Declare visibility on class properties of SpecialRevisionDelete

[lhc/web/wiklou.git] / includes / actions / CreditsAction.php

diff --git a/includes/actions/CreditsAction.php b/includes/actions/CreditsAction.php
index 4d3c41b..97c1605 100644 (file)
--- a/includes/actions/CreditsAction.php
+++ b/includes/actions/CreditsAction.php
@@ -74,26 +74,28 @@ class CreditsAction extends FormlessAction {
                }
 
                wfProfileOut( __METHOD__ );
+
                return $s;
        }
 
        /**
         * Get the last author with the last modification time
-        * @param $article Article object
+        * @param Page $page
         * @return String HTML
         */
-       protected function getAuthor( Page $article ) {
-               $user = User::newFromName( $article->getUserText(), false );
+       protected function getAuthor( Page $page ) {
+               $user = User::newFromName( $page->getUserText(), false );
 
-               $timestamp = $article->getTimestamp();
+               $timestamp = $page->getTimestamp();
                if ( $timestamp ) {
                        $lang = $this->getLanguage();
-                       $d = $lang->date( $article->getTimestamp(), true );
-                       $t = $lang->time( $article->getTimestamp(), true );
+                       $d = $lang->date( $page->getTimestamp(), true );
+                       $t = $lang->time( $page->getTimestamp(), true );
                } else {
                        $d = '';
                        $t = '';
                }
+
                return $this->msg( 'lastmodifiedatby', $d, $t )->rawParams(
                        $this->userLink( $user ) )->params( $user->getName() )->escaped();
        }
@@ -114,9 +116,10 @@ class CreditsAction extends FormlessAction {
                # Hmm... too many to fit!
                if ( $cnt > 0 && $contributors->count() > $cnt ) {
                        $others_link = $this->othersLink();
-                       if ( !$showIfMax )
+                       if ( !$showIfMax ) {
                                return $this->msg( 'othercontribs' )->rawParams(
                                        $others_link )->params( $contributors->count() )->escaped();
+                       }
                }
 
                $real_names = array();
@@ -124,6 +127,7 @@ class CreditsAction extends FormlessAction {
                $anon_ips = array();
 
                # Sift for real versus user names
+               /** @var $user User */
                foreach ( $contributors as $user ) {
                        $cnt--;
                        if ( $user->isLoggedIn() ) {
@@ -174,6 +178,7 @@ class CreditsAction extends FormlessAction {
                }
 
                $count = count( $fulllist );
+
                # "Based on work by ..."
                return $count
                        ? $this->msg( 'othercontribs' )->rawParams(