Kill some trailing whitespace
[lhc/web/wiklou.git] / includes / User.php
index 9aed0bf..8cdad6c 100644 (file)
 /**
  * See user.txt
  *
- * @package MediaWiki
  */
 
 # Number of characters in user_token field
 define( 'USER_TOKEN_LENGTH', 32 );
 
 # Serialized record version
-define( 'MW_USER_VERSION', 3 );
+define( 'MW_USER_VERSION', 5 );
+
+# Some punctuation to prevent editing from broken text-mangling proxies.
+# FIXME: this is embedded unescaped into HTML attributes in various
+# places, so we can't safely include ' or " even though we really should.
+define( 'EDIT_TOKEN_SUFFIX', '\\' );
+
+/**
+ * Thrown by User::setPassword() on error
+ */
+class PasswordError extends MWException {
+       // NOP
+}
 
 /**
  *
- * @package MediaWiki
  */
 class User {
-       /*
-        * When adding a new private variable, dont forget to add it to __sleep()
+
+       /**
+        * A list of default user toggles, i.e. boolean user preferences that are 
+        * displayed by Special:Preferences as checkboxes. This list can be 
+        * extended via the UserToggles hook or $wgContLang->getExtraUserToggles().
+        */
+       static public $mToggles = array(
+               'highlightbroken',
+               'justify',
+               'hideminor',
+               'extendwatchlist',
+               'usenewrc',
+               'numberheadings',
+               'showtoolbar',
+               'editondblclick',
+               'editsection',
+               'editsectiononrightclick',
+               'showtoc',
+               'rememberpassword',
+               'editwidth',
+               'watchcreations',
+               'watchdefault',
+               'watchmoves',
+               'watchdeletion',
+               'minordefault',
+               'previewontop',
+               'previewonfirst',
+               'nocache',
+               'enotifwatchlistpages',
+               'enotifusertalkpages',
+               'enotifminoredits',
+               'enotifrevealaddr',
+               'shownumberswatching',
+               'fancysig',
+               'externaleditor',
+               'externaldiff',
+               'showjumplinks',
+               'uselivepreview',
+               'forceeditsummary',
+               'watchlisthideown',
+               'watchlisthidebots',
+               'watchlisthideminor',
+               'ccmeonemails',
+               'diffonly',
+       );
+
+       /**
+        * List of member variables which are saved to the shared cache (memcached).
+        * Any operation which changes the corresponding database fields must 
+        * call a cache-clearing function.
+        */
+       static $mCacheVars = array(
+               # user table
+               'mId',
+               'mName',
+               'mRealName',
+               'mPassword',
+               'mNewpassword',
+               'mNewpassTime',
+               'mEmail',
+               'mOptions',
+               'mTouched',
+               'mToken',
+               'mEmailAuthenticated',
+               'mEmailToken',
+               'mEmailTokenExpires',
+               'mRegistration',
+               'mEditCount',
+               # user_group table
+               'mGroups',
+       );
+
+       /**
+        * The cache variable declarations
+        */
+       var $mId, $mName, $mRealName, $mPassword, $mNewpassword, $mNewpassTime, 
+               $mEmail, $mOptions, $mTouched, $mToken, $mEmailAuthenticated, 
+               $mEmailToken, $mEmailTokenExpires, $mRegistration, $mGroups;
+
+       /**
+        * Whether the cache variables have been loaded
+        */
+       var $mDataLoaded;
+
+       /**
+        * Initialisation data source if mDataLoaded==false. May be one of:
+        *    defaults      anonymous user initialised from class defaults
+        *    name          initialise from mName
+        *    id            initialise from mId
+        *    session       log in from cookies or session if possible
+        *
+        * Use the User::newFrom*() family of functions to set this.
         */
-       /**@{{
-        * @private
+       var $mFrom;
+
+       /**
+        * Lazy-initialised variables, invalidated with clearInstanceCache
         */
-       var $mBlockedby;        //!<
-       var $mBlockreason;      //!<
-       var $mDataLoaded;       //!<
-       var $mEmail;            //!<
-       var $mEmailAuthenticated; //!<
-       var $mGroups;           //!<
-       var $mHash;                     //!<
-       var $mId;                       //!<
-       var $mName;                     //!<
-       var $mNewpassword;      //!<
-       var $mNewtalk;          //!<
-       var $mOptions;          //!<
-       var $mPassword;         //!<
-       var $mRealName;         //!<
-       var $mRegistration;     //!<
-       var $mRights;           //!<
-       var $mSkin;                     //!<
-       var $mToken;            //!<
-       var $mTouched;          //!<
-       var $mVersion;          //!< serialized version
-       /**@}} */
-
-       /** Constructor using User:loadDefaults() */
-       function User() {
-               $this->loadDefaults();
-               $this->mVersion = MW_USER_VERSION;
-       }
-
-       /**
-        * Static factory method
-        * @param string $name Username, validated by Title:newFromText()
-        * @param bool $validate Validate username
-        * @return User
-        * @static
+       var $mNewtalk, $mDatePreference, $mBlockedby, $mHash, $mSkin, $mRights,
+               $mBlockreason, $mBlock, $mEffectiveGroups;
+
+       /** 
+        * Lightweight constructor for anonymous user
+        * Use the User::newFrom* factory functions for other kinds of users
         */
-       function newFromName( $name, $validate = true ) {
-               # Force usernames to capital
-               global $wgContLang;
-               $name = $wgContLang->ucfirst( $name );
+       function User() {
+               $this->clearInstanceCache( 'defaults' );
+       }
 
-               # Clean up name according to title rules
-               $t = Title::newFromText( $name );
-               if( is_null( $t ) ) {
-                       return null;
+       /**
+        * Load the user table data for this object from the source given by mFrom
+        */
+       function load() {
+               if ( $this->mDataLoaded ) {
+                       return;
                }
+               wfProfileIn( __METHOD__ );
 
-               # Reject various classes of invalid names
-               $canonicalName = $t->getText();
-               global $wgAuth;
-               $canonicalName = $wgAuth->getCanonicalName( $t->getText() );
+               # Set it now to avoid infinite recursion in accessors
+               $this->mDataLoaded = true;
+
+               switch ( $this->mFrom ) {
+                       case 'defaults':
+                               $this->loadDefaults();
+                               break;
+                       case 'name':
+                               $this->mId = self::idFromName( $this->mName );
+                               if ( !$this->mId ) {
+                                       # Nonexistent user placeholder object
+                                       $this->loadDefaults( $this->mName );
+                               } else {
+                                       $this->loadFromId();
+                               }
+                               break;
+                       case 'id':
+                               $this->loadFromId();
+                               break;
+                       case 'session':
+                               $this->loadFromSession();
+                               break;
+                       default:
+                               throw new MWException( "Unrecognised value for User->mFrom: \"{$this->mFrom}\"" );
+               }
+               wfProfileOut( __METHOD__ );
+       }
+
+       /**
+        * Load user table data given mId
+        * @return false if the ID does not exist, true otherwise
+        * @private
+        */
+       function loadFromId() {
+               global $wgMemc;
+               if ( $this->mId == 0 ) {
+                       $this->loadDefaults();
+                       return false;
+               } 
+
+               # Try cache
+               $key = wfMemcKey( 'user', 'id', $this->mId );
+               $data = $wgMemc->get( $key );
+               if ( !is_array( $data ) || $data['mVersion'] < MW_USER_VERSION ) {
+                       # Object is expired, load from DB
+                       $data = false;
+               }
+               
+               if ( !$data ) {
+                       wfDebug( "Cache miss for user {$this->mId}\n" );
+                       # Load from DB
+                       if ( !$this->loadFromDatabase() ) {
+                               # Can't load from ID, user is anonymous
+                               return false;
+                       }
 
-               if( $validate && !User::isValidUserName( $canonicalName ) ) {
+                       # Save to cache
+                       $data = array();
+                       foreach ( self::$mCacheVars as $name ) {
+                               $data[$name] = $this->$name;
+                       }
+                       $data['mVersion'] = MW_USER_VERSION;
+                       $wgMemc->set( $key, $data );
+               } else {
+                       wfDebug( "Got user {$this->mId} from cache\n" );
+                       # Restore from cache
+                       foreach ( self::$mCacheVars as $name ) {
+                               $this->$name = $data[$name];
+                       }
+               }
+               return true;
+       }
+
+       /**
+        * Static factory method for creation from username.
+        *
+        * This is slightly less efficient than newFromId(), so use newFromId() if
+        * you have both an ID and a name handy. 
+        *
+        * @param string $name Username, validated by Title:newFromText()
+        * @param mixed $validate Validate username. Takes the same parameters as 
+        *    User::getCanonicalName(), except that true is accepted as an alias 
+        *    for 'valid', for BC.
+        * 
+        * @return User object, or null if the username is invalid. If the username 
+        *    is not present in the database, the result will be a user object with
+        *    a name, zero user ID and default settings. 
+        * @static
+        */
+       static function newFromName( $name, $validate = 'valid' ) {
+               if ( $validate === true ) {
+                       $validate = 'valid';
+               }
+               $name = self::getCanonicalName( $name, $validate );
+               if ( $name === false ) {
                        return null;
+               } else {
+                       # Create unloaded user object
+                       $u = new User;
+                       $u->mName = $name;
+                       $u->mFrom = 'name';
+                       return $u;
                }
+       }
 
-               $u = new User();
-               $u->setName( $canonicalName );
-               $u->setId( $u->idFromName( $canonicalName ) );
+       static function newFromId( $id ) {
+               $u = new User;
+               $u->mId = $id;
+               $u->mFrom = 'id';
                return $u;
        }
 
        /**
-        * Factory method to fetch whichever use has a given email confirmation code.
+        * Factory method to fetch whichever user has a given email confirmation code.
         * This code is generated when an account is created or its e-mail address
         * has changed.
         *
@@ -94,46 +267,30 @@ class User {
         * @return User
         * @static
         */
-       function newFromConfirmationCode( $code ) {
-               $dbr =& wfGetDB( DB_SLAVE );
-               $name = $dbr->selectField( 'user', 'user_name', array(
+       static function newFromConfirmationCode( $code ) {
+               $dbr = wfGetDB( DB_SLAVE );
+               $id = $dbr->selectField( 'user', 'user_id', array(
                        'user_email_token' => md5( $code ),
                        'user_email_token_expires > ' . $dbr->addQuotes( $dbr->timestamp() ),
                        ) );
-               if( is_string( $name ) ) {
-                       return User::newFromName( $name );
+               if( $id !== false ) {
+                       return User::newFromId( $id );
                } else {
                        return null;
                }
        }
-
+       
        /**
-        * Serialze sleep function, for better cache efficiency and avoidance of
-        * silly "incomplete type" errors when skins are cached. The array should
-        * contain names of private variables (see at top of User.php).
+        * Create a new user object using data from session or cookies. If the
+        * login credentials are invalid, the result is an anonymous user.
+        *
+        * @return User
+        * @static
         */
-       function __sleep() {
-               return array(
-'mBlockedby',
-'mBlockreason',
-'mDataLoaded',
-'mEmail',
-'mEmailAuthenticated',
-'mGroups',
-'mHash',
-'mId',
-'mName',
-'mNewpassword',
-'mNewtalk',
-'mOptions',
-'mPassword',
-'mRealName',
-'mRegistration',
-'mRights',
-'mToken',
-'mTouched',
-'mVersion',
-);
+       static function newFromSession() {
+               $user = new User;
+               $user->mFrom = 'session';
+               return $user;
        }
 
        /**
@@ -142,8 +299,8 @@ class User {
         * @return string Nickname of a user
         * @static
         */
-       function whoIs( $id )   {
-               $dbr =& wfGetDB( DB_SLAVE );
+       static function whoIs( $id ) {
+               $dbr = wfGetDB( DB_SLAVE );
                return $dbr->selectField( 'user', 'user_name', array( 'user_id' => $id ), 'User::whoIs' );
        }
 
@@ -153,8 +310,8 @@ class User {
         * @return string Realname of a user
         * @static
         */
-       function whoIsReal( $id )       {
-               $dbr =& wfGetDB( DB_SLAVE );
+       static function whoIsReal( $id ) {
+               $dbr = wfGetDB( DB_SLAVE );
                return $dbr->selectField( 'user', 'user_real_name', array( 'user_id' => $id ), 'User::whoIsReal' );
        }
 
@@ -164,16 +321,14 @@ class User {
         * @return integer|null Database user id (null: if non existent
         * @static
         */
-       function idFromName( $name ) {
-               $fname = "User::idFromName";
-
+       static function idFromName( $name ) {
                $nt = Title::newFromText( $name );
                if( is_null( $nt ) ) {
                        # Illegal name
                        return null;
                }
-               $dbr =& wfGetDB( DB_SLAVE );
-               $s = $dbr->selectRow( 'user', array( 'user_id' ), array( 'user_name' => $nt->getText() ), $fname );
+               $dbr = wfGetDB( DB_SLAVE );
+               $s = $dbr->selectRow( 'user', array( 'user_id' ), array( 'user_name' => $nt->getText() ), __METHOD__ );
 
                if ( $s === false ) {
                        return 0;
@@ -195,14 +350,12 @@ class User {
         * addresses like this, if we allowed accounts like this to be created
         * new users could get the old edits of these anonymous users.
         *
-        * @bug 3631
-        *
         * @static
         * @param string $name Nickname of a user
         * @return bool
         */
-       function isIP( $name ) {
-               return preg_match("/^\d{1,3}\.\d{1,3}\.\d{1,3}\.(?:xxx|\d{1,3})$/",$name);
+       static function isIP( $name ) {
+               return preg_match('/^\d{1,3}\.\d{1,3}\.\d{1,3}\.(?:xxx|\d{1,3})$/',$name) || User::isIPv6($name);
                /*return preg_match("/^
                        (?:[01]?\d{1,2}|2(:?[0-4]\d|5[0-5]))\.
                        (?:[01]?\d{1,2}|2(:?[0-4]\d|5[0-5]))\.
@@ -211,6 +364,27 @@ class User {
                $/x", $name);*/
        }
 
+       /**
+        * Check if $name is an IPv6 IP.
+        */
+       static function isIPv6($name) {
+               /* 
+                * if it has any non-valid characters, it can't be a valid IPv6  
+                * address.
+                */
+               if (preg_match("/[^:a-fA-F0-9]/", $name))
+                       return false;
+
+               $parts = explode(":", $name);
+               if (count($parts) < 3)
+                       return false;
+               foreach ($parts as $part) {
+                       if (!preg_match("/^[0-9a-fA-F]{0,4}$/", $part))
+                               return false;
+               }
+               return true;
+       }
+
        /**
         * Is the input a valid username?
         *
@@ -223,7 +397,7 @@ class User {
         * @return bool
         * @static
         */
-       function isValidUserName( $name ) {
+       static function isValidUserName( $name ) {
                global $wgContLang, $wgMaxNameChars;
 
                if ( $name == ''
@@ -257,6 +431,48 @@ class User {
                
                return true;
        }
+       
+       /**
+        * Usernames which fail to pass this function will be blocked
+        * from user login and new account registrations, but may be used
+        * internally by batch processes.
+        *
+        * If an account already exists in this form, login will be blocked
+        * by a failure to pass this function.
+        *
+        * @param string $name
+        * @return bool
+        */
+       static function isUsableName( $name ) {
+               global $wgReservedUsernames;
+               return
+                       // Must be a usable username, obviously ;)
+                       self::isValidUserName( $name ) &&
+                       
+                       // Certain names may be reserved for batch processes.
+                       !in_array( $name, $wgReservedUsernames );
+       }
+       
+       /**
+        * Usernames which fail to pass this function will be blocked
+        * from new account registrations, but may be used internally
+        * either by batch processes or by user accounts which have
+        * already been created.
+        *
+        * Additional character blacklisting may be added here
+        * rather than in isValidUserName() to avoid disrupting
+        * existing accounts.
+        *
+        * @param string $name
+        * @return bool
+        */
+       static function isCreatableName( $name ) {
+               return
+                       self::isUsableName( $name ) &&
+                       
+                       // Registration-time character blacklisting...
+                       strpos( $name, '@' ) === false;
+       }
 
        /**
         * Is the input a valid password?
@@ -265,9 +481,13 @@ class User {
         * @return bool
         * @static
         */
-       function isValidPassword( $password ) {
+       static function isValidPassword( $password ) {
                global $wgMinimalPasswordLength;
-               return strlen( $password ) >= $wgMinimalPasswordLength;
+
+               $result = null;
+               if( !wfRunHooks( 'isValidPassword', array( $password, &$result ) ) ) return $result;
+               if ($result === false) return false; 
+               return (strlen( $password ) >= $wgMinimalPasswordLength);
        }
 
        /**
@@ -277,42 +497,114 @@ class User {
         * rejected valid addresses. Actually just check if there is '@' somewhere
         * in the given address.
         *
-        * @todo Check for RFC 2822 compilance
-        * @bug 959
+        * @todo Check for RFC 2822 compilance (bug 959)
         *
         * @param string $addr email address
         * @static
         * @return bool
         */
-       function isValidEmailAddr ( $addr ) {
+       static function isValidEmailAddr ( $addr ) {
                return ( trim( $addr ) != '' ) &&
                        (false !== strpos( $addr, '@' ) );
        }
 
+       /**
+        * Given unvalidated user input, return a canonical username, or false if 
+        * the username is invalid.
+        * @param string $name
+        * @param mixed $validate Type of validation to use:
+        *                         false        No validation
+        *                         'valid'      Valid for batch processes
+        *                         'usable'     Valid for batch processes and login
+        *                         'creatable'  Valid for batch processes, login and account creation
+        */
+       static function getCanonicalName( $name, $validate = 'valid' ) {
+               # Force usernames to capital
+               global $wgContLang;
+               $name = $wgContLang->ucfirst( $name );
+
+               # Clean up name according to title rules
+               $t = Title::newFromText( $name );
+               if( is_null( $t ) ) {
+                       return false;
+               }
+
+               # Reject various classes of invalid names
+               $name = $t->getText();
+               global $wgAuth;
+               $name = $wgAuth->getCanonicalName( $t->getText() );
+
+               switch ( $validate ) {
+                       case false:
+                               break;
+                       case 'valid':
+                               if ( !User::isValidUserName( $name ) ) {
+                                       $name = false;
+                               }
+                               break;
+                       case 'usable':
+                               if ( !User::isUsableName( $name ) ) {
+                                       $name = false;
+                               }
+                               break;
+                       case 'creatable':
+                               if ( !User::isCreatableName( $name ) ) {
+                                       $name = false;
+                               }
+                               break;
+                       default:
+                               throw new MWException( 'Invalid parameter value for $validate in '.__METHOD__ );
+               }
+               return $name;
+       }
+
        /**
         * Count the number of edits of a user
         *
+        * It should not be static and some day should be merged as proper member function / deprecated -- domas
+        * 
         * @param int $uid The user ID to check
         * @return int
+        * @static
         */
-       function edits( $uid ) {
-               $fname = 'User::edits';
-
-               $dbr =& wfGetDB( DB_SLAVE );
-               return $dbr->selectField(
-                       'revision', 'count(*)',
-                       array( 'rev_user' => $uid ),
-                       $fname
+       static function edits( $uid ) {
+               wfProfileIn( __METHOD__ );
+               $dbr = wfGetDB( DB_SLAVE );
+               // check if the user_editcount field has been initialized
+               $field = $dbr->selectField(
+                       'user', 'user_editcount',
+                       array( 'user_id' => $uid ),
+                       __METHOD__
                );
+
+               if( $field === null ) { // it has not been initialized. do so.
+                       $dbw = wfGetDb( DB_MASTER );
+                       $count = $dbr->selectField(
+                               'revision', 'count(*)',
+                               array( 'rev_user' => $uid ),
+                               __METHOD__
+                       );
+                       $dbw->update(
+                               'user',
+                               array( 'user_editcount' => $count ),
+                               array( 'user_id' => $uid ),
+                               __METHOD__
+                       );
+               } else {
+                       $count = $field;
+               }
+               wfProfileOut( __METHOD__ );
+               return $count;
        }
 
        /**
-        * probably return a random password
-        * @return string probably a random password
+        * Return a random password. Sourced from mt_rand, so it's not particularly secure.
+        * @todo hash random numbers to improve security, like generateToken()
+        *
+        * @return string
         * @static
-        * @todo Check what is doing really [AV]
         */
-       function randomPassword() {
+       static function randomPassword() {
                global $wgMinimalPasswordLength;
                $pwchars = 'ABCDEFGHJKLMNPQRSTUVWXYZabcdefghjkmnpqrstuvwxyz';
                $l = strlen( $pwchars ) - 1;
@@ -327,72 +619,215 @@ class User {
        }
 
        /**
-        * Set properties to default
-        * Used at construction. It will load per language default settings only
-        * if we have an available language object.
+        * Set cached properties to default. Note: this no longer clears 
+        * uncached lazy-initialised properties. The constructor does that instead.
+        *
+        * @private
         */
-       function loadDefaults() {
-               static $n=0;
-               $n++;
-               $fname = 'User::loadDefaults' . $n;
-               wfProfileIn( $fname );
+       function loadDefaults( $name = false ) {
+               wfProfileIn( __METHOD__ );
 
                global $wgCookiePrefix;
-               global $wgNamespacesToBeSearchedDefault;
 
                $this->mId = 0;
-               $this->mNewtalk = -1;
-               $this->mName = false;
-               $this->mRealName = $this->mEmail = '';
-               $this->mEmailAuthenticated = null;
+               $this->mName = $name;
+               $this->mRealName = '';
                $this->mPassword = $this->mNewpassword = '';
-               $this->mRights = array();
-               $this->mGroups = array();
-               $this->mOptions = User::getDefaultOptions();
-
-               foreach( $wgNamespacesToBeSearchedDefault as $nsnum => $val ) {
-                       $this->mOptions['searchNs'.$nsnum] = $val;
-               }
-               unset( $this->mSkin );
-               $this->mDataLoaded = false;
-               $this->mBlockedby = -1; # Unset
-               $this->setToken(); # Random
-               $this->mHash = false;
+               $this->mNewpassTime = null;
+               $this->mEmail = '';
+               $this->mOptions = null; # Defer init
 
                if ( isset( $_COOKIE[$wgCookiePrefix.'LoggedOut'] ) ) {
                        $this->mTouched = wfTimestamp( TS_MW, $_COOKIE[$wgCookiePrefix.'LoggedOut'] );
-               }
-               else {
+               } else {
                        $this->mTouched = '0'; # Allow any pages to be cached
                }
 
+               $this->setToken(); # Random
+               $this->mEmailAuthenticated = null;
+               $this->mEmailToken = '';
+               $this->mEmailTokenExpires = null;
                $this->mRegistration = wfTimestamp( TS_MW );
+               $this->mGroups = array();
+
+               wfProfileOut( __METHOD__ );
+       }
+       
+       /**
+        * Initialise php session
+        * @deprecated use wfSetupSession()
+        */
+       function SetupSession() {
+               wfSetupSession();
+       }
+
+       /**
+        * Load user data from the session or login cookie. If there are no valid
+        * credentials, initialises the user as an anon.
+        * @return true if the user is logged in, false otherwise
+        * 
+        * @private
+        */
+       function loadFromSession() {
+               global $wgMemc, $wgCookiePrefix;
+
+               if ( isset( $_SESSION['wsUserID'] ) ) {
+                       if ( 0 != $_SESSION['wsUserID'] ) {
+                               $sId = $_SESSION['wsUserID'];
+                       } else {
+                               $this->loadDefaults();
+                               return false;
+                       }
+               } else if ( isset( $_COOKIE["{$wgCookiePrefix}UserID"] ) ) {
+                       $sId = intval( $_COOKIE["{$wgCookiePrefix}UserID"] );
+                       $_SESSION['wsUserID'] = $sId;
+               } else {
+                       $this->loadDefaults();
+                       return false;
+               }
+               if ( isset( $_SESSION['wsUserName'] ) ) {
+                       $sName = $_SESSION['wsUserName'];
+               } else if ( isset( $_COOKIE["{$wgCookiePrefix}UserName"] ) ) {
+                       $sName = $_COOKIE["{$wgCookiePrefix}UserName"];
+                       $_SESSION['wsUserName'] = $sName;
+               } else {
+                       $this->loadDefaults();
+                       return false;
+               }
+
+               $passwordCorrect = FALSE;
+               $this->mId = $sId;
+               if ( !$this->loadFromId() ) {
+                       # Not a valid ID, loadFromId has switched the object to anon for us
+                       return false;
+               }
+               
+               if ( isset( $_SESSION['wsToken'] ) ) {
+                       $passwordCorrect = $_SESSION['wsToken'] == $this->mToken;
+                       $from = 'session';
+               } else if ( isset( $_COOKIE["{$wgCookiePrefix}Token"] ) ) {
+                       $passwordCorrect = $this->mToken == $_COOKIE["{$wgCookiePrefix}Token"];
+                       $from = 'cookie';
+               } else {
+                       # No session or persistent login cookie
+                       $this->loadDefaults();
+                       return false;
+               }
+
+               if ( ( $sName == $this->mName ) && $passwordCorrect ) {
+                       wfDebug( "Logged in from $from\n" );
+                       return true;
+               } else {
+                       # Invalid credentials
+                       wfDebug( "Can't log in from $from, invalid credentials\n" );
+                       $this->loadDefaults();
+                       return false;
+               }
+       }
+       
+       /**
+        * Load user and user_group data from the database
+        * $this->mId must be set, this is how the user is identified.
+        * 
+        * @return true if the user exists, false if the user is anonymous
+        * @private
+        */
+       function loadFromDatabase() {
+               # Paranoia
+               $this->mId = intval( $this->mId );
+
+               /** Anonymous user */
+               if( !$this->mId ) {
+                       $this->loadDefaults();
+                       return false;
+               }
+
+               $dbr = wfGetDB( DB_MASTER );
+               $s = $dbr->selectRow( 'user', '*', array( 'user_id' => $this->mId ), __METHOD__ );
+
+               if ( $s !== false ) {
+                       # Initialise user table data
+                       $this->mName = $s->user_name;
+                       $this->mRealName = $s->user_real_name;
+                       $this->mPassword = $s->user_password;
+                       $this->mNewpassword = $s->user_newpassword;
+                       $this->mNewpassTime = wfTimestampOrNull( TS_MW, $s->user_newpass_time );
+                       $this->mEmail = $s->user_email;
+                       $this->decodeOptions( $s->user_options );
+                       $this->mTouched = wfTimestamp(TS_MW,$s->user_touched);
+                       $this->mToken = $s->user_token;
+                       $this->mEmailAuthenticated = wfTimestampOrNull( TS_MW, $s->user_email_authenticated );
+                       $this->mEmailToken = $s->user_email_token;
+                       $this->mEmailTokenExpires = wfTimestampOrNull( TS_MW, $s->user_email_token_expires );
+                       $this->mRegistration = wfTimestampOrNull( TS_MW, $s->user_registration );
+                       $this->mEditCount = $s->user_editcount; 
+                       $this->getEditCount(); // revalidation for nulls
+
+                       # Load group data
+                       $res = $dbr->select( 'user_groups',
+                               array( 'ug_group' ),
+                               array( 'ug_user' => $this->mId ),
+                               __METHOD__ );
+                       $this->mGroups = array();
+                       while( $row = $dbr->fetchObject( $res ) ) {
+                               $this->mGroups[] = $row->ug_group;
+                       }
+                       return true;
+               } else {
+                       # Invalid user_id
+                       $this->mId = 0;
+                       $this->loadDefaults();
+                       return false;
+               }
+       }
+
+       /**
+        * Clear various cached data stored in this object. 
+        * @param string $reloadFrom Reload user and user_groups table data from a 
+        *   given source. May be "name", "id", "defaults", "session" or false for 
+        *   no reload.
+        */
+       function clearInstanceCache( $reloadFrom = false ) {
+               $this->mNewtalk = -1;
+               $this->mDatePreference = null;
+               $this->mBlockedby = -1; # Unset
+               $this->mHash = false;
+               $this->mSkin = null;
+               $this->mRights = null;
+               $this->mEffectiveGroups = null;
 
-               wfProfileOut( $fname );
+               if ( $reloadFrom ) {
+                       $this->mDataLoaded = false;
+                       $this->mFrom = $reloadFrom;
+               }
        }
 
        /**
         * Combine the language default options with any site-specific options
         * and add the default language variants.
-        *
+        * Not really private cause it's called by Language class
         * @return array
         * @static
         * @private
         */
-       function getDefaultOptions() {
+       static function getDefaultOptions() {
+               global $wgNamespacesToBeSearchedDefault;
                /**
                 * Site defaults will override the global/language defaults
                 */
-               global $wgContLang, $wgDefaultUserOptions;
-               $defOpt = $wgDefaultUserOptions + $wgContLang->getDefaultUserOptions();
+               global $wgDefaultUserOptions, $wgContLang;
+               $defOpt = $wgDefaultUserOptions + $wgContLang->getDefaultUserOptionOverrides();
 
                /**
                 * default language setting
                 */
-               $variant = $wgContLang->getPreferredVariant();
+               $variant = $wgContLang->getPreferredVariant( false );
                $defOpt['variant'] = $variant;
                $defOpt['language'] = $variant;
 
+               foreach( $wgNamespacesToBeSearchedDefault as $nsnum => $val ) {
+                       $defOpt['searchNs'.$nsnum] = $val;
+               }
                return $defOpt;
        }
 
@@ -413,6 +848,18 @@ class User {
                }
        }
 
+       /**
+        * Get a list of user toggle names
+        * @return array
+        */
+       static function getToggles() {
+               global $wgContLang;
+               $extraToggles = array();
+               wfRunHooks( 'UserToggles', array( &$extraToggles ) );
+               return array_merge( self::$mToggles, $extraToggles, $wgContLang->getExtraUserToggles() );
+       }
+
+
        /**
         * Get blocking information
         * @private
@@ -428,29 +875,35 @@ class User {
                        return;
                }
 
-               $fname = 'User::getBlockedStatus';
-               wfProfileIn( $fname );
-               wfDebug( "$fname: checking...\n" );
+               wfProfileIn( __METHOD__ );
+               wfDebug( __METHOD__.": checking...\n" );
 
-               $this->mBlockedby = 0;
+               $this->mBlockedby = 0; 
+               $this->mHideName = 0;
                $ip = wfGetIP();
 
+               if ($this->isAllowed( 'ipblock-exempt' ) ) {
+                       # Exempt from all types of IP-block
+                       $ip = '';
+               }
+
                # User/IP blocking
-               $block = new Block();
-               $block->fromMaster( !$bFromSlave );
-               if ( $block->load( $ip , $this->mId ) ) {
-                       wfDebug( "$fname: Found block.\n" );
-                       $this->mBlockedby = $block->mBy;
-                       $this->mBlockreason = $block->mReason;
+               $this->mBlock = new Block();
+               $this->mBlock->fromMaster( !$bFromSlave );
+               if ( $this->mBlock->load( $ip , $this->mId ) ) {
+                       wfDebug( __METHOD__.": Found block.\n" );
+                       $this->mBlockedby = $this->mBlock->mBy;
+                       $this->mBlockreason = $this->mBlock->mReason;
+                       $this->mHideName = $this->mBlock->mHideName;
                        if ( $this->isLoggedIn() ) {
                                $this->spreadBlock();
                        }
                } else {
-                       wfDebug( "$fname: No block.\n" );
+                       $this->mBlock = null;
+                       wfDebug( __METHOD__.": No block.\n" );
                }
 
                # Proxy blocking
-               # FIXME ? proxyunbannable is to deprecate the old isSysop()
                if ( !$this->isAllowed('proxyunbannable') && !in_array( $ip, $wgProxyWhitelist ) ) {
 
                        # Local list
@@ -471,22 +924,23 @@ class User {
                # Extensions
                wfRunHooks( 'GetBlockedStatus', array( &$this ) );
 
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
        }
 
        function inSorbsBlacklist( $ip ) {
-               global $wgEnableSorbs;
+               global $wgEnableSorbs, $wgSorbsUrl;
+
                return $wgEnableSorbs &&
-                       $this->inDnsBlacklist( $ip, 'http.dnsbl.sorbs.net.' );
+                       $this->inDnsBlacklist( $ip, $wgSorbsUrl );
        }
 
        function inDnsBlacklist( $ip, $base ) {
-               $fname = 'User::inDnsBlacklist';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
 
                $found = false;
                $host = '';
 
+               $m = array();
                if ( preg_match( '/^(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})$/', $ip, $m ) ) {
                        # Make hostname
                        for ( $i=4; $i>=1; $i-- ) {
@@ -505,10 +959,20 @@ class User {
                        }
                }
 
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return $found;
        }
 
+       /**
+        * Is this user subject to rate limiting?
+        *
+        * @return bool
+        */
+       public function isPingLimitable() {
+               global $wgRateLimitsExcludedGroups;
+               return array_intersect($this->getEffectiveGroups(), $wgRateLimitsExcludedGroups) != array();
+       }
+
        /**
         * Primitive rate limits: enforce maximum actions per time period
         * to put a brake on flooding.
@@ -520,20 +984,24 @@ class User {
         * @public
         */
        function pingLimiter( $action='edit' ) {
+
+               # Call the 'PingLimiter' hook
+               $result = false;
+               if( !wfRunHooks( 'PingLimiter', array( &$this, $action, $result ) ) ) {
+                       return $result;
+               }
+
                global $wgRateLimits, $wgRateLimitsExcludedGroups;
                if( !isset( $wgRateLimits[$action] ) ) {
                        return false;
                }
-               
+
                # Some groups shouldn't trigger the ping limiter, ever
-               foreach( $this->getGroups() as $group ) {
-                       if( array_search( $group, $wgRateLimitsExcludedGroups ) !== false )
-                               return false;
-               }
-               
-               global $wgMemc, $wgDBname, $wgRateLimitLog;
-               $fname = 'User::pingLimiter';
-               wfProfileIn( $fname );
+               if( !$this->isPingLimitable() )
+                       return false;
+
+               global $wgMemc, $wgRateLimitLog;
+               wfProfileIn( __METHOD__ );
 
                $limits = $wgRateLimits[$action];
                $keys = array();
@@ -541,19 +1009,20 @@ class User {
                $ip = wfGetIP();
 
                if( isset( $limits['anon'] ) && $id == 0 ) {
-                       $keys["$wgDBname:limiter:$action:anon"] = $limits['anon'];
+                       $keys[wfMemcKey( 'limiter', $action, 'anon' )] = $limits['anon'];
                }
 
                if( isset( $limits['user'] ) && $id != 0 ) {
-                       $keys["$wgDBname:limiter:$action:user:$id"] = $limits['user'];
+                       $keys[wfMemcKey( 'limiter', $action, 'user', $id )] = $limits['user'];
                }
                if( $this->isNewbie() ) {
                        if( isset( $limits['newbie'] ) && $id != 0 ) {
-                               $keys["$wgDBname:limiter:$action:user:$id"] = $limits['newbie'];
+                               $keys[wfMemcKey( 'limiter', $action, 'user', $id )] = $limits['newbie'];
                        }
                        if( isset( $limits['ip'] ) ) {
                                $keys["mediawiki:limiter:$action:ip:$ip"] = $limits['ip'];
                        }
+                       $matches = array();
                        if( isset( $limits['subnet'] ) && preg_match( '/^(\d+\.\d+\.\d+)\.\d+$/', $ip, $matches ) ) {
                                $subnet = $matches[1];
                                $keys["mediawiki:limiter:$action:subnet:$subnet"] = $limits['subnet'];
@@ -567,22 +1036,22 @@ class User {
                        $count = $wgMemc->get( $key );
                        if( $count ) {
                                if( $count > $max ) {
-                                       wfDebug( "$fname: tripped! $key at $count $summary\n" );
+                                       wfDebug( __METHOD__.": tripped! $key at $count $summary\n" );
                                        if( $wgRateLimitLog ) {
-                                               @error_log( wfTimestamp( TS_MW ) . ' ' . $wgDBname . ': ' . $this->getName() . " tripped $key at $count $summary\n", 3, $wgRateLimitLog );
+                                               @error_log( wfTimestamp( TS_MW ) . ' ' . wfWikiID() . ': ' . $this->getName() . " tripped $key at $count $summary\n", 3, $wgRateLimitLog );
                                        }
                                        $triggered = true;
                                } else {
-                                       wfDebug( "$fname: ok. $key at $count $summary\n" );
+                                       wfDebug( __METHOD__.": ok. $key at $count $summary\n" );
                                }
                        } else {
-                               wfDebug( "$fname: adding record for $key $summary\n" );
+                               wfDebug( __METHOD__.": adding record for $key $summary\n" );
                                $wgMemc->add( $key, 1, intval( $period ) );
                        }
                        $wgMemc->incr( $key );
                }
 
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return $triggered;
        }
 
@@ -593,214 +1062,98 @@ class User {
        function isBlocked( $bFromSlave = true ) { // hacked from false due to horrible probs on site
                wfDebug( "User::isBlocked: enter\n" );
                $this->getBlockedStatus( $bFromSlave );
-               return $this->mBlockedby !== 0;
-       }
-
-       /**
-        * Check if user is blocked from editing a particular article
-        */
-       function isBlockedFrom( $title, $bFromSlave = false ) {
-               global $wgBlockAllowsUTEdit;
-               $fname = 'User::isBlockedFrom';
-               wfProfileIn( $fname );
-               wfDebug( "$fname: enter\n" );
-
-               if ( $wgBlockAllowsUTEdit && $title->getText() === $this->getName() &&
-                 $title->getNamespace() == NS_USER_TALK )
-               {
-                       $blocked = false;
-                       wfDebug( "$fname: self-talk page, ignoring any blocks\n" );
-               } else {
-                       wfDebug( "$fname: asking isBlocked()\n" );
-                       $blocked = $this->isBlocked( $bFromSlave );
-               }
-               wfProfileOut( $fname );
-               return $blocked;
-       }
-
-       /**
-        * Get name of blocker
-        * @return string name of blocker
-        */
-       function blockedBy() {
-               $this->getBlockedStatus();
-               return $this->mBlockedby;
-       }
-
-       /**
-        * Get blocking reason
-        * @return string Blocking reason
-        */
-       function blockedFor() {
-               $this->getBlockedStatus();
-               return $this->mBlockreason;
-       }
-
-       /**
-        * Initialise php session
-        */
-       function SetupSession() {
-               global $wgSessionsInMemcached, $wgCookiePath, $wgCookieDomain;
-               if( $wgSessionsInMemcached ) {
-                       require_once( 'MemcachedSessions.php' );
-               } elseif( 'files' != ini_get( 'session.save_handler' ) ) {
-                       # If it's left on 'user' or another setting from another
-                       # application, it will end up failing. Try to recover.
-                       ini_set ( 'session.save_handler', 'files' );
-               }
-               session_set_cookie_params( 0, $wgCookiePath, $wgCookieDomain );
-               session_cache_limiter( 'private, must-revalidate' );
-               @session_start();
-       }
-
-       /**
-        * Create a new user object using data from session
-        * @static
-        */
-       function loadFromSession() {
-               global $wgMemc, $wgDBname, $wgCookiePrefix;
-
-               if ( isset( $_SESSION['wsUserID'] ) ) {
-                       if ( 0 != $_SESSION['wsUserID'] ) {
-                               $sId = $_SESSION['wsUserID'];
-                       } else {
-                               return new User();
-                       }
-               } else if ( isset( $_COOKIE["{$wgCookiePrefix}UserID"] ) ) {
-                       $sId = intval( $_COOKIE["{$wgCookiePrefix}UserID"] );
-                       $_SESSION['wsUserID'] = $sId;
-               } else {
-                       return new User();
-               }
-               if ( isset( $_SESSION['wsUserName'] ) ) {
-                       $sName = $_SESSION['wsUserName'];
-               } else if ( isset( $_COOKIE["{$wgCookiePrefix}UserName"] ) ) {
-                       $sName = $_COOKIE["{$wgCookiePrefix}UserName"];
-                       $_SESSION['wsUserName'] = $sName;
-               } else {
-                       return new User();
-               }
-
-               $passwordCorrect = FALSE;
-               $user = $wgMemc->get( $key = "$wgDBname:user:id:$sId" );
-               if( !is_object( $user ) || $user->mVersion < MW_USER_VERSION ) {
-                       # Expire old serialized objects; they may be corrupt.
-                       $user = false;
-               }
-               if($makenew = !$user) {
-                       wfDebug( "User::loadFromSession() unable to load from memcached\n" );
-                       $user = new User();
-                       $user->mId = $sId;
-                       $user->loadFromDatabase();
-               } else {
-                       wfDebug( "User::loadFromSession() got from cache!\n" );
-               }
-
-               if ( isset( $_SESSION['wsToken'] ) ) {
-                       $passwordCorrect = $_SESSION['wsToken'] == $user->mToken;
-               } else if ( isset( $_COOKIE["{$wgCookiePrefix}Token"] ) ) {
-                       $passwordCorrect = $user->mToken == $_COOKIE["{$wgCookiePrefix}Token"];
-               } else {
-                       return new User(); # Can't log in from session
-               }
-
-               if ( ( $sName == $user->mName ) && $passwordCorrect ) {
-                       if($makenew) {
-                               if($wgMemc->set( $key, $user ))
-                                       wfDebug( "User::loadFromSession() successfully saved user\n" );
-                               else
-                                       wfDebug( "User::loadFromSession() unable to save to memcached\n" );
-                       }
-                       return $user;
-               }
-               return new User(); # Can't log in from session
+               return $this->mBlockedby !== 0;
        }
 
        /**
-        * Load a user from the database
+        * Check if user is blocked from editing a particular article
         */
-       function loadFromDatabase() {
-               $fname = "User::loadFromDatabase";
-
-               # Counter-intuitive, breaks various things, use User::setLoaded() if you want to suppress
-               # loading in a command line script, don't assume all command line scripts need it like this
-               #if ( $this->mDataLoaded || $wgCommandLineMode ) {
-               if ( $this->mDataLoaded ) {
-                       return;
+       function isBlockedFrom( $title, $bFromSlave = false ) {
+               global $wgBlockAllowsUTEdit;
+               wfProfileIn( __METHOD__ );
+               wfDebug( __METHOD__.": enter\n" );
+
+               wfDebug( __METHOD__.": asking isBlocked()\n" );
+               $blocked = $this->isBlocked( $bFromSlave );
+               # If a user's name is suppressed, they cannot make edits anywhere
+               if ( !$this->mHideName && $wgBlockAllowsUTEdit && $title->getText() === $this->getName() &&
+                 $title->getNamespace() == NS_USER_TALK ) {
+                       $blocked = false;
+                       wfDebug( __METHOD__.": self-talk page, ignoring any blocks\n" );
                }
+               wfProfileOut( __METHOD__ );
+               return $blocked;
+       }
 
-               # Paranoia
-               $this->mId = intval( $this->mId );
-
-               /** Anonymous user */
-               if( !$this->mId ) {
-                       /** Get rights */
-                       $this->mRights = $this->getGroupPermissions( array( '*' ) );
-                       $this->mDataLoaded = true;
-                       return;
-               } # the following stuff is for non-anonymous users only
-
-               $dbr =& wfGetDB( DB_SLAVE );
-               $s = $dbr->selectRow( 'user', array( 'user_name','user_password','user_newpassword','user_email',
-                 'user_email_authenticated',
-                 'user_real_name','user_options','user_touched', 'user_token', 'user_registration' ),
-                 array( 'user_id' => $this->mId ), $fname );
-
-               if ( $s !== false ) {
-                       $this->mName = $s->user_name;
-                       $this->mEmail = $s->user_email;
-                       $this->mEmailAuthenticated = wfTimestampOrNull( TS_MW, $s->user_email_authenticated );
-                       $this->mRealName = $s->user_real_name;
-                       $this->mPassword = $s->user_password;
-                       $this->mNewpassword = $s->user_newpassword;
-                       $this->decodeOptions( $s->user_options );
-                       $this->mTouched = wfTimestamp(TS_MW,$s->user_touched);
-                       $this->mToken = $s->user_token;
-                       $this->mRegistration = wfTimestampOrNull( TS_MW, $s->user_registration );
-
-                       $res = $dbr->select( 'user_groups',
-                               array( 'ug_group' ),
-                               array( 'ug_user' => $this->mId ),
-                               $fname );
-                       $this->mGroups = array();
-                       while( $row = $dbr->fetchObject( $res ) ) {
-                               $this->mGroups[] = $row->ug_group;
-                       }
-                       $implicitGroups = array( '*', 'user' );
-
-                       global $wgAutoConfirmAge;
-                       $accountAge = time() - wfTimestampOrNull( TS_UNIX, $this->mRegistration );
-                       if( $accountAge >= $wgAutoConfirmAge ) {
-                               $implicitGroups[] = 'autoconfirmed';
-                       }
+       /**
+        * Get name of blocker
+        * @return string name of blocker
+        */
+       function blockedBy() {
+               $this->getBlockedStatus();
+               return $this->mBlockedby;
+       }
 
-                       $effectiveGroups = array_merge( $implicitGroups, $this->mGroups );
-                       $this->mRights = $this->getGroupPermissions( $effectiveGroups );
-               }
+       /**
+        * Get blocking reason
+        * @return string Blocking reason
+        */
+       function blockedFor() {
+               $this->getBlockedStatus();
+               return $this->mBlockreason;
+       }
 
-               $this->mDataLoaded = true;
+       /**
+        * Get the user ID. Returns 0 if the user is anonymous or nonexistent.
+        */
+       function getID() { 
+               $this->load();
+               return $this->mId; 
        }
 
-       function getID() { return $this->mId; }
+       /**
+        * Set the user and reload all fields according to that ID
+        * @deprecated use User::newFromId()
+        */
        function setID( $v ) {
                $this->mId = $v;
-               $this->mDataLoaded = false;
+               $this->clearInstanceCache( 'id' );
        }
 
+       /**
+        * Get the user name, or the IP for anons
+        */
        function getName() {
-               $this->loadFromDatabase();
-               if ( $this->mName === false ) {
-                       $this->mName = wfGetIP();
+               if ( !$this->mDataLoaded && $this->mFrom == 'name' ) {
+                       # Special case optimisation
+                       return $this->mName;
+               } else {
+                       $this->load();
+                       if ( $this->mName === false ) {
+                               $this->mName = wfGetIP();
+                       }
+                       # Clean up IPs
+                       return IP::sanitizeIP($this->mName);
                }
-               return $this->mName;
        }
 
+       /**
+        * Set the user name. 
+        *
+        * This does not reload fields from the database according to the given 
+        * name. Rather, it is used to create a temporary "nonexistent user" for
+        * later addition to the database. It can also be used to set the IP 
+        * address for an anonymous user to something other than the current 
+        * remote IP.
+        *
+        * User::newFromName() has rougly the same function, when the named user
+        * does not exist.
+        */
        function setName( $str ) {
-               $this->loadFromDatabase();
+               $this->load();
                $this->mName = $str;
        }
 
-
        /**
         * Return the title dbkey form of the name, for eg user pages.
         * @return string
@@ -811,7 +1164,7 @@ class User {
        }
 
        function getNewtalk() {
-               $this->loadFromDatabase();
+               $this->load();
 
                # Load the newtalk status if it is unloaded (mNewtalk=-1)
                if( $this->mNewtalk === -1 ) {
@@ -820,14 +1173,14 @@ class User {
                        # Check memcached separately for anons, who have no
                        # entire User object stored in there.
                        if( !$this->mId ) {
-                               global $wgDBname, $wgMemc;
-                               $key = "$wgDBname:newtalk:ip:" . $this->getName();
+                               global $wgMemc;
+                               $key = wfMemcKey( 'newtalk', 'ip', $this->getName() );
                                $newtalk = $wgMemc->get( $key );
-                               if( is_integer( $newtalk ) ) {
+                               if( $newtalk != "" ) {
                                        $this->mNewtalk = (bool)$newtalk;
                                } else {
                                        $this->mNewtalk = $this->checkNewtalk( 'user_ip', $this->getName() );
-                                       $wgMemc->set( $key, $this->mNewtalk, time() ); // + 1800 );
+                                       $wgMemc->set( $key, (int)$this->mNewtalk, time() + 1800 );
                                }
                        } else {
                                $this->mNewtalk = $this->checkNewtalk( 'user_id', $this->mId );
@@ -841,7 +1194,6 @@ class User {
         * Return the talk page(s) this user has new messages on.
         */
        function getNewMessageLinks() {
-       global  $wgDBname;
                $talks = array();
                if (!wfRunHooks('UserRetrieveNewTalks', array(&$this, &$talks)))
                        return $talks;
@@ -850,7 +1202,7 @@ class User {
                        return array();
                $up = $this->getUserPage();
                $utp = $up->getTalkPage();
-               return array(array("wiki" => $wgDBname, "link" => $utp->getLocalURL()));
+               return array(array("wiki" => wfWikiID(), "link" => $utp->getLocalURL()));
        }
 
                
@@ -865,10 +1217,9 @@ class User {
         * @private
         */
        function checkNewtalk( $field, $id ) {
-               $fname = 'User::checkNewtalk';
-               $dbr =& wfGetDB( DB_SLAVE );
+               $dbr = wfGetDB( DB_SLAVE );
                $ok = $dbr->selectField( 'user_newtalk', $field,
-                       array( $field => $id ), $fname );
+                       array( $field => $id ), __METHOD__ );
                return $ok !== false;
        }
 
@@ -879,17 +1230,16 @@ class User {
         * @private
         */
        function updateNewtalk( $field, $id ) {
-               $fname = 'User::updateNewtalk';
                if( $this->checkNewtalk( $field, $id ) ) {
-                       wfDebug( "$fname already set ($field, $id), ignoring\n" );
+                       wfDebug( __METHOD__." already set ($field, $id), ignoring\n" );
                        return false;
                }
-               $dbw =& wfGetDB( DB_MASTER );
+               $dbw = wfGetDB( DB_MASTER );
                $dbw->insert( 'user_newtalk',
                        array( $field => $id ),
-                       $fname,
+                       __METHOD__,
                        'IGNORE' );
-               wfDebug( "$fname: set on ($field, $id)\n" );
+               wfDebug( __METHOD__.": set on ($field, $id)\n" );
                return true;
        }
 
@@ -900,16 +1250,15 @@ class User {
         * @private
         */
        function deleteNewtalk( $field, $id ) {
-               $fname = 'User::deleteNewtalk';
                if( !$this->checkNewtalk( $field, $id ) ) {
-                       wfDebug( "$fname: already gone ($field, $id), ignoring\n" );
+                       wfDebug( __METHOD__.": already gone ($field, $id), ignoring\n" );
                        return false;
                }
-               $dbw =& wfGetDB( DB_MASTER );
+               $dbw = wfGetDB( DB_MASTER );
                $dbw->delete( 'user_newtalk',
                        array( $field => $id ),
-                       $fname );
-               wfDebug( "$fname: killed on ($field, $id)\n" );
+                       __METHOD__ );
+               wfDebug( __METHOD__.": killed on ($field, $id)\n" );
                return true;
        }
 
@@ -922,11 +1271,9 @@ class User {
                        return;
                }
 
-               $this->loadFromDatabase();
+               $this->load();
                $this->mNewtalk = $val;
 
-               $fname = 'User::setNewtalk';
-
                if( $this->isAnon() ) {
                        $field = 'user_ip';
                        $id = $this->getName();
@@ -945,8 +1292,8 @@ class User {
                        if( $this->isAnon() ) {
                                // Anons have a separate memcached space, since
                                // user records aren't kept for them.
-                               global $wgDBname, $wgMemc;
-                               $key = "$wgDBname:newtalk:ip:$val";
+                               global $wgMemc;
+                               $key = wfMemcKey( 'newtalk', 'ip', $val );
                                $wgMemc->set( $key, $val ? 1 : 0 );
                        } else {
                                if( $val ) {
@@ -956,20 +1303,54 @@ class User {
                                }
                        }
                        $this->invalidateCache();
-                       $this->saveSettings();
+               }
+       }
+       
+       /**
+        * Generate a current or new-future timestamp to be stored in the
+        * user_touched field when we update things.
+        */
+       private static function newTouchedTimestamp() {
+               global $wgClockSkewFudge;
+               return wfTimestamp( TS_MW, time() + $wgClockSkewFudge );
+       }
+       
+       /**
+        * Clear user data from memcached.
+        * Use after applying fun updates to the database; caller's
+        * responsibility to update user_touched if appropriate.
+        *
+        * Called implicitly from invalidateCache() and saveSettings().
+        */
+       private function clearSharedCache() {
+               if( $this->mId ) {
+                       global $wgMemc;
+                       $wgMemc->delete( wfMemcKey( 'user', 'id', $this->mId ) );
                }
        }
 
+       /**
+        * Immediately touch the user data cache for this account.
+        * Updates user_touched field, and removes account data from memcached
+        * for reload on the next hit.
+        */
        function invalidateCache() {
-               global $wgClockSkewFudge;
-               $this->loadFromDatabase();
-               $this->mTouched = wfTimestamp(TS_MW, time() + $wgClockSkewFudge );
-               # Don't forget to save the options after this or
-               # it won't take effect!
+               $this->load();
+               if( $this->mId ) {
+                       $this->mTouched = self::newTouchedTimestamp();
+                       
+                       $dbw = wfGetDB( DB_MASTER );
+                       $dbw->update( 'user',
+                               array( 'user_touched' => $dbw->timestamp( $this->mTouched ) ),
+                               array( 'user_id' => $this->mId ),
+                               __METHOD__ );
+                       
+                       $this->clearSharedCache();
+               }
        }
 
        function validateCache( $timestamp ) {
-               $this->loadFromDatabase();
+               $this->load();
                return ($timestamp >= $this->mTouched);
        }
 
@@ -980,20 +1361,75 @@ class User {
         * @return string Encrypted password.
         */
        function encryptPassword( $p ) {
+               $this->load();
                return wfEncryptPassword( $this->mId, $p );
        }
 
-       # Set the password and reset the random token
+       /**
+        * Set the password and reset the random token
+        * Calls through to authentication plugin if necessary;
+        * will have no effect if the auth plugin refuses to
+        * pass the change through or if the legal password
+        * checks fail.
+        *
+        * As a special case, setting the password to null
+        * wipes it, so the account cannot be logged in until
+        * a new password is set, for instance via e-mail.
+        *
+        * @param string $str
+        * @throws PasswordError on failure
+        */
        function setPassword( $str ) {
-               $this->loadFromDatabase();
+               global $wgAuth;
+               
+               if( $str !== null ) {
+                       if( !$wgAuth->allowPasswordChange() ) {
+                               throw new PasswordError( wfMsg( 'password-change-forbidden' ) );
+                       }
+               
+                       if( !$this->isValidPassword( $str ) ) {
+                               global $wgMinimalPasswordLength;
+                               throw new PasswordError( wfMsg( 'passwordtooshort',
+                                       $wgMinimalPasswordLength ) );
+                       }
+               }
+
+               if( !$wgAuth->setPassword( $this, $str ) ) {
+                       throw new PasswordError( wfMsg( 'externaldberror' ) );
+               }
+               
+               $this->setInternalPassword( $str );
+
+               return true;
+       }
+
+       /**
+        * Set the password and reset the random token no matter
+        * what.
+        *
+        * @param string $str
+        */
+       function setInternalPassword( $str ) {
+               $this->load();
                $this->setToken();
-               $this->mPassword = $this->encryptPassword( $str );
+               
+               if( $str === null ) {
+                       // Save an invalid hash...
+                       $this->mPassword = '';
+               } else {
+                       $this->mPassword = $this->encryptPassword( $str );
+               }
                $this->mNewpassword = '';
+               $this->mNewpassTime = null;
        }
-
-       # Set the random token (used for persistent authentication)
+       /**
+        * Set the random token (used for persistent authentication)
+        * Called from loadDefaults() among other places.
+        * @private
+        */
        function setToken( $token = false ) {
-               global $wgSecretKey, $wgProxyKey, $wgDBname;
+               global $wgSecretKey, $wgProxyKey;
+               $this->load();
                if ( !$token ) {
                        if ( $wgSecretKey ) {
                                $key = $wgSecretKey;
@@ -1002,59 +1438,105 @@ class User {
                        } else {
                                $key = microtime();
                        }
-                       $this->mToken = md5( $key . mt_rand( 0, 0x7fffffff ) . $wgDBname . $this->mId );
+                       $this->mToken = md5( $key . mt_rand( 0, 0x7fffffff ) . wfWikiID() . $this->mId );
                } else {
                        $this->mToken = $token;
                }
        }
 
-
        function setCookiePassword( $str ) {
-               $this->loadFromDatabase();
+               $this->load();
                $this->mCookiePassword = md5( $str );
        }
 
-       function setNewpassword( $str ) {
-               $this->loadFromDatabase();
+       /**
+        * Set the password for a password reminder or new account email
+        * Sets the user_newpass_time field if $throttle is true
+        */
+       function setNewpassword( $str, $throttle = true ) {
+               $this->load();
                $this->mNewpassword = $this->encryptPassword( $str );
+               if ( $throttle ) {
+                       $this->mNewpassTime = wfTimestampNow();
+               }
        }
 
+       /**
+        * Returns true if a password reminder email has already been sent within
+        * the last $wgPasswordReminderResendTime hours
+        */
+       function isPasswordReminderThrottled() {
+               global $wgPasswordReminderResendTime;
+               $this->load();
+               if ( !$this->mNewpassTime || !$wgPasswordReminderResendTime ) {
+                       return false;
+               }
+               $expiry = wfTimestamp( TS_UNIX, $this->mNewpassTime ) + $wgPasswordReminderResendTime * 3600;
+               return time() < $expiry;
+       }
+       
        function getEmail() {
-               $this->loadFromDatabase();
+               $this->load();
                return $this->mEmail;
        }
 
        function getEmailAuthenticationTimestamp() {
-               $this->loadFromDatabase();
+               $this->load();
                return $this->mEmailAuthenticated;
        }
 
        function setEmail( $str ) {
-               $this->loadFromDatabase();
+               $this->load();
                $this->mEmail = $str;
        }
 
        function getRealName() {
-               $this->loadFromDatabase();
+               $this->load();
                return $this->mRealName;
        }
 
        function setRealName( $str ) {
-               $this->loadFromDatabase();
+               $this->load();
                $this->mRealName = $str;
        }
 
        /**
         * @param string $oname The option to check
+        * @param string $defaultOverride A default value returned if the option does not exist
         * @return string
         */
-       function getOption( $oname ) {
-               $this->loadFromDatabase();
+       function getOption( $oname, $defaultOverride = '' ) {
+               $this->load();
+
+               if ( is_null( $this->mOptions ) ) {
+                       if($defaultOverride != '') {
+                               return $defaultOverride;
+                       }
+                       $this->mOptions = User::getDefaultOptions();
+               }
+
                if ( array_key_exists( $oname, $this->mOptions ) ) {
                        return trim( $this->mOptions[$oname] );
                } else {
-                       return '';
+                       return $defaultOverride;
+               }
+       }
+
+       /**
+        * Get the user's date preference, including some important migration for 
+        * old user rows.
+        */
+       function getDatePreference() {
+               if ( is_null( $this->mDatePreference ) ) {
+                       global $wgLang;
+                       $value = $this->getOption( 'date' );
+                       $map = $wgLang->getDatePreferenceMigrationMap();
+                       if ( isset( $map[$value] ) ) {
+                               $value = $map[$value];
+                       }
+                       $this->mDatePreference = $value;
                }
+               return $this->mDatePreference;
        }
 
        /**
@@ -1080,7 +1562,10 @@ class User {
        }
 
        function setOption( $oname, $val ) {
-               $this->loadFromDatabase();
+               $this->load();
+               if ( is_null( $this->mOptions ) ) {
+                       $this->mOptions = User::getDefaultOptions();
+               }
                if ( $oname == 'skin' ) {
                        # Clear cached skin, so the new one displays immediately in Special:Preferences
                        unset( $this->mSkin );
@@ -1091,11 +1576,12 @@ class User {
                $val = str_replace( "\r", "\n", $val );
                $val = str_replace( "\n", " ", $val );
                $this->mOptions[$oname] = $val;
-               $this->invalidateCache();
        }
 
        function getRights() {
-               $this->loadFromDatabase();
+               if ( is_null( $this->mRights ) ) {
+                       $this->mRights = self::getGroupPermissions( $this->getEffectiveGroups() );
+               }
                return $this->mRights;
        }
 
@@ -1105,7 +1591,7 @@ class User {
         * @return array of strings
         */
        function getGroups() {
-               $this->loadFromDatabase();
+               $this->load();
                return $this->mGroups;
        }
 
@@ -1113,45 +1599,84 @@ class User {
         * Get the list of implicit group memberships this user has.
         * This includes all explicit groups, plus 'user' if logged in
         * and '*' for all accounts.
+        * @param boolean $recache Don't use the cache
         * @return array of strings
         */
-       function getEffectiveGroups() {
-               $base = array( '*' );
-               if( $this->isLoggedIn() ) {
-                       $base[] = 'user';
+       function getEffectiveGroups( $recache = false ) {
+               if ( $recache || is_null( $this->mEffectiveGroups ) ) {
+                       $this->load();
+                       $this->mEffectiveGroups = $this->mGroups;
+                       $this->mEffectiveGroups[] = '*';
+                       if( $this->mId ) {
+                               $this->mEffectiveGroups[] = 'user';
+                               
+                               global $wgAutoConfirmAge, $wgAutoConfirmCount;
+
+                               $accountAge = time() - wfTimestampOrNull( TS_UNIX, $this->mRegistration );
+                               if( $accountAge >= $wgAutoConfirmAge && $this->getEditCount() >= $wgAutoConfirmCount ) {
+                                       $this->mEffectiveGroups[] = 'autoconfirmed';
+                               }
+                               # Implicit group for users whose email addresses are confirmed
+                               global $wgEmailAuthentication;
+                               if( self::isValidEmailAddr( $this->mEmail ) ) {
+                                       if( $wgEmailAuthentication ) {
+                                               if( $this->mEmailAuthenticated )
+                                                       $this->mEffectiveGroups[] = 'emailconfirmed';
+                                       } else {
+                                               $this->mEffectiveGroups[] = 'emailconfirmed';
+                                       }
+                               }
+                       }
                }
-               return array_merge( $base, $this->getGroups() );
+               return $this->mEffectiveGroups;
        }
-
+       
+       /* Return the edit count for the user. This is where User::edits should have been */
+       function getEditCount() {
+               if ($this->mId) {
+                       if ( !isset( $this->mEditCount ) ) {
+                               /* Populate the count, if it has not been populated yet */
+                               $this->mEditCount = User::edits($this->mId);
+                       } 
+                       return $this->mEditCount;
+               } else {
+                       /* nil */
+                       return null;
+               }
+       }
+       
        /**
         * Add the user to the given group.
         * This takes immediate effect.
-        * @string $group
+        * @param string $group
         */
        function addGroup( $group ) {
-               $dbw =& wfGetDB( DB_MASTER );
-               $dbw->insert( 'user_groups',
-                       array(
-                               'ug_user'  => $this->getID(),
-                               'ug_group' => $group,
-                       ),
-                       'User::addGroup',
-                       array( 'IGNORE' ) );
+               $this->load();
+               $dbw = wfGetDB( DB_MASTER );
+               if( $this->getId() ) {
+                       $dbw->insert( 'user_groups',
+                               array(
+                                       'ug_user'  => $this->getID(),
+                                       'ug_group' => $group,
+                               ),
+                               'User::addGroup',
+                               array( 'IGNORE' ) );
+               }
 
-               $this->mGroups = array_merge( $this->mGroups, array( $group ) );
-               $this->mRights = User::getGroupPermissions( $this->getEffectiveGroups() );
+               $this->mGroups[] = $group;
+               $this->mRights = User::getGroupPermissions( $this->getEffectiveGroups( true ) );
 
                $this->invalidateCache();
-               $this->saveSettings();
        }
 
        /**
         * Remove the user from the given group.
         * This takes immediate effect.
-        * @string $group
+        * @param string $group
         */
        function removeGroup( $group ) {
-               $dbw =& wfGetDB( DB_MASTER );
+               $this->load();
+               $dbw = wfGetDB( DB_MASTER );
                $dbw->delete( 'user_groups',
                        array(
                                'ug_user'  => $this->getID(),
@@ -1160,10 +1685,9 @@ class User {
                        'User::removeGroup' );
 
                $this->mGroups = array_diff( $this->mGroups, array( $group ) );
-               $this->mRights = User::getGroupPermissions( $this->getEffectiveGroups() );
+               $this->mRights = User::getGroupPermissions( $this->getEffectiveGroups( true ) );
 
                $this->invalidateCache();
-               $this->saveSettings();
        }
 
 
@@ -1187,45 +1711,17 @@ class User {
                return !$this->isLoggedIn();
        }
 
-       /**
-        * Deprecated in 1.6, die in 1.7, to be removed in 1.8
-        * @deprecated
-        */
-       function isSysop() {
-               wfDebugDieBacktrace( "Call to deprecated (v1.7) User::isSysop() method\n" );
-               #return $this->isAllowed( 'protect' );
-       }
-
-       /**
-        * Deprecated in 1.6, die in 1.7, to be removed in 1.8
-        * @deprecated
-        */
-       function isDeveloper() {
-               wfDebugDieBacktrace( "Call to deprecated (v1.7) User::isDeveloper() method\n" );
-               #return $this->isAllowed( 'siteadmin' );
-       }
-
-       /**
-        * Deprecated in 1.6, die in 1.7, to be removed in 1.8
-        * @deprecated
-        */
-       function isBureaucrat() {
-               wfDebugDieBacktrace( "Call to deprecated (v1.7) User::isBureaucrat() method\n" );
-               #return $this->isAllowed( 'makesysop' );
-       }
-
        /**
         * Whether the user is a bot
-        * @todo need to be migrated to the new user level management sytem
+        * @deprecated
         */
        function isBot() {
-               $this->loadFromDatabase();
-               return in_array( 'bot', $this->mRights );
+               return $this->isAllowed( 'bot' );
        }
 
        /**
         * Check if user is allowed to access a feature / make an action
-        * @param string $action Action to be checked (see $wgAvailableRights in Defines.php for possible actions).
+        * @param string $action Action to be checked
         * @return boolean True: action is allowed, False: action should not be allowed
         */
        function isAllowed($action='') {
@@ -1233,8 +1729,7 @@ class User {
                        // In the spirit of DWIM
                        return true;
 
-               $this->loadFromDatabase();
-               return in_array( $action , $this->mRights );
+               return in_array( $action, $this->getRights() );
        }
 
        /**
@@ -1242,17 +1737,16 @@ class User {
         * @todo FIXME : need to check the old failback system [AV]
         */
        function &getSkin() {
-               global $IP, $wgRequest;
+               global $wgRequest;
                if ( ! isset( $this->mSkin ) ) {
-                       $fname = 'User::getSkin';
-                       wfProfileIn( $fname );
+                       wfProfileIn( __METHOD__ );
 
                        # get the user skin
                        $userSkin = $this->getOption( 'skin' );
                        $userSkin = $wgRequest->getVal('useskin', $userSkin);
 
                        $this->mSkin =& Skin::newFromKey( $userSkin );
-                       wfProfileOut( $fname );
+                       wfProfileOut( __METHOD__ );
                }
                return $this->mSkin;
        }
@@ -1296,6 +1790,10 @@ class User {
        function clearNotification( &$title ) {
                global $wgUser, $wgUseEnotif;
 
+               # Do nothing if the database is locked to writes
+               if( wfReadOnly() ) {
+                       return;
+               }
 
                if ($title->getNamespace() == NS_USER_TALK &&
                        $title->getText() == $this->getName() ) {
@@ -1330,8 +1828,8 @@ class User {
                // If the page is watched by the user (or may be watched), update the timestamp on any
                // any matching rows
                if ( $watched ) {
-                       $dbw =& wfGetDB( DB_MASTER );
-                       $success = $dbw->update( 'watchlist',
+                       $dbw = wfGetDB( DB_MASTER );
+                       $dbw->update( 'watchlist',
                                        array( /* SET */
                                                'wl_notificationtimestamp' => NULL
                                        ), array( /* WHERE */
@@ -1361,10 +1859,10 @@ class User {
                }
                if( $currentUser != 0 )  {
 
-                       $dbw =& wfGetDB( DB_MASTER );
-                       $success = $dbw->update( 'watchlist',
+                       $dbw = wfGetDB( DB_MASTER );
+                       $dbw->update( 'watchlist',
                                array( /* SET */
-                                       'wl_notificationtimestamp' => 0
+                                       'wl_notificationtimestamp' => NULL
                                ), array( /* WHERE */
                                        'wl_user' => $currentUser
                                ), 'UserMailer::clearAll'
@@ -1380,6 +1878,10 @@ class User {
         * @return string Encoding options
         */
        function encodeOptions() {
+               $this->load();
+               if ( is_null( $this->mOptions ) ) {
+                       $this->mOptions = User::getDefaultOptions();
+               }
                $a = array();
                foreach ( $this->mOptions as $oname => $oval ) {
                        array_push( $a, $oname.'='.$oval );
@@ -1392,8 +1894,10 @@ class User {
         * @private
         */
        function decodeOptions( $str ) {
+               $this->mOptions = array();
                $a = explode( "\n", $str );
                foreach ( $a as $s ) {
+                       $m = array();
                        if ( preg_match( "/^(.[^=]*)=(.*)$/", $s, $m ) ) {
                                $this->mOptions[$m[1]] = $m[2];
                        }
@@ -1402,8 +1906,8 @@ class User {
 
        function setCookies() {
                global $wgCookieExpiration, $wgCookiePath, $wgCookieDomain, $wgCookieSecure, $wgCookiePrefix;
+               $this->load();
                if ( 0 == $this->mId ) return;
-               $this->loadFromDatabase();
                $exp = time() + $wgCookieExpiration;
 
                $_SESSION['wsUserID'] = $this->mId;
@@ -1422,12 +1926,11 @@ class User {
 
        /**
         * Logout user
-        * It will clean the session cookie
+        * Clears the cookies and session, resets the instance cache
         */
        function logout() {
                global $wgCookiePath, $wgCookieDomain, $wgCookieSecure, $wgCookiePrefix;
-               $this->loadDefaults();
-               $this->setLoaded( true );
+               $this->clearInstanceCache( 'defaults' );
 
                $_SESSION['wsUserID'] = 0;
 
@@ -1440,20 +1943,22 @@ class User {
 
        /**
         * Save object settings into database
+        * @todo Only rarely do all these fields need to be set!
         */
        function saveSettings() {
-               global $wgMemc, $wgDBname;
-               $fname = 'User::saveSettings';
-
+               $this->load();
                if ( wfReadOnly() ) { return; }
                if ( 0 == $this->mId ) { return; }
+               
+               $this->mTouched = self::newTouchedTimestamp();
 
-               $dbw =& wfGetDB( DB_MASTER );
+               $dbw = wfGetDB( DB_MASTER );
                $dbw->update( 'user',
                        array( /* SET */
                                'user_name' => $this->mName,
                                'user_password' => $this->mPassword,
                                'user_newpassword' => $this->mNewpassword,
+                               'user_newpass_time' => $dbw->timestampOrNull( $this->mNewpassTime ),
                                'user_real_name' => $this->mRealName,
                                'user_email' => $this->mEmail,
                                'user_email_authenticated' => $dbw->timestampOrNull( $this->mEmailAuthenticated ),
@@ -1462,9 +1967,9 @@ class User {
                                'user_token' => $this->mToken
                        ), array( /* WHERE */
                                'user_id' => $this->mId
-                       ), $fname
+                       ), __METHOD__
                );
-               $wgMemc->delete( "$wgDBname:user:id:$this->mId" );
+               $this->clearSharedCache();
        }
 
 
@@ -1472,14 +1977,11 @@ class User {
         * Checks if a user with the given name exists, returns the ID
         */
        function idForName() {
-               $fname = 'User::idForName';
-
-               $gotid = 0;
                $s = trim( $this->getName() );
                if ( 0 == strcmp( '', $s ) ) return 0;
 
-               $dbr =& wfGetDB( DB_SLAVE );
-               $id = $dbr->selectField( 'user', 'user_id', array( 'user_name' => $s ), $fname );
+               $dbr = wfGetDB( DB_SLAVE );
+               $id = $dbr->selectField( 'user', 'user_id', array( 'user_name' => $s ), __METHOD__ );
                if ( $id === false ) {
                        $id = 0;
                }
@@ -1487,11 +1989,62 @@ class User {
        }
 
        /**
-        * Add user object to the database
+        * Add a user to the database, return the user object
+        *
+        * @param string $name The user's name
+        * @param array $params Associative array of non-default parameters to save to the database:
+        *     password             The user's password. Password logins will be disabled if this is omitted.
+        *     newpassword          A temporary password mailed to the user
+        *     email                The user's email address
+        *     email_authenticated  The email authentication timestamp
+        *     real_name            The user's real name
+        *     options              An associative array of non-default options
+        *     token                Random authentication token. Do not set.
+        *     registration         Registration timestamp. Do not set.
+        *
+        * @return User object, or null if the username already exists
+        */
+       static function createNew( $name, $params = array() ) {
+               $user = new User;
+               $user->load();
+               if ( isset( $params['options'] ) ) {
+                       $user->mOptions = $params['options'] + $user->mOptions;
+                       unset( $params['options'] );
+               }
+               $dbw = wfGetDB( DB_MASTER );
+               $seqVal = $dbw->nextSequenceValue( 'user_user_id_seq' );
+               $fields = array(
+                       'user_id' => $seqVal,
+                       'user_name' => $name,
+                       'user_password' => $user->mPassword,
+                       'user_newpassword' => $user->mNewpassword,
+                       'user_newpass_time' => $dbw->timestamp( $user->mNewpassTime ),
+                       'user_email' => $user->mEmail,
+                       'user_email_authenticated' => $dbw->timestampOrNull( $user->mEmailAuthenticated ),
+                       'user_real_name' => $user->mRealName,
+                       'user_options' => $user->encodeOptions(),
+                       'user_token' => $user->mToken,
+                       'user_registration' => $dbw->timestamp( $user->mRegistration ),
+                       'user_editcount' => 0,
+               );
+               foreach ( $params as $name => $value ) {
+                       $fields["user_$name"] = $value;
+               }
+               $dbw->insert( 'user', $fields, __METHOD__, array( 'IGNORE' ) );
+               if ( $dbw->affectedRows() ) {
+                       $newUser = User::newFromId( $dbw->insertId() );
+               } else {
+                       $newUser = null;
+               }
+               return $newUser;
+       }
+       
+       /**
+        * Add an existing user object to the database
         */
        function addToDatabase() {
-               $fname = 'User::addToDatabase';
-               $dbw =& wfGetDB( DB_MASTER );
+               $this->load();
+               $dbw = wfGetDB( DB_MASTER );
                $seqVal = $dbw->nextSequenceValue( 'user_user_id_seq' );
                $dbw->insert( 'user',
                        array(
@@ -1499,65 +2052,39 @@ class User {
                                'user_name' => $this->mName,
                                'user_password' => $this->mPassword,
                                'user_newpassword' => $this->mNewpassword,
+                               'user_newpass_time' => $dbw->timestamp( $this->mNewpassTime ),
                                'user_email' => $this->mEmail,
                                'user_email_authenticated' => $dbw->timestampOrNull( $this->mEmailAuthenticated ),
                                'user_real_name' => $this->mRealName,
                                'user_options' => $this->encodeOptions(),
                                'user_token' => $this->mToken,
                                'user_registration' => $dbw->timestamp( $this->mRegistration ),
-                       ), $fname
+                               'user_editcount' => 0,
+                       ), __METHOD__
                );
                $this->mId = $dbw->insertId();
+
+               # Clear instance cache other than user table data, which is already accurate
+               $this->clearInstanceCache();
        }
 
+       /**
+        * If the (non-anonymous) user is blocked, this function will block any IP address
+        * that they successfully log on from.
+        */
        function spreadBlock() {
-               # If the (non-anonymous) user is blocked, this function will block any IP address
-               # that they successfully log on from.
-               $fname = 'User::spreadBlock';
-
-               wfDebug( "User:spreadBlock()\n" );
+               wfDebug( __METHOD__."()\n" );
+               $this->load();
                if ( $this->mId == 0 ) {
                        return;
                }
 
                $userblock = Block::newFromDB( '', $this->mId );
-               if ( !$userblock->isValid() ) {
-                       return;
-               }
-
-               # Check if this IP address is already blocked
-               $ipblock = Block::newFromDB( wfGetIP() );
-               if ( $ipblock->isValid() ) {
-                       # If the user is already blocked. Then check if the autoblock would
-                       # excede the user block. If it would excede, then do nothing, else
-                       # prolong block time
-                       if ($userblock->mExpiry &&
-                               ($userblock->mExpiry < Block::getAutoblockExpiry($ipblock->mTimestamp))) {
-                               return;
-                       }
-                       # Just update the timestamp
-                       $ipblock->updateTimestamp();
+               if ( !$userblock ) {
                        return;
                }
 
-               # Make a new block object with the desired properties
-               wfDebug( "Autoblocking {$this->mName}@" . wfGetIP() . "\n" );
-               $ipblock->mAddress = wfGetIP();
-               $ipblock->mUser = 0;
-               $ipblock->mBy = $userblock->mBy;
-               $ipblock->mReason = wfMsg( 'autoblocker', $this->getName(), $userblock->mReason );
-               $ipblock->mTimestamp = wfTimestampNow();
-               $ipblock->mAuto = 1;
-               # If the user is already blocked with an expiry date, we don't
-               # want to pile on top of that!
-               if($userblock->mExpiry) {
-                       $ipblock->mExpiry = min ( $userblock->mExpiry, Block::getAutoblockExpiry( $ipblock->mTimestamp ));
-               } else {
-                       $ipblock->mExpiry = Block::getAutoblockExpiry( $ipblock->mTimestamp );
-               }
-
-               # Insert it
-               $ipblock->insert();
+               $userblock->doAutoblock( wfGetIp() );
 
        }
 
@@ -1575,7 +2102,7 @@ class User {
         * @return string
         */
        function getPageRenderingHash() {
-               global $wgContLang;
+               global $wgContLang, $wgUseDynamicDates, $wgLang;
                if( $this->mHash ){
                        return $this->mHash;
                }
@@ -1585,9 +2112,11 @@ class User {
 
                $confstr =        $this->getOption( 'math' );
                $confstr .= '!' . $this->getOption( 'stubthreshold' );
-               $confstr .= '!' . $this->getOption( 'date' );
+               if ( $wgUseDynamicDates ) {
+                       $confstr .= '!' . $this->getDatePreference();
+               }
                $confstr .= '!' . ($this->getOption( 'numberheadings' ) ? '1' : '');
-               $confstr .= '!' . $this->getOption( 'language' );
+               $confstr .= '!' . $wgLang->getCode();
                $confstr .= '!' . $this->getOption( 'thumbsize' );
                // add in language specific options, if any
                $extra = $wgContLang->getExtraHashOptions();
@@ -1601,17 +2130,19 @@ class User {
                return $confstr;
        }
 
+       function isBlockedFromCreateAccount() {
+               $this->getBlockedStatus();
+               return $this->mBlock && $this->mBlock->mCreateAccount;
+       }
+
        function isAllowedToCreateAccount() {
-               return $this->isAllowed( 'createaccount' ) && !$this->isBlocked();
+               return $this->isAllowed( 'createaccount' ) && !$this->isBlockedFromCreateAccount();
        }
 
        /**
-        * Set mDataLoaded, return previous value
-        * Use this to prevent DB access in command-line scripts or similar situations
+        * @deprecated
         */
-       function setLoaded( $loaded ) {
-               return wfSetVar( $this->mDataLoaded, $loaded );
-       }
+       function setLoaded( $loaded ) {}
 
        /**
         * Get this user's personal page title.
@@ -1643,7 +2174,7 @@ class User {
                if ( isset( $res ) )
                        return $res;
                else {
-                       $dbr =& wfGetDB( DB_SLAVE );
+                       $dbr = wfGetDB( DB_SLAVE );
                        return $res = $dbr->selectField( 'user', 'max(user_id)', false, 'User::getMaxID' );
                }
        }
@@ -1663,15 +2194,15 @@ class User {
         * @return bool True if the given password is correct otherwise False.
         */
        function checkPassword( $password ) {
-               global $wgAuth, $wgMinimalPasswordLength;
-               $this->loadFromDatabase();
+               global $wgAuth;
+               $this->load();
 
                // Even though we stop people from creating passwords that
                // are shorter than this, doesn't mean people wont be able
                // to. Certain authentication plugins do NOT want to save
                // domain passwords in a mysql database, so we should
                // check this (incase $wgAuth->strict() is false).
-               if( strlen( $password ) < $wgMinimalPasswordLength ) {
+               if( !$this->isValidPassword( $password ) ) {
                        return false;
                }
 
@@ -1684,18 +2215,26 @@ class User {
                $ep = $this->encryptPassword( $password );
                if ( 0 == strcmp( $ep, $this->mPassword ) ) {
                        return true;
-               } elseif ( ($this->mNewpassword != '') && (0 == strcmp( $ep, $this->mNewpassword )) ) {
-                       return true;
                } elseif ( function_exists( 'iconv' ) ) {
                        # Some wikis were converted from ISO 8859-1 to UTF-8, the passwords can't be converted
                        # Check for this with iconv
-                       $cp1252hash = $this->encryptPassword( iconv( 'UTF-8', 'WINDOWS-1252', $password ) );
+                       $cp1252hash = $this->encryptPassword( iconv( 'UTF-8', 'WINDOWS-1252//TRANSLIT', $password ) );
                        if ( 0 == strcmp( $cp1252hash, $this->mPassword ) ) {
                                return true;
                        }
                }
                return false;
        }
+       
+       /**
+        * Check if the given clear-text password matches the temporary password
+        * sent by e-mail for password reset operations.
+        * @return bool
+        */
+       function checkTemporaryPassword( $plaintext ) {
+               $hash = $this->encryptPassword( $plaintext );
+               return $hash === $this->mNewpassword;
+       }
 
        /**
         * Initialize (if necessary) and return a session token value
@@ -1718,7 +2257,7 @@ class User {
                if( is_array( $salt ) ) {
                        $salt = implode( '|', $salt );
                }
-               return md5( $token . $salt );
+               return md5( $token . $salt ) . EDIT_TOKEN_SUFFIX;
        }
 
        /**
@@ -1759,6 +2298,7 @@ class User {
         */
        function sendConfirmationMail() {
                global $wgContLang;
+               $expiration = null; // gets passed-by-ref and defined in next line.
                $url = $this->confirmationTokenUrl( $expiration );
                return $this->sendMail( wfMsg( 'confirmemail_subject' ),
                        wfMsg( 'confirmemail_body',
@@ -1803,8 +2343,6 @@ class User {
         * @private
         */
        function confirmationToken( &$expiration ) {
-               $fname = 'User::confirmationToken';
-
                $now = time();
                $expires = $now + 7 * 24 * 60 * 60;
                $expiration = wfTimestamp( TS_MW, $expires );
@@ -1812,12 +2350,12 @@ class User {
                $token = $this->generateToken( $this->mId . $this->mEmail . $expires );
                $hash = md5( $token );
 
-               $dbw =& wfGetDB( DB_MASTER );
+               $dbw = wfGetDB( DB_MASTER );
                $dbw->update( 'user',
                        array( 'user_email_token'         => $hash,
                               'user_email_token_expires' => $dbw->timestamp( $expires ) ),
                        array( 'user_id'                  => $this->mId ),
-                       $fname );
+                       __METHOD__ );
 
                return $token;
        }
@@ -1831,7 +2369,7 @@ class User {
         */
        function confirmationTokenUrl( &$expiration ) {
                $token = $this->confirmationToken( $expiration );
-               $title = Title::makeTitle( NS_SPECIAL, 'Confirmemail/' . $token );
+               $title = SpecialPage::getTitleFor( 'Confirmemail', $token );
                return $title->getFullUrl();
        }
 
@@ -1839,7 +2377,7 @@ class User {
         * Mark the e-mail address confirmed and save.
         */
        function confirmEmail() {
-               $this->loadFromDatabase();
+               $this->load();
                $this->mEmailAuthenticated = wfTimestampNow();
                $this->saveSettings();
                return true;
@@ -1875,12 +2413,12 @@ class User {
         */
        function isEmailConfirmed() {
                global $wgEmailAuthentication;
-               $this->loadFromDatabase();
+               $this->load();
                $confirmed = true;
                if( wfRunHooks( 'EmailConfirmed', array( &$this, &$confirmed ) ) ) {
                        if( $this->isAnon() )
                                return false;
-                       if( !$this->isValidEmailAddr( $this->mEmail ) )
+                       if( !self::isValidEmailAddr( $this->mEmail ) )
                                return false;
                        if( $wgEmailAuthentication && !$this->getEmailAuthenticationTimestamp() )
                                return false;
@@ -1889,13 +2427,25 @@ class User {
                        return $confirmed;
                }
        }
+       
+       /**
+        * Return true if there is an outstanding request for e-mail confirmation.
+        * @return bool
+        */
+       function isEmailConfirmationPending() {
+               global $wgEmailAuthentication;
+               return $wgEmailAuthentication &&
+                       !$this->isEmailConfirmed() &&
+                       $this->mEmailToken &&
+                       $this->mEmailTokenExpires > wfTimestamp();
+       }
 
        /**
         * @param array $groups list of groups
         * @return array list of permission key names for given groups combined
         * @static
         */
-       function getGroupPermissions( $groups ) {
+       static function getGroupPermissions( $groups ) {
                global $wgGroupPermissions;
                $rights = array();
                foreach( $groups as $group ) {
@@ -1912,10 +2462,10 @@ class User {
         * @return string localized descriptive name for group, if provided
         * @static
         */
-       function getGroupName( $group ) {
+       static function getGroupName( $group ) {
                $key = "group-$group";
                $name = wfMsg( $key );
-               if( $name == '' || $name == "&lt;$key&gt;" ) {
+               if( $name == '' || wfEmptyMsg( $key, $name ) ) {
                        return $group;
                } else {
                        return $name;
@@ -1927,37 +2477,38 @@ class User {
         * @return string localized descriptive name for member of a group, if provided
         * @static
         */
-       function getGroupMember( $group ) {
+       static function getGroupMember( $group ) {
                $key = "group-$group-member";
                $name = wfMsg( $key );
-               if( $name == '' || $name == "&lt;$key&gt;" ) {
+               if( $name == '' || wfEmptyMsg( $key, $name ) ) {
                        return $group;
                } else {
                        return $name;
                }
        }
 
-
        /**
         * Return the set of defined explicit groups.
-        * The * and 'user' groups are not included.
+        * The *, 'user', 'autoconfirmed' and 'emailconfirmed'
+        * groups are not included, as they are defined
+        * automatically, not in the database.
         * @return array
         * @static
         */
-       function getAllGroups() {
+       static function getAllGroups() {
                global $wgGroupPermissions;
                return array_diff(
                        array_keys( $wgGroupPermissions ),
-                       array( '*', 'user', 'autoconfirmed' ) );
+                       array( '*', 'user', 'autoconfirmed', 'emailconfirmed' ) );
        }
-       
+
        /**
         * Get the title of a page describing a particular group
         *
         * @param $group Name of the group
         * @return mixed
         */
-       function getGroupPage( $group ) {
+       static function getGroupPage( $group ) {
                $page = wfMsgForContent( 'grouppage-' . $group );
                if( !wfEmptyMsg( 'grouppage-' . $group, $page ) ) {
                        $title = Title::newFromText( $page );
@@ -1966,8 +2517,91 @@ class User {
                }
                return false;
        }
+
+       /**
+        * Create a link to the group in HTML, if available
+        *
+        * @param $group Name of the group
+        * @param $text The text of the link
+        * @return mixed
+        */
+       static function makeGroupLinkHTML( $group, $text = '' ) {
+               if( $text == '' ) {
+                       $text = self::getGroupName( $group );
+               }
+               $title = self::getGroupPage( $group );
+               if( $title ) {
+                       global $wgUser;
+                       $sk = $wgUser->getSkin();
+                       return $sk->makeLinkObj( $title, htmlspecialchars( $text ) );
+               } else {
+                       return $text;
+               }
+       }
+
+       /**
+        * Create a link to the group in Wikitext, if available
+        *
+        * @param $group Name of the group
+        * @param $text The text of the link (by default, the name of the group)
+        * @return mixed
+        */
+       static function makeGroupLinkWiki( $group, $text = '' ) {
+               if( $text == '' ) {
+                       $text = self::getGroupName( $group );
+               }
+               $title = self::getGroupPage( $group );
+               if( $title ) {
+                       $page = $title->getPrefixedText();
+                       return "[[$page|$text]]";
+               } else {
+                       return $text;
+               }
+       }
        
-       
+       /**
+        * Increment the user's edit-count field.
+        * Will have no effect for anonymous users.
+        */
+       function incEditCount() {
+               if( !$this->isAnon() ) {
+                       $dbw = wfGetDB( DB_MASTER );
+                       $dbw->update( 'user',
+                               array( 'user_editcount=user_editcount+1' ),
+                               array( 'user_id' => $this->getId() ),
+                               __METHOD__ );
+                       
+                       // Lazy initialization check...
+                       if( $dbw->affectedRows() == 0 ) {
+                               // Pull from a slave to be less cruel to servers
+                               // Accuracy isn't the point anyway here
+                               $dbr = wfGetDB( DB_SLAVE );
+                               $count = $dbr->selectField( 'revision',
+                                       'COUNT(rev_user)',
+                                       array( 'rev_user' => $this->getId() ),
+                                       __METHOD__ );
+                               
+                               // Now here's a goddamn hack...
+                               if( $dbr !== $dbw ) {
+                                       // If we actually have a slave server, the count is
+                                       // at least one behind because the current transaction
+                                       // has not been committed and replicated.
+                                       $count++;
+                               } else {
+                                       // But if DB_SLAVE is selecting the master, then the
+                                       // count we just read includes the revision that was
+                                       // just added in the working transaction.
+                               }
+                               
+                               $dbw->update( 'user',
+                                       array( 'user_editcount' => $count ),
+                                       array( 'user_id' => $this->getId() ),
+                                       __METHOD__ );
+                       }
+               }
+               // edit count in user cache too
+               $this->invalidateCache();
+       }
 }
 
 ?>