<?php
+use MediaWiki\MediaWikiServices;
+
/**
* Handles compiling Mustache templates into PHP rendering functions
*
* @throws UnexpectedValueException If $templateName attempts upwards directory traversal
*/
protected function getTemplateFilename( $templateName ) {
- // Prevent upwards directory traversal using same methods as Title::secureAndSplit
+ // Prevent path traversal. Based on Language::isValidCode().
+ // This is for paranoia. The $templateName should never come from
+ // untrusted input.
if (
- strpos( $templateName, '.' ) !== false &&
- (
- $templateName === '.' || $templateName === '..' ||
- strpos( $templateName, './' ) === 0 ||
- strpos( $templateName, '../' ) === 0 ||
- strpos( $templateName, '/./' ) !== false ||
- strpos( $templateName, '/../' ) !== false ||
- substr( $templateName, -2 ) === '/.' ||
- substr( $templateName, -3 ) === '/..'
- )
+ strcspn( $templateName, ":/\\\000&<>'\"%" ) !== strlen( $templateName )
) {
throw new UnexpectedValueException( "Malformed \$templateName: $templateName" );
}
$fastHash = md5( $fileContents );
// Fetch a secret key for building a keyed hash of the PHP code
- $config = ConfigFactory::getDefaultInstance()->makeConfig( 'main' );
+ $config = MediaWikiServices::getInstance()->getMainConfig();
$secretKey = $config->get( 'SecretKey' );
if ( $secretKey ) {