(bug 12952) Using Nosuchusershort instead of Nosuchuser when account creatio is disabled
[lhc/web/wiklou.git] / includes / SpecialUserlogin.php
index 1f56141..72ccad3 100644 (file)
@@ -1,30 +1,26 @@
 <?php
 /**
  *
- * @package MediaWiki
- * @subpackage SpecialPage
+ * @addtogroup SpecialPage
  */
 
 /**
  * constructor
  */
-function wfSpecialUserlogin() {
-       global $wgCommandLineMode;
+function wfSpecialUserlogin( $par = '' ) {
        global $wgRequest;
-       if( !$wgCommandLineMode && !isset( $_COOKIE[session_name()] )  ) {
-               User::SetupSession();
+       if( session_id() == '' ) {
+               wfSetupSession();
        }
 
-       $form = new LoginForm( $wgRequest );
+       $form = new LoginForm( $wgRequest, $par );
        $form->execute();
 }
 
 /**
- *
- * @package MediaWiki
- * @subpackage SpecialPage
+ * implements Special:Login
+ * @addtogroup SpecialPage
  */
-
 class LoginForm {
 
        const SUCCESS = 0;
@@ -34,6 +30,8 @@ class LoginForm {
        const NOT_EXISTS = 4;
        const WRONG_PASS = 5;
        const EMPTY_PASS = 6;
+       const RESET_PASS = 7;
+       const ABORTED = 8;
 
        var $mName, $mPassword, $mRetype, $mReturnTo, $mCookieCheck, $mPosted;
        var $mAction, $mCreateaccount, $mCreateaccountMail, $mMailmypassword;
@@ -41,13 +39,13 @@ class LoginForm {
 
        /**
         * Constructor
-        * @param webrequest $request A webrequest object passed by reference
+        * @param WebRequest $request A WebRequest object passed by reference
         */
-       function LoginForm( &$request ) {
+       function LoginForm( &$request, $par = '' ) {
                global $wgLang, $wgAllowRealName, $wgEnableEmail;
                global $wgAuth;
 
-               $this->mType = $request->getText( 'type' );
+               $this->mType = ( $par == 'signup' ) ? $par : $request->getText( 'type' ); # Check for [[Special:Userlogin/signup]]
                $this->mName = $request->getText( 'wpName' );
                $this->mPassword = $request->getText( 'wpPassword' );
                $this->mRetype = $request->getText( 'wpRetype' );
@@ -122,10 +120,12 @@ class LoginForm {
                        return;
                }
 
+               // Wipe the initial password and mail a temporary one
+               $u->setPassword( null );
                $u->saveSettings();
-               $result = $this->mailPasswordInternal($u);
+               $result = $this->mailPasswordInternal( $u, false, 'createaccount-title', 'createaccount-text' );
 
-               wfRunHooks( 'AddNewAccount', array( $u ) );
+               wfRunHooks( 'AddNewAccount', array( $u, true ) );
 
                $wgOut->setPageTitle( wfMsg( 'accmailtitle' ) );
                $wgOut->setRobotpolicy( 'noindex,nofollow' );
@@ -146,12 +146,12 @@ class LoginForm {
         */
        function addNewAccount() {
                global $wgUser, $wgEmailAuthentication;
-               
+
                # Create the account and abort if there's a problem doing so
                $u = $this->addNewAccountInternal();
                if( $u == NULL )
                        return;
-                       
+
                # If we showed up language selection links, and one was in use, be
                # smart (and sensible) and save that language as the user's preference
                global $wgLoginLanguageSelector;
@@ -160,8 +160,15 @@ class LoginForm {
 
                # Save user settings and send out an email authentication message if needed
                $u->saveSettings();
-               if( $wgEmailAuthentication && User::isValidEmailAddr( $u->getEmail() ) )
-                       $u->sendConfirmationMail();
+               if( $wgEmailAuthentication && User::isValidEmailAddr( $u->getEmail() ) ) {
+                       global $wgOut;
+                       $error = $u->sendConfirmationMail();
+                       if( WikiError::isError( $error ) ) {
+                               $wgOut->addWikiText( wfMsg( 'confirmemail_sendfailed', $error->getMessage() ) );
+                       } else {
+                               $wgOut->addWikiText( wfMsg( 'confirmemail_oncreate' ) );
+                       }
+               }
 
                # If not logged in, assume the new account as the current one and set session cookies
                # then show a "welcome" message or a "need cookies" message as needed
@@ -177,13 +184,12 @@ class LoginForm {
                } else {
                        # Confirm that the account was created
                        global $wgOut;
-                       $skin = $wgUser->getSkin();
-                       $self = Title::makeTitle( NS_SPECIAL, 'Userlogin' );
+                       $self = SpecialPage::getTitleFor( 'Userlogin' );
                        $wgOut->setPageTitle( wfMsgHtml( 'accountcreated' ) );
                        $wgOut->setArticleRelated( false );
                        $wgOut->setRobotPolicy( 'noindex,nofollow' );
                        $wgOut->addHtml( wfMsgWikiHtml( 'accountcreatedtext', $u->getName() ) );
-                       $wgOut->returnToMain( $self->getPrefixedText() );
+                       $wgOut->returnToMain( false, $self );
                        wfRunHooks( 'AddNewAccount', array( $u ) );
                        return true;
                }
@@ -197,6 +203,7 @@ class LoginForm {
                global $wgEnableSorbs, $wgProxyWhitelist;
                global $wgMemc, $wgAccountCreationThrottle;
                global $wgAuth, $wgMinimalPasswordLength;
+               global $wgEmailConfirmToEdit;
 
                // If the user passes an invalid domain, something is fishy
                if( !$wgAuth->validDomain( $this->mDomain ) ) {
@@ -222,9 +229,13 @@ class LoginForm {
                        return false;
                }
 
-               if (!$wgUser->isAllowedToCreateAccount()) {
+               # Check permissions
+               if ( !$wgUser->isAllowed( 'createaccount' ) ) {
                        $this->userNotPrivilegedMessage();
                        return false;
+               } elseif ( $wgUser->isBlockedFromCreateAccount() ) {
+                       $this->userBlockedMessage();
+                       return false;
                }
 
                $ip = wfGetIP();
@@ -235,6 +246,7 @@ class LoginForm {
                        return;
                }
 
+               # Now create a dummy user ($u) and check if it is valid
                $name = trim( $this->mName );
                $u = User::newFromName( $name, 'creatable' );
                if ( is_null( $u ) ) {
@@ -252,11 +264,34 @@ class LoginForm {
                        return false;
                }
 
-               if ( !$wgUser->isValidPassword( $this->mPassword ) ) {
-                       $this->mainLoginForm( wfMsg( 'passwordtooshort', $wgMinimalPasswordLength ) );
+               # check for minimal password length
+               if ( !$u->isValidPassword( $this->mPassword ) ) {
+                       if ( !$this->mCreateaccountMail ) {
+                               $this->mainLoginForm( wfMsg( 'passwordtooshort', $wgMinimalPasswordLength ) );
+                               return false;
+                       } else {
+                               # do not force a password for account creation by email
+                               # set pseudo password, it will be replaced later by a random generated password
+                               $this->mPassword = '-';
+                       }
+               }
+
+               # if you need a confirmed email address to edit, then obviously you need an email address.
+               if ( $wgEmailConfirmToEdit && empty( $this->mEmail ) ) {
+                       $this->mainLoginForm( wfMsg( 'noemailtitle' ) );
+                       return false;
+               }
+
+               if( !empty( $this->mEmail ) && !User::isValidEmailAddr( $this->mEmail ) ) {
+                       $this->mainLoginForm( wfMsg( 'invalidemailaddress' ) );
                        return false;
                }
 
+               # Set some additional data so the AbortNewAccount hook can be
+               # used for more than just username validation
+               $u->setEmail( $this->mEmail );
+               $u->setRealName( $this->mRealName );
+
                $abortError = '';
                if( !wfRunHooks( 'AbortNewAccount', array( $u, &$abortError ) ) ) {
                        // Hook point to add extra creation throttles and blocks
@@ -265,7 +300,7 @@ class LoginForm {
                        return false;
                }
 
-               if ( $wgAccountCreationThrottle ) {
+               if ( $wgAccountCreationThrottle && $wgUser->isPingLimitable() ) {
                        $key = wfMemcKey( 'acctcreate', 'ip', $ip );
                        $value = $wgMemc->incr( $key );
                        if ( !$value ) {
@@ -277,16 +312,12 @@ class LoginForm {
                        }
                }
 
-               if( !$wgAuth->addUser( $u, $this->mPassword ) ) {
+               if( !$wgAuth->addUser( $u, $this->mPassword, $this->mEmail, $this->mRealName ) ) {
                        $this->mainLoginForm( wfMsg( 'externaldberror' ) );
                        return false;
                }
 
-               # Update user count
-               $ssUpdate = new SiteStatsUpdate( 0, 0, 0, 0, 1 );
-               $ssUpdate->doUpdate();
-
-               return $this->initUser( $u );
+               return $this->initUser( $u, false );
        }
 
        /**
@@ -294,30 +325,45 @@ class LoginForm {
         * Give it a User object that has been initialised with a name.
         *
         * @param $u User object.
+        * @param $autocreate boolean -- true if this is an autocreation via auth plugin
         * @return User object.
         * @private
         */
-       function &initUser( &$u ) {
+       function initUser( $u, $autocreate ) {
+               global $wgAuth;
+
                $u->addToDatabase();
-               $u->setPassword( $this->mPassword );
+
+               if ( $wgAuth->allowPasswordChange() ) {
+                       $u->setPassword( $this->mPassword );
+               }
+
                $u->setEmail( $this->mEmail );
                $u->setRealName( $this->mRealName );
                $u->setToken();
 
-               global $wgAuth;
-               $wgAuth->initUser( $u );
+               $wgAuth->initUser( $u, $autocreate );
 
                $u->setOption( 'rememberpassword', $this->mRemember ? 1 : 0 );
+               $u->saveSettings();
+
+               # Update user count
+               $ssUpdate = new SiteStatsUpdate( 0, 0, 0, 0, 1 );
+               $ssUpdate->doUpdate();
 
                return $u;
        }
 
        /**
+        * Internally authenticate the login request.
+        *
+        * This may create a local account as a side effect if the
+        * authentication plugin allows transparent local account
+        * creation.
+        *
         * @public
         */
-       
-       function authenticateUserData()
-       {
+       function authenticateUserData() {
                global $wgUser, $wgAuth;
                if ( '' == $this->mName ) {
                        return self::NO_NAME;
@@ -335,7 +381,7 @@ class LoginForm {
                         */
                        if ( $wgAuth->autoCreate() && $wgAuth->userExists( $u->getName() ) ) {
                                if ( $wgAuth->authenticate( $u->getName(), $this->mPassword ) ) {
-                                       $u =& $this->initUser( $u );
+                                       $u = $this->initUser( $u, true );
                                } else {
                                        return self::WRONG_PLUGIN_PASS;
                                }
@@ -343,21 +389,58 @@ class LoginForm {
                                return self::NOT_EXISTS;
                        }
                } else {
-                       $u->loadFromDatabase();
+                       $u->load();
                }
 
-               if (!$u->checkPassword( $this->mPassword )) {
-                       return '' == $this->mPassword ? self::EMPTY_PASS : self::WRONG_PASS;
+               // Give general extensions, such as a captcha, a chance to abort logins
+               $abort = self::ABORTED;
+               if( !wfRunHooks( 'AbortLogin', array( $u, $this->mPassword, &$abort ) ) ) {
+                       return $abort;
                }
-               else
-               {       
+               
+               if (!$u->checkPassword( $this->mPassword )) {
+                       if( $u->checkTemporaryPassword( $this->mPassword ) ) {
+                               // The e-mailed temporary password should not be used
+                               // for actual logins; that's a very sloppy habit,
+                               // and insecure if an attacker has a few seconds to
+                               // click "search" on someone's open mail reader.
+                               //
+                               // Allow it to be used only to reset the password
+                               // a single time to a new value, which won't be in
+                               // the user's e-mail archives.
+                               //
+                               // For backwards compatibility, we'll still recognize
+                               // it at the login form to minimize surprises for
+                               // people who have been logging in with a temporary
+                               // password for some time.
+                               //
+                               // As a side-effect, we can authenticate the user's
+                               // e-mail address if it's not already done, since
+                               // the temporary password was sent via e-mail.
+                               //
+                               if( !$u->isEmailConfirmed() ) {
+                                       $u->confirmEmail();
+                               }
+
+                               // At this point we just return an appropriate code
+                               // indicating that the UI should show a password
+                               // reset form; bot interfaces etc will probably just
+                               // fail cleanly here.
+                               //
+                               $retval = self::RESET_PASS;
+                       } else {
+                               $retval = '' == $this->mPassword ? self::EMPTY_PASS : self::WRONG_PASS;
+                       }
+               } else {
                        $wgAuth->updateUser( $u );
                        $wgUser = $u;
 
-                       return self::SUCCESS;
+                       $retval = self::SUCCESS;
                }
+               wfRunHooks( 'LoginAuthenticateAudit', array( $u, $this->mPassword, $retval ) );
+               return $retval;
        }
-       
+
        function processLogin() {
                global $wgUser, $wgAuth;
 
@@ -388,7 +471,11 @@ class LoginForm {
                                $this->mainLoginForm( wfMsg( 'wrongpassword' ) );
                                break;
                        case self::NOT_EXISTS:
-                               $this->mainLoginForm( wfMsg( 'nosuchuser', htmlspecialchars( $this->mName ) ) );
+                               if( $wgUser->isAllowed( 'createaccount' ) ){
+                                       $this->mainLoginForm( wfMsg( 'nosuchuser', htmlspecialchars( $this->mName ) ) );
+                               } else {
+                                       $this->mainLoginForm( wfMsg( 'nosuchusershort', htmlspecialchars( $this->mName ) ) );
+                               }
                                break;
                        case self::WRONG_PASS:
                                $this->mainLoginForm( wfMsg( 'wrongpassword' ) );
@@ -396,30 +483,45 @@ class LoginForm {
                        case self::EMPTY_PASS:
                                $this->mainLoginForm( wfMsg( 'wrongpasswordempty' ) );
                                break;
+                       case self::RESET_PASS:
+                               $this->resetLoginForm( wfMsg( 'resetpass_announce' ) );
+                               break;
                        default:
                                wfDebugDieBacktrace( "Unhandled case value" );
                }
        }
 
+       function resetLoginForm( $error ) {
+               global $wgOut;
+               $wgOut->addWikiText( "<div class=\"errorbox\">$error</div>" );
+               $reset = new PasswordResetForm( $this->mName, $this->mPassword );
+               $reset->execute( null );
+       }
+
        /**
         * @private
         */
        function mailPassword() {
-               global $wgUser, $wgOut;
-               
+               global $wgUser, $wgOut, $wgAuth;
+
+               if( !$wgAuth->allowPasswordChange() ) {
+                       $this->mainLoginForm( wfMsg( 'resetpass_forbidden' ) );
+                       return;
+               }
+
                # Check against blocked IPs
                # fixme -- should we not?
                if( $wgUser->isBlocked() ) {
                        $this->mainLoginForm( wfMsg( 'blocked-mailpassword' ) );
                        return;
                }
-               
+
                # Check against the rate limiter
                if( $wgUser->pingLimiter( 'mailpassword' ) ) {
                        $wgOut->rateLimited();
                        return;
                }
-       
+
                if ( '' == $this->mName ) {
                        $this->mainLoginForm( wfMsg( 'noname' ) );
                        return;
@@ -434,9 +536,16 @@ class LoginForm {
                        return;
                }
 
-               $u->loadFromDatabase();
+               # Check against password throttle
+               if ( $u->isPasswordReminderThrottled() ) {
+                       global $wgPasswordReminderResendTime;
+                       # Round the time in hours to 3 d.p., in case someone is specifying minutes or seconds.
+                       $this->mainLoginForm( wfMsg( 'throttled-mailpassword',
+                               round( $wgPasswordReminderResendTime, 3 ) ) );
+                       return;
+               }
 
-               $result = $this->mailPasswordInternal( $u );
+               $result = $this->mailPasswordInternal( $u, true, 'passwordremindertitle', 'passwordremindertext' );
                if( WikiError::isError( $result ) ) {
                        $this->mainLoginForm( wfMsg( 'mailerror', $result->getMessage() ) );
                } else {
@@ -446,10 +555,14 @@ class LoginForm {
 
 
        /**
+        * @param object user
+        * @param bool throttle
+        * @param string message name of email title
+        * @param string message name of email text
         * @return mixed true on success, WikiError on failure
         * @private
         */
-       function mailPasswordInternal( $u ) {
+       function mailPasswordInternal( $u, $throttle = true, $emailTitle = 'passwordremindertitle', $emailText = 'passwordremindertext' ) {
                global $wgCookiePath, $wgCookieDomain, $wgCookiePrefix, $wgCookieSecure;
                global $wgServer, $wgScript;
 
@@ -458,7 +571,7 @@ class LoginForm {
                }
 
                $np = $u->randomPassword();
-               $u->setNewpassword( $np );
+               $u->setNewpassword( $np, $throttle );
 
                setcookie( "{$wgCookiePrefix}Token", '', time() - 3600, $wgCookiePath, $wgCookieDomain, $wgCookieSecure );
 
@@ -467,9 +580,9 @@ class LoginForm {
                $ip = wfGetIP();
                if ( '' == $ip ) { $ip = '(Unknown)'; }
 
-               $m = wfMsg( 'passwordremindertext', $ip, $u->getName(), $np, $wgServer . $wgScript );
+               $m = wfMsg( $emailText, $ip, $u->getName(), $np, $wgServer . $wgScript );
+               $result = $u->sendMail( wfMsg( $emailTitle ), $m );
 
-               $result = $u->sendMail( wfMsg( 'passwordremindertitle' ), $m );
                return $result;
        }
 
@@ -513,7 +626,7 @@ class LoginForm {
 
        /** */
        function userBlockedMessage() {
-               global $wgOut;
+               global $wgOut, $wgUser;
 
                # Let's be nice about this, it's likely that this feature will be used
                # for blocking large numbers of innocent people, e.g. range blocks on 
@@ -522,13 +635,16 @@ class LoginForm {
                # haven't bothered to log out before trying to create an account to 
                # evade it, but we'll leave that to their guilty conscience to figure
                # out.
-               
+
                $wgOut->setPageTitle( wfMsg( 'cantcreateaccounttitle' ) );
                $wgOut->setRobotpolicy( 'noindex,nofollow' );
                $wgOut->setArticleRelated( false );
 
                $ip = wfGetIP();
-               $wgOut->addWikiText( wfMsg( 'cantcreateaccounttext', $ip ) );
+               $blocker = User::whoIs( $wgUser->mBlock->mBy );
+               $block_reason = $wgUser->mBlock->mReason;
+
+               $wgOut->addWikiText( wfMsg( 'cantcreateaccount-text', $ip, $block_reason, $blocker ) );
                $wgOut->returnToMain( false );
        }
 
@@ -538,6 +654,7 @@ class LoginForm {
        function mainLoginForm( $msg, $msgtype = 'error' ) {
                global $wgUser, $wgOut, $wgAllowRealName, $wgEnableEmail;
                global $wgCookiePrefix, $wgAuth, $wgLoginLanguageSelector;
+               global $wgAuth, $wgEmailConfirmToEdit;
 
                if ( $this->mType == 'signup' ) {
                        if ( !$wgUser->isAllowed( 'createaccount' ) ) {
@@ -553,11 +670,11 @@ class LoginForm {
                        if ( $wgUser->isLoggedIn() ) {
                                $this->mName = $wgUser->getName();
                        } else {
-                               $this->mName = @$_COOKIE[$wgCookiePrefix.'UserName'];
+                               $this->mName = isset( $_COOKIE[$wgCookiePrefix.'UserName'] ) ? $_COOKIE[$wgCookiePrefix.'UserName'] : null;
                        }
                }
 
-               $titleObj = Title::makeTitle( NS_SPECIAL, 'Userlogin' );
+               $titleObj = SpecialPage::getTitleFor( 'Userlogin' );
 
                if ( $this->mType == 'signup' ) {
                        $template = new UsercreateTemplate();
@@ -576,13 +693,13 @@ class LoginForm {
                        $q .= $returnto;
                        $linkq .= $returnto;
                }
-               
+
                # Pass any language selection on to the mode switch link
                if( $wgLoginLanguageSelector && $this->mLanguage )
                        $linkq .= '&uselang=' . $this->mLanguage;
 
                $link = '<a href="' . htmlspecialchars ( $titleObj->getLocalUrl( $linkq ) ) . '">';
-               $link .= wfMsgHtml( $linkmsg . 'link' );
+               $link .= wfMsgHtml( $linkmsg . 'link' ); # Calling either 'gotaccountlink' or 'nologinlink'
                $link .= '</a>';
 
                # Don't show a "create account" link if the user can't
@@ -590,7 +707,7 @@ class LoginForm {
                        $template->set( 'link', wfMsgHtml( $linkmsg, $link ) );
                else
                        $template->set( 'link', '' );
-               
+
                $template->set( 'header', '' );
                $template->set( 'name', $this->mName );
                $template->set( 'password', $this->mPassword );
@@ -605,15 +722,17 @@ class LoginForm {
                $template->set( 'createemail', $wgEnableEmail && $wgUser->isLoggedIn() );
                $template->set( 'userealname', $wgAllowRealName );
                $template->set( 'useemail', $wgEnableEmail );
+               $template->set( 'emailrequired', $wgEmailConfirmToEdit );
+               $template->set( 'canreset', $wgAuth->allowPasswordChange() );
                $template->set( 'remember', $wgUser->getOption( 'rememberpassword' ) or $this->mRemember  );
-                               
+
                # Prepare language selection links as needed
                if( $wgLoginLanguageSelector ) {
                        $template->set( 'languages', $this->makeLanguageSelector() );
                        if( $this->mLanguage )
                                $template->set( 'uselang', $this->mLanguage );
                }
-               
+
                // Give authentication and captcha plugins a chance to modify the form
                $wgAuth->modifyUITemplate( $template );
                if ( $this->mType == 'signup' ) {
@@ -625,9 +744,10 @@ class LoginForm {
                $wgOut->setPageTitle( wfMsg( 'userlogin' ) );
                $wgOut->setRobotpolicy( 'noindex,nofollow' );
                $wgOut->setArticleRelated( false );
+               $wgOut->disallowUserJs();  // just in case...
                $wgOut->addTemplate( $template );
        }
-       
+
        /**
         * @private
         */
@@ -642,11 +762,17 @@ class LoginForm {
        }
 
        /**
+        * Check if a session cookie is present.
+        *
+        * This will not pick up a cookie set during _this_ request, but is
+        * meant to ensure that the client is returning the cookie which was
+        * set on a previous pass through the system.
+        *
         * @private
         */
        function hasSessionCookie() {
-               global $wgDisableCookieCheck;
-               return ( $wgDisableCookieCheck ) ? true : ( isset( $_COOKIE[session_name()] ) );
+               global $wgDisableCookieCheck, $wgRequest;
+               return $wgDisableCookieCheck ? true : $wgRequest->checkSessionCookie();
        }
 
        /**
@@ -655,7 +781,7 @@ class LoginForm {
        function cookieRedirectCheck( $type ) {
                global $wgOut;
 
-               $titleObj = Title::makeTitle( NS_SPECIAL, 'Userlogin' );
+               $titleObj = SpecialPage::getTitleFor( 'Userlogin' );
                $check = $titleObj->getFullURL( 'wpCookieCheck='.$type );
 
                return $wgOut->redirect( $check );
@@ -689,7 +815,7 @@ class LoginForm {
 
                $wgOut->addWikiText( wfMsg( 'acct_creation_throttle_hit', $limit ) );
        }
-       
+
        /**
         * Produce a bar of links which allow the user to select another language
         * during login/registration but retain "returnto"
@@ -704,14 +830,16 @@ class LoginForm {
                        foreach( $langs as $lang ) {
                                $lang = trim( $lang, '* ' );
                                $parts = explode( '|', $lang );
-                               $links[] = $this->makeLanguageSelectorLink( $parts[0], $parts[1] );
+                               if (count($parts) >= 2) {
+                                       $links[] = $this->makeLanguageSelectorLink( $parts[0], $parts[1] );
+                               }
                        }
                        return count( $links ) > 0 ? wfMsgHtml( 'loginlanguagelabel', implode( ' | ', $links ) ) : '';
                } else {
                        return '';
                }
        }
-       
+
        /**
         * Create a language selector link for a particular language
         * Links back to this page preserving type and returnto
@@ -721,15 +849,15 @@ class LoginForm {
         */
        function makeLanguageSelectorLink( $text, $lang ) {
                global $wgUser;
-               $self = Title::makeTitle( NS_SPECIAL, 'Userlogin' );
+               $self = SpecialPage::getTitleFor( 'Userlogin' );
                $attr[] = 'uselang=' . $lang;
                if( $this->mType == 'signup' )
                        $attr[] = 'type=signup';
                if( $this->mReturnTo )
                        $attr[] = 'returnto=' . $this->mReturnTo;
-               $skin =& $wgUser->getSkin();
+               $skin = $wgUser->getSkin();
                return $skin->makeKnownLinkObj( $self, htmlspecialchars( $text ), implode( '&', $attr ) );
        }
-       
 }
-?>
+
+