* De-crappified JS upload dest check feature. Converted to sajax framework. Comprehen...
[lhc/web/wiklou.git] / includes / SpecialUpload.php
index 3bfd26e..85579f3 100644 (file)
@@ -1,16 +1,10 @@
 <?php
 /**
  *
- * @package MediaWiki
- * @subpackage SpecialPage
+ * @addtogroup SpecialPage
  */
 
-/**
- *
- */
-require_once 'Image.php';
-require_once 'MacBinary.php';
-require_once 'Licenses.php';
+
 /**
  * Entry point
  */
@@ -21,18 +15,26 @@ function wfSpecialUpload() {
 }
 
 /**
- *
- * @package MediaWiki
- * @subpackage SpecialPage
+ * implements Special:Upload
+ * @addtogroup SpecialPage
  */
 class UploadForm {
        /**#@+
         * @access private
         */
-       var $mUploadFile, $mUploadDescription, $mLicense ,$mIgnoreWarning, $mUploadError;
-       var $mUploadSaveName, $mUploadTempName, $mUploadSize, $mUploadOldVersion;
-       var $mUploadCopyStatus, $mUploadSource, $mReUpload, $mAction, $mUpload;
-       var $mOname, $mSessionKey, $mStashed, $mDestFile, $mRemoveTempFile;
+       var $mComment, $mLicense, $mIgnoreWarning, $mCurlError;
+       var $mDestName, $mTempPath, $mFileSize, $mFileProps;
+       var $mCopyrightStatus, $mCopyrightSource, $mReUpload, $mAction, $mUploadClicked;
+       var $mSrcName, $mSessionKey, $mStashed, $mDesiredDestName, $mRemoveTempFile, $mSourceType;
+       var $mDestWarningAck, $mCurlDestHandle;
+       var $mLocalFile;
+
+       # Placeholders for text injection by hooks (must be HTML)
+       # extensions should take care to _append_ to the present value
+       var $uploadFormTextTop;
+       var $uploadFormTextAfterSummary;
+
+       const SESSION_VERSION = 1;
        /**#@-*/
 
        /**
@@ -41,29 +43,36 @@ class UploadForm {
         * @param $request Data posted.
         */
        function UploadForm( &$request ) {
-               $this->mDestFile          = $request->getText( 'wpDestFile' );
+               global $wgAllowCopyUploads;
+               $this->mDesiredDestName   = $request->getText( 'wpDestFile' );
+               $this->mIgnoreWarning     = $request->getCheck( 'wpIgnoreWarning' );
 
                if( !$request->wasPosted() ) {
                        # GET requests just give the main form; no data except wpDestfile.
                        return;
                }
 
-               $this->mIgnoreWarning     = $request->getCheck( 'wpIgnoreWarning');
+               # Placeholders for text injection by hooks (empty per default)
+               $this->uploadFormTextTop = "";
+               $this->uploadFormTextAfterSummary = "";
+
                $this->mReUpload          = $request->getCheck( 'wpReUpload' );
-               $this->mUpload            = $request->getCheck( 'wpUpload' );
+               $this->mUploadClicked     = $request->getCheck( 'wpUpload' );
 
-               $this->mUploadDescription = $request->getText( 'wpUploadDescription' );
+               $this->mComment           = $request->getText( 'wpUploadDescription' );
                $this->mLicense           = $request->getText( 'wpLicense' );
-               $this->mUploadCopyStatus  = $request->getText( 'wpUploadCopyStatus' );
-               $this->mUploadSource      = $request->getText( 'wpUploadSource' );
+               $this->mCopyrightStatus   = $request->getText( 'wpUploadCopyStatus' );
+               $this->mCopyrightSource   = $request->getText( 'wpUploadSource' );
                $this->mWatchthis         = $request->getBool( 'wpWatchthis' );
-               wfDebug( "UploadForm: watchthis is: '$this->mWatchthis'\n" );
+               $this->mSourceType        = $request->getText( 'wpSourceType' );
+               $this->mDestWarningAck    = $request->getText( 'wpDestFileWarningAck' );
 
                $this->mAction            = $request->getVal( 'action' );
 
                $this->mSessionKey        = $request->getInt( 'wpSessionKey' );
                if( !empty( $this->mSessionKey ) &&
-                       isset( $_SESSION['wsUploadData'][$this->mSessionKey] ) ) {
+                       isset( $_SESSION['wsUploadData'][$this->mSessionKey]['version'] ) && 
+                       $_SESSION['wsUploadData'][$this->mSessionKey]['version'] == self::SESSION_VERSION ) {
                        /**
                         * Confirming a temporarily stashed upload.
                         * We don't want path names to be forged, so we keep
@@ -71,24 +80,127 @@ class UploadForm {
                         * an opaque key to the user agent.
                         */
                        $data = $_SESSION['wsUploadData'][$this->mSessionKey];
-                       $this->mUploadTempName   = $data['mUploadTempName'];
-                       $this->mUploadSize       = $data['mUploadSize'];
-                       $this->mOname            = $data['mOname'];
-                       $this->mUploadError      = 0/*UPLOAD_ERR_OK*/;
+                       $this->mTempPath         = $data['mTempPath'];
+                       $this->mFileSize         = $data['mFileSize'];
+                       $this->mSrcName          = $data['mSrcName'];
+                       $this->mFileProps        = $data['mFileProps'];
+                       $this->mCurlError        = 0/*UPLOAD_ERR_OK*/;
                        $this->mStashed          = true;
                        $this->mRemoveTempFile   = false;
                } else {
                        /**
                         *Check for a newly uploaded file.
                         */
-                       $this->mUploadTempName = $request->getFileTempName( 'wpUploadFile' );
-                       $this->mUploadSize     = $request->getFileSize( 'wpUploadFile' );
-                       $this->mOname          = $request->getFileName( 'wpUploadFile' );
-                       $this->mUploadError    = $request->getUploadError( 'wpUploadFile' );
-                       $this->mSessionKey     = false;
-                       $this->mStashed        = false;
-                       $this->mRemoveTempFile = false; // PHP will handle this
+                       if( $wgAllowCopyUploads && $this->mSourceType == 'web' ) {
+                               $this->initializeFromUrl( $request );
+                       } else {
+                               $this->initializeFromUpload( $request );
+                       }
+               }
+       }
+
+       /**
+        * Initialize the uploaded file from PHP data
+        * @access private
+        */
+       function initializeFromUpload( $request ) {
+               $this->mTempPath       = $request->getFileTempName( 'wpUploadFile' );
+               $this->mFileSize       = $request->getFileSize( 'wpUploadFile' );
+               $this->mSrcName        = $request->getFileName( 'wpUploadFile' );
+               $this->mCurlError      = $request->getUploadError( 'wpUploadFile' );
+               $this->mSessionKey     = false;
+               $this->mStashed        = false;
+               $this->mRemoveTempFile = false; // PHP will handle this
+       }
+
+       /**
+        * Copy a web file to a temporary file
+        * @access private
+        */
+       function initializeFromUrl( $request ) {
+               global $wgTmpDirectory;
+               $url = $request->getText( 'wpUploadFileURL' );
+               $local_file = tempnam( $wgTmpDirectory, 'WEBUPLOAD' );
+
+               $this->mTempPath       = $local_file;
+               $this->mFileSize       = 0; # Will be set by curlCopy
+               $this->mCurlError      = $this->curlCopy( $url, $local_file );
+               $this->mSrcName        = array_pop( explode( '/', $url ) );
+               $this->mSessionKey     = false;
+               $this->mStashed        = false;
+
+               // PHP won't auto-cleanup the file
+               $this->mRemoveTempFile = file_exists( $local_file );
+       }
+
+       /**
+        * Safe copy from URL
+        * Returns true if there was an error, false otherwise
+        */
+       private function curlCopy( $url, $dest ) {
+               global $wgUser, $wgOut;
+
+               if( !$wgUser->isAllowed( 'upload_by_url' ) ) {
+                       $wgOut->permissionRequired( 'upload_by_url' );
+                       return true;
+               }
+
+               # Maybe remove some pasting blanks :-)
+               $url =  trim( $url );
+               if( stripos($url, 'http://') !== 0 && stripos($url, 'ftp://') !== 0 ) {
+                       # Only HTTP or FTP URLs
+                       $wgOut->errorPage( 'upload-proto-error', 'upload-proto-error-text' );
+                       return true;
+               }
+
+               # Open temporary file
+               $this->mCurlDestHandle = @fopen( $this->mTempPath, "wb" );
+               if( $this->mCurlDestHandle === false ) {
+                       # Could not open temporary file to write in
+                       $wgOut->errorPage( 'upload-file-error', 'upload-file-error-text');
+                       return true;
+               }
+
+               $ch = curl_init();
+               curl_setopt( $ch, CURLOPT_HTTP_VERSION, 1.0); # Probably not needed, but apparently can work around some bug
+               curl_setopt( $ch, CURLOPT_TIMEOUT, 10); # 10 seconds timeout
+               curl_setopt( $ch, CURLOPT_LOW_SPEED_LIMIT, 512); # 0.5KB per second minimum transfer speed
+               curl_setopt( $ch, CURLOPT_URL, $url);
+               curl_setopt( $ch, CURLOPT_WRITEFUNCTION, array( $this, 'uploadCurlCallback' ) );
+               curl_exec( $ch );
+               $error = curl_errno( $ch ) ? true : false;
+               $errornum =  curl_errno( $ch );
+               // if ( $error ) print curl_error ( $ch ) ; # Debugging output
+               curl_close( $ch );
+
+               fclose( $this->mCurlDestHandle );
+               unset( $this->mCurlDestHandle );
+               if( $error ) {
+                       unlink( $dest );
+                       if( wfEmptyMsg( "upload-curl-error$errornum", wfMsg("upload-curl-error$errornum") ) )
+                               $wgOut->errorPage( 'upload-misc-error', 'upload-misc-error-text' );
+                       else
+                               $wgOut->errorPage( "upload-curl-error$errornum", "upload-curl-error$errornum-text" );
                }
+
+               return $error;
+       }
+
+       /**
+        * Callback function for CURL-based web transfer
+        * Write data to file unless we've passed the length limit;
+        * if so, abort immediately.
+        * @access private
+        */
+       function uploadCurlCallback( $ch, $data ) {
+               global $wgMaxUploadSize;
+               $length = strlen( $data );
+               $this->mFileSize += $length;
+               if( $this->mFileSize > $wgMaxUploadSize ) {
+                       return 0;
+               }
+               fwrite( $this->mCurlDestHandle, $data );
+               return $length;
        }
 
        /**
@@ -97,24 +209,23 @@ class UploadForm {
         */
        function execute() {
                global $wgUser, $wgOut;
-               global $wgEnableUploads, $wgUploadDirectory;
+               global $wgEnableUploads;
 
                # Check uploading enabled
                if( !$wgEnableUploads ) {
-                       $wgOut->errorPage( 'uploaddisabled', 'uploaddisabledtext' );
+                       $wgOut->showErrorPage( 'uploaddisabled', 'uploaddisabledtext', array( $this->mDesiredDestName ) );
                        return;
                }
 
                # Check permissions
-               if( $wgUser->isLoggedIn() ) {
-                       if( !$wgUser->isAllowed( 'upload' ) ) {
+               if( !$wgUser->isAllowed( 'upload' ) ) {
+                       if( !$wgUser->isLoggedIn() ) {
+                               $wgOut->showErrorPage( 'uploadnologin', 'uploadnologintext' );
+                       } else {
                                $wgOut->permissionRequired( 'upload' );
-                               return;
                        }
-               } else {
-                       $wgOut->errorPage( 'uploadnologin', 'uploadnologintext' );
                        return;
-               }       
+               }
 
                # Check blocks
                if( $wgUser->isBlocked() ) {
@@ -127,16 +238,12 @@ class UploadForm {
                        return;
                }
 
-               /** Check if the image directory is writeable, this is a common mistake */
-               if ( !is_writeable( $wgUploadDirectory ) ) {
-                       $wgOut->addWikiText( wfMsg( 'upload_directory_read_only', $wgUploadDirectory ) );
-                       return;
-               }
-
                if( $this->mReUpload ) {
-                       $this->unsaveUploadedFile();
+                       if( !$this->unsaveUploadedFile() ) {
+                               return;
+                       }
                        $this->mainUploadForm();
-               } else if ( 'submit' == $this->mAction || $this->mUpload ) {
+               } else if( 'submit' == $this->mAction || $this->mUploadClicked ) {
                        $this->processUpload();
                } else {
                        $this->mainUploadForm();
@@ -155,8 +262,14 @@ class UploadForm {
        function processUpload() {
                global $wgUser, $wgOut;
 
+               if( !wfRunHooks( 'UploadForm:BeforeProcessing', array( &$this ) ) )
+               {
+                       wfDebug( "Hook 'UploadForm:BeforeProcessing' broke processing the file." );
+                       return false;
+               }
+
                /* Check for PHP error if any, requires php 4.2 or newer */
-               if ( $this->mUploadError == 1/*UPLOAD_ERR_INI_SIZE*/ ) {
+               if( $this->mCurlError == 1/*UPLOAD_ERR_INI_SIZE*/ ) {
                        $this->mainUploadForm( wfMsgHtml( 'largefileserver' ) );
                        return;
                }
@@ -164,16 +277,16 @@ class UploadForm {
                /**
                 * If there was no filename or a zero size given, give up quick.
                 */
-               if( trim( $this->mOname ) == '' || empty( $this->mUploadSize ) ) {
+               if( trim( $this->mSrcName ) == '' || empty( $this->mFileSize ) ) {
                        $this->mainUploadForm( wfMsgHtml( 'emptyfile' ) );
                        return;
                }
 
                # Chop off any directories in the given filename
-               if ( $this->mDestFile ) {
-                       $basename = wfBaseName( $this->mDestFile );
+               if( $this->mDesiredDestName ) {
+                       $basename = wfBaseName( $this->mDesiredDestName );
                } else {
-                       $basename = wfBaseName( $this->mOname );
+                       $basename = wfBaseName( $this->mSrcName );
                }
 
                /**
@@ -181,15 +294,22 @@ class UploadForm {
                 * only the final one for the whitelist.
                 */
                list( $partname, $ext ) = $this->splitExtensions( $basename );
+
                if( count( $ext ) ) {
                        $finalExt = $ext[count( $ext ) - 1];
                } else {
                        $finalExt = '';
                }
-               $fullExt = implode( '.', $ext );
 
-               if ( strlen( $partname ) < 3 ) {
-                       $this->mainUploadForm( wfMsgHtml( 'minlength' ) );
+               # If there was more than one "extension", reassemble the base
+               # filename to prevent bogus complaints about length
+               if( count( $ext ) > 1 ) {
+                       for( $i = 0; $i < count( $ext ) - 1; $i++ )
+                               $partname .= '.' . $ext[$i];
+               }
+
+               if( strlen( $partname ) < 1 ) {
+                       $this->mainUploadForm( wfMsgHtml( 'minlength1' ) );
                        return;
                }
 
@@ -198,26 +318,26 @@ class UploadForm {
                 * out of it. We'll strip some silently that Title would die on.
                 */
                $filtered = preg_replace ( "/[^".Title::legalChars()."]|:/", '-', $basename );
-               $nt = Title::newFromText( $filtered );
+               $nt = Title::makeTitleSafe( NS_IMAGE, $filtered );
                if( is_null( $nt ) ) {
                        $this->uploadError( wfMsgWikiHtml( 'illegalfilename', htmlspecialchars( $filtered ) ) );
                        return;
                }
-               $nt =& Title::makeTitle( NS_IMAGE, $nt->getDBkey() );
-               $this->mUploadSaveName = $nt->getDBkey();
+               $this->mLocalFile = wfLocalFile( $nt );
+               $this->mDestName = $this->mLocalFile->getName();
 
                /**
                 * If the image is protected, non-sysop users won't be able
                 * to modify it by uploading a new revision.
                 */
-               if( !$nt->userCanEdit() ) {
+               if( !$nt->userCan( 'edit' ) ) {
                        return $this->uploadError( wfMsgWikiHtml( 'protectedpage' ) );
                }
 
                /**
                 * In some cases we may forbid overwriting of existing files.
                 */
-               $overwrite = $this->checkOverwrite( $this->mUploadSaveName );
+               $overwrite = $this->checkOverwrite( $this->mDestName );
                if( WikiError::isError( $overwrite ) ) {
                        return $this->uploadError( $overwrite->toString() );
                }
@@ -225,10 +345,12 @@ class UploadForm {
                /* Don't allow users to override the blacklist (check file extension) */
                global $wgStrictFileExtensions;
                global $wgFileExtensions, $wgFileBlacklist;
-               if( $this->checkFileExtensionList( $ext, $wgFileBlacklist ) ||
-                       ($wgStrictFileExtensions &&
-                               !$this->checkFileExtension( $finalExt, $wgFileExtensions ) ) ) {
-                       return $this->uploadError( wfMsgHtml( 'badfiletype', htmlspecialchars( $fullExt ) ) );
+               if ($finalExt == '') {
+                       return $this->uploadError( wfMsgExt( 'filetype-missing', array ( 'parseinline' ) ) );
+               } elseif ( $this->checkFileExtensionList( $ext, $wgFileBlacklist ) ||
+                               ($wgStrictFileExtensions && !$this->checkFileExtension( $finalExt, $wgFileExtensions ) ) ) {
+                       return $this->uploadError( wfMsgExt( 'filetype-badtype', array ( 'parseinline' ), 
+                               htmlspecialchars( $finalExt ), implode ( ', ', $wgFileExtensions ) ) );
                }
 
                /**
@@ -237,23 +359,25 @@ class UploadForm {
                 * probably not accept it.
                 */
                if( !$this->mStashed ) {
+                       $this->mFileProps = File::getPropsFromPath( $this->mTempPath, $finalExt );
                        $this->checkMacBinary();
-                       $veri = $this->verify( $this->mUploadTempName, $finalExt );
+                       $veri = $this->verify( $this->mTempPath, $finalExt );
 
                        if( $veri !== true ) { //it's a wiki error...
                                return $this->uploadError( $veri->toString() );
                        }
-               }
 
-               /**
-                * Provide an opportunity for extensions to add futher checks
-                */
-               $error = '';
-               if( !wfRunHooks( 'UploadVerification',
-                               array( $this->mUploadSaveName, $this->mUploadTempName, &$error ) ) ) {
-                       return $this->uploadError( $error );
+                       /**
+                        * Provide an opportunity for extensions to add futher checks
+                        */
+                       $error = '';
+                       if( !wfRunHooks( 'UploadVerification',
+                                       array( $this->mDestName, $this->mTempPath, &$error ) ) ) {
+                               return $this->uploadError( $error );
+                       }
                }
 
+
                /**
                 * Check for non-fatal conditions
                 */
@@ -264,34 +388,32 @@ class UploadForm {
                        if( $wgCapitalLinks ) {
                                $filtered = ucfirst( $filtered );
                        }
-                       if( $this->mUploadSaveName != $filtered ) {
-                               $warning .=  '<li>'.wfMsgHtml( 'badfilename', htmlspecialchars( $this->mUploadSaveName ) ).'</li>';
+                       if( $this->mDestName != $filtered ) {
+                               $warning .=  '<li>'.wfMsgHtml( 'badfilename', htmlspecialchars( $this->mDestName ) ).'</li>';
                        }
 
                        global $wgCheckFileExtensions;
                        if ( $wgCheckFileExtensions ) {
                                if ( ! $this->checkFileExtension( $finalExt, $wgFileExtensions ) ) {
-                                       $warning .= '<li>'.wfMsgHtml( 'badfiletype', htmlspecialchars( $fullExt ) ).'</li>';
+                                       $warning .= '<li>'.wfMsgExt( 'filetype-badtype', array ( 'parseinline' ), 
+                                               htmlspecialchars( $finalExt ), implode ( ', ', $wgFileExtensions ) ).'</li>';
                                }
                        }
 
                        global $wgUploadSizeWarning;
-                       if ( $wgUploadSizeWarning && ( $this->mUploadSize > $wgUploadSizeWarning ) ) {
-                               # TODO: Format $wgUploadSizeWarning to something that looks better than the raw byte
-                               # value, perhaps add GB,MB and KB suffixes?
-                               $warning .= '<li>'.wfMsgHtml( 'largefile', $wgUploadSizeWarning, $this->mUploadSize ).'</li>';
+                       if ( $wgUploadSizeWarning && ( $this->mFileSize > $wgUploadSizeWarning ) ) {
+                               $skin = $wgUser->getSkin();
+                               $wsize = $skin->formatSize( $wgUploadSizeWarning );
+                               $asize = $skin->formatSize( $this->mFileSize );
+                               $warning .= '<li>' . wfMsgHtml( 'large-file', $wsize, $asize ) . '</li>';
                        }
-                       if ( $this->mUploadSize == 0 ) {
+                       if ( $this->mFileSize == 0 ) {
                                $warning .= '<li>'.wfMsgHtml( 'emptyfile' ).'</li>';
                        }
 
-                       if( $nt->getArticleID() ) {
-                               global $wgUser;
-                               $sk = $wgUser->getSkin();
-                               $dlink = $sk->makeKnownLinkObj( $nt );
-                               $warning .= '<li>'.wfMsgHtml( 'fileexists', $dlink ).'</li>';
+                       if ( !$this->mDestWarningAck ) {
+                               $warning .= self::getExistsWarning( $this->mLocalFile );
                        }
-
                        if( $warning != '' ) {
                                /**
                                 * Stash the file in a temporary location; the user can choose
@@ -305,85 +427,134 @@ class UploadForm {
                 * Try actually saving the thing...
                 * It will show an error form on failure.
                 */
-               $hasBeenMunged = !empty( $this->mSessionKey ) || $this->mRemoveTempFile;
-               if( $this->saveUploadedFile( $this->mUploadSaveName,
-                                            $this->mUploadTempName,
-                                            $hasBeenMunged ) ) {
-                       /**
-                        * Update the upload log and create the description page
-                        * if it's a new file.
-                        */
-                       $img = Image::newFromName( $this->mUploadSaveName );
-                       $success = $img->recordUpload( $this->mUploadOldVersion,
-                                                       $this->mUploadDescription,
-                                                       $this->mLicense,
-                                                       $this->mUploadCopyStatus,
-                                                       $this->mUploadSource,
-                                                       $this->mWatchthis );
-
-                       if ( $success ) {
-                               $this->showSuccess();
-                       } else {
-                               // Image::recordUpload() fails if the image went missing, which is
-                               // unlikely, hence the lack of a specialised message
-                               $wgOut->fileNotFoundError( $this->mUploadSaveName );
+               $pageText = self::getInitialPageText( $this->mComment, $this->mLicense,
+                       $this->mCopyrightStatus, $this->mCopyrightSource );
+
+               $status = $this->mLocalFile->upload( $this->mTempPath, $this->mComment, $pageText, 
+                       File::DELETE_SOURCE, $this->mFileProps );
+               if ( WikiError::isError( $status ) ) {
+                       $this->showError( $status );
+               } else {
+                       if ( $this->mWatchthis ) {
+                               global $wgUser;
+                               $wgUser->addWatch( $this->mLocalFile->getTitle() );
                        }
+                       // Success, redirect to description page
+                       $wgOut->redirect( $this->mLocalFile->getTitle()->getFullURL() );
+                       wfRunHooks( 'UploadComplete', array( &$img ) );
                }
        }
 
        /**
-        * Move the uploaded file from its temporary location to the final
-        * destination. If a previous version of the file exists, move
-        * it into the archive subdirectory.
-        *
-        * @todo If the later save fails, we may have disappeared the original file.
-        *
-        * @param string $saveName
-        * @param string $tempName full path to the temporary file
-        * @param bool $useRename if true, doesn't check that the source file
-        *                        is a PHP-managed upload temporary
+        * Do existence checks on a file and produce a warning
+        * This check is static and can be done pre-upload via AJAX
+        * Returns an HTML fragment consisting of one or more LI elements if there is a warning
+        * Returns an empty string if there is no warning
         */
-       function saveUploadedFile( $saveName, $tempName, $useRename = false ) {
-               global $wgOut;
+       static function getExistsWarning( $file ) {
+               global $wgUser;
+               // Check for uppercase extension. We allow these filenames but check if an image
+               // with lowercase extension exists already
+               $warning = '';
+               $ext = $file->getExtension();
+               $sk = $wgUser->getSkin();
+               if ( $ext !== '' ) {
+                       $partname = substr( $file->getName(), 0, -strlen( $ext ) - 1 );
+               } else {
+                       $partname = $file->getName();
+               }
 
-               $fname= "SpecialUpload::saveUploadedFile";
+               if ( $ext != strtolower( $ext ) ) {
+                       $nt_lc = Title::newFromText( $partname . '.' . strtolower( $ext ) );
+                       $file_lc = wfLocalFile( $nt_lc );
+               } else {
+                       $file_lc = false;
+               }
 
-               $dest = wfImageDir( $saveName );
-               $archive = wfImageArchiveDir( $saveName );
-               $this->mSavedFile = "{$dest}/{$saveName}";
+               if( $file->exists() ) {
+                       $dlink = $sk->makeKnownLinkObj( $file->getTitle() );
+                       if ( $file->allowInlineDisplay() ) {
+                               $dlink2 = $sk->makeImageLinkObj( $file->getTitle(), wfMsgExt( 'fileexists-thumb', 'parseinline', $dlink ), 
+                                       $file->getName(), 'right', array(), false, true );
+                       } elseif ( !$file->allowInlineDisplay() && $file->isSafeFile() ) {
+                               $icon = $file->iconThumb();
+                               $dlink2 = '<div style="float:right" id="mw-media-icon"><a href="' . $file->getURL() . '">' . 
+                                       $icon->toHtml() . '</a><br />' . $dlink . '</div>';
+                       } else {
+                               $dlink2 = '';
+                       }
 
-               if( is_file( $this->mSavedFile ) ) {
-                       $this->mUploadOldVersion = gmdate( 'YmdHis' ) . "!{$saveName}";
-                       wfSuppressWarnings();
-                       $success = rename( $this->mSavedFile, "${archive}/{$this->mUploadOldVersion}" );
-                       wfRestoreWarnings();
+                       $warning .= '<li>' . wfMsgExt( 'fileexists', 'parseline', $dlink ) . '</li>' . $dlink2;
+
+               } elseif ( $file_lc && $file_lc->exists() ) {
+                       # Check if image with lowercase extension exists.
+                       # It's not forbidden but in 99% it makes no sense to upload the same filename with uppercase extension
+                       $dlink = $sk->makeKnownLinkObj( $nt_lc );
+                       if ( $file_lc->allowInlineDisplay() ) {
+                               $dlink2 = $sk->makeImageLinkObj( $nt_lc, wfMsgExt( 'fileexists-thumb', 'parseinline', $dlink ), 
+                                       $nt_lc->getText(), 'right', array(), false, true );
+                       } elseif ( !$file_lc->allowInlineDisplay() && $file_lc->isSafeFile() ) {
+                               $icon = $file_lc->iconThumb();
+                               $dlink2 = '<div style="float:right" id="mw-media-icon"><a href="' . $file_lc->getURL() . '">' . 
+                                       $icon->toHtml() . '</a><br />' . $dlink . '</div>';
+                       } else {
+                               $dlink2 = '';
+                       }
 
-                       if( ! $success ) {
-                               $wgOut->fileRenameError( $this->mSavedFile,
-                                 "${archive}/{$this->mUploadOldVersion}" );
-                               return false;
+                       $warning .= '<li>' . wfMsgExt( 'fileexists-extension', 'parsemag' , $partname . '.' 
+                               . $ext , $dlink ) . '</li>' . $dlink2;                          
+
+               } elseif ( ( substr( $partname , 3, 3 ) == 'px-' || substr( $partname , 2, 3 ) == 'px-' ) 
+                       && ereg( "[0-9]{2}" , substr( $partname , 0, 2) ) )
+               {
+                       # Check for filenames like 50px- or 180px-, these are mostly thumbnails
+                       $nt_thb = Title::newFromText( substr( $partname , strpos( $partname , '-' ) +1 ) . '.' . $ext );
+                       $file_thb = wfLocalFile( $nt_thb );
+                       if ($file_thb->exists() ) {
+                               # Check if an image without leading '180px-' (or similiar) exists
+                               $dlink = $sk->makeKnownLinkObj( $nt_thb);
+                               if ( $file_thb->allowInlineDisplay() ) {
+                                       $dlink2 = $sk->makeImageLinkObj( $nt_thb, 
+                                               wfMsgExt( 'fileexists-thumb', 'parseinline', $dlink ), 
+                                               $nt_thb->getText(), 'right', array(), false, true );
+                               } elseif ( !$file_thb->allowInlineDisplay() && $file_thb->isSafeFile() ) {
+                                       $icon = $file_thb->iconThumb();
+                                       $dlink2 = '<div style="float:right" id="mw-media-icon"><a href="' . 
+                                               $file_thb->getURL() . '">' . $icon->toHtml() . '</a><br />' . 
+                                               $dlink . '</div>';
+                               } else {
+                                       $dlink2 = '';
+                               }
+
+                               $warning .= '<li>' . wfMsgExt( 'fileexists-thumbnail-yes', 'parsemag', $dlink ) . 
+                                       '</li>' . $dlink2;      
+                       } else {
+                               # Image w/o '180px-' does not exists, but we do not like these filenames
+                               $warning .= '<li>' . wfMsgExt( 'file-thumbnail-no', 'parseinline' , 
+                                       substr( $partname , 0, strpos( $partname , '-' ) +1 ) ) . '</li>';
                        }
-                       else wfDebug("$fname: moved file ".$this->mSavedFile." to ${archive}/{$this->mUploadOldVersion}\n");
                }
-               else {
-                       $this->mUploadOldVersion = '';
+               if ( $file->wasDeleted() ) {
+                       # If the file existed before and was deleted, warn the user of this
+                       # Don't bother doing so if the image exists now, however
+                       $ltitle = SpecialPage::getTitleFor( 'Log' );
+                       $llink = $sk->makeKnownLinkObj( $ltitle, wfMsgHtml( 'deletionlog' ), 
+                               'type=delete&page=' . $file->getTitle()->getPrefixedUrl() );
+                       $warning .= '<li>' . wfMsgWikiHtml( 'filewasdeleted', $llink ) . '</li>';
                }
+               return $warning;
+       }
 
-               wfSuppressWarnings();
-               $success = $useRename
-                       ? rename( $tempName, $this->mSavedFile )
-                       : move_uploaded_file( $tempName, $this->mSavedFile );
-               wfRestoreWarnings();
-
-               if( ! $success ) {
-                       $wgOut->fileCopyError( $tempName, $this->mSavedFile );
-                       return false;
-               } else {
-                       wfDebug("$fname: wrote tempfile $tempName to ".$this->mSavedFile."\n");
+       static function ajaxGetExistsWarning( $filename ) {
+               $file = wfFindFile( $filename );
+               $s = '&nbsp;';
+               if ( $file ) {
+                       $warning = self::getExistsWarning( $file );
+                       if ( $warning !== '' ) {
+                               $s = "<ul>$warning</ul>";
+                       }
                }
-
-               chmod( $this->mSavedFile, 0644 );
-               return true;
+               return $s;
        }
 
        /**
@@ -400,18 +571,14 @@ class UploadForm {
         */
        function saveTempUploadedFile( $saveName, $tempName ) {
                global $wgOut;
-               $archive = wfImageArchiveDir( $saveName, 'temp' );
-               $stash = $archive . '/' . gmdate( "YmdHis" ) . '!' . $saveName;
-
-               $success = $this->mRemoveTempFile
-                       ? rename( $tempName, $stash )
-                       : move_uploaded_file( $tempName, $stash );
-               if ( !$success ) {
-                       $wgOut->fileCopyError( $tempName, $stash );
+               $repo = RepoGroup::singleton()->getLocalRepo();
+               $result = $repo->storeTemp( $saveName, $tempName );
+               if ( WikiError::isError( $result ) ) {
+                       $this->showError( $result );
                        return false;
+               } else {
+                       return $result;
                }
-
-               return $stash;
        }
 
        /**
@@ -424,8 +591,7 @@ class UploadForm {
         * @access private
         */
        function stashSession() {
-               $stash = $this->saveTempUploadedFile(
-                       $this->mUploadSaveName, $this->mUploadTempName );
+               $stash = $this->saveTempUploadedFile( $this->mDestName, $this->mTempPath );
 
                if( !$stash ) {
                        # Couldn't save the file.
@@ -434,46 +600,34 @@ class UploadForm {
 
                $key = mt_rand( 0, 0x7fffffff );
                $_SESSION['wsUploadData'][$key] = array(
-                       'mUploadTempName' => $stash,
-                       'mUploadSize'     => $this->mUploadSize,
-                       'mOname'          => $this->mOname );
+                       'mTempPath'       => $stash,
+                       'mFileSize'       => $this->mFileSize,
+                       'mSrcName'        => $this->mSrcName,
+                       'mFileProps'      => $this->mFileProps,
+                       'version'         => self::SESSION_VERSION,
+               );
                return $key;
        }
 
        /**
         * Remove a temporarily kept file stashed by saveTempUploadedFile().
         * @access private
+        * @return success
         */
        function unsaveUploadedFile() {
                global $wgOut;
-               wfSuppressWarnings();
-               $success = unlink( $this->mUploadTempName );
-               wfRestoreWarnings();
+               $repo = RepoGroup::singleton()->getLocalRepo();
+               $success = $repo->freeTemp( $this->mTempPath );
                if ( ! $success ) {
-                       $wgOut->fileDeleteError( $this->mUploadTempName );
+                       $wgOut->showFileDeleteError( $this->mTempPath );
+                       return false;
+               } else {
+                       return true;
                }
        }
 
        /* -------------------------------------------------------------- */
 
-       /**
-        * Show some text and linkage on successful upload.
-        * @access private
-        */
-       function showSuccess() {
-               global $wgUser, $wgOut, $wgContLang;
-
-               $sk = $wgUser->getSkin();
-               $ilink = $sk->makeMediaLink( $this->mUploadSaveName, Image::imageUrl( $this->mUploadSaveName ) );
-               $dname = $wgContLang->getNsText( NS_IMAGE ) . ':'.$this->mUploadSaveName;
-               $dlink = $sk->makeKnownLink( $dname, $dname );
-
-               $wgOut->addHTML( '<h2>' . wfMsgHtml( 'successfulupload' ) . "</h2>\n" );
-               $text = wfMsgWikiHtml( 'fileuploaded', $ilink, $dlink );
-               $wgOut->addHTML( $text );
-               $wgOut->returnToMain( false );
-       }
-
        /**
         * @param string $error as HTML
         * @access private
@@ -509,14 +663,14 @@ class UploadForm {
                $reupload = wfMsgHtml( 'reupload' );
                $iw = wfMsgWikiHtml( 'ignorewarning' );
                $reup = wfMsgWikiHtml( 'reuploaddesc' );
-               $titleObj = Title::makeTitle( NS_SPECIAL, 'Upload' );
+               $titleObj = SpecialPage::getTitleFor( 'Upload' );
                $action = $titleObj->escapeLocalURL( 'action=submit' );
 
                if ( $wgUseCopyrightUpload )
                {
                        $copyright =  "
-       <input type='hidden' name='wpUploadCopyStatus' value=\"" . htmlspecialchars( $this->mUploadCopyStatus ) . "\" />
-       <input type='hidden' name='wpUploadSource' value=\"" . htmlspecialchars( $this->mUploadSource ) . "\" />
+       <input type='hidden' name='wpUploadCopyStatus' value=\"" . htmlspecialchars( $this->mCopyrightStatus ) . "\" />
+       <input type='hidden' name='wpUploadSource' value=\"" . htmlspecialchars( $this->mCopyrightSource ) . "\" />
        ";
                } else {
                        $copyright = "";
@@ -526,22 +680,22 @@ class UploadForm {
        <form id='uploadwarning' method='post' enctype='multipart/form-data' action='$action'>
                <input type='hidden' name='wpIgnoreWarning' value='1' />
                <input type='hidden' name='wpSessionKey' value=\"" . htmlspecialchars( $this->mSessionKey ) . "\" />
-               <input type='hidden' name='wpUploadDescription' value=\"" . htmlspecialchars( $this->mUploadDescription ) . "\" />
+               <input type='hidden' name='wpUploadDescription' value=\"" . htmlspecialchars( $this->mComment ) . "\" />
                <input type='hidden' name='wpLicense' value=\"" . htmlspecialchars( $this->mLicense ) . "\" />
-               <input type='hidden' name='wpDestFile' value=\"" . htmlspecialchars( $this->mDestFile ) . "\" />
+               <input type='hidden' name='wpDestFile' value=\"" . htmlspecialchars( $this->mDesiredDestName ) . "\" />
                <input type='hidden' name='wpWatchthis' value=\"" . htmlspecialchars( intval( $this->mWatchthis ) ) . "\" />
        {$copyright}
        <table border='0'>
                <tr>
                        <tr>
                                <td align='right'>
-                                       <input tabindex='2' type='submit' name='wpUpload' value='$save' />
+                                       <input tabindex='2' type='submit' name='wpUpload' value=\"$save\" />
                                </td>
                                <td align='left'>$iw</td>
                        </tr>
                        <tr>
                                <td align='right'>
-                                       <input tabindex='2' type='submit' name='wpReUpload' value='{$reupload}' />
+                                       <input tabindex='2' type='submit' name='wpReUpload' value=\"{$reupload}\" />
                                </td>
                                <td align='left'>$reup</td>
                        </tr>
@@ -558,7 +712,21 @@ class UploadForm {
         */
        function mainUploadForm( $msg='' ) {
                global $wgOut, $wgUser;
-               global $wgUseCopyrightUpload;
+               global $wgUseCopyrightUpload, $wgAjaxUploadDestCheck;
+               global $wgRequest, $wgAllowCopyUploads, $wgEnableAPI;
+               global $wgStylePath;
+
+               $wgOut->addScript( 
+                       "<script type='text/javascript'>wgAjaxUploadDestCheck = " . 
+                               ($wgAjaxUploadDestCheck ? 'true' : 'false' ) . ";</script>\n" . 
+                       "<script type='text/javascript' src=\"$wgStylePath/common/upload.js?1\"></script>\n" 
+               );
+
+               if( !wfRunHooks( 'UploadForm:initial', array( &$this ) ) )
+               {
+                       wfDebug( "Hook 'UploadForm:initial' broke output of the upload form" );
+                       return false;
+               }
 
                $cols = intval($wgUser->getOption( 'cols' ));
                $ew = $wgUser->getOption( 'editwidth' );
@@ -571,61 +739,103 @@ class UploadForm {
                          "<span class='error'>{$msg}</span>\n" );
                }
                $wgOut->addHTML( '<div id="uploadtext">' );
-               $wgOut->addWikiText( wfMsg( 'uploadtext' ) );
+               $wgOut->addWikiText( wfMsgNoTrans( 'uploadtext', $this->mDesiredDestName ) );
                $wgOut->addHTML( '</div>' );
-               $sk = $wgUser->getSkin();
-
 
                $sourcefilename = wfMsgHtml( 'sourcefilename' );
                $destfilename = wfMsgHtml( 'destfilename' );
                $summary = wfMsgWikiHtml( 'fileuploadsummary' );
 
                $licenses = new Licenses();
-               $license = wfMsgHtml( 'license' );
+               $license = wfMsgExt( 'license', array( 'parseinline' ) );
                $nolicense = wfMsgHtml( 'nolicense' );
                $licenseshtml = $licenses->getHtml();
 
                $ulb = wfMsgHtml( 'uploadbtn' );
 
 
-               $titleObj = Title::makeTitle( NS_SPECIAL, 'Upload' );
+               $titleObj = SpecialPage::getTitleFor( 'Upload' );
                $action = $titleObj->escapeLocalURL();
 
-               $encDestFile = htmlspecialchars( $this->mDestFile );
+               $encDestName = htmlspecialchars( $this->mDesiredDestName );
 
-               $watchChecked = $wgUser->getOption( 'watchdefault' )
+               $watchChecked =
+                       ( $wgUser->getOption( 'watchdefault' ) ||
+                               ( $wgUser->getOption( 'watchcreations' ) && $this->mDesiredDestName == '' ) )
                        ? 'checked="checked"'
                        : '';
+               $warningChecked = $this->mIgnoreWarning ? 'checked' : '';
+
+               // Prepare form for upload or upload/copy
+               if( $wgAllowCopyUploads && $wgUser->isAllowed( 'upload_by_url' ) ) {
+                       $filename_form =
+                               "<input type='radio' id='wpSourceTypeFile' name='wpSourceType' value='file' " .
+                                  "onchange='toggle_element_activation(\"wpUploadFileURL\",\"wpUploadFile\")' checked />" .
+                                "<input tabindex='1' type='file' name='wpUploadFile' id='wpUploadFile' " .
+                                  "onfocus='" . 
+                                    "toggle_element_activation(\"wpUploadFileURL\",\"wpUploadFile\");" .
+                                    "toggle_element_check(\"wpSourceTypeFile\",\"wpSourceTypeURL\")'" .
+                               ($this->mDesiredDestName?"":"onchange='fillDestFilename(\"wpUploadFile\")' ") . "size='40' />" .
+                               wfMsgHTML( 'upload_source_file' ) . "<br/>" .
+                               "<input type='radio' id='wpSourceTypeURL' name='wpSourceType' value='web' " .
+                                 "onchange='toggle_element_activation(\"wpUploadFile\",\"wpUploadFileURL\")' />" .
+                               "<input tabindex='1' type='text' name='wpUploadFileURL' id='wpUploadFileURL' " .
+                                 "onfocus='" .
+                                   "toggle_element_activation(\"wpUploadFile\",\"wpUploadFileURL\");" .
+                                   "toggle_element_check(\"wpSourceTypeURL\",\"wpSourceTypeFile\")'" .
+                               ($this->mDesiredDestName?"":"onchange='fillDestFilename(\"wpUploadFileURL\")' ") . "size='40' DISABLED />" .
+                               wfMsgHtml( 'upload_source_url' ) ;
+               } else {
+                       $filename_form =
+                               "<input tabindex='1' type='file' name='wpUploadFile' id='wpUploadFile' " .
+                               ($this->mDesiredDestName?"":"onchange='fillDestFilename(\"wpUploadFile\")' ") .
+                               "size='40' />" .
+                               "<input type='hidden' name='wpSourceType' value='file' />" ;
+               }
+               if ( $wgAjaxUploadDestCheck ) {
+                       $warningRow = "<tr><td colspan='2' id='wpDestFile-warning'>&nbsp</td></tr>";
+                       $destOnkeyup = 'onkeyup="wgUploadWarningObj.keypress();"';
+               } else {
+                       $warningRow = '';
+                       $destOnkeyup = '';
+               }
 
-               $wgOut->addHTML( "
-       <form id='upload' method='post' enctype='multipart/form-data' action=\"$action\">
+               $encComment = htmlspecialchars( $this->mComment );
+
+               $wgOut->addHTML( <<<EOT
+       <form id='upload' method='post' enctype='multipart/form-data' action="$action">
                <table border='0'>
                <tr>
-                       <td align='right'><label for='wpUploadFile'>{$sourcefilename}:</label></td>
+         {$this->uploadFormTextTop}
+                       <td align='right' valign='top'><label for='wpUploadFile'>{$sourcefilename}:</label></td>
                        <td align='left'>
-                               <input tabindex='1' type='file' name='wpUploadFile' id='wpUploadFile' " . ($this->mDestFile?"":"onchange='fillDestFilename()' ") . "size='40' />
+                               {$filename_form}
                        </td>
                </tr>
                <tr>
                        <td align='right'><label for='wpDestFile'>{$destfilename}:</label></td>
                        <td align='left'>
-                               <input tabindex='2' type='text' name='wpDestFile' id='wpDestFile' size='40' value=\"$encDestFile\" />
+                               <input tabindex='2' type='text' name='wpDestFile' id='wpDestFile' size='40' 
+                                       value="$encDestName" $destOnkeyup />
                        </td>
                </tr>
                <tr>
                        <td align='right'><label for='wpUploadDescription'>{$summary}</label></td>
                        <td align='left'>
-                               <textarea tabindex='3' name='wpUploadDescription' id='wpUploadDescription' rows='6' cols='{$cols}'{$ew}>" . htmlspecialchars( $this->mUploadDescription ) . "</textarea>
+                               <textarea tabindex='3' name='wpUploadDescription' id='wpUploadDescription' rows='6' 
+                                       cols='{$cols}'{$ew}>$encComment</textarea>
+          {$this->uploadFormTextAfterSummary}
                        </td>
                </tr>
-               <tr>" );
+               <tr>
+EOT
+               );
 
                if ( $licenseshtml != '' ) {
                        global $wgStylePath;
                        $wgOut->addHTML( "
                        <td align='right'><label for='wpLicense'>$license:</label></td>
                        <td align='left'>
-                               <script type='text/javascript' src=\"$wgStylePath/common/upload.js\"></script>
                                <select name='wpLicense' id='wpLicense' tabindex='4'
                                        onchange='licenseSelectorCheck()'>
                                        <option value=''>$nolicense</option>
@@ -639,40 +849,38 @@ class UploadForm {
 
                if ( $wgUseCopyrightUpload ) {
                        $filestatus = wfMsgHtml ( 'filestatus' );
-                       $copystatus =  htmlspecialchars( $this->mUploadCopyStatus );
+                       $copystatus =  htmlspecialchars( $this->mCopyrightStatus );
                        $filesource = wfMsgHtml ( 'filesource' );
-                       $uploadsource = htmlspecialchars( $this->mUploadSource );
-                       
+                       $uploadsource = htmlspecialchars( $this->mCopyrightSource );
+
                        $wgOut->addHTML( "
                                <td align='right' nowrap='nowrap'><label for='wpUploadCopyStatus'>$filestatus:</label></td>
-                               <td><input tabindex='5' type='text' name='wpUploadCopyStatus' id='wpUploadCopyStatus' value=\"$copystatus\" size='40' /></td>
+                                       <td><input tabindex='5' type='text' name='wpUploadCopyStatus' id='wpUploadCopyStatus' 
+                                         value=\"$copystatus\" size='40' /></td>
                        </tr>
                        <tr>
                                <td align='right'><label for='wpUploadCopyStatus'>$filesource:</label></td>
-                               <td><input tabindex='6' type='text' name='wpUploadSource' id='wpUploadCopyStatus' value=\"$uploadsource\" size='40' /></td>
+                                       <td><input tabindex='6' type='text' name='wpUploadSource' id='wpUploadCopyStatus' 
+                                         value=\"$uploadsource\" size='40' /></td>
                        </tr>
                        <tr>
                ");
                }
 
-
                $wgOut->addHtml( "
                <td></td>
                <td>
                        <input tabindex='7' type='checkbox' name='wpWatchthis' id='wpWatchthis' $watchChecked value='true' />
-                       <label for='wpWatchthis'>" . wfMsgHtml( 'watchthis' ) . "</label>
-                       <input tabindex='8' type='checkbox' name='wpIgnoreWarning' id='wpIgnoreWarning' value='true' />
+                       <label for='wpWatchthis'>" . wfMsgHtml( 'watchthisupload' ) . "</label>
+                       <input tabindex='8' type='checkbox' name='wpIgnoreWarning' id='wpIgnoreWarning' value='true' $warningChecked/>
                        <label for='wpIgnoreWarning'>" . wfMsgHtml( 'ignorewarnings' ) . "</label>
                </td>
        </tr>
-       <tr>
-
-       </tr>
+       $warningRow
        <tr>
                <td></td>
                <td align='left'><input tabindex='9' type='submit' name='wpUpload' value=\"{$ulb}\" /></td>
        </tr>
-
        <tr>
                <td></td>
                <td align='left'>
@@ -683,6 +891,7 @@ class UploadForm {
        </tr>
 
        </table>
+       <input type='hidden' name='wpDestFileWarningAck' id='wpDestFileWarningAck' value=''/>
        </form>" );
        }
 
@@ -740,11 +949,9 @@ class UploadForm {
         */
        function verify( $tmpfile, $extension ) {
                #magically determine mime type
-               $magic=& wfGetMimeMagic();
+               $magic=& MimeMagic::singleton();
                $mime= $magic->guessMimeType($tmpfile,false);
 
-               $fname= "SpecialUpload::verify";
-
                #check mime type, if desired
                global $wgVerifyMimeType;
                if ($wgVerifyMimeType) {
@@ -758,12 +965,12 @@ class UploadForm {
                        global $wgMimeTypeBlacklist;
                        if( isset($wgMimeTypeBlacklist) && !is_null($wgMimeTypeBlacklist)
                                && $this->checkFileExtension( $mime, $wgMimeTypeBlacklist ) ) {
-                               return new WikiErrorMsg( 'badfiletype', htmlspecialchars( $mime ) );
+                               return new WikiErrorMsg( 'filetype-badmime', htmlspecialchars( $mime ) );
                        }
                }
 
                #check for htmlish code and javascript
-               if( $this->detectScript ( $tmpfile, $mime ) ) {
+               if( $this->detectScript ( $tmpfile, $mime, $extension ) ) {
                        return new WikiErrorMsg( 'uploadscripted' );
                }
 
@@ -775,7 +982,7 @@ class UploadForm {
                        return new WikiErrorMsg( 'uploadvirus', htmlspecialchars($virus) );
                }
 
-               wfDebug( "$fname: all clear; passing.\n" );
+               wfDebug( __METHOD__.": all clear; passing.\n" );
                return true;
        }
 
@@ -787,45 +994,48 @@ class UploadForm {
         * @return bool
         */
        function verifyExtension( $mime, $extension ) {
-               $fname = 'SpecialUpload::verifyExtension';
-
-               $magic =& wfGetMimeMagic();
+               $magic =& MimeMagic::singleton();
 
                if ( ! $mime || $mime == 'unknown' || $mime == 'unknown/unknown' )
                        if ( ! $magic->isRecognizableExtension( $extension ) ) {
-                               wfDebug( "$fname: passing file with unknown detected mime type; unrecognized extension '$extension', can't verify\n" );
+                               wfDebug( __METHOD__.": passing file with unknown detected mime type; " .
+                                       "unrecognized extension '$extension', can't verify\n" );
                                return true;
                        } else {
-                               wfDebug( "$fname: rejecting file with unknown detected mime type; recognized extension '$extension', so probably invalid file\n" );
+                               wfDebug( __METHOD__.": rejecting file with unknown detected mime type; ".
+                                       "recognized extension '$extension', so probably invalid file\n" );
                                return false;
                        }
 
                $match= $magic->isMatchingExtension($extension,$mime);
 
                if ($match===NULL) {
-                       wfDebug( "$fname: no file extension known for mime type $mime, passing file\n" );
+                       wfDebug( __METHOD__.": no file extension known for mime type $mime, passing file\n" );
                        return true;
                } elseif ($match===true) {
-                       wfDebug( "$fname: mime type $mime matches extension $extension, passing file\n" );
+                       wfDebug( __METHOD__.": mime type $mime matches extension $extension, passing file\n" );
 
                        #TODO: if it's a bitmap, make sure PHP or ImageMagic resp. can handle it!
                        return true;
 
                } else {
-                       wfDebug( "$fname: mime type $mime mismatches file extension $extension, rejecting file\n" );
+                       wfDebug( __METHOD__.": mime type $mime mismatches file extension $extension, rejecting file\n" );
                        return false;
                }
        }
 
-       /** Heuristig for detecting files that *could* contain JavaScript instructions or
-       * things that may look like HTML to a browser and are thus
-       * potentially harmful. The present implementation will produce false positives in some situations.
-       *
-       * @param string $file Pathname to the temporary upload file
-       * @param string $mime The mime type of the file
-       * @return bool true if the file contains something looking like embedded scripts
-       */
-       function detectScript($file,$mime) {
+       /** 
+        * Heuristic for detecting files that *could* contain JavaScript instructions or
+        * things that may look like HTML to a browser and are thus
+        * potentially harmful. The present implementation will produce false positives in some situations.
+        *
+        * @param string $file Pathname to the temporary upload file
+        * @param string $mime The mime type of the file
+        * @param string $extension The extension of the file
+        * @return bool true if the file contains something looking like embedded scripts
+        */
+       function detectScript($file, $mime, $extension) {
+               global $wgAllowTitlesInSVG;
 
                #ugly hack: for text files, always look at the entire file.
                #For binarie field, just check the first K.
@@ -880,9 +1090,11 @@ class UploadForm {
                        '<img',
                        '<pre',
                        '<script', #also in safari
-                       '<table',
-                       '<title'   #also in safari
+                       '<table'
                        );
+               if( ! $wgAllowTitlesInSVG && $extension !== 'svg' && $mime !== 'image/svg' ) {
+                       $tags[] = '<title';
+               }
 
                foreach( $tags as $tag ) {
                        if( false !== strpos( $chunk, $tag ) ) {
@@ -898,101 +1110,115 @@ class UploadForm {
                $chunk = Sanitizer::decodeCharReferences( $chunk );
 
                #look for script-types
-               if (preg_match("!type\s*=\s*['\"]?\s*(\w*/)?(ecma|java)!sim",$chunk)) return true;
+               if (preg_match('!type\s*=\s*[\'"]?\s*(?:\w*/)?(?:ecma|java)!sim',$chunk)) return true;
 
                #look for html-style script-urls
-               if (preg_match("!(href|src|data)\s*=\s*['\"]?\s*(ecma|java)script:!sim",$chunk)) return true;
+               if (preg_match('!(?:href|src|data)\s*=\s*[\'"]?\s*(?:ecma|java)script:!sim',$chunk)) return true;
 
                #look for css-style script-urls
-               if (preg_match("!url\s*\(\s*['\"]?\s*(ecma|java)script:!sim",$chunk)) return true;
+               if (preg_match('!url\s*\(\s*[\'"]?\s*(?:ecma|java)script:!sim',$chunk)) return true;
 
                wfDebug("SpecialUpload::detectScript: no scripts found\n");
                return false;
        }
 
-       /** Generic wrapper function for a virus scanner program.
-       * This relies on the $wgAntivirus and $wgAntivirusSetup variables.
-       * $wgAntivirusRequired may be used to deny upload if the scan fails.
-       *
-       * @param string $file Pathname to the temporary upload file
-       * @return mixed false if not virus is found, NULL if the scan fails or is disabled,
-       *         or a string containing feedback from the virus scanner if a virus was found.
-       *         If textual feedback is missing but a virus was found, this function returns true.
-       */
+       /** 
+        * Generic wrapper function for a virus scanner program.
+        * This relies on the $wgAntivirus and $wgAntivirusSetup variables.
+        * $wgAntivirusRequired may be used to deny upload if the scan fails.
+        *
+        * @param string $file Pathname to the temporary upload file
+        * @return mixed false if not virus is found, NULL if the scan fails or is disabled,
+        *         or a string containing feedback from the virus scanner if a virus was found.
+        *         If textual feedback is missing but a virus was found, this function returns true.
+        */
        function detectVirus($file) {
-               global $wgAntivirus, $wgAntivirusSetup, $wgAntivirusRequired;
-
-               $fname= "SpecialUpload::detectVirus";
-
-               if (!$wgAntivirus) { #disabled?
-                       wfDebug("$fname: virus scanner disabled\n");
+               global $wgAntivirus, $wgAntivirusSetup, $wgAntivirusRequired, $wgOut;
 
+               if ( !$wgAntivirus ) {
+                       wfDebug( __METHOD__.": virus scanner disabled\n");
                        return NULL;
                }
 
-               if (!$wgAntivirusSetup[$wgAntivirus]) {
-                       wfDebug("$fname: unknown virus scanner: $wgAntivirus\n");
-
-                       $wgOut->addHTML( "<div class='error'>Bad configuration: unknown virus scanner: <i>$wgAntivirus</i></div>\n" ); #LOCALIZE
-
+               if ( !$wgAntivirusSetup[$wgAntivirus] ) {
+                       wfDebug( __METHOD__.": unknown virus scanner: $wgAntivirus\n" );
+                       # @TODO: localise
+                       $wgOut->addHTML( "<div class='error'>Bad configuration: unknown virus scanner: <i>$wgAntivirus</i></div>\n" ); 
                        return "unknown antivirus: $wgAntivirus";
                }
 
-               #look up scanner configuration
-               $virus_scanner= $wgAntivirusSetup[$wgAntivirus]["command"]; #command pattern
-               $virus_scanner_codes= $wgAntivirusSetup[$wgAntivirus]["codemap"]; #exit-code map
-               $msg_pattern= $wgAntivirusSetup[$wgAntivirus]["messagepattern"]; #message pattern
+               # look up scanner configuration
+               $command = $wgAntivirusSetup[$wgAntivirus]["command"];
+               $exitCodeMap = $wgAntivirusSetup[$wgAntivirus]["codemap"];
+               $msgPattern = isset( $wgAntivirusSetup[$wgAntivirus]["messagepattern"] ) ?
+                       $wgAntivirusSetup[$wgAntivirus]["messagepattern"] : null;
 
-               $scanner= $virus_scanner; #copy, so we can resolve the pattern
-
-               if (strpos($scanner,"%f")===false) $scanner.= " ".wfEscapeShellArg($file); #simple pattern: append file to scan
-               else $scanner= str_replace("%f",wfEscapeShellArg($file),$scanner); #complex pattern: replace "%f" with file to scan
+               if ( strpos( $command,"%f" ) === false ) {
+                       # simple pattern: append file to scan
+                       $command .= " " . wfEscapeShellArg( $file ); 
+               } else {
+                       # complex pattern: replace "%f" with file to scan
+                       $command = str_replace( "%f", wfEscapeShellArg( $file ), $command ); 
+               }
 
-               wfDebug("$fname: running virus scan: $scanner \n");
+               wfDebug( __METHOD__.": running virus scan: $command \n" );
 
-               #execute virus scanner
-               $code= false;
+               # execute virus scanner
+               $exitCode = false;
 
                #NOTE: there's a 50 line workaround to make stderr redirection work on windows, too.
                #      that does not seem to be worth the pain.
                #      Ask me (Duesentrieb) about it if it's ever needed.
-               if (wfIsWindows()) exec("$scanner",$output,$code);
-               else exec("$scanner 2>&1",$output,$code);
-
-               $exit_code= $code; #remeber for user feedback
+               $output = array();
+               if ( wfIsWindows() ) {
+                       exec( "$command", $output, $exitCode );
+               } else {
+                       exec( "$command 2>&1", $output, $exitCode );
+               }
 
-               if ($virus_scanner_codes) { #map exit code to AV_xxx constants.
-                       if (isset($virus_scanner_codes[$code])) $code= $virus_scanner_codes[$code]; #explicite mapping
-                       else if (isset($virus_scanner_codes["*"])) $code= $virus_scanner_codes["*"]; #fallback mapping
+               # map exit code to AV_xxx constants.
+               $mappedCode = $exitCode;
+               if ( $exitCodeMap ) { 
+                       if ( isset( $exitCodeMap[$exitCode] ) ) {
+                               $mappedCode = $exitCodeMap[$exitCode];
+                       } elseif ( isset( $exitCodeMap["*"] ) ) {
+                               $mappedCode = $exitCodeMap["*"];
+                       }
                }
 
-               if ($code===AV_SCAN_FAILED) { #scan failed (code was mapped to false by $virus_scanner_codes)
-                       wfDebug("$fname: failed to scan $file (code $exit_code).\n");
+               if ( $mappedCode === AV_SCAN_FAILED ) { 
+                       # scan failed (code was mapped to false by $exitCodeMap)
+                       wfDebug( __METHOD__.": failed to scan $file (code $exitCode).\n" );
 
-                       if ($wgAntivirusRequired) return "scan failed (code $exit_code)";
-                       else return NULL;
-               }
-               else if ($code===AV_SCAN_ABORTED) { #scan failed because filetype is unknown (probably imune)
-                       wfDebug("$fname: unsupported file type $file (code $exit_code).\n");
+                       if ( $wgAntivirusRequired ) { 
+                               return "scan failed (code $exitCode)"; 
+                       } else { 
+                               return NULL; 
+                       }
+               } else if ( $mappedCode === AV_SCAN_ABORTED ) { 
+                       # scan failed because filetype is unknown (probably imune)
+                       wfDebug( __METHOD__.": unsupported file type $file (code $exitCode).\n" );
                        return NULL;
-               }
-               else if ($code===AV_NO_VIRUS) {
-                       wfDebug("$fname: file passed virus scan.\n");
-                       return false; #no virus found
-               }
-               else {
-                       $output= join("\n",$output);
-                       $output= trim($output);
-
-                       if (!$output) $output= true; #if ther's no output, return true
-                       else if ($msg_pattern) {
-                               $groups= array();
-                               if (preg_match($msg_pattern,$output,$groups)) {
-                                       if ($groups[1]) $output= $groups[1];
+               } else if ( $mappedCode === AV_NO_VIRUS ) {
+                       # no virus found
+                       wfDebug( __METHOD__.": file passed virus scan.\n" );
+                       return false;
+               } else {
+                       $output = join( "\n", $output );
+                       $output = trim( $output );
+
+                       if ( !$output ) {
+                               $output = true; #if there's no output, return true
+                       } elseif ( $msgPattern ) {
+                               $groups = array();
+                               if ( preg_match( $msgPattern, $output, $groups ) ) {
+                                       if ( $groups[1] ) {
+                                               $output = $groups[1];
+                                       }
                                }
                        }
 
-                       wfDebug("$fname: FOUND VIRUS! scanner feedback: $output");
+                       wfDebug( __METHOD__.": FOUND VIRUS! scanner feedback: $output" );
                        return $output;
                }
        }
@@ -1006,7 +1232,7 @@ class UploadForm {
         * @access private
         */
        function checkMacBinary() {
-               $macbin = new MacBinary( $this->mUploadTempName );
+               $macbin = new MacBinary( $this->mTempPath );
                if( $macbin->isValid() ) {
                        $dataFile = tempnam( wfTempDir(), "WikiMacBinary" );
                        $dataHandle = fopen( $dataFile, 'wb' );
@@ -1014,8 +1240,8 @@ class UploadForm {
                        wfDebug( "SpecialUpload::checkMacBinary: Extracting MacBinary data fork to $dataFile\n" );
                        $macbin->extractData( $dataHandle );
 
-                       $this->mUploadTempName = $dataFile;
-                       $this->mUploadSize = $macbin->dataForkLength();
+                       $this->mTempPath = $dataFile;
+                       $this->mFileSize = $macbin->dataForkLength();
 
                        // We'll have to manually remove the new file if it's not kept.
                        $this->mRemoveTempFile = true;
@@ -1029,9 +1255,9 @@ class UploadForm {
         * @access private
         */
        function cleanupTempFile() {
-               if( $this->mRemoveTempFile && file_exists( $this->mUploadTempName ) ) {
-                       wfDebug( "SpecialUpload::cleanupTempFile: Removing temporary file $this->mUploadTempName\n" );
-                       unlink( $this->mUploadTempName );
+               if ( $this->mRemoveTempFile && file_exists( $this->mTempPath ) ) {
+                       wfDebug( "SpecialUpload::cleanupTempFile: Removing temporary file {$this->mTempPath}\n" );
+                       unlink( $this->mTempPath );
                }
        }
 
@@ -1043,18 +1269,13 @@ class UploadForm {
         * @access private
         */
        function checkOverwrite( $name ) {
-               $img = Image::newFromName( $name );
-               if( is_null( $img ) ) {
-                       // Uh... this shouldn't happen ;)
-                       // But if it does, fall through to previous behavior
-                       return false;
-               }
+               $img = wfFindFile( $name );
 
                $error = '';
-               if( $img->exists() ) {
+               if( $img ) {
                        global $wgUser, $wgOut;
                        if( $img->isLocal() ) {
-                               if( !$wgUser->isAllowed( 'reupload' ) ) {
+                               if( !self::userCanReUpload( $wgUser, $img->name ) ) {
                                        $error = 'fileexists-forbidden';
                                }
                        } else {
@@ -1074,5 +1295,65 @@ class UploadForm {
                return true;
        }
 
+        /**
+        * Check if a user is the last uploader
+        *
+        * @param User $user
+        * @param string $img, image name
+        * @return bool
+        */
+       public static function userCanReUpload( User $user, $img ) {
+               if( $user->isAllowed( 'reupload' ) )
+                       return true; // non-conditional
+               if( !$user->isAllowed( 'reupload-own' ) )
+                       return false;
+               
+               $dbr = wfGetDB( DB_SLAVE );
+               $row = $dbr->selectRow('image',
+               /* SELECT */ 'img_user',
+               /* WHERE */ array( 'img_name' => $img )
+               );
+               if ( !$row )
+                       return false;
+
+               return $user->getID() == $row->img_user;
+       }
+
+       /**
+        * Display an error from a wikitext-formatted WikiError object
+        */
+       function showError( WikiError $error ) {
+               global $wgOut;
+               $wgOut->setPageTitle( wfMsg( "internalerror" ) );
+               $wgOut->setRobotpolicy( "noindex,nofollow" );
+               $wgOut->setArticleRelated( false );
+               $wgOut->enableClientCache( false );
+               $wgOut->addWikiText( $error->getMessage() );
+       }
+
+       /**
+        * Get the initial image page text based on a comment and optional file status information
+        */
+       static function getInitialPageText( $comment, $license, $copyStatus, $source ) {
+               global $wgUseCopyrightUpload;
+               if ( $wgUseCopyrightUpload ) {
+                       if ( $license != '' ) {
+                               $licensetxt = '== ' . wfMsgForContent( 'license' ) . " ==\n" . '{{' . $license . '}}' . "\n";
+                       }
+                       $pageText = '== ' . wfMsg ( 'filedesc' ) . " ==\n" . $comment . "\n" .
+                         '== ' . wfMsgForContent ( 'filestatus' ) . " ==\n" . $copyStatus . "\n" .
+                         "$licensetxt" .
+                         '== ' . wfMsgForContent ( 'filesource' ) . " ==\n" . $source ;
+               } else {
+                       if ( $license != '' ) {
+                               $filedesc = $comment == '' ? '' : '== ' . wfMsg ( 'filedesc' ) . " ==\n" . $comment . "\n";
+                                $pageText = $filedesc .
+                                        '== ' . wfMsgForContent ( 'license' ) . " ==\n" . '{{' . $license . '}}' . "\n";
+                       } else {
+                               $pageText = $comment;
+                       }
+               }
+               return $pageText;
+       }
 }
-?>
+