aaaand one more
[lhc/web/wiklou.git] / includes / SpecialUpload.php
index dd3181a..2ebd3fa 100644 (file)
@@ -1,14 +1,9 @@
 <?php
 /**
  *
- * @package MediaWiki
- * @subpackage SpecialPage
+ * @addtogroup SpecialPage
  */
 
-/**
- *
- */
-require_once( 'Image.php' );
 
 /**
  * Entry point
@@ -20,18 +15,25 @@ function wfSpecialUpload() {
 }
 
 /**
- *
- * @package MediaWiki
- * @subpackage SpecialPage
+ * implements Special:Upload
+ * @addtogroup SpecialPage
  */
 class UploadForm {
        /**#@+
         * @access private
         */
-       var $mUploadAffirm, $mUploadFile, $mUploadDescription, $mIgnoreWarning;
+       var $mUploadFile, $mUploadDescription, $mLicense ,$mIgnoreWarning, $mUploadError;
        var $mUploadSaveName, $mUploadTempName, $mUploadSize, $mUploadOldVersion;
        var $mUploadCopyStatus, $mUploadSource, $mReUpload, $mAction, $mUpload;
-       var $mOname, $mSessionKey, $mStashed, $mDestFile;
+       var $mOname, $mSessionKey, $mStashed, $mDestFile, $mRemoveTempFile, $mSourceType;
+       var $mUploadTempFileSize = 0;
+       var $mImage;
+
+       # Placeholders for text injection by hooks (must be HTML)
+       # extensions should take care to _append_ to the present value
+       var $uploadFormTextTop;
+       var $uploadFormTextAfterSummary;
+
        /**#@-*/
 
        /**
@@ -40,24 +42,32 @@ class UploadForm {
         * @param $request Data posted.
         */
        function UploadForm( &$request ) {
+               global $wgAllowCopyUploads;
                $this->mDestFile          = $request->getText( 'wpDestFile' );
-               
+
                if( !$request->wasPosted() ) {
                        # GET requests just give the main form; no data except wpDestfile.
                        return;
                }
 
-               $this->mUploadAffirm      = $request->getCheck( 'wpUploadAffirm' );
-               $this->mIgnoreWarning     = $request->getCheck( 'wpIgnoreWarning');
+               # Placeholders for text injection by hooks (empty per default)
+               $this->uploadFormTextTop = "";
+               $this->uploadFormTextAfterSummary = "";
+
+               $this->mIgnoreWarning     = $request->getCheck( 'wpIgnoreWarning' );
                $this->mReUpload          = $request->getCheck( 'wpReUpload' );
                $this->mUpload            = $request->getCheck( 'wpUpload' );
-               
+
                $this->mUploadDescription = $request->getText( 'wpUploadDescription' );
+               $this->mLicense           = $request->getText( 'wpLicense' );
                $this->mUploadCopyStatus  = $request->getText( 'wpUploadCopyStatus' );
-               $this->mUploadSource      = $request->getText( 'wpUploadSource');
-               
+               $this->mUploadSource      = $request->getText( 'wpUploadSource' );
+               $this->mWatchthis         = $request->getBool( 'wpWatchthis' );
+               $this->mSourceType         = $request->getText( 'wpSourceType' );
+               wfDebug( "UploadForm: watchthis is: '$this->mWatchthis'\n" );
+
                $this->mAction            = $request->getVal( 'action' );
-               
+
                $this->mSessionKey        = $request->getInt( 'wpSessionKey' );
                if( !empty( $this->mSessionKey ) &&
                        isset( $_SESSION['wsUploadData'][$this->mSessionKey] ) ) {
@@ -71,19 +81,125 @@ class UploadForm {
                        $this->mUploadTempName   = $data['mUploadTempName'];
                        $this->mUploadSize       = $data['mUploadSize'];
                        $this->mOname            = $data['mOname'];
-                       $this->mStashed          = true;
+                       $this->mUploadError      = 0/*UPLOAD_ERR_OK*/;
+                       $this->mStashed          = true;
+                       $this->mRemoveTempFile   = false;
                } else {
                        /**
                         *Check for a newly uploaded file.
                         */
-                       $this->mUploadTempName = $request->getFileTempName( 'wpUploadFile' );
-                       $this->mUploadSize     = $request->getFileSize( 'wpUploadFile' );
-                       $this->mOname          = $request->getFileName( 'wpUploadFile' );
-                       $this->mSessionKey     = false;
-                       $this->mStashed        = false;
+                       if( $wgAllowCopyUploads && $this->mSourceType == 'web' ) {
+                               $this->initializeFromUrl( $request );
+                       } else {
+                               $this->initializeFromUpload( $request );
+                       }
                }
        }
 
+       /**
+        * Initialize the uploaded file from PHP data
+        * @access private
+        */
+       function initializeFromUpload( $request ) {
+               $this->mUploadTempName = $request->getFileTempName( 'wpUploadFile' );
+               $this->mUploadSize     = $request->getFileSize( 'wpUploadFile' );
+               $this->mOname          = $request->getFileName( 'wpUploadFile' );
+               $this->mUploadError    = $request->getUploadError( 'wpUploadFile' );
+               $this->mSessionKey     = false;
+               $this->mStashed        = false;
+               $this->mRemoveTempFile = false; // PHP will handle this
+       }
+
+       /**
+        * Copy a web file to a temporary file
+        * @access private
+        */
+       function initializeFromUrl( $request ) {
+               global $wgTmpDirectory;
+               $url = $request->getText( 'wpUploadFileURL' );
+               $local_file = tempnam( $wgTmpDirectory, 'WEBUPLOAD' );
+
+               $this->mUploadTempName = $local_file;
+               $this->mUploadError    = $this->curlCopy( $url, $local_file );
+               $this->mUploadSize     = $this->mUploadTempFileSize;
+               $this->mOname          = array_pop( explode( '/', $url ) );
+               $this->mSessionKey     = false;
+               $this->mStashed        = false;
+
+               // PHP won't auto-cleanup the file
+               $this->mRemoveTempFile = file_exists( $local_file );
+       }
+
+       /**
+        * Safe copy from URL
+        * Returns true if there was an error, false otherwise
+        */
+       private function curlCopy( $url, $dest ) {
+               global $wgUser, $wgOut;
+
+               if( !$wgUser->isAllowed( 'upload_by_url' ) ) {
+                       $wgOut->permissionRequired( 'upload_by_url' );
+                       return true;
+               }
+
+               # Maybe remove some pasting blanks :-)
+               $url =  trim( $url );
+               if( stripos($url, 'http://') !== 0 && stripos($url, 'ftp://') !== 0 ) {
+                       # Only HTTP or FTP URLs
+                       $wgOut->errorPage( 'upload-proto-error', 'upload-proto-error-text' );
+                       return true;
+               }
+
+               # Open temporary file
+               $this->mUploadTempFile = @fopen( $this->mUploadTempName, "wb" );
+               if( $this->mUploadTempFile === false ) {
+                       # Could not open temporary file to write in
+                       $wgOut->errorPage( 'upload-file-error', 'upload-file-error-text');
+                       return true;
+               }
+
+               $ch = curl_init();
+               curl_setopt( $ch, CURLOPT_HTTP_VERSION, 1.0); # Probably not needed, but apparently can work around some bug
+               curl_setopt( $ch, CURLOPT_TIMEOUT, 10); # 10 seconds timeout
+               curl_setopt( $ch, CURLOPT_LOW_SPEED_LIMIT, 512); # 0.5KB per second minimum transfer speed
+               curl_setopt( $ch, CURLOPT_URL, $url);
+               curl_setopt( $ch, CURLOPT_WRITEFUNCTION, array( $this, 'uploadCurlCallback' ) );
+               curl_exec( $ch );
+               $error = curl_errno( $ch ) ? true : false;
+               $errornum =  curl_errno( $ch );
+               // if ( $error ) print curl_error ( $ch ) ; # Debugging output
+               curl_close( $ch );
+
+               fclose( $this->mUploadTempFile );
+               unset( $this->mUploadTempFile );
+               if( $error ) {
+                       unlink( $dest );
+                       if( wfEmptyMsg( "upload-curl-error$errornum", wfMsg("upload-curl-error$errornum") ) )
+                               $wgOut->errorPage( 'upload-misc-error', 'upload-misc-error-text' );
+                       else
+                               $wgOut->errorPage( "upload-curl-error$errornum", "upload-curl-error$errornum-text" );
+               }
+
+               return $error;
+       }
+
+       /**
+        * Callback function for CURL-based web transfer
+        * Write data to file unless we've passed the length limit;
+        * if so, abort immediately.
+        * @access private
+        */
+       function uploadCurlCallback( $ch, $data ) {
+               global $wgMaxUploadSize;
+               $length = strlen( $data );
+               $this->mUploadTempFileSize += $length;
+               if( $this->mUploadTempFileSize > $wgMaxUploadSize ) {
+                       return 0;
+               }
+               fwrite( $this->mUploadTempFile, $data );
+               return $length;
+       }
+
        /**
         * Start doing stuff
         * @access public
@@ -92,37 +208,51 @@ class UploadForm {
                global $wgUser, $wgOut;
                global $wgEnableUploads, $wgUploadDirectory;
 
-               /** Show an error message if file upload is disabled */ 
-               if( ! $wgEnableUploads ) {
-                       $wgOut->addWikiText( wfMsg( 'uploaddisabled' ) );
+               # Check uploading enabled
+               if( !$wgEnableUploads ) {
+                       $wgOut->showErrorPage( 'uploaddisabled', 'uploaddisabledtext', array( $this->mDestFile ) );
                        return;
                }
 
-               /** Various rights checks */
-               if( ( $wgUser->isAnon() )
-                        OR $wgUser->isBlocked() ) {
-                       $wgOut->errorpage( 'uploadnologin', 'uploadnologintext' );
+               # Check permissions
+               if( !$wgUser->isAllowed( 'upload' ) ) {
+                       if( !$wgUser->isLoggedIn() ) {
+                               $wgOut->showErrorPage( 'uploadnologin', 'uploadnologintext' );
+                       } else {
+                               $wgOut->permissionRequired( 'upload' );
+                       }
                        return;
                }
+
+               # Check blocks
+               if( $wgUser->isBlocked() ) {
+                       $wgOut->blockedPage();
+                       return;
+               }
+
                if( wfReadOnly() ) {
                        $wgOut->readOnlyPage();
                        return;
                }
-               
+
                /** Check if the image directory is writeable, this is a common mistake */
-               if ( !is_writeable( $wgUploadDirectory ) ) {
+               if( !is_writeable( $wgUploadDirectory ) ) {
                        $wgOut->addWikiText( wfMsg( 'upload_directory_read_only', $wgUploadDirectory ) );
                        return;
                }
 
                if( $this->mReUpload ) {
-                       $this->unsaveUploadedFile();
+                       if( !$this->unsaveUploadedFile() ) {
+                               return;
+                       }
                        $this->mainUploadForm();
-               } else if ( 'submit' == $this->mAction || $this->mUpload ) {
+               } else if( 'submit' == $this->mAction || $this->mUpload ) {
                        $this->processUpload();
                } else {
                        $this->mainUploadForm();
                }
+
+               $this->cleanupTempFile();
        }
 
        /* -------------------------------------------------------------- */
@@ -133,41 +263,33 @@ class UploadForm {
         * @access private
         */
        function processUpload() {
-               global $wgUser, $wgOut, $wgLang, $wgContLang;
-               global $wgUploadDirectory;
-               global $wgUseCopyrightUpload, $wgCheckCopyrightUpload;
+               global $wgUser, $wgOut;
+
+               if( !wfRunHooks( 'UploadForm:BeforeProcessing', array( &$this ) ) )
+               {
+                       wfDebug( "Hook 'UploadForm:BeforeProcessing' broke processing the file." );
+                       return false;
+               }
+
+               /* Check for PHP error if any, requires php 4.2 or newer */
+               if( $this->mUploadError == 1/*UPLOAD_ERR_INI_SIZE*/ ) {
+                       $this->mainUploadForm( wfMsgHtml( 'largefileserver' ) );
+                       return;
+               }
 
                /**
                 * If there was no filename or a zero size given, give up quick.
                 */
                if( trim( $this->mOname ) == '' || empty( $this->mUploadSize ) ) {
-                       return $this->mainUploadForm('<li>'.wfMsg( 'emptyfile' ).'</li>');
-               }
-               
-               /**
-                * When using detailed copyright, if user filled field, assume he
-                * confirmed the upload
-                */
-               if ( $wgUseCopyrightUpload ) {
-                       $this->mUploadAffirm = true;
-                       if( $wgCheckCopyrightUpload && 
-                           ( trim( $this->mUploadCopyStatus ) == '' ||
-                             trim( $this->mUploadSource     ) == '' ) ) {
-                               $this->mUploadAffirm = false;
-                       }
-               }
-
-               /** User need to confirm his upload */
-               if( !$this->mUploadAffirm ) {
-                       $this->mainUploadForm( wfMsg( 'noaffirmation' ) );
+                       $this->mainUploadForm( wfMsgHtml( 'emptyfile' ) );
                        return;
                }
 
                # Chop off any directories in the given filename
-               if ( $this->mDestFile ) {
-                       $basename = basename( $this->mDestFile );
+               if( $this->mDestFile ) {
+                       $basename = wfBaseName( $this->mDestFile );
                } else {
-                       $basename = basename( $this->mOname );
+                       $basename = wfBaseName( $this->mOname );
                }
 
                /**
@@ -175,15 +297,22 @@ class UploadForm {
                 * only the final one for the whitelist.
                 */
                list( $partname, $ext ) = $this->splitExtensions( $basename );
+
                if( count( $ext ) ) {
                        $finalExt = $ext[count( $ext ) - 1];
                } else {
                        $finalExt = '';
                }
-               $fullExt = implode( '.', $ext );
-               
-               if ( strlen( $partname ) < 3 ) {
-                       $this->mainUploadForm( wfMsg( 'minlength' ) );
+
+               # If there was more than one "extension", reassemble the base
+               # filename to prevent bogus complaints about length
+               if( count( $ext ) > 1 ) {
+                       for( $i = 0; $i < count( $ext ) - 1; $i++ )
+                               $partname .= '.' . $ext[$i];
+               }
+
+               if( strlen( $partname ) < 3 ) {
+                       $this->mainUploadForm( wfMsgHtml( 'minlength' ) );
                        return;
                }
 
@@ -194,106 +323,200 @@ class UploadForm {
                $filtered = preg_replace ( "/[^".Title::legalChars()."]|:/", '-', $basename );
                $nt = Title::newFromText( $filtered );
                if( is_null( $nt ) ) {
-                       return $this->uploadError( wfMsg( 'illegalfilename', htmlspecialchars( $filtered ) ) );
+                       $this->uploadError( wfMsgWikiHtml( 'illegalfilename', htmlspecialchars( $filtered ) ) );
+                       return;
                }
                $nt =& Title::makeTitle( NS_IMAGE, $nt->getDBkey() );
                $this->mUploadSaveName = $nt->getDBkey();
-               
+
                /**
                 * If the image is protected, non-sysop users won't be able
                 * to modify it by uploading a new revision.
                 */
-               if( !$nt->userCanEdit() ) {
-                       return $this->uploadError( wfMsg( 'protectedpage' ) );
+               if( !$nt->userCan( 'edit' ) ) {
+                       return $this->uploadError( wfMsgWikiHtml( 'protectedpage' ) );
                }
-               
+
+               /**
+                * In some cases we may forbid overwriting of existing files.
+                */
+               $overwrite = $this->checkOverwrite( $this->mUploadSaveName );
+               if( WikiError::isError( $overwrite ) ) {
+                       return $this->uploadError( $overwrite->toString() );
+               }
+
                /* Don't allow users to override the blacklist (check file extension) */
                global $wgStrictFileExtensions;
                global $wgFileExtensions, $wgFileBlacklist;
-               if( $this->checkFileExtensionList( $ext, $wgFileBlacklist ) ||
-                       ($wgStrictFileExtensions &&
-                               !$this->checkFileExtension( $finalExt, $wgFileExtensions ) ) ) {
-                       return $this->uploadError( wfMsg( 'badfiletype', htmlspecialchars( $fullExt ) ) );
+               if ($finalExt == '') {
+                       return $this->uploadError( wfMsgExt( 'filetype-missing', array ( 'parseinline' ) ) );
+               } elseif ( $this->checkFileExtensionList( $ext, $wgFileBlacklist ) ||
+                               ($wgStrictFileExtensions &&
+                                       !$this->checkFileExtension( $finalExt, $wgFileExtensions ) ) ) {
+                       return $this->uploadError( wfMsgExt( 'filetype-badtype', array ( 'parseinline' ), htmlspecialchars( $finalExt ), implode ( ', ', $wgFileExtensions ) ) );
                }
-               
+
                /**
                 * Look at the contents of the file; if we can recognize the
                 * type but it's corrupt or data of the wrong type, we should
                 * probably not accept it.
                 */
                if( !$this->mStashed ) {
-                       $veri= $this->verify($this->mUploadTempName, $finalExt);
-                       
+                       $this->checkMacBinary();
+                       $veri = $this->verify( $this->mUploadTempName, $finalExt );
+
                        if( $veri !== true ) { //it's a wiki error...
                                return $this->uploadError( $veri->toString() );
                        }
+
+                       /**
+                        * Provide an opportunity for extensions to add futher checks
+                        */
+                       $error = '';
+                       if( !wfRunHooks( 'UploadVerification',
+                                       array( $this->mUploadSaveName, $this->mUploadTempName, &$error ) ) ) {
+                               return $this->uploadError( $error );
+                       }
                }
-               
+
+
                /**
                 * Check for non-fatal conditions
                 */
                if ( ! $this->mIgnoreWarning ) {
                        $warning = '';
-                       if( $this->mUploadSaveName != ucfirst( $filtered ) ) {
-                               $warning .=  '<li>'.wfMsg( 'badfilename', htmlspecialchars( $this->mUploadSaveName ) ).'</li>';
+
+                       global $wgCapitalLinks;
+                       if( $wgCapitalLinks ) {
+                               $filtered = ucfirst( $filtered );
+                       }
+                       if( $this->mUploadSaveName != $filtered ) {
+                               $warning .=  '<li>'.wfMsgHtml( 'badfilename', htmlspecialchars( $this->mUploadSaveName ) ).'</li>';
                        }
-       
+
                        global $wgCheckFileExtensions;
                        if ( $wgCheckFileExtensions ) {
                                if ( ! $this->checkFileExtension( $finalExt, $wgFileExtensions ) ) {
-                                       $warning .= '<li>'.wfMsg( 'badfiletype', htmlspecialchars( $fullExt ) ).'</li>';
+                                       $warning .= '<li>'.wfMsgExt( 'filetype-badtype', array ( 'parseinline' ), htmlspecialchars( $finalExt ), implode ( ', ', $wgFileExtensions ) ).'</li>';
                                }
                        }
-       
+
                        global $wgUploadSizeWarning;
                        if ( $wgUploadSizeWarning && ( $this->mUploadSize > $wgUploadSizeWarning ) ) {
-                               # TODO: Format $wgUploadSizeWarning to something that looks better than the raw byte
-                               # value, perhaps add GB,MB and KB suffixes?
-                               $warning .= '<li>'.wfMsg( 'largefile', $wgUploadSizeWarning, $this->mUploadSize ).'</li>';
+                               $skin = $wgUser->getSkin();
+                               $wsize = $skin->formatSize( $wgUploadSizeWarning );
+                               $asize = $skin->formatSize( $this->mUploadSize );
+                               $warning .= '<li>' . wfMsgHtml( 'large-file', $wsize, $asize ) . '</li>';
                        }
                        if ( $this->mUploadSize == 0 ) {
-                               $warning .= '<li>'.wfMsg( 'emptyfile' ).'</li>';
+                               $warning .= '<li>'.wfMsgHtml( 'emptyfile' ).'</li>';
                        }
-                       
-                       if( $nt->getArticleID() ) {
-                               global $wgUser;
-                               $sk = $wgUser->getSkin();
+
+                       global $wgUser;
+                       $sk = $wgUser->getSkin();
+                       $image = wfLocalFile( $nt );
+
+                       // Check for uppercase extension. We allow these filenames but check if an image
+                       // with lowercase extension exists already
+                       if ( $finalExt != strtolower( $finalExt ) ) {
+                               $nt_lc = Title::newFromText( $partname . '.' . strtolower( $finalExt ) );
+                               $image_lc = wfLocalFile( $nt_lc );
+                       }
+
+                       if( $image->exists() ) {
                                $dlink = $sk->makeKnownLinkObj( $nt );
-                               $warning .= '<li>'.wfMsg( 'fileexists', $dlink ).'</li>';
+                               if ( $image->allowInlineDisplay() ) {
+                                       $dlink2 = $sk->makeImageLinkObj( $nt, wfMsgExt( 'fileexists-thumb', 'parseinline', $dlink ), $nt->getText(), 'right', array(), false, true );
+                               } elseif ( !$image->allowInlineDisplay() && $image->isSafeFile() ) {
+                                       $icon = $image->iconThumb();
+                                       $dlink2 = '<div style="float:right" id="mw-media-icon"><a href="' . $image->getURL() . '">' . $icon->toHtml() . '</a><br />' . $dlink . '</div>';
+                               } else {
+                                       $dlink2 = '';
+                               }
+
+                               $warning .= '<li>' . wfMsgExt( 'fileexists', 'parseline', $dlink ) . '</li>' . $dlink2;
+
+                       } elseif ( isset( $image_lc) && $image_lc->exists() ) {
+                               # Check if image with lowercase extension exists.
+                               # It's not forbidden but in 99% it makes no sense to upload the same filename with uppercase extension
+                               $dlink = $sk->makeKnownLinkObj( $nt_lc );
+                               if ( $image_lc->allowInlineDisplay() ) {
+                                       $dlink2 = $sk->makeImageLinkObj( $nt_lc, wfMsgExt( 'fileexists-thumb', 'parseinline', $dlink ), $nt_lc->getText(), 'right', array(), false, true );
+                               } elseif ( !$image_lc->allowInlineDisplay() && $image_lc->isSafeFile() ) {
+                                       $icon = $image_lc->iconThumb();
+                                       $dlink2 = '<div style="float:right" id="mw-media-icon"><a href="' . $image_lc->getURL() . '">' . $icon->toHtml() . '</a><br />' . $dlink . '</div>';
+                               } else {
+                                       $dlink2 = '';
+                               }
+
+                               $warning .= '<li>' . wfMsgExt( 'fileexists-extension', 'parsemag' , $partname . '.' . $finalExt , $dlink ) . '</li>' . $dlink2;                         
+
+                       } elseif ( ( substr( $partname , 3, 3 ) == 'px-' || substr( $partname , 2, 3 ) == 'px-' ) && ereg( "[0-9]{2}" , substr( $partname , 0, 2) ) ) {
+                               # Check for filenames like 50px- or 180px-, these are mostly thumbnails
+                               $nt_thb = Title::newFromText( substr( $partname , strpos( $partname , '-' ) +1 ) . '.' . $finalExt );
+                               $image_thb = wfLocalFile( $nt_thb );
+                               if ($image_thb->exists() ) {
+                                       # Check if an image without leading '180px-' (or similiar) exists
+                                       $dlink = $sk->makeKnownLinkObj( $nt_thb);
+                                       if ( $image_thb->allowInlineDisplay() ) {
+                                               $dlink2 = $sk->makeImageLinkObj( $nt_thb, wfMsgExt( 'fileexists-thumb', 'parseinline', $dlink ), $nt_thb->getText(), 'right', array(), false, true );
+                                       } elseif ( !$image_thb->allowInlineDisplay() && $image_thb->isSafeFile() ) {
+                                               $icon = $image_thb->iconThumb();
+                                               $dlink2 = '<div style="float:right" id="mw-media-icon"><a href="' . $image_thb->getURL() . '">' . $icon->toHtml() . '</a><br />' . $dlink . '</div>';
+                                       } else {
+                                               $dlink2 = '';
+                                       }
+
+                                       $warning .= '<li>' . wfMsgExt( 'fileexists-thumbnail-yes', 'parsemag', $dlink ) . '</li>' . $dlink2;    
+                               } else {
+                                       # Image w/o '180px-' does not exists, but we do not like these filenames
+                                       $warning .= '<li>' . wfMsgExt( 'file-thumbnail-no', 'parseinline' , substr( $partname , 0, strpos( $partname , '-' ) +1 ) ) . '</li>';
+                               }
+                       }
+                       if ( $image->wasDeleted() ) {
+                               # If the file existed before and was deleted, warn the user of this
+                               # Don't bother doing so if the image exists now, however
+                               $ltitle = SpecialPage::getTitleFor( 'Log' );
+                               $llink = $sk->makeKnownLinkObj( $ltitle, wfMsgHtml( 'deletionlog' ), 'type=delete&page=' . $nt->getPrefixedUrl() );
+                               $warning .= wfOpenElement( 'li' ) . wfMsgWikiHtml( 'filewasdeleted', $llink ) . wfCloseElement( 'li' );
                        }
-                       
+
                        if( $warning != '' ) {
                                /**
                                 * Stash the file in a temporary location; the user can choose
                                 * to let it through and we'll complete the upload then.
                                 */
-                               return $this->uploadWarning($warning);
+                               return $this->uploadWarning( $warning );
                        }
                }
-               
+
                /**
                 * Try actually saving the thing...
                 * It will show an error form on failure.
                 */
+               $hasBeenMunged = !empty( $this->mSessionKey ) || $this->mRemoveTempFile;
                if( $this->saveUploadedFile( $this->mUploadSaveName,
                                             $this->mUploadTempName,
-                                            !empty( $this->mSessionKey ) ) ) {
+                                            $hasBeenMunged ) ) {
                        /**
                         * Update the upload log and create the description page
                         * if it's a new file.
                         */
-                       $img = Image::newFromName( $this->mUploadSaveName );
-                       $success = $img->recordUpload( $this->mUploadOldVersion,
+                       $this->mImage = wfLocalFile( $this->mUploadSaveName );
+                       $success = $this->mImage->recordUpload( $this->mUploadOldVersion,
                                                        $this->mUploadDescription,
+                                                       $this->mLicense,
                                                        $this->mUploadCopyStatus,
-                                                       $this->mUploadSource );
+                                                       $this->mUploadSource,
+                                                       $this->mWatchthis );
 
                        if ( $success ) {
                                $this->showSuccess();
+                               wfRunHooks( 'UploadComplete', array( &$img ) );
                        } else {
-                               // Image::recordUpload() fails if the image went missing, which is 
+                               // File::recordUpload() fails if the image went missing, which is
                                // unlikely, hence the lack of a specialised message
-                               $wgOut->fileNotFoundError( $this->mUploadSaveName );
+                               $wgOut->showFileNotFoundError( $this->mUploadSaveName );
                        }
                }
        }
@@ -311,55 +534,15 @@ class UploadForm {
         *                        is a PHP-managed upload temporary
         */
        function saveUploadedFile( $saveName, $tempName, $useRename = false ) {
-               global $wgUploadDirectory, $wgOut;
+               global $wgOut, $wgAllowCopyUploads;
 
-               $fname= "SpecialUpload::saveUploadedFile";
-               
-               $dest = wfImageDir( $saveName );
-               $archive = wfImageArchiveDir( $saveName );
-               $this->mSavedFile = "{$dest}/{$saveName}";
-
-               if( is_file( $this->mSavedFile ) ) {
-                       $this->mUploadOldVersion = gmdate( 'YmdHis' ) . "!{$saveName}";
-                       wfSuppressWarnings();
-                       $success = rename( $this->mSavedFile, "${archive}/{$this->mUploadOldVersion}" );
-                       wfRestoreWarnings();
-
-                       if( ! $success ) { 
-                               $wgOut->fileRenameError( $this->mSavedFile,
-                                 "${archive}/{$this->mUploadOldVersion}" );
-                               return false;
-                       }
-                       else wfDebug("$fname: moved file ".$this->mSavedFile." to ${archive}/{$this->mUploadOldVersion}\n");
-               } 
-               else {
-                       $this->mUploadOldVersion = '';
-               }
-               
-               if( $useRename ) {
-                       wfSuppressWarnings();
-                       $success = rename( $tempName, $this->mSavedFile );
-                       wfRestoreWarnings();
-
-                       if( ! $success ) {
-                               $wgOut->fileCopyError( $tempName, $this->mSavedFile );
-                               return false;
-                       } else {
-                               wfDebug("$fname: wrote tempfile $tempName to ".$this->mSavedFile."\n");
-                       }
-               } else {
-                       wfSuppressWarnings();
-                       $success = move_uploaded_file( $tempName, $this->mSavedFile );
-                       wfRestoreWarnings();
-
-                       if( ! $success ) {
-                               $wgOut->fileCopyError( $tempName, $this->mSavedFile );
-                               return false;
-                       }
-                       else wfDebug("$fname: wrote tempfile $tempName to ".$this->mSavedFile."\n");
+               $image = wfLocalFile( $saveName );
+               $archiveName = $image->publish( $tempName, File::DELETE_SOURCE );
+               if ( WikiError::isError( $archiveName ) ) {
+                       $this->showError( $archiveName );
+                       return false;
                }
-               
-               chmod( $this->mSavedFile, 0644 );
+               $this->mUploadOldVersion = $archiveName;
                return true;
        }
 
@@ -376,18 +559,17 @@ class UploadForm {
         * @access private
         */
        function saveTempUploadedFile( $saveName, $tempName ) {
-               global $wgOut;          
-               $archive = wfImageArchiveDir( $saveName, 'temp' );
-               $stash = $archive . '/' . gmdate( "YmdHis" ) . '!' . $saveName;
-
-               if ( !move_uploaded_file( $tempName, $stash ) ) {
-                       $wgOut->fileCopyError( $tempName, $stash );
+               global $wgOut;
+               $repo = RepoGroup::singleton()->getLocalRepo();
+               $result = $repo->storeTemp( $saveName, $tempName );
+               if ( WikiError::isError( $result ) ) {
+                       $this->showError( $result );
                        return false;
+               } else {
+                       return $result;
                }
-               
-               return $stash;
        }
-       
+
        /**
         * Stash a file in a temporary directory for later processing,
         * and save the necessary descriptive info into the session.
@@ -397,7 +579,7 @@ class UploadForm {
         * @return int
         * @access private
         */
-       function stashSession() {               
+       function stashSession() {
                $stash = $this->saveTempUploadedFile(
                        $this->mUploadSaveName, $this->mUploadTempName );
 
@@ -405,7 +587,7 @@ class UploadForm {
                        # Couldn't save the file.
                        return false;
                }
-               
+
                $key = mt_rand( 0, 0x7fffffff );
                $_SESSION['wsUploadData'][$key] = array(
                        'mUploadTempName' => $stash,
@@ -417,13 +599,17 @@ class UploadForm {
        /**
         * Remove a temporarily kept file stashed by saveTempUploadedFile().
         * @access private
+        * @return success
         */
        function unsaveUploadedFile() {
-               wfSuppressWarnings();
-               $success = unlink( $this->mUploadTempName );
-               wfRestoreWarnings();
+               global $wgOut;
+               $repo = RepoGroup::singleton()->getLocalRepo();
+               $success = $repo->freeTemp( $this->mUploadTempName );
                if ( ! $success ) {
-                       $wgOut->fileDeleteError( $this->mUploadTempName );
+                       $wgOut->showFileDeleteError( $this->mUploadTempName );
+                       return false;
+               } else {
+                       return true;
                }
        }
 
@@ -435,15 +621,15 @@ class UploadForm {
         */
        function showSuccess() {
                global $wgUser, $wgOut, $wgContLang;
-               
+
                $sk = $wgUser->getSkin();
-               $ilink = $sk->makeMediaLink( $this->mUploadSaveName, Image::imageUrl( $this->mUploadSaveName ) );
+               $ilink = $sk->makeMediaLinkObj( $this->mImage->getTitle() );
                $dname = $wgContLang->getNsText( NS_IMAGE ) . ':'.$this->mUploadSaveName;
                $dlink = $sk->makeKnownLink( $dname, $dname );
 
-               $wgOut->addHTML( '<h2>' . wfMsg( 'successfulupload' ) . "</h2>\n" );
-               $text = wfMsg( 'fileuploaded', $ilink, $dlink );
-               $wgOut->addHTML( '<p>'.$text."\n" );
+               $wgOut->addHTML( '<h2>' . wfMsgHtml( 'successfulupload' ) . "</h2>\n" );
+               $text = wfMsgWikiHtml( 'fileuploaded', $ilink, $dlink );
+               $wgOut->addHTML( $text );
                $wgOut->returnToMain( false );
        }
 
@@ -453,9 +639,8 @@ class UploadForm {
         */
        function uploadError( $error ) {
                global $wgOut;
-               $sub = wfMsg( 'uploadwarning' );
-               $wgOut->addHTML( "<h2>{$sub}</h2>\n" );
-               $wgOut->addHTML( "<h4 class='error'>{$error}</h4>\n" );
+               $wgOut->addHTML( "<h2>" . wfMsgHtml( 'uploadwarning' ) . "</h2>\n" );
+               $wgOut->addHTML( "<span class='error'>{$error}</span>\n" );
        }
 
        /**
@@ -467,7 +652,7 @@ class UploadForm {
         * @access private
         */
        function uploadWarning( $warning ) {
-               global $wgOut, $wgUser, $wgLang, $wgUploadDirectory, $wgRequest;
+               global $wgOut;
                global $wgUseCopyrightUpload;
 
                $this->mSessionKey = $this->stashSession();
@@ -476,15 +661,14 @@ class UploadForm {
                        return;
                }
 
-               $sub = wfMsg( 'uploadwarning' );
-               $wgOut->addHTML( "<h2>{$sub}</h2>\n" );
+               $wgOut->addHTML( "<h2>" . wfMsgHtml( 'uploadwarning' ) . "</h2>\n" );
                $wgOut->addHTML( "<ul class='warning'>{$warning}</ul><br />\n" );
 
-               $save = wfMsg( 'savefile' );
-               $reupload = wfMsg( 'reupload' );
-               $iw = wfMsg( 'ignorewarning' );
-               $reup = wfMsg( 'reuploaddesc' );
-               $titleObj = Title::makeTitle( NS_SPECIAL, 'Upload' );
+               $save = wfMsgHtml( 'savefile' );
+               $reupload = wfMsgHtml( 'reupload' );
+               $iw = wfMsgWikiHtml( 'ignorewarning' );
+               $reup = wfMsgWikiHtml( 'reuploaddesc' );
+               $titleObj = SpecialPage::getTitleFor( 'Upload' );
                $action = $titleObj->escapeLocalURL( 'action=submit' );
 
                if ( $wgUseCopyrightUpload )
@@ -499,23 +683,24 @@ class UploadForm {
 
                $wgOut->addHTML( "
        <form id='uploadwarning' method='post' enctype='multipart/form-data' action='$action'>
-               <input type='hidden' name='wpUploadAffirm' value='1' />
                <input type='hidden' name='wpIgnoreWarning' value='1' />
                <input type='hidden' name='wpSessionKey' value=\"" . htmlspecialchars( $this->mSessionKey ) . "\" />
                <input type='hidden' name='wpUploadDescription' value=\"" . htmlspecialchars( $this->mUploadDescription ) . "\" />
+               <input type='hidden' name='wpLicense' value=\"" . htmlspecialchars( $this->mLicense ) . "\" />
                <input type='hidden' name='wpDestFile' value=\"" . htmlspecialchars( $this->mDestFile ) . "\" />
+               <input type='hidden' name='wpWatchthis' value=\"" . htmlspecialchars( intval( $this->mWatchthis ) ) . "\" />
        {$copyright}
        <table border='0'>
                <tr>
                        <tr>
                                <td align='right'>
-                                       <input tabindex='2' type='submit' name='wpUpload' value='$save' />
+                                       <input tabindex='2' type='submit' name='wpUpload' value=\"$save\" />
                                </td>
                                <td align='left'>$iw</td>
                        </tr>
                        <tr>
                                <td align='right'>
-                                       <input tabindex='2' type='submit' name='wpReUpload' value='{$reupload}' />
+                                       <input tabindex='2' type='submit' name='wpReUpload' value=\"{$reupload}\" />
                                </td>
                                <td align='left'>$reup</td>
                        </tr>
@@ -531,81 +716,160 @@ class UploadForm {
         * @access private
         */
        function mainUploadForm( $msg='' ) {
-               global $wgOut, $wgUser, $wgLang, $wgUploadDirectory, $wgRequest;
+               global $wgOut, $wgUser;
                global $wgUseCopyrightUpload;
-               
+               global $wgRequest, $wgAllowCopyUploads;
+
+               if( !wfRunHooks( 'UploadForm:initial', array( &$this ) ) )
+               {
+                       wfDebug( "Hook 'UploadForm:initial' broke output of the upload form" );
+                       return false;
+               }
+
                $cols = intval($wgUser->getOption( 'cols' ));
                $ew = $wgUser->getOption( 'editwidth' );
                if ( $ew ) $ew = " style=\"width:100%\"";
                else $ew = '';
 
                if ( '' != $msg ) {
-                       $sub = wfMsg( 'uploaderror' );
+                       $sub = wfMsgHtml( 'uploaderror' );
                        $wgOut->addHTML( "<h2>{$sub}</h2>\n" .
-                         "<h4 class='error'>{$msg}</h4>\n" );
+                         "<span class='error'>{$msg}</span>\n" );
                }
-               $wgOut->addWikiText( wfMsg( 'uploadtext' ) );
-               $sk = $wgUser->getSkin();
+               $wgOut->addHTML( '<div id="uploadtext">' );
+               $wgOut->addWikiText( wfMsgNoTrans( 'uploadtext', $this->mDestFile ) );
+               $wgOut->addHTML( '</div>' );
 
+               $sourcefilename = wfMsgHtml( 'sourcefilename' );
+               $destfilename = wfMsgHtml( 'destfilename' );
+               $summary = wfMsgWikiHtml( 'fileuploadsummary' );
 
-               $sourcefilename = wfMsg( 'sourcefilename' );
-               $destfilename = wfMsg( 'destfilename' );
-               
-               $fd = wfMsg( 'filedesc' );
-               $ulb = wfMsg( 'uploadbtn' );
+               $licenses = new Licenses();
+               $license = wfMsgHtml( 'license' );
+               $nolicense = wfMsgHtml( 'nolicense' );
+               $licenseshtml = $licenses->getHtml();
+
+               $ulb = wfMsgHtml( 'uploadbtn' );
 
-               $clink = $sk->makeKnownLink( wfMsgForContent( 'copyrightpage' ),
-                 wfMsg( 'copyrightpagename' ) );
-               $ca = wfMsg( 'affirmation', $clink );
-               $iw = wfMsg( 'ignorewarning' );
 
-               $titleObj = Title::makeTitle( NS_SPECIAL, 'Upload' );
+               $titleObj = SpecialPage::getTitleFor( 'Upload' );
                $action = $titleObj->escapeLocalURL();
 
                $encDestFile = htmlspecialchars( $this->mDestFile );
 
-               $source = "
-       <td align='right'>
-       <input tabindex='3' type='checkbox' name='wpUploadAffirm' value='1' id='wpUploadAffirm' />
-       </td><td align='left'><label for='wpUploadAffirm'>{$ca}</label></td>
-       " ;
-               if ( $wgUseCopyrightUpload )
-                 {
-                       $source = "
-       <td align='right' nowrap='nowrap'>" . wfMsg ( 'filestatus' ) . ":</td>
-       <td><input tabindex='3' type='text' name=\"wpUploadCopyStatus\" value=\"" .
-       htmlspecialchars($this->mUploadCopyStatus). "\" size='40' /></td>
-       </tr><tr>
-       <td align='right'>". wfMsg ( 'filesource' ) . ":</td>
-       <td><input tabindex='4' type='text' name='wpUploadSource' value=\"" .
-       htmlspecialchars($this->mUploadSource). "\" size='40' /></td>
-       " ;
-                 }
+               $watchChecked =
+                       ( $wgUser->getOption( 'watchdefault' ) ||
+                               ( $wgUser->getOption( 'watchcreations' ) && $this->mDestFile == '' ) )
+                       ? 'checked="checked"'
+                       : '';
+
+               // Prepare form for upload or upload/copy
+               if( $wgAllowCopyUploads && $wgUser->isAllowed( 'upload_by_url' ) ) {
+                       $filename_form =
+                               "<input type='radio' id='wpSourceTypeFile' name='wpSourceType' value='file' onchange='toggle_element_activation(\"wpUploadFileURL\",\"wpUploadFile\")' checked />" .
+                               "<input tabindex='1' type='file' name='wpUploadFile' id='wpUploadFile' onfocus='toggle_element_activation(\"wpUploadFileURL\",\"wpUploadFile\");toggle_element_check(\"wpSourceTypeFile\",\"wpSourceTypeURL\")'" .
+                               ($this->mDestFile?"":"onchange='fillDestFilename(\"wpUploadFile\")' ") . "size='40' />" .
+                               wfMsgHTML( 'upload_source_file' ) . "<br/>" .
+                               "<input type='radio' id='wpSourceTypeURL' name='wpSourceType' value='web' onchange='toggle_element_activation(\"wpUploadFile\",\"wpUploadFileURL\")' />" .
+                               "<input tabindex='1' type='text' name='wpUploadFileURL' id='wpUploadFileURL' onfocus='toggle_element_activation(\"wpUploadFile\",\"wpUploadFileURL\");toggle_element_check(\"wpSourceTypeURL\",\"wpSourceTypeFile\")'" .
+                               ($this->mDestFile?"":"onchange='fillDestFilename(\"wpUploadFileURL\")' ") . "size='40' DISABLED />" .
+                               wfMsgHtml( 'upload_source_url' ) ;
+               } else {
+                       $filename_form =
+                               "<input tabindex='1' type='file' name='wpUploadFile' id='wpUploadFile' " .
+                               ($this->mDestFile?"":"onchange='fillDestFilename(\"wpUploadFile\")' ") .
+                               "size='40' />" .
+                               "<input type='hidden' name='wpSourceType' value='file' />" ;
+               }
 
                $wgOut->addHTML( "
        <form id='upload' method='post' enctype='multipart/form-data' action=\"$action\">
-       <table border='0'><tr>
-
-       <td align='right'>{$sourcefilename}:</td><td align='left'>
-       <input tabindex='1' type='file' name='wpUploadFile' id='wpUploadFile' onchange='fillDestFilename()' size='40' />
-       </td></tr><tr>
-
-       <td align='right'>{$destfilename}:</td><td align='left'>
-       <input tabindex='1' type='text' name='wpDestFile' id='wpDestFile' size='40' value=\"$encDestFile\" />
-       </td></tr><tr>
-       
-       <td align='right'>{$fd}:</td><td align='left'>
-       <textarea tabindex='2' name='wpUploadDescription' rows='6' cols='{$cols}'{$ew}>"        
-         . htmlspecialchars( $this->mUploadDescription ) .
-       "</textarea>
-       </td></tr><tr>
-       {$source}
+               <table border='0'>
+               <tr>
+         {$this->uploadFormTextTop}
+                       <td align='right' valign='top'><label for='wpUploadFile'>{$sourcefilename}:</label></td>
+                       <td align='left'>
+                               {$filename_form}
+                       </td>
+               </tr>
+               <tr>
+                       <td align='right'><label for='wpDestFile'>{$destfilename}:</label></td>
+                       <td align='left'>
+                               <input tabindex='2' type='text' name='wpDestFile' id='wpDestFile' size='40' value=\"$encDestFile\" />
+                       </td>
+               </tr>
+               <tr>
+                       <td align='right'><label for='wpUploadDescription'>{$summary}</label></td>
+                       <td align='left'>
+                               <textarea tabindex='3' name='wpUploadDescription' id='wpUploadDescription' rows='6' cols='{$cols}'{$ew}>" . htmlspecialchars( $this->mUploadDescription ) . "</textarea>
+          {$this->uploadFormTextAfterSummary}
+                       </td>
+               </tr>
+               <tr>" );
+
+               if ( $licenseshtml != '' ) {
+                       global $wgStylePath;
+                       $wgOut->addHTML( "
+                       <td align='right'><label for='wpLicense'>$license:</label></td>
+                       <td align='left'>
+                               <script type='text/javascript' src=\"$wgStylePath/common/upload.js\"></script>
+                               <select name='wpLicense' id='wpLicense' tabindex='4'
+                                       onchange='licenseSelectorCheck()'>
+                                       <option value=''>$nolicense</option>
+                                       $licenseshtml
+                               </select>
+                       </td>
+                       </tr>
+                       <tr>
+               ");
+               }
+
+               if ( $wgUseCopyrightUpload ) {
+                       $filestatus = wfMsgHtml ( 'filestatus' );
+                       $copystatus =  htmlspecialchars( $this->mUploadCopyStatus );
+                       $filesource = wfMsgHtml ( 'filesource' );
+                       $uploadsource = htmlspecialchars( $this->mUploadSource );
+
+                       $wgOut->addHTML( "
+                               <td align='right' nowrap='nowrap'><label for='wpUploadCopyStatus'>$filestatus:</label></td>
+                               <td><input tabindex='5' type='text' name='wpUploadCopyStatus' id='wpUploadCopyStatus' value=\"$copystatus\" size='40' /></td>
+                       </tr>
+                       <tr>
+                               <td align='right'><label for='wpUploadCopyStatus'>$filesource:</label></td>
+                               <td><input tabindex='6' type='text' name='wpUploadSource' id='wpUploadCopyStatus' value=\"$uploadsource\" size='40' /></td>
+                       </tr>
+                       <tr>
+               ");
+               }
+
+
+               $wgOut->addHtml( "
+               <td></td>
+               <td>
+                       <input tabindex='7' type='checkbox' name='wpWatchthis' id='wpWatchthis' $watchChecked value='true' />
+                       <label for='wpWatchthis'>" . wfMsgHtml( 'watchthisupload' ) . "</label>
+                       <input tabindex='8' type='checkbox' name='wpIgnoreWarning' id='wpIgnoreWarning' value='true' />
+                       <label for='wpIgnoreWarning'>" . wfMsgHtml( 'ignorewarnings' ) . "</label>
+               </td>
+       </tr>
+       <tr>
+               <td></td>
+               <td align='left'><input tabindex='9' type='submit' name='wpUpload' value=\"{$ulb}\" /></td>
        </tr>
-       <tr><td></td><td align='left'>
-       <input tabindex='5' type='submit' name='wpUpload' value=\"{$ulb}\" />
-       </td></tr></table></form>\n" );
+
+       <tr>
+               <td></td>
+               <td align='left'>
+               " );
+               $wgOut->addWikiText( wfMsgForContent( 'edittools' ) );
+               $wgOut->addHTML( "
+               </td>
+       </tr>
+
+       </table>
+       </form>" );
        }
-       
+
        /* -------------------------------------------------------------- */
 
        /**
@@ -621,7 +885,7 @@ class UploadForm {
                $basename = array_shift( $bits );
                return array( $basename, $bits );
        }
-       
+
        /**
         * Perform case-insensitive match against a list of file extensions.
         * Returns true if the extension is in the list.
@@ -650,21 +914,21 @@ class UploadForm {
                }
                return false;
        }
-       
+
        /**
         * Verifies that it's ok to include the uploaded file
         *
-        * @param string $tmpfile the full path opf the temporary file to verify
+        * @param string $tmpfile the full path of the temporary file to verify
         * @param string $extension The filename extension that the file is to be served with
         * @return mixed true of the file is verified, a WikiError object otherwise.
         */
        function verify( $tmpfile, $extension ) {
                #magically determine mime type
-               $magic=& wfGetMimeMagic();
+               $magic=& MimeMagic::singleton();
                $mime= $magic->guessMimeType($tmpfile,false);
-               
+
                $fname= "SpecialUpload::verify";
-               
+
                #check mime type, if desired
                global $wgVerifyMimeType;
                if ($wgVerifyMimeType) {
@@ -673,20 +937,20 @@ class UploadForm {
                        if( !$this->verifyExtension( $mime, $extension ) ) {
                                return new WikiErrorMsg( 'uploadcorrupt' );
                        }
-               
+
                        #check mime type blacklist
                        global $wgMimeTypeBlacklist;
-                       if( isset($wgMimeTypeBlacklist) && !is_null($wgMimeTypeBlacklist) 
+                       if( isset($wgMimeTypeBlacklist) && !is_null($wgMimeTypeBlacklist)
                                && $this->checkFileExtension( $mime, $wgMimeTypeBlacklist ) ) {
-                               return new WikiErrorMsg( 'badfiletype', htmlspecialchars( $mime ) );
+                               return new WikiErrorMsg( 'filetype-badmime', htmlspecialchars( $mime ) );
                        }
                }
-       
+
                #check for htmlish code and javascript
-               if( $this->detectScript ( $tmpfile, $mime ) ) {
+               if( $this->detectScript ( $tmpfile, $mime, $extension ) ) {
                        return new WikiErrorMsg( 'uploadscripted' );
                }
-               
+
                /**
                * Scan the uploaded file for viruses
                */
@@ -694,11 +958,11 @@ class UploadForm {
                if ( $virus ) {
                        return new WikiErrorMsg( 'uploadvirus', htmlspecialchars($virus) );
                }
-               
+
                wfDebug( "$fname: all clear; passing.\n" );
                return true;
        }
-       
+
        /**
         * Checks if the mime type of the uploaded file matches the file extension.
         *
@@ -708,71 +972,77 @@ class UploadForm {
         */
        function verifyExtension( $mime, $extension ) {
                $fname = 'SpecialUpload::verifyExtension';
-               
-               if (!$mime || $mime=="unknown" || $mime=="unknown/unknown") {
-                       wfDebug( "$fname: passing file with unknown mime type\n" );
-                       return true; 
-               }
-               
-               $magic=& wfGetMimeMagic();
-               
+
+               $magic =& MimeMagic::singleton();
+
+               if ( ! $mime || $mime == 'unknown' || $mime == 'unknown/unknown' )
+                       if ( ! $magic->isRecognizableExtension( $extension ) ) {
+                               wfDebug( "$fname: passing file with unknown detected mime type; unrecognized extension '$extension', can't verify\n" );
+                               return true;
+                       } else {
+                               wfDebug( "$fname: rejecting file with unknown detected mime type; recognized extension '$extension', so probably invalid file\n" );
+                               return false;
+                       }
+
                $match= $magic->isMatchingExtension($extension,$mime);
-               
+
                if ($match===NULL) {
                        wfDebug( "$fname: no file extension known for mime type $mime, passing file\n" );
-                       return true; 
+                       return true;
                } elseif ($match===true) {
                        wfDebug( "$fname: mime type $mime matches extension $extension, passing file\n" );
-                       
+
                        #TODO: if it's a bitmap, make sure PHP or ImageMagic resp. can handle it!
                        return true;
-                       
+
                } else {
                        wfDebug( "$fname: mime type $mime mismatches file extension $extension, rejecting file\n" );
-                       return false; 
+                       return false;
                }
        }
-       
-       /** Heuristig for detecting files that *could* contain JavaScript instructions or 
+
+       /** Heuristig for detecting files that *could* contain JavaScript instructions or
        * things that may look like HTML to a browser and are thus
        * potentially harmful. The present implementation will produce false positives in some situations.
        *
        * @param string $file Pathname to the temporary upload file
        * @param string $mime The mime type of the file
+       * @param string $extension The extension of the file
        * @return bool true if the file contains something looking like embedded scripts
        */
-       function detectScript($file,$mime) {
-               
+       function detectScript($file, $mime, $extension) {
+               global $wgAllowTitlesInSVG;
+
                #ugly hack: for text files, always look at the entire file.
                #For binarie field, just check the first K.
-               
+
                if (strpos($mime,'text/')===0) $chunk = file_get_contents( $file );
                else {
                        $fp = fopen( $file, 'rb' );
                        $chunk = fread( $fp, 1024 );
                        fclose( $fp );
                }
-               
+
                $chunk= strtolower( $chunk );
-               
+
                if (!$chunk) return false;
-               
+
                #decode from UTF-16 if needed (could be used for obfuscation).
-               if (substr($chunk,0,2)=="\xfe\xff") $enc= "UTF-16BE"; 
-               elseif (substr($chunk,0,2)=="\xff\xfe") $enc= "UTF-16LE"; 
+               if (substr($chunk,0,2)=="\xfe\xff") $enc= "UTF-16BE";
+               elseif (substr($chunk,0,2)=="\xff\xfe") $enc= "UTF-16LE";
                else $enc= NULL;
-                       
+
                if ($enc) $chunk= iconv($enc,"ASCII//IGNORE",$chunk);
-               
+
                $chunk= trim($chunk);
-               
+
                #FIXME: convert from UTF-16 if necessarry!
-               
+
                wfDebug("SpecialUpload::detectScript: checking for embedded scripts and HTML stuff\n");
-               
+
                #check for HTML doctype
                if (eregi("<!DOCTYPE *X?HTML",$chunk)) return true;
-               
+
                /**
                * Internet Explorer for Windows performs some really stupid file type
                * autodetection which can cause it to interpret valid image files as HTML
@@ -788,7 +1058,7 @@ class UploadForm {
                * Also returns true if Safari would mistake the given file for HTML
                * when served with a generic content-type.
                */
-               
+
                $tags = array(
                        '<body',
                        '<head',
@@ -796,36 +1066,38 @@ class UploadForm {
                        '<img',
                        '<pre',
                        '<script', #also in safari
-                       '<table',
-                       '<title'   #also in safari
+                       '<table'
                        );
-                       
+               if( ! $wgAllowTitlesInSVG && $extension !== 'svg' && $mime !== 'image/svg' ) {
+                       $tags[] = '<title';
+               }
+
                foreach( $tags as $tag ) {
                        if( false !== strpos( $chunk, $tag ) ) {
                                return true;
                        }
                }
-               
+
                /*
-               * look for javascript 
+               * look for javascript
                */
-               
+
                #resolve entity-refs to look at attributes. may be harsh on big files... cache result?
-               $chunk= wfMungeToUtf8($chunk); #this should actually use do_html_decode_entites, once this also deals with numeric entities.
-               
+               $chunk = Sanitizer::decodeCharReferences( $chunk );
+
                #look for script-types
-               if (preg_match("!type\s*=\s*['\"]?\s*(\w*/)?(ecma|java)!sim",$chunk)) return true;
-               
+               if (preg_match('!type\s*=\s*[\'"]?\s*(?:\w*/)?(?:ecma|java)!sim',$chunk)) return true;
+
                #look for html-style script-urls
-               if (preg_match("!(href|src|data)\s*=\s*['\"]?\s*(ecma|java)script:!sim",$chunk)) return true;
-               
+               if (preg_match('!(?:href|src|data)\s*=\s*[\'"]?\s*(?:ecma|java)script:!sim',$chunk)) return true;
+
                #look for css-style script-urls
-               if (preg_match("!url\s*\(\s*['\"]?\s*(ecma|java)script:!sim",$chunk)) return true;
-               
+               if (preg_match('!url\s*\(\s*[\'"]?\s*(?:ecma|java)script:!sim',$chunk)) return true;
+
                wfDebug("SpecialUpload::detectScript: no scripts found\n");
                return false;
        }
-       
+
        /** Generic wrapper function for a virus scanner program.
        * This relies on the $wgAntivirus and $wgAntivirusSetup variables.
        * $wgAntivirusRequired may be used to deny upload if the scan fails.
@@ -836,83 +1108,193 @@ class UploadForm {
        *         If textual feedback is missing but a virus was found, this function returns true.
        */
        function detectVirus($file) {
-               global $wgAntivirus, $wgAntivirusSetup, $wgAntivirusRequired;
-               
+               global $wgAntivirus, $wgAntivirusSetup, $wgAntivirusRequired, $wgOut;
+
                $fname= "SpecialUpload::detectVirus";
-               
+
                if (!$wgAntivirus) { #disabled?
                        wfDebug("$fname: virus scanner disabled\n");
-                       
+
                        return NULL;
                }
-               
-               if (!$wgAntivirusSetup[$wgAntivirus]) { 
-                       wfDebug("$fname: unknown virus scanner: $wgAntivirus\n"); 
+
+               if (!$wgAntivirusSetup[$wgAntivirus]) {
+                       wfDebug("$fname: unknown virus scanner: $wgAntivirus\n");
 
                        $wgOut->addHTML( "<div class='error'>Bad configuration: unknown virus scanner: <i>$wgAntivirus</i></div>\n" ); #LOCALIZE
-                       
+
                        return "unknown antivirus: $wgAntivirus";
                }
-               
+
                #look up scanner configuration
                $virus_scanner= $wgAntivirusSetup[$wgAntivirus]["command"]; #command pattern
                $virus_scanner_codes= $wgAntivirusSetup[$wgAntivirus]["codemap"]; #exit-code map
                $msg_pattern= $wgAntivirusSetup[$wgAntivirus]["messagepattern"]; #message pattern
-               
+
                $scanner= $virus_scanner; #copy, so we can resolve the pattern
-               
+
                if (strpos($scanner,"%f")===false) $scanner.= " ".wfEscapeShellArg($file); #simple pattern: append file to scan
                else $scanner= str_replace("%f",wfEscapeShellArg($file),$scanner); #complex pattern: replace "%f" with file to scan
-               
+
                wfDebug("$fname: running virus scan: $scanner \n");
-               
+
                #execute virus scanner
                $code= false;
-               
+
                #NOTE: there's a 50 line workaround to make stderr redirection work on windows, too.
-               #      that does not seem to be worth the pain. 
+               #      that does not seem to be worth the pain.
                #      Ask me (Duesentrieb) about it if it's ever needed.
-               if (wfIsWindows()) exec("$scanner",$output,$code); 
-               else exec("$scanner 2>&1",$output,$code); 
-               
-               $exit_code= $code; #remeber for user feedback
-               
+               $output = array();
+               if (wfIsWindows()) exec("$scanner",$output,$code);
+               else exec("$scanner 2>&1",$output,$code);
+
+               $exit_code= $code; #remember for user feedback
+
                if ($virus_scanner_codes) { #map exit code to AV_xxx constants.
-                       if (isset($virus_scanner_codes[$code])) $code= $virus_scanner_codes[$code]; #explicite mapping
-                       else if (isset($virus_scanner_codes["*"])) $code= $virus_scanner_codes["*"]; #fallback mapping
+                       if (isset($virus_scanner_codes[$code])) {
+                               $code= $virus_scanner_codes[$code]; # explicit mapping
+                       } else if (isset($virus_scanner_codes["*"])) {
+                               $code= $virus_scanner_codes["*"];   # fallback mapping
+                       }
                }
-               
+
                if ($code===AV_SCAN_FAILED) { #scan failed (code was mapped to false by $virus_scanner_codes)
                        wfDebug("$fname: failed to scan $file (code $exit_code).\n");
-                       
-                       if ($wgAntivirusRequired) return "scan failed (code $exit_code)";
-                       else return NULL; 
+
+                       if ($wgAntivirusRequired) { return "scan failed (code $exit_code)"; }
+                       else { return NULL; }
                }
                else if ($code===AV_SCAN_ABORTED) { #scan failed because filetype is unknown (probably imune)
                        wfDebug("$fname: unsupported file type $file (code $exit_code).\n");
-                       return NULL; 
+                       return NULL;
                }
                else if ($code===AV_NO_VIRUS) {
                        wfDebug("$fname: file passed virus scan.\n");
                        return false; #no virus found
                }
-               else { 
+               else {
                        $output= join("\n",$output);
                        $output= trim($output);
-                       
-                       if (!$output) $output= true; #if ther's no output, return true
+
+                       if (!$output) $output= true; #if there's no output, return true
                        else if ($msg_pattern) {
                                $groups= array();
                                if (preg_match($msg_pattern,$output,$groups)) {
                                        if ($groups[1]) $output= $groups[1];
                                }
                        }
-                       
+
                        wfDebug("$fname: FOUND VIRUS! scanner feedback: $output");
                        return $output;
                }
        }
-       
-       
+
+       /**
+        * Check if the temporary file is MacBinary-encoded, as some uploads
+        * from Internet Explorer on Mac OS Classic and Mac OS X will be.
+        * If so, the data fork will be extracted to a second temporary file,
+        * which will then be checked for validity and either kept or discarded.
+        *
+        * @access private
+        */
+       function checkMacBinary() {
+               $macbin = new MacBinary( $this->mUploadTempName );
+               if( $macbin->isValid() ) {
+                       $dataFile = tempnam( wfTempDir(), "WikiMacBinary" );
+                       $dataHandle = fopen( $dataFile, 'wb' );
+
+                       wfDebug( "SpecialUpload::checkMacBinary: Extracting MacBinary data fork to $dataFile\n" );
+                       $macbin->extractData( $dataHandle );
+
+                       $this->mUploadTempName = $dataFile;
+                       $this->mUploadSize = $macbin->dataForkLength();
+
+                       // We'll have to manually remove the new file if it's not kept.
+                       $this->mRemoveTempFile = true;
+               }
+               $macbin->close();
+       }
+
+       /**
+        * If we've modified the upload file we need to manually remove it
+        * on exit to clean up.
+        * @access private
+        */
+       function cleanupTempFile() {
+               if( $this->mRemoveTempFile && file_exists( $this->mUploadTempName ) ) {
+                       wfDebug( "SpecialUpload::cleanupTempFile: Removing temporary file $this->mUploadTempName\n" );
+                       unlink( $this->mUploadTempName );
+               }
+       }
+
+       /**
+        * Check if there's an overwrite conflict and, if so, if restrictions
+        * forbid this user from performing the upload.
+        *
+        * @return mixed true on success, WikiError on failure
+        * @access private
+        */
+       function checkOverwrite( $name ) {
+               $img = wfFindFile( $name );
+
+               $error = '';
+               if( $img ) {
+                       global $wgUser, $wgOut;
+                       if( $img->isLocal() ) {
+                               if( !self::userCanReUpload( $wgUser, $img->name ) ) {
+                                       $error = 'fileexists-forbidden';
+                               }
+                       } else {
+                               if( !$wgUser->isAllowed( 'reupload' ) ||
+                                   !$wgUser->isAllowed( 'reupload-shared' ) ) {
+                                       $error = "fileexists-shared-forbidden";
+                               }
+                       }
+               }
+
+               if( $error ) {
+                       $errorText = wfMsg( $error, wfEscapeWikiText( $img->getName() ) );
+                       return new WikiError( $wgOut->parse( $errorText ) );
+               }
+
+               // Rockin', go ahead and upload
+               return true;
+       }
+
+        /**
+        * Check if a user is the last uploader
+        *
+        * @param User $user
+        * @param string $img, image name
+        * @return bool
+        */
+       public static function userCanReUpload( User $user, $img ) {
+               if( $user->isAllowed( 'reupload' ) )
+                       return true; // non-conditional
+               if( !$user->isAllowed( 'reupload-own' ) )
+                       return false;
+               
+               $dbr = wfGetDB( DB_SLAVE );
+               $row = $dbr->selectRow('image',
+               /* SELECT */ 'img_user',
+               /* WHERE */ array( 'img_name' => $img )
+               );
+               if ( !$row )
+                       return false;
+
+               return $user->getID() == $row->img_user;
+       }
+
+       /**
+        * Display an error from a wikitext-formatted WikiError object
+        */
+       function showError( WikiError $error ) {
+               global $wgOut;
+               $wgOut->setPageTitle( wfMsg( "internalerror" ) );
+               $wgOut->setRobotpolicy( "noindex,nofollow" );
+               $wgOut->setArticleRelated( false );
+               $wgOut->enableClientCache( false );
+               $wgOut->addWikiText( $error->getMessage() );
+       }
 }
 ?>