(bug 13143) Fix regression in r25481, in which file extensions were incorrectly being...
[lhc/web/wiklou.git] / includes / SpecialUpload.php
index 597fd14..1227b93 100644 (file)
@@ -19,6 +19,21 @@ function wfSpecialUpload() {
  * @addtogroup SpecialPage
  */
 class UploadForm {
+       const SUCCESS = 0;
+       const BEFORE_PROCESSING = 1;
+       const LARGE_FILE_SERVER = 2;
+       const EMPTY_FILE = 3;
+       const MIN_LENGHT_PARTNAME = 4;
+       const ILLEGAL_FILENAME = 5;
+       const PROTECTED_PAGE = 6;
+       const OVERWRITE_EXISTING_FILE = 7;
+       const FILETYPE_MISSING = 8;
+       const FILETYPE_BADTYPE = 9;
+       const VERIFICATION_ERROR = 10;
+       const UPLOAD_VERIFICATION_ERROR = 11;
+       const UPLOAD_WARNING = 12;
+       const INTERNAL_ERROR = 13;
+
        /**#@+
         * @access private
         */
@@ -253,34 +268,123 @@ class UploadForm {
                $this->cleanupTempFile();
        }
 
-       /* -------------------------------------------------------------- */
+       /**
+        * Do the upload
+        * Checks are made in SpecialUpload::execute()
+        *
+        * @access private
+        */
+       function processUpload(){
+               global $wgUser, $wgOut, $wgFileExtensions;
+               $details = null;
+               $value = null;
+               $value = $this->internalProcessUpload( $details );
+               
+               switch($value) {
+                       case self::SUCCESS:
+                               $wgOut->redirect( $this->mLocalFile->getTitle()->getFullURL() );
+                               break;
+
+                       case self::BEFORE_PROCESSING:
+                               break;
+
+                       case self::LARGE_FILE_SERVER:
+                               $this->mainUploadForm( wfMsgHtml( 'largefileserver' ) );
+                               break;
+
+                       case self::EMPTY_FILE:
+                               $this->mainUploadForm( wfMsgHtml( 'emptyfile' ) );
+                               break;
+
+                       case self::MIN_LENGHT_PARTNAME:
+                               $this->mainUploadForm( wfMsgHtml( 'minlength1' ) );
+                               break;
+
+                       case self::ILLEGAL_FILENAME:
+                               $filtered = $details['filtered'];
+                               $this->uploadError( wfMsgWikiHtml( 'illegalfilename', htmlspecialchars( $filtered ) ) );
+                               break;
+
+                       case self::PROTECTED_PAGE:
+                               $this->uploadError( wfMsgWikiHtml( 'protectedpage' ) );
+                               break;
+
+                       case self::OVERWRITE_EXISTING_FILE:
+                               $errorText = $details['overwrite'];
+                               $overwrite = new WikiError( $wgOut->parse( $errorText ) );
+                               $this->uploadError( $overwrite->toString() );
+                               break;
+
+                       case self::FILETYPE_MISSING:
+                               $this->uploadError( wfMsgExt( 'filetype-missing', array ( 'parseinline' ) ) );
+                               break;
+
+                       case self::FILETYPE_BADTYPE:
+                               $finalExt = $details['finalExt'];
+                               $this->uploadError( 
+                                       wfMsgExt( 'filetype-banned-type',
+                                               array( 'parseinline' ),
+                                               htmlspecialchars( $finalExt ),
+                                               implode(
+                                                       wfMsgExt( 'comma-separator', array( 'escapenoentities' ) ),
+                                                       $wgFileExtensions
+                                               )
+                                       )
+                               );
+                               break;
+
+                       case self::VERIFICATION_ERROR:
+                               $veri = $details['veri'];
+                               $this->uploadError( $veri->toString() );
+                               break;
+
+                       case self::UPLOAD_VERIFICATION_ERROR:
+                               $error = $details['error'];
+                               $this->uploadError( $error );
+                               break;
+
+                       case self::UPLOAD_WARNING:
+                               $warning = $details['warning'];
+                               $this->uploadWarning( $warning );
+                               break;
+
+                       case self::INTERNAL_ERROR:
+                               $internal = $details['internal'];
+                               $this->showError( $internal );
+                               break;
+
+                       default:
+                               throw new MWException( __METHOD__ . ": Unknown value `{$value}`" );
+               }
+       }
 
        /**
         * Really do the upload
         * Checks are made in SpecialUpload::execute()
+        *
+        * @param array $resultDetails contains result-specific dict of additional values
+        *
         * @access private
         */
-       function processUpload() {
-               global $wgUser, $wgOut;
+       function internalProcessUpload( &$resultDetails ) {
+               global $wgUser;
 
                if( !wfRunHooks( 'UploadForm:BeforeProcessing', array( &$this ) ) )
                {
                        wfDebug( "Hook 'UploadForm:BeforeProcessing' broke processing the file." );
-                       return false;
+                       return self::BEFORE_PROCESSING;
                }
 
                /* Check for PHP error if any, requires php 4.2 or newer */
                if( $this->mCurlError == 1/*UPLOAD_ERR_INI_SIZE*/ ) {
-                       $this->mainUploadForm( wfMsgHtml( 'largefileserver' ) );
-                       return;
+                       return self::LARGE_FILE_SERVER;
                }
 
                /**
                 * If there was no filename or a zero size given, give up quick.
                 */
                if( trim( $this->mSrcName ) == '' || empty( $this->mFileSize ) ) {
-                       $this->mainUploadForm( wfMsgHtml( 'emptyfile' ) );
-                       return;
+                       return self::EMPTY_FILE;
                }
 
                # Chop off any directories in the given filename
@@ -311,8 +415,7 @@ class UploadForm {
                }
 
                if( strlen( $partname ) < 1 ) {
-                       $this->mainUploadForm( wfMsgHtml( 'minlength1' ) );
-                       return;
+                       return self::MIN_LENGHT_PARTNAME;
                }
 
                /**
@@ -322,8 +425,8 @@ class UploadForm {
                $filtered = preg_replace ( "/[^".Title::legalChars()."]|:/", '-', $filtered );
                $nt = Title::makeTitleSafe( NS_IMAGE, $filtered );
                if( is_null( $nt ) ) {
-                       $this->uploadError( wfMsgWikiHtml( 'illegalfilename', htmlspecialchars( $filtered ) ) );
-                       return;
+                       $resultDetails = array( 'filtered' => $filtered );
+                       return self::ILLEGAL_FILENAME;
                }
                $this->mLocalFile = wfLocalFile( $nt );
                $this->mDestName = $this->mLocalFile->getName();
@@ -332,27 +435,28 @@ class UploadForm {
                 * If the image is protected, non-sysop users won't be able
                 * to modify it by uploading a new revision.
                 */
-               if( !$nt->userCan( 'edit' ) ) {
-                       return $this->uploadError( wfMsgWikiHtml( 'protectedpage' ) );
+               if( !$nt->userCan( 'edit' ) || !$nt->userCan( 'create' ) ) {
+                       return self::PROTECTED_PAGE;
                }
 
                /**
                 * In some cases we may forbid overwriting of existing files.
                 */
                $overwrite = $this->checkOverwrite( $this->mDestName );
-               if( WikiError::isError( $overwrite ) ) {
-                       return $this->uploadError( $overwrite->toString() );
+               if( $overwrite !== true ) {
+                       $resultDetails = array( 'overwrite' => $overwrite );
+                       return self::OVERWRITE_EXISTING_FILE;
                }
 
                /* Don't allow users to override the blacklist (check file extension) */
                global $wgStrictFileExtensions;
                global $wgFileExtensions, $wgFileBlacklist;
                if ($finalExt == '') {
-                       return $this->uploadError( wfMsgExt( 'filetype-missing', array ( 'parseinline' ) ) );
+                       return self::FILETYPE_MISSING;
                } elseif ( $this->checkFileExtensionList( $ext, $wgFileBlacklist ) ||
                                ($wgStrictFileExtensions && !$this->checkFileExtension( $finalExt, $wgFileExtensions ) ) ) {
-                       return $this->uploadError( wfMsgExt( 'filetype-badtype', array ( 'parseinline' ), 
-                               htmlspecialchars( $finalExt ), implode ( ', ', $wgFileExtensions ) ) );
+                       $resultDetails = array( 'finalExt' => $finalExt );
+                       return self::FILETYPE_BADTYPE;
                }
 
                /**
@@ -366,7 +470,8 @@ class UploadForm {
                        $veri = $this->verify( $this->mTempPath, $finalExt );
 
                        if( $veri !== true ) { //it's a wiki error...
-                               return $this->uploadError( $veri->toString() );
+                               $resultDetails = array( 'veri' => $veri );
+                               return self::VERIFICATION_ERROR;
                        }
 
                        /**
@@ -375,7 +480,8 @@ class UploadForm {
                        $error = '';
                        if( !wfRunHooks( 'UploadVerification',
                                        array( $this->mDestName, $this->mTempPath, &$error ) ) ) {
-                               return $this->uploadError( $error );
+                               $resultDetails = array( 'error' => $error );
+                               return self::UPLOAD_VERIFICATION_ERROR;
                        }
                }
 
@@ -396,9 +502,16 @@ class UploadForm {
 
                        global $wgCheckFileExtensions;
                        if ( $wgCheckFileExtensions ) {
-                               if ( ! $this->checkFileExtension( $finalExt, $wgFileExtensions ) ) {
-                                       $warning .= '<li>'.wfMsgExt( 'filetype-badtype', array ( 'parseinline' ), 
-                                               htmlspecialchars( $finalExt ), implode ( ', ', $wgFileExtensions ) ).'</li>';
+                               if ( !$this->checkFileExtension( $finalExt, $wgFileExtensions ) ) {
+                                       $warning .= '<li>' .
+                                       wfMsgExt( 'filetype-unwanted-type',
+                                               array( 'parseinline' ),
+                                               htmlspecialchars( $finalExt ),
+                                               implode(
+                                                       wfMsgExt( 'comma-separator', array( 'escapenoentities' ) ),
+                                                       $wgFileExtensions
+                                               )
+                                       ) . '</li>';
                                }
                        }
 
@@ -421,7 +534,8 @@ class UploadForm {
                                 * Stash the file in a temporary location; the user can choose
                                 * to let it through and we'll complete the upload then.
                                 */
-                               return $this->uploadWarning( $warning );
+                               $resultDetails = array( 'warning' => $warning );
+                               return self::UPLOAD_WARNING;
                        }
                }
 
@@ -432,19 +546,20 @@ class UploadForm {
                $pageText = self::getInitialPageText( $this->mComment, $this->mLicense,
                        $this->mCopyrightStatus, $this->mCopyrightSource );
 
-               $status = $this->mLocalFile->upload( $this->mTempPath, $this->mComment, $pageText, 
+               $status = $this->mLocalFile->upload( $this->mTempPath, $this->mComment, $pageText,
                        File::DELETE_SOURCE, $this->mFileProps );
                if ( !$status->isGood() ) {
-                       $this->showError( $status->getWikiText() );
+                       $resultDetails = array( 'internal' => $status->getWikiText() );
+                       return self::INTERNAL_ERROR;
                } else {
                        if ( $this->mWatchthis ) {
                                global $wgUser;
                                $wgUser->addWatch( $this->mLocalFile->getTitle() );
                        }
                        // Success, redirect to description page
-                       $wgOut->redirect( $this->mLocalFile->getTitle()->getFullURL() );
                        $img = null; // @todo: added to avoid passing a ref to null - should this be defined somewhere?
-                       wfRunHooks( 'UploadComplete', array( &$img ) );
+                       wfRunHooks( 'UploadComplete', array( &$this ) );
+                       return self::SUCCESS;
                }
        }
 
@@ -455,20 +570,30 @@ class UploadForm {
         * Returns an empty string if there is no warning
         */
        static function getExistsWarning( $file ) {
-               global $wgUser;
+               global $wgUser, $wgContLang;
                // Check for uppercase extension. We allow these filenames but check if an image
                // with lowercase extension exists already
                $warning = '';
-               $ext = $file->getExtension();
-               $sk = $wgUser->getSkin();
-               if ( $ext !== '' ) {
-                       $partname = substr( $file->getName(), 0, -strlen( $ext ) - 1 );
-               } else {
+               $align = $wgContLang->isRtl() ? 'left' : 'right';
+
+               if( strpos( $file->getName(), '.' ) == false ) {
                        $partname = $file->getName();
+                       $rawExtension = '';
+               } else {
+                       $n = strrpos( $file->getName(), '.' );
+                       $rawExtension = substr( $file->getName(), $n + 1 );
+                       $partname = substr( $file->getName(), 0, $n );
                }
 
-               if ( $ext != strtolower( $ext ) ) {
-                       $nt_lc = Title::newFromText( $partname . '.' . strtolower( $ext ) );
+               $sk = $wgUser->getSkin();
+
+               if ( $rawExtension != $file->getExtension() ) {
+                       // We're not using the normalized form of the extension.
+                       // Normal form is lowercase, using most common of alternate
+                       // extensions (eg 'jpg' rather than 'JPEG').
+                       //
+                       // Check for another file using the normalized form...
+                       $nt_lc = Title::newFromText( $partname . '.' . $file->getExtension() );
                        $file_lc = wfLocalFile( $nt_lc );
                } else {
                        $file_lc = false;
@@ -477,53 +602,55 @@ class UploadForm {
                if( $file->exists() ) {
                        $dlink = $sk->makeKnownLinkObj( $file->getTitle() );
                        if ( $file->allowInlineDisplay() ) {
-                               $dlink2 = $sk->makeImageLinkObj( $file->getTitle(), wfMsgExt( 'fileexists-thumb', 'parseinline', $dlink ), 
-                                       $file->getName(), 'right', array(), false, true );
+                               $dlink2 = $sk->makeImageLinkObj( $file->getTitle(), wfMsgExt( 'fileexists-thumb', 'parseinline' ),
+                                       $file->getName(), $align, array(), false, true );
                        } elseif ( !$file->allowInlineDisplay() && $file->isSafeFile() ) {
                                $icon = $file->iconThumb();
-                               $dlink2 = '<div style="float:right" id="mw-media-icon"><a href="' . $file->getURL() . '">' . 
-                                       $icon->toHtml() . '</a><br />' . $dlink . '</div>';
+                               $dlink2 = '<div style="float:' . $align . '" id="mw-media-icon">' . 
+                                       $icon->toHtml( array( 'desc-link' => true ) ) . '<br />' . $dlink . '</div>';
                        } else {
                                $dlink2 = '';
                        }
 
-                       $warning .= '<li>' . wfMsgExt( 'fileexists', 'parseline', $dlink ) . '</li>' . $dlink2;
+                       $warning .= '<li>' . wfMsgExt( 'fileexists', 'parseinline', $dlink ) . '</li>' . $dlink2;
 
+               } elseif( $file->getTitle()->getArticleID() ) {
+                       $lnk = $sk->makeKnownLinkObj( $file->getTitle(), '', 'redirect=no' );
+                       $warning .= '<li>' . wfMsgExt( 'filepageexists', array( 'parseinline', 'replaceafter' ), $lnk ) . '</li>';
                } elseif ( $file_lc && $file_lc->exists() ) {
                        # Check if image with lowercase extension exists.
                        # It's not forbidden but in 99% it makes no sense to upload the same filename with uppercase extension
                        $dlink = $sk->makeKnownLinkObj( $nt_lc );
                        if ( $file_lc->allowInlineDisplay() ) {
-                               $dlink2 = $sk->makeImageLinkObj( $nt_lc, wfMsgExt( 'fileexists-thumb', 'parseinline', $dlink ), 
-                                       $nt_lc->getText(), 'right', array(), false, true );
+                               $dlink2 = $sk->makeImageLinkObj( $nt_lc, wfMsgExt( 'fileexists-thumb', 'parseinline' ),
+                                       $nt_lc->getText(), $align, array(), false, true );
                        } elseif ( !$file_lc->allowInlineDisplay() && $file_lc->isSafeFile() ) {
                                $icon = $file_lc->iconThumb();
-                               $dlink2 = '<div style="float:right" id="mw-media-icon"><a href="' . $file_lc->getURL() . '">' . 
-                                       $icon->toHtml() . '</a><br />' . $dlink . '</div>';
+                               $dlink2 = '<div style="float:' . $align . '" id="mw-media-icon">' . 
+                                       $icon->toHtml( array( 'desc-link' => true ) ) . '<br />' . $dlink . '</div>';
                        } else {
                                $dlink2 = '';
                        }
 
-                       $warning .= '<li>' . wfMsgExt( 'fileexists-extension', 'parsemag' , $partname . '.' 
-                               . $ext , $dlink ) . '</li>' . $dlink2;                          
+                       $warning .= '<li>' . wfMsgExt( 'fileexists-extension', 'parsemag', $file->getName(), $dlink ) . '</li>' . $dlink2;                              
 
                } elseif ( ( substr( $partname , 3, 3 ) == 'px-' || substr( $partname , 2, 3 ) == 'px-' ) 
                        && ereg( "[0-9]{2}" , substr( $partname , 0, 2) ) )
                {
                        # Check for filenames like 50px- or 180px-, these are mostly thumbnails
-                       $nt_thb = Title::newFromText( substr( $partname , strpos( $partname , '-' ) +1 ) . '.' . $ext );
+                       $nt_thb = Title::newFromText( substr( $partname , strpos( $partname , '-' ) +1 ) . '.' . $rawExtension );
                        $file_thb = wfLocalFile( $nt_thb );
                        if ($file_thb->exists() ) {
                                # Check if an image without leading '180px-' (or similiar) exists
                                $dlink = $sk->makeKnownLinkObj( $nt_thb);
                                if ( $file_thb->allowInlineDisplay() ) {
                                        $dlink2 = $sk->makeImageLinkObj( $nt_thb, 
-                                               wfMsgExt( 'fileexists-thumb', 'parseinline', $dlink ), 
-                                               $nt_thb->getText(), 'right', array(), false, true );
+                                               wfMsgExt( 'fileexists-thumb', 'parseinline' ),
+                                               $nt_thb->getText(), $align, array(), false, true );
                                } elseif ( !$file_thb->allowInlineDisplay() && $file_thb->isSafeFile() ) {
                                        $icon = $file_thb->iconThumb();
-                                       $dlink2 = '<div style="float:right" id="mw-media-icon"><a href="' . 
-                                               $file_thb->getURL() . '">' . $icon->toHtml() . '</a><br />' . 
+                                       $dlink2 = '<div style="float:' . $align . '" id="mw-media-icon">' . 
+                                               $icon->toHtml( array( 'desc-link' => true ) ) . '<br />' . 
                                                $dlink . '</div>';
                                } else {
                                        $dlink2 = '';
@@ -537,9 +664,19 @@ class UploadForm {
                                        substr( $partname , 0, strpos( $partname , '-' ) +1 ) ) . '</li>';
                        }
                }
-               if ( $file->wasDeleted() ) {
+
+               $filenamePrefixBlacklist = self::getFilenamePrefixBlacklist();
+               # Do the match
+               foreach( $filenamePrefixBlacklist as $prefix ) {
+                       if ( substr( $partname, 0, strlen( $prefix ) ) == $prefix ) {
+                               $warning .= '<li>' . wfMsgExt( 'filename-bad-prefix', 'parseinline', $prefix ) . '</li>';
+                               break;
+                       }
+               }
+
+               if ( $file->wasDeleted() && !$file->exists() ) {
                        # If the file existed before and was deleted, warn the user of this
-                       # Don't bother doing so if the image exists now, however
+                       # Don't bother doing so if the file exists now, however
                        $ltitle = SpecialPage::getTitleFor( 'Log' );
                        $llink = $sk->makeKnownLinkObj( $ltitle, wfMsgHtml( 'deletionlog' ), 
                                'type=delete&page=' . $file->getTitle()->getPrefixedUrl() );
@@ -548,8 +685,19 @@ class UploadForm {
                return $warning;
        }
 
+       /**
+        * Get a list of warnings
+        *
+        * @param string local filename, e.g. 'file exists', 'non-descriptive filename'
+        * @return array list of warning messages
+        */
        static function ajaxGetExistsWarning( $filename ) {
                $file = wfFindFile( $filename );
+               if( !$file ) {
+                       // Force local file so we have an object to do further checks against
+                       // if there isn't an exact match...
+                       $file = wfLocalFile( $filename );
+               }
                $s = '&nbsp;';
                if ( $file ) {
                        $warning = self::getExistsWarning( $file );
@@ -579,6 +727,33 @@ class UploadForm {
                return $output->getText();
        }
 
+       /**
+        * Get a list of blacklisted filename prefixes from [[MediaWiki:filename-prefix-blacklist]]
+        *
+        * @return array list of prefixes
+        */
+       public static function getFilenamePrefixBlacklist() {
+               $blacklist = array();
+               $message = wfMsgForContent( 'filename-prefix-blacklist' );
+               if( $message && !( wfEmptyMsg( 'filename-prefix-blacklist', $message ) || $message == '-' ) ) {
+                       $lines = explode( "\n", $message );
+                       foreach( $lines as $line ) {
+                               // Remove comment lines
+                               $comment = substr( trim( $line ), 0, 1 );
+                               if ( $comment == '#' || $comment == '' ) {
+                                       continue;
+                               }
+                               // Remove additional comments after a prefix
+                               $comment = strpos( $line, '#' );
+                               if ( $comment > 0 ) {
+                                       $line = substr( $line, 0, $comment-1 );
+                               }
+                               $blacklist[] = trim( $line );
+                       }
+               }
+               return $blacklist;
+       }
+
        /**
         * Stash a file in a temporary directory for later processing
         * after the user has confirmed it.
@@ -742,10 +917,10 @@ class UploadForm {
 
                $useAjaxDestCheck = $wgUseAjax && $wgAjaxUploadDestCheck;
                $useAjaxLicensePreview = $wgUseAjax && $wgAjaxLicensePreview;
-               
+
                $adc = wfBoolToStr( $useAjaxDestCheck );
                $alp = wfBoolToStr( $useAjaxLicensePreview );
-               
+
                $wgOut->addScript( "<script type=\"text/javascript\">
 wgAjaxUploadDestCheck = {$adc};
 wgAjaxLicensePreview = {$alp};
@@ -759,10 +934,34 @@ wgAjaxLicensePreview = {$alp};
                        return false;
                }
 
+               if( $this->mDesiredDestName ) {
+                       $title = Title::makeTitleSafe( NS_IMAGE, $this->mDesiredDestName );
+                       // Show a subtitle link to deleted revisions (to sysops et al only)
+                       if( $title instanceof Title && ( $count = $title->isDeleted() ) > 0 && $wgUser->isAllowed( 'deletedhistory' ) ) {
+                               $link = wfMsgExt(
+                                       $wgUser->isAllowed( 'delete' ) ? 'thisisdeleted' : 'viewdeleted',
+                                       array( 'parse', 'replaceafter' ),
+                                       $wgUser->getSkin()->makeKnownLinkObj(
+                                               SpecialPage::getTitleFor( 'Undelete', $title->getPrefixedText() ),
+                                               wfMsgExt( 'restorelink', array( 'parsemag', 'escape' ), $count )
+                                       )
+                               );
+                               $wgOut->addHtml( "<div id=\"contentSub2\">{$link}</div>" );
+                       }
+
+                       // Show the relevant lines from deletion log (for still deleted files only)
+                       if( $title instanceof Title && $title->isDeleted() > 0 && !$title->exists() ) {
+                               $this->showDeletionLog( $wgOut, $title->getPrefixedText() );
+                       }
+               }
+
                $cols = intval($wgUser->getOption( 'cols' ));
-               $ew = $wgUser->getOption( 'editwidth' );
-               if ( $ew ) $ew = " style=\"width:100%\"";
-               else $ew = '';
+
+               if( $wgUser->getOption( 'editwidth' ) ) {
+                       $width = " style=\"width:100%\"";
+               } else {
+                       $width = '';
+               }
 
                if ( '' != $msg ) {
                        $sub = wfMsgHtml( 'uploaderror' );
@@ -770,12 +969,38 @@ wgAjaxLicensePreview = {$alp};
                          "<span class='error'>{$msg}</span>\n" );
                }
                $wgOut->addHTML( '<div id="uploadtext">' );
-               $wgOut->addWikiText( wfMsgNoTrans( 'uploadtext', $this->mDesiredDestName ) );
-               $wgOut->addHTML( '</div>' );
+               $wgOut->addWikiMsg( 'uploadtext', $this->mDesiredDestName );
+               $wgOut->addHTML( "</div>\n" );
+
+               # Print a list of allowed file extensions, if so configured.  We ignore
+               # MIME type here, it's incomprehensible to most people and too long.
+               global $wgCheckFileExtensions, $wgStrictFileExtensions,
+               $wgFileExtensions, $wgFileBlacklist;
+               if( $wgCheckFileExtensions ) {
+                       $delim = wfMsgExt( 'comma-separator', array( 'escapenoentities' ) );
+                       if( $wgStrictFileExtensions ) {
+                               # Everything not permitted is banned
+                               $wgOut->addHTML(
+                                       '<div id="mw-upload-permitted">' .
+                                       wfMsgWikiHtml( 'upload-permitted', implode( $wgFileExtensions, $delim ) ) .
+                                       "</div>\n"
+                               );
+                       } else {
+                               # We have to list both preferred and prohibited
+                               $wgOut->addHTML(
+                                       '<div id="mw-upload-preferred">' .
+                                       wfMsgWikiHtml( 'upload-preferred', implode( $wgFileExtensions, $delim ) ) .
+                                       "</div>\n" .
+                                       '<div id="mw-upload-prohibited">' .
+                                       wfMsgWikiHtml( 'upload-prohibited', implode( $wgFileBlacklist, $delim ) ) .
+                                       "</div>\n"
+                               );
+                       }
+               }
 
                $sourcefilename = wfMsgHtml( 'sourcefilename' );
                $destfilename = wfMsgHtml( 'destfilename' );
-               $summary = wfMsgWikiHtml( 'fileuploadsummary' );
+               $summary = wfMsgExt( 'fileuploadsummary', 'parseinline' );
 
                $licenses = new Licenses();
                $license = wfMsgExt( 'license', array( 'parseinline' ) );
@@ -806,7 +1031,7 @@ wgAjaxLicensePreview = {$alp};
                                   "onfocus='" . 
                                     "toggle_element_activation(\"wpUploadFileURL\",\"wpUploadFile\");" .
                                     "toggle_element_check(\"wpSourceTypeFile\",\"wpSourceTypeURL\")'" .
-                               ($this->mDesiredDestName?"":"onchange='fillDestFilename(\"wpUploadFile\")' ") . "size='40' />" .
+                               ($this->mDesiredDestName?"":"onchange='fillDestFilename(\"wpUploadFile\")' ") . "size='60' />" .
                                wfMsgHTML( 'upload_source_file' ) . "<br/>" .
                                "<input type='radio' id='wpSourceTypeURL' name='wpSourceType' value='web' " .
                                  "onchange='toggle_element_activation(\"wpUploadFile\",\"wpUploadFileURL\")' />" .
@@ -814,17 +1039,17 @@ wgAjaxLicensePreview = {$alp};
                                  "onfocus='" .
                                    "toggle_element_activation(\"wpUploadFile\",\"wpUploadFileURL\");" .
                                    "toggle_element_check(\"wpSourceTypeURL\",\"wpSourceTypeFile\")'" .
-                               ($this->mDesiredDestName?"":"onchange='fillDestFilename(\"wpUploadFileURL\")' ") . "size='40' DISABLED />" .
+                               ($this->mDesiredDestName?"":"onchange='fillDestFilename(\"wpUploadFileURL\")' ") . "size='60' DISABLED />" .
                                wfMsgHtml( 'upload_source_url' ) ;
                } else {
                        $filename_form =
                                "<input tabindex='1' type='file' name='wpUploadFile' id='wpUploadFile' " .
                                ($this->mDesiredDestName?"":"onchange='fillDestFilename(\"wpUploadFile\")' ") .
-                               "size='40' />" .
+                               "size='60' />" .
                                "<input type='hidden' name='wpSourceType' value='file' />" ;
                }
                if ( $useAjaxDestCheck ) {
-                       $warningRow = "<tr><td colspan='2' id='wpDestFile-warning'>&nbsp</td></tr>";
+                       $warningRow = "<tr><td colspan='2' id='wpDestFile-warning'>&nbsp;</td></tr>";
                        $destOnkeyup = 'onkeyup="wgUploadWarningObj.keypress();"';
                } else {
                        $warningRow = '';
@@ -848,7 +1073,7 @@ wgAjaxLicensePreview = {$alp};
                <tr>
                        <td align='$align1'><label for='wpDestFile'>{$destfilename}:</label></td>
                        <td align='$align2'>
-                               <input tabindex='2' type='text' name='wpDestFile' id='wpDestFile' size='40' 
+                               <input tabindex='2' type='text' name='wpDestFile' id='wpDestFile' size='60' 
                                        value="$encDestName" $destOnkeyup />
                        </td>
                </tr>
@@ -856,7 +1081,7 @@ wgAjaxLicensePreview = {$alp};
                        <td align='$align1'><label for='wpUploadDescription'>{$summary}</label></td>
                        <td align='$align2'>
                                <textarea tabindex='3' name='wpUploadDescription' id='wpUploadDescription' rows='6' 
-                                       cols='{$cols}'{$ew}>$encComment</textarea>
+                                       cols='{$cols}'{$width}>$encComment</textarea>
           {$this->uploadFormTextAfterSummary}
                        </td>
                </tr>
@@ -895,12 +1120,12 @@ EOT
                        $wgOut->addHTML( "
                                <td align='$align1' nowrap='nowrap'><label for='wpUploadCopyStatus'>$filestatus:</label></td>
                                        <td><input tabindex='5' type='text' name='wpUploadCopyStatus' id='wpUploadCopyStatus' 
-                                         value=\"$copystatus\" size='40' /></td>
+                                         value=\"$copystatus\" size='60' /></td>
                        </tr>
                        <tr>
                                <td align='$align1'><label for='wpUploadCopyStatus'>$filesource:</label></td>
                                        <td><input tabindex='6' type='text' name='wpUploadSource' id='wpUploadCopyStatus' 
-                                         value=\"$uploadsource\" size='40' /></td>
+                                         value=\"$uploadsource\" size='60' /></td>
                        </tr>
                        <tr>
                ");
@@ -918,7 +1143,7 @@ EOT
        $warningRow
        <tr>
                <td></td>
-               <td align='$align2'><input tabindex='9' type='submit' name='wpUpload' value=\"{$ulb}\" /></td>
+               <td align='$align2'><input tabindex='9' type='submit' name='wpUpload' value=\"{$ulb}\"" . $wgUser->getSkin()->tooltipAndAccesskey( 'upload' ) . " /></td>
        </tr>
        <tr>
                <td></td>
@@ -1328,7 +1553,7 @@ EOT
 
                if( $error ) {
                        $errorText = wfMsg( $error, wfEscapeWikiText( $img->getName() ) );
-                       return new WikiError( $wgOut->parse( $errorText ) );
+                       return $errorText;
                }
 
                // Rockin', go ahead and upload
@@ -1395,6 +1620,29 @@ EOT
                }
                return $pageText;
        }
-}
-
 
+       /**
+        * If there are rows in the deletion log for this file, show them,
+        * along with a nice little note for the user
+        *
+        * @param OutputPage $out
+        * @param string filename
+        */
+       private function showDeletionLog( $out, $filename ) {
+               $reader = new LogReader(
+                       new FauxRequest(
+                               array(
+                                       'page' => $filename,
+                                       'type' => 'delete',
+                                       )
+                       )
+               );
+               if( $reader->hasRows() ) {
+                       $out->addHtml( '<div id="mw-upload-deleted-warn">' );
+                       $out->addWikiMsg( 'upload-wasdeleted' );
+                       $viewer = new LogViewer( $reader );
+                       $viewer->showList( $out );
+                       $out->addHtml( '</div>' );
+               }
+       }
+}