Revert r23471, r23474: restore Special:Version to working, non-ugly state
[lhc/web/wiklou.git] / includes / SpecialUndelete.php
index 3a3daba..1706833 100644 (file)
@@ -1,55 +1,95 @@
 <?php
+
 /**
- * @todo document
- * @package MediaWiki
- * @subpackage SpecialPage
+ * Special page allowing users with the appropriate permissions to view
+ * and restore deleted content
+ *
+ * @addtogroup SpecialPage
  */
 
-/** */
-require_once( 'Revision.php' );
-
 /**
- *
+ * Constructor
  */
 function wfSpecialUndelete( $par ) {
-    global $wgRequest;
+       global $wgRequest;
 
        $form = new UndeleteForm( $wgRequest, $par );
        $form->execute();
 }
 
 /**
- *
- * @package MediaWiki
- * @subpackage SpecialPage
+ * Used to show archived pages and eventually restore them.
+ * @addtogroup SpecialPage
  */
 class PageArchive {
-       var $title;
+       protected $title;
 
-       function PageArchive( &$title ) {
+       function __construct( $title ) {
                if( is_null( $title ) ) {
-                       wfDebugDieBacktrace( 'Archiver() given a null title.');
+                       throw new MWException( 'Archiver() given a null title.');
                }
-               $this->title =& $title;
+               $this->title = $title;
        }
 
        /**
         * List all deleted pages recorded in the archive table. Returns result
         * wrapper with (ar_namespace, ar_title, count) fields, ordered by page
-        * namespace/title. Can be called staticaly.
+        * namespace/title.
         *
         * @return ResultWrapper
         */
-       /* static */ function listAllPages() {
-               $dbr =& wfGetDB( DB_SLAVE );
-               $archive = $dbr->tableName( 'archive' );
-
-               $sql = "SELECT ar_namespace,ar_title, COUNT(*) AS count FROM $archive " .
-                 "GROUP BY ar_namespace,ar_title ORDER BY ar_namespace,ar_title";
-
-               return $dbr->resultObject( $dbr->query( $sql, 'PageArchive::listAllPages' ) );
+       public static function listAllPages() {
+               $dbr = wfGetDB( DB_SLAVE );
+               return self::listPages( $dbr, '' );
+       }
+       
+       /**
+        * List deleted pages recorded in the archive table matching the
+        * given title prefix.
+        * Returns result wrapper with (ar_namespace, ar_title, count) fields.
+        *
+        * @return ResultWrapper
+        */
+       public static function listPagesByPrefix( $prefix ) {
+               $dbr = wfGetDB( DB_SLAVE );
+               
+               $title = Title::newFromText( $prefix );
+               if( $title ) {
+                       $ns = $title->getNamespace();
+                       $encPrefix = $dbr->escapeLike( $title->getDbKey() );
+               } else {
+                       // Prolly won't work too good
+                       // @todo handle bare namespace names cleanly?
+                       $ns = 0;
+                       $encPrefix = $dbr->escapeLike( $prefix );
+               }
+               $conds = array(
+                       'ar_namespace' => $ns,
+                       "ar_title LIKE '$encPrefix%'",
+               );
+               return self::listPages( $dbr, $conds );
        }
 
+       protected static function listPages( $dbr, $condition ) {
+               return $dbr->resultObject(
+                       $dbr->select(
+                               array( 'archive' ),
+                               array(
+                                       'ar_namespace',
+                                       'ar_title',
+                                       'COUNT(*) AS count',
+                               ),
+                               $condition,
+                               __METHOD__,
+                               array(
+                                       'GROUP BY' => 'ar_namespace,ar_title',
+                                       'ORDER BY' => 'ar_namespace,ar_title',
+                                       'LIMIT' => 100,
+                               )
+                       )
+               );
+       }
+       
        /**
         * List the revisions of the given page. Returns result wrapper with
         * (ar_minor_edit, ar_timestamp, ar_user, ar_user_text, ar_comment) fields.
@@ -57,9 +97,9 @@ class PageArchive {
         * @return ResultWrapper
         */
        function listRevisions() {
-               $dbr =& wfGetDB( DB_SLAVE );
+               $dbr = wfGetDB( DB_SLAVE );
                $res = $dbr->select( 'archive',
-                       array( 'ar_minor_edit', 'ar_timestamp', 'ar_user', 'ar_user_text', 'ar_comment' ),
+                       array( 'ar_minor_edit', 'ar_timestamp', 'ar_user', 'ar_user_text', 'ar_comment', 'ar_len' ),
                        array( 'ar_namespace' => $this->title->getNamespace(),
                               'ar_title' => $this->title->getDBkey() ),
                        'PageArchive::listRevisions',
@@ -67,42 +107,108 @@ class PageArchive {
                $ret = $dbr->resultObject( $res );
                return $ret;
        }
+       
+       /**
+        * List the deleted file revisions for this page, if it's a file page.
+        * Returns a result wrapper with various filearchive fields, or null
+        * if not a file page.
+        *
+        * @return ResultWrapper
+        * @todo Does this belong in Image for fuller encapsulation?
+        */
+       function listFiles() {
+               if( $this->title->getNamespace() == NS_IMAGE ) {
+                       $dbr = wfGetDB( DB_SLAVE );
+                       $res = $dbr->select( 'filearchive',
+                               array(
+                                       'fa_id',
+                                       'fa_name',
+                                       'fa_storage_key',
+                                       'fa_size',
+                                       'fa_width',
+                                       'fa_height',
+                                       'fa_description',
+                                       'fa_user',
+                                       'fa_user_text',
+                                       'fa_timestamp' ),
+                               array( 'fa_name' => $this->title->getDbKey() ),
+                               __METHOD__,
+                               array( 'ORDER BY' => 'fa_timestamp DESC' ) );
+                       $ret = $dbr->resultObject( $res );
+                       return $ret;
+               }
+               return null;
+       }
 
        /**
         * Fetch (and decompress if necessary) the stored text for the deleted
         * revision of the page with the given timestamp.
         *
         * @return string
+        * @deprecated Use getRevision() for more flexible information
         */
        function getRevisionText( $timestamp ) {
-               $fname = 'PageArchive::getRevisionText';
-               $dbr =& wfGetDB( DB_SLAVE );
+               $rev = $this->getRevision( $timestamp );
+               return $rev ? $rev->getText() : null;
+       }
+
+       /**
+        * Return a Revision object containing data for the deleted revision.
+        * Note that the result *may* or *may not* have a null page ID.
+        * @param string $timestamp
+        * @return Revision
+        */
+       function getRevision( $timestamp ) {
+               $dbr = wfGetDB( DB_SLAVE );
                $row = $dbr->selectRow( 'archive',
-                       array( 'ar_text', 'ar_flags', 'ar_text_id' ),
+                       array(
+                               'ar_rev_id',
+                               'ar_text',
+                               'ar_comment',
+                               'ar_user',
+                               'ar_user_text',
+                               'ar_timestamp',
+                               'ar_minor_edit',
+                               'ar_flags',
+                               'ar_text_id',
+                               'ar_len' ),
                        array( 'ar_namespace' => $this->title->getNamespace(),
                               'ar_title' => $this->title->getDbkey(),
                               'ar_timestamp' => $dbr->timestamp( $timestamp ) ),
-                       $fname );
-               return $this->getTextFromRow( $row );
+                       __METHOD__ );
+               if( $row ) {
+                       return new Revision( array(
+                               'page'       => $this->title->getArticleId(),
+                               'id'         => $row->ar_rev_id,
+                               'text'       => ($row->ar_text_id
+                                       ? null
+                                       : Revision::getRevisionText( $row, 'ar_' ) ),
+                               'comment'    => $row->ar_comment,
+                               'user'       => $row->ar_user,
+                               'user_text'  => $row->ar_user_text,
+                               'timestamp'  => $row->ar_timestamp,
+                               'minor_edit' => $row->ar_minor_edit,
+                               'text_id'    => $row->ar_text_id ) );
+               } else {
+                       return null;
+               }
        }
 
        /**
         * Get the text from an archive row containing ar_text, ar_flags and ar_text_id
         */
        function getTextFromRow( $row ) {
-               $fname = 'PageArchive::getTextFromRow';
-
                if( is_null( $row->ar_text_id ) ) {
                        // An old row from MediaWiki 1.4 or previous.
                        // Text is embedded in this row in classic compression format.
                        return Revision::getRevisionText( $row, "ar_" );
                } else {
                        // New-style: keyed to the text storage backend.
-                       $dbr =& wfGetDB( DB_SLAVE );
+                       $dbr = wfGetDB( DB_SLAVE );
                        $text = $dbr->selectRow( 'text',
                                array( 'old_text', 'old_flags' ),
                                array( 'old_id' => $row->ar_text_id ),
-                               $fname );
+                               __METHOD__ );
                        return Revision::getRevisionText( $text );
                }
        }
@@ -117,7 +223,7 @@ class PageArchive {
         * @return string
         */
        function getLastRevisionText() {
-               $dbr =& wfGetDB( DB_SLAVE );
+               $dbr = wfGetDB( DB_SLAVE );
                $row = $dbr->selectRow( 'archive',
                        array( 'ar_text', 'ar_flags', 'ar_text_id' ),
                        array( 'ar_namespace' => $this->title->getNamespace(),
@@ -136,44 +242,96 @@ class PageArchive {
         * @return bool
         */
        function isDeleted() {
-               $dbr =& wfGetDB( DB_SLAVE );
+               $dbr = wfGetDB( DB_SLAVE );
                $n = $dbr->selectField( 'archive', 'COUNT(ar_title)',
                        array( 'ar_namespace' => $this->title->getNamespace(),
                               'ar_title' => $this->title->getDBkey() ) );
                return ($n > 0);
        }
 
+       /**
+        * Restore the given (or all) text and file revisions for the page.
+        * Once restored, the items will be removed from the archive tables.
+        * The deletion log will be updated with an undeletion notice.
+        *
+        * @param array $timestamps Pass an empty array to restore all revisions, otherwise list the ones to undelete.
+        * @param string $comment
+        * @param array $fileVersions
+        *
+        * @return true on success.
+        */
+       function undelete( $timestamps, $comment = '', $fileVersions = array() ) {
+               // If both the set of text revisions and file revisions are empty,
+               // restore everything. Otherwise, just restore the requested items.
+               $restoreAll = empty( $timestamps ) && empty( $fileVersions );
+               
+               $restoreText = $restoreAll || !empty( $timestamps );
+               $restoreFiles = $restoreAll || !empty( $fileVersions );
+               
+               if( $restoreFiles && $this->title->getNamespace() == NS_IMAGE ) {
+                       $img = wfLocalFile( $this->title );
+                       $filesRestored = $img->restore( $fileVersions );
+               } else {
+                       $filesRestored = 0;
+               }
+               
+               if( $restoreText ) {
+                       $textRestored = $this->undeleteRevisions( $timestamps );
+               } else {
+                       $textRestored = 0;
+               }
+               
+               // Touch the log!
+               global $wgContLang;
+               $log = new LogPage( 'delete' );
+               
+               if( $textRestored && $filesRestored ) {
+                       $reason = wfMsgForContent( 'undeletedrevisions-files',
+                               $wgContLang->formatNum( $textRestored ),
+                               $wgContLang->formatNum( $filesRestored ) );
+               } elseif( $textRestored ) {
+                       $reason = wfMsgForContent( 'undeletedrevisions',
+                               $wgContLang->formatNum( $textRestored ) );
+               } elseif( $filesRestored ) {
+                       $reason = wfMsgForContent( 'undeletedfiles',
+                               $wgContLang->formatNum( $filesRestored ) );
+               } else {
+                       wfDebug( "Undelete: nothing undeleted...\n" );
+                       return false;
+               }
+               
+               if( trim( $comment ) != '' )
+                       $reason .= ": {$comment}";
+               $log->addEntry( 'restore', $this->title, $reason );
+               
+               return true;
+       }
+       
        /**
         * This is the meaty bit -- restores archived revisions of the given page
         * to the cur/old tables. If the page currently exists, all revisions will
         * be stuffed into old, otherwise the most recent will go into cur.
-        * The deletion log will be updated with an undeletion notice.
-        *
-        * Returns true on success.
         *
         * @param array $timestamps Pass an empty array to restore all revisions, otherwise list the ones to undelete.
-        * @return bool
+        * @param string $comment
+        * @param array $fileVersions
+        *
+        * @return int number of revisions restored
         */
-       function undelete( $timestamps ) {
-               global $wgDeferredUpdateList, $wgParser, $wgDBtype;
-
-               $fname = "doUndeleteArticle";
+       private function undeleteRevisions( $timestamps ) {
                $restoreAll = empty( $timestamps );
-               $restoreRevisions = count( $timestamps );
-
-               $dbw =& wfGetDB( DB_MASTER );
-               extract( $dbw->tableNames( 'page', 'archive' ) );
+               
+               $dbw = wfGetDB( DB_MASTER );
+               $page = $dbw->tableName( 'archive' );
 
                # Does this page already exist? We'll have to update it...
                $article = new Article( $this->title );
-               $options = ( $wgDBtype == 'PostgreSQL' )
-                       ? '' // pg doesn't support this?
-                       : 'FOR UPDATE';
+               $options = 'FOR UPDATE';
                $page = $dbw->selectRow( 'page',
                        array( 'page_id', 'page_latest' ),
                        array( 'page_namespace' => $this->title->getNamespace(),
                               'page_title'     => $this->title->getDBkey() ),
-                       $fname,
+                       __METHOD__,
                        $options );
                if( $page ) {
                        # Page already exists. Import the history, and if necessary
@@ -212,17 +370,23 @@ class PageArchive {
                                'ar_timestamp',
                                'ar_minor_edit',
                                'ar_flags',
-                               'ar_text_id' ),
+                               'ar_text_id',
+                               'ar_len' ),
                        /* WHERE */ array(
                                'ar_namespace' => $this->title->getNamespace(),
                                'ar_title'     => $this->title->getDBkey(),
                                $oldones ),
-                       $fname,
+                       __METHOD__,
                        /* options */ array(
                                'ORDER BY' => 'ar_timestamp' )
                        );
+               if( $dbw->numRows( $result ) < count( $timestamps ) ) {
+                       wfDebug( __METHOD__.": couldn't find all requested rows\n" );
+                       return false;
+               }
+               
                $revision = null;
-               $newRevId = $previousRevId;
+               $restored = 0;
 
                while( $row = $dbw->fetchObject( $result ) ) {
                        if( $row->ar_text_id ) {
@@ -247,29 +411,26 @@ class PageArchive {
                                'timestamp'  => $row->ar_timestamp,
                                'minor_edit' => $row->ar_minor_edit,
                                'text_id'    => $row->ar_text_id,
+                               'len'            => $row->ar_len
                                ) );
-                       $newRevId = $revision->insertOn( $dbw );
+                       $revision->insertOn( $dbw );
+                       $restored++;
                }
 
                if( $revision ) {
-                       # FIXME: Update latest if newer as well...
-                       if( $newid ) {
-                               # FIXME: update article count if changed...
-                               $article->updateRevisionOn( $dbw, $revision, $previousRevId );
-
-                               # Finally, clean up the link tables
-                               $options = new ParserOptions;
-                               $parserOutput = $wgParser->parse( $revision->getText(), $this->title, $options,
-                                       true, true, $newRevId );
-                               $u = new LinksUpdate( $this->title, $parserOutput );
-                               $u->doUpdate();
+                       // Attach the latest revision to the page...
+                       $wasnew = $article->updateIfNewerOn( $dbw, $revision, $previousRevId );
 
-                               #TODO: SearchUpdate, etc.
+                       if( $newid || $wasnew ) {
+                               // Update site stats, link tables, etc
+                               $article->createUpdates( $revision );
                        }
 
                        if( $newid ) {
+                               wfRunHooks( 'ArticleUndelete', array( &$this->title, true ) );
                                Article::onArticleCreate( $this->title );
                        } else {
+                               wfRunHooks( 'ArticleUndelete', array( &$this->title, false ) );
                                Article::onArticleEdit( $this->title );
                        }
                } else {
@@ -282,38 +443,37 @@ class PageArchive {
                                'ar_namespace' => $this->title->getNamespace(),
                                'ar_title' => $this->title->getDBkey(),
                                $oldones ),
-                       $fname );
-
-               # Touch the log!
-               $log = new LogPage( 'delete' );
-               if( $restoreAll ) {
-                       $reason = '';
-               } else {
-                       $reason = wfMsgForContent( 'undeletedrevisions', $restoreRevisions );
-               }
-               $log->addEntry( 'restore', $this->title, $reason );
+                       __METHOD__ );
 
-               return true;
+               return $restored;
        }
+
 }
 
 /**
- *
- * @package MediaWiki
- * @subpackage SpecialPage
+ * The HTML form for Special:Undelete, which allows users with the appropriate
+ * permissions to view and restore deleted content.
+ * @addtogroup SpecialPage
  */
 class UndeleteForm {
        var $mAction, $mTarget, $mTimestamp, $mRestore, $mTargetObj;
-       var $mTargetTimestamp, $mAllowed;
+       var $mTargetTimestamp, $mAllowed, $mComment;
 
-       function UndeleteForm( &$request, $par = "" ) {
+       function UndeleteForm( $request, $par = "" ) {
                global $wgUser;
-               $this->mAction = $request->getText( 'action' );
-               $this->mTarget = $request->getText( 'target' );
-               $this->mTimestamp = $request->getText( 'timestamp' );
-               $this->mRestore = $request->getCheck( 'restore' ) &&
-                       $request->wasPosted() &&
+               $this->mAction = $request->getVal( 'action' );
+               $this->mTarget = $request->getVal( 'target' );
+               $this->mSearchPrefix = $request->getText( 'prefix' );
+               $time = $request->getVal( 'timestamp' );
+               $this->mTimestamp = $time ? wfTimestamp( TS_MW, $time ) : '';
+               $this->mFile = $request->getVal( 'file' );
+               
+               $posted = $request->wasPosted() &&
                        $wgUser->matchEditToken( $request->getVal( 'wpEditToken' ) );
+               $this->mRestore = $request->getCheck( 'restore' ) && $posted;
+               $this->mPreview = $request->getCheck( 'preview' ) && $posted;
+               $this->mComment = $request->getText( 'wpComment' );
+               
                if( $par != "" ) {
                        $this->mTarget = $par;
                }
@@ -331,10 +491,16 @@ class UndeleteForm {
                }
                if( $this->mRestore ) {
                        $timestamps = array();
+                       $this->mFileVersions = array();
                        foreach( $_REQUEST as $key => $val ) {
+                               $matches = array();
                                if( preg_match( '/^ts(\d{14})$/', $key, $matches ) ) {
                                        array_push( $timestamps, $matches[1] );
                                }
+                               
+                               if( preg_match( '/^fileid(\d+)$/', $key, $matches ) ) {
+                                       $this->mFileVersions[] = intval( $matches[1] );
+                               }
                        }
                        rsort( $timestamps );
                        $this->mTargetTimestamp = $timestamps;
@@ -342,45 +508,78 @@ class UndeleteForm {
        }
 
        function execute() {
-
+               global $wgOut;
+               if ( $this->mAllowed ) {
+                       $wgOut->setPagetitle( wfMsg( "undeletepage" ) );
+               } else {
+                       $wgOut->setPagetitle( wfMsg( "viewdeletedpage" ) );
+               }
+               
                if( is_null( $this->mTargetObj ) ) {
-                       return $this->showList();
+                       $this->showSearchForm();
+
+                       # List undeletable articles
+                       if( $this->mSearchPrefix ) {
+                               $result = PageArchive::listPagesByPrefix(
+                                       $this->mSearchPrefix );
+                               $this->showList( $result );
+                       }
+                       return;
                }
                if( $this->mTimestamp !== '' ) {
                        return $this->showRevision( $this->mTimestamp );
                }
+               if( $this->mFile !== null ) {
+                       return $this->showFile( $this->mFile );
+               }
                if( $this->mRestore && $this->mAction == "submit" ) {
                        return $this->undelete();
                }
                return $this->showHistory();
        }
 
-       /* private */ function showList() {
-               global $wgLang, $wgContLang, $wgUser, $wgOut;
-               $fname = "UndeleteForm::showList";
-
-               # List undeletable articles
-               $result = PageArchive::listAllPages();
+       function showSearchForm() {
+               global $wgOut, $wgScript;
+               $wgOut->addWikiText( wfMsg( 'undelete-header' ) );
+               
+               $wgOut->addHtml(
+                       Xml::openElement( 'form', array(
+                               'method' => 'get',
+                               'action' => $wgScript ) ) .
+                       '<fieldset>' .
+                       Xml::element( 'legend', array(),
+                               wfMsg( 'undelete-search-box' ) ) .
+                       Xml::hidden( 'title',
+                               SpecialPage::getTitleFor( 'Undelete' )->getPrefixedDbKey() ) .
+                       Xml::inputLabel( wfMsg( 'undelete-search-prefix' ),
+                               'prefix', 'prefix', 20,
+                               $this->mSearchPrefix ) .
+                       Xml::submitButton( wfMsg( 'undelete-search-submit' ) ) .
+                       '</fieldset>' .
+                       '</form>' );
+       }
 
-               if ( $this->mAllowed ) {
-                       $wgOut->setPagetitle( wfMsg( "undeletepage" ) );
-               } else {
-                       $wgOut->setPagetitle( wfMsg( "viewdeletedpage" ) );
+       /* private */ function showList( $result ) {
+               global $wgLang, $wgContLang, $wgUser, $wgOut;
+               
+               if( $result->numRows() == 0 ) {
+                       $wgOut->addWikiText( wfMsg( 'undelete-no-results' ) );
+                       return;
                }
+
                $wgOut->addWikiText( wfMsg( "undeletepagetext" ) );
 
                $sk = $wgUser->getSkin();
-               $undelete =& Title::makeTitle( NS_SPECIAL, 'Undelete' );
+               $undelete = SpecialPage::getTitleFor( 'Undelete' );
                $wgOut->addHTML( "<ul>\n" );
                while( $row = $result->fetchObject() ) {
-                       $n = ($row->ar_namespace ?
-                               ($wgContLang->getNsText( $row->ar_namespace ) . ":") : "").
-                               $row->ar_title;
-                       $link = $sk->makeKnownLinkObj( $undelete,
-                               htmlspecialchars( $n ), "target=" . urlencode( $n ) );
-                       $revisions = htmlspecialchars( wfMsg( "undeleterevisions",
-                               $wgLang->formatNum( $row->count ) ) );
-                       $wgOut->addHTML( "<li>$link $revisions</li>\n" );
+                       $title = Title::makeTitleSafe( $row->ar_namespace, $row->ar_title );
+                       $link = $sk->makeKnownLinkObj( $undelete, htmlspecialchars( $title->getPrefixedText() ), 'target=' . $title->getPrefixedUrl() );
+                       #$revs = wfMsgHtml( 'undeleterevisions', $wgLang->formatNum( $row->count ) );
+                       $revs = wfMsgExt( 'undeleterevisions',
+                               array( 'parseinline' ),
+                               $wgLang->formatNum( $row->count ) );
+                       $wgOut->addHtml( "<li>{$link} ({$revs})</li>\n" );
                }
                $result->free();
                $wgOut->addHTML( "</ul>\n" );
@@ -390,16 +589,82 @@ class UndeleteForm {
 
        /* private */ function showRevision( $timestamp ) {
                global $wgLang, $wgUser, $wgOut;
-               $fname = "UndeleteForm::showRevision";
+               $self = SpecialPage::getTitleFor( 'Undelete' );
+               $skin = $wgUser->getSkin();
 
                if(!preg_match("/[0-9]{14}/",$timestamp)) return 0;
 
-               $archive =& new PageArchive( $this->mTargetObj );
-               $text = $archive->getRevisionText( $timestamp );
+               $archive = new PageArchive( $this->mTargetObj );
+               $rev = $archive->getRevision( $timestamp );
+               
+               $wgOut->setPageTitle( wfMsg( 'undeletepage' ) );
+               $link = $skin->makeKnownLinkObj( $self, htmlspecialchars( $this->mTargetObj->getPrefixedText() ),
+                                       'target=' . $this->mTargetObj->getPrefixedUrl() );
+               $wgOut->addHtml( '<p>' . wfMsgHtml( 'undelete-revision', $link,
+                       htmlspecialchars( $wgLang->timeAndDate( $timestamp ) ) ) . '</p>' ); 
+               
+               if( !$rev ) {
+                       $wgOut->addWikiText( wfMsg( 'undeleterevision-missing' ) );
+                       return;
+               }
+               
+               wfRunHooks( 'UndeleteShowRevision', array( $this->mTargetObj, $rev ) );
+               
+               if( $this->mPreview ) {
+                       $wgOut->addHtml( "<hr />\n" );
+                       $wgOut->addWikiTextTitleTidy( $rev->getText(), $this->mTargetObj, false );
+               }
 
-               $wgOut->setPagetitle( wfMsg( "undeletepage" ) );
-               $wgOut->addWikiText( "(" . wfMsg( "undeleterevision",
-                       $wgLang->date( $timestamp ) ) . ")\n<hr />\n" . $text );
+               $wgOut->addHtml(
+                       wfElement( 'textarea', array(
+                                       'readonly' => true,
+                                       'cols' => intval( $wgUser->getOption( 'cols' ) ),
+                                       'rows' => intval( $wgUser->getOption( 'rows' ) ) ),
+                               $rev->getText() . "\n" ) .
+                       wfOpenElement( 'div' ) .
+                       wfOpenElement( 'form', array(
+                               'method' => 'post',
+                               'action' => $self->getLocalURL( "action=submit" ) ) ) .
+                       wfElement( 'input', array(
+                               'type' => 'hidden',
+                               'name' => 'target',
+                               'value' => $this->mTargetObj->getPrefixedDbKey() ) ) .
+                       wfElement( 'input', array(
+                               'type' => 'hidden',
+                               'name' => 'timestamp',
+                               'value' => $timestamp ) ) .
+                       wfElement( 'input', array(
+                               'type' => 'hidden',
+                               'name' => 'wpEditToken',
+                               'value' => $wgUser->editToken() ) ) .
+                       wfElement( 'input', array(
+                               'type' => 'hidden',
+                               'name' => 'preview',
+                               'value' => '1' ) ) .
+                       wfElement( 'input', array(
+                               'type' => 'submit',
+                               'value' => wfMsg( 'showpreview' ) ) ) .
+                       wfCloseElement( 'form' ) .
+                       wfCloseElement( 'div' ) );
+       }
+       
+       /**
+        * Show a deleted file version requested by the visitor.
+        */
+       function showFile( $key ) {
+               global $wgOut, $wgRequest;
+               $wgOut->disable();
+               
+               # We mustn't allow the output to be Squid cached, otherwise
+               # if an admin previews a deleted image, and it's cached, then
+               # a user without appropriate permissions can toddle off and
+               # nab the image, and Squid will serve it
+               $wgRequest->response()->header( 'Expires: ' . gmdate( 'D, d M Y H:i:s', 0 ) . ' GMT' );
+               $wgRequest->response()->header( 'Cache-Control: no-cache, no-store, max-age=0, must-revalidate' );
+               $wgRequest->response()->header( 'Pragma: no-cache' );
+               
+               $store = FileStore::get( 'deleted' );
+               $store->stream( $key );
        }
 
        /* private */ function showHistory() {
@@ -413,99 +678,173 @@ class UndeleteForm {
                }
 
                $archive = new PageArchive( $this->mTargetObj );
+               /*
                $text = $archive->getLastRevisionText();
                if( is_null( $text ) ) {
                        $wgOut->addWikiText( wfMsg( "nohistory" ) );
                        return;
                }
+               */
                if ( $this->mAllowed ) {
-                       $wgOut->addWikiText( wfMsg( "undeletehistory" ) . "\n----\n" . $text );
+                       $wgOut->addWikiText( wfMsg( "undeletehistory" ) );
                } else {
                        $wgOut->addWikiText( wfMsg( "undeletehistorynoadmin" ) );
                }
 
                # List all stored revisions
                $revisions = $archive->listRevisions();
+               $files = $archive->listFiles();
+               
+               $haveRevisions = $revisions && $revisions->numRows() > 0;
+               $haveFiles = $files && $files->numRows() > 0;
+               
+               # Batch existence check on user and talk pages
+               if( $haveRevisions ) {
+                       $batch = new LinkBatch();
+                       while( $row = $revisions->fetchObject() ) {
+                               $batch->addObj( Title::makeTitleSafe( NS_USER, $row->ar_user_text ) );
+                               $batch->addObj( Title::makeTitleSafe( NS_USER_TALK, $row->ar_user_text ) );
+                       }
+                       $batch->execute();
+                       $revisions->seek( 0 );
+               }
+               if( $haveFiles ) {
+                       $batch = new LinkBatch();
+                       while( $row = $files->fetchObject() ) {
+                               $batch->addObj( Title::makeTitleSafe( NS_USER, $row->fa_user_text ) );
+                               $batch->addObj( Title::makeTitleSafe( NS_USER_TALK, $row->fa_user_text ) );
+                       }
+                       $batch->execute();
+                       $files->seek( 0 );
+               }
 
                if ( $this->mAllowed ) {
-                       $titleObj = Title::makeTitle( NS_SPECIAL, "Undelete" );
-                       $action = $titleObj->escapeLocalURL( "action=submit" );
-                       $encTarget = htmlspecialchars( $this->mTarget );
-                       $button = htmlspecialchars( wfMsg("undeletebtn") );
-                       $token = htmlspecialchars( $wgUser->editToken() );
-
-                       $wgOut->addHTML("
-                               <form id=\"undelete\" method=\"post\" action=\"{$action}\">
-                               <input type=\"hidden\" name=\"target\" value=\"{$encTarget}\" />
-                               <input type=\"submit\" name=\"restore\" value=\"{$button}\" />
-                               <input type='hidden' name='wpEditToken' value=\"{$token}\" />
-                               ");
+                       $titleObj = SpecialPage::getTitleFor( "Undelete" );
+                       $action = $titleObj->getLocalURL( "action=submit" );
+                       # Start the form here
+                       $top = wfOpenElement( 'form', array( 'method' => 'post', 'action' => $action, 'id' => 'undelete' ) );
+                       $wgOut->addHtml( $top );
                }
 
                # Show relevant lines from the deletion log:
                $wgOut->addHTML( "<h2>" . htmlspecialchars( LogPage::logName( 'delete' ) ) . "</h2>\n" );
-               require_once( 'SpecialLog.php' );
-               $logViewer =& new LogViewer(
+               $logViewer = new LogViewer(
                        new LogReader(
                                new FauxRequest(
                                        array( 'page' => $this->mTargetObj->getPrefixedText(),
-                                              'type' => 'delete' ) ) ) );
+                                                  'type' => 'delete' ) ) ) );
                $logViewer->showList( $wgOut );
-
-               # The page's stored (deleted) history:
+               
+               if( $this->mAllowed && ( $haveRevisions || $haveFiles ) ) {
+                       # Format the user-visible controls (comment field, submission button)
+                       # in a nice little table
+                       $table = '<fieldset><table><tr>';
+                       $table .= '<td colspan="2">' . wfMsgWikiHtml( 'undeleteextrahelp' ) . '</td></tr><tr>';
+                       $table .= '<td align="right"><strong>' . wfMsgHtml( 'undeletecomment' ) . '</strong></td>';
+                       $table .= '<td>' . wfInput( 'wpComment', 50, $this->mComment ) . '</td>';
+                       $table .= '</tr><tr><td>&nbsp;</td><td>';
+                       $table .= wfSubmitButton( wfMsg( 'undeletebtn' ), array( 'name' => 'restore' ) );
+                       $table .= wfElement( 'input', array( 'type' => 'reset', 'value' => wfMsg( 'undeletereset' ) ) );
+                       $table .= '</td></tr></table></fieldset>';
+                       $wgOut->addHtml( $table );
+               }
+       
                $wgOut->addHTML( "<h2>" . htmlspecialchars( wfMsg( "history" ) ) . "</h2>\n" );
-               $wgOut->addHTML("<ul>");
-               $target = urlencode( $this->mTarget );
-               while( $row = $revisions->fetchObject() ) {
-                       $ts = wfTimestamp( TS_MW, $row->ar_timestamp );
-                       if ( $this->mAllowed ) {
-                               $checkBox = "<input type=\"checkbox\" name=\"ts$ts\" value=\"1\" />";
-                               $pageLink = $sk->makeKnownLinkObj( $titleObj,
-                                       $wgLang->timeanddate( $ts, true ),
-                                       "target=$target&timestamp=$ts" );
-                       } else {
-                               $checkBox = '';
-                               $pageLink = $wgLang->timeanddate( $ts, true );
-                       }
-                       $userLink = htmlspecialchars( $row->ar_user_text );
-                       if( $row->ar_user ) {
-                               $userLink = $sk->makeKnownLinkObj(
-                                       Title::makeTitle( NS_USER, $row->ar_user_text ),
-                                       $userLink );
-                       } else {
-                               $userLink = $sk->makeKnownLinkObj(
-                                       Title::makeTitle( NS_SPECIAL, 'Contributions' ),
-                                       $userLink, 'target=' . $row->ar_user_text );
+
+               if( $haveRevisions ) {
+                       # The page's stored (deleted) history:
+                       $wgOut->addHTML("<ul>");
+                       $target = urlencode( $this->mTarget );
+                       while( $row = $revisions->fetchObject() ) {
+                               $ts = wfTimestamp( TS_MW, $row->ar_timestamp );
+                               if ( $this->mAllowed ) {
+                                       $checkBox = wfCheck( "ts$ts" );
+                                       $pageLink = $sk->makeKnownLinkObj( $titleObj,
+                                               $wgLang->timeanddate( $ts, true ),
+                                               "target=$target&timestamp=$ts" );
+                               } else {
+                                       $checkBox = '';
+                                       $pageLink = $wgLang->timeanddate( $ts, true );
+                               }
+                               $userLink = $sk->userLink( $row->ar_user, $row->ar_user_text ) . $sk->userToolLinks( $row->ar_user, $row->ar_user_text );
+                               $stxt = '';
+                               if (!is_null($size = $row->ar_len)) {
+                                       if ($size == 0) {
+                                               $stxt = wfMsgHtml('historyempty');
+                                       } else {
+                                               $stxt = wfMsgHtml('historysize', $wgLang->formatNum( $size ) );
+                                       }
+                               }
+                               $comment = $sk->commentBlock( $row->ar_comment );
+                               $wgOut->addHTML( "<li>$checkBox $pageLink . . $userLink $stxt $comment</li>\n" );
+       
                        }
-                       $comment = $sk->commentBlock( $row->ar_comment );
-                       $wgOut->addHTML( "<li>$checkBox $pageLink . . $userLink $comment</li>\n" );
+                       $revisions->free();
+                       $wgOut->addHTML("</ul>");
+               } else {
+                       $wgOut->addWikiText( wfMsg( "nohistory" ) );
+               }
 
+               
+               if( $haveFiles ) {
+                       $wgOut->addHtml( "<h2>" . wfMsgHtml( 'imghistory' ) . "</h2>\n" );
+                       $wgOut->addHtml( "<ul>" );
+                       while( $row = $files->fetchObject() ) {
+                               $ts = wfTimestamp( TS_MW, $row->fa_timestamp );
+                               if ( $this->mAllowed && $row->fa_storage_key ) {
+                                       $checkBox = wfCheck( "fileid" . $row->fa_id );
+                                       $key = urlencode( $row->fa_storage_key );
+                                       $target = urlencode( $this->mTarget );
+                                       $pageLink = $sk->makeKnownLinkObj( $titleObj,
+                                               $wgLang->timeanddate( $ts, true ),
+                                               "target=$target&file=$key" );
+                               } else {
+                                       $checkBox = '';
+                                       $pageLink = $wgLang->timeanddate( $ts, true );
+                               }
+                               $userLink = $sk->userLink( $row->fa_user, $row->fa_user_text ) . $sk->userToolLinks( $row->fa_user, $row->fa_user_text );
+                               $data =
+                                       wfMsgHtml( 'widthheight',
+                                               $wgLang->formatNum( $row->fa_width ),
+                                               $wgLang->formatNum( $row->fa_height ) ) .
+                                       ' (' .
+                                       wfMsgHtml( 'nbytes', $wgLang->formatNum( $row->fa_size ) ) .
+                                       ')';
+                               $comment = $sk->commentBlock( $row->fa_description );
+                               $wgOut->addHTML( "<li>$checkBox $pageLink . . $userLink $data $comment</li>\n" );
+                       }
+                       $files->free();
+                       $wgOut->addHTML( "</ul>" );
                }
-               $revisions->free();
-               $wgOut->addHTML("</ul>");
+               
                if ( $this->mAllowed ) {
-                       $wgOut->addHTML( "\n</form>" );
+                       # Slip in the hidden controls here
+                       $misc  = wfHidden( 'target', $this->mTarget );
+                       $misc .= wfHidden( 'wpEditToken', $wgUser->editToken() );
+                       $wgOut->addHtml( $misc . '</form>' );
                }
 
                return true;
        }
 
        function undelete() {
-               global $wgOut;
+               global $wgOut, $wgUser;
                if( !is_null( $this->mTargetObj ) ) {
                        $archive = new PageArchive( $this->mTargetObj );
-                       if( $archive->undelete( $this->mTargetTimestamp ) ) {
-                               $wgOut->addWikiText( wfMsg( "undeletedtext", $this->mTarget ) );
-
-                               if (NS_IMAGE == $this->mTargetObj->getNamespace()) {
-                                       /* refresh image metadata cache */
-                                       new Image( $this->mTargetObj );
-                               }
-
+                       
+                       $ok = $archive->undelete(
+                               $this->mTargetTimestamp,
+                               $this->mComment,
+                               $this->mFileVersions );
+                       
+                       if( $ok ) {
+                               $skin = $wgUser->getSkin();
+                               $link = $skin->makeKnownLinkObj( $this->mTargetObj );
+                               $wgOut->addHtml( wfMsgWikiHtml( 'undeletedpage', $link ) );
                                return true;
                        }
                }
-               $wgOut->fatalError( wfMsg( "cannotundelete" ) );
+               $wgOut->showFatalError( wfMsg( "cannotundelete" ) );
                return false;
        }
 }