Oops, escape the output too. Thanks to Nikerabbit :)
[lhc/web/wiklou.git] / includes / SpecialSearch.php
index be5165a..e20d838 100644 (file)
@@ -154,6 +154,8 @@ class SpecialSearch {
                        wfProfileOut( $fname );
                        return;
                }
+               
+               $wgOut->addHTML( $this->shortDialog( $term ) );
 
                $search = SearchEngine::create();
                $search->setLimitOffset( $this->limit, $this->offset );
@@ -189,7 +191,7 @@ class SpecialSearch {
                                        $this->powerSearchOptions(),
                                        array( 'search' => $term ) ),
                                        ($num < $this->limit) );
-                       $wgOut->addHTML( "<br />{$prevnext}\n" );
+                       $wgOut->addHTML( "<p>{$prevnext}</p>\n" );
                }
 
                if( $titleMatches ) {
@@ -288,6 +290,8 @@ class SpecialSearch {
                $opt['searchx'] = 1;
                return $opt;
        }
+       
+
 
        /**
         * @param SearchResultSet $matches
@@ -302,12 +306,12 @@ class SpecialSearch {
                $terms = implode( '|', $tm );
 
                $off = $this->offset + 1;
-               $out = "<ol start='{$off}'>\n";
+               $out = "<ul start='{$off}' class='mw-search-results'>\n";
 
                while( $result = $matches->next() ) {
                        $out .= $this->showHit( $result, $terms );
                }
-               $out .= "</ol>\n";
+               $out .= "</ul>\n";
 
                // convert the whole thing to desired language variant
                global $wgContLang;
@@ -333,7 +337,8 @@ class SpecialSearch {
                }
                $sk = $wgUser->getSkin();
 
-               $contextlines = $wgUser->getOption( 'contextlines',  5 );
+               //$contextlines = $wgUser->getOption( 'contextlines',  5 );
+               $contextlines = 2; // Hardcode this. Old defaults sucked. :)
                $contextchars = $wgUser->getOption( 'contextchars', 50 );
 
                $link = $sk->makeKnownLinkObj( $t );
@@ -345,50 +350,73 @@ class SpecialSearch {
                        return "<li>{$link}</li>\n";
                }
                
-               $extract = $size = '';
+               $revision = Revision::newFromTitle( $t );
+               // If the page doesn't *exist*... our search index is out of date.
+               // The least confusing at this point is to drop the result.
+               // You may get less results, but... oh well. :P
+               if( !$revision ) {
+                       return "<!-- missing page " .
+                               htmlspecialchars( $t->getPrefixedText() ) . "-->\n";
+               }
+               
+               $text = $revision->getText();
+               $size = wfMsgExt( 'search-result-size', array( 'parsemag', 'escape' ),
+                       $sk->formatSize( strlen( $text ) ),
+                       str_word_count( $text ) );
+               $date = $wgLang->timeanddate( $revision->getTimestamp() );
+               
+               if( is_null( $result->getScore() ) ) {
+                       // Search engine doesn't report scoring info
+                       $score = '';
+               } else {
+                       $percent = sprintf( '%2.1f', $result->getScore() * 100 );
+                       $score = wfMsg( 'search-result-score', $wgLang->formatNum( $percent ) )
+                               . ' - ';
+               }
+
+               $extract = $this->extractText( $text, $terms, $contextlines, $contextchars );
+               
                // Include a thumbnail for media files...
                if( $t->getNamespace() == NS_IMAGE ) {
                        $img = wfFindFile( $t );
                        if( $img ) {
                                $thumb = $img->getThumbnail( 120, 120 );
                                if( $thumb ) {
-                                       $extract = '<table>' .
+                                       $desc = $img->getShortDesc();
+                                       wfProfileOut( $fname );
+                                       // Ugly table. :D
+                                       // Float doesn't seem to interact well with the bullets.
+                                       // Table messes up vertical alignment of the bullet, but I'm
+                                       // not sure what more I can do about that. :(
+                                       return "<li>" .
+                                               '<table class="searchResultImage">' .
                                                '<tr>' .
                                                '<td width="120" align="center">' .
-                                               $sk->makeKnownLinkObj( $t, $thumb->toHtml() ) .
+                                               $thumb->toHtml( array( 'desc-link' => true ) ) .
                                                '</td>' .
-                                               '<td>' .
+                                               '<td valign="top">' .
                                                $link .
-                                               '<br />' .
-                                               $img->getLongDesc() .
+                                               $extract .
+                                               "<div class='mw-search-result-data'>{$score}{$desc} - {$date}</div>" .
                                                '</td>' .
                                                '</tr>' .
-                                               '</table>';
-                                       wfProfileOut( $fname );
-                                       return "<li><div>{$extract}</div></li>\n";
+                                               '</table>' .
+                                               "</li>\n";
                                }
                        }
                }
 
-               $extract = $this->extractText( $t, $terms, $contextlines, $contextchars );
                wfProfileOut( $fname );
-               return "<li>{$link} {$extract}</li>\n";
+               return "<li>{$link} {$extract}\n" .
+                       "<div class='mw-search-result-data'>{$score}{$size} - {$date}</div>" .
+                       "</li>\n";
 
        }
        
-       private function extractText( $t, $terms, $contextlines, $contextchars ) {
+       private function extractText( $text, $terms, $contextlines, $contextchars ) {
                global $wgLang, $wgContLang;
                $fname = __METHOD__;
        
-               $revision = Revision::newFromTitle( $t );
-               if( !$revision ) {
-                       return '<!-- missing page -->';
-               }
-               
-               $text = $revision->getText();
-               $size = wfMsgExt( 'nbytes', array( 'parsemag', 'escape'),
-                       $wgLang->formatNum( strlen( $text ) ) );
-
                $lines = explode( "\n", $text );
 
                $max = intval( $contextchars ) + 1;
@@ -396,7 +424,7 @@ class SpecialSearch {
 
                $lineno = 0;
 
-               $extract = "($size)";
+               $extract = "";
                wfProfileIn( "$fname-extract" );
                foreach ( $lines as $line ) {
                        if ( 0 == $contextlines ) {
@@ -423,55 +451,69 @@ class SpecialSearch {
                        $line = preg_replace( $pat2,
                          "<span class='searchmatch'>\\1</span>", $line );
 
-                       $extract .= "<br /><small>{$lineno}: {$line}</small>\n";
+                       $extract .= "<br /><small>{$line}</small>\n";
                }
                wfProfileOut( "$fname-extract" );
                
                return $extract;
        }
 
+       /**
+        * Generates the power search box at bottom of [[Special:Search]]
+        * @param $term string: search term
+        * @return $out string: HTML form
+        */
        function powerSearchBox( $term ) {
+               global $wgScript;
+
                $namespaces = '';
                foreach( SearchEngine::searchableNamespaces() as $ns => $name ) {
-                       $checked = in_array( $ns, $this->namespaces )
-                               ? ' checked="checked"'
-                               : '';
                        $name = str_replace( '_', ' ', $name );
                        if( '' == $name ) {
                                $name = wfMsg( 'blanknamespace' );
                        }
-                       $encName = htmlspecialchars( $name );
-                       $namespaces .= " <label><input type='checkbox' value=\"1\" name=\"" .
-                         "ns{$ns}\"{$checked} />{$encName}</label>\n";
+                       $namespaces .= Xml::openElement( 'span', array( 'style' => 'white-space: nowrap' ) ) .
+                                       Xml::checkLabel( $name, "ns{$ns}", $name, in_array( $ns, $this->namespaces ) ) . 
+                                       Xml::closeElement( 'span' ) . "\n";
                }
 
-               $checked = $this->searchRedirects
-                       ? ' checked="checked"'
-                       : '';
-               $redirect = "<input type='checkbox' value='1' name=\"redirs\"{$checked} />\n";
-
-               $searchField = '<input type="text" id="powerSearchText" name="search" value="' .
-                       htmlspecialchars( $term ) ."\" size=\"16\" />\n";
-
-               $searchButton = '<input type="submit" name="searchx" value="' .
-                 htmlspecialchars( wfMsg('powersearch') ) . "\" />\n";
+               $redirect = Xml::check( 'redirs', $this->searchRedirects, array( 'value' => '1' ) );
+               $searchField = Xml::input( 'search', 50, $term, array( 'type' => 'text', 'id' => 'powerSearchText' ) );
+               $searchButton = Xml::submitButton( wfMsg( 'powersearch' ), array( 'name' => 'searchx' ) ) . "\n";
+
+               $out = Xml::openElement( 'form', array( 'id' => 'powersearch', 'method' => 'get', 'action' => $wgScript ) ) .
+                       Xml::openElement( 'fieldset' ) .
+                       Xml::element( 'legend', array( ), wfMsg( 'powersearch' ) ) .
+                       Xml::hidden( 'title', 'Special:Search' ) .
+                       wfMsgExt( 'powersearchtext', array( 'parse', 'replaceafter' ),
+                               $namespaces, $redirect, $searchField,
+                               '', '', '', '', '', # Dummy placeholders
+                               $searchButton ) .
+                       Xml::closeElement( 'fieldset' ) .
+                       Xml::closeElement( 'form' );
 
-               $ret = wfMsg( 'powersearchtext',
-                       $namespaces, $redirect, $searchField,
-                       '', '', '', '', '', # Dummy placeholders
-                       $searchButton );
-
-               $title = SpecialPage::getTitleFor( 'Search' );
-               $action = $title->escapeLocalURL();
-               return "<br /><br />\n<form id=\"powersearch\" method=\"get\" " .
-                 "action=\"$action\">\n{$ret}\n</form>\n";
+               return $out;
        }
-       
+
        function powerSearchFocus() {
                return "<script type='text/javascript'>" .
                        "document.getElementById('powerSearchText').focus();" .
                        "</script>";
        }
+       
+       function shortDialog($term) {
+               global $wgScript;
+               
+               $out  = Xml::openElement( 'form', array(
+                       'id' => 'search',
+                       'method' => 'get',
+                       'action' => $wgScript
+               ));
+               $out .= Xml::hidden( 'title', 'Special:Search' );
+               $out .= Xml::input( 'search', 50, $term ) . ' ';
+               $out .= Xml::submitButton( wfMsg( 'searchbutton' ), array( 'name' => 'fulltext' ) );
+               $out .= Xml::closeElement( 'form' );
+               
+               return $out;
+       }
 }
-
-