Kill some trailing whitespace

[lhc/web/wiklou.git] / includes / SpecialRandompage.php

diff --git a/includes/SpecialRandompage.php b/includes/SpecialRandompage.php
index a442623..0dd0f51 100644 (file)
--- a/includes/SpecialRandompage.php
+++ b/includes/SpecialRandompage.php
@@ -1,30 +1,57 @@
 <?php
+/**
+ * @addtogroup SpecialPage
+ */
 
-function wfSpecialRandompage()
-{
-       global $wgOut, $wgTitle, $wgArticle;
-       $fname = "wfSpecialRandompage";
+/**
+ * Constructor
+ *
+ * @param $par The namespace to get a random page from (default NS_MAIN),
+ *               used as e.g. Special:Randompage/Category
+ */
+function wfSpecialRandompage( $par = NS_MAIN ) {
+       global $wgOut, $wgExtraRandompageSQL;
+       $fname = 'wfSpecialRandompage';
+
+       # Determine namespace
+       $t = Title::newFromText ( $par . ":Dummy" ) ;
+       $namespace = $t->getNamespace () ;
+
+       # NOTE! We use a literal constant in the SQL instead of the RAND()
+       # function because RAND() will return a different value for every row
+       # in the table. That's both very slow and returns results heavily
+       # biased towards low values, as rows later in the table will likely
+       # never be reached for comparison.
+       #
+       # Using a literal constant means the whole thing gets optimized on
+       # the index, and the comparison is both fast and fair.
 
-       wfSeedRandom();
-       $rand = mt_rand() / mt_getrandmax();
        # interpolation and sprintf() can muck up with locale-specific decimal separator
-       $randstr = number_format( $rand, 12, ".", "" );
-       $sqlget = "SELECT cur_id,cur_title
-               FROM cur USE INDEX (cur_random)
-               WHERE cur_namespace=0 AND cur_is_redirect=0
-               AND cur_random>$randstr
-               ORDER BY cur_random
-               LIMIT 1";
-       $res = wfQuery( $sqlget, DB_READ, $fname );
-       if( $s = wfFetchObject( $res ) ) {
-               $rt = wfUrlEncode( $s->cur_title );
-       } else {
-               # No articles?!
-               $rt = "";
-       }
+       $randstr = wfRandom();
+
+       $db = wfGetDB( DB_SLAVE );
+       $use_index = $db->useIndexClause( 'page_random' );
+       $page = $db->tableName( 'page' );
 
+       $extra = $wgExtraRandompageSQL ? "AND ($wgExtraRandompageSQL)" : '';
+       $sql = "SELECT page_id,page_title
+               FROM $page $use_index
+               WHERE page_namespace=$namespace AND page_is_redirect=0 $extra
+               AND page_random>$randstr
+               ORDER BY page_random";
+       $sql = $db->limitResult($sql, 1, 0);
+       $res = $db->query( $sql, $fname );
+
+       $title = null;
+       if( $s = $db->fetchObject( $res ) ) {
+               $title =& Title::makeTitle( $namespace, $s->page_title );
+       }
+       if( is_null( $title ) ) {
+               # That's not supposed to happen :)
+               $title = Title::newMainPage();
+       }
        $wgOut->reportTime(); # for logfile
-       $wgOut->redirect( wfLocalUrl( $rt ) );
+       $wgOut->redirect( $title->getFullUrl() );
 }
 
 ?>