* (bug 14258, 14368) Fix for subpage renames in replication environments

[lhc/web/wiklou.git] / includes / SpecialMostlinked.php

diff --git a/includes/SpecialMostlinked.php b/includes/SpecialMostlinked.php
index 9d0ecea..a56ac26 100644 (file)
--- a/includes/SpecialMostlinked.php
+++ b/includes/SpecialMostlinked.php
@@ -1,10 +1,14 @@
 <?php
+/**
+ * @file
+ * @ingroup SpecialPage
+ */
 
 /**
- * A special page to show pages ordered by the number of pages linking to them
+ * A special page to show pages ordered by the number of pages linking to them.
+ * Implements Special:Mostlinked
  *
- * @package MediaWiki
- * @subpackage SpecialPage
+ * @ingroup SpecialPage
  *
  * @author Ævar Arnfjörð Bjarmason <avarab@gmail.com>
  * @author Rob Church <robchur@gmail.com>
@@ -12,14 +16,6 @@
  * @copyright © 2006 Rob Church
  * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
  */
-
-/* */
-require_once 'QueryPage.php';
-
-/**
- * @package MediaWiki
- * @subpackage SpecialPage
- */
 class MostlinkedPage extends QueryPage {
 
        function getName() { return 'Mostlinked'; }
@@ -30,8 +26,8 @@ class MostlinkedPage extends QueryPage {
         * Note: Getting page_namespace only works if $this->isCached() is false
         */
        function getSQL() {
-               $dbr =& wfGetDB( DB_SLAVE );
-               extract( $dbr->tableNames( 'pagelinks', 'page' ) );
+               $dbr = wfGetDB( DB_SLAVE );
+               list( $pagelinks, $page ) = $dbr->tableNamesN( 'pagelinks', 'page' );
                return
                        "SELECT 'Mostlinked' AS type,
                                pl_namespace AS namespace,
@@ -40,19 +36,19 @@ class MostlinkedPage extends QueryPage {
                                page_namespace
                        FROM $pagelinks
                        LEFT JOIN $page ON pl_namespace=page_namespace AND pl_title=page_title
-                       GROUP BY pl_namespace,pl_title
+                       GROUP BY 1,2,3,5
                        HAVING COUNT(*) > 1";
        }
 
        /**
         * Pre-fill the link cache
         */
-       function preprocessResults( &$dbr, $res ) {
-               if( $dbr->numRows( $res ) > 0 ) {
+       function preprocessResults( $db, $res ) {
+               if( $db->numRows( $res ) > 0 ) {
                        $linkBatch = new LinkBatch();
-                       while( $row = $dbr->fetchObject( $res ) )
-                               $linkBatch->addObj( Title::makeTitleSafe( $row->namespace, $row->title ) );
-                       $dbr->dataSeek( $res, 0 );
+                       while( $row = $db->fetchObject( $res ) )
+                               $linkBatch->add( $row->namespace, $row->title );
+                       $db->dataSeek( $res, 0 );
                        $linkBatch->execute();
                }
        }
@@ -65,8 +61,8 @@ class MostlinkedPage extends QueryPage {
         * @return string
         */
        function makeWlhLink( &$title, $caption, &$skin ) {
-               $wlh = Title::makeTitle( NS_SPECIAL, 'Whatlinkshere' );
-               return $skin->makeKnownLinkObj( $wlh, $caption, 'target=' . $title->getPrefixedUrl() );
+               $wlh = SpecialPage::getTitleFor( 'Whatlinkshere', $title->getPrefixedDBkey() );
+               return $skin->makeKnownLinkObj( $wlh, $caption );
        }
 
        /**
@@ -97,5 +93,3 @@ function wfSpecialMostlinked() {
 
        $wpp->doQuery( $offset, $limit );
 }
-
-?>