Clean up after r14751:
[lhc/web/wiklou.git] / includes / SpecialBlockip.php
index ca1b398..b3f67ab 100644 (file)
@@ -9,14 +9,15 @@
 /**
  * Constructor
  */
-function wfSpecialBlockip() {
+function wfSpecialBlockip( $par ) {
        global $wgUser, $wgOut, $wgRequest;
 
-       if ( ! $wgUser->isAllowed('block') ) {
-               $wgOut->sysopRequired();
+       if( !$wgUser->isAllowed( 'block' ) ) {
+               $wgOut->permissionRequired( 'block' );
                return;
        }
-       $ipb = new IPBlockForm();
+
+       $ipb = new IPBlockForm( $par );
 
        $action = $wgRequest->getVal( 'action' );
        if ( 'success' == $action ) {
@@ -38,55 +39,63 @@ function wfSpecialBlockip() {
 class IPBlockForm {
        var $BlockAddress, $BlockExpiry, $BlockReason;
 
-       function IPBlockForm() {
+       function IPBlockForm( $par ) {
                global $wgRequest;
-               $this->BlockAddress = $wgRequest->getVal( 'wpBlockAddress', $wgRequest->getVal( 'ip' ) );
+
+               $this->BlockAddress = $wgRequest->getVal( 'wpBlockAddress', $wgRequest->getVal( 'ip', $par ) );
                $this->BlockReason = $wgRequest->getText( 'wpBlockReason' );
-               $this->BlockExpiry = $wgRequest->getVal( 'wpBlockExpiry' );
-               $this->BlockOther = $wgRequest->getVal( 'wpBlockOther' );
+               $this->BlockExpiry = $wgRequest->getVal( 'wpBlockExpiry', wfMsg('ipbotheroption') );
+               $this->BlockOther = $wgRequest->getVal( 'wpBlockOther', '' );
        }
-       
+
        function showForm( $err ) {
-               global $wgOut, $wgUser, $wgLang, $wgBlockExpiryOptions;
-               global $wgRequest, $wgSysopUserBans;
+               global $wgOut, $wgUser, $wgSysopUserBans;
 
-               $wgOut->setPagetitle( htmlspecialchars( wfMsg( 'blockip' ) ) );
+               $wgOut->setPagetitle( wfMsg( 'blockip' ) );
                $wgOut->addWikiText( wfMsg( 'blockiptext' ) );
 
                if($wgSysopUserBans) {
-                       $mIpaddress = htmlspecialchars( wfMsg( 'ipadressorusername' ) );
+                       $mIpaddress = wfMsgHtml( 'ipadressorusername' );
                } else {
-                       $mIpaddress = htmlspecialchars( wfMsg( 'ipaddress' ) );
+                       $mIpaddress = wfMsgHtml( 'ipaddress' );
                }
-               $mIpbexpiry = htmlspecialchars( wfMsg( 'ipbexpiry' ) );
-               $mIpbother = htmlspecialchars( wfMsg( 'ipbother' ) );
-               $mIpbothertime = htmlspecialchars( wfMsg( 'ipbotheroption' ) );
-               $mIpbreason = htmlspecialchars( wfMsg( 'ipbreason' ) );
-               $mIpbsubmit = htmlspecialchars( wfMsg( 'ipbsubmit' ) );
+               $mIpbexpiry = wfMsgHtml( 'ipbexpiry' );
+               $mIpbother = wfMsgHtml( 'ipbother' );
+               $mIpbothertime = wfMsgHtml( 'ipbotheroption' );
+               $mIpbreason = wfMsgHtml( 'ipbreason' );
+               $mIpbsubmit = wfMsgHtml( 'ipbsubmit' );
                $titleObj = Title::makeTitle( NS_SPECIAL, 'Blockip' );
                $action = $titleObj->escapeLocalURL( "action=submit" );
 
                if ( "" != $err ) {
-                       $wgOut->setSubtitle( wfMsg( 'formerror' ) );
+                       $wgOut->setSubtitle( wfMsgHtml( 'formerror' ) );
                        $wgOut->addHTML( "<p class='error'>{$err}</p>\n" );
                }
 
                $scBlockAddress = htmlspecialchars( $this->BlockAddress );
                $scBlockExpiry = htmlspecialchars( $this->BlockExpiry );
                $scBlockReason = htmlspecialchars( $this->BlockReason );
-               $scBlockOtherTime = htmlspecialchars( $this->BlockOtherTime );
-               $scBlockExpiryOptions = htmlspecialchars( wfMsg( 'ipboptions' ) );
+               $scBlockOtherTime = htmlspecialchars( $this->BlockOther );
+               $scBlockExpiryOptions = htmlspecialchars( wfMsgForContent( 'ipboptions' ) );
+
+               $showblockoptions = $scBlockExpiryOptions != '-';
+               if (!$showblockoptions)
+                       $mIpbother = $mIpbexpiry;
 
                $blockExpiryFormOptions = "<option value=\"other\">$mIpbothertime</option>";
                foreach (explode(',', $scBlockExpiryOptions) as $option) {
+                       if ( strpos($option, ":") === false ) $option = "$option:$option";
+                       list($show, $value) = explode(":", $option);
+                       $show = htmlspecialchars($show);
+                       $value = htmlspecialchars($value);
                        $selected = "";
-                       if ($this->BlockExpiry === $option)
+                       if ($this->BlockExpiry === $value)
                                $selected = ' selected="selected"';
-                       $blockExpiryFormOptions .= "<option$selected>$option</option>";
+                       $blockExpiryFormOptions .= "<option value=\"$value\"$selected>$show</option>";
                }
 
                $token = htmlspecialchars( $wgUser->editToken() );
-               
+
                $wgOut->addHTML( "
 <form id=\"blockip\" method=\"post\" action=\"{$action}\">
        <table border='0'>
@@ -96,15 +105,20 @@ class IPBlockForm {
                                <input tabindex='1' type='text' size='20' name=\"wpBlockAddress\" value=\"{$scBlockAddress}\" />
                        </td>
                </tr>
-               <tr>
+               <tr>");
+               if ($showblockoptions) {
+                       $wgOut->addHTML("
                        <td align=\"right\">{$mIpbexpiry}:</td>
                        <td align=\"left\">
-                               <select tabindex='2' name=\"wpBlockExpiry\">
+                               <select tabindex='2' id='wpBlockExpiry' name=\"wpBlockExpiry\" onchange=\"considerChangingExpiryFocus()\">
                                        $blockExpiryFormOptions
                                </select>
                        </td>
+                       ");
+               }
+               $wgOut->addHTML("
                </tr>
-               <tr>
+               <tr id='wpBlockOther'>
                        <td align=\"right\">{$mIpbother}:</td>
                        <td align=\"left\">
                                <input tabindex='3' type='text' size='40' name=\"wpBlockOther\" value=\"{$scBlockOtherTime}\" />
@@ -129,9 +143,8 @@ class IPBlockForm {
        }
 
        function doSubmit() {
-               global $wgOut, $wgUser, $wgLang;
-               global $wgSysopUserBans, $wgSysopRangeBans;
-               
+               global $wgOut, $wgUser, $wgSysopUserBans, $wgSysopRangeBans;
+
                $userId = 0;
                $this->BlockAddress = trim( $this->BlockAddress );
                $rxIP = '\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}';
@@ -152,7 +165,7 @@ class IPBlockForm {
                                }
                        } else {
                                # Username block
-                               if ( $wgSysopUserBans ) {       
+                               if ( $wgSysopUserBans ) {
                                        $userId = User::idFromName( $this->BlockAddress );
                                        if ( $userId == 0 ) {
                                                $this->showForm( wfMsg( 'nosuchusershort', htmlspecialchars( $this->BlockAddress ) ) );
@@ -166,39 +179,44 @@ class IPBlockForm {
                }
 
                $expirestr = $this->BlockExpiry;
-               if (strlen($expirestr) == 0 || $expirestr == wfMsg('ipbotheroption'))
+               if( $expirestr == 'other' )
                        $expirestr = $this->BlockOther;
 
+               if (strlen($expirestr) == 0) {
+                       $this->showForm( wfMsg( 'ipb_expiry_invalid' ) );
+                       return;
+               }
+
                if ( $expirestr == 'infinite' || $expirestr == 'indefinite' ) {
                        $expiry = '';
                } else {
-                       # Convert GNU-style date, returns -1 on error
+                       # Convert GNU-style date, on error returns -1 for PHP <5.1 and false for PHP >=5.1
                        $expiry = strtotime( $expirestr );
 
-                       if ( $expiry < 0 ) {
+                       if ( $expiry < 0 || $expiry === false ) {
                                $this->showForm( wfMsg( 'ipb_expiry_invalid' ) );
                                return;
                        }
-                       
+
                        $expiry = wfTimestamp( TS_MW, $expiry );
 
                }
-               
+
                # Create block
                # Note: for a user block, ipb_address is only for display purposes
 
-               $ban = new Block( $this->BlockAddress, $userId, $wgUser->getID(), 
+               $ban = new Block( $this->BlockAddress, $userId, $wgUser->getID(),
                        $this->BlockReason, wfTimestampNow(), 0, $expiry );
-               
+
                if (wfRunHooks('BlockIp', array(&$ban, &$wgUser))) {
-                       
+
                        $ban->insert();
-                       
+
                        wfRunHooks('BlockIpComplete', array($ban, $wgUser));
-                       
+
                        # Make log entry
                        $log = new LogPage( 'block' );
-                       $log->addEntry( 'block', Title::makeTitle( NS_USER, $this->BlockAddress ), 
+                       $log->addEntry( 'block', Title::makeTitle( NS_USER, $this->BlockAddress ),
                          $this->BlockReason, $expirestr );
 
                        # Report to the user
@@ -209,7 +227,7 @@ class IPBlockForm {
        }
 
        function showSuccess() {
-               global $wgOut, $wgUser;
+               global $wgOut;
 
                $wgOut->setPagetitle( wfMsg( 'blockip' ) );
                $wgOut->setSubtitle( wfMsg( 'blockipsuccesssub' ) );