FU 97704: I was thinking the space was already added in this case
[lhc/web/wiklou.git] / includes / SkinTemplate.php
index 2c5edf9..ea6274d 100644 (file)
@@ -107,7 +107,7 @@ class SkinTemplate extends Skin {
         *
         * @param $out OutputPage
         */
-       function setupSkinUserCss( OutputPage $out ){
+       function setupSkinUserCss( OutputPage $out ) {
                $out->addModuleStyles( array( 'mediawiki.legacy.shared', 'mediawiki.legacy.commonPrint' ) );
        }
 
@@ -116,10 +116,10 @@ class SkinTemplate extends Skin {
         * and eventually it spits out some HTML. Should have interface
         * roughly equivalent to PHPTAL 0.7.
         *
-        * @param $classname string (or file)
+        * @param $classname String
         * @param $repository string: subdirectory where we keep template files
         * @param $cache_dir string
-        * @return object
+        * @return QuickTemplate
         * @private
         */
        function setupTemplate( $classname, $repository = false, $cache_dir = false ) {
@@ -131,50 +131,52 @@ class SkinTemplate extends Skin {
         *
         * @param $out OutputPage
         */
-       function outputPage( OutputPage $out ) {
-               global $wgUser, $wgLang, $wgContLang;
-               global $wgScript, $wgStylePath, $wgLanguageCode;
-               global $wgMimeType, $wgJsMimeType, $wgOutputEncoding, $wgRequest;
+       function outputPage( OutputPage $out=null ) {
+               global $wgContLang;
+               global $wgScript, $wgStylePath;
+               global $wgMimeType, $wgJsMimeType;
                global $wgXhtmlDefaultNamespace, $wgXhtmlNamespaces, $wgHtml5Version;
-               global $wgDisableCounters, $wgLogo, $wgHideInterlanguageLinks;
+               global $wgDisableCounters, $wgSitename, $wgLogo, $wgHideInterlanguageLinks;
                global $wgMaxCredits, $wgShowCreditsIfMax;
                global $wgPageShowWatchingUsers;
                global $wgUseTrackbacks, $wgUseSiteJs, $wgDebugComments;
-               global $wgArticlePath, $wgScriptPath, $wgServer, $wgProfiler;
+               global $wgArticlePath, $wgScriptPath, $wgServer;
 
                wfProfileIn( __METHOD__ );
-               if ( is_object( $wgProfiler ) ) {
-                       $wgProfiler->setTemplated( true );
+               Profiler::instance()->setTemplated( true );
+
+               $oldContext = null;
+               if ( $out !== null ) {
+                       // @todo Add wfDeprecated in 1.20
+                       $oldContext = $this->getContext();
+                       $this->setContext( $out->getContext() );
                }
 
-               $oldid = $wgRequest->getVal( 'oldid' );
-               $diff = $wgRequest->getVal( 'diff' );
-               $action = $wgRequest->getVal( 'action', 'view' );
+               $out = $this->getOutput();
+               $request = $this->getRequest();
+               $user = $this->getUser();
 
                wfProfileIn( __METHOD__ . '-init' );
                $this->initPage( $out );
 
-               $this->setMembers();
                $tpl = $this->setupTemplate( $this->template, 'skins' );
                wfProfileOut( __METHOD__ . '-init' );
 
                wfProfileIn( __METHOD__ . '-stuff' );
-               $this->thispage = $this->mTitle->getPrefixedDBkey();
-               $this->thisurl = $this->mTitle->getPrefixedURL();
+               $this->thispage = $this->getTitle()->getPrefixedDBkey();
+               $this->userpage = $user->getUserPage()->getPrefixedText();
                $query = array();
-               if ( !$wgRequest->wasPosted() ) {
-                       $query = $wgRequest->getValues();
+               if ( !$request->wasPosted() ) {
+                       $query = $request->getValues();
                        unset( $query['title'] );
                        unset( $query['returnto'] );
                        unset( $query['returntoquery'] );
                }
-               $this->thisquery = wfUrlencode( wfArrayToCGI( $query ) );
-               $this->loggedin = $wgUser->isLoggedIn();
-               $this->iscontent = ( $this->mTitle->getNamespace() != NS_SPECIAL );
-               $this->iseditable = ( $this->iscontent and !( $action == 'edit' or $action == 'submit' ) );
-               $this->username = $wgUser->getName();
+               $this->thisquery = wfArrayToCGI( $query );
+               $this->loggedin = $user->isLoggedIn();
+               $this->username = $user->getName();
 
-               if ( $wgUser->isLoggedIn() || $this->showIPinHeader() ) {
+               if ( $user->isLoggedIn() || $this->showIPinHeader() ) {
                        $this->userpageUrlDetails = self::makeUrlDetails( $this->userpage );
                } else {
                        # This won't be used in the standard skins, but we define it to preserve the interface
@@ -182,22 +184,16 @@ class SkinTemplate extends Skin {
                        $this->userpageUrlDetails = self::makeKnownUrlDetails( $this->userpage );
                }
 
-               $this->titletxt = $this->mTitle->getPrefixedText();
+               $this->titletxt = $this->getTitle()->getPrefixedText();
                wfProfileOut( __METHOD__ . '-stuff' );
 
                wfProfileIn( __METHOD__ . '-stuff-head' );
-               if ( $this->useHeadElement ) {
-                       $pagecss = $this->setupPageCss();
-                       if( $pagecss )
-                               $out->addInlineStyle( $pagecss );
-               } else {
-                       $this->setupUserCss( $out );
-
-                       $tpl->set( 'pagecss', $this->setupPageCss() );
-                       $tpl->setRef( 'usercss', $this->usercss );
+               if ( !$this->useHeadElement ) {
+                       $tpl->set( 'pagecss', false );
+                       $tpl->set( 'usercss', false );
 
                        $this->userjs = $this->userjsprev = false;
-                       # FIXME: this is the only use of OutputPage::isUserJsAllowed() anywhere; can we
+                       # @todo FIXME: This is the only use of OutputPage::isUserJsAllowed() anywhere; can we
                        # get rid of it?  For that matter, why is any of this here at all?
                        $this->setupUserJs( $out->isUserJsAllowed() );
                        $tpl->setRef( 'userjs', $this->userjs );
@@ -216,14 +212,17 @@ class SkinTemplate extends Skin {
                        $tpl->setRef( 'xhtmldefaultnamespace', $wgXhtmlDefaultNamespace );
                        $tpl->set( 'xhtmlnamespaces', $wgXhtmlNamespaces );
                        $tpl->set( 'html5version', $wgHtml5Version );
-                       $tpl->set( 'headlinks', $out->getHeadLinks( $this ) );
-                       $tpl->set( 'csslinks', $out->buildCssLinks( $this ) );
+                       $tpl->set( 'headlinks', $out->getHeadLinks() );
+                       $tpl->set( 'csslinks', $out->buildCssLinks() );
 
                        if( $wgUseTrackbacks && $out->isArticleRelated() ) {
                                $tpl->set( 'trackbackhtml', $out->getTitle()->trackbackRDF() );
                        } else {
                                $tpl->set( 'trackbackhtml', null );
                        }
+
+                       $tpl->set( 'pageclass', $this->getPageClasses( $this->getTitle() ) );
+                       $tpl->set( 'skinnameclass', ( 'skin-' . Sanitizer::escapeClass( $this->getSkinName() ) ) );
                }
                wfProfileOut( __METHOD__ . '-stuff-head' );
 
@@ -231,19 +230,10 @@ class SkinTemplate extends Skin {
                $tpl->set( 'title', $out->getPageTitle() );
                $tpl->set( 'pagetitle', $out->getHTMLTitle() );
                $tpl->set( 'displaytitle', $out->mPageLinkTitle );
-               $tpl->set( 'pageclass', $this->getPageClasses( $this->mTitle ) );
-               $tpl->set( 'skinnameclass', ( 'skin-' . Sanitizer::escapeClass( $this->getSkinName() ) ) );
-
-               $nsname = MWNamespace::exists( $this->mTitle->getNamespace() ) ?
-                                       MWNamespace::getCanonicalName( $this->mTitle->getNamespace() ) :
-                                       $this->mTitle->getNsText();
 
-               $tpl->set( 'nscanonical', $nsname );
-               $tpl->set( 'nsnumber', $this->mTitle->getNamespace() );
-               $tpl->set( 'titleprefixeddbkey', $this->mTitle->getPrefixedDBKey() );
-               $tpl->set( 'titletext', $this->mTitle->getText() );
-               $tpl->set( 'articleid', $this->mTitle->getArticleId() );
-               $tpl->set( 'currevisionid', $this->mTitle->getLatestRevID() );
+               $tpl->set( 'titleprefixeddbkey', $this->getTitle()->getPrefixedDBKey() );
+               $tpl->set( 'titletext', $this->getTitle()->getText() );
+               $tpl->set( 'articleid', $this->getTitle()->getArticleId() );
 
                $tpl->set( 'isarticle', $out->isArticle() );
 
@@ -277,131 +267,102 @@ class SkinTemplate extends Skin {
 
                $tpl->setRef( 'mimetype', $wgMimeType );
                $tpl->setRef( 'jsmimetype', $wgJsMimeType );
-               $tpl->setRef( 'charset', $wgOutputEncoding );
+               $tpl->set( 'charset', 'UTF-8' );
                $tpl->setRef( 'wgScript', $wgScript );
                $tpl->setRef( 'skinname', $this->skinname );
                $tpl->set( 'skinclass', get_class( $this ) );
                $tpl->setRef( 'stylename', $this->stylename );
                $tpl->set( 'printable', $out->isPrintable() );
-               $tpl->set( 'handheld', $wgRequest->getBool( 'handheld' ) );
+               $tpl->set( 'handheld', $request->getBool( 'handheld' ) );
                $tpl->setRef( 'loggedin', $this->loggedin );
-               $tpl->set( 'notspecialpage', $this->mTitle->getNamespace() != NS_SPECIAL );
+               $tpl->set( 'notspecialpage', $this->getTitle()->getNamespace() != NS_SPECIAL );
                /* XXX currently unused, might get useful later
-               $tpl->set( 'editable', ( $this->mTitle->getNamespace() != NS_SPECIAL ) );
-               $tpl->set( 'exists', $this->mTitle->getArticleID() != 0 );
-               $tpl->set( 'watch', $this->mTitle->userIsWatching() ? 'unwatch' : 'watch' );
-               $tpl->set( 'protect', count( $this->mTitle->isProtected() ) ? 'unprotect' : 'protect' );
+               $tpl->set( 'editable', ( $this->getTitle()->getNamespace() != NS_SPECIAL ) );
+               $tpl->set( 'exists', $this->getTitle()->getArticleID() != 0 );
+               $tpl->set( 'watch', $this->getTitle()->userIsWatching() ? 'unwatch' : 'watch' );
+               $tpl->set( 'protect', count( $this->getTitle()->isProtected() ) ? 'unprotect' : 'protect' );
                $tpl->set( 'helppage', wfMsg( 'helppage' ) );
                */
                $tpl->set( 'searchaction', $this->escapeSearchLink() );
                $tpl->set( 'searchtitle', SpecialPage::getTitleFor( 'Search' )->getPrefixedDBKey() );
-               $tpl->set( 'search', trim( $wgRequest->getVal( 'search' ) ) );
+               $tpl->set( 'search', trim( $request->getVal( 'search' ) ) );
                $tpl->setRef( 'stylepath', $wgStylePath );
                $tpl->setRef( 'articlepath', $wgArticlePath );
                $tpl->setRef( 'scriptpath', $wgScriptPath );
                $tpl->setRef( 'serverurl', $wgServer );
                $tpl->setRef( 'logopath', $wgLogo );
+               $tpl->setRef( 'sitename', $wgSitename );
 
-               $lang = wfUILang();
-               $tpl->set( 'lang', $lang->getCode() );
-               $tpl->set( 'dir', $lang->getDir() );
-               $tpl->set( 'rtl', $lang->isRTL() );
+               $contentlang = $wgContLang->getCode();
+               $contentdir  = $wgContLang->getDir();
+               $userlang = $this->getLang()->getCode();
+               $userdir  = $this->getLang()->getDir();
 
-               $tpl->set( 'capitalizeallnouns', $wgLang->capitalizeAllNouns() ? ' capitalize-all-nouns' : '' );
-               $tpl->set( 'showjumplinks', $wgUser->getOption( 'showjumplinks' ) );
-               $tpl->set( 'username', $wgUser->isAnon() ? null : $this->username );
+               $tpl->set( 'lang', $userlang );
+               $tpl->set( 'dir', $userdir );
+               $tpl->set( 'rtl', $this->getLang()->isRTL() );
+
+               $tpl->set( 'capitalizeallnouns', $this->getLang()->capitalizeAllNouns() ? ' capitalize-all-nouns' : '' );
+               $tpl->set( 'showjumplinks', $user->getOption( 'showjumplinks' ) );
+               $tpl->set( 'username', $user->isAnon() ? null : $this->username );
                $tpl->setRef( 'userpage', $this->userpage );
                $tpl->setRef( 'userpageurl', $this->userpageUrlDetails['href'] );
-               $tpl->set( 'userlang', $wgLang->getCode() );
+               $tpl->set( 'userlang', $userlang );
 
                // Users can have their language set differently than the
                // content of the wiki. For these users, tell the web browser
                // that interface elements are in a different language.
                $tpl->set( 'userlangattributes', '' );
-               $tpl->set( 'specialpageattributes', '' );
-
-               $lang = $wgLang->getCode();
-               $dir  = $wgLang->getDir();
-               if ( $lang !== $wgContLang->getCode() || $dir !== $wgContLang->getDir() ) {
-                       $attrs = " lang='$lang' dir='$dir'";
+               $tpl->set( 'specialpageattributes', '' ); # obsolete
 
+               if ( $userlang !== $contentlang || $userdir !== $contentdir ) {
+                       $attrs = " lang='$userlang' dir='$userdir'";
                        $tpl->set( 'userlangattributes', $attrs );
-
-                       // The content of SpecialPages should be presented in the
-                       // user's language. Content of regular pages should not be touched.
-                       if( $this->mTitle->isSpecialPage() ) {
-                               $tpl->set( 'specialpageattributes', $attrs );
-                       }
                }
 
-               $newtalks = $this->getNewtalks();
-
                wfProfileOut( __METHOD__ . '-stuff2' );
 
                wfProfileIn( __METHOD__ . '-stuff3' );
-               $tpl->setRef( 'newtalk', $newtalks );
+               $tpl->set( 'newtalk', $this->getNewtalks() );
                $tpl->setRef( 'skin', $this );
                $tpl->set( 'logo', $this->logoText() );
-               if ( $out->isArticle() && ( !isset( $oldid ) || isset( $diff ) ) &&
-                       $this->mTitle->exists() )
-               {
-                       $article = new Article( $this->mTitle, 0 );
-                       if ( !$wgDisableCounters ) {
-                               $viewcount = $wgLang->formatNum( $article->getCount() );
-                               if ( $viewcount ) {
-                                       $tpl->set( 'viewcount', wfMsgExt( 'viewcount', array( 'parseinline' ), $viewcount ) );
-                               } else {
-                                       $tpl->set( 'viewcount', false );
+
+               $tpl->set( 'copyright', false );
+               $tpl->set( 'viewcount', false );
+               $tpl->set( 'lastmod', false );
+               $tpl->set( 'credits', false );
+               $tpl->set( 'numberofwatchingusers', false );
+               if ( $out->isArticle() && $this->getTitle()->exists() ) {
+                       if ( $this->isRevisionCurrent() ) {
+                               $article = new Article( $this->getTitle(), 0 );
+                               if ( !$wgDisableCounters ) {
+                                       $viewcount = $this->getLang()->formatNum( $article->getCount() );
+                                       if ( $viewcount ) {
+                                               $tpl->set( 'viewcount', wfMsgExt( 'viewcount', array( 'parseinline' ), $viewcount ) );
+                                       }
                                }
-                       } else {
-                               $tpl->set( 'viewcount', false );
-                       }
 
-                       if( $wgPageShowWatchingUsers ) {
-                               $dbr = wfGetDB( DB_SLAVE );
-                               $res = $dbr->select( 'watchlist',
-                                       array( 'COUNT(*) AS n' ),
-                                       array( 'wl_title' => $dbr->strencode( $this->mTitle->getDBkey() ), 'wl_namespace' => $this->mTitle->getNamespace() ),
-                                       __METHOD__
-                               );
-                               $x = $dbr->fetchObject( $res );
-                               $numberofwatchingusers = $x->n;
-                               if( $numberofwatchingusers > 0 ) {
-                                       $tpl->set( 'numberofwatchingusers',
-                                               wfMsgExt( 'number_of_watching_users_pageview', array( 'parseinline' ),
-                                               $wgLang->formatNum( $numberofwatchingusers ) )
+                               if( $wgPageShowWatchingUsers ) {
+                                       $dbr = wfGetDB( DB_SLAVE );
+                                       $num = $dbr->selectField( 'watchlist', 'COUNT(*)',
+                                               array( 'wl_title' => $this->getTitle()->getDBkey(), 'wl_namespace' => $this->getTitle()->getNamespace() ),
+                                               __METHOD__
                                        );
-                               } else {
-                                       $tpl->set( 'numberofwatchingusers', false );
+                                       if( $num > 0 ) {
+                                               $tpl->set( 'numberofwatchingusers',
+                                                       wfMsgExt( 'number_of_watching_users_pageview', array( 'parseinline' ),
+                                                       $this->getLang()->formatNum( $num ) )
+                                               );
+                                       }
                                }
-                       } else {
-                               $tpl->set( 'numberofwatchingusers', false );
-                       }
-
-                       $tpl->set( 'copyright', $this->getCopyright() );
 
-                       $this->credits = false;
-
-                       if( $wgMaxCredits != 0 ){
-                               $this->credits = Credits::getCredits( $article, $wgMaxCredits, $wgShowCreditsIfMax );
-                       } else {
-                               $tpl->set( 'lastmod', $this->lastModified( $article ) );
+                               if ( $wgMaxCredits != 0 ) {
+                                       $tpl->set( 'credits', Action::factory( 'credits', $article )->getCredits( $wgMaxCredits, $wgShowCreditsIfMax ) );
+                               } else {
+                                       $tpl->set( 'lastmod', $this->lastModified( $article ) );
+                               }
                        }
-
-                       $tpl->setRef( 'credits', $this->credits );
-
-               } elseif ( isset( $oldid ) && !isset( $diff ) ) {
                        $tpl->set( 'copyright', $this->getCopyright() );
-                       $tpl->set( 'viewcount', false );
-                       $tpl->set( 'lastmod', false );
-                       $tpl->set( 'credits', false );
-                       $tpl->set( 'numberofwatchingusers', false );
-               } else {
-                       $tpl->set( 'copyright', false );
-                       $tpl->set( 'viewcount', false );
-                       $tpl->set( 'lastmod', false );
-                       $tpl->set( 'credits', false );
-                       $tpl->set( 'numberofwatchingusers', false );
                }
                wfProfileOut( __METHOD__ . '-stuff3' );
 
@@ -454,15 +415,21 @@ class SkinTemplate extends Skin {
 
                $tpl->set( 'reporttime', wfReportTime() );
                $tpl->set( 'sitenotice', $this->getSiteNotice() );
-               $tpl->set( 'bottomscripts', $this->bottomScripts( $out ) );
-
-               $printfooter = "<div class=\"printfooter\">\n" . $this->printSource() . "</div>\n";
-               global $wgBetterDirectionality;
-               if ( $wgBetterDirectionality ) {
-                       $realBodyAttribs = array( 'lang' => $wgLanguageCode, 'dir' => $wgContLang->getDir() );
+               $tpl->set( 'bottomscripts', $this->bottomScripts() );
+               $tpl->set( 'printfooter', $this->printSource() );
+
+               # Add a <div class="mw-content-ltr/rtl"> around the body text
+               # not for special pages or file pages AND only when viewing AND if the page exists
+               # (or is in MW namespace, because that has default content)
+               if( !in_array( $this->getTitle()->getNamespace(), array( NS_SPECIAL, NS_FILE ) ) &&
+                       in_array( $request->getVal( 'action', 'view' ), array( 'view', 'historysubmit' ) ) &&
+                       ( $this->getTitle()->exists() || $this->getTitle()->getNamespace() == NS_MEDIAWIKI ) ) {
+                       $pageLang = $this->getTitle()->getPageLanguage();
+                       $realBodyAttribs = array( 'lang' => $pageLang->getCode(), 'dir' => $pageLang->getDir(),
+                               'class' => 'mw-content-'.$pageLang->getDir() );
                        $out->mBodytext = Html::rawElement( 'div', $realBodyAttribs, $out->mBodytext );
                }
-               $out->mBodytext .= $printfooter . $this->generateDebugHTML();
+
                $tpl->setRef( 'bodytext', $out->mBodytext );
 
                # Language links
@@ -494,14 +461,14 @@ class SkinTemplate extends Skin {
 
                wfProfileIn( __METHOD__ . '-stuff5' );
                # Personal toolbar
-               $tpl->set( 'personal_urls', $this->buildPersonalUrls( $out ) );
-               $content_navigation = $this->buildContentNavigationUrls( $out );
+               $tpl->set( 'personal_urls', $this->buildPersonalUrls() );
+               $content_navigation = $this->buildContentNavigationUrls();
                $content_actions = $this->buildContentActionUrls( $content_navigation );
                $tpl->setRef( 'content_navigation', $content_navigation );
                $tpl->setRef( 'content_actions', $content_actions );
 
                $tpl->set( 'sidebar', $this->buildSidebar() );
-               $tpl->set( 'nav_urls', $this->buildNavUrls( $out ) );
+               $tpl->set( 'nav_urls', $this->buildNavUrls() );
 
                // Set the head scripts near the end, in case the above actions resulted in added scripts
                if ( $this->useHeadElement ) {
@@ -510,11 +477,22 @@ class SkinTemplate extends Skin {
                        $tpl->set( 'headscripts', $out->getScript() );
                }
 
+               $tpl->set( 'debughtml', $this->generateDebugHTML() );
+
                // original version by hansm
                if( !wfRunHooks( 'SkinTemplateOutputPageBeforeExec', array( &$this, &$tpl ) ) ) {
                        wfDebug( __METHOD__ . ": Hook SkinTemplateOutputPageBeforeExec broke outputPage execution!\n" );
                }
 
+               // Set the bodytext to another key so that skins can just output it on it's own
+               // and output printfooter and debughtml separately
+               $tpl->set( 'bodycontent', $tpl->data['bodytext'] );
+
+               // Append printfooter and debughtml onto bodytext so that skins that were already
+               // using bodytext before they were split out don't suddenly start not outputting information
+               $tpl->data['bodytext'] .= Html::rawElement( 'div', array( 'class' => 'printfooter' ), "\n{$tpl->data['printfooter']}" ) . "\n";
+               $tpl->data['bodytext'] .= $tpl->data['debughtml'];
+
                // allow extensions adding stuff after the page content.
                // See Skin::afterContentHook() for further documentation.
                $tpl->set( 'dataAfterContent', $this->afterContentHook() );
@@ -527,6 +505,10 @@ class SkinTemplate extends Skin {
 
                // result may be an error
                $this->printOrError( $res );
+
+               if ( $oldContext ) {
+                       $this->setContext( $oldContext );
+               }
                wfProfileOut( __METHOD__ );
        }
 
@@ -559,21 +541,22 @@ class SkinTemplate extends Skin {
         * build array of urls for personal toolbar
         * @return array
         */
-       protected function buildPersonalUrls( OutputPage $out ) {
-               global $wgRequest;
-
-               $title = $out->getTitle();
+       protected function buildPersonalUrls() {
+               $title = $this->getTitle();
+               $request = $this->getRequest();
                $pageurl = $title->getLocalURL();
                wfProfileIn( __METHOD__ );
 
                /* set up the default links for the personal toolbar */
                $personal_urls = array();
-               $page = $wgRequest->getVal( 'returnto', $this->thisurl );
-               $query = $wgRequest->getVal( 'returntoquery', $this->thisquery );
-               $returnto = wfArrayToCGI( array( 'returnto' => $page ) );
-               if( $this->thisquery != '' ) {
-                       $returnto .= "&returntoquery=$query";
+
+               $page = $request->getVal( 'returnto', $this->thispage );
+               $query = $request->getVal( 'returntoquery', $this->thisquery );
+               $a = array( 'returnto' => $page );
+               if( $query != '' ) {
+                       $a['returntoquery'] = $query;
                }
+               $returnto = wfArrayToCGI( $a );
                if( $this->loggedin ) {
                        $personal_urls['userpage'] = array(
                                'text' => $this->username,
@@ -606,13 +589,12 @@ class SkinTemplate extends Skin {
                        # from request values or be specified in "sub page" form. The plot
                        # thickens, because $wgTitle is altered for special pages, so doesn't
                        # contain the original alias-with-subpage.
-                       $origTitle = Title::newFromText( $wgRequest->getText( 'title' ) );
+                       $origTitle = Title::newFromText( $request->getText( 'title' ) );
                        if( $origTitle instanceof Title && $origTitle->getNamespace() == NS_SPECIAL ) {
-                               list( $spName, $spPar ) =
-                                       SpecialPage::resolveAliasWithSubpage( $origTitle->getText() );
+                               list( $spName, $spPar ) = SpecialPageFactory::resolveAlias( $origTitle->getText() );
                                $active = $spName == 'Contributions'
                                        && ( ( $spPar && $spPar == $this->username )
-                                               || $wgRequest->getText( 'target' ) == $this->username );
+                                               || $request->getText( 'target' ) == $this->username );
                        } else {
                                $active = false;
                        }
@@ -626,17 +608,18 @@ class SkinTemplate extends Skin {
                        $personal_urls['logout'] = array(
                                'text' => wfMsg( 'userlogout' ),
                                'href' => self::makeSpecialUrl( 'Userlogout',
-                                       $title->isSpecial( 'Preferences' ) ? '' : $returnto
+                                       // userlogout link must always contain an & character, otherwise we might not be able
+                                       // to detect a buggy precaching proxy (bug 17790)
+                                       $title->isSpecial( 'Preferences' ) ? 'noreturnto' : $returnto
                                ),
                                'active' => false
                        );
                } else {
-                       global $wgUser;
                        $useCombinedLoginLink = $this->useCombinedLoginLink();
-                       $loginlink = $wgUser->isAllowed( 'createaccount' ) && $useCombinedLoginLink
+                       $loginlink = $this->getUser()->isAllowed( 'createaccount' ) && $useCombinedLoginLink
                                ? 'nav-login-createaccount'
                                : 'login';
-                       $is_signup = $wgRequest->getText('type') == "signup";
+                       $is_signup = $request->getText('type') == "signup";
 
                        # anonlogin & login are the same
                        $login_url = array(
@@ -644,26 +627,29 @@ class SkinTemplate extends Skin {
                                'href' => self::makeSpecialUrl( 'Userlogin', $returnto ),
                                'active' => $title->isSpecial( 'Userlogin' ) && ( $loginlink == "nav-login-createaccount" || !$is_signup )
                        );
-                       if ( $wgUser->isAllowed( 'createaccount' ) && !$useCombinedLoginLink ) {
+                       if ( $this->getUser()->isAllowed( 'createaccount' ) && !$useCombinedLoginLink ) {
                                $createaccount_url = array(
                                        'text' => wfMsg( 'createaccount' ),
                                        'href' => self::makeSpecialUrl( 'Userlogin', "$returnto&type=signup" ),
                                        'active' => $title->isSpecial( 'Userlogin' ) && $is_signup
                                );
                        }
-                       global $wgProto, $wgSecureLogin;
-                       if( $wgProto === 'http' && $wgSecureLogin ) {
+                       global $wgServer, $wgSecureLogin;
+                       if( substr( $wgServer, 0, 5 ) === 'http:' && $wgSecureLogin ) {
                                $title = SpecialPage::getTitleFor( 'Userlogin' );
                                $https_url = preg_replace( '/^http:/', 'https:', $title->getFullURL() );
                                $login_url['href']  = $https_url;
-                               $login_url['class'] = 'link-https';  # FIXME class depends on skin
+                               # @todo FIXME: Class depends on skin
+                               $login_url['class'] = 'link-https';
                                if ( isset($createaccount_url) ) {
-                                       $https_url = preg_replace( '/^http:/', 'https:', $title->getFullURL("type=signup") );
+                                       $https_url = preg_replace( '/^http:/', 'https:',
+                                               $title->getFullURL("type=signup") );
                                        $createaccount_url['href']  = $https_url;
-                                       $createaccount_url['class'] = 'link-https';  # FIXME class depends on skin
+                                       # @todo FIXME: Class depends on skin
+                                       $createaccount_url['class'] = 'link-https';
                                }
                        }
-                       
+
 
                        if( $this->showIPinHeader() ) {
                                $href = &$this->userpageUrlDetails['href'];
@@ -682,12 +668,12 @@ class SkinTemplate extends Skin {
                                        'active' => ( $pageurl == $href )
                                );
                                $personal_urls['anonlogin'] = $login_url;
-                               if ( isset($createaccount_url) ) {
-                                       $personal_urls['createaccount'] = $createaccount_url;
-                               }
                        } else {
                                $personal_urls['login'] = $login_url;
                        }
+                       if ( isset($createaccount_url) ) {
+                               $personal_urls['createaccount'] = $createaccount_url;
+                       }
                }
 
                wfRunHooks( 'PersonalUrls', array( &$personal_urls, &$title ) );
@@ -695,6 +681,15 @@ class SkinTemplate extends Skin {
                return $personal_urls;
        }
 
+       /**
+        * TODO document
+        * @param  $title Title
+        * @param  $message String message key
+        * @param  $selected Bool
+        * @param  $query String
+        * @param  $checkEdit Bool
+        * @return array
+        */
        function tabAction( $title, $message, $selected, $query = '', $checkEdit = false ) {
                $classes = array();
                if( $selected ) {
@@ -716,7 +711,8 @@ class SkinTemplate extends Skin {
                        $text = $msg->text();
                } else {
                        global $wgContLang;
-                       $text = $wgContLang->getFormattedNsText( MWNamespace::getSubject( $title->getNamespace() ) );
+                       $text = $wgContLang->getFormattedNsText(
+                               MWNamespace::getSubject( $title->getNamespace() ) );
                }
 
                $result = array();
@@ -758,13 +754,13 @@ class SkinTemplate extends Skin {
 
        /**
         * a structured array of links usually used for the tabs in a skin
-        * 
+        *
         * There are 4 standard sections
         * namespaces: Used for namespace tabs like special, page, and talk namespaces
         * views: Used for primary page views like read, edit, history
         * actions: Used for most extra page actions like deletion, protection, etc...
         * variants: Used to list the language variants for the page
-        * 
+        *
         * Each section's value is a key/value array of links for that section.
         * The links themseves have these common keys:
         * - class: The css classes to apply to the tab
@@ -774,11 +770,11 @@ class SkinTemplate extends Skin {
         * - redundant: If true the tab will be dropped in skins using content_actions
         *   this is useful for tabs like "Read" which only have meaning in skins that
         *   take special meaning from the grouped structure of content_navigation
-        * 
+        *
         * Views also have an extra key which can be used:
         * - primary: If this is not true skins like vector may try to hide the tab
         *            when the user has limited space in their browser window
-        * 
+        *
         * content_navigation using code also expects these ids to be present on the
         * links, however these are usually automatically generated by SkinTemplate
         * itself and are not necessary when using a hook. The only things these may
@@ -786,18 +782,22 @@ class SkinTemplate extends Skin {
         * - id: A "preferred" id, most skins are best off outputting this preferred id for best compatibility
         * - tooltiponly: This is set to true for some tabs in cases where the system
         *                believes that the accesskey should not be added to the tab.
-        * 
+        *
         * @return array
         */
-       protected function buildContentNavigationUrls( OutputPage $out ) {
-               global $wgContLang, $wgLang, $wgUser, $wgRequest;
+       protected function buildContentNavigationUrls() {
+               global $wgContLang;
                global $wgDisableLangConversion;
 
                wfProfileIn( __METHOD__ );
-               
+
                $title = $this->getRelevantTitle(); // Display tabs for the relevant title rather than always the title itself
-               $onPage = $title->equals($this->mTitle);
-               
+               $onPage = $title->equals($this->getTitle());
+
+               $out = $this->getOutput();
+               $request = $this->getRequest();
+               $user = $this->getUser();
+
                $content_navigation = array(
                        'namespaces' => array(),
                        'views' => array(),
@@ -806,8 +806,8 @@ class SkinTemplate extends Skin {
                );
 
                // parameters
-               $action = $wgRequest->getVal( 'action', 'view' );
-               $section = $wgRequest->getVal( 'section' );
+               $action = $request->getVal( 'action', 'view' );
+               $section = $request->getVal( 'section' );
 
                $userCanRead = $title->userCanRead();
                $skname = $this->skinname;
@@ -879,7 +879,7 @@ class SkinTemplate extends Skin {
                                        ( $action == 'edit' || $action == 'submit' ) &&
                                        ( $section != 'new' )
                                );
-                               $msgKey = $title->exists() || ( $title->getNamespace() == NS_MEDIAWIKI && !wfEmptyMsg( $title->getText() ) ) ?
+                               $msgKey = $title->exists() || ( $title->getNamespace() == NS_MEDIAWIKI && $title->getDefaultMessageText() !== false ) ?
                                        "edit" : "create";
                                $content_navigation['views']['edit'] = array(
                                        'class' => ( $selected ? 'selected' : '' ) . $isTalkClass,
@@ -925,7 +925,7 @@ class SkinTemplate extends Skin {
                                        'rel' => 'archives',
                                );
 
-                               if( $wgUser->isAllowed( 'delete' ) ) {
+                               if( $user->isAllowed( 'delete' ) ) {
                                        $content_navigation['actions']['delete'] = array(
                                                'class' => ( $onPage && $action == 'delete' ) ? 'selected' : false,
                                                'text' => wfMessageFallback( "$skname-action-delete", 'delete' )->text(),
@@ -935,13 +935,13 @@ class SkinTemplate extends Skin {
                                if ( $title->quickUserCan( 'move' ) ) {
                                        $moveTitle = SpecialPage::getTitleFor( 'Movepage', $title->getPrefixedDBkey() );
                                        $content_navigation['actions']['move'] = array(
-                                               'class' => $this->mTitle->isSpecial( 'Movepage' ) ? 'selected' : false,
+                                               'class' => $this->getTitle()->isSpecial( 'Movepage' ) ? 'selected' : false,
                                                'text' => wfMessageFallback( "$skname-action-move", 'move' )->text(),
                                                'href' => $moveTitle->getLocalURL()
                                        );
                                }
 
-                               if ( $title->getNamespace() !== NS_MEDIAWIKI && $wgUser->isAllowed( 'protect' ) ) {
+                               if ( $title->getNamespace() !== NS_MEDIAWIKI && $user->isAllowed( 'protect' ) ) {
                                        $mode = !$title->isProtected() ? 'protect' : 'unprotect';
                                        $content_navigation['actions'][$mode] = array(
                                                'class' => ( $onPage && $action == $mode ) ? 'selected' : false,
@@ -951,22 +951,22 @@ class SkinTemplate extends Skin {
                                }
                        } else {
                                // article doesn't exist or is deleted
-                               if ( $wgUser->isAllowed( 'deletedhistory' ) ) {
+                               if ( $user->isAllowed( 'deletedhistory' ) ) {
                                        $n = $title->isDeleted();
                                        if( $n ) {
                                                $undelTitle = SpecialPage::getTitleFor( 'Undelete' );
                                                // If the user can't undelete but can view deleted history show them a "View .. deleted" tab instead
-                                               $msgKey = $wgUser->isAllowed( 'undelete' ) ? 'undelete' : 'viewdeleted';
+                                               $msgKey = $user->isAllowed( 'undelete' ) ? 'undelete' : 'viewdeleted';
                                                $content_navigation['actions']['undelete'] = array(
-                                                       'class' => $this->mTitle->isSpecial( 'Undelete' ) ? 'selected' : false,
+                                                       'class' => $this->getTitle()->isSpecial( 'Undelete' ) ? 'selected' : false,
                                                        'text' => wfMessageFallback( "$skname-action-$msgKey", "{$msgKey}_short" )
-                                                               ->params( $wgLang->formatNum( $n ) )->text(),
+                                                               ->params( $this->getLang()->formatNum( $n ) )->text(),
                                                        'href' => $undelTitle->getLocalURL( array( 'target' => $title->getPrefixedDBkey() ) )
                                                );
                                        }
                                }
 
-                               if ( $title->getNamespace() !== NS_MEDIAWIKI && $wgUser->isAllowed( 'protect' ) ) {
+                               if ( $title->getNamespace() !== NS_MEDIAWIKI && $user->isAllowed( 'protect' ) ) {
                                        $mode = !$title->getRestrictions( 'create' ) ? 'protect' : 'unprotect';
                                        $content_navigation['actions'][$mode] = array(
                                                'class' => ( $onPage && $action == $mode ) ? 'selected' : false,
@@ -989,24 +989,26 @@ class SkinTemplate extends Skin {
                                 * the global versions.
                                 */
                                $mode = $title->userIsWatching() ? 'unwatch' : 'watch';
+                               $token = WatchAction::getWatchToken( $title, $user, $mode );
                                $content_navigation['actions'][$mode] = array(
                                        'class' => $onPage && ( $action == 'watch' || $action == 'unwatch' ) ? 'selected' : false,
                                        'text' => wfMsg( $mode ), // uses 'watch' or 'unwatch' message
-                                       'href' => $title->getLocalURL( 'action=' . $mode )
+                                       'href' => $title->getLocalURL( array( 'action' => $mode, 'token' => $token ) )
                                );
                        }
-                       
+
                        wfRunHooks( 'SkinTemplateNavigation', array( &$this, &$content_navigation ) );
                } else {
                        // If it's not content, it's got to be a special page
                        $content_navigation['namespaces']['special'] = array(
                                'class' => 'selected',
                                'text' => wfMsg( 'nstab-special' ),
-                               'href' => $wgRequest->getRequestURL(), // @bug 2457, 2510
+                               'href' => $request->getRequestURL(), // @bug 2457, 2510
                                'context' => 'subject'
                        );
-                       
-                       wfRunHooks( 'SkinTemplateNavigation::SpecialPage', array( &$this, &$content_navigation ) );
+
+                       wfRunHooks( 'SkinTemplateNavigation::SpecialPage',
+                               array( &$this, &$content_navigation ) );
                }
 
                // Gets list of language variants
@@ -1052,7 +1054,7 @@ class SkinTemplate extends Skin {
                                $link['id'] = $xmlID;
                        }
                }
-               
+
                # We don't want to give the watch tab an accesskey if the
                # page is being edited, because that conflicts with the
                # accesskey on the watch checkbox.  We also don't want to
@@ -1070,7 +1072,7 @@ class SkinTemplate extends Skin {
                                $content_navigation['actions']['unwatch']['tooltiponly'] = true;
                        }
                }
-               
+
                wfProfileOut( __METHOD__ );
 
                return $content_navigation;
@@ -1088,18 +1090,18 @@ class SkinTemplate extends Skin {
                // content_actions has been replaced with content_navigation for backwards
                // compatibility and also for skins that just want simple tabs content_actions
                // is now built by flattening the content_navigation arrays into one
-               
+
                $content_actions = array();
-               
-               foreach ( $content_navigation as $section => $links ) {
-                       
+
+               foreach ( $content_navigation as $links ) {
+
                        foreach ( $links as $key => $value ) {
-                               
+
                                if ( isset($value["redundant"]) && $value["redundant"] ) {
                                        // Redundant tabs are dropped from content_actions
                                        continue;
                                }
-                               
+
                                // content_actions used to have ids built using the "ca-$key" pattern
                                // so the xmlID based id is much closer to the actual $key that we want
                                // for that reason we'll just strip out the ca- if present and use
@@ -1107,20 +1109,20 @@ class SkinTemplate extends Skin {
                                if ( isset($value["id"]) && substr($value["id"], 0, 3) == "ca-" ) {
                                        $key = substr($value["id"], 3);
                                }
-                               
+
                                if ( isset($content_actions[$key]) ) {
                                        wfDebug( __METHOD__ . ": Found a duplicate key for $key while flattening content_navigation into content_actions." );
                                        continue;
                                }
-                               
+
                                $content_actions[$key] = $value;
-                               
+
                        }
-                       
+
                }
-               
+
                wfProfileOut( __METHOD__ );
-               
+
                return $content_actions;
        }
 
@@ -1129,19 +1131,20 @@ class SkinTemplate extends Skin {
         * @return array
         * @private
         */
-       protected function buildNavUrls( OutputPage $out ) {
-               global $wgUseTrackbacks, $wgUser, $wgRequest;
+       protected function buildNavUrls() {
+               global $wgUseTrackbacks;
                global $wgUploadNavigationUrl;
 
                wfProfileIn( __METHOD__ );
 
-               $action = $wgRequest->getVal( 'action', 'view' );
+               $out = $this->getOutput();
+               $request = $this->getRequest();
 
                $nav_urls = array();
                $nav_urls['mainpage'] = array( 'href' => self::makeMainPageUrl() );
                if( $wgUploadNavigationUrl ) {
                        $nav_urls['upload'] = array( 'href' => $wgUploadNavigationUrl );
-               } elseif( UploadBase::isEnabled() && UploadBase::isAllowed( $wgUser ) === true ) {
+               } elseif( UploadBase::isEnabled() && UploadBase::isAllowed( $this->getUser() ) === true ) {
                        $nav_urls['upload'] = array( 'href' => self::makeSpecialUrl( 'Upload' ) );
                } else {
                        $nav_urls['upload'] = false;
@@ -1153,33 +1156,35 @@ class SkinTemplate extends Skin {
 
                // A print stylesheet is attached to all pages, but nobody ever
                // figures that out. :)  Add a link...
-               if( $this->iscontent && ( $action == 'view' || $action == 'purge' ) ) {
+               if( $out->isArticle() ) {
                        if ( !$out->isPrintable() ) {
                                $nav_urls['print'] = array(
                                        'text' => wfMsg( 'printableversion' ),
-                                       'href' => $wgRequest->appendQuery( 'printable=yes' )
+                                       'href' => $this->getTitle()->getLocalURL(
+                                               $request->appendQueryValue( 'printable', 'yes', true ) )
                                );
                        }
 
                        // Also add a "permalink" while we're at it
-                       if ( $this->mRevisionId ) {
+                       $revid = $this->getRevisionId();
+                       if ( $revid ) {
                                $nav_urls['permalink'] = array(
                                        'text' => wfMsg( 'permalink' ),
-                                       'href' => $out->getTitle()->getLocalURL( "oldid=$this->mRevisionId" )
+                                       'href' => $out->getTitle()->getLocalURL( "oldid=$revid" )
                                );
                        }
 
-                       // Copy in case this undocumented, shady hook tries to mess with internals
-                       $revid = $this->mRevisionId;
-                       wfRunHooks( 'SkinTemplateBuildNavUrlsNav_urlsAfterPermalink', array( &$this, &$nav_urls, &$revid, &$revid ) );
+                       // Use the copy of revision ID in case this undocumented, shady hook tries to mess with internals
+                       wfRunHooks( 'SkinTemplateBuildNavUrlsNav_urlsAfterPermalink',
+                               array( &$this, &$nav_urls, &$revid, &$revid ) );
                }
 
-               if( $this->mTitle->getNamespace() != NS_SPECIAL ) {
+               if( $this->getTitle()->getNamespace() != NS_SPECIAL ) {
                        $wlhTitle = SpecialPage::getTitleFor( 'Whatlinkshere', $this->thispage );
                        $nav_urls['whatlinkshere'] = array(
                                'href' => $wlhTitle->getLocalUrl()
                        );
-                       if( $this->mTitle->getArticleId() ) {
+                       if( $this->getTitle()->getArticleId() ) {
                                $rclTitle = SpecialPage::getTitleFor( 'Recentchangeslinked', $this->thispage );
                                $nav_urls['recentchangeslinked'] = array(
                                        'href' => $rclTitle->getLocalUrl()
@@ -1193,13 +1198,15 @@ class SkinTemplate extends Skin {
                                );
                }
 
-               if ( $user = $this->getRelevantUser() ) {
+               $user = $this->getRelevantUser();
+               if ( $user ) {
                        $id = $user->getID();
                        $ip = $user->isAnon();
                        $rootUser = $user->getName();
                } else {
                        $id = 0;
                        $ip = false;
+                       $rootUser = null;
                }
 
                if( $id || $ip ) { # both anons and non-anons have contribs list
@@ -1220,9 +1227,9 @@ class SkinTemplate extends Skin {
                                $nav_urls['log'] = false;
                        }
 
-                       if ( $wgUser->isAllowed( 'block' ) ) {
+                       if ( $this->getUser()->isAllowed( 'block' ) ) {
                                $nav_urls['blockip'] = array(
-                                       'href' => self::makeSpecialUrlSubpage( 'Blockip', $rootUser )
+                                       'href' => self::makeSpecialUrlSubpage( 'Block', $rootUser )
                                );
                        } else {
                                $nav_urls['blockip'] = false;
@@ -1248,23 +1255,21 @@ class SkinTemplate extends Skin {
         * @private
         */
        function getNameSpaceKey() {
-               return $this->mTitle->getNamespaceKey();
+               return $this->getTitle()->getNamespaceKey();
        }
 
        /**
         * @private
-        * FIXME: why is this duplicated in/from OutputPage::getHeadScripts()??
+        * @todo FIXME: Why is this duplicated in/from OutputPage::getHeadScripts()??
         */
        function setupUserJs( $allowUserJs ) {
-               global $wgRequest, $wgJsMimeType;
+               global $wgJsMimeType;
                wfProfileIn( __METHOD__ );
 
-               $action = $wgRequest->getVal( 'action', 'view' );
-
                if( $allowUserJs && $this->loggedin ) {
-                       if( $this->mTitle->isJsSubpage() and $this->userCanPreview( $action ) ) {
+                       if( $this->getTitle()->isJsSubpage() and $this->getOutput()->userCanPreview() ) {
                                # XXX: additional security check/prompt?
-                               $this->userjsprev = '/*<![CDATA[*/ ' . $wgRequest->getText( 'wpTextbox1' ) . ' /*]]>*/';
+                               $this->userjsprev = '/*<![CDATA[*/ ' . $this->getRequest()->getText( 'wpTextbox1' ) . ' /*]]>*/';
                        } else {
                                $this->userjs = self::makeUrl( $this->userpage . '/' . $this->skinname . '.js', 'action=raw&ctype=' . $wgJsMimeType );
                        }
@@ -1272,20 +1277,6 @@ class SkinTemplate extends Skin {
                wfProfileOut( __METHOD__ );
        }
 
-       /**
-        * Code for extensions to hook into to provide per-page CSS, see
-        * extensions/PageCSS/PageCSS.php for an implementation of this.
-        *
-        * @private
-        */
-       function setupPageCss() {
-               wfProfileIn( __METHOD__ );
-               $out = false;
-               wfRunHooks( 'SkinTemplateSetupPageCss', array( &$out ) );
-               wfProfileOut( __METHOD__ );
-               return $out;
-       }
-
        public function commonPrintStylesheet() {
                return false;
        }
@@ -1375,12 +1366,10 @@ abstract class QuickTemplate {
         * @private
         */
        function msgWiki( $str ) {
-               global $wgParser, $wgOut;
+               global $wgOut;
 
                $text = $this->translator->translate( $str );
-               $parserOutput = $wgParser->parse( $text, $wgOut->getTitle(),
-                       $wgOut->parserOptions(), true );
-               echo $parserOutput->getText();
+               echo $wgOut->parse( $text );
        }
 
        /**
@@ -1392,6 +1381,8 @@ abstract class QuickTemplate {
 
        /**
         * @private
+        *
+        * @return bool
         */
        function haveMsg( $str ) {
                $msg = $this->translator->translate( $str );
@@ -1460,15 +1451,16 @@ abstract class BaseTemplate extends QuickTemplate {
                        $toolbox['print']['rel'] = 'alternate';
                        $toolbox['print']['msg'] = 'printableversion';
                }
-               if ( !empty( $this->data['nav_urls']['permalink']['href'] ) ) {
-                       $toolbox['permalink'] = $this->data['nav_urls']['permalink'];
-                       $toolbox['permalink']['id'] = 't-permalink';
-               } elseif ( $this->data['nav_urls']['permalink']['href'] === '' ) {
+               if( $this->data['nav_urls']['permalink'] ) {
                        $toolbox['permalink'] = $this->data['nav_urls']['permalink'];
-                       unset( $toolbox['permalink']['href'] );
-                       $toolbox['ispermalink']['tooltiponly'] = true;
-                       $toolbox['ispermalink']['id'] = 't-ispermalink';
-                       $toolbox['ispermalink']['msg'] = 'permalink';
+                       if( $toolbox['permalink']['href'] === '' ) {
+                               unset( $toolbox['permalink']['href'] );
+                               $toolbox['ispermalink']['tooltiponly'] = true;
+                               $toolbox['ispermalink']['id'] = 't-ispermalink';
+                               $toolbox['ispermalink']['msg'] = 'permalink';
+                       } else {
+                               $toolbox['permalink']['id'] = 't-permalink';
+                       }
                }
                wfRunHooks( 'BaseTemplateToolbox', array( &$this, &$toolbox ) );
                wfProfileOut( __METHOD__ );
@@ -1531,7 +1523,7 @@ abstract class BaseTemplate extends QuickTemplate {
                }
 
                $attrs = array();
-               foreach ( array( 'href', 'id', 'class', 'rel', 'type' ) as $attr ) {
+               foreach ( array( 'href', 'id', 'class', 'rel', 'type', 'target') as $attr ) {
                        if ( isset( $item[$attr] ) ) {
                                $attrs[$attr] = $item[$attr];
                        }
@@ -1542,14 +1534,14 @@ abstract class BaseTemplate extends QuickTemplate {
                }
                if ( isset( $item['single-id'] ) ) {
                        if ( isset( $item['tooltiponly'] ) && $item['tooltiponly'] ) {
-                               $attrs['title'] = $this->skin->titleAttrib( $item['single-id'] );
+                               $attrs['title'] = Linker::titleAttrib( $item['single-id'] );
                                if ( $attrs['title'] === false ) {
                                        unset( $attrs['title'] );
                                }
                        } else {
                                $attrs = array_merge(
                                        $attrs,
-                                       $this->skin->tooltipAndAccesskeyAttribs( $item['single-id'] )
+                                       Linker::tooltipAndAccesskeyAttribs( $item['single-id'] )
                                );
                        }
                }
@@ -1584,7 +1576,7 @@ abstract class BaseTemplate extends QuickTemplate {
                        }
                } else {
                        $link = array();
-                       foreach ( array( 'text', 'msg', 'href', 'rel', 'type', 'tooltiponly' ) as $k ) {
+                       foreach ( array( 'text', 'msg', 'href', 'rel', 'type', 'tooltiponly', 'target' ) as $k ) {
                                if ( isset( $item[$k] ) ) {
                                        $link[$k] = $item[$k];
                                }
@@ -1620,7 +1612,7 @@ abstract class BaseTemplate extends QuickTemplate {
                        'name' => 'search',
                        'value' => isset( $this->data['search'] ) ? $this->data['search'] : '',
                );
-               $realAttrs = array_merge( $realAttrs, $this->skin->tooltipAndAccesskeyAttribs( 'search' ), $attrs );
+               $realAttrs = array_merge( $realAttrs, Linker::tooltipAndAccesskeyAttribs( 'search' ), $attrs );
                return Html::element( 'input', $realAttrs );
        }
 
@@ -1631,11 +1623,12 @@ abstract class BaseTemplate extends QuickTemplate {
                                $realAttrs = array(
                                        'type' => 'submit',
                                        'name' => $mode,
-                                       'value' => $this->translator->translate( $mode == 'go' ? 'searcharticle' : 'searchbutton' ),
+                                       'value' => $this->translator->translate(
+                                               $mode == 'go' ? 'searcharticle' : 'searchbutton' ),
                                );
                                $realAttrs = array_merge(
                                        $realAttrs,
-                                       $this->skin->tooltipAndAccesskeyAttribs( "search-$mode" ),
+                                       Linker::tooltipAndAccesskeyAttribs( "search-$mode" ),
                                        $attrs
                                );
                                return Html::element( 'input', $realAttrs );
@@ -1646,14 +1639,16 @@ abstract class BaseTemplate extends QuickTemplate {
                                );
                                $buttonAttrs = array_merge(
                                        $buttonAttrs,
-                                       $this->skin->tooltipAndAccesskeyAttribs( 'search-fulltext' ),
+                                       Linker::tooltipAndAccesskeyAttribs( 'search-fulltext' ),
                                        $attrs
                                );
                                unset( $buttonAttrs['src'] );
                                unset( $buttonAttrs['alt'] );
                                $imgAttrs = array(
                                        'src' => $attrs['src'],
-                                       'alt' => isset( $attrs['alt'] ) ? $attrs['alt'] : $this->translator->translate( 'searchbutton' ),
+                                       'alt' => isset( $attrs['alt'] )
+                                               ? $attrs['alt']
+                                               : $this->translator->translate( 'searchbutton' ),
                                );
                                return Html::rawElement( 'button', $buttonAttrs, Html::element( 'img', $imgAttrs ) );
                        default:
@@ -1712,7 +1707,7 @@ abstract class BaseTemplate extends QuickTemplate {
 
                if ( $option == 'icononly' ) {
                        // Unset any icons which don't have an image
-                       foreach ( $footericons as $footerIconsKey => &$footerIconsBlock ) {
+                       foreach ( $footericons as &$footerIconsBlock ) {
                                foreach ( $footerIconsBlock as $footerIconKey => $footerIcon ) {
                                        if ( !is_string( $footerIcon ) && !isset( $footerIcon['src'] ) ) {
                                                unset( $footerIconsBlock[$footerIconKey] );