Fixing bug 30973. Strip off subpages when determining the username who the current...
[lhc/web/wiklou.git] / includes / Skin.php
index 4b06e1d..76a913b 100644 (file)
@@ -15,7 +15,7 @@ if ( !defined( 'MEDIAWIKI' ) ) {
  *
  * @ingroup Skins
  */
-abstract class Skin {
+abstract class Skin extends ContextSource {
        protected $skinname = 'standard';
        protected $mRelevantTitle = null;
        protected $mRelevantUser = null;
@@ -156,15 +156,10 @@ abstract class Skin {
                                }
                        }
                }
-               $skin = new $className;
+               $skin = new $className( $key );
                return $skin;
        }
 
-       /** @return string path to the skin stylesheet */
-       function getStylesheet() {
-               return 'common/wikistandard.css';
-       }
-
        /** @return string skin name */
        public function getSkinName() {
                return $this->skinname;
@@ -174,7 +169,6 @@ abstract class Skin {
                wfProfileIn( __METHOD__ );
 
                $this->preloadExistence();
-               $this->setMembers();
 
                wfProfileOut( __METHOD__ );
        }
@@ -183,7 +177,7 @@ abstract class Skin {
         * Preload the existence of three commonly-requested pages in a single query
         */
        function preloadExistence() {
-               $user = $this->getContext()->getUser();
+               $user = $this->getUser();
 
                // User/talk link
                $titles = array( $user->getUserPage(), $user->getTalkPage() );
@@ -202,58 +196,13 @@ abstract class Skin {
                $lb->execute();
        }
 
-       /**
-        * Set some local variables
-        */
-       protected function setMembers() {
-               $this->userpage = $this->getContext()->getUser()->getUserPage()->getPrefixedText();
-       }
-
-       /**
-        * Set the RequestContext used in this instance
-        *
-        * @param RequestContext $context
-        */
-       public function setContext( RequestContext $context ) {
-               $this->mContext = $context;
-       }
-
-       /**
-        * Get the RequestContext used in this instance
-        *
-        * @return RequestContext
-        */
-       public function getContext() {
-               if ( !isset($this->mContext) ) {
-                       wfDebug( __METHOD__ . " called and \$mContext is null. Using RequestContext::getMain(); for sanity\n" );
-                       $this->mContext = RequestContext::getMain();
-               }
-               return $this->mContext;
-       }
-
-       /** Get the title
-        *
-        * @return Title
-        */
-       public function getTitle() {
-               return $this->getContext()->getTitle();
-       }
-
-       /** Get the user
-        *
-        * @return User
-        */
-       public function getUser() {
-               return $this->getContext()->getUser();
-       }
-
        /**
         * Get the current revision ID
         *
         * @return Integer
         */
        public function getRevisionId() {
-               return $this->getContext()->getOutput()->getRevisionId();
+               return $this->getOutput()->getRevisionId();
        }
 
        /**
@@ -333,7 +282,7 @@ abstract class Skin {
         * Outputs the HTML generated by other functions.
         * @param $out OutputPage
         */
-       abstract function outputPage( OutputPage $out );
+       abstract function outputPage( OutputPage $out = null );
 
        static function makeVariablesScript( $data ) {
                if ( $data ) {
@@ -345,34 +294,6 @@ abstract class Skin {
                }
        }
 
-       /**
-        * To make it harder for someone to slip a user a fake
-        * user-JavaScript or user-CSS preview, a random token
-        * is associated with the login session. If it's not
-        * passed back with the preview request, we won't render
-        * the code.
-        *
-        * @param $action String: 'edit', 'submit' etc.
-        * @return bool
-        */
-       public function userCanPreview( $action ) {
-               if ( $action != 'submit' ) {
-                       return false;
-               }
-               if ( !$this->getContext()->getRequest()->wasPosted() ) {
-                       return false;
-               }
-               if ( !$this->getTitle()->userCanEditCssSubpage() ) {
-                       return false;
-               }
-               if ( !$this->getTitle()->userCanEditJsSubpage() ) {
-                       return false;
-               }
-
-               return $this->getContext()->getUser()->matchEditToken(
-                       $this->getContext()->getRequest()->getVal( 'wpEditToken' ) );
-       }
-
        /**
         * Generated JavaScript action=raw&gen=js
         * This used to load MediaWiki:Common.js and the skin-specific style
@@ -398,48 +319,6 @@ abstract class Skin {
                return '';
        }
 
-       /**
-        * @private
-        * @todo document
-        * @param $out OutputPage
-        */
-       function setupUserCss( OutputPage $out ) {
-               global $wgUseSiteCss, $wgAllowUserCss, $wgAllowUserCssPrefs;
-
-               wfProfileIn( __METHOD__ );
-
-               $this->setupSkinUserCss( $out );
-               // Add any extension CSS
-               foreach ( $out->getExtStyle() as $url ) {
-                       $out->addStyle( $url );
-               }
-
-               // Per-site custom styles
-               if ( $wgUseSiteCss ) {
-                       $out->addModuleStyles( array( 'site', 'noscript' ) );
-                       if( $this->getContext()->getUser()->isLoggedIn() ){
-                               $out->addModuleStyles( 'user.groups' );
-                       }
-               }
-
-               // Per-user custom styles
-               if ( $wgAllowUserCss ) {
-                       if ( $this->getTitle()->isCssSubpage() && $this->userCanPreview( $this->getContext()->getRequest()->getVal( 'action' ) ) ) {
-                               // @todo FIXME: Properly escape the cdata!
-                               $out->addInlineStyle( $this->getContext()->getRequest()->getText( 'wpTextbox1' ) );
-                       } else {
-                               $out->addModuleStyles( 'user' );
-                       }
-               }
-
-               // Per-user preference styles
-               if ( $wgAllowUserCssPrefs ) {
-                       $out->addModuleStyles( 'user.options' );
-               }
-
-               wfProfileOut( __METHOD__ );
-       }
-
        /**
         * Get the query to generate a dynamic stylesheet
         *
@@ -460,7 +339,7 @@ abstract class Skin {
        /**
         * Add skin specific stylesheets
         * Calling this method with an $out of anything but the same OutputPage
-        * inside ->getContext()->getOutput() is deprecated. The $out arg is kept
+        * inside ->getOutput() is deprecated. The $out arg is kept
         * for compatibility purposes with skins.
         * @param $out OutputPage
         * @delete
@@ -516,49 +395,43 @@ abstract class Skin {
        }
 
        function getCategoryLinks() {
-               global $wgUseCategoryBrowser, $wgContLang;
+               global $wgUseCategoryBrowser;
 
-               $out = $this->getContext()->getOutput();
+               $out = $this->getOutput();
+               $allCats = $out->getCategoryLinks();
 
-               if ( count( $out->mCategoryLinks ) == 0 ) {
+               if ( !count( $allCats ) ) {
                        return '';
                }
 
-               # Separator
-               $sep = wfMsgExt( 'catseparator', array( 'parsemag', 'escapenoentities' ) );
+               $embed = "<li>";
+               $pop = "</li>";
 
-               // Use Unicode bidi embedding override characters,
-               // to make sure links don't smash each other up in ugly ways.
-               $dir = $wgContLang->getDir();
-               $embed = "<span dir='$dir'>";
-               $pop = '</span>';
-
-               $allCats = $out->getCategoryLinks();
                $s = '';
                $colon = wfMsgExt( 'colon-separator', 'escapenoentities' );
 
                if ( !empty( $allCats['normal'] ) ) {
-                       $t = $embed . implode( "{$pop} {$sep} {$embed}" , $allCats['normal'] ) . $pop;
+                       $t = $embed . implode( "{$pop}{$embed}" , $allCats['normal'] ) . $pop;
 
                        $msg = wfMsgExt( 'pagecategories', array( 'parsemag', 'escapenoentities' ), count( $allCats['normal'] ) );
-                       $s .= '<div id="mw-normal-catlinks">' .
+                       $s .= '<div id="mw-normal-catlinks" class="mw-normal-catlinks">' .
                                Linker::link( Title::newFromText( wfMsgForContent( 'pagecategorieslink' ) ), $msg )
-                               . $colon . $t . '</div>';
+                               . $colon . '<ul>' . $t . '</ul>' . '</div>';
                }
 
                # Hidden categories
                if ( isset( $allCats['hidden'] ) ) {
-                       if ( $this->getContext()->getUser()->getBoolOption( 'showhiddencats' ) ) {
-                               $class = 'mw-hidden-cats-user-shown';
+                       if ( $this->getUser()->getBoolOption( 'showhiddencats' ) ) {
+                               $class = ' mw-hidden-cats-user-shown';
                        } elseif ( $this->getTitle()->getNamespace() == NS_CATEGORY ) {
-                               $class = 'mw-hidden-cats-ns-shown';
+                               $class = ' mw-hidden-cats-ns-shown';
                        } else {
-                               $class = 'mw-hidden-cats-hidden';
+                               $class = ' mw-hidden-cats-hidden';
                        }
 
-                       $s .= "<div id=\"mw-hidden-catlinks\" class=\"$class\">" .
+                       $s .= "<div id=\"mw-hidden-catlinks\" class=\"mw-hidden-catlinks$class\">" .
                                wfMsgExt( 'hidden-categories', array( 'parsemag', 'escapenoentities' ), count( $allCats['hidden'] ) ) .
-                               $colon . $embed . implode( "$pop $sep $embed", $allCats['hidden'] ) . $pop .
+                               $colon . '<ul>' . $embed . implode( "{$pop}{$embed}" , $allCats['hidden'] ) . $pop . '</ul>' .
                                '</div>';
                }
 
@@ -601,14 +474,14 @@ abstract class Skin {
 
                        # add our current element to the list
                        $eltitle = Title::newFromText( $element );
-                       $return .=  Linker::link( $eltitle, $eltitle->getText() );
+                       $return .=  Linker::link( $eltitle, htmlspecialchars( $eltitle->getText() ) );
                }
 
                return $return;
        }
 
        function getCategories() {
-               $out = $this->getContext()->getOutput();
+               $out = $this->getOutput();
 
                $catlinks = $this->getCategoryLinks();
 
@@ -616,7 +489,7 @@ abstract class Skin {
 
                // Check what we're showing
                $allCats = $out->getCategoryLinks();
-               $showHidden = $this->getContext()->getUser()->getBoolOption( 'showhiddencats' ) ||
+               $showHidden = $this->getUser()->getBoolOption( 'showhiddencats' ) ||
                                                $this->getTitle()->getNamespace() == NS_CATEGORY;
 
                if ( empty( $allCats['normal'] ) && !( !empty( $allCats['hidden'] ) && $showHidden ) ) {
@@ -670,7 +543,7 @@ abstract class Skin {
                global $wgShowDebug;
 
                if ( $wgShowDebug ) {
-                       $listInternals = $this->formatDebugHTML( $this->getContext()->getOutput()->mDebugtext );
+                       $listInternals = $this->formatDebugHTML( $this->getOutput()->mDebugtext );
                        return "\n<hr />\n<strong>Debug data:</strong><ul id=\"mw-debug-html\">" .
                                $listInternals . "</ul>\n";
                }
@@ -730,34 +603,46 @@ abstract class Skin {
 
        /**
         * This gets called shortly before the </body> tag.
-        * @param $out OutputPage object
+        *
         * @return String HTML-wrapped JS code to be put before </body>
         */
-       function bottomScripts( $out ) {
+       function bottomScripts() {
                // TODO and the suckage continues. This function is really just a wrapper around
                // OutputPage::getBottomScripts() which takes a Skin param. This should be cleaned
                // up at some point
-               $bottomScriptText = $out->getBottomScripts( $this );
+               $bottomScriptText = $this->getOutput()->getBottomScripts();
                wfRunHooks( 'SkinAfterBottomScripts', array( $this, &$bottomScriptText ) );
 
                return $bottomScriptText;
        }
 
-       /** @return string Retrievied from HTML text */
+       /**
+        * Text with the permalink to the source page,
+        * usually shown on the footer of a printed page
+        *
+        * @return string HTML text with an URL
+        */
        function printSource() {
-               $url = htmlspecialchars( $this->getTitle()->getFullURL() );
+               $oldid = $this->getRevisionId();
+               if ( $oldid ) {
+                       $url = htmlspecialchars( $this->getTitle()->getCanonicalURL( 'oldid=' . $oldid ) );
+               } else {
+                       // oldid not available for non existing pages
+                       $url = htmlspecialchars( $this->getTitle()->getCanonicalURL() );
+               }
                return wfMsg( 'retrievedfrom', '<a href="' . $url . '">' . $url . '</a>' );
        }
 
        function getUndeleteLink() {
-               $action = $this->getContext()->getRequest()->getVal( 'action', 'view' );
+               $action = $this->getRequest()->getVal( 'action', 'view' );
 
-               if ( $this->getContext()->getUser()->isAllowed( 'deletedhistory' ) &&
+               if ( $this->getUser()->isAllowed( 'deletedhistory' ) && !$this->getUser()->isBlocked() &&
                        ( $this->getTitle()->getArticleId() == 0 || $action == 'history' ) ) {
                        $n = $this->getTitle()->isDeleted();
 
+
                        if ( $n ) {
-                               if ( $this->getContext()->getUser()->isAllowed( 'undelete' ) ) {
+                               if ( $this->getUser()->isAllowed( 'undelete' ) ) {
                                        $msg = 'thisisdeleted';
                                } else {
                                        $msg = 'viewdeleted';
@@ -765,12 +650,9 @@ abstract class Skin {
 
                                return wfMsg(
                                        $msg,
-                                       Linker::link(
+                                       Linker::linkKnown(
                                                SpecialPage::getTitleFor( 'Undelete', $this->getTitle()->getPrefixedDBkey() ),
-                                               wfMsgExt( 'restorelink', array( 'parsemag', 'escape' ), $this->getContext()->getLang()->formatNum( $n ) ),
-                                               array(),
-                                               array(),
-                                               array( 'known', 'noclasses' )
+                                               wfMsgExt( 'restorelink', array( 'parsemag', 'escape' ), $this->getLang()->formatNum( $n ) )
                                        )
                                );
                        }
@@ -780,7 +662,7 @@ abstract class Skin {
        }
 
        function subPageSubtitle() {
-               $out = $this->getContext()->getOutput();
+               $out = $this->getOutput();
                $subpages = '';
 
                if ( !wfRunHooks( 'SkinSubPageSubtitle', array( &$subpages, $this, $out ) ) ) {
@@ -802,12 +684,9 @@ abstract class Skin {
                                        $linkObj = Title::newFromText( $growinglink );
 
                                        if ( is_object( $linkObj ) && $linkObj->exists() ) {
-                                               $getlink = $this->link(
+                                               $getlink = Linker::linkKnown(
                                                        $linkObj,
-                                                       htmlspecialchars( $display ),
-                                                       array(),
-                                                       array(),
-                                                       array( 'known', 'noclasses' )
+                                                       htmlspecialchars( $display )
                                                );
 
                                                $c++;
@@ -853,9 +732,7 @@ abstract class Skin {
                global $wgRightsPage, $wgRightsUrl, $wgRightsText;
 
                if ( $type == 'detect' ) {
-                       $diff = $this->getContext()->getRequest()->getVal( 'diff' );
-
-                       if ( is_null( $diff ) && !$this->isRevisionCurrent() && wfMsgForContent( 'history_copyright' ) !== '-' ) {
+                       if ( !$this->isRevisionCurrent() && wfMsgForContent( 'history_copyright' ) !== '-' ) {
                                $type = 'history';
                        } else {
                                $type = 'normal';
@@ -868,8 +745,6 @@ abstract class Skin {
                        $msg = 'copyright';
                }
 
-               $out = '';
-
                if ( $wgRightsPage ) {
                        $title = Title::newFromText( $wgRightsPage );
                        $link = Linker::linkKnown( $title, $wgRightsText );
@@ -879,7 +754,7 @@ abstract class Skin {
                        $link = $wgRightsText;
                } else {
                        # Give up now
-                       return $out;
+                       return '';
                }
 
                // Allow for site and per-namespace customization of copyright notice.
@@ -888,12 +763,10 @@ abstract class Skin {
                wfRunHooks( 'SkinCopyrightFooter', array( $this->getTitle(), $type, &$msg, &$link, &$forContent ) );
 
                if ( $forContent ) {
-                       $out .= wfMsgForContent( $msg, $link );
+                       return wfMsgForContent( $msg, $link );
                } else {
-                       $out .= wfMsg( $msg, $link );
+                       return wfMsg( $msg, $link );
                }
-
-               return $out;
        }
 
        function getCopyrightIcon() {
@@ -949,8 +822,8 @@ abstract class Skin {
                }
 
                if ( $timestamp ) {
-                       $d = $this->getContext()->getLang()->date( $timestamp, true );
-                       $t = $this->getContext()->getLang()->time( $timestamp, true );
+                       $d = $this->getLang()->date( $timestamp, true );
+                       $t = $this->getLang()->time( $timestamp, true );
                        $s = ' ' . wfMsg( 'lastmodifiedat', $d, $t );
                } else {
                        $s = '';
@@ -970,7 +843,7 @@ abstract class Skin {
                        $a = '';
                }
 
-               $mp = wfMsg( 'mainpage' );
+               $mp = wfMsgHtml( 'mainpage' );
                $mptitle = Title::newMainPage();
                $url = ( is_object( $mptitle ) ? $mptitle->escapeLocalURL() : '' );
 
@@ -1009,12 +882,9 @@ abstract class Skin {
         * @return string
         */
        function mainPageLink() {
-               $s = Linker::link(
+               $s = Linker::linkKnown(
                        Title::newMainPage(),
-                       wfMsg( 'mainpage' ),
-                       array(),
-                       array(),
-                       array( 'known', 'noclasses' )
+                       wfMsgHtml( 'mainpage' )
                );
 
                return $s;
@@ -1081,7 +951,7 @@ abstract class Skin {
 
        function showEmailUser( $id ) {
                $targetUser = User::newFromId( $id );
-               return $this->getContext()->getUser()->canSendEmail() && # the sending user must have a confirmed email address
+               return $this->getUser()->canSendEmail() && # the sending user must have a confirmed email address
                        $targetUser->canReceiveEmail(); # the target user must have a confirmed email address and allow emails from users
        }
 
@@ -1208,7 +1078,7 @@ abstract class Skin {
                global $parserMemc, $wgEnableSidebarCache, $wgSidebarCacheExpiry;
                wfProfileIn( __METHOD__ );
 
-               $key = wfMemcKey( 'sidebar', $this->getContext()->getLang()->getCode() );
+               $key = wfMemcKey( 'sidebar', $this->getLang()->getCode() );
 
                if ( $wgEnableSidebarCache ) {
                        $cachedsidebar = $parserMemc->get( $key );
@@ -1251,7 +1121,6 @@ abstract class Skin {
         */
        function addToSidebarPlain( &$bar, $text ) {
                $lines = explode( "\n", $text );
-               $wikiBar = array(); # We need to handle the wikitext on a different variable, to avoid trying to do an array operation on text, which would be a fatal error.
 
                $heading = '';
 
@@ -1259,6 +1128,7 @@ abstract class Skin {
                        if ( strpos( $line, '*' ) !== 0 ) {
                                continue;
                        }
+                       $line = rtrim( $line, "\r" ); // for Windows compat
 
                        if ( strpos( $line, '**' ) !== 0 ) {
                                $heading = trim( $line, '* ' );
@@ -1292,24 +1162,13 @@ abstract class Skin {
 
                                        if ( preg_match( '/^(?:' . wfUrlProtocols() . ')/', $link ) ) {
                                                $href = $link;
-                                               //Parser::getExternalLinkAttribs won't work here because of the Namespace things
-                                               global $wgNoFollowLinks;
-                                               if ( $wgNoFollowLinks ) {
+                                               
+                                               // Parser::getExternalLinkAttribs won't work here because of the Namespace things
+                                               global $wgNoFollowLinks, $wgNoFollowDomainExceptions;
+                                               if ( $wgNoFollowLinks && !wfMatchesDomainList( $href, $wgNoFollowDomainExceptions ) ) {
                                                        $extraAttribs['rel'] = 'nofollow';
-
-                                                       global $wgNoFollowDomainExceptions;
-                                                       if ( $wgNoFollowDomainExceptions ) {
-                                                               $bits = wfParseUrl( $url );
-                                                               if ( is_array( $bits ) && isset( $bits['host'] ) ) {
-                                                                       foreach ( $wgNoFollowDomainExceptions as $domain ) {
-                                                                               if ( substr( $bits['host'], -strlen( $domain ) ) == $domain ) {
-                                                                                       unset( $extraAttribs['rel'] );
-                                                                                       break;
-                                                                               }
-                                                                       }
-                                                               }
-                                                       }
                                                }
+                                               
                                                global $wgExternalLinkTarget;
                                                if ( $wgExternalLinkTarget) {
                                                        $extraAttribs['target'] = $wgExternalLinkTarget;
@@ -1319,7 +1178,7 @@ abstract class Skin {
 
                                                if ( $title ) {
                                                        $title = $title->fixSpecialName();
-                                                       $href = $title->getLocalURL();
+                                                       $href = $title->getLinkURL();
                                                } else {
                                                        $href = 'INVALID-TITLE';
                                                }
@@ -1328,28 +1187,15 @@ abstract class Skin {
                                        $bar[$heading][] = array_merge( array(
                                                'text' => $text,
                                                'href' => $href,
-                                               'id' => 'n-' . strtr( $line[1], ' ', '-' ),
+                                               'id' => 'n-' . Sanitizer::escapeId( strtr( $line[1], ' ', '-' ), 'noninitial' ),
                                                'active' => false
                                        ), $extraAttribs );
-                               } elseif ( ( substr( $line, 0, 2 ) == '{{' ) && ( substr( $line, -2 ) == '}}' ) ) {
-                                       global $wgParser;
-
-                                       $line = substr( $line, 2, strlen( $line ) - 4 );
-
-                                       $options = new ParserOptions();
-                                       $options->setEditSection( false );
-                                       $options->setInterfaceMessage( true );
-                                       $wikiBar[$heading] = $wgParser->parse( wfMsgForContentNoTrans( $line ) , $this->getTitle(), $options )->getText();
                                } else {
                                        continue;
                                }
                        }
                }
 
-               if ( count( $wikiBar ) > 0 ) {
-                       $bar = array_merge( $bar, $wikiBar );
-               }
-
                return $bar;
        }
 
@@ -1370,9 +1216,9 @@ abstract class Skin {
         * @return MediaWiki message or if no new talk page messages, nothing
         */
        function getNewtalks() {
-               $out = $this->getContext()->getOutput();
+               $out = $this->getOutput();
 
-               $newtalks = $this->getContext()->getUser()->getNewMessageLinks();
+               $newtalks = $this->getUser()->getNewMessageLinks();
                $ntl = '';
 
                if ( count( $newtalks ) == 1 && $newtalks[0]['wiki'] === wfWikiID() ) {
@@ -1380,20 +1226,18 @@ abstract class Skin {
                        $userTalkTitle = $userTitle->getTalkPage();
 
                        if ( !$userTalkTitle->equals( $out->getTitle() ) ) {
-                               $newMessagesLink = $this->link(
+                               $newMessagesLink = Linker::linkKnown(
                                        $userTalkTitle,
                                        wfMsgHtml( 'newmessageslink' ),
                                        array(),
-                                       array( 'redirect' => 'no' ),
-                                       array( 'known', 'noclasses' )
+                                       array( 'redirect' => 'no' )
                                );
 
-                               $newMessagesDiffLink = $this->link(
+                               $newMessagesDiffLink = Linker::linkKnown(
                                        $userTalkTitle,
                                        wfMsgHtml( 'newmessagesdifflink' ),
                                        array(),
-                                       array( 'diff' => 'cur' ),
-                                       array( 'known', 'noclasses' )
+                                       array( 'diff' => 'cur' )
                                );
 
                                $ntl = wfMsg(
@@ -1430,7 +1274,7 @@ abstract class Skin {
         * @return String: HTML fragment
         */
        private function getCachedNotice( $name ) {
-               global $wgRenderHashAppend, $parserMemc;
+               global $wgRenderHashAppend, $parserMemc, $wgContLang;
 
                wfProfileIn( __METHOD__ );
 
@@ -1467,12 +1311,13 @@ abstract class Skin {
                }
 
                if ( $needParse ) {
-                       $parsed = $this->getContext()->getOutput()->parse( $notice );
+                       $parsed = $this->getOutput()->parse( $notice );
                        $parserMemc->set( $key, array( 'html' => $parsed, 'hash' => md5( $notice ) ), 600 );
                        $notice = $parsed;
                }
 
-               $notice = '<div id="localNotice">' .$notice . '</div>';
+               $notice = Html::rawElement( 'div', array( 'id' => 'localNotice',
+                       'lang' => $wgContLang->getCode(), 'dir' => $wgContLang->getDir() ), $notice );
                wfProfileOut( __METHOD__ );
                return $notice;
        }
@@ -1507,7 +1352,7 @@ abstract class Skin {
                $siteNotice = '';
 
                if ( wfRunHooks( 'SiteNoticeBefore', array( &$siteNotice, $this ) ) ) {
-                       if ( is_object( $this->getContext()->getUser() ) && $this->getContext()->getUser()->isLoggedIn() ) {
+                       if ( is_object( $this->getUser() ) && $this->getUser()->isLoggedIn() ) {
                                $siteNotice = $this->getCachedNotice( 'sitenotice' );
                        } else {
                                $anonNotice = $this->getCachedNotice( 'anonnotice' );