Update Postgres with missing uploadstash tables
[lhc/web/wiklou.git] / includes / Revision.php
index 65f9baf..ec0508c 100644 (file)
@@ -4,6 +4,22 @@
  * @todo document
  */
 class Revision {
+       protected $mId;
+       protected $mPage;
+       protected $mUserText;
+       protected $mOrigUserText;
+       protected $mUser;
+       protected $mMinorEdit;
+       protected $mTimestamp;
+       protected $mDeleted;
+       protected $mSize;
+       protected $mParentId;
+       protected $mComment;
+       protected $mText;
+       protected $mTextRow;
+       protected $mTitle;
+       protected $mCurrent;
+
        const DELETED_TEXT = 1;
        const DELETED_COMMENT = 2;
        const DELETED_USER = 4;
@@ -23,9 +39,7 @@ class Revision {
         * @return Revision or null
         */
        public static function newFromId( $id ) {
-               return Revision::newFromConds(
-                       array( 'page_id=rev_page',
-                                  'rev_id' => intval( $id ) ) );
+               return Revision::newFromConds( array( 'rev_id' => intval( $id ) ) );
        }
 
        /**
@@ -57,7 +71,6 @@ class Revision {
                        // Use a join to get the latest revision
                        $conds[] = 'rev_id=page_latest';
                }
-               $conds[] = 'page_id=rev_page';
                return Revision::newFromConds( $conds );
        }
 
@@ -85,7 +98,6 @@ class Revision {
                } else {
                        $conds[] = 'rev_id = page_latest';
                }
-               $conds[] = 'page_id=rev_page';
                return Revision::newFromConds( $conds );
        }
 
@@ -110,7 +122,8 @@ class Revision {
                        'minor_edit' => $row->ar_minor_edit,
                        'text_id'    => isset( $row->ar_text_id ) ? $row->ar_text_id : null,
                        'deleted'    => $row->ar_deleted,
-                       'len'        => $row->ar_len);
+                       'len'        => $row->ar_len
+               );
                if ( isset( $row->ar_text ) && !$row->ar_text_id ) {
                        // Pre-1.5 ar_text row
                        $attribs['text'] = self::getRevisionText( $row, 'ar_' );
@@ -122,6 +135,8 @@ class Revision {
        }
 
        /**
+        * @since 1.19
+        *
         * @param $row
         * @return Revision
         */
@@ -138,9 +153,7 @@ class Revision {
         * @return Revision or null
         */
        public static function loadFromId( $db, $id ) {
-               return Revision::loadFromConds( $db,
-                       array( 'page_id=rev_page',
-                                  'rev_id' => intval( $id ) ) );
+               return Revision::loadFromConds( $db, array( 'rev_id' => intval( $id ) ) );
        }
 
        /**
@@ -154,7 +167,7 @@ class Revision {
         * @return Revision or null
         */
        public static function loadFromPageId( $db, $pageid, $id = 0 ) {
-               $conds = array( 'page_id=rev_page','rev_page' => intval( $pageid ), 'page_id'=>intval( $pageid ) );
+               $conds = array( 'rev_page' => intval( $pageid ), 'page_id'  => intval( $pageid ) );
                if( $id ) {
                        $conds['rev_id'] = intval( $id );
                } else {
@@ -179,12 +192,11 @@ class Revision {
                } else {
                        $matchId = 'page_latest';
                }
-               return Revision::loadFromConds(
-                       $db,
+               return Revision::loadFromConds( $db,
                        array( "rev_id=$matchId",
-                                  'page_id=rev_page',
                                   'page_namespace' => $title->getNamespace(),
-                                  'page_title'     => $title->getDBkey() ) );
+                                  'page_title'     => $title->getDBkey() )
+               );
        }
 
        /**
@@ -198,12 +210,11 @@ class Revision {
         * @return Revision or null
         */
        public static function loadFromTimestamp( $db, $title, $timestamp ) {
-               return Revision::loadFromConds(
-                       $db,
+               return Revision::loadFromConds( $db,
                        array( 'rev_timestamp'  => $db->timestamp( $timestamp ),
-                                  'page_id=rev_page',
                                   'page_namespace' => $title->getNamespace(),
-                                  'page_title'     => $title->getDBkey() ) );
+                                  'page_title'     => $title->getDBkey() )
+               );
        }
 
        /**
@@ -214,12 +225,12 @@ class Revision {
         */
        public static function newFromConds( $conditions ) {
                $db = wfGetDB( DB_SLAVE );
-               $row = Revision::loadFromConds( $db, $conditions );
-               if( is_null( $row ) && wfGetLB()->getServerCount() > 1 ) {
+               $rev = Revision::loadFromConds( $db, $conditions );
+               if( is_null( $rev ) && wfGetLB()->getServerCount() > 1 ) {
                        $dbw = wfGetDB( DB_MASTER );
-                       $row = Revision::loadFromConds( $dbw, $conditions );
+                       $rev = Revision::loadFromConds( $dbw, $conditions );
                }
-               return $row;
+               return $rev;
        }
 
        /**
@@ -234,7 +245,6 @@ class Revision {
                $res = Revision::fetchFromConds( $db, $conditions );
                if( $res ) {
                        $row = $res->fetchObject();
-                       $res->free();
                        if( $row ) {
                                $ret = new Revision( $row );
                                return $ret;
@@ -257,8 +267,8 @@ class Revision {
                        wfGetDB( DB_SLAVE ),
                        array( 'rev_id=page_latest',
                                   'page_namespace' => $title->getNamespace(),
-                                  'page_title'     => $title->getDBkey(),
-                                  'page_id=rev_page' ) );
+                                  'page_title'     => $title->getDBkey() )
+               );
        }
 
        /**
@@ -271,16 +281,20 @@ class Revision {
         * @return ResultWrapper
         */
        private static function fetchFromConds( $db, $conditions ) {
-               $fields = self::selectFields();
-               $fields[] = 'page_namespace';
-               $fields[] = 'page_title';
-               $fields[] = 'page_latest';
+               $fields = array_merge(
+                       self::selectFields(),
+                       self::selectPageFields(),
+                       self::selectUserFields()
+               );
                return $db->select(
-                       array( 'page', 'revision' ),
+                       array( 'revision', 'page', 'user' ),
                        $fields,
                        $conditions,
                        __METHOD__,
-                       array( 'LIMIT' => 1 ) );
+                       array( 'LIMIT' => 1 ),
+                       array( 'page' => array( 'INNER JOIN', 'page_id = rev_page' ),
+                               'user' => array( 'LEFT JOIN', 'rev_user != 0 AND user_id = rev_user' ) )
+               );
        }
 
        /**
@@ -294,7 +308,7 @@ class Revision {
                        'rev_text_id',
                        'rev_timestamp',
                        'rev_comment',
-                       'rev_user_text,'.
+                       'rev_user_text',
                        'rev_user',
                        'rev_minor_edit',
                        'rev_deleted',
@@ -307,7 +321,7 @@ class Revision {
         * Return the list of text fields that should be selected to read the
         * revision text
         */
-       static function selectTextFields() {
+       public static function selectTextFields() {
                return array(
                        'old_text',
                        'old_flags'
@@ -317,7 +331,7 @@ class Revision {
        /**
         * Return the list of page fields that should be selected from page table
         */
-       static function selectPageFields() {
+       public static function selectPageFields() {
                return array(
                        'page_namespace',
                        'page_title',
@@ -325,6 +339,13 @@ class Revision {
                );
        }
 
+       /**
+        * Return the list of user fields that should be selected from user table
+        */
+       public static function selectUserFields() {
+               return array( 'user_name' );
+       }
+
        /**
         * Constructor
         *
@@ -337,14 +358,13 @@ class Revision {
                        $this->mPage      = intval( $row->rev_page );
                        $this->mTextId    = intval( $row->rev_text_id );
                        $this->mComment   =         $row->rev_comment;
-                       $this->mUserText  =         $row->rev_user_text;
                        $this->mUser      = intval( $row->rev_user );
                        $this->mMinorEdit = intval( $row->rev_minor_edit );
                        $this->mTimestamp =         $row->rev_timestamp;
                        $this->mDeleted   = intval( $row->rev_deleted );
 
                        if( !isset( $row->rev_parent_id ) ) {
-                               $this->mParentId = is_null($row->rev_parent_id) ? null : 0;
+                               $this->mParentId = is_null( $row->rev_parent_id ) ? null : 0;
                        } else {
                                $this->mParentId  = intval( $row->rev_parent_id );
                        }
@@ -371,6 +391,15 @@ class Revision {
                                // 'text' table row entry will be lazy-loaded
                                $this->mTextRow = null;
                        }
+
+                       // Use user_name for users and rev_user_text for IPs...
+                       $this->mUserText = null; // lazy load if left null
+                       if ( $this->mUser == 0 ) {
+                               $this->mUserText = $row->rev_user_text; // IP user
+                       } elseif ( isset( $row->user_name ) ) {
+                               $this->mUserText = $row->user_name; // logged-in user
+                       }
+                       $this->mOrigUserText = $row->rev_user_text;
                } elseif( is_array( $row ) ) {
                        // Build a new revision to be saved...
                        global $wgUser;
@@ -394,8 +423,9 @@ class Revision {
                        $this->mTitle     = null; # Load on demand if needed
                        $this->mCurrent   = false;
                        # If we still have no len_size, see it we have the text to figure it out
-                       if ( !$this->mSize )
+                       if ( !$this->mSize ) {
                                $this->mSize      = is_null( $this->mText ) ? null : strlen( $this->mText );
+                       }
                } else {
                        throw new MWException( 'Revision constructor passed invalid row format.' );
                }
@@ -487,14 +517,14 @@ class Revision {
         *      Revision::FOR_PUBLIC       to be displayed to all users
         *      Revision::FOR_THIS_USER    to be displayed to $wgUser
         *      Revision::RAW              get the ID regardless of permissions
-        *
-        *
+        * @param $user User object to check for, only if FOR_THIS_USER is passed
+        *              to the $audience parameter
         * @return Integer
         */
-       public function getUser( $audience = self::FOR_PUBLIC ) {
+       public function getUser( $audience = self::FOR_PUBLIC, User $user = null ) {
                if( $audience == self::FOR_PUBLIC && $this->isDeleted( self::DELETED_USER ) ) {
                        return 0;
-               } elseif( $audience == self::FOR_THIS_USER && !$this->userCan( self::DELETED_USER ) ) {
+               } elseif( $audience == self::FOR_THIS_USER && !$this->userCan( self::DELETED_USER, $user ) ) {
                        return 0;
                } else {
                        return $this->mUser;
@@ -519,16 +549,17 @@ class Revision {
         *      Revision::FOR_PUBLIC       to be displayed to all users
         *      Revision::FOR_THIS_USER    to be displayed to $wgUser
         *      Revision::RAW              get the text regardless of permissions
-        *
+        * @param $user User object to check for, only if FOR_THIS_USER is passed
+        *              to the $audience parameter
         * @return string
         */
-       public function getUserText( $audience = self::FOR_PUBLIC ) {
+       public function getUserText( $audience = self::FOR_PUBLIC, User $user = null ) {
                if( $audience == self::FOR_PUBLIC && $this->isDeleted( self::DELETED_USER ) ) {
                        return '';
-               } elseif( $audience == self::FOR_THIS_USER && !$this->userCan( self::DELETED_USER ) ) {
+               } elseif( $audience == self::FOR_THIS_USER && !$this->userCan( self::DELETED_USER, $user ) ) {
                        return '';
                } else {
-                       return $this->mUserText;
+                       return $this->getRawUserText();
                }
        }
 
@@ -538,6 +569,14 @@ class Revision {
         * @return String
         */
        public function getRawUserText() {
+               if ( $this->mUserText === null ) {
+                       $this->mUserText = User::whoIs( $this->mUser ); // load on demand
+                       if ( $this->mUserText === false ) {
+                               # This shouldn't happen, but it can if the wiki was recovered
+                               # via importing revs and there is no user table entry yet.
+                               $this->mUserText = $this->mOrigUserText;
+                       }
+               }
                return $this->mUserText;
        }
 
@@ -550,13 +589,14 @@ class Revision {
         *      Revision::FOR_PUBLIC       to be displayed to all users
         *      Revision::FOR_THIS_USER    to be displayed to $wgUser
         *      Revision::RAW              get the text regardless of permissions
-        *
+        * @param $user User object to check for, only if FOR_THIS_USER is passed
+        *              to the $audience parameter
         * @return String
         */
-       function getComment( $audience = self::FOR_PUBLIC ) {
+       function getComment( $audience = self::FOR_PUBLIC, User $user = null ) {
                if( $audience == self::FOR_PUBLIC && $this->isDeleted( self::DELETED_COMMENT ) ) {
                        return '';
-               } elseif( $audience == self::FOR_THIS_USER && !$this->userCan( self::DELETED_COMMENT ) ) {
+               } elseif( $audience == self::FOR_THIS_USER && !$this->userCan( self::DELETED_COMMENT, $user ) ) {
                        return '';
                } else {
                        return $this->mComment;
@@ -627,13 +667,14 @@ class Revision {
         *      Revision::FOR_PUBLIC       to be displayed to all users
         *      Revision::FOR_THIS_USER    to be displayed to $wgUser
         *      Revision::RAW              get the text regardless of permissions
-        *
+        * @param $user User object to check for, only if FOR_THIS_USER is passed
+        *              to the $audience parameter
         * @return String
         */
-       public function getText( $audience = self::FOR_PUBLIC ) {
+       public function getText( $audience = self::FOR_PUBLIC, User $user = null ) {
                if( $audience == self::FOR_PUBLIC && $this->isDeleted( self::DELETED_TEXT ) ) {
                        return '';
-               } elseif( $audience == self::FOR_THIS_USER && !$this->userCan( self::DELETED_TEXT ) ) {
+               } elseif( $audience == self::FOR_THIS_USER && !$this->userCan( self::DELETED_TEXT, $user ) ) {
                        return '';
                } else {
                        return $this->getRawText();
@@ -1020,10 +1061,11 @@ class Revision {
         * @param $field Integer:one of self::DELETED_TEXT,
         *                              self::DELETED_COMMENT,
         *                              self::DELETED_USER
+        * @param $user User object to check, or null to use $wgUser
         * @return Boolean
         */
-       public function userCan( $field ) {
-               return self::userCanBitfield( $this->mDeleted, $field );
+       public function userCan( $field, User $user = null ) {
+               return self::userCanBitfield( $this->mDeleted, $field, $user );
        }
 
        /**
@@ -1035,11 +1077,11 @@ class Revision {
         * @param $field Integer: one of self::DELETED_TEXT = File::DELETED_FILE,
         *                               self::DELETED_COMMENT = File::DELETED_COMMENT,
         *                               self::DELETED_USER = File::DELETED_USER
+        * @param $user User object to check, or null to use $wgUser
         * @return Boolean
         */
-       public static function userCanBitfield( $bitfield, $field ) {
+       public static function userCanBitfield( $bitfield, $field, User $user = null ) {
                if( $bitfield & $field ) { // aspect is deleted
-                       global $wgUser;
                        if ( $bitfield & self::DELETED_RESTRICTED ) {
                                $permission = 'suppressrevision';
                        } elseif ( $field & self::DELETED_TEXT ) {
@@ -1048,7 +1090,11 @@ class Revision {
                                $permission = 'deletedhistory';
                        }
                        wfDebug( "Checking for $permission due to $field match on $bitfield\n" );
-                       return $wgUser->isAllowed( $permission );
+                       if ( $user === null ) {
+                               global $wgUser;
+                               $user = $wgUser;
+                       }
+                       return $user->isAllowed( $permission );
                } else {
                        return true;
                }