Unused global
[lhc/web/wiklou.git] / includes / RecentChange.php
index 845b429..97a5e1b 100644 (file)
@@ -1,68 +1,63 @@
 <?php
-/**
- *
- */
 
 /**
  * Utility class for creating new RC entries
+ *
  * mAttribs:
- *     rc_id           id of the row in the recentchanges table
- *     rc_timestamp    time the entry was made
- *     rc_cur_time     timestamp on the cur row
- *     rc_namespace    namespace #
- *     rc_title        non-prefixed db key
- *     rc_type         is new entry, used to determine whether updating is necessary
- *     rc_minor        is minor
- *     rc_cur_id       page_id of associated page entry
- *     rc_user         user id who made the entry
- *     rc_user_text    user name who made the entry
- *     rc_comment      edit summary
- *     rc_this_oldid   rev_id associated with this entry (or zero)
- *     rc_last_oldid   rev_id associated with the entry before this one (or zero)
- *     rc_bot          is bot, hidden
- *     rc_ip           IP address of the user in dotted quad notation
- *     rc_new          obsolete, use rc_type==RC_NEW
- *     rc_patrolled    boolean whether or not someone has marked this edit as patrolled
- *     rc_old_len      integer byte length of the text before the edit
- *     rc_new_len      the same after the edit
 *    rc_deleted              partial deletion
- *     rc_logid                the log_id value for this log entry (or zero)
- *  rc_log_type                the log type (or null)
- *     rc_log_action   the log action (or null)
- *  rc_params          log params
+ *  rc_id           id of the row in the recentchanges table
+ *  rc_timestamp    time the entry was made
+ *  rc_cur_time     timestamp on the cur row
+ *  rc_namespace    namespace #
+ *  rc_title        non-prefixed db key
+ *  rc_type         is new entry, used to determine whether updating is necessary
+ *  rc_minor        is minor
+ *  rc_cur_id       page_id of associated page entry
+ *  rc_user         user id who made the entry
+ *  rc_user_text    user name who made the entry
+ *  rc_comment      edit summary
+ *  rc_this_oldid   rev_id associated with this entry (or zero)
+ *  rc_last_oldid   rev_id associated with the entry before this one (or zero)
+ *  rc_bot          is bot, hidden
+ *  rc_ip           IP address of the user in dotted quad notation
+ *  rc_new          obsolete, use rc_type==RC_NEW
+ *  rc_patrolled    boolean whether or not someone has marked this edit as patrolled
+ *  rc_old_len      integer byte length of the text before the edit
+ *  rc_new_len      the same after the edit
*  rc_deleted      partial deletion
+ *  rc_logid        the log_id value for this log entry (or zero)
+ *  rc_log_type     the log type (or null)
+ *  rc_log_action   the log action (or null)
+ *  rc_params       log params
  *
  * mExtra:
- *     prefixedDBkey   prefixed db key, used by external app via msg queue
- *     lastTimestamp   timestamp of previous entry, used in WHERE clause during update
- *     lang            the interwiki prefix, automatically set in save()
+ *  prefixedDBkey   prefixed db key, used by external app via msg queue
+ *  lastTimestamp   timestamp of previous entry, used in WHERE clause during update
+ *  lang            the interwiki prefix, automatically set in save()
  *  oldSize         text size before the change
  *  newSize         text size after the change
  *
- * temporary:          not stored in the database
+ * temporary:       not stored in the database
  *      notificationtimestamp
  *      numberofWatchingusers
  *
  * @todo document functions and variables
  */
-class RecentChange
-{
+class RecentChange {
        var $mAttribs = array(), $mExtra = array();
        var $mTitle = false, $mMovedToTitle = false;
        var $numberofWatchingusers = 0 ; # Dummy to prevent error message in SpecialRecentchangeslinked
 
        # Factory methods
 
-       public static function newFromRow( $row )
-       {
+       public static function newFromRow( $row ) {
                $rc = new RecentChange;
                $rc->loadFromRow( $row );
                return $rc;
        }
 
-       public static function newFromCurRow( $row, $rc_this_oldid = 0 )
-       {
+       public static function newFromCurRow( $row ) {
                $rc = new RecentChange;
-               $rc->loadFromCurRow( $row, $rc_this_oldid );
+               $rc->loadFromCurRow( $row );
                $rc->notificationtimestamp = false;
                $rc->numberofWatchingusers = false;
                return $rc;
@@ -71,7 +66,7 @@ class RecentChange
        /**
         * Obtain the recent change with a given rc_id value
         *
-        * @param $rcid rc_id value to retrieve
+        * @param $rcid Int rc_id value to retrieve
         * @return RecentChange
         */
        public static function newFromId( $rcid ) {
@@ -79,18 +74,17 @@ class RecentChange
                $res = $dbr->select( 'recentchanges', '*', array( 'rc_id' => $rcid ), __METHOD__ );
                if( $res && $dbr->numRows( $res ) > 0 ) {
                        $row = $dbr->fetchObject( $res );
-                       $dbr->freeResult( $res );
                        return self::newFromRow( $row );
                } else {
-                       return NULL;
+                       return null;
                }
        }
 
        /**
         * Find the first recent change matching some specific conditions
         *
-        * @param array $conds Array of conditions
-        * @param mixed $fname Override the method name in profiling/logs
+        * @param $conds Array of conditions
+        * @param $fname Mixed: override the method name in profiling/logs
         * @return RecentChange
         */
        public static function newFromConds( $conds, $fname = false ) {
@@ -113,27 +107,29 @@ class RecentChange
 
        # Accessors
 
-       function setAttribs( $attribs )
-       {
+       public function setAttribs( $attribs ) {
                $this->mAttribs = $attribs;
        }
 
-       function setExtra( $extra )
-       {
+       public function setExtra( $extra ) {
                $this->mExtra = $extra;
        }
 
-       function &getTitle()
-       {
-               if ( $this->mTitle === false ) {
+       /**
+        *
+        * @return Title
+        */
+       public function &getTitle() {
+               if( $this->mTitle === false ) {
                        $this->mTitle = Title::makeTitle( $this->mAttribs['rc_namespace'], $this->mAttribs['rc_title'] );
+                       # Make sure the correct page ID is process cached
+                       $this->mTitle->resetArticleID( $this->mAttribs['rc_cur_id'] );
                }
                return $this->mTitle;
        }
 
-       function getMovedToTitle()
-       {
-               if ( $this->mMovedToTitle === false ) {
+       public function getMovedToTitle() {
+               if( $this->mMovedToTitle === false ) {
                        $this->mMovedToTitle = Title::makeTitle( $this->mAttribs['rc_moved_to_ns'],
                                $this->mAttribs['rc_moved_to_title'] );
                }
@@ -141,34 +137,33 @@ class RecentChange
        }
 
        # Writes the data in this object to the database
-       function save()
-       {
-               global $wgLocalInterwiki, $wgPutIPinRC, $wgRC2UDPAddress, $wgRC2UDPPort, $wgRC2UDPPrefix;
+       public function save() {
+               global $wgLocalInterwiki, $wgPutIPinRC, $wgRC2UDPAddress, $wgRC2UDPOmitBots;
                $fname = 'RecentChange::save';
 
                $dbw = wfGetDB( DB_MASTER );
-               if ( !is_array($this->mExtra) ) {
+               if( !is_array($this->mExtra) ) {
                        $this->mExtra = array();
                }
                $this->mExtra['lang'] = $wgLocalInterwiki;
 
-               if ( !$wgPutIPinRC ) {
+               if( !$wgPutIPinRC ) {
                        $this->mAttribs['rc_ip'] = '';
                }
 
-               ## If our database is strict about IP addresses, use NULL instead of an empty string
-               if ( $dbw->strictIPs() and $this->mAttribs['rc_ip'] == '' ) {
+               # If our database is strict about IP addresses, use NULL instead of an empty string
+               if( $dbw->strictIPs() and $this->mAttribs['rc_ip'] == '' ) {
                        unset( $this->mAttribs['rc_ip'] );
                }
 
                # Fixup database timestamps
                $this->mAttribs['rc_timestamp'] = $dbw->timestamp($this->mAttribs['rc_timestamp']);
                $this->mAttribs['rc_cur_time'] = $dbw->timestamp($this->mAttribs['rc_cur_time']);
-               $this->mAttribs['rc_id'] = $dbw->nextSequenceValue( 'rc_rc_id_seq' );
+               $this->mAttribs['rc_id'] = $dbw->nextSequenceValue( 'recentchanges_rc_id_seq' );
 
                ## If we are using foreign keys, an entry of 0 for the page_id will fail, so use NULL
-               if ( $dbw->cascadingDeletes() and $this->mAttribs['rc_cur_id']==0 ) {
-                       unset ( $this->mAttribs['rc_cur_id'] );
+               if( $dbw->cascadingDeletes() and $this->mAttribs['rc_cur_id']==0 ) {
+                       unset( $this->mAttribs['rc_cur_id'] );
                }
 
                # Insert new row
@@ -176,79 +171,149 @@ class RecentChange
 
                # Set the ID
                $this->mAttribs['rc_id'] = $dbw->insertId();
-
-               # Update old rows, if necessary
-               if ( $this->mAttribs['rc_type'] == RC_EDIT ) {
-                       $lastTime = $this->mExtra['lastTimestamp'];
-                       #$now = $this->mAttribs['rc_timestamp'];
-                       #$curId = $this->mAttribs['rc_cur_id'];
-
-                       # Don't bother looking for entries that have probably
-                       # been purged, it just locks up the indexes needlessly.
-                       global $wgRCMaxAge;
-                       $age = time() - wfTimestamp( TS_UNIX, $lastTime );
-                       if( $age < $wgRCMaxAge ) {
-                               # live hack, will commit once tested - kate
-                               # Update rc_this_oldid for the entries which were current
-                               #
-                               #$oldid = $this->mAttribs['rc_last_oldid'];
-                               #$ns = $this->mAttribs['rc_namespace'];
-                               #$title = $this->mAttribs['rc_title'];
-                               #
-                               #$dbw->update( 'recentchanges',
-                               #       array( /* SET */
-                               #               'rc_this_oldid' => $oldid
-                               #       ), array( /* WHERE */
-                               #               'rc_namespace' => $ns,
-                               #               'rc_title' => $title,
-                               #               'rc_timestamp' => $dbw->timestamp( $lastTime )
-                               #       ), $fname
-                               #);
-                       }
-
-                       # Update rc_cur_time
-                       #$dbw->update( 'recentchanges', array( 'rc_cur_time' => $now ),
-                       #       array( 'rc_cur_id' => $curId ), $fname );
-               }
+               
+               # Notify extensions
+               wfRunHooks( 'RecentChange_save', array( &$this ) );
 
                # Notify external application via UDP
-               if ( $wgRC2UDPAddress ) {
-                       $conn = socket_create( AF_INET, SOCK_DGRAM, SOL_UDP );
-                       if ( $conn ) {
-                               $line = $wgRC2UDPPrefix . $this->getIRCLine();
-                               socket_sendto( $conn, $line, strlen($line), 0, $wgRC2UDPAddress, $wgRC2UDPPort );
-                               socket_close( $conn );
-                       }
+               if( $wgRC2UDPAddress && ( !$this->mAttribs['rc_bot'] || !$wgRC2UDPOmitBots ) ) {
+                       self::sendToUDP( $this->getIRCLine() );
                }
 
                # E-mail notifications
-               global $wgUseEnotif;
-               if( $wgUseEnotif ) {
-                       # this would be better as an extension hook
-                       global $wgUser;
-                       $enotif = new EmailNotification;
+               global $wgUseEnotif, $wgShowUpdatedMarker, $wgUser;
+               if( $wgUseEnotif || $wgShowUpdatedMarker ) {
+                       // Users
+                       if( $this->mAttribs['rc_user'] ) {
+                               $editor = ($wgUser->getId() == $this->mAttribs['rc_user']) ? 
+                                       $wgUser : User::newFromID( $this->mAttribs['rc_user'] );
+                       // Anons
+                       } else {
+                               $editor = ($wgUser->getName() == $this->mAttribs['rc_user_text']) ? 
+                                       $wgUser : User::newFromName( $this->mAttribs['rc_user_text'], false );
+                       }
+                       # FIXME: this would be better as an extension hook
+                       $enotif = new EmailNotification();
                        $title = Title::makeTitle( $this->mAttribs['rc_namespace'], $this->mAttribs['rc_title'] );
-                       $enotif->notifyOnPageChange( $wgUser, $title,
+                       $enotif->notifyOnPageChange( $editor, $title,
                                $this->mAttribs['rc_timestamp'],
                                $this->mAttribs['rc_comment'],
                                $this->mAttribs['rc_minor'],
                                $this->mAttribs['rc_last_oldid'] );
                }
+       }
+       
+       public function notifyRC2UDP() {
+               global $wgRC2UDPAddress, $wgRC2UDPOmitBots;
+               # Notify external application via UDP
+               if( $wgRC2UDPAddress && ( !$this->mAttribs['rc_bot'] || !$wgRC2UDPOmitBots ) ) {
+                       self::sendToUDP( $this->getIRCLine() );
+               }
+       }
 
-               # Notify extensions
-               wfRunHooks( 'RecentChange_save', array( &$this ) );
+       /**
+        * Send some text to UDP.
+        * @see RecentChange::cleanupForIRC
+        * @param $line String: text to send
+        * @param $address String: defaults to $wgRC2UDPAddress.
+        * @param $prefix String: defaults to $wgRC2UDPPrefix.
+        * @param $port Int: defaults to $wgRC2UDPPort. (Since 1.17)
+        * @return Boolean: success
+        */
+       public static function sendToUDP( $line, $address = '', $prefix = '', $port = '' ) {
+               global $wgRC2UDPAddress, $wgRC2UDPPrefix, $wgRC2UDPPort;
+               # Assume default for standard RC case
+               $address = $address ? $address : $wgRC2UDPAddress;
+               $prefix = $prefix ? $prefix : $wgRC2UDPPrefix;
+               $port = $port ? $port : $wgRC2UDPPort;
+               # Notify external application via UDP
+               if( $address ) {
+                       $conn = socket_create( AF_INET, SOCK_DGRAM, SOL_UDP );
+                       if( $conn ) {
+                               $line = $prefix . $line;
+                               wfDebug( __METHOD__ . ": sending UDP line: $line\n" );
+                               socket_sendto( $conn, $line, strlen($line), 0, $address, $port );
+                               socket_close( $conn );
+                               return true;
+                       } else {
+                               wfDebug( __METHOD__ . ": failed to create UDP socket\n" );
+                       }
+               }
+               return false;
+       }
+       
+       /**
+        * Remove newlines, carriage returns and decode html entites
+        * @param $text String
+        * @return String
+        */
+       public static function cleanupForIRC( $text ) {
+               return Sanitizer::decodeCharReferences( str_replace( array( "\n", "\r" ), array( "", "" ), $text ) );
        }
 
        /**
         * Mark a given change as patrolled
         *
-        * @param mixed $change RecentChange or corresponding rc_id
-        * @returns integer number of affected rows
+        * @param $change Mixed: RecentChange or corresponding rc_id
+        * @param $auto Boolean: for automatic patrol
+        * @return Array See doMarkPatrolled(), or null if $change is not an existing rc_id
+        */
+       public static function markPatrolled( $change, $auto = false ) {
+               $change = $change instanceof RecentChange
+                       ? $change
+                       : RecentChange::newFromId($change);
+               if( !$change instanceof RecentChange ) {
+                       return null;
+               }
+               return $change->doMarkPatrolled( $auto );
+       }
+       
+       /**
+        * Mark this RecentChange as patrolled
+        *
+        * NOTE: Can also return 'rcpatroldisabled', 'hookaborted' and 'markedaspatrollederror-noautopatrol' as errors
+        * @param $auto Boolean: for automatic patrol
+        * @return array of permissions errors, see Title::getUserPermissionsErrors()
         */
-       public static function markPatrolled( $change ) {
-               $rcid = $change instanceof RecentChange
-                       ? $change->mAttribs['rc_id']
-                       : $change;
+       public function doMarkPatrolled( $auto = false ) {
+               global $wgUser, $wgUseRCPatrol, $wgUseNPPatrol;
+               $errors = array();
+               // If recentchanges patrol is disabled, only new pages
+               // can be patrolled
+               if( !$wgUseRCPatrol && ( !$wgUseNPPatrol || $this->getAttribute('rc_type') != RC_NEW ) ) {
+                       $errors[] = array('rcpatroldisabled');
+               }
+               // Automatic patrol needs "autopatrol", ordinary patrol needs "patrol"
+               $right = $auto ? 'autopatrol' : 'patrol';
+               $errors = array_merge( $errors, $this->getTitle()->getUserPermissionsErrors( $right, $wgUser ) );
+               if( !wfRunHooks('MarkPatrolled', array($this->getAttribute('rc_id'), &$wgUser, false)) ) {
+                       $errors[] = array('hookaborted');
+               }
+               // Users without the 'autopatrol' right can't patrol their
+               // own revisions
+               if( $wgUser->getName() == $this->getAttribute('rc_user_text') && !$wgUser->isAllowed('autopatrol') ) {
+                       $errors[] = array('markedaspatrollederror-noautopatrol');
+               }
+               if( $errors ) {
+                       return $errors;
+               }
+               // If the change was patrolled already, do nothing
+               if( $this->getAttribute('rc_patrolled') ) {
+                       return array();
+               }
+               // Actually set the 'patrolled' flag in RC
+               $this->reallyMarkPatrolled();
+               // Log this patrol event
+               PatrolLog::record( $this, $auto );
+               wfRunHooks( 'MarkPatrolledComplete', array($this->getAttribute('rc_id'), &$wgUser, false) );
+               return array();
+       }
+       
+       /**
+        * Mark this RecentChange patrolled, without error checking
+        * @return Integer: number of affected rows
+        */
+       public function reallyMarkPatrolled() {
                $dbw = wfGetDB( DB_MASTER );
                $dbw->update(
                        'recentchanges',
@@ -256,7 +321,7 @@ class RecentChange
                                'rc_patrolled' => 1
                        ),
                        array(
-                               'rc_id' => $rcid
+                               'rc_id' => $this->getAttribute('rc_id')
                        ),
                        __METHOD__
                );
@@ -264,54 +329,51 @@ class RecentChange
        }
 
        # Makes an entry in the database corresponding to an edit
-       public static function notifyEdit( $timestamp, &$title, $minor, &$user, $comment,
-               $oldId, $lastTimestamp, $bot, $ip = '', $oldSize = 0, $newSize = 0,
-               $newId = 0)
+       public static function notifyEdit( $timestamp, &$title, $minor, &$user, $comment, $oldId,
+               $lastTimestamp, $bot, $ip='', $oldSize=0, $newSize=0, $newId=0, $patrol=0 )
        {
-               if ( !$ip ) {
+               if( !$ip ) {
                        $ip = wfGetIP();
-                       if ( !$ip ) {
-                               $ip = '';
-                       }
+                       if( !$ip ) $ip = '';
                }
 
                $rc = new RecentChange;
                $rc->mAttribs = array(
-                       'rc_timestamp'  => $timestamp,
-                       'rc_cur_time'   => $timestamp,
-                       'rc_namespace'  => $title->getNamespace(),
-                       'rc_title'      => $title->getDBkey(),
-                       'rc_type'       => RC_EDIT,
-                       'rc_minor'      => $minor ? 1 : 0,
-                       'rc_cur_id'     => $title->getArticleID(),
-                       'rc_user'       => $user->getID(),
-                       'rc_user_text'  => $user->getName(),
-                       'rc_comment'    => $comment,
-                       'rc_this_oldid' => $newId,
-                       'rc_last_oldid' => $oldId,
-                       'rc_bot'        => $bot ? 1 : 0,
-                       'rc_moved_to_ns'        => 0,
-                       'rc_moved_to_title'     => '',
-                       'rc_ip'         => $ip,
-                       'rc_patrolled'  => 0,
-                       'rc_new'        => 0,  # obsolete
-                       'rc_old_len'    => $oldSize,
-                       'rc_new_len'    => $newSize,
-                       'rc_deleted'    => 0,
-                       'rc_logid'              => 0,
-                       'rc_log_type'   => null,
-                       'rc_log_action' => '',
-                       'rc_params'             => ''
+                       'rc_timestamp'  => $timestamp,
+                       'rc_cur_time'   => $timestamp,
+                       'rc_namespace'  => $title->getNamespace(),
+                       'rc_title'      => $title->getDBkey(),
+                       'rc_type'       => RC_EDIT,
+                       'rc_minor'      => $minor ? 1 : 0,
+                       'rc_cur_id'     => $title->getArticleID(),
+                       'rc_user'       => $user->getId(),
+                       'rc_user_text'  => $user->getName(),
+                       'rc_comment'    => $comment,
+                       'rc_this_oldid' => $newId,
+                       'rc_last_oldid' => $oldId,
+                       'rc_bot'        => $bot ? 1 : 0,
+                       'rc_moved_to_ns' => 0,
+                       'rc_moved_to_title' => '',
+                       'rc_ip'         => $ip,
+                       'rc_patrolled'  => intval($patrol),
+                       'rc_new'        => 0,  # obsolete
+                       'rc_old_len'    => $oldSize,
+                       'rc_new_len'    => $newSize,
+                       'rc_deleted'    => 0,
+                       'rc_logid'      => 0,
+                       'rc_log_type'   => null,
+                       'rc_log_action' => '',
+                       'rc_params'     => ''
                );
 
                $rc->mExtra =  array(
-                       'prefixedDBkey' => $title->getPrefixedDBkey(),
+                       'prefixedDBkey' => $title->getPrefixedDBkey(),
                        'lastTimestamp' => $lastTimestamp,
                        'oldSize'       => $oldSize,
                        'newSize'       => $newSize,
                );
                $rc->save();
-               return( $rc->mAttribs['rc_id'] );
+               return $rc;
        }
 
        /**
@@ -320,13 +382,11 @@ class RecentChange
         * @todo Document parameters and return
         */
        public static function notifyNew( $timestamp, &$title, $minor, &$user, $comment, $bot,
-         $ip='', $size = 0, $newId = 0 )
+               $ip='', $size=0, $newId=0, $patrol=0 )
        {
-               if ( !$ip ) {
+               if( !$ip ) {
                        $ip = wfGetIP();
-                       if ( !$ip ) {
-                               $ip = '';
-                       }
+                       if( !$ip ) $ip = '';
                }
 
                $rc = new RecentChange;
@@ -338,7 +398,7 @@ class RecentChange
                        'rc_type'           => RC_NEW,
                        'rc_minor'          => $minor ? 1 : 0,
                        'rc_cur_id'         => $title->getArticleID(),
-                       'rc_user'           => $user->getID(),
+                       'rc_user'           => $user->getId(),
                        'rc_user_text'      => $user->getName(),
                        'rc_comment'        => $comment,
                        'rc_this_oldid'     => $newId,
@@ -347,72 +407,69 @@ class RecentChange
                        'rc_moved_to_ns'    => 0,
                        'rc_moved_to_title' => '',
                        'rc_ip'             => $ip,
-                       'rc_patrolled'      => 0,
-                       'rc_new'                => 1, # obsolete
+                       'rc_patrolled'      => intval($patrol),
+                       'rc_new'            => 1, # obsolete
                        'rc_old_len'        => 0,
-                       'rc_new_len'        => $size,
-                       'rc_deleted'            => 0,
-                       'rc_logid'                      => 0,
-                       'rc_log_type'           => null,
-                       'rc_log_action'         => '',
-                       'rc_params'                     => ''
+                       'rc_new_len'        => $size,
+                       'rc_deleted'        => 0,
+                       'rc_logid'          => 0,
+                       'rc_log_type'       => null,
+                       'rc_log_action'     => '',
+                       'rc_params'         => ''
                );
 
                $rc->mExtra =  array(
-                       'prefixedDBkey' => $title->getPrefixedDBkey(),
+                       'prefixedDBkey' => $title->getPrefixedDBkey(),
                        'lastTimestamp' => 0,
                        'oldSize' => 0,
                        'newSize' => $size
                );
                $rc->save();
-               return( $rc->mAttribs['rc_id'] );
+               return $rc;     
        }
 
        # Makes an entry in the database corresponding to a rename
        public static function notifyMove( $timestamp, &$oldTitle, &$newTitle, &$user, $comment, $ip='', $overRedir = false )
        {
                global $wgRequest;
-
-               if ( !$ip ) {
+               if( !$ip ) {
                        $ip = wfGetIP();
-                       if ( !$ip ) {
-                               $ip = '';
-                       }
+                       if( !$ip ) $ip = '';
                }
 
                $rc = new RecentChange;
                $rc->mAttribs = array(
-                       'rc_timestamp'  => $timestamp,
-                       'rc_cur_time'   => $timestamp,
-                       'rc_namespace'  => $oldTitle->getNamespace(),
-                       'rc_title'      => $oldTitle->getDBkey(),
-                       'rc_type'       => $overRedir ? RC_MOVE_OVER_REDIRECT : RC_MOVE,
-                       'rc_minor'      => 0,
-                       'rc_cur_id'     => $oldTitle->getArticleID(),
-                       'rc_user'       => $user->getID(),
-                       'rc_user_text'  => $user->getName(),
-                       'rc_comment'    => $comment,
-                       'rc_this_oldid' => 0,
-                       'rc_last_oldid' => 0,
-                       'rc_bot'        => $user->isAllowed( 'bot' ) ? $wgRequest->getBool( 'bot' , true ) : 0,
-                       'rc_moved_to_ns'        => $newTitle->getNamespace(),
-                       'rc_moved_to_title'     => $newTitle->getDBkey(),
-                       'rc_ip'         => $ip,
-                       'rc_new'        => 0, # obsolete
-                       'rc_patrolled'  => 1,
-                       'rc_old_len'    => NULL,
-                       'rc_new_len'    => NULL,
-                       'rc_deleted'    => 0,
-                       'rc_logid'              => 0, # notifyMove not used anymore
-                       'rc_log_type'   => null,
-                       'rc_log_action' => '',
-                       'rc_params'             => ''
+                       'rc_timestamp'  => $timestamp,
+                       'rc_cur_time'   => $timestamp,
+                       'rc_namespace'  => $oldTitle->getNamespace(),
+                       'rc_title'      => $oldTitle->getDBkey(),
+                       'rc_type'       => $overRedir ? RC_MOVE_OVER_REDIRECT : RC_MOVE,
+                       'rc_minor'      => 0,
+                       'rc_cur_id'     => $oldTitle->getArticleID(),
+                       'rc_user'       => $user->getId(),
+                       'rc_user_text'  => $user->getName(),
+                       'rc_comment'    => $comment,
+                       'rc_this_oldid' => 0,
+                       'rc_last_oldid' => 0,
+                       'rc_bot'        => $user->isAllowed( 'bot' ) ? $wgRequest->getBool( 'bot' , true ) : 0,
+                       'rc_moved_to_ns' => $newTitle->getNamespace(),
+                       'rc_moved_to_title' => $newTitle->getDBkey(),
+                       'rc_ip'         => $ip,
+                       'rc_new'        => 0, # obsolete
+                       'rc_patrolled'  => 1,
+                       'rc_old_len'    => null,
+                       'rc_new_len'    => null,
+                       'rc_deleted'    => 0,
+                       'rc_logid'      => 0, # notifyMove not used anymore
+                       'rc_log_type'   => null,
+                       'rc_log_action' => '',
+                       'rc_params'     => ''
                );
 
                $rc->mExtra = array(
-                       'prefixedDBkey' => $oldTitle->getPrefixedDBkey(),
+                       'prefixedDBkey' => $oldTitle->getPrefixedDBkey(),
                        'lastTimestamp' => 0,
-                       'prefixedMoveTo'        => $newTitle->getPrefixedDBkey()
+                       'prefixedMoveTo' => $newTitle->getPrefixedDBkey()
                );
                $rc->save();
        }
@@ -425,70 +482,74 @@ class RecentChange
                RecentChange::notifyMove( $timestamp, $oldTitle, $newTitle, $user, $comment, $ip, true );
        }
 
-       # A log entry is different to an edit in that previous revisions are not kept
-       public static function notifyLog( $timestamp, &$title, &$user, $comment, $ip='',
-          $type, $action, $target, $logComment, $params, $newId=0 )
+       public static function notifyLog( $timestamp, &$title, &$user, $actionComment, $ip='', $type, 
+               $action, $target, $logComment, $params, $newId=0 )
        {
-               global $wgRequest;
+               global $wgLogRestrictions;
+               # Don't add private logs to RC!
+               if( isset($wgLogRestrictions[$type]) && $wgLogRestrictions[$type] != '*' ) {
+                       return false;
+               }
+               $rc = self::newLogEntry( $timestamp, $title, $user, $actionComment, $ip, $type, $action,
+                       $target, $logComment, $params, $newId );
+               $rc->save();
+               return true;
+       }
 
-               if ( !$ip ) {
+       public static function newLogEntry( $timestamp, &$title, &$user, $actionComment, $ip='',
+               $type, $action, $target, $logComment, $params, $newId=0 )
+       {
+               global $wgRequest;
+               if( !$ip ) {
                        $ip = wfGetIP();
-                       if ( !$ip ) {
-                               $ip = '';
-                       }
+                       if( !$ip ) $ip = '';
                }
 
                $rc = new RecentChange;
                $rc->mAttribs = array(
-                       'rc_timestamp'  => $timestamp,
-                       'rc_cur_time'   => $timestamp,
-                       'rc_namespace'  => $target->getNamespace(),
-                       'rc_title'      => $target->getDBkey(),
-                       'rc_type'       => RC_LOG,
-                       'rc_minor'      => 0,
-                       'rc_cur_id'     => $target->getArticleID(),
-                       'rc_user'       => $user->getID(),
-                       'rc_user_text'  => $user->getName(),
-                       'rc_comment'    => $logComment,
-                       'rc_this_oldid' => 0,
-                       'rc_last_oldid' => 0,
-                       'rc_bot'        => $user->isAllowed( 'bot' ) ? $wgRequest->getBool( 'bot' , true ) : 0,
-                       'rc_moved_to_ns'        => 0,
-                       'rc_moved_to_title'     => '',
-                       'rc_ip' => $ip,
-                       'rc_patrolled' => 1,
-                       'rc_new'        => 0, # obsolete
-                       'rc_old_len'    => NULL,
-                       'rc_new_len'    => NULL,
-                       'rc_deleted'    => 0,
-                       'rc_logid'              => $newId,
-                       'rc_log_type'   => $type,
-                       'rc_log_action' => $action,
-                       'rc_params'             => $params
+                       'rc_timestamp'  => $timestamp,
+                       'rc_cur_time'   => $timestamp,
+                       'rc_namespace'  => $target->getNamespace(),
+                       'rc_title'      => $target->getDBkey(),
+                       'rc_type'       => RC_LOG,
+                       'rc_minor'      => 0,
+                       'rc_cur_id'     => $target->getArticleID(),
+                       'rc_user'       => $user->getId(),
+                       'rc_user_text'  => $user->getName(),
+                       'rc_comment'    => $logComment,
+                       'rc_this_oldid' => 0,
+                       'rc_last_oldid' => 0,
+                       'rc_bot'        => $user->isAllowed( 'bot' ) ? $wgRequest->getBool( 'bot', true ) : 0,
+                       'rc_moved_to_ns' => 0,
+                       'rc_moved_to_title' => '',
+                       'rc_ip'         => $ip,
+                       'rc_patrolled'  => 1,
+                       'rc_new'        => 0, # obsolete
+                       'rc_old_len'    => null,
+                       'rc_new_len'    => null,
+                       'rc_deleted'    => 0,
+                       'rc_logid'      => $newId,
+                       'rc_log_type'   => $type,
+                       'rc_log_action' => $action,
+                       'rc_params'     => $params
                );
                $rc->mExtra =  array(
-                       'prefixedDBkey' => $title->getPrefixedDBkey(),
+                       'prefixedDBkey' => $title->getPrefixedDBkey(),
                        'lastTimestamp' => 0,
-                       'logType' => $type,
-                       'logAction' => $action,
-                       'logComment' => $logComment,
-                       'logTarget' => $target,
-                       'logParams' => $params
+                       'actionComment' => $actionComment, // the comment appended to the action, passed from LogPage
                );
-               $rc->save();
+               return $rc;
        }
 
        # Initialises the members of this object from a mysql row object
-       function loadFromRow( $row )
-       {
+       public function loadFromRow( $row ) {
                $this->mAttribs = get_object_vars( $row );
-               $this->mAttribs["rc_timestamp"] = wfTimestamp(TS_MW, $this->mAttribs["rc_timestamp"]);
-               $this->mExtra = array();
+               $this->mAttribs['rc_timestamp'] = wfTimestamp(TS_MW, $this->mAttribs['rc_timestamp']);
+               $this->mAttribs['rc_deleted'] = $row->rc_deleted; // MUST be set
        }
 
        # Makes a pseudo-RC entry from a cur row
-       function loadFromCurRow( $row )
-       {
+       public function loadFromCurRow( $row ) {
                $this->mAttribs = array(
                        'rc_timestamp' => wfTimestamp(TS_MW, $row->rev_timestamp),
                        'rc_cur_time' => $row->rev_timestamp,
@@ -515,33 +576,33 @@ class RecentChange
                        'rc_log_type' => isset($row->rc_log_type) ? $row->rc_log_type : null,
                        'rc_log_action' => isset($row->rc_log_action) ? $row->rc_log_action : null,
                        'rc_log_id' => isset($row->rc_log_id) ? $row->rc_log_id: 0,
-                       // this one REALLY should be set...
-                       'rc_deleted' => isset($row->rc_deleted) ? $row->rc_deleted: 0,
+                       'rc_deleted' => $row->rc_deleted // MUST be set
                );
-
-               $this->mExtra = array();
        }
 
        /**
         * Get an attribute value
         *
-        * @param $name Attribute name
+        * @param $name String Attribute name
         * @return mixed
         */
        public function getAttribute( $name ) {
-               return isset( $this->mAttribs[$name] ) ? $this->mAttribs[$name] : NULL;
+               return isset( $this->mAttribs[$name] ) ? $this->mAttribs[$name] : null;
+       }
+
+       public function getAttributes() {
+               return $this->mAttribs;
        }
 
        /**
         * Gets the end part of the diff URL associated with this object
         * Blank if no diff link should be displayed
         */
-       function diffLinkTrail( $forceCur )
-       {
-               if ( $this->mAttribs['rc_type'] == RC_EDIT ) {
+       public function diffLinkTrail( $forceCur ) {
+               if( $this->mAttribs['rc_type'] == RC_EDIT ) {
                        $trail = "curid=" . (int)($this->mAttribs['rc_cur_id']) .
                                "&oldid=" . (int)($this->mAttribs['rc_last_oldid']);
-                       if ( $forceCur ) {
+                       if( $forceCur ) {
                                $trail .= '&diff=0' ;
                        } else {
                                $trail .= '&diff=' . (int)($this->mAttribs['rc_this_oldid']);
@@ -552,49 +613,45 @@ class RecentChange
                return $trail;
        }
 
-       function cleanupForIRC( $text ) {
-               return str_replace(array("\n", "\r"), array("", ""), $text);
-       }
-
-       function getIRCLine() {
-               global $wgUseRCPatrol;
+       public function getIRCLine() {
+               global $wgUseRCPatrol, $wgUseNPPatrol, $wgRC2UDPInterwikiPrefix, $wgLocalInterwiki;
 
                // FIXME: Would be good to replace these 2 extract() calls with something more explicit
                // e.g. list ($rc_type, $rc_id) = array_values ($this->mAttribs); [or something like that]
                extract($this->mAttribs);
                extract($this->mExtra);
 
-               $titleObj =& $this->getTitle();
-               if ( $rc_type == RC_LOG ) {
-                       $title = MWNamespace::getCanonicalName( $titleObj->getNamespace() ) . $titleObj->getText();
+               if( $rc_type == RC_LOG ) {
+                       $titleObj = Title::newFromText( "Log/$rc_log_type", NS_SPECIAL );
                } else {
-                       $title = $titleObj->getPrefixedText();
+                       $titleObj =& $this->getTitle();
                }
-               $title = $this->cleanupForIRC( $title );
-
-               $bad = array("\n", "\r");
-               $empty = array("", "");
                $title = $titleObj->getPrefixedText();
-               $title = str_replace($bad, $empty, $title);
+               $title = self::cleanupForIRC( $title );
 
-               // FIXME: *HACK* these should be getFullURL(), hacked for SSL madness --brion 2005-12-26
-               if ( $rc_type == RC_LOG ) {
+               if( $rc_type == RC_LOG ) {
                        $url = '';
-               } elseif ( $rc_new && $wgUseRCPatrol ) {
-                       $url = $titleObj->getInternalURL("rcid=$rc_id");
-               } else if ( $rc_new ) {
-                       $url = $titleObj->getInternalURL();
-               } else if ( $wgUseRCPatrol ) {
-                       $url = $titleObj->getInternalURL("diff=$rc_this_oldid&oldid=$rc_last_oldid&rcid=$rc_id");
                } else {
-                       $url = $titleObj->getInternalURL("diff=$rc_this_oldid&oldid=$rc_last_oldid");
+                       if( $rc_type == RC_NEW ) {
+                               $url = "oldid=$rc_this_oldid";
+                       } else {
+                               $url = "diff=$rc_this_oldid&oldid=$rc_last_oldid";
+                       }
+                       if( $wgUseRCPatrol || ($rc_type == RC_NEW && $wgUseNPPatrol) ) {
+                               $url .= "&rcid=$rc_id";
+                       }
+                       // XXX: *HACK* this should use getFullURL(), hacked for SSL madness --brion 2005-12-26
+                       // XXX: *HACK^2* the preg_replace() undoes much of what getInternalURL() does, but we 
+                       // XXX: need to call it so that URL paths on the Wikimedia secure server can be fixed
+                       // XXX: by a custom GetInternalURL hook --vyznev 2008-12-10
+                       $url = preg_replace( '/title=[^&]*&/', '', $titleObj->getInternalURL( $url ) );
                }
 
-               if ( isset( $oldSize ) && isset( $newSize ) ) {
+               if( isset( $oldSize ) && isset( $newSize ) ) {
                        $szdiff = $newSize - $oldSize;
-                       if ($szdiff < -500) {
+                       if($szdiff < -500) {
                                $szdiff = "\002$szdiff\002";
-                       } elseif ($szdiff >= 0) {
+                       } elseif($szdiff >= 0) {
                                $szdiff = '+' . $szdiff ;
                        }
                        $szdiff = '(' . $szdiff . ')' ;
@@ -602,20 +659,39 @@ class RecentChange
                        $szdiff = '';
                }
 
-               $user = $this->cleanupForIRC( $rc_user_text );
+               $user = self::cleanupForIRC( $rc_user_text );
 
-               if ( $rc_type == RC_LOG ) {
-                       $logTargetText = $logTarget->getPrefixedText();
-                       $comment = $this->cleanupForIRC( str_replace( $logTargetText, "\00302$logTargetText\00310", $rc_comment ) );
-                       $flag = $logAction;
+               if( $rc_type == RC_LOG ) {
+                       $targetText = $this->getTitle()->getPrefixedText();
+                       $comment = self::cleanupForIRC( str_replace("[[$targetText]]","[[\00302$targetText\00310]]",$actionComment) );
+                       $flag = $rc_log_action;
                } else {
-                       $comment = $this->cleanupForIRC( $rc_comment );
-                       $flag = ($rc_minor ? "M" : "") . ($rc_new ? "N" : "");
+                       $comment = self::cleanupForIRC( $rc_comment );
+                       $flag = '';
+                       if( !$rc_patrolled && ($wgUseRCPatrol || $rc_new && $wgUseNPPatrol) ) {
+                               $flag .= '!';
+                       }
+                       $flag .= ($rc_new ? "N" : "") . ($rc_minor ? "M" : "") . ($rc_bot ? "B" : "");
+               }
+
+               if ( $wgRC2UDPInterwikiPrefix === true && $wgLocalInterwiki !== false ) {
+                       $prefix = $wgLocalInterwiki;
+               } elseif ( $wgRC2UDPInterwikiPrefix ) {
+                       $prefix = $wgRC2UDPInterwikiPrefix;
+               } else {
+                       $prefix = false;
+               }
+               if ( $prefix !== false ) {
+                       $titleString = "\00314[[\00303$prefix:\00307$title\00314]]";
+               } else {
+                       $titleString = "\00314[[\00307$title\00314]]";
                }
+               
                # see http://www.irssi.org/documentation/formats for some colour codes. prefix is \003,
                # no colour (\003) switches back to the term default
-               $fullString = "\00314[[\00307$title\00314]]\0034 $flag\00310 " .
+               $fullString = "$titleString\0034 $flag\00310 " .
                              "\00302$url\003 \0035*\003 \00303$user\003 \0035*\003 $szdiff \00310$comment\003\n";
+                       
                return $fullString;
        }
 
@@ -623,32 +699,16 @@ class RecentChange
         * Returns the change size (HTML).
         * The lengths can be given optionally.
         */
-       function getCharacterDifference( $old = 0, $new = 0 ) {
-               global $wgRCChangedSizeThreshold, $wgLang;
-
+       public function getCharacterDifference( $old = 0, $new = 0 ) {
                if( $old === 0 ) {
                        $old = $this->mAttribs['rc_old_len'];
                }
                if( $new === 0 ) {
                        $new = $this->mAttribs['rc_new_len'];
                }
-
-               if( $old === NULL || $new === NULL ) {
+               if( $old === null || $new === null ) {
                        return '';
                }
-
-               $szdiff = $new - $old;
-               $formatedSize = wfMsgExt( 'rc-change-size', array( 'parsemag', 'escape'),
-                       $wgLang->formatNum($szdiff) );
-
-               if( $szdiff < $wgRCChangedSizeThreshold ) {
-                       return '<strong class=\'mw-plusminus-neg\'>(' . $formatedSize . ')</strong>';
-               } elseif( $szdiff === 0 ) {
-                       return '<span class=\'mw-plusminus-null\'>(' . $formatedSize . ')</span>';
-               } elseif( $szdiff > 0 ) {
-                       return '<span class=\'mw-plusminus-pos\'>(+' . $formatedSize . ')</span>';
-               } else {
-                       return '<span class=\'mw-plusminus-neg\'>(' . $formatedSize . ')</span>';
-               }
+               return ChangesList::showCharacterDifference( $old, $new );
        }
 }