Fix bug: max-slave-length => max-slave-lag
[lhc/web/wiklou.git] / includes / Parser.php
index 75050c9..afda767 100644 (file)
@@ -82,14 +82,17 @@ class Parser
        const OT_WIKI = 2;
        const OT_PREPROCESS = 3;
        const OT_MSG = 3;
-       
+
+       // Marker Suffix needs to be accessible staticly.
+       const MARKER_SUFFIX = "-QINU\x7f";
+
        /**#@+
         * @private
         */
        # Persistent:
        var $mTagHooks, $mTransparentTagHooks, $mFunctionHooks, $mFunctionSynonyms, $mVariables,
-               $mImageParams, $mImageParamsMagicArray, $mStripList, $mMarkerSuffix,
-               $mExtLinkBracketedRegex, $mPreprocessor, $mDefaultStripList, $mVarCache, $mConf;
+               $mImageParams, $mImageParamsMagicArray, $mStripList, $mMarkerIndex, $mPreprocessor,
+               $mExtLinkBracketedRegex, $mDefaultStripList, $mVarCache, $mConf;
 
 
        # Cleared with clearState():
@@ -98,7 +101,7 @@ class Parser
        var $mInterwikiLinkHolders, $mLinkHolders;
        var $mIncludeSizes, $mPPNodeCount, $mDefaultSort;
        var $mTplExpandCache; // empty-frame expansion cache
-       var $mTplRedirCache, $mTplDomCache, $mHeadings;
+       var $mTplRedirCache, $mTplDomCache, $mHeadings, $mDoubleUnderscores;
 
        # Temporary
        # These are variables reset at least once per parse regardless of $clearState
@@ -124,7 +127,6 @@ class Parser
                $this->mFunctionHooks = array();
                $this->mFunctionSynonyms = array( 0 => array(), 1 => array() );
                $this->mDefaultStripList = $this->mStripList = array( 'nowiki', 'gallery' );
-               $this->mMarkerSuffix = "-QINU\x7f";
                $this->mExtLinkBracketedRegex = '/\[(\b(' . wfUrlProtocols() . ')'.
                        '[^][<>"\\x00-\\x20\\x7F]+) *([^\]\\x0a\\x0d]*?)\]/S';
                $this->mVarCache = array();
@@ -133,6 +135,7 @@ class Parser
                } else {
                        $this->mPreprocessorClass = 'Preprocessor_DOM';
                }
+               $this->mMarkerIndex = 0;
                $this->mFirstCall = true;
        }
        
@@ -146,51 +149,9 @@ class Parser
                $this->mFirstCall = false;
                
                wfProfileIn( __METHOD__ );
-               global $wgAllowDisplayTitle, $wgAllowSlowParserFunctions;
 
                $this->setHook( 'pre', array( $this, 'renderPreTag' ) );
-
-               # Syntax for arguments (see self::setFunctionHook):
-               #  "name for lookup in localized magic words array",
-               #  function callback,
-               #  optional SFH_NO_HASH to omit the hash from calls (e.g. {{int:...}
-               #    instead of {{#int:...}})
-               $this->setFunctionHook( 'int',              array( 'CoreParserFunctions', 'intFunction'      ), SFH_NO_HASH );
-               $this->setFunctionHook( 'ns',               array( 'CoreParserFunctions', 'ns'               ), SFH_NO_HASH );
-               $this->setFunctionHook( 'urlencode',        array( 'CoreParserFunctions', 'urlencode'        ), SFH_NO_HASH );
-               $this->setFunctionHook( 'lcfirst',          array( 'CoreParserFunctions', 'lcfirst'          ), SFH_NO_HASH );
-               $this->setFunctionHook( 'ucfirst',          array( 'CoreParserFunctions', 'ucfirst'          ), SFH_NO_HASH );
-               $this->setFunctionHook( 'lc',               array( 'CoreParserFunctions', 'lc'               ), SFH_NO_HASH );
-               $this->setFunctionHook( 'uc',               array( 'CoreParserFunctions', 'uc'               ), SFH_NO_HASH );
-               $this->setFunctionHook( 'localurl',         array( 'CoreParserFunctions', 'localurl'         ), SFH_NO_HASH );
-               $this->setFunctionHook( 'localurle',        array( 'CoreParserFunctions', 'localurle'        ), SFH_NO_HASH );
-               $this->setFunctionHook( 'fullurl',          array( 'CoreParserFunctions', 'fullurl'          ), SFH_NO_HASH );
-               $this->setFunctionHook( 'fullurle',         array( 'CoreParserFunctions', 'fullurle'         ), SFH_NO_HASH );
-               $this->setFunctionHook( 'formatnum',        array( 'CoreParserFunctions', 'formatnum'        ), SFH_NO_HASH );
-               $this->setFunctionHook( 'grammar',          array( 'CoreParserFunctions', 'grammar'          ), SFH_NO_HASH );
-               $this->setFunctionHook( 'plural',           array( 'CoreParserFunctions', 'plural'           ), SFH_NO_HASH );
-               $this->setFunctionHook( 'numberofpages',    array( 'CoreParserFunctions', 'numberofpages'    ), SFH_NO_HASH );
-               $this->setFunctionHook( 'numberofusers',    array( 'CoreParserFunctions', 'numberofusers'    ), SFH_NO_HASH );
-               $this->setFunctionHook( 'numberofarticles', array( 'CoreParserFunctions', 'numberofarticles' ), SFH_NO_HASH );
-               $this->setFunctionHook( 'numberoffiles',    array( 'CoreParserFunctions', 'numberoffiles'    ), SFH_NO_HASH );
-               $this->setFunctionHook( 'numberofadmins',   array( 'CoreParserFunctions', 'numberofadmins'   ), SFH_NO_HASH );
-               $this->setFunctionHook( 'numberofedits',    array( 'CoreParserFunctions', 'numberofedits'    ), SFH_NO_HASH );
-               $this->setFunctionHook( 'language',         array( 'CoreParserFunctions', 'language'         ), SFH_NO_HASH );
-               $this->setFunctionHook( 'padleft',          array( 'CoreParserFunctions', 'padleft'          ), SFH_NO_HASH );
-               $this->setFunctionHook( 'padright',         array( 'CoreParserFunctions', 'padright'         ), SFH_NO_HASH );
-               $this->setFunctionHook( 'anchorencode',     array( 'CoreParserFunctions', 'anchorencode'     ), SFH_NO_HASH );
-               $this->setFunctionHook( 'special',          array( 'CoreParserFunctions', 'special'          ) );
-               $this->setFunctionHook( 'defaultsort',      array( 'CoreParserFunctions', 'defaultsort'      ), SFH_NO_HASH );
-               $this->setFunctionHook( 'filepath',         array( 'CoreParserFunctions', 'filepath'         ), SFH_NO_HASH );
-               $this->setFunctionHook( 'tag',              array( 'CoreParserFunctions', 'tagObj'           ), SFH_OBJECT_ARGS );
-
-               if ( $wgAllowDisplayTitle ) {
-                       $this->setFunctionHook( 'displaytitle', array( 'CoreParserFunctions', 'displaytitle' ), SFH_NO_HASH );
-               }
-               if ( $wgAllowSlowParserFunctions ) {
-                       $this->setFunctionHook( 'pagesinnamespace', array( 'CoreParserFunctions', 'pagesinnamespace' ), SFH_NO_HASH );
-               }
-
+               CoreParserFunctions::register( $this );
                $this->initialiseVariables();
 
                wfRunHooks( 'ParserFirstCallInit', array( &$this ) );
@@ -242,6 +203,7 @@ class Parser
                # Changed to \x7f to allow XML double-parsing -- TS
                $this->mUniqPrefix = "\x7fUNIQ" . Parser::getRandomString();
 
+
                # Clear these on every parse, bug 4549
                $this->mTplExpandCache = $this->mTplRedirCache = $this->mTplDomCache = array();
 
@@ -254,6 +216,7 @@ class Parser
                $this->mPPNodeCount = 0;
                $this->mDefaultSort = false;
                $this->mHeadings = array();
+               $this->mDoubleUnderscores = array();
 
                # Fix cloning
                if ( isset( $this->mPreprocessor ) && $this->mPreprocessor->parser !== $this ) {
@@ -357,6 +320,7 @@ class Parser
                        '/(.) (?=\\?|:|;|!|%|\\302\\273)/' => '\\1&nbsp;\\2',
                        # french spaces, Guillemet-right
                        '/(\\302\\253) /' => '\\1&nbsp;',
+                       '/&nbsp;(!\s*important)/' => ' \\1', #Beware of CSS magic word !important, bug #11874.
                );
                $text = preg_replace( array_keys($fixtags), array_values($fixtags), $text );
 
@@ -498,7 +462,13 @@ class Parser
 
        function getFunctionLang() {
                global $wgLang, $wgContLang;
-               return $this->mOptions->getInterfaceMessage() ? $wgLang : $wgContLang;
+
+               $target = $this->mOptions->getTargetLanguage();
+               if ( $target !== null ) {
+                       return $target;
+               } else {
+                       return $this->mOptions->getInterfaceMessage() ? $wgLang : $wgContLang;
+               }
        }
 
        /**
@@ -514,7 +484,7 @@ class Parser
 
        /**
         * Replaces all occurrences of HTML-style comments and the given tags
-        * in the text with a random marker and returns teh next text. The output
+        * in the text with a random marker and returns the next text. The output
         * parameter $matches will be an associative array filled with data in
         * the form:
         *   'UNIQ-xxxxx' => array(
@@ -558,7 +528,7 @@ class Parser
                                $inside     = $p[4];
                        }
 
-                       $marker = "$uniq_prefix-$element-" . sprintf('%08X', $n++) . $this->mMarkerSuffix;
+                       $marker = "$uniq_prefix-$element-" . sprintf('%08X', $n++) . self::MARKER_SUFFIX;
                        $stripped .= $marker;
 
                        if ( $close === '/>' ) {
@@ -650,9 +620,8 @@ class Parser
         * @private
         */
        function insertStripItem( $text ) {
-               static $n = 0;
-               $rnd = "{$this->mUniqPrefix}-item-$n-{$this->mMarkerSuffix}";
-               ++$n;
+               $rnd = "{$this->mUniqPrefix}-item-{$this->mMarkerIndex}-" . self::MARKER_SUFFIX;
+               $this->mMarkerIndex++;
                $this->mStripState->general->setPair( $rnd, $text );
                return $rnd;
        }
@@ -990,8 +959,7 @@ class Parser
 
                $text = preg_replace( '/(^|\n)-----*/', '\\1<hr />', $text );
 
-               $text = $this->stripToc( $text );
-               $this->stripNoGallery( $text );
+               $text = $this->doDoubleUnderscore( $text );
                $text = $this->doHeadings( $text );
                if($this->mOptions->getUseDynamicDates()) {
                        $df =& DateFormatter::getInstance();
@@ -1046,9 +1014,9 @@ class Parser
                                ' ' => '',
                                'x' => 'X',
                        ));
-                       $titleObj = SpecialPage::getTitleFor( 'Booksources' );
+                       $titleObj = SpecialPage::getTitleFor( 'Booksources', $num );
                        $text = '<a href="' .
-                               $titleObj->escapeLocalUrl( "isbn=$num" ) .
+                               $titleObj->escapeLocalUrl() .
                                "\" class=\"internal\">ISBN $isbn</a>";
                } else {
                        if ( substr( $m[0], 0, 3 ) == 'RFC' ) {
@@ -2454,14 +2422,6 @@ class Parser
                                return wfEscapeWikiText( $this->mTitle->getBaseText() );
                        case 'basepagenamee':
                                return wfUrlEncode( str_replace( ' ', '_', $this->mTitle->getBaseText() ) );
-                       case 'parentpagename':
-                               return wfEscapeWikiText( $this->mTitle->getBaseText() );
-                       case 'parentpagenamee':
-                               return wfUrlEncode( str_replace( ' ', '_', $this->mTitle->getBaseText() ) );
-                       case 'rootpagename':
-                               return wfEscapeWikiText( $this->mTitle->getRootText() );
-                       case 'rootpagenamee':
-                               return wfUrlEncode( str_replace( ' ', '_', $this->mTitle->getRootText() ) );
                        case 'talkpagename':
                                if( $this->mTitle->canTalk() ) {
                                        $talkPage = $this->mTitle->getTalkPage();
@@ -3222,13 +3182,12 @@ class Parser
         */
        function extensionSubstitution( $params, $frame ) {
                global $wgRawHtml, $wgContLang;
-               static $n = 1;
 
                $name = $frame->expand( $params['name'] );
                $attrText = !isset( $params['attr'] ) ? null : $frame->expand( $params['attr'] );
                $content = !isset( $params['inner'] ) ? null : $frame->expand( $params['inner'] );
 
-               $marker = "{$this->mUniqPrefix}-$name-" . sprintf('%08X', $n++) . $this->mMarkerSuffix;
+               $marker = "{$this->mUniqPrefix}-$name-" . sprintf('%08X', $this->mMarkerIndex++) . self::MARKER_SUFFIX;
                
                if ( $this->ot['html'] ) {
                        $name = strtolower( $name );
@@ -3310,32 +3269,11 @@ class Parser
        }
 
        /**
-        * Detect __NOGALLERY__ magic word and set a placeholder
+        * Strip double-underscore items like __NOGALLERY__ and __NOTOC__
+        * Fills $this->mDoubleUnderscores, returns the modified text
         */
-       function stripNoGallery( &$text ) {
-               # if the string __NOGALLERY__ (not case-sensitive) occurs in the HTML,
-               # do not add TOC
-               $mw = MagicWord::get( 'nogallery' );
-               $this->mOutput->mNoGallery = $mw->matchAndRemove( $text ) ;
-       }
-
-       /**
-        * Find the first __TOC__ magic word and set a <!--MWTOC-->
-        * placeholder that will then be replaced by the real TOC in
-        * ->formatHeadings, this works because at this points real
-        * comments will have already been discarded by the sanitizer.
-        *
-        * Any additional __TOC__ magic words left over will be discarded
-        * as there can only be one TOC on the page.
-        */
-       function stripToc( $text ) {
-               # if the string __NOTOC__ (not case-sensitive) occurs in the HTML,
-               # do not add TOC
-               $mw = MagicWord::get( 'notoc' );
-               if( $mw->matchAndRemove( $text ) ) {
-                       $this->mShowToc = false;
-               }
-
+       function doDoubleUnderscore( $text ) {
+               // The position of __TOC__ needs to be recorded
                $mw = MagicWord::get( 'toc' );
                if( $mw->match( $text ) ) {
                        $this->mShowToc = true;
@@ -3347,6 +3285,27 @@ class Parser
                        // Only keep the first one.
                        $text = $mw->replace( '', $text );
                }
+
+               // Now match and remove the rest of them
+               $mwa = MagicWord::getDoubleUnderscoreArray();
+               $this->mDoubleUnderscores = $mwa->matchAndRemove( $text );
+
+               if ( isset( $this->mDoubleUnderscores['nogallery'] ) ) {
+                       $this->mOutput->mNoGallery = true;
+               }
+               if ( isset( $this->mDoubleUnderscores['notoc'] ) && !$this->mForceTocPosition ) {
+                       $this->mShowToc = false;
+               }
+               if ( isset( $this->mDoubleUnderscores['hiddencat'] ) && $this->mTitle->getNamespace() == NS_CATEGORY ) {
+                       $this->mOutput->setProperty( 'hiddencat', 'y' );
+
+                       $containerCategory = Title::makeTitleSafe( NS_CATEGORY, wfMsgForContent( 'hidden-category-category' ) );
+                       if ( $containerCategory ) {
+                               $this->mOutput->addCategory( $containerCategory->getDBkey(), $this->getDefaultSort() );
+                       } else {
+                               wfDebug( __METHOD__.": [[MediaWiki:hidden-category-category]] is not a valid title!\n" );
+                       }
+               }
                return $text;
        }
 
@@ -3375,8 +3334,7 @@ class Parser
                }
 
                # Inhibit editsection links if requested in the page
-               $esw =& MagicWord::get( 'noeditsection' );
-               if( $esw->matchAndRemove( $text ) ) {
+               if ( isset( $this->mDoubleUnderscores['noeditsection'] ) ) {
                        $showEditLink = 0;
                }
 
@@ -3392,14 +3350,13 @@ class Parser
 
                # Allow user to stipulate that a page should have a "new section"
                # link added via __NEWSECTIONLINK__
-               $mw =& MagicWord::get( 'newsectionlink' );
-               if( $mw->matchAndRemove( $text ) )
+               if ( isset( $this->mDoubleUnderscores['newsectionlink'] ) ) {
                        $this->mOutput->setNewSection( true );
+               }
 
                # if the string __FORCETOC__ (not case-sensitive) occurs in the HTML,
                # override above conditions and always show TOC above first header
-               $mw =& MagicWord::get( 'forcetoc' );
-               if ($mw->matchAndRemove( $text ) ) {
+               if ( isset( $this->mDoubleUnderscores['forcetoc'] ) ) {
                        $this->mShowToc = true;
                        $enoughToc = true;
                }
@@ -3423,7 +3380,7 @@ class Parser
                $prevlevel = 0;
                $toclevel = 0;
                $prevtoclevel = 0;
-               $markerRegex = "{$this->mUniqPrefix}-h-(\d+)-{$this->mMarkerSuffix}";
+               $markerRegex = "{$this->mUniqPrefix}-h-(\d+)-" . self::MARKER_SUFFIX;
                $baseTitleText = $this->mTitle->getPrefixedDBkey();
                $tocraw = array();
 
@@ -3482,6 +3439,7 @@ class Parser
                                                if($prevtoclevel < $wgMaxTocLevel) {
                                                        # Unindent only if the previous toc level was shown :p
                                                        $toc .= $sk->tocUnindent( $prevtoclevel - $toclevel );
+                                                       $prevtoclevel = $toclevel;
                                                } else {
                                                        $toc .= $sk->tocLineEnd();
                                                }
@@ -3540,11 +3498,15 @@ class Parser
                        # Save headline for section edit hint before it's escaped
                        $headlineHint = $safeHeadline;
                        $safeHeadline = Sanitizer::escapeId( $safeHeadline );
+                       # HTML names must be case-insensitively unique (bug 10721)
+                       $arrayKey = strtolower( $safeHeadline );
+
+                       # XXX : Is $refers[$headlineCount] ever accessed, actually ?
                        $refers[$headlineCount] = $safeHeadline;
 
                        # count how many in assoc. array so we can track dupes in anchors
-                       isset( $refers[$safeHeadline] ) ? $refers[$safeHeadline]++ : $refers[$safeHeadline] = 1;
-                       $refcount[$headlineCount] = $refers[$safeHeadline];
+                       isset( $refers[$arrayKey] ) ? $refers[$arrayKey]++ : $refers[$arrayKey] = 1;
+                       $refcount[$headlineCount] = $refers[$arrayKey];
 
                        # Don't number the heading if it is the only one (looks silly)
                        if( $doNumberHeadings && count( $matches[3] ) > 1) {
@@ -3665,16 +3627,20 @@ class Parser
                 * the database, we use $wgContLang here in order to give
                 * everyone the same signature and use the default one rather
                 * than the one selected in each user's preferences.
+                *
+                * (see also bug 12815)
                 */
+               $ts = $this->mOptions->getTimestamp();
+               $tz = 'UTC';
                if ( isset( $wgLocaltimezone ) ) {
+                       $unixts = wfTimestamp( TS_UNIX, $ts );
                        $oldtz = getenv( 'TZ' );
                        putenv( 'TZ='.$wgLocaltimezone );
-               }
-               $d = $wgContLang->timeanddate( $this->mOptions->getTimestamp(), false, false) .
-                 ' (' . date( 'T' ) . ')';
-               if ( isset( $wgLocaltimezone ) ) {
+                       $ts = date( 'YmdHis', $unixts );
+                       $tz = date( 'T', $unixts );  # might vary on DST changeover!
                        putenv( 'TZ='.$oldtz );
                }
+               $d = $wgContLang->timeanddate( $ts, false, false ) . " ($tz)";
 
                # Variable replacement
                # Because mOutputType is OT_WIKI, this will only process {{subst:xxx}} type tags
@@ -3881,7 +3847,9 @@ class Parser
                $tag = strtolower( $tag );
                $oldVal = isset( $this->mTagHooks[$tag] ) ? $this->mTagHooks[$tag] : null;
                $this->mTagHooks[$tag] = $callback;
-               $this->mStripList[] = $tag;
+               if( !in_array( $tag, $this->mStripList ) ) {
+                       $this->mStripList[] = $tag;
+               }
 
                return $oldVal;
        }
@@ -4019,9 +3987,9 @@ class Parser
                                        # Not in the link cache, add it to the query
                                        if ( !isset( $current ) ) {
                                                $current = $ns;
-                                               $query =  "SELECT page_id, page_namespace, page_title";
+                                               $query =  "SELECT page_id, page_namespace, page_title, page_is_redirect";
                                                if ( $threshold > 0 ) {
-                                                       $query .= ', page_len, page_is_redirect';
+                                                       $query .= ', page_len';
                                                }
                                                $query .= " FROM $page WHERE (page_namespace=$ns AND page_title IN(";
                                        } elseif ( $current != $ns ) {
@@ -4110,9 +4078,9 @@ class Parser
                                        // construct query
                                        $titleClause = $linkBatch->constructSet('page', $dbr);
 
-                                       $variantQuery =  "SELECT page_id, page_namespace, page_title";
+                                       $variantQuery =  "SELECT page_id, page_namespace, page_title, page_is_redirect";
                                        if ( $threshold > 0 ) {
-                                               $variantQuery .= ', page_len, page_is_redirect';
+                                               $variantQuery .= ', page_len';
                                        }
 
                                        $variantQuery .= " FROM $page WHERE $titleClause";
@@ -4403,8 +4371,6 @@ class Parser
         * Parse image options text and use it to make an image
         */
        function makeImage( $title, $options ) {
-               # @TODO: let the MediaHandler specify its transform parameters
-               #
                # Check if the options text is of the form "options|alt text"
                # Options are:
                #  * thumbnail          make a thumbnail with enlarge-icon and caption, alignment depends on lang
@@ -4450,21 +4416,48 @@ class Parser
                        'horizAlign' => array(), 'vertAlign' => array() );
                foreach( $parts as $part ) {
                        list( $magicName, $value ) = $mwArray->matchVariableStartToEnd( $part );
-                       if ( isset( $paramMap[$magicName] ) ) {
+                       $validated = false;
+                       if( isset( $paramMap[$magicName] ) ) {
                                list( $type, $paramName ) = $paramMap[$magicName];
-                               $params[$type][$paramName] = $value;
-                               
+
                                // Special case; width and height come in one variable together
                                if( $type == 'handler' && $paramName == 'width' ) {
                                        $m = array();
-                                       if ( preg_match( '/^([0-9]*)x([0-9]*)$/', $value, $m ) ) {
-                                               $params[$type]['width'] = intval( $m[1] );
-                                               $params[$type]['height'] = intval( $m[2] );
+                                       # (bug 13500) In both cases (width/height and width only),
+                                       # permit trailing "px" for backward compatibility.
+                                       if ( preg_match( '/^([0-9]*)x([0-9]*)\s*(?:px)?\s*$/', $value, $m ) ) {
+                                               $width = intval( $m[1] );
+                                               $height = intval( $m[2] );
+                                               if ( $handler->validateParam( 'width', $width ) ) {
+                                                       $params[$type]['width'] = $width;
+                                                       $validated = true;
+                                               }
+                                               if ( $handler->validateParam( 'height', $height ) ) {
+                                                       $params[$type]['height'] = $height;
+                                                       $validated = true;
+                                               }
+                                       } elseif ( preg_match( '/^[0-9]*\s*(?:px)?\s*$/', $value ) ) {
+                                               $width = intval( $value );
+                                               if ( $handler->validateParam( 'width', $width ) ) {
+                                                       $params[$type]['width'] = $width;
+                                                       $validated = true;
+                                               }
+                                       } // else no validation -- bug 13436
+                               } else {
+                                       if ( $type == 'handler' ) {
+                                               # Validate handler parameter
+                                               $validated = $handler->validateParam( $paramName, $value );
                                        } else {
-                                               $params[$type]['width'] = intval( $value );
+                                               # Validate internal parameters
+                                               $validated = ( $value === false || is_numeric( trim( $value ) ) );
+                                       }
+
+                                       if ( $validated ) {
+                                               $params[$type][$paramName] = $value;
                                        }
                                }
-                       } else {
+                       }
+                       if ( !$validated ) {
                                $caption = $part;
                        }
                }
@@ -4477,15 +4470,6 @@ class Parser
                        $params['frame']['valign'] = key( $params['vertAlign'] );
                }
 
-               # Validate the handler parameters
-               if ( $handler ) {
-                       foreach ( $params['handler'] as $name => $value ) {
-                               if ( !$handler->validateParam( $name, $value ) ) {
-                                       unset( $params['handler'][$name] );
-                               }
-                       }
-               }
-
                # Strip bad stuff out of the alt text
                $alt = $this->replaceLinkHoldersText( $caption );
 
@@ -4498,8 +4482,10 @@ class Parser
                $params['frame']['alt'] = $alt;
                $params['frame']['caption'] = $caption;
 
+               wfRunHooks( 'ParserMakeImageParams', array( $title, $file, &$params ) );
+
                # Linker does the rest
-               $ret = $sk->makeImageLink2( $title, $file, $params['frame'], $params['handler'] );
+               $ret = $sk->makeImageLink2( $title, $file, $params['frame'], $params['handler'], $time );
 
                # Give the handler a chance to modify the parser object
                if ( $handler ) {
@@ -4840,12 +4826,12 @@ class Parser
                                break;
                        } else {
                                $out .= call_user_func( $callback, substr( $s, $i, $markerStart - $i ) );
-                               $markerEnd = strpos( $s, $this->mMarkerSuffix, $markerStart );
+                               $markerEnd = strpos( $s, self::MARKER_SUFFIX, $markerStart );
                                if ( $markerEnd === false ) {
                                        $out .= substr( $s, $markerStart );
                                        break;
                                } else {
-                                       $markerEnd += strlen( $this->mMarkerSuffix );
+                                       $markerEnd += strlen( self::MARKER_SUFFIX );
                                        $out .= substr( $s, $markerStart, $markerEnd - $markerStart );
                                        $i = $markerEnd;
                                }