*/
private static $instance;
+ /**
+ * Overrides the default instance of this class
+ * This is intended for use while testing and will fail if MW_PHPUNIT_TEST is not defined.
+ *
+ * If this method is used it MUST also be called with null after a test to ensure a new
+ * default instance is created next time getInstance is called.
+ *
+ * @since 1.27
+ *
+ * @param PageProps|null $store
+ *
+ * @return ScopedCallback to reset the overridden value
+ * @throws MWException
+ */
+ public static function overrideInstance( PageProps $store = null ) {
+ if ( !defined( 'MW_PHPUNIT_TEST' ) ) {
+ throw new MWException(
+ 'Cannot override ' . __CLASS__ . 'default instance in operation.'
+ );
+ }
+ $previousValue = self::$instance;
+ self::$instance = $store;
+ return new ScopedCallback( function() use ( $previousValue ) {
+ self::$instance = $previousValue;
+ } );
+ }
+
/**
* @return PageProps
*/
if ( is_array( $propertyNames ) ) {
$gotArray = true;
} else {
- $propertyNames = array( $propertyNames );
+ $propertyNames = [ $propertyNames ];
$gotArray = false;
}
- $values = array();
+ $values = [];
$goodIDs = $this->getGoodIDs( $titles );
- $queryIDs = array();
+ $queryIDs = [];
foreach ( $goodIDs as $pageID ) {
foreach ( $propertyNames as $propertyName ) {
$propertyValue = $this->getCachedProperty( $pageID, $propertyName );
$dbr = wfGetDB( DB_SLAVE );
$result = $dbr->select(
'page_props',
- array(
+ [
'pp_page',
'pp_propname',
'pp_value'
- ),
- array(
+ ],
+ [
'pp_page' => $queryIDs,
'pp_propname' => $propertyNames
- ),
+ ],
__METHOD__
);
* @return array associative array mapping page ID to property value array
*/
public function getAllProperties( $titles ) {
- $values = array();
+ $values = [];
$goodIDs = $this->getGoodIDs( $titles );
- $queryIDs = array();
+ $queryIDs = [];
foreach ( $goodIDs as $pageID ) {
$pageProperties = $this->getCachedProperties( $pageID );
if ( $pageProperties === false ) {
}
}
- if ( $queryIDs != array() ) {
+ if ( $queryIDs != [] ) {
$dbr = wfGetDB( DB_SLAVE );
$result = $dbr->select(
'page_props',
- array(
+ [
'pp_page',
'pp_propname',
'pp_value'
- ),
- array(
+ ],
+ [
'pp_page' => $queryIDs,
- ),
+ ],
__METHOD__
);
$currentPageID = 0;
- $pageProperties = array();
+ $pageProperties = [];
foreach ( $result as $row ) {
$pageID = $row->pp_page;
if ( $currentPageID != $pageID ) {
- if ( $pageProperties != array() ) {
+ if ( $pageProperties != [] ) {
$this->cacheProperties( $currentPageID, $pageProperties );
$values[$currentPageID] = $pageProperties;
}
$currentPageID = $pageID;
- $pageProperties = array();
+ $pageProperties = [];
}
$pageProperties[$row->pp_propname] = $row->pp_value;
}
- if ( $pageProperties != array() ) {
+ if ( $pageProperties != [] ) {
$this->cacheProperties( $pageID, $pageProperties );
$values[$pageID] = $pageProperties;
}
* @return array array of good page IDs
*/
private function getGoodIDs( $titles ) {
- $result = array();
+ $result = [];
if ( is_array( $titles ) ) {
foreach ( $titles as $title ) {
$pageID = $title->getArticleID();