Add support for Number grouping(commafy) based on CLDR number grouping patterns like...
[lhc/web/wiklou.git] / includes / OutputPage.php
index 9db347a..8a97061 100644 (file)
@@ -18,7 +18,7 @@ if ( !defined( 'MEDIAWIKI' ) ) {
  *
  * @todo document
  */
-class OutputPage {
+class OutputPage extends ContextSource {
        /// Should be private. Used with addMeta() which adds <meta>
        var $mMetatags = array();
 
@@ -47,7 +47,13 @@ class OutputPage {
        var $mHTMLtitle = '';
 
        /// Should be private. Is the displayed content related to the source of the corresponding wiki article.
-       var $mIsarticle = true;
+       var $mIsarticle = false;
+
+       /**
+        * Should be private. Has get/set methods properly documented.
+        * Stores "article flag" toggle.
+        */
+       var $mIsArticleRelated = true;
 
        /**
         * Should be private. We have to set isPrintable(). Some pages should
@@ -145,12 +151,6 @@ class OutputPage {
        // Parser related.
        var $mContainsOldMagic = 0, $mContainsNewMagic = 0;
 
-       /**
-        * Should be private. Has get/set methods properly documented.
-        * Stores "article flag" toggle.
-        */
-       var $mIsArticleRelated = true;
-
        /// lazy initialised, use parserOptions()
        protected $mParserOptions = null;
 
@@ -196,8 +196,6 @@ class OutputPage {
 
        var $mFileVersion = null;
 
-       private $mContext;
-
        /**
         * An array of stylesheet filenames (relative from skins path), with options
         * for CSS media, IE conditions, and RTL/LTR direction.
@@ -225,12 +223,13 @@ class OutputPage {
         * Instead a new RequestContext should be created and it will implicitly create
         * a OutputPage tied to that context.
         */
-       function __construct( RequestContext $context = null ) {
-               if ( !isset($context) ) {
+       function __construct( IContextSource $context = null ) {
+               if ( $context === null ) {
                        # Extensions should use `new RequestContext` instead of `new OutputPage` now.
                        wfDeprecated( __METHOD__ );
+               } else {
+                       $this->setContext( $context );
                }
-               $this->mContext = $context;
        }
 
        /**
@@ -510,6 +509,15 @@ class OutputPage {
                $this->mModuleMessages = array_merge( $this->mModuleMessages, (array)$modules );
        }
 
+       /**
+        * Get an array of head items
+        *
+        * @return Array
+        */
+       function getHeadItemsArray() {
+               return $this->mHeadItems;
+       }
+
        /**
         * Get all header items in a string
         *
@@ -787,66 +795,15 @@ class OutputPage {
                return $this->mPagetitle;
        }
 
-       /**
-        * Get the RequestContext used in this instance
-        *
-        * @return RequestContext
-        */
-       private function getContext() {
-               if ( !isset($this->mContext) ) {
-                       wfDebug( __METHOD__ . " called and \$mContext is null. Using RequestContext::getMain(); for sanity\n" );
-                       $this->mContext = RequestContext::getMain();
-               }
-               return $this->mContext;
-       }
-
-       /**
-        * Get the WebRequest being used for this instance
-        *
-        * @return WebRequest
-        * @since 1.18
-        */
-       public function getRequest() {
-               return $this->getContext()->getRequest();
-       }
-
        /**
         * Set the Title object to use
         *
         * @param $t Title object
         */
-       public function setTitle( $t ) {
+       public function setTitle( Title $t ) {
                $this->getContext()->setTitle( $t );
        }
 
-       /**
-        * Get the Title object used in this instance
-        *
-        * @return Title
-        */
-       public function getTitle() {
-               return $this->getContext()->getTitle();
-       }
-
-       /**
-        * Get the User object used in this instance
-        *
-        * @return User
-        * @since 1.18
-        */
-       public function getUser() {
-               return $this->getContext()->getUser();
-       }
-
-       /**
-        * Get the Skin object used to render this instance
-        *
-        * @return Skin
-        * @since 1.18
-        */
-       public function getSkin() {
-               return $this->getContext()->getSkin();
-       }
 
        /**
         * Replace the subtile with $str
@@ -1344,7 +1301,7 @@ class OutputPage {
         * @return Array (dbKey => array('time' => MW timestamp or null, 'sha1' => sha1 or ''))
         * @since 1.18
         */
-       public function getImageTimeKeys() {
+       public function getFileSearchOptions() {
                return $this->mImageTimeKeys;
        }
 
@@ -1354,10 +1311,11 @@ class OutputPage {
         *
         * @param $text String
         * @param $linestart Boolean: is this the start of a line?
+        * @param $interface Boolean: is this text in the user interface language?
         */
-       public function addWikiText( $text, $linestart = true ) {
+       public function addWikiText( $text, $linestart = true, $interface = true ) {
                $title = $this->getTitle(); // Work arround E_STRICT
-               $this->addWikiTextTitle( $text, $title, $linestart );
+               $this->addWikiTextTitle( $text, $title, $linestart, /*tidy*/false, $interface );
        }
 
        /**
@@ -1400,8 +1358,10 @@ class OutputPage {
         * @param $title Title object
         * @param $linestart Boolean: is this the start of a line?
         * @param $tidy Boolean: whether to use tidy
+        * @param $interface Boolean: whether it is an interface message
+        *                                                              (for example disables conversion)
         */
-       public function addWikiTextTitle( $text, &$title, $linestart, $tidy = false ) {
+       public function addWikiTextTitle( $text, &$title, $linestart, $tidy = false, $interface = false ) {
                global $wgParser;
 
                wfProfileIn( __METHOD__ );
@@ -1410,6 +1370,7 @@ class OutputPage {
 
                $popts = $this->parserOptions();
                $oldTidy = $popts->setTidy( $tidy );
+               $popts->setInterfaceMessage( (bool) $interface );
 
                $parserOutput = $wgParser->parse(
                        $text, $title, $popts,
@@ -1441,6 +1402,9 @@ class OutputPage {
                $this->mNoGallery = $parserOutput->getNoGallery();
                $this->mHeadItems = array_merge( $this->mHeadItems, $parserOutput->getHeadItems() );
                $this->addModules( $parserOutput->getModules() );
+               $this->addModuleScripts( $parserOutput->getModuleScripts() );
+               $this->addModuleStyles( $parserOutput->getModuleStyles() );
+               $this->addModuleMessages( $parserOutput->getModuleMessages() );
 
                // Template versioning...
                foreach ( (array)$parserOutput->getTemplateIds() as $ns => $dbks ) {
@@ -1451,7 +1415,7 @@ class OutputPage {
                        }
                }
                // File versioning...
-               foreach ( (array)$parserOutput->getImageTimeKeys() as $dbk => $data ) {
+               foreach ( (array)$parserOutput->getFileSearchOptions() as $dbk => $data ) {
                        $this->mImageTimeKeys[$dbk] = $data;
                }
 
@@ -1499,19 +1463,13 @@ class OutputPage {
         * @param $linestart Boolean: is this the start of a line?
         * @param $interface Boolean: use interface language ($wgLang instead of
         *                   $wgContLang) while parsing language sensitive magic
-        *                   words like GRAMMAR and PLURAL
+        *                   words like GRAMMAR and PLURAL. This also disables
+        *                                       LanguageConverter.
         * @param $language  Language object: target language object, will override
         *                   $interface
         * @return String: HTML
         */
        public function parse( $text, $linestart = true, $interface = false, $language = null ) {
-               // Check one for one common cause for parser state resetting
-               $callers = wfGetAllCallers( 10 );
-               if ( strpos( $callers, 'Parser::extensionSubstitution' ) !== false ) {
-                       throw new MWException( "wfMsg* function with parsing cannot be used " .
-                               "inside a tag hook. Should use parser->recursiveTagParse() instead" );
-               }
-
                global $wgParser;
 
                if( is_null( $this->getTitle() ) ) {
@@ -1859,7 +1817,7 @@ class OutputPage {
 
                if ( $this->mRedirect != '' ) {
                        # Standards require redirect URLs to be absolute
-                       $this->mRedirect = wfExpandUrl( $this->mRedirect );
+                       $this->mRedirect = wfExpandUrl( $this->mRedirect, PROTO_CURRENT );
                        if( $this->mRedirectCode == '301' || $this->mRedirectCode == '303' ) {
                                if( !$wgDebugRedirects ) {
                                        $message = HttpStatus::getMessage( $this->mRedirectCode );
@@ -1911,7 +1869,7 @@ class OutputPage {
                        wfRunHooks( 'BeforePageDisplay', array( &$this, &$sk ) );
 
                        wfProfileIn( 'Output-skin' );
-                       $sk->outputPage( $this );
+                       $sk->outputPage();
                        wfProfileOut( 'Output-skin' );
                }
 
@@ -1940,9 +1898,12 @@ class OutputPage {
        /**
         * Output a standard error page
         *
+        * showErrorPage( 'titlemsg', 'pagetextmsg', array( 'param1', 'param2' ) );
+        * showErrorPage( 'titlemsg', $messageObject );
+        *
         * @param $title String: message key for page title
-        * @param $msg String: message key for page text
-        * @param $params Array: message parameters
+        * @param $msg Mixed: message key (string) for page text, or a Message object
+        * @param $params Array: message parameters; ignored if $msg is a Message object
         */
        public function showErrorPage( $title, $msg, $params = array() ) {
                if ( $this->getTitle() ) {
@@ -1956,7 +1917,11 @@ class OutputPage {
                $this->mRedirect = '';
                $this->mBodytext = '';
 
-               $this->addWikiMsgArray( $msg, $params );
+               if ( $msg instanceof Message ){
+                       $this->addHTML( $msg->parse() );
+               } else {
+                       $this->addWikiMsgArray( $msg, $params );
+               }
 
                $this->returnToMain();
        }
@@ -2095,6 +2060,8 @@ class OutputPage {
         * @param $action    String: action that was denied or null if unknown
         */
        public function readOnlyPage( $source = null, $protected = false, $reasons = array(), $action = null ) {
+               global $wgEnableInterwikiTranscluding, $wgEnableInterwikiTemplatesTracking;
+
                $this->setRobotPolicy( 'noindex,nofollow' );
                $this->setArticleRelated( false );
 
@@ -2124,12 +2091,15 @@ class OutputPage {
                if( is_string( $source ) ) {
                        $this->addWikiMsg( 'viewsourcetext' );
 
+                       $pageLang = $this->getTitle()->getPageLanguage();
                        $params = array(
                                'id'   => 'wpTextbox1',
                                'name' => 'wpTextbox1',
                                'cols' => $this->getUser()->getOption( 'cols' ),
                                'rows' => $this->getUser()->getOption( 'rows' ),
-                               'readonly' => 'readonly'
+                               'readonly' => 'readonly',
+                               'lang' => $pageLang->getCode(),
+                               'dir' => $pageLang->getDir(),
                        );
                        $this->addHTML( Html::element( 'textarea', $params, $source ) );
 
@@ -2140,6 +2110,13 @@ class OutputPage {
 $templates
 </div>
 " );
+                       if ( $wgEnableInterwikiTranscluding && $wgEnableInterwikiTemplatesTracking ) {
+                               $distantTemplates = Linker::formatDistantTemplates( $article->getUsedDistantTemplates() );
+                               $this->addHTML( "<div class='distantTemplatesUsed'>
+$distantTemplates
+</div>
+" );
+                       }
                }
 
                # If the title doesn't exist, it's fairly pointless to print a return
@@ -2262,15 +2239,15 @@ $templates
         * @return String: The doctype, opening <html>, and head element.
         */
        public function headElement( Skin $sk, $includeStyle = true ) {
-               global $wgLang, $wgContLang, $wgUseTrackbacks;
-               $userdir = $wgLang->getDir();
+               global $wgContLang, $wgUseTrackbacks;
+               $userdir = $this->getLang()->getDir();
                $sitedir = $wgContLang->getDir();
 
                if ( $sk->commonPrintStylesheet() ) {
                        $this->addModuleStyles( 'mediawiki.legacy.wikiprintable' );
                }
 
-               $ret = Html::htmlHeader( array( 'lang' => $wgLang->getCode(), 'dir' => $userdir ) );
+               $ret = Html::htmlHeader( array( 'lang' => $this->getLang()->getCode(), 'dir' => $userdir, 'class' => 'client-nojs' ) );
 
                if ( $this->getHTMLTitle() == '' ) {
                        $this->setHTMLTitle( wfMsg( 'pagetitle', $this->getPageTitle() ) );
@@ -2302,20 +2279,6 @@ $templates
 
                $bodyAttrs = array();
 
-               # Crazy edit-on-double-click stuff
-               $action = $this->getRequest()->getVal( 'action', 'view' );
-
-               if (
-                       $this->getTitle()->getNamespace() != NS_SPECIAL &&
-                       in_array( $action, array( 'view', 'purge' ) ) &&
-                       $this->getUser()->getOption( 'editondblclick' )
-               )
-               {
-                       $editUrl = $this->getTitle()->getLocalUrl( $sk->editUrlOptions() );
-                       $bodyAttrs['ondblclick'] = "document.location = '" .
-                               Xml::escapeJsString( $editUrl ) . "'";
-               }
-
                # Classes for LTR/RTL directionality support
                $bodyAttrs['class'] = "mediawiki $userdir sitedir-$sitedir";
 
@@ -2338,8 +2301,7 @@ $templates
         * Add the default ResourceLoader modules to this object
         */
        private function addDefaultModules() {
-               global $wgIncludeLegacyJavaScript, $wgUseAjax,
-                       $wgAjaxWatch, $wgEnableMWSuggest, $wgUseAJAXCategories;
+               global $wgIncludeLegacyJavaScript, $wgUseAjax, $wgAjaxWatch, $wgEnableMWSuggest;
 
                // Add base resources
                $this->addModules( array(
@@ -2363,7 +2325,7 @@ $templates
                        }
 
                        if ( $wgEnableMWSuggest && !$this->getUser()->getOption( 'disablesuggest', false ) ) {
-                               $this->addModules( 'mediawiki.page.mwsuggest' );
+                               $this->addModules( 'mediawiki.legacy.mwsuggest' );
                        }
                }
 
@@ -2371,14 +2333,9 @@ $templates
                        $this->addModules( 'mediawiki.action.view.rightClickEdit' );
                }
 
-               if ( $wgUseAJAXCategories ) {
-                       global $wgAJAXCategoriesNamespaces;
-
-                       $title = $this->getTitle();
-
-                       if( empty( $wgAJAXCategoriesNamespaces ) || in_array( $title->getNamespace(), $wgAJAXCategoriesNamespaces ) ) {
-                               $this->addModules( 'mediawiki.page.ajaxCategories.init' );
-                       }
+               # Crazy edit-on-double-click stuff
+               if ( $this->isArticle() && $this->getUser()->getOption( 'editondblclick' ) ) {
+                       $this->addModules( 'mediawiki.action.view.dblClickEdit' );
                }
        }
 
@@ -2396,29 +2353,15 @@ $templates
 
        /**
         * TODO: Document
-        * @param $modules Array/string with the module name
+        * @param $modules Array/string with the module name(s)
         * @param $only String ResourceLoaderModule TYPE_ class constant
         * @param $useESI boolean
+        * @param $extraQuery Array with extra query parameters to add to each request. array( param => value )
         * @return string html <script> and <style> tags
         */
-       protected function makeResourceLoaderLink( $modules, $only, $useESI = false ) {
+       protected function makeResourceLoaderLink( $modules, $only, $useESI = false, array $extraQuery = array() ) {
                global $wgLoadScript, $wgResourceLoaderUseESI,
                        $wgResourceLoaderInlinePrivateModules;
-               // Lazy-load ResourceLoader
-               // TODO: Should this be a static function of ResourceLoader instead?
-               $baseQuery = array(
-                       'lang' => $this->getContext()->getLang()->getCode(),
-                       'debug' => ResourceLoader::inDebugMode() ? 'true' : 'false',
-                       'skin' => $this->getSkin()->getSkinName(),
-                       'only' => $only,
-               );
-               // Propagate printable and handheld parameters if present
-               if ( $this->isPrintable() ) {
-                       $baseQuery['printable'] = 1;
-               }
-               if ( $this->getRequest()->getBool( 'handheld' ) ) {
-                       $baseQuery['handheld'] = 1;
-               }
 
                if ( !count( $modules ) ) {
                        return '';
@@ -2464,14 +2407,26 @@ $templates
 
                $links = '';
                foreach ( $groups as $group => $modules ) {
-                       $query = $baseQuery;
                        // Special handling for user-specific groups
+                       $user = null;
                        if ( ( $group === 'user' || $group === 'private' ) && $this->getUser()->isLoggedIn() ) {
-                               $query['user'] = $this->getUser()->getName();
+                               $user = $this->getUser()->getName();
                        }
 
                        // Create a fake request based on the one we are about to make so modules return
                        // correct timestamp and emptiness data
+                       $query = ResourceLoader::makeLoaderQuery(
+                               array(), // modules; not determined yet
+                               $this->getContext()->getLang()->getCode(),
+                               $this->getSkin()->getSkinName(),
+                               $user,
+                               null, // version; not determined yet
+                               ResourceLoader::inDebugMode(),
+                               $only === ResourceLoaderModule::TYPE_COMBINED ? null : $only,
+                               $this->isPrintable(),
+                               $this->getRequest()->getBool( 'handheld' ),
+                               $extraQuery
+                       );
                        $context = new ResourceLoaderContext( $resourceLoader, new FauxRequest( $query ) );
                        // Drop modules that know they're empty
                        foreach ( $modules as $key => $module ) {
@@ -2484,8 +2439,6 @@ $templates
                                continue;
                        }
 
-                       $query['modules'] = ResourceLoader::makePackedModulesString( array_keys( $modules ) );
-
                        // Support inlining of private modules if configured as such
                        if ( $group === 'private' && $wgResourceLoaderInlinePrivateModules ) {
                                if ( $only == ResourceLoaderModule::TYPE_STYLES ) {
@@ -2507,6 +2460,7 @@ $templates
                        // timestamp of these user-changable modules so we can ensure cache misses on change
                        // This should NOT be done for the site group (bug 27564) because anons get that too
                        // and we shouldn't be putting timestamps in Squid-cached HTML
+                       $version = null;
                        if ( $group === 'user' ) {
                                // Get the maximum timestamp
                                $timestamp = 1;
@@ -2514,15 +2468,21 @@ $templates
                                        $timestamp = max( $timestamp, $module->getModifiedTime( $context ) );
                                }
                                // Add a version parameter so cache will break when things change
-                               $query['version'] = wfTimestamp( TS_ISO_8601_BASIC, $timestamp );
+                               $version = wfTimestamp( TS_ISO_8601_BASIC, $timestamp );
                        }
-                       // Make queries uniform in order
-                       ksort( $query );
-
-                       $url = wfAppendQuery( $wgLoadScript, $query );
-                       // Prevent the IE6 extension check from being triggered (bug 28840)
-                       // by appending a character that's invalid in Windows extensions ('*')
-                       $url .= '&*';
+                       
+                       $url = ResourceLoader::makeLoaderURL(
+                               array_keys( $modules ),
+                               $this->getContext()->getLang()->getCode(),
+                               $this->getSkin()->getSkinName(),
+                               $user,
+                               $version,
+                               ResourceLoader::inDebugMode(),
+                               $only === ResourceLoaderModule::TYPE_COMBINED ? null : $only,
+                               $this->isPrintable(),
+                               $this->getRequest()->getBool( 'handheld' ),
+                               $extraQuery
+                       );
                        if ( $useESI && $wgResourceLoaderUseESI ) {
                                $esi = Xml::element( 'esi:include', array( 'src' => $url ) );
                                if ( $only == ResourceLoaderModule::TYPE_STYLES ) {
@@ -2626,14 +2586,21 @@ $templates
                if ( $wgAllowUserJs && $this->getUser()->isLoggedIn() ) {
                        if( $this->getTitle() && $this->getTitle()->isJsSubpage() && $this->userCanPreview() ) {
                                # XXX: additional security check/prompt?
+                               // We're on a preview of a JS subpage
+                               // Exclude this page from the user module in case it's in there (bug 26283)
+                               $scripts .= $this->makeResourceLoaderLink( 'user', ResourceLoaderModule::TYPE_SCRIPTS, false,
+                                       array( 'excludepage' => $this->getTitle()->getPrefixedDBkey() )
+                               );
+                               // Load the previewed JS
                                $scripts .= Html::inlineScript( "\n" . $this->getRequest()->getText( 'wpTextbox1' ) . "\n" ) . "\n";
                        } else {
-                               # @todo FIXME: This means that User:Me/Common.js doesn't load when previewing
-                               # User:Me/Vector.js, and vice versa (bug26283)
-                               $userScripts[] = 'user';
+                               // Include the user module normally
+                               // We can't do $userScripts[] = 'user'; because the user module would end up
+                               // being wrapped in a closure, so load it raw like 'site'
+                               $scripts .= $this->makeResourceLoaderLink( 'user', ResourceLoaderModule::TYPE_SCRIPTS );
                        }
                }
-               $scripts .= $this->makeResourceLoaderLink( $userScripts, ResourceLoaderModule::TYPE_SCRIPTS );
+               $scripts .= $this->makeResourceLoaderLink( $userScripts, ResourceLoaderModule::TYPE_COMBINED );
 
                return $scripts;
        }
@@ -2687,7 +2654,7 @@ $templates
                }
 
                // Allow extensions to add their custom variables to the global JS variables
-               wfRunHooks( 'MakeGlobalVariablesScript', array( &$vars ) );
+               wfRunHooks( 'MakeGlobalVariablesScript', array( &$vars, &$this ) );
 
                return $vars;
        }
@@ -2846,7 +2813,9 @@ $templates
                        $tags[] = Html::element( 'link', array(
                                'rel' => 'EditURI',
                                'type' => 'application/rsd+xml',
-                               'href' => wfExpandUrl( wfAppendQuery( wfScript( 'api' ), array( 'action' => 'rsd' ) ) ),
+                               // Output a protocol-relative URL here if $wgServer is protocol-relative
+                               // Whether RSD accepts relative or protocol-relative URLs is completely undocumented, though
+                               'href' => wfExpandUrl( wfAppendQuery( wfScript( 'api' ), array( 'action' => 'rsd' ) ), PROTO_RELATIVE ),
                        ) );
                }
 
@@ -2868,8 +2837,8 @@ $templates
                        } else {
                                $tags[] = Html::element( 'link', array(
                                        'rel' => 'canonical',
-                                       'href' => $this->getTitle()->getFullURL() )
-                               );
+                                       'href' => $this->getTitle()->getCanonicalUrl()
+                               ) );
                        }
                }
 
@@ -2922,9 +2891,10 @@ $templates
 
                        if ( $wgOverrideSiteFeed ) {
                                foreach ( $wgOverrideSiteFeed as $type => $feedUrl ) {
+                                       // Note, this->feedLink escapes the url.
                                        $tags[] = $this->feedLink(
                                                $type,
-                                               htmlspecialchars( $feedUrl ),
+                                               $feedUrl,
                                                wfMsg( "site-{$type}-feed", $wgSitename )
                                        );
                                }
@@ -2986,8 +2956,13 @@ $templates
        /**
         * Adds inline CSS styles
         * @param $style_css Mixed: inline CSS
+        * @param $flip String: Set to 'flip' to flip the CSS if needed
         */
-       public function addInlineStyle( $style_css ){
+       public function addInlineStyle( $style_css, $flip = 'noflip' ) {
+               if( $flip === 'flip' && $this->getLang()->isRTL() ) {
+                       # If wanted, and the interface is right-to-left, flip the CSS
+                       $style_css = CSSJanus::transform( $style_css, true, false );
+               }
                $this->mInlineStyles .= Html::inlineStyle( $style_css );
        }
 
@@ -3005,6 +2980,7 @@ $templates
                // Add ResourceLoader styles
                // Split the styles into four groups
                $styles = array( 'other' => array(), 'user' => array(), 'site' => array(), 'private' => array(), 'noscript' => array() );
+               $otherTags = ''; // Tags to append after the normal <link> tags
                $resourceLoader = $this->getResourceLoader();
 
                $moduleStyles = $this->getModuleStyles();
@@ -3021,9 +2997,15 @@ $templates
                // Per-user custom styles
                if ( $wgAllowUserCss ) {
                        if ( $this->getTitle()->isCssSubpage() && $this->userCanPreview() ) {
-                               // @todo FIXME: Properly escape the cdata!
-                               $this->addInlineStyle( $this->getRequest()->getText( 'wpTextbox1' ) );
+                               // We're on a preview of a CSS subpage
+                               // Exclude this page from the user module in case it's in there (bug 26283)
+                               $otherTags .= $this->makeResourceLoaderLink( 'user', ResourceLoaderModule::TYPE_STYLES, false,
+                                       array( 'excludepage' => $this->getTitle()->getPrefixedDBkey() )
+                               );
+                               // Load the previewed CSS
+                               $otherTags .= Html::inlineStyle( $this->getRequest()->getText( 'wpTextbox1' ) );
                        } else {
+                               // Load the user styles normally
                                $moduleStyles[] = 'user';
                        }
                }
@@ -3059,9 +3041,15 @@ $templates
                                        ResourceLoaderModule::TYPE_STYLES
                        );
                }
+
+               // Add stuff in $otherTags (previewed user CSS if applicable)
+               $ret .= $otherTags;
                return $ret;
        }
 
+       /**
+        * @return Array
+        */
        public function buildCssLinksArray() {
                $links = array();
 
@@ -3090,8 +3078,7 @@ $templates
         */
        protected function styleLink( $style, $options ) {
                if( isset( $options['dir'] ) ) {
-                       global $wgLang;
-                       if( $wgLang->getDir() != $options['dir'] ) {
+                       if( $this->getLang()->getDir() != $options['dir'] ) {
                                return '';
                        }
                }