Follow-up r84814: revert redundant summary message addition.
[lhc/web/wiklou.git] / includes / LinkCache.php
index abfdfc5..e2db69a 100644 (file)
@@ -1,15 +1,14 @@
 <?php
 /**
  * Cache for article titles (prefixed DB keys) and ids linked from one source
- * 
- * @addtogroup Cache
+ *
+ * @ingroup Cache
  */
 class LinkCache {
        // Increment $mClassVer whenever old serialized versions of this class
        // becomes incompatible with the new version.
        /* private */ var $mClassVer = 4;
 
-       /* private */ var $mPageLinks;
        /* private */ var $mGoodLinks, $mBadLinks;
        /* private */ var $mForUpdate;
 
@@ -26,7 +25,6 @@ class LinkCache {
 
        function __construct() {
                $this->mForUpdate = false;
-               $this->mPageLinks = array();
                $this->mGoodLinks = array();
                $this->mGoodLinkFields = array();
                $this->mBadLinks = array();
@@ -35,7 +33,7 @@ class LinkCache {
        /**
         * General accessor to get/set whether SELECT FOR UPDATE should be used
         */
-       public function forUpdate( $update = NULL ) {
+       public function forUpdate( $update = null ) {
                return wfSetVar( $this->mForUpdate, $update );
        }
 
@@ -46,12 +44,12 @@ class LinkCache {
                        return 0;
                }
        }
-       
+
        /**
-        * Get a field of a title object from cache. 
+        * Get a field of a title object from cache.
         * If this link is not good, it will return NULL.
-        * @param Title $title
-        * @param string $field ('length','redirect')
+        * @param $title Title
+        * @param $field String: ('length','redirect','revision')
         * @return mixed
         */
        public function getGoodLinkFieldObj( $title, $field ) {
@@ -59,7 +57,7 @@ class LinkCache {
                if ( array_key_exists( $dbkey, $this->mGoodLinkFields ) ) {
                        return $this->mGoodLinkFields[$dbkey][$field];
                } else {
-                       return NULL;
+                       return null;
                }
        }
 
@@ -69,49 +67,59 @@ class LinkCache {
 
        /**
         * Add a link for the title to the link cache
-        * @param int $id
-        * @param Title $title
-        * @param int $len
-        * @param int $redir
+        *
+        * @param $id Integer: page's ID
+        * @param $title Title object
+        * @param $len Integer: text's length
+        * @param $redir Integer: whether the page is a redirect
+        * @param $revision Integer: latest revision's ID
         */
-       public function addGoodLinkObj( $id, $title, $len = -1, $redir = NULL ) {
+       public function addGoodLinkObj( $id, $title, $len = -1, $redir = null, $revision = false ) {
                $dbkey = $title->getPrefixedDbKey();
-               $this->mGoodLinks[$dbkey] = $id;
-               $this->mGoodLinkFields[$dbkey] = array( 'length' => $len, 'redirect' => $redir );
-               $this->mPageLinks[$dbkey] = $title;
+               $this->mGoodLinks[$dbkey] = intval( $id );
+               $this->mGoodLinkFields[$dbkey] = array(
+                       'length' => intval( $len ),
+                       'redirect' => intval( $redir ),
+                       'revision' => intval( $revision ) );
        }
 
        public function addBadLinkObj( $title ) {
                $dbkey = $title->getPrefixedDbKey();
-               if ( ! $this->isBadLink( $dbkey ) ) {
+               if ( !$this->isBadLink( $dbkey ) ) {
                        $this->mBadLinks[$dbkey] = 1;
-                       $this->mPageLinks[$dbkey] = $title;
                }
        }
 
        public function clearBadLink( $title ) {
                unset( $this->mBadLinks[$title] );
-               $this->clearLink( $title );
        }
 
-       /* obsolete, for old $wgLinkCacheMemcached stuff */
-       public function clearLink( $title ) {}
+       public function clearLink( $title ) {
+               $dbkey = $title->getPrefixedDbKey();
+               if( isset($this->mBadLinks[$dbkey]) ) {
+                       unset($this->mBadLinks[$dbkey]);
+               }
+               if( isset($this->mGoodLinks[$dbkey]) ) {
+                       unset($this->mGoodLinks[$dbkey]);
+               }
+               if( isset($this->mGoodLinkFields[$dbkey]) ) {
+                       unset($this->mGoodLinkFields[$dbkey]);
+               }
+       }
 
-       public function getPageLinks() { return $this->mPageLinks; }
        public function getGoodLinks() { return $this->mGoodLinks; }
        public function getBadLinks() { return array_keys( $this->mBadLinks ); }
 
        /**
         * Add a title to the link cache, return the page_id or zero if non-existent
+        *
         * @param $title String: title to add
-        * @param $len int, page size
-        * @param $redir bool, is redirect?
-        * @return integer
+        * @return Integer
         */
-       public function addLink( $title, $len = -1, $redir = NULL ) {
+       public function addLink( $title ) {
                $nt = Title::newFromDBkey( $title );
                if( $nt ) {
-                       return $this->addLinkObj( $nt, $len, $redir );
+                       return $this->addLinkObj( $nt );
                } else {
                        return 0;
                }
@@ -119,65 +127,66 @@ class LinkCache {
 
        /**
         * Add a title to the link cache, return the page_id or zero if non-existent
-        * @param $nt Title to add.
-        * @param $len int, page size
-        * @param $redir bool, is redirect?
-        * @return integer
+        *
+        * @param $nt Title object to add
+        * @return Integer
         */
-       public function addLinkObj( &$nt, $len = -1, $redirect = NULL ) {
+       public function addLinkObj( $nt ) {
                global $wgAntiLockFlags;
-               $title = $nt->getPrefixedDBkey();
-               if ( $this->isBadLink( $title ) ) { return 0; }
-               $id = $this->getGoodLinkID( $title );
-               if ( 0 != $id ) { return $id; }
-
-               $fname = 'LinkCache::addLinkObj';
-               global $wgProfiler;
-               if ( isset( $wgProfiler ) ) {
-                       $fname .= ' (' . $wgProfiler->getCurrentSection() . ')';
-               }
-
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
 
-               $ns = $nt->getNamespace();
-               $t = $nt->getDBkey();
+               $key = $nt->getPrefixedDBkey();
+               if ( $this->isBadLink( $key ) || $nt->isExternal() ) {
+                       wfProfileOut( __METHOD__ );
+                       return 0;
+               }
+               $id = $this->getGoodLinkID( $key );
+               if ( $id != 0 ) {
+                       wfProfileOut( __METHOD__ );
+                       return $id;
+               }
 
-               if ( '' == $title ) {
-                       wfProfileOut( $fname );
+               if ( $key === '' ) {
+                       wfProfileOut( __METHOD__ );
                        return 0;
                }
+
                # Some fields heavily used for linking...
-               $id = NULL;
-               
-               if( !is_integer( $id ) ) {
-                       if ( $this->mForUpdate ) {
-                               $db = wfGetDB( DB_MASTER );
-                               if ( !( $wgAntiLockFlags & ALF_NO_LINK_LOCK ) ) {
-                                       $options = array( 'FOR UPDATE' );
-                               } else {
-                                       $options = array();
-                               }
+               if ( $this->mForUpdate ) {
+                       $db = wfGetDB( DB_MASTER );
+                       if ( !( $wgAntiLockFlags & ALF_NO_LINK_LOCK ) ) {
+                               $options = array( 'FOR UPDATE' );
                        } else {
-                               $db = wfGetDB( DB_SLAVE );
                                $options = array();
                        }
+               } else {
+                       $db = wfGetDB( DB_SLAVE );
+                       $options = array();
+               }
 
-                       $s = $db->selectRow( 'page', 
-                               array( 'page_id', 'page_len', 'page_is_redirect' ),
-                               array( 'page_namespace' => $ns, 'page_title' => $t ),
-                               $fname, $options );
-                       # Set fields...
-                       $id = $s ? $s->page_id : 0;
-                       $len = $s ? $s->page_len : -1;
-                       $redirect = $s ? $s->page_is_redirect : 0;
+               $s = $db->selectRow( 'page',
+                       array( 'page_id', 'page_len', 'page_is_redirect', 'page_latest' ),
+                       array( 'page_namespace' => $nt->getNamespace(), 'page_title' => $nt->getDBkey() ),
+                       __METHOD__, $options );
+               # Set fields...
+               if ( $s !== false ) {
+                       $id = intval( $s->page_id );
+                       $len = intval( $s->page_len );
+                       $redirect = intval( $s->page_is_redirect );
+                       $revision = intval( $s->page_latest );
+               } else {
+                       $id = 0;
+                       $len = -1;
+                       $redirect = 0;
+                       $revision = 0;
                }
 
-               if( 0 == $id ) {
+               if ( $id == 0 ) {
                        $this->addBadLinkObj( $nt );
                } else {
-                       $this->addGoodLinkObj( $id, $nt, $len, $redirect );
+                       $this->addGoodLinkObj( $id, $nt, $len, $redirect, $revision );
                }
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return $id;
        }
 
@@ -185,10 +194,8 @@ class LinkCache {
         * Clears cache
         */
        public function clear() {
-               $this->mPageLinks = array();
                $this->mGoodLinks = array();
                $this->mGoodLinkFields = array();
                $this->mBadLinks = array();
        }
 }
-