Fix for r85114, see code reviev

[lhc/web/wiklou.git] / includes / Interwiki.php

diff --git a/includes/Interwiki.php b/includes/Interwiki.php
index 6a179f2..036cbe3 100644 (file)
--- a/includes/Interwiki.php
+++ b/includes/Interwiki.php
@@ -7,7 +7,8 @@
 /**
  * The interwiki class
  * All information is loaded on creation when called by Interwiki::fetch( $prefix ).
- * All work is done on slave, because this should *never* change (except during schema updates etc, which arent wiki-related)
+ * All work is done on slave, because this should *never* change (except during
+ * schema updates etc, which aren't wiki-related)
  */
 class Interwiki {
 
@@ -17,11 +18,11 @@ class Interwiki {
 
        protected $mPrefix, $mURL, $mAPI, $mWikiID, $mLocal, $mTrans;
 
-       public function __construct( $prefix = null, $url = '', $api = '', $wikiid = '', $local = 0, $trans = 0 ) {
+       public function __construct( $prefix = null, $url = '', $api = '', $wikiId = '', $local = 0, $trans = 0 ) {
                $this->mPrefix = $prefix;
                $this->mURL = $url;
                $this->mAPI = $api;
-               $this->mWikiID = $wikiid;
+               $this->mWikiID = $wikiId;
                $this->mLocal = $local;
                $this->mTrans = $trans;
        }
@@ -63,7 +64,7 @@ class Interwiki {
                }
                if( self::CACHE_LIMIT && count( self::$smCache ) >= self::CACHE_LIMIT ) {
                        reset( self::$smCache );
-                       unset( self::$smCache[ key( self::$smCache ) ] );
+                       unset( self::$smCache[key( self::$smCache )] );
                }
                self::$smCache[$prefix] = $iw;
                return $iw;
@@ -109,7 +110,7 @@ class Interwiki {
                        $db = CdbReader::open( $wgInterwikiCache );
                }
                /* Resolve site name */
-               if( $wgInterwikiScopes>=3 && !$site ) {
+               if( $wgInterwikiScopes >= 3 && !$site ) {
                        $site = $db->get( '__sites:' . wfWikiID() );
                        if ( $site == '' ) {
                                $site = $wgInterwikiFallbackSite;
@@ -125,8 +126,9 @@ class Interwiki {
                if ( $value == '' && $wgInterwikiScopes >= 2 ) {
                        $value = $db->get( "__global:{$prefix}" );
                }
-               if ( $value == 'undef' )
+               if ( $value == 'undef' ) {
                        $value = '';
+               }
 
                return $value;
        }
@@ -139,11 +141,19 @@ class Interwiki {
         */
        protected static function load( $prefix ) {
                global $wgMemc, $wgInterwikiExpiry;
-               $key = wfMemcKey( 'interwiki', $prefix );
-               $mc = $wgMemc->get( $key );
-               $iw = false;
-               if( $mc && is_array( $mc ) ) { // is_array is hack for old keys
-                       $iw = Interwiki::loadFromArray( $mc );
+
+               $iwData = false;
+               if ( !wfRunHooks( 'InterwikiLoadPrefix', array( $prefix, &$iwData ) ) ) {
+                       return Interwiki::loadFromArray( $iwData );
+               }
+
+               if ( !$iwData ) {
+                       $key = wfMemcKey( 'interwiki', $prefix );
+                       $iwData = $wgMemc->get( $key );
+               }
+
+               if( $iwData && is_array( $iwData ) ) { // is_array is hack for old keys
+                       $iw = Interwiki::loadFromArray( $iwData );
                        if( $iw ) {
                                return $iw;
                        }
@@ -155,7 +165,12 @@ class Interwiki {
                        __METHOD__ ) );
                $iw = Interwiki::loadFromArray( $row );
                if ( $iw ) {
-                       $mc = array( 'iw_url' => $iw->mURL, 'iw_api' => $iw->mAPI, 'iw_local' => $iw->mLocal, 'iw_trans' => $iw->mTrans );
+                       $mc = array(
+                               'iw_url' => $iw->mURL,
+                               'iw_api' => $iw->mAPI,
+                               'iw_local' => $iw->mLocal,
+                               'iw_trans' => $iw->mTrans
+                       );
                        $wgMemc->add( $key, $mc, $wgInterwikiExpiry );
                        return $iw;
                }
@@ -177,7 +192,7 @@ class Interwiki {
                        $iw->mTrans = $mc['iw_trans'];
                        $iw->mAPI = isset( $mc['iw_api'] ) ? $mc['iw_api'] : '';
                        $iw->mWikiID = isset( $mc['iw_wikiid'] ) ? $mc['iw_wikiid'] : '';
-                       
+
                        return $iw;
                }
                return false;
@@ -185,7 +200,7 @@ class Interwiki {
 
        /**
         * Get the URL for a particular title (or with $1 if no title given)
-        * 
+        *
         * @param $title String: what text to put for the article name
         * @return String: the URL
         */
@@ -199,19 +214,19 @@ class Interwiki {
 
        /**
         * Get the API URL for this wiki
-        * 
+        *
         * @return String: the URL
         */
-       public function getAPI( ) {
+       public function getAPI() {
                return $this->mAPI;
        }
 
        /**
         * Get the DB name for this wiki
-        * 
+        *
         * @return String: the DB name
         */
-       public function getWikiID( ) {
+       public function getWikiID() {
                return $this->mWikiID;
        }
 
@@ -241,9 +256,8 @@ class Interwiki {
         * @return String
         */
        public function getName() {
-               $key = 'interwiki-name-' . $this->mPrefix;
-               $msg = wfMsgForContent( $key );
-               return wfEmptyMsg( $key, $msg ) ? '' : $msg;
+               $msg = wfMessage( 'interwiki-name-' . $this->mPrefix )->inContentLanguage();
+               return !$msg->exists() ? '' : $msg;
        }
 
        /**
@@ -252,8 +266,7 @@ class Interwiki {
         * @return String
         */
        public function getDescription() {
-               $key = 'interwiki-desc-' . $this->mPrefix;
-               $msg = wfMsgForContent( $key );
-               return wfEmptyMsg( $key, $msg ) ? '' : $msg;
+               $msg = wfMessage( 'interwiki-desc-' . $this->mPrefix )->inContentLanguage();
+               return !$msg->exists() ? '' : $msg;
        }
 }