Kill some more mysql 4 related things from the installer
[lhc/web/wiklou.git] / includes / ImagePage.php
index b56a279..a599ab7 100644 (file)
@@ -18,6 +18,10 @@ class ImagePage extends Article {
 
        var $mExtraDescription = false;
 
+       /**
+        * @param $title Title
+        * @return WikiFilePage
+        */
        protected function newPage( Title $title ) {
                // Overload mPage with a file-specific page
                return new WikiFilePage( $title );
@@ -84,7 +88,7 @@ class ImagePage extends Article {
                if ( $this->getTitle()->getNamespace() != NS_FILE || ( isset( $diff ) && $diffOnly ) ) {
                        return parent::view();
                }
-                       
+
                $this->loadFile();
 
                if ( $this->getTitle()->getNamespace() == NS_FILE && $this->mPage->getFile()->getRedirected() ) {
@@ -94,7 +98,7 @@ class ImagePage extends Article {
                                $wgRequest->setVal( 'diffonly', 'true' );
                                return parent::view();
                        } else {
-                               // mTitle is not the same as the redirect target so it is 
+                               // mTitle is not the same as the redirect target so it is
                                // probably the redirect page itself. Fake the redirect symbol
                                $wgOut->setPageTitle( $this->getTitle()->getPrefixedText() );
                                $wgOut->addHTML( $this->viewRedirect( Title::makeTitle( NS_FILE, $this->mPage->getFile()->getName() ),
@@ -124,8 +128,8 @@ class ImagePage extends Article {
 
                # No need to display noarticletext, we use our own message, output in openShowImage()
                if ( $this->mPage->getID() ) {
-                       # When $wgBetterDirectionality is enabled, NS_FILE is in the user language,
-                       # but this section (the actual wikitext) should be in page content language
+                       # NS_FILE is in the user language, but this section (the actual wikitext)
+                       # should be in page content language
                        $pageLang = $this->getTitle()->getPageLanguage();
                        $wgOut->addHTML( Xml::openElement( 'div', array( 'id' => 'mw-imagepage-content',
                                'lang' => $pageLang->getCode(), 'dir' => $pageLang->getDir(),
@@ -159,7 +163,7 @@ class ImagePage extends Article {
                # @todo FIXME: For some freaky reason, we can't redirect to foreign images.
                # Yet we return metadata about the target. Definitely an issue in the FileRepo
                $this->imageLinks();
-               
+
                # Allow extensions to add something after the image links
                $html = '';
                wfRunHooks( 'ImagePageAfterImageLinks', array( $this, &$html ) );
@@ -184,6 +188,9 @@ class ImagePage extends Article {
                $wgOut->addModuleStyles( 'filepage' );
        }
 
+       /**
+        * @return File
+        */
        public function getDisplayedFile() {
                $this->loadFile();
                return $this->displayImg;
@@ -204,9 +211,9 @@ class ImagePage extends Article {
                if ( $metadata ) {
                        $r[] = '<li><a href="#metadata">' . wfMsgHtml( 'metadata' ) . '</a></li>';
                }
-       
+
                wfRunHooks( 'ImagePageShowTOC', array( $this, &$r ) );
-               
+
                return '<ul id="filetoc">' . implode( "\n", $r ) . '</ul>';
        }
 
@@ -243,6 +250,7 @@ class ImagePage extends Article {
         *
         * Omit noarticletext if sharedupload; text will be fetched from the
         * shared upload server if possible.
+        * @return string
         */
        public function getContent() {
                $this->loadFile();
@@ -272,8 +280,7 @@ class ImagePage extends Article {
                $max = $wgImageLimits[$sizeSel];
                $maxWidth = $max[0];
                $maxHeight = $max[1];
-               $sk = $wgUser->getSkin();
-               $dirmark = wfUILang()->getDirMark();
+               $dirmark = $wgLang->getDirMark();
 
                if ( $this->displayImg->exists() ) {
                        # image
@@ -297,7 +304,7 @@ class ImagePage extends Article {
                                # image
 
                                # "Download high res version" link below the image
-                               # $msgsize = wfMsgHtml( 'file-info-size', $width_orig, $height_orig, $sk->formatSize( $this->displayImg->getSize() ), $mime );
+                               # $msgsize = wfMsgHtml( 'file-info-size', $width_orig, $height_orig, Linker::formatSize( $this->displayImg->getSize() ), $mime );
                                # We'll show a thumbnail of this image
                                if ( $width > $maxWidth || $height > $maxHeight ) {
                                        # Calculate the thumbnail size.
@@ -318,17 +325,23 @@ class ImagePage extends Article {
                                        foreach ( $wgImageLimits as $size ) {
                                                if ( $size[0] < $width_orig && $size[1] < $height_orig &&
                                                                $size[0] != $width && $size[1] != $height ) {
-                                                       $otherSizes[] = $this->makeSizeLink( $params, $size[0], $size[1] );                                                     
+                                                       $otherSizes[] = $this->makeSizeLink( $params, $size[0], $size[1] );
                                                }
                                        }
                                        $msgsmall = wfMessage( 'show-big-image-preview' )->
                                                rawParams( $this->makeSizeLink( $params, $width, $height ) )->
-                                               parse() . ' ' . 
-                                               wfMessage( 'show-big-image-other' )->
-                                               rawParams( $wgLang->pipeList( $otherSizes ) )->parse();
+                                               parse() . ' ' .
+                                               Html::rawElement( 'span', array( 'class' => 'mw-filepage-other-resolutions' ),
+                                                       wfMessage( 'show-big-image-other' )->rawParams( $wgLang->pipeList( $otherSizes ) )->
+                                                       params( count( $otherSizes ) )->parse()
+                                               );
+                               } elseif ( $width == 0 && $height == 0 ){
+                                       # Some sort of audio file that doesn't have dimensions
+                                       # Don't output a no hi res message for such a file
+                                       $msgsmall = '';
                                } else {
                                        # Image is small enough to show full size on image page
-                                       $msgsmall = wfMsgExt( 'file-nohires', array( 'parseinline' ) );
+                                       $msgsmall = wfMessage( 'file-nohires' )->parse();
                                }
 
                                $params['width'] = $width;
@@ -336,7 +349,7 @@ class ImagePage extends Article {
                                $thumbnail = $this->displayImg->transform( $params );
 
                                $showLink = true;
-                               $anchorclose = '<br />' . $msgsmall;
+                               $anchorclose = Html::rawElement( 'div', array( 'class' => 'mw-filepage-resolutioninfo' ), $msgsmall );
 
                                $isMulti = $this->displayImg->isMultipage() && $this->displayImg->pageCount() > 1;
                                if ( $isMulti ) {
@@ -358,14 +371,14 @@ class ImagePage extends Article {
 
                                        if ( $page > 1 ) {
                                                $label = $wgOut->parse( wfMsg( 'imgmultipageprev' ), false );
-                                               $link = $sk->link(
+                                               $link = Linker::link(
                                                        $this->getTitle(),
                                                        $label,
                                                        array(),
                                                        array( 'page' => $page - 1 ),
                                                        array( 'known', 'noclasses' )
                                                );
-                                               $thumb1 = $sk->makeThumbLinkObj( $this->getTitle(), $this->displayImg, $link, $label, 'none',
+                                               $thumb1 = Linker::makeThumbLinkObj( $this->getTitle(), $this->displayImg, $link, $label, 'none',
                                                        array( 'page' => $page - 1 ) );
                                        } else {
                                                $thumb1 = '';
@@ -373,14 +386,14 @@ class ImagePage extends Article {
 
                                        if ( $page < $count ) {
                                                $label = wfMsg( 'imgmultipagenext' );
-                                               $link = $sk->link(
+                                               $link = Linker::link(
                                                        $this->getTitle(),
                                                        $label,
                                                        array(),
                                                        array( 'page' => $page + 1 ),
                                                        array( 'known', 'noclasses' )
                                                );
-                                               $thumb2 = $sk->makeThumbLinkObj( $this->getTitle(), $this->displayImg, $link, $label, 'none',
+                                               $thumb2 = Linker::makeThumbLinkObj( $this->getTitle(), $this->displayImg, $link, $label, 'none',
                                                        array( 'page' => $page + 1 ) );
                                        } else {
                                                $thumb2 = '';
@@ -393,7 +406,7 @@ class ImagePage extends Article {
                                                'action' => $wgScript,
                                                'onchange' => 'document.pageselector.submit();',
                                        );
-
+                                       $options = array();
                                        for ( $i = 1; $i <= $count; $i++ ) {
                                                $options[] = Xml::option( $wgLang->formatNum( $i ), $i, $i == $page );
                                        }
@@ -408,7 +421,7 @@ class ImagePage extends Article {
                                                wfMsgExt( 'imgmultigoto', array( 'parseinline', 'replaceafter' ), $select ) .
                                                Xml::submitButton( wfMsg( 'imgmultigo' ) ) .
                                                Xml::closeElement( 'form' ) .
-                                               "<hr />$thumb1\n$thumb2<br clear=\"all\" /></div></td></tr></table>"
+                                               "<hr />$thumb1\n$thumb2<br style=\"clear: both\" /></div></td></tr></table>"
                                        );
                                }
                        } else {
@@ -474,13 +487,15 @@ EOT
                                $wgRequest->response()->header( 'HTTP/1.1 404 Not Found' );
                        }
                }
+               $wgOut->setFileVersion( $this->displayImg );
        }
-       
+
        /**
-        * Creates an thumbnail of specified size and returns an HTML link to it  
-        * @param array $params Scaler parameters
-        * @param int $width
-        * @param int $height
+        * Creates an thumbnail of specified size and returns an HTML link to it
+        * @param $params array Scaler parameters
+        * @param $width int
+        * @param $height int
+        * @return string
         */
        private function makeSizeLink( $params, $width, $height ) {
                $params['width'] = $width;
@@ -491,7 +506,7 @@ EOT
                                'href' => $thumbnail->getUrl(),
                                'class' => 'mw-thumbnail-link'
                                ), wfMessage( 'show-big-image-size' )->numParams(
-                                       $thumbnail->getWidth(), $thumbnail->getHeight() 
+                                       $thumbnail->getWidth(), $thumbnail->getHeight()
                                )->parse() );
                } else {
                        return '';
@@ -555,19 +570,17 @@ EOT
                        return;
                }
 
-               $sk = $wgUser->getSkin();
-
                $wgOut->addHTML( "<br /><ul>\n" );
 
                # "Upload a new version of this file" link
                if ( UploadBase::userCanReUpload( $wgUser, $this->mPage->getFile()->name ) ) {
-                       $ulink = $sk->makeExternalLink( $this->getUploadUrl(), wfMsg( 'uploadnewversion-linktext' ) );
+                       $ulink = Linker::makeExternalLink( $this->getUploadUrl(), wfMsg( 'uploadnewversion-linktext' ) );
                        $wgOut->addHTML( "<li id=\"mw-imagepage-reupload-link\"><div class=\"plainlinks\">{$ulink}</div></li>\n" );
                }
 
                # External editing link
                if ( $wgUseExternalEditor ) {
-                       $elink = $sk->link(
+                       $elink = Linker::link(
                                $this->getTitle(),
                                wfMsgHtml( 'edit-externally' ),
                                array(),
@@ -611,6 +624,11 @@ EOT
                }
        }
 
+       /**
+        * @param $target
+        * @param $limit
+        * @return ResultWrapper
+        */
        protected function queryImageLinks( $target, $limit ) {
                $dbr = wfGetDB( DB_SLAVE );
 
@@ -619,15 +637,15 @@ EOT
                        array( 'page_namespace', 'page_title', 'page_is_redirect', 'il_to' ),
                        array( 'il_to' => $target, 'il_from = page_id' ),
                        __METHOD__,
-                       array( 'LIMIT' => $limit + 1 )
-               );              
+                       array( 'LIMIT' => $limit + 1, 'ORDER BY' => 'il_from', )
+               );
        }
-       
+
        protected function imageLinks() {
-               global $wgUser, $wgOut, $wgLang;
+               global $wgOut, $wgLang;
 
                $limit = 100;
-               
+
                $res = $this->queryImageLinks( $this->getTitle()->getDbKey(), $limit + 1);
                $rows = array();
                $redirects = array();
@@ -638,10 +656,10 @@ EOT
                        $rows[] = $row;
                }
                $count = count( $rows );
-               
+
                $hasMore = $count > $limit;
                if ( !$hasMore && count( $redirects ) ) {
-                       $res = $this->queryImageLinks( array_keys( $redirects ), 
+                       $res = $this->queryImageLinks( array_keys( $redirects ),
                                $limit - count( $rows ) + 1 );
                        foreach ( $res as $row ) {
                                $redirects[$row->il_to][] = $row;
@@ -658,7 +676,7 @@ EOT
                        );
                        return;
                }
-               
+
                $wgOut->addHTML( "<div id='mw-imagepage-section-linkstoimage'>\n" );
                if ( !$hasMore ) {
                        $wgOut->addWikiMsg( 'linkstoimage', $count );
@@ -674,7 +692,6 @@ EOT
                        Html::openElement( 'ul',
                                array( 'class' => 'mw-imagepage-linkstoimage' ) ) . "\n"
                );
-               $sk = $wgUser->getSkin();
                $count = 0;
 
                // Sort the list by namespace:title
@@ -687,8 +704,8 @@ EOT
                        if ( $currentCount > $limit ) {
                                break;
                        }
-                           
-                       $link = $sk->linkKnown( Title::makeTitle( $element->page_namespace, $element->page_title ) );
+
+                       $link = Linker::linkKnown( Title::makeTitle( $element->page_namespace, $element->page_title ) );
                        if ( !isset( $redirects[$element->page_title] ) ) {
                                $liContents = $link;
                        } else {
@@ -698,8 +715,8 @@ EOT
                                        if ( $currentCount > $limit ) {
                                                break;
                                        }
-                                       
-                                       $link2 = $sk->linkKnown( Title::makeTitle( $row->page_namespace, $row->page_title ) );
+
+                                       $link2 = Linker::linkKnown( Title::makeTitle( $row->page_namespace, $row->page_title ) );
                                        $ul .= Html::rawElement(
                                                'li',
                                                array( 'id' => 'mw-imagepage-linkstoimage-ns' . $element->page_namespace ),
@@ -707,7 +724,7 @@ EOT
                                                ) . "\n";
                                }
                                $ul .= '</ul>';
-                               $liContents = wfMessage( 'linkstoimage-redirect' )->rawParams( 
+                               $liContents = wfMessage( 'linkstoimage-redirect' )->rawParams(
                                        $link, $ul )->parse();
                        }
                        $wgOut->addHTML( Html::rawElement(
@@ -729,7 +746,7 @@ EOT
        }
 
        protected function imageDupes() {
-               global $wgOut, $wgUser, $wgLang;
+               global $wgOut, $wgLang;
 
                $this->loadFile();
 
@@ -744,11 +761,13 @@ EOT
                );
                $wgOut->addHTML( "<ul class='mw-imagepage-duplicates'>\n" );
 
-               $sk = $wgUser->getSkin();
+               /**
+                * @var $file File
+                */
                foreach ( $dupes as $file ) {
                        $fromSrc = '';
                        if ( $file->isLocal() ) {
-                               $link = $sk->link(
+                               $link = Linker::link(
                                        $file->getTitle(),
                                        null,
                                        array(),
@@ -756,7 +775,7 @@ EOT
                                        array( 'known', 'noclasses' )
                                );
                        } else {
-                               $link = $sk->makeExternalLink( $file->getDescriptionUrl(),
+                               $link = Linker::makeExternalLink( $file->getDescriptionUrl(),
                                        $file->getTitle()->getPrefixedText() );
                                $fromSrc = wfMsg( 'shared-repo-from', $file->getRepo()->getDisplayName() );
                        }
@@ -769,58 +788,25 @@ EOT
         * Delete the file, or an earlier version of it
         */
        public function delete() {
-               global $wgUploadMaintenance;
-               if ( $wgUploadMaintenance && $this->getTitle() && $this->getTitle()->getNamespace() == NS_FILE ) {
-                       global $wgOut;
-                       $wgOut->wrapWikiMsg( "<div class='error'>\n$1\n</div>\n", array( 'filedelete-maintenance' ) );
-                       return;
-               }
-
-               $this->loadFile();
-               if ( !$this->mPage->getFile()->exists() || !$this->mPage->getFile()->isLocal() || $this->mPage->getFile()->getRedirected() ) {
+               $file = $this->mPage->getFile();
+               if ( !$file->exists() || !$file->isLocal() || $file->getRedirected() ) {
                        // Standard article deletion
                        parent::delete();
                        return;
                }
-               $deleter = new FileDeleteForm( $this->mPage->getFile() );
-               $deleter->execute();
-       }
-
-       /**
-        * Revert the file to an earlier version
-        */
-       public function revert() {
-               $this->loadFile();
-               $reverter = new FileRevertForm( $this->mPage->getFile() );
-               $reverter->execute();
-       }
 
-       /**
-        * Override handling of action=purge
-        */
-       public function doPurge() {
-               $this->loadFile();
-               if ( $this->mPage->getFile()->exists() ) {
-                       wfDebug( 'ImagePage::doPurge purging ' . $this->mPage->getFile()->getName() . "\n" );
-                       $update = new HTMLCacheUpdate( $this->getTitle(), 'imagelinks' );
-                       $update->doUpdate();
-                       $this->mPage->getFile()->upgradeRow();
-                       $this->mPage->getFile()->purgeCache();
-               } else {
-                       wfDebug( 'ImagePage::doPurge no image for ' . $this->mPage->getFile()->getName() . "; limiting purge to cache only\n" );
-                       // even if the file supposedly doesn't exist, force any cached information
-                       // to be updated (in case the cached information is wrong)
-                       $this->mPage->getFile()->purgeCache();
-               }
-               parent::doPurge();
+               $deleter = new FileDeleteForm( $file );
+               $deleter->execute();
        }
 
        /**
         * Display an error with a wikitext description
+        *
+        * @param $description String
         */
        function showError( $description ) {
                global $wgOut;
-               $wgOut->setPageTitle( wfMsg( 'internalerror' ) );
+               $wgOut->setPageTitle( wfMessage( 'internalerror' ) );
                $wgOut->setRobotPolicy( 'noindex,nofollow' );
                $wgOut->setArticleRelated( false );
                $wgOut->enableClientCache( false );
@@ -830,7 +816,7 @@ EOT
        /**
         * Callback for usort() to do link sorts by (namespace, title)
         * Function copied from Title::compare()
-        * 
+        *
         * @param $a object page to compare with
         * @param $b object page to compare with
         * @return Integer: result of string comparison, or namespace comparison
@@ -867,9 +853,9 @@ class ImageHistoryList {
        protected $imagePage;
 
        /**
-        * @var Skin
+        * @var File
         */
-       protected $skin;
+       protected $current;
 
        protected $repo, $showThumb;
        protected $preventClickjacking = false;
@@ -878,8 +864,7 @@ class ImageHistoryList {
         * @param ImagePage $imagePage
         */
        public function __construct( $imagePage ) {
-               global $wgUser, $wgShowArchiveThumbnails;
-               $this->skin = $wgUser->getSkin();
+               global $wgShowArchiveThumbnails;
                $this->current = $imagePage->getFile();
                $this->img = $imagePage->getDisplayedFile();
                $this->title = $imagePage->getTitle();
@@ -887,18 +872,24 @@ class ImageHistoryList {
                $this->showThumb = $wgShowArchiveThumbnails && $this->img->canRender();
        }
 
+       /**
+        * @return ImagePage
+        */
        public function getImagePage() {
                return $this->imagePage;
        }
 
-       public function getSkin() {
-               return $this->skin;
-       }
-
+       /**
+        * @return File
+        */
        public function getFile() {
                return $this->img;
        }
 
+       /**
+        * @param $navLinks string
+        * @return string
+        */
        public function beginImageHistoryList( $navLinks = '' ) {
                global $wgOut, $wgUser;
                return Xml::element( 'h2', array( 'id' => 'filehistory' ), wfMsg( 'filehist' ) ) . "\n"
@@ -916,6 +907,10 @@ class ImageHistoryList {
                        . "</tr>\n";
        }
 
+       /**
+        * @param $navLinks string
+        * @return string
+        */
        public function endImageHistoryList( $navLinks = '' ) {
                return "</table>\n$navLinks\n</div>\n";
        }
@@ -926,7 +921,7 @@ class ImageHistoryList {
         * @return string
         */
        public function imageHistoryLine( $iscur, $file ) {
-               global $wgUser, $wgLang;
+               global $wgUser, $wgLang, $wgContLang;
 
                $timestamp = wfTimestamp( TS_MW, $file->getTimestamp() );
                $img = $iscur ? $file->getName() : $file->getArchiveName();
@@ -946,7 +941,7 @@ class ImageHistoryList {
                                if ( !$iscur ) {
                                        $q['oldimage'] = $img;
                                }
-                               $row .= $this->skin->link(
+                               $row .= Linker::link(
                                        $this->title,
                                        wfMsgHtml( $iscur ? 'filehist-deleteall' : 'filehist-deleteone' ),
                                        array(), $q, array( 'known' )
@@ -960,7 +955,7 @@ class ImageHistoryList {
                                }
                                // If file is top revision or locked from this user, don't link
                                if ( $iscur || !$file->userCan( File::DELETED_RESTRICTED ) ) {
-                                       $del = $this->skin->revDeleteLinkDisabled( $canHide );
+                                       $del = Linker::revDeleteLinkDisabled( $canHide );
                                } else {
                                        list( $ts, $name ) = explode( '!', $img, 2 );
                                        $query = array(
@@ -968,7 +963,7 @@ class ImageHistoryList {
                                                'target' => $this->title->getPrefixedText(),
                                                'ids'    => $ts,
                                        );
-                                       $del = $this->skin->revDeleteLink( $query,
+                                       $del = Linker::revDeleteLink( $query,
                                                $file->isDeleted( File::DELETED_RESTRICTED ), $canHide );
                                }
                                $row .= $del;
@@ -984,14 +979,14 @@ class ImageHistoryList {
                        if ( $file->isDeleted( File::DELETED_FILE ) ) {
                                $row .= wfMsgHtml( 'filehist-revert' );
                        } else {
-                               $row .= $this->skin->link(
+                               $row .= Linker::link(
                                        $this->title,
                                        wfMsgHtml( 'filehist-revert' ),
                                        array(),
                                        array(
                                                'action' => 'revert',
                                                'oldimage' => $img,
-                                               'wpEditToken' => $wgUser->editToken( $img )
+                                               'wpEditToken' => $wgUser->getEditToken( $img )
                                        ),
                                        array( 'known', 'noclasses' )
                                );
@@ -1012,14 +1007,14 @@ class ImageHistoryList {
                                $this->preventClickjacking();
                                $revdel = SpecialPage::getTitleFor( 'Revisiondelete' );
                                # Make a link to review the image
-                               $url = $this->skin->link(
+                               $url = Linker::link(
                                        $revdel,
                                        $wgLang->timeAndDate( $timestamp, true ),
                                        array(),
                                        array(
                                                'target' => $this->title->getPrefixedText(),
                                                'file' => $img,
-                                               'token' => $wgUser->editToken( $img )
+                                               'token' => $wgUser->getEditToken( $img )
                                        ),
                                        array( 'known', 'noclasses' )
                                );
@@ -1041,7 +1036,7 @@ class ImageHistoryList {
                // Image dimensions + size
                $row .= '<td>';
                $row .= htmlspecialchars( $file->getDimensionsString() );
-               $row .= ' <span style="white-space: nowrap;">(' . $this->skin->formatSize( $file->getSize() ) . ')</span>';
+               $row .= ' <span style="white-space: nowrap;">(' . Linker::formatSize( $file->getSize() ) . ')</span>';
                $row .= '</td>';
 
                // Uploading user
@@ -1051,21 +1046,20 @@ class ImageHistoryList {
                        $row .= '<span class="history-deleted">' . wfMsgHtml( 'rev-deleted-user' ) . '</span>';
                } else {
                        if ( $local ) {
-                               $row .= $this->skin->userLink( $user, $usertext ) . ' <span style="white-space: nowrap;">' .
-                               $this->skin->userToolLinks( $user, $usertext ) . '</span>';
+                               $row .= Linker::userLink( $user, $usertext ) . ' <span style="white-space: nowrap;">' .
+                               Linker::userToolLinks( $user, $usertext ) . '</span>';
                        } else {
                                $row .= htmlspecialchars( $usertext );
                        }
                }
-               $row .= '</td><td>';
+               $row .= '</td>';
 
                // Don't show deleted descriptions
                if ( $file->isDeleted( File::DELETED_COMMENT ) ) {
-                       $row .= '<span class="history-deleted">' . wfMsgHtml( 'rev-deleted-comment' ) . '</span>';
+                       $row .= '<td><span class="history-deleted">' . wfMsgHtml( 'rev-deleted-comment' ) . '</span></td>';
                } else {
-                       $row .= $this->skin->commentBlock( $description, $this->title );
+                       $row .= '<td dir="' . $wgContLang->getDir() . '">' . Linker::formatComment( $description, $this->title ) . '</td>';
                }
-               $row .= '</td>';
 
                $rowClass = null;
                wfRunHooks( 'ImagePageFileHistoryLine', array( $this, $file, &$row, &$rowClass ) );
@@ -1096,7 +1090,7 @@ class ImageHistoryList {
                                        $wgLang->time( $timestamp, true ) ),
                                'file-link' => true,
                        );
-                       
+
                        if ( !$thumbnail ) {
                                return wfMsgHtml( 'filehist-nothumb' );
                        }
@@ -1107,10 +1101,16 @@ class ImageHistoryList {
                }
        }
 
+       /**
+        * @param $enable bool
+        */
        protected function preventClickjacking( $enable = true ) {
                $this->preventClickjacking = $enable;
        }
 
+       /**
+        * @return bool
+        */
        public function getPreventClickjacking() {
                return $this->preventClickjacking;
        }
@@ -1141,7 +1141,10 @@ class ImageHistoryPseudoPager extends ReverseChronologicalPager {
                $this->mHist = array();
                $this->mRange = array( 0, 0 ); // display range
        }
-       
+
+       /**
+        * @return Title
+        */
        function getTitle() {
                return $this->mTitle;
        }
@@ -1150,14 +1153,23 @@ class ImageHistoryPseudoPager extends ReverseChronologicalPager {
                return false;
        }
 
+       /**
+        * @return string
+        */
        function getIndexField() {
                return '';
        }
 
+       /**
+        * @return string
+        */
        function formatRow( $row ) {
                return '';
        }
-       
+
+       /**
+        * @return string
+        */
        function getBody() {
                $s = '';
                $this->doQuery();
@@ -1260,11 +1272,17 @@ class ImageHistoryPseudoPager extends ReverseChronologicalPager {
                }
                $this->mQueryDone = true;
        }
-       
+
+       /**
+        * @param $enable bool
+        */
        protected function preventClickjacking( $enable = true ) {
                $this->preventClickjacking = $enable;
        }
 
+       /**
+        * @return bool
+        */
        public function getPreventClickjacking() {
                return $this->preventClickjacking;
        }