* (bug 12938) Fix template expansion and 404 returns for action=raw with section
[lhc/web/wiklou.git] / includes / ImagePage.php
index e31ca15..8336837 100644 (file)
@@ -16,14 +16,19 @@ if( !defined( 'MEDIAWIKI' ) )
 class ImagePage extends Article {
 
        /* private */ var $img;  // Image object this page is shown for
+       /* private */ var $repo;
        var $mExtraDescription = false;
 
-       function __construct( $title ) {
+       function __construct( $title, $time = false ) {
                parent::__construct( $title );
-               $this->img = wfFindFile( $this->mTitle );
+               $this->img = wfFindFile( $this->mTitle, $time );
                if ( !$this->img ) {
                        $this->img = wfLocalFile( $this->mTitle );
+                       $this->current = $this->img;
+               } else {
+                       $this->current = $time ? wfLocalFile( $this->mTitle ) : $this->img;
                }
+               $this->repo = $this->img->repo;
        }
 
        /**
@@ -46,10 +51,10 @@ class ImagePage extends Article {
                        return Article::view();
 
                if ($wgShowEXIF && $this->img->exists()) {
-                       $exif = $this->img->getExifData();
-                       $showmeta = count($exif) ? true : false;
+                       // FIXME: bad interface, see note on MediaHandler::formatMetadata(). 
+                       $formattedMetadata = $this->img->formatMetadata();
+                       $showmeta = $formattedMetadata !== false;
                } else {
-                       $exif = false;
                        $showmeta = false;
                }
 
@@ -64,7 +69,7 @@ class ImagePage extends Article {
                } else {
                        # Just need to set the right headers
                        $wgOut->setArticleFlag( true );
-                       $wgOut->setRobotpolicy( 'index,follow' );
+                       $wgOut->setRobotpolicy( 'noindex,nofollow' );
                        $wgOut->setPageTitle( $this->mTitle->getPrefixedText() );
                        $this->viewUpdates();
                }
@@ -82,12 +87,12 @@ class ImagePage extends Article {
                $this->imageHistory();
                $this->imageLinks();
 
-               if ( $exif ) {
+               if ( $showmeta ) {
                        global $wgStylePath, $wgStyleVersion;
                        $expand = htmlspecialchars( wfEscapeJsString( wfMsg( 'metadata-expand' ) ) );
                        $collapse = htmlspecialchars( wfEscapeJsString( wfMsg( 'metadata-collapse' ) ) );
                        $wgOut->addHTML( Xml::element( 'h2', array( 'id' => 'metadata' ), wfMsg( 'metadata' ) ). "\n" );
-                       $wgOut->addWikiText( $this->makeMetadataTable( $exif ) );
+                       $wgOut->addWikiText( $this->makeMetadataTable( $formattedMetadata ) );
                        $wgOut->addHTML(
                                "<script type=\"text/javascript\" src=\"$wgStylePath/common/metadata.js?$wgStyleVersion\"></script>\n" .
                                "<script type=\"text/javascript\">attachMetadataToggle('mw_metadata', '$expand', '$collapse');</script>\n" );
@@ -106,9 +111,9 @@ class ImagePage extends Article {
                global $wgLang;
                $r = '<ul id="filetoc">
                        <li><a href="#file">' . $wgLang->getNsText( NS_IMAGE ) . '</a></li>
-                       <li><a href="#filehistory">' . wfMsgHtml( 'imghistory' ) . '</a></li>
+                       <li><a href="#filehistory">' . wfMsgHtml( 'filehist' ) . '</a></li>
                        <li><a href="#filelinks">' . wfMsgHtml( 'imagelinks' ) . '</a></li>' .
-                       ($metadata ? '<li><a href="#metadata">' . wfMsgHtml( 'metadata' ) . '</a></li>' : '') . '
+                       ($metadata ? ' <li><a href="#metadata">' . wfMsgHtml( 'metadata' ) . '</a></li>' : '') . '
                </ul>';
                return $r;
        }
@@ -116,49 +121,31 @@ class ImagePage extends Article {
        /**
         * Make a table with metadata to be shown in the output page.
         *
+        * FIXME: bad interface, see note on MediaHandler::formatMetadata(). 
+        *
         * @access private
         *
         * @param array $exif The array containing the EXIF data
         * @return string
         */
-       function makeMetadataTable( $exif ) {
+       function makeMetadataTable( $metadata ) {
                $r = wfMsg( 'metadata-help' ) . "\n\n";
                $r .= "{| id=mw_metadata class=mw_metadata\n";
-               $visibleFields = $this->visibleMetadataFields();
-               foreach( $exif as $k => $v ) {
-                       $tag = strtolower( $k );
-                       $msg = wfMsg( "exif-$tag" );
-                       $class = "exif-$tag";
-                       if( !in_array( $tag, $visibleFields ) ) {
-                               $class .= ' collapsable';
+               foreach ( $metadata as $type => $stuff ) {
+                       foreach ( $stuff as $v ) {
+                               $class = Sanitizer::escapeId( $v['id'] );
+                               if( $type == 'collapsed' ) {
+                                       $class .= ' collapsable';
+                               }
+                               $r .= "|- class=\"$class\"\n";
+                               $r .= "!| {$v['name']}\n";
+                               $r .= "|| {$v['value']}\n";
                        }
-                       $r .= "|- class=\"$class\"\n";
-                       $r .= "!| $msg\n";
-                       $r .= "|| $v\n";
                }
                $r .= '|}';
                return $r;
        }
 
-       /**
-        * Get a list of EXIF metadata items which should be displayed when
-        * the metadata table is collapsed.
-        *
-        * @return array of strings
-        * @access private
-        */
-       function visibleMetadataFields() {
-               $fields = array();
-               $lines = explode( "\n", wfMsgForContent( 'metadata-fields' ) );
-               foreach( $lines as $line ) {
-                       $matches = array();
-                       if( preg_match( '/^\\*\s*(.*?)\s*$/', $line, $matches ) ) {
-                               $fields[] = $matches[1];
-                       }
-               }
-               return $fields;
-       }
-
        /**
         * Overloading Article's getContent method.
         * 
@@ -173,7 +160,7 @@ class ImagePage extends Article {
        }
 
        function openShowImage() {
-               global $wgOut, $wgUser, $wgImageLimits, $wgRequest, $wgLang;
+               global $wgOut, $wgUser, $wgImageLimits, $wgRequest, $wgLang, $wgContLang;
 
                $full_url  = $this->img->getURL();
                $linkAttribs = false;
@@ -192,6 +179,7 @@ class ImagePage extends Article {
                $maxWidth = $max[0];
                $maxHeight = $max[1];
                $sk = $wgUser->getSkin();
+               $dirmark = $wgContLang->getDirMark();
 
                if ( $this->img->exists() ) {
                        # image
@@ -209,14 +197,15 @@ class ImagePage extends Article {
                        $mime = $this->img->getMimeType();
                        $showLink = false;
                        $linkAttribs = array( 'href' => $full_url );
+                       $longDesc = $this->img->getLongDesc();
 
-      wfRunHooks( 'ImageOpenShowImageInlineBefore', array( &$this , &$wgOut ) )        ;
+                       wfRunHooks( 'ImageOpenShowImageInlineBefore', array( &$this , &$wgOut ) )       ;
 
-                       if ( $this->img->allowInlineDisplay() and $width and $height) {
+                       if ( $this->img->allowInlineDisplay() ) {
                                # image
 
                                # "Download high res version" link below the image
-                               $msgsize = wfMsgHtml('file-info-size', $width_orig, $height_orig, $sk->formatSize( $this->img->getSize() ), $mime );
+                               #$msgsize = wfMsgHtml('file-info-size', $width_orig, $height_orig, $sk->formatSize( $this->img->getSize() ), $mime );
                                # We'll show a thumbnail of this image
                                if ( $width > $maxWidth || $height > $maxHeight ) {
                                        # Calculate the thumbnail size.
@@ -234,7 +223,7 @@ class ImagePage extends Article {
                                        }
                                        $msgbig  = wfMsgHtml( 'show-big-image' );
                                        $msgsmall = wfMsgExt( 'show-big-image-thumb',
-                                               array( 'parseinline' ), $width, $height );
+                                               array( 'parseinline' ), $wgLang->formatNum( $width ), $wgLang->formatNum( $height ) );
                                } else {
                                        # Image is small enough to show full size on image page
                                        $msgbig = htmlspecialchars( $this->img->getName() );
@@ -250,21 +239,20 @@ class ImagePage extends Article {
                                } else {
                                        $anchorclose .= 
                                                $msgsmall .
-                                               '<br />' . Xml::tags( 'a', $linkAttribs,  $msgbig ) . ' ' . $msgsize;
+                                               '<br />' . Xml::tags( 'a', $linkAttribs,  $msgbig ) . "$dirmark " . $longDesc;
                                }
 
                                if ( $this->img->isMultipage() ) {
                                        $wgOut->addHTML( '<table class="multipageimage"><tr><td>' );
                                }
 
-                               $imgAttribs = array(
-                                       'border' => 0,
-                                       'alt' => $this->img->getTitle()->getPrefixedText()
-                               );
-
                                if ( $thumbnail ) {
+                                       $options = array( 
+                                               'alt' => $this->img->getTitle()->getPrefixedText(),
+                                               'file-link' => true,
+                                       );
                                        $wgOut->addHTML( '<div class="fullImageLink" id="file">' . 
-                                               $thumbnail->toHtml( $imgAttribs, $linkAttribs ) .
+                                               $thumbnail->toHtml( $options ) .
                                                $anchorclose . '</div>' );
                                }
 
@@ -312,9 +300,9 @@ class ImagePage extends Article {
                                if ($this->img->isSafeFile()) {
                                        $icon= $this->img->iconThumb();
 
-                                       $wgOut->addHTML( '<div class="fullImageLink" id="file"><a href="' . $full_url . '">' .
-                                       $icon->toHtml() .
-                                       '</a></div>' );
+                                       $wgOut->addHTML( '<div class="fullImageLink" id="file">' .
+                                       $icon->toHtml( array( 'desc-link' => true ) ) .
+                                       '</div>' );
                                }
 
                                $showLink = true;
@@ -322,26 +310,14 @@ class ImagePage extends Article {
 
 
                        if ($showLink) {
-                               // Workaround for incorrect MIME type on SVGs uploaded in previous versions
-                               if ($mime == 'image/svg') $mime = 'image/svg+xml';
-
                                $filename = wfEscapeWikiText( $this->img->getName() );
-                               $info = wfMsg( 'file-info', $sk->formatSize( $this->img->getSize() ), $mime );
-                               $infores = '';
 
-                               // Check for MIME type. Other types may have more information in the future.
-                               if (substr($mime,0,9) == 'image/svg' ) {
-                                       $infores = wfMsg('file-svg', $width_orig, $height_orig ) . '<br />';
-                               }
-
-                               global $wgContLang;
-                               $dirmark = $wgContLang->getDirMark();
                                if (!$this->img->isSafeFile()) {
                                        $warning = wfMsg( 'mediawarning' );
                                        $wgOut->addWikiText( <<<EOT
-<div class="fullMedia">$infores
+<div class="fullMedia">
 <span class="dangerousLink">[[Media:$filename|$filename]]</span>$dirmark
-<span class="fileInfo"> $info</span>
+<span class="fileInfo"> $longDesc</span>
 </div>
 
 <div class="mediaWarning">$warning</div>
@@ -349,8 +325,8 @@ EOT
                                                );
                                } else {
                                        $wgOut->addWikiText( <<<EOT
-<div class="fullMedia">$infores
-[[Media:$filename|$filename]]$dirmark <span class="fileInfo"> $info</span>
+<div class="fullMedia">
+[[Media:$filename|$filename]]$dirmark <span class="fileInfo"> $longDesc</span>
 </div>
 EOT
                                                );
@@ -438,28 +414,32 @@ EOT
 
                $sk = $wgUser->getSkin();
 
-               $line = $this->img->nextHistoryLine();
-
-               if ( $line ) {
-                       $list = new ImageHistoryList( $sk, $this->img );
+               if ( $this->img->exists() ) {
+                       $list = new ImageHistoryList( $sk, $this->current );
+                       $file = $this->current;
+                       $dims = $file->getDimensionsString();
                        $s = $list->beginImageHistoryList() .
-                               $list->imageHistoryLine( true, wfTimestamp(TS_MW, $line->img_timestamp),
-                                       $this->mTitle->getDBkey(),  $line->img_user,
-                                       $line->img_user_text, $line->img_size, $line->img_description,
-                                       $line->img_width, $line->img_height
+                               $list->imageHistoryLine( true, wfTimestamp(TS_MW, $file->getTimestamp()),
+                                       $this->mTitle->getDBkey(),  $file->getUser('id'),
+                                       $file->getUser('text'), $file->getSize(), $file->getDescription(),
+                                       $dims
                                );
 
-                       while ( $line = $this->img->nextHistoryLine() ) {
-                               $s .= $list->imageHistoryLine( false, $line->img_timestamp,
-                                       $line->oi_archive_name, $line->img_user,
-                                       $line->img_user_text, $line->img_size, $line->img_description,
-                                       $line->img_width, $line->img_height
+                       $hist = $this->img->getHistory();
+                       foreach( $hist as $file ) {
+                               $dims = $file->getDimensionsString();
+                               $s .= $list->imageHistoryLine( false, wfTimestamp(TS_MW, $file->getTimestamp()),
+                                       $file->getArchiveName(), $file->getUser('id'),
+                                       $file->getUser('text'), $file->getSize(), $file->getDescription(),
+                                       $dims
                                );
                        }
                        $s .= $list->endImageHistoryList();
                } else { $s=''; }
                $wgOut->addHTML( $s );
 
+               $this->img->resetHistory();     // free db resources
+
                # Exist check because we don't want to show this on pages where an image
                # doesn't exist along with the noimage message, that would suck. -ævar
                if( $wgUseExternalEditor && $this->img->exists() ) {
@@ -498,186 +478,25 @@ EOT
                $wgOut->addHTML( "</ul>\n" );
        }
 
-       function delete()
-       {
-               global $wgUser, $wgOut, $wgRequest;
-
-               if ( !$this->img->exists() || !$this->img->isLocal() ) {
-                       # Use standard article deletion
+       /**
+        * Delete the file, or an earlier version of it
+        */
+       public function delete() {
+               if( !$this->img->exists() || !$this->img->isLocal() ) {
+                       // Standard article deletion
                        Article::delete();
                        return;
                }
-
-               $confirm = $wgRequest->wasPosted();
-               $reason = $wgRequest->getVal( 'wpReason' );
-               $image = $wgRequest->getVal( 'image' );
-               $oldimage = $wgRequest->getVal( 'oldimage' );
-
-               # Only sysops can delete images. Previously ordinary users could delete
-               # old revisions, but this is no longer the case.
-               if ( !$wgUser->isAllowed('delete') ) {
-                       $wgOut->permissionRequired( 'delete' );
-                       return;
-               }
-               if ( $wgUser->isBlocked() ) {
-                       $wgOut->blockedPage();
-                       return;
-               }
-               if ( wfReadOnly() ) {
-                       $wgOut->readOnlyPage();
-                       return;
-               }
-
-               # Better double-check that it hasn't been deleted yet!
-               $wgOut->setPagetitle( wfMsg( 'confirmdelete' ) );
-               if ( ( !is_null( $image ) )
-                 && ( '' == trim( $image ) ) ) {
-                       $wgOut->showFatalError( wfMsg( 'cannotdelete' ) );
-                       return;
-               }
-
-               # Deleting old images doesn't require confirmation
-               if ( !is_null( $oldimage ) || $confirm ) {
-                       if( $wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ), $oldimage ) ) {
-                               $this->doDeleteImage( $reason );
-                       } else {
-                               $wgOut->showFatalError( wfMsg( 'sessionfailure' ) );
-                       }
-                       return;
-               }
-
-               if ( !is_null( $image ) ) {
-                       $q = '&image=' . urlencode( $image );
-               } else if ( !is_null( $oldimage ) ) {
-                       $q = '&oldimage=' . urlencode( $oldimage );
-               } else {
-                       $q = '';
-               }
-               return $this->confirmDelete( $q, $wgRequest->getText( 'wpReason' ) );
-       }
-
-       /*
-        * Delete an image.
-        * Called doDeleteImage() not doDelete() so that Article::delete() doesn't 
-        * call back to here.
-        *
-        * @param $reason User provided reason for deletion.
-        */
-       function doDeleteImage( $reason ) {
-               global $wgOut, $wgRequest;
-
-               $oldimage = $wgRequest->getVal( 'oldimage' );
-
-               if ( !is_null( $oldimage ) ) {
-                       if ( strlen( $oldimage ) < 16 ) {
-                               $wgOut->showUnexpectedValueError( 'oldimage', htmlspecialchars($oldimage) );
-                               return;
-                       }
-                       if ( strstr( $oldimage, "/" ) || strstr( $oldimage, "\\" ) ) {
-                               $wgOut->showUnexpectedValueError( 'oldimage', htmlspecialchars($oldimage) );
-                               return;
-                       }
-                       if ( !$this->doDeleteOldImage( $oldimage ) ) {
-                               return;
-                       }
-                       $deleted = $oldimage;
-               } else {
-                       $ok = $this->img->delete( $reason );
-                       if( !$ok ) {
-                               # If the deletion operation actually failed, bug out:
-                               $wgOut->showFileDeleteError( $this->img->getName() );
-                               return;
-                       }
-                       
-                       # Image itself is now gone, and database is cleaned.
-                       # Now we remove the image description page.
-       
-                       $article = new Article( $this->mTitle );
-                       $article->doDeleteArticle( $reason ); # ignore errors
-
-                       $deleted = $this->img->getName();
-               }
-
-               $wgOut->setPagetitle( wfMsg( 'actioncomplete' ) );
-               $wgOut->setRobotpolicy( 'noindex,nofollow' );
-
-               $loglink = '[[Special:Log/delete|' . wfMsg( 'deletionlog' ) . ']]';
-               $text = wfMsg( 'deletedtext', $deleted, $loglink );
-
-               $wgOut->addWikiText( $text );
-
-               $wgOut->returnToMain( false, $this->mTitle->getPrefixedText() );
+               $deleter = new FileDeleteForm( $this->img );
+               $deleter->execute();
        }
 
        /**
-        * @return success
+        * Revert the file to an earlier version
         */
-       function doDeleteOldImage( $oldimage )
-       {
-               global $wgOut;
-
-               $ok = $this->img->deleteOld( $oldimage, '' );
-               if( !$ok ) {
-                       # If we actually have a file and can't delete it, throw an error.
-                       # Something went awry...
-                       $wgOut->showFileDeleteError( "$oldimage" );
-               } else {
-                       # Log the deletion
-                       $log = new LogPage( 'delete' );
-                       $log->addEntry( 'delete', $this->mTitle, wfMsg('deletedrevision',$oldimage) );
-               }
-               return $ok;
-       }
-
-       function revert() {
-               global $wgOut, $wgRequest, $wgUser;
-
-               $oldimage = $wgRequest->getText( 'oldimage' );
-               if ( strlen( $oldimage ) < 16 ) {
-                       $wgOut->showUnexpectedValueError( 'oldimage', htmlspecialchars($oldimage) );
-                       return;
-               }
-               if ( strstr( $oldimage, "/" ) || strstr( $oldimage, "\\" ) ) {
-                       $wgOut->showUnexpectedValueError( 'oldimage', htmlspecialchars($oldimage) );
-                       return;
-               }
-
-               if ( wfReadOnly() ) {
-                       $wgOut->readOnlyPage();
-                       return;
-               }
-               if( $wgUser->isAnon() ) {
-                       $wgOut->showErrorPage( 'uploadnologin', 'uploadnologintext' );
-                       return;
-               }
-               if ( ! $this->mTitle->userCan( 'edit' ) ) {
-                       $wgOut->readOnlyPage( $this->getContent(), true );
-                       return;
-               }
-               if ( $wgUser->isBlocked() ) {
-                       $wgOut->blockedPage();
-                       return;
-               }
-               if( !$wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ), $oldimage ) ) {
-                       $wgOut->showErrorPage( 'internalerror', 'sessionfailure' );
-                       return;
-               }
-
-               $sourcePath = $this->img->getArchiveVirtualUrl( $oldimage );
-               $comment = wfMsg( "reverted" );
-               $result = $this->img->upload( $sourcePath, $comment, $comment );
-
-               if ( WikiError::isError( $result ) ) {
-                       $this->showError( $result );
-                       return;
-               }
-
-               $wgOut->setPagetitle( wfMsg( 'actioncomplete' ) );
-               $wgOut->setRobotpolicy( 'noindex,nofollow' );
-               $wgOut->addHTML( wfMsg( 'imagereverted' ) );
-
-               $descTitle = $this->img->getTitle();
-               $wgOut->returnToMain( false, $descTitle->getPrefixedText() );
+       public function revert() {
+               $reverter = new FileRevertForm( $this->img );
+               $reverter->execute();
        }
        
        /**
@@ -697,99 +516,132 @@ EOT
        }
 
        /**
-        * Display an error from a wikitext-formatted WikiError object
+        * Display an error with a wikitext description
         */
-       function showError( WikiError $error ) {
+       function showError( $description ) {
                global $wgOut;
                $wgOut->setPageTitle( wfMsg( "internalerror" ) );
                $wgOut->setRobotpolicy( "noindex,nofollow" );
                $wgOut->setArticleRelated( false );
                $wgOut->enableClientCache( false );
-               $wgOut->addWikiText( $error->getMessage() );
+               $wgOut->addWikiText( $description );
        }
 
 }
 
 /**
- * @todo document
+ * Builds the image revision log shown on image pages
+ *
  * @addtogroup Media
  */
 class ImageHistoryList {
-       var $img, $skin;
-       function ImageHistoryList( $skin, $img ) {
+
+       protected $img, $skin, $title, $repo;
+
+       public function __construct( $skin, $img ) {
                $this->skin = $skin;
                $this->img = $img;
+               $this->title = $img->getTitle();
        }
 
-       function beginImageHistoryList() {
-               $s = "\n" .
-                       Xml::element( 'h2', array( 'id' => 'filehistory' ), wfMsg( 'imghistory' ) ) .
-                       "\n<p>" . wfMsg( 'imghistlegend' ) . "</p>\n".'<ul class="special">';
-               return $s;
+       public function beginImageHistoryList() {
+               global $wgOut, $wgUser;
+               return Xml::element( 'h2', array( 'id' => 'filehistory' ), wfMsg( 'filehist' ) )
+                       . $wgOut->parse( wfMsgNoTrans( 'filehist-help' ) )
+                       . Xml::openElement( 'table', array( 'class' => 'filehistory' ) ) . "\n"
+                       . '<tr><td></td>'
+                       . ( $this->img->isLocal() && $wgUser->isAllowed( 'delete' ) ? '<td></td>' : '' )
+                       . '<th>' . wfMsgHtml( 'filehist-datetime' ) . '</th>'
+                       . '<th>' . wfMsgHtml( 'filehist-user' ) . '</th>'
+                       . '<th>' . wfMsgHtml( 'filehist-dimensions' ) . '</th>'
+                       . '<th class="mw-imagepage-filesize">' . wfMsgHtml( 'filehist-filesize' ) . '</th>'
+                       . '<th>' . wfMsgHtml( 'filehist-comment' ) . '</th>'
+                       . "</tr>\n";
        }
 
-       function endImageHistoryList() {
-               $s = "</ul>\n";
-               return $s;
+       public function endImageHistoryList() {
+               return "</table>\n";
        }
 
-       function imageHistoryLine( $iscur, $timestamp, $img, $user, $usertext, $size, $description, $width, $height ) {
-               global $wgUser, $wgLang, $wgTitle, $wgContLang;
-
-               $datetime = $wgLang->timeanddate( $timestamp, true );
-               $del = wfMsgHtml( 'deleteimg' );
-               $delall = wfMsgHtml( 'deleteimgcompletely' );
-               $cur = wfMsgHtml( 'cur' );
+       /**
+        * Create one row of file history
+        *
+        * @param bool $iscur is this the current file version?
+        * @param string $timestamp timestamp of file version
+        * @param string $img filename
+        * @param int $user ID of uploading user
+        * @param string $usertext username of uploading user
+        * @param int $size size of file version
+        * @param string $description description of file version
+        * @param string $dims dimensions of file version
+        * @return string a HTML formatted table row
+        */
+       public function imageHistoryLine( $iscur, $timestamp, $img, $user, $usertext, $size, $description, $dims ) {
+               global $wgUser, $wgLang, $wgContLang;
                $local = $this->img->isLocal();
-
-               if ( $iscur ) {
-                       $url = htmlspecialchars( $this->img->getURL() );
-                       $rlink = $cur;
-                       if ( $local && $wgUser->isAllowed('delete') ) {
-                               $link = $wgTitle->escapeLocalURL( 'image=' . $wgTitle->getPartialURL() .
-                                 '&action=delete' );
-                               $style = $this->skin->getInternalLinkAttributes( $link, $delall );
-
-                               $dlink = '<a href="'.$link.'"'.$style.'>'.$delall.'</a>';
-                       } else {
-                               $dlink = $del;
-                       }
+               $row = '';
+
+               // Deletion link
+               if( $local && $wgUser->isAllowed( 'delete' ) ) {
+                       $row .= '<td>';
+                       $q = array();
+                       $q[] = 'action=delete';
+                       if( !$iscur )
+                               $q[] = 'oldimage=' . urlencode( $img );
+                       $row .= $this->skin->makeKnownLinkObj(
+                               $this->title,
+                               wfMsgHtml( $iscur ? 'filehist-deleteall' : 'filehist-deleteone' ),
+                               implode( '&', $q )
+                       );
+                       $row .= '</td>';
+               }
+
+               // Reversion link/current indicator
+               $row .= '<td>';
+               if( $iscur ) {
+                       $row .= wfMsgHtml( 'filehist-current' );
+               } elseif( $local && $wgUser->isLoggedIn() && $this->title->userCan( 'edit' ) ) {
+                       $q = array();
+                       $q[] = 'action=revert';
+                       $q[] = 'oldimage=' . urlencode( $img );
+                       $q[] = 'wpEditToken=' . urlencode( $wgUser->editToken( $img ) );
+                       $row .= $this->skin->makeKnownLinkObj(
+                               $this->title,
+                               wfMsgHtml( 'filehist-revert' ),
+                               implode( '&', $q )
+                       );
+               }
+               $row .= '</td>';
+
+               // Date/time and image link
+               $row .= '<td>';
+               $url = $iscur ? $this->img->getUrl() : $this->img->getArchiveUrl( $img );
+               $row .= Xml::element(
+                       'a',
+                       array( 'href' => $url ),
+                       $wgLang->timeAndDate( $timestamp, true )
+               );
+               $row .= '</td>';
+
+               // Uploading user
+               $row .= '<td>';
+               if( $local ) {
+                       $row .= $this->skin->userLink( $user, $usertext ) . $this->skin->userToolLinks( $user, $usertext );
                } else {
-                       $url = htmlspecialchars( $this->img->getArchiveUrl( $img ) );
-                       if( $local && $wgUser->getID() != 0 && $wgTitle->userCan( 'edit' ) ) {
-                               $token = urlencode( $wgUser->editToken( $img ) );
-                               $rlink = $this->skin->makeKnownLinkObj( $wgTitle,
-                                          wfMsgHtml( 'revertimg' ), 'action=revert&oldimage=' .
-                                          urlencode( $img ) . "&wpEditToken=$token" );
-                               $dlink = $this->skin->makeKnownLinkObj( $wgTitle,
-                                          $del, 'action=delete&oldimage=' . urlencode( $img ) .
-                                          "&wpEditToken=$token" );
-                       } else {
-                               # Having live active links for non-logged in users
-                               # means that bots and spiders crawling our site can
-                               # inadvertently change content. Baaaad idea.
-                               $rlink = wfMsgHtml( 'revertimg' );
-                               $dlink = $del;
-                       }
+                       $row .= htmlspecialchars( $usertext );
                }
+               $row .= '</td>';
 
-               if ( $local ) {
-                       $userlink = $this->skin->userLink( $user, $usertext ) . $this->skin->userToolLinks( $user, $usertext );
-               } else {
-                       $userlink = htmlspecialchars( $usertext );
-               }
-               $nbytes = wfMsgExt( 'nbytes', array( 'parsemag', 'escape' ),
-                       $wgLang->formatNum( $size ) );
-               $widthheight = wfMsgHtml( 'widthheight', $width, $height );
-               $style = $this->skin->getInternalLinkAttributes( $url, $datetime );
+               // Image dimensions
+               $row .= '<td>' . htmlspecialchars( $dims ) . '</td>';
 
-               $s = "<li> ({$dlink}) ({$rlink}) <a href=\"{$url}\"{$style}>{$datetime}</a> . . {$userlink} . . {$widthheight} ({$nbytes})";
+               // File size
+               $row .= '<td class="mw-imagepage-filesize">' . $this->skin->formatSize( $size ) . '</td>';
 
-               $s .= $this->skin->commentBlock( $description, $wgTitle );
-               $s .= "</li>\n";
-               return $s;
-       }
-}
+               // Comment
+               $row .= '<td>' . $this->skin->formatComment( $description, $this->title ) . '</td>';
 
+               return "<tr>{$row}</tr>\n";
+       }
 
-?>
+}