-rakkaus/#mediawiki-i18n- (1 lines skipped) [06-Oct-2011 16:12:26] PHP Fatal error...
[lhc/web/wiklou.git] / includes / ImageGallery.php
index 9a37202..a40a685 100644 (file)
@@ -9,8 +9,7 @@ if ( ! defined( 'MEDIAWIKI' ) )
  *
  * @ingroup Media
  */
-class ImageGallery
-{
+class ImageGallery {
        var $mImages, $mShowBytes, $mShowFilename;
        var $mCaption = false;
 
@@ -29,21 +28,22 @@ class ImageGallery
         * Contextual title, used when images are being screened
         * against the bad image list
         */
-       private $contextTitle = false;
+       protected $contextTitle = false;
 
-       private $mAttribs = array();
+       protected $mAttribs = array();
 
        /**
         * Fixed margins
         */
        const THUMB_PADDING = 30;
        const GB_PADDING = 5;
-       const GB_BORDERS = 6;
+       // 2px borders on each side + 2px implied padding on each side
+       const GB_BORDERS = 8;
 
        /**
         * Create a new image gallery object.
         */
-       function __construct( ) {
+       function __construct() {
                global $wgGalleryOptions;
                $this->mImages = array();
                $this->mShowBytes = $wgGalleryOptions['showBytes'];
@@ -58,6 +58,8 @@ class ImageGallery
 
        /**
         * Register a parser object
+        *
+        * @param $parser Parser
         */
        function setParser( $parser ) {
                $this->mParser = $parser;
@@ -95,7 +97,7 @@ class ImageGallery
         * invalid numbers will be rejected
         */
        public function setPerRow( $num ) {
-               if ($num >= 0) {
+               if ( $num >= 0 ) {
                        $this->mPerRow = (int)$num;
                }
        }
@@ -106,7 +108,7 @@ class ImageGallery
         * @param $num Integer > 0; invalid numbers will be ignored
         */
        public function setWidths( $num ) {
-               if ($num > 0) {
+               if ( $num > 0 ) {
                        $this->mWidths = (int)$num;
                }
        }
@@ -117,7 +119,7 @@ class ImageGallery
         * @param $num Integer > 0; invalid numbers will be ignored
         */
        public function setHeights( $num ) {
-               if ($num > 0) {
+               if ( $num > 0 ) {
                        $this->mHeights = (int)$num;
                }
        }
@@ -126,9 +128,10 @@ class ImageGallery
         * Instruct the class to use a specific skin for rendering
         *
         * @param $skin Skin object
-        * @deprecated Not used anymore
+        * @deprecated since 1.18 Not used anymore
         */
        function useSkin( $skin ) {
+               wfDeprecated( __METHOD__ );
                /* no op */
        }
 
@@ -145,7 +148,7 @@ class ImageGallery
                        $title = $title->getTitle();
                }
                $this->mImages[] = array( $title, $html, $alt );
-               wfDebug( "ImageGallery::add " . $title->getText() . "\n" );
+               wfDebug( 'ImageGallery::add ' . $title->getText() . "\n" );
        }
 
        /**
@@ -155,7 +158,7 @@ class ImageGallery
        * @param $html  String: Additional HTML text to be shown. The name and size of the image are always shown.
        * @param $alt   String: Alt text for the image
        */
-       function insert( $title, $html='', $alt='' ) {
+       function insert( $title, $html = '', $alt = '' ) {
                if ( $title instanceof File ) {
                        // Old calling convention
                        $title = $title->getTitle();
@@ -163,7 +166,6 @@ class ImageGallery
                array_unshift( $this->mImages, array( &$title, $html, $alt ) );
        }
 
-
        /**
         * isEmpty() returns true if the gallery contains no images
         */
@@ -219,7 +221,7 @@ class ImageGallery
 
                if ( $this->mPerRow > 0 ) {
                        $maxwidth = $this->mPerRow * ( $this->mWidths + self::THUMB_PADDING + self::GB_PADDING + self::GB_BORDERS );
-                       $oldStyle = isset( $this->mAttribs['style'] ) ? $this->mAttribs['style'] : ""; 
+                       $oldStyle = isset( $this->mAttribs['style'] ) ? $this->mAttribs['style'] : '';
                        # _width is ignored by any sane browser. IE6 doesn't know max-width so it uses _width instead
                        $this->mAttribs['style'] = "max-width: {$maxwidth}px;_width: {$maxwidth}px;" . $oldStyle;
                }
@@ -232,7 +234,10 @@ class ImageGallery
                        $output .= "\n\t<li class='gallerycaption'>{$this->mCaption}</li>";
                }
 
-               $params = array( 'width' => $this->mWidths, 'height' => $this->mHeights );
+               $params = array(
+                       'width' => $this->mWidths,
+                       'height' => $this->mHeights
+               );
                # Output each image...
                foreach ( $this->mImages as $pair ) {
                        $nt = $pair[0];
@@ -244,11 +249,11 @@ class ImageGallery
                                # Get the file...
                                if ( $this->mParser instanceof Parser ) {
                                        # Give extensions a chance to select the file revision for us
-                                       $time = $sha1 = false;
+                                       $options = array();
                                        wfRunHooks( 'BeforeParserFetchFileAndTitle',
-                                               array( $this->mParser, $nt, &$time, &$sha1, &$descQuery ) );
+                                               array( $this->mParser, $nt, &$options, &$descQuery ) );
                                        # Fetch and register the file (file title may be different via hooks)
-                                       list( $img, $nt ) = $this->mParser->fetchFileAndTitle( $nt, $time, $sha1 );
+                                       list( $img, $nt ) = $this->mParser->fetchFileAndTitle( $nt, $options );
                                } else {
                                        $img = wfFindFile( $nt );
                                }
@@ -258,11 +263,11 @@ class ImageGallery
 
                        if( !$img ) {
                                # We're dealing with a non-image, spit out the name and be done with it.
-                               $thumbhtml = "\n\t\t\t".'<div style="height: '.(self::THUMB_PADDING + $this->mHeights).'px;">'
+                               $thumbhtml = "\n\t\t\t" . '<div style="height: ' . ( self::THUMB_PADDING + $this->mHeights ) . 'px;">'
                                        . htmlspecialchars( $nt->getText() ) . '</div>';
                        } elseif( $this->mHideBadImages && wfIsBadImage( $nt->getDBkey(), $this->getContextTitle() ) ) {
                                # The image is blacklisted, just show it as a text link.
-                               $thumbhtml = "\n\t\t\t".'<div style="height: '.(self::THUMB_PADDING + $this->mHeights).'px;">' .
+                               $thumbhtml = "\n\t\t\t" . '<div style="height: ' . ( self::THUMB_PADDING + $this->mHeights ) . 'px;">' .
                                        Linker::link(
                                                $nt,
                                                htmlspecialchars( $nt->getText() ),
@@ -273,14 +278,10 @@ class ImageGallery
                                        '</div>';
                        } elseif( !( $thumb = $img->transform( $params ) ) ) {
                                # Error generating thumbnail.
-                               $thumbhtml = "\n\t\t\t".'<div style="height: '.(self::THUMB_PADDING + $this->mHeights).'px;">'
+                               $thumbhtml = "\n\t\t\t" . '<div style="height: ' . ( self::THUMB_PADDING + $this->mHeights ) . 'px;">'
                                        . htmlspecialchars( $img->getLastError() ) . '</div>';
                        } else {
-                               # We get layout problems with the margin, if the image is smaller 
-                               # than the line-height (17), so we add less margin in these cases.
-                               $minThumbHeight =  $thumb->height > 17 ? $thumb->height : 17;
-                               $vpad = floor(( self::THUMB_PADDING + $this->mHeights - $minThumbHeight ) /2);
-                               
+                               $vpad = ( self::THUMB_PADDING + $this->mHeights - $thumb->height ) /2;
 
                                $imageParameters = array(
                                        'desc-link' => true,
@@ -293,12 +294,12 @@ class ImageGallery
                                }
 
                                # Set both fixed width and min-height.
-                               $thumbhtml = "\n\t\t\t".
-                                       '<div class="thumb" style="width: ' .($this->mWidths + self::THUMB_PADDING).'px;">'
+                               $thumbhtml = "\n\t\t\t" .
+                                       '<div class="thumb" style="width: ' . ( $this->mWidths + self::THUMB_PADDING ) . 'px;">'
                                        # Auto-margin centering for block-level elements. Needed now that we have video
                                        # handlers since they may emit block-level elements as opposed to simple <img> tags.
                                        # ref http://css-discuss.incutio.com/?page=CenteringBlockElement
-                                       . '<div style="margin:'.$vpad.'px auto;">'
+                                       . '<div style="margin:' . $vpad . 'px auto;">'
                                        . $thumb->toHtml( $imageParameters ) . '</div></div>';
 
                                // Call parser transform hook