Revert Special:Log to r20745 with non-ugly form
[lhc/web/wiklou.git] / includes / Image.php
index c66c6bb..6a5e730 100644 (file)
@@ -1,6 +1,5 @@
 <?php
 /**
- * @package MediaWiki
  */
 
 /**
@@ -22,10 +21,14 @@ define( 'MW_IMAGE_VERSION', 1 );
  *
  * Provides methods to retrieve paths (physical, logical, URL),
  * to generate thumbnails or for uploading.
- * @package MediaWiki
  */
 class Image
 {
+       const DELETED_FILE = 1;
+       const DELETED_COMMENT = 2;
+       const DELETED_USER = 4;
+    const DELETED_RESTRICTED = 8;
+    
        /**#@+
         * @private
         */
@@ -43,6 +46,7 @@ class Image
                $attr,          # /
                $type,          # MEDIATYPE_xxx (bitmap, drawing, audio...)
                $mime,          # MIME type, determined by MimeMagic::guessMimeType
+               $extension,     # The file extension (constructor)
                $size,          # Size in bytes (loadFromXxx)
                $metadata,      # Metadata
                $dataLoaded,    # Whether or not all this has been loaded from the database (loadFromXxx)
@@ -58,7 +62,7 @@ class Image
         * @param string $name name of the image, used to create a title object using Title::makeTitleSafe
         * @public
         */
-       function newFromName( $name ) {
+       public static function newFromName( $name ) {
                $title = Title::makeTitleSafe( NS_IMAGE, $name );
                if ( is_object( $title ) ) {
                        return new Image( $title );
@@ -92,7 +96,6 @@ class Image
                $this->dataLoaded = false;
        }
 
-       
        /**
         * Normalize a file extension to the common form, and ensure it's clean.
         * Extensions with non-alphanumeric characters will be discarded.
@@ -115,18 +118,18 @@ class Image
                        return '';
                }
        }
-       
+
        /**
         * Get the memcached keys
         * Returns an array, first element is the local cache key, second is the shared cache key, if there is one
         */
        function getCacheKeys( ) {
-               global $wgDBname, $wgUseSharedUploads, $wgSharedUploadDBname, $wgCacheSharedUploads;
+               global $wgUseSharedUploads, $wgSharedUploadDBname, $wgCacheSharedUploads;
 
                $hashedName = md5($this->name);
-               $keys = array( "$wgDBname:Image:$hashedName" );
+               $keys = array( wfMemcKey( 'Image', $hashedName ) );
                if ( $wgUseSharedUploads && $wgSharedUploadDBname && $wgCacheSharedUploads ) {
-                       $keys[] = "$wgSharedUploadDBname:Image:$hashedName";
+                       $keys[] = wfForeignMemcKey( $wgSharedUploadDBname, false, 'Image', $hashedName );
                }
                return $keys;
        }
@@ -235,12 +238,13 @@ class Image
         * Load metadata from the file itself
         */
        function loadFromFile() {
-               global $wgUseSharedUploads, $wgSharedUploadDirectory, $wgContLang, $wgShowEXIF;
+               global $wgUseSharedUploads, $wgSharedUploadDirectory, $wgContLang;
                wfProfileIn( __METHOD__ );
                $this->imagePath = $this->getFullPath();
                $this->fileExists = file_exists( $this->imagePath );
                $this->fromSharedDirectory = false;
                $gis = array();
+               $deja = false;
 
                if (!$this->fileExists) wfDebug(__METHOD__.': '.$this->imagePath." not found locally!\n");
 
@@ -268,22 +272,8 @@ class Image
                        # Get size in bytes
                        $this->size = filesize( $this->imagePath );
 
-                       $magic=& MimeMagic::singleton();
-
                        # Height and width
-                       wfSuppressWarnings();
-                       if( $this->mime == 'image/svg' ) {
-                               $gis = wfGetSVGsize( $this->imagePath );
-                       } elseif( $this->mime == 'image/vnd.djvu' ) {
-                               $deja = new DjVuImage( $this->imagePath );
-                               $gis = $deja->getImageSize();
-                       } elseif ( !$magic->isPHPImageType( $this->mime ) ) {
-                               # Don't try to get the width and height of sound and video files, that's bad for performance
-                               $gis = false;
-                       } else {
-                               $gis = getimagesize( $this->imagePath );
-                       }
-                       wfRestoreWarnings();
+                       $gis = self::getImageSize( $this->imagePath, $this->mime, $deja );
 
                        wfDebug(__METHOD__.': '.$this->imagePath." loaded, ".$this->size." bytes, ".$this->mime.".\n");
                }
@@ -309,7 +299,7 @@ class Image
                $this->dataLoaded = true;
 
 
-               if ( $this->mime == 'image/vnd.djvu' ) {
+               if ( $deja ) {
                        $this->metadata = $deja->retrieveMetaData();
                } else {
                        $this->metadata = serialize( $this->retrieveExifData( $this->imagePath ) );
@@ -328,7 +318,7 @@ class Image
                global $wgUseSharedUploads, $wgSharedUploadDBname, $wgSharedUploadDBprefix, $wgContLang;
                wfProfileIn( __METHOD__ );
 
-               $dbr =& wfGetDB( DB_SLAVE );
+               $dbr = wfGetDB( DB_SLAVE );
                $this->checkDBSchema($dbr);
 
                $row = $dbr->selectRow( 'image',
@@ -349,7 +339,7 @@ class Image
                        # capitalize the first letter of the filename before
                        # looking it up in the shared repository.
                        $name = $wgContLang->ucfirst($this->name);
-                       $dbc =& wfGetDB( DB_SLAVE, 'commons' );
+                       $dbc = Image::getCommonsDB();
 
                        $row = $dbc->selectRow( "`$wgSharedUploadDBname`.{$wgSharedUploadDBprefix}image",
                                array(
@@ -451,10 +441,9 @@ class Image
 
                        // Write to the other DB using selectDB, not database selectors
                        // This avoids breaking replication in MySQL
-                       $dbw =& wfGetDB( DB_MASTER, 'commons' );
-                       $dbw->selectDB( $wgSharedUploadDBname );
+                       $dbw = Image::getCommonsDB();
                } else {
-                       $dbw =& wfGetDB( DB_MASTER );
+                       $dbw = wfGetDB( DB_MASTER );
                }
 
                $this->checkDBSchema($dbw);
@@ -479,7 +468,7 @@ class Image
                }
                wfProfileOut( __METHOD__ );
        }
-       
+
        /**
         * Split an internet media type into its two components; if not
         * a two-part name, set the minor type to 'unknown'.
@@ -619,7 +608,7 @@ class Image
                if (!$mime || $mime==='unknown' || $mime==='unknown/unknown') return false;
 
                #if it's SVG, check if there's a converter enabled
-               if ($mime === 'image/svg') {
+               if ($mime === 'image/svg' || $mime == 'image/svg+xml' ) {
                        global $wgSVGConverters, $wgSVGConverter;
 
                        if ($wgSVGConverter && isset( $wgSVGConverters[$wgSVGConverter])) {
@@ -852,6 +841,7 @@ class Image
         * @private
         */
        function thumbName( $width ) {
+               global $wgDjvuOutputExtension;
                $thumb = $width."px-".$this->name;
                if ( $this->page != 1 ) {
                        $thumb = "page{$this->page}-$thumb";
@@ -859,8 +849,10 @@ class Image
 
                if( $this->mustRender() ) {
                        if( $this->canRender() ) {
-                               # Rasterize to PNG (for SVG vector images, etc)
-                               $thumb .= '.png';
+                               list( $ext, $mime ) = self::getThumbType( $this->extension, $this->mime );
+                               if ( $ext != $this->extension ) {
+                                       $thumb .= ".$ext";
+                               }
                        }
                        else {
                                #should we use iconThumb here to get a symbolic thumbnail?
@@ -925,7 +917,7 @@ class Image
                                        if ( !$this->mustRender() && $width == $this->width && $height == $this->height ) {
                                                $url = $this->getURL();
                                        } else {
-                                               list( $isScriptUrl, $url ) = $this->thumbUrl( $width );
+                                               list( /* $isScriptUrl */, $url ) = $this->thumbUrl( $width );
                                        }
                                        $thumb = new ThumbnailImage( $url, $width, $height );
                                } else {
@@ -966,7 +958,7 @@ class Image
         */
        function validateThumbParams( &$width, &$height ) {
                global $wgSVGMaxSize, $wgMaxImageArea;
-               
+
                $this->load();
 
                if ( ! $this->exists() )
@@ -974,9 +966,9 @@ class Image
                        # If there is no image, there will be no thumbnail
                        return false;
                }
-               
+
                $width = intval( $width );
-               
+
                # Sanity check $width
                if( $width <= 0 || $this->width <= 0) {
                        # BZZZT
@@ -1002,10 +994,10 @@ class Image
                        return true;
                }
 
-               $height = round( $this->height * $width / $this->width );
+               $height = self::scaleHeight( $this->width, $this->height, $width );
                return true;
        }
-       
+
        /**
         * Create a thumbnail of the image having the specified width.
         * The thumbnail will not be created if the width is larger than the
@@ -1037,7 +1029,7 @@ class Image
                        wfProfileOut( __METHOD__ );
                        return $thumb;
                }
-               
+
                list( $isScriptUrl, $url ) = $this->thumbUrl( $width );
                if ( $isScriptUrl && $useScript ) {
                        // Use thumb.php to render the image
@@ -1076,7 +1068,7 @@ class Image
                                @unlink( $thumbDir );
                        }
                        wfMkdirParents( $thumbDir );
-                       
+
                        $oldThumbPath = wfDeprecatedThumbDir( $thumbName, 'thumb', $this->fromSharedDirectory ).
                                '/'.$thumbName;
                        $done = false;
@@ -1101,7 +1093,8 @@ class Image
                                }
                        }
                        if ( !$done ) {
-                               $this->lastError = $this->reallyRenderThumb( $thumbPath, $width, $height );
+                               $this->lastError = self::reallyRenderThumb( $this->imagePath, $thumbPath, $this->mime, 
+                                       $width, $height, $this->page );
                                if ( $this->lastError === true ) {
                                        $done = true;
                                } elseif( $GLOBALS['wgIgnoreImageErrors'] ) {
@@ -1132,26 +1125,26 @@ class Image
        /**
         * Really render a thumbnail
         * Call this only for images for which canRender() returns true.
-        *
-        * @param string $thumbPath Path to thumbnail
-        * @param int $width Desired width in pixels
-        * @param int $height Desired height in pixels
-        * @return bool True on error, false or error string on failure.
-        * @private
+        * 
+        * @param string $source Source filename
+        * @param string $destination Destination filename
+        * @param string $mime MIME type of source
+        * @param integer $width Destination width in pixels
+        * @param integer $height Destination height in pixels
+        * @param integer $page Which page of a multi-page document to display. Ignored 
+        *           for source MIME types which do not support multiple pages.
         */
-       function reallyRenderThumb( $thumbPath, $width, $height ) {
+       static function reallyRenderThumb( $source, $destination, $mime, $width, $height, $page = false ) {
                global $wgSVGConverters, $wgSVGConverter;
                global $wgUseImageMagick, $wgImageMagickConvertCommand;
                global $wgCustomConvertCommand;
                global $wgDjvuRenderer, $wgDjvuPostProcessor;
 
-               $this->load();
-
                $err = false;
                $cmd = "";
                $retval = 0;
-               
-               if( $this->mime === "image/svg" ) {
+
+               if( $mime == "image/svg" || $mime == 'image/svg+xml' ) {
                        #Right now we have only SVG
 
                        global $wgSVGConverters, $wgSVGConverter;
@@ -1159,139 +1152,131 @@ class Image
                                global $wgSVGConverterPath;
                                $cmd = str_replace(
                                        array( '$path/', '$width', '$height', '$input', '$output' ),
-                                       array( $wgSVGConverterPath ? "$wgSVGConverterPath/" : "",
+                                       array( $wgSVGConverterPath ? wfEscapeShellArg( "$wgSVGConverterPath/" ) : "",
                                                   intval( $width ),
                                                   intval( $height ),
-                                                  wfEscapeShellArg( $this->imagePath ),
-                                                  wfEscapeShellArg( $thumbPath ) ),
-                                       $wgSVGConverters[$wgSVGConverter] );
+                                                  wfEscapeShellArg( $source ),
+                                                  wfEscapeShellArg( $destination ) ),
+                                       $wgSVGConverters[$wgSVGConverter] ) . " 2>&1";
                                wfProfileIn( 'rsvg' );
                                wfDebug( "reallyRenderThumb SVG: $cmd\n" );
                                $err = wfShellExec( $cmd, $retval );
                                wfProfileOut( 'rsvg' );
                        }
-               } else {
-                       if ( $this->mime === "image/vnd.djvu" && $wgDjvuRenderer ) {
-                               // DJVU image
-                               // The file contains several images. First, extract the
-                               // page in hi-res, if it doesn't yet exist. Then, thumbnail
-                               // it.
-
-                               $cmd = "{$wgDjvuRenderer} -page={$this->page} -size=${width}x${height} " .
-                                       wfEscapeShellArg( $this->imagePath ) . 
-                                       " | {$wgDjvuPostProcessor} > " . wfEscapeShellArg($thumbPath);
-                               wfProfileIn( 'ddjvu' );
-                               wfDebug( "reallyRenderThumb DJVU: $cmd\n" );
-                               $err = wfShellExec( $cmd, $retval );
-                               wfProfileOut( 'ddjvu' );
-
-                       } elseif ( $wgUseImageMagick ) {
-                               # use ImageMagick
-                       
-                               if ( $this->mime == 'image/jpeg' ) {
-                                       $quality = "-quality 80"; // 80%
-                               } elseif ( $this->mime == 'image/png' ) {
-                                       $quality = "-quality 95"; // zlib 9, adaptive filtering
-                               } else {
-                                       $quality = ''; // default
-                               }
-
-                               # Specify white background color, will be used for transparent images
-                               # in Internet Explorer/Windows instead of default black.
-       
-                               # Note, we specify "-size {$width}" and NOT "-size {$width}x{$height}".
-                               # It seems that ImageMagick has a bug wherein it produces thumbnails of
-                               # the wrong size in the second case.
-                               
-                               $cmd  =  wfEscapeShellArg($wgImageMagickConvertCommand) .
-                                       " {$quality} -background white -size {$width} ".
-                                       wfEscapeShellArg($this->imagePath) .
-                                       // Coalesce is needed to scale animated GIFs properly (bug 1017).
-                                       ' -coalesce ' .
-                                       // For the -resize option a "!" is needed to force exact size,
-                                       // or ImageMagick may decide your ratio is wrong and slice off
-                                       // a pixel.
-                                       " -resize " . wfEscapeShellArg( "{$width}x{$height}!" ) .
-                                       " -depth 8 " .
-                                       wfEscapeShellArg($thumbPath) . " 2>&1";
-                               wfDebug("reallyRenderThumb: running ImageMagick: $cmd\n");
-                               wfProfileIn( 'convert' );
-                               $err = wfShellExec( $cmd, $retval );
-                               wfProfileOut( 'convert' );
-                       } elseif( $wgCustomConvertCommand ) {
-                               # Use a custom convert command
-                               # Variables: %s %d %w %h
-                               $src = wfEscapeShellArg( $this->imagePath );
-                               $dst = wfEscapeShellArg( $thumbPath );
-                               $cmd = $wgCustomConvertCommand;
-                               $cmd = str_replace( '%s', $src, str_replace( '%d', $dst, $cmd ) ); # Filenames
-                               $cmd = str_replace( '%h', $height, str_replace( '%w', $width, $cmd ) ); # Size
-                               wfDebug( "reallyRenderThumb: Running custom convert command $cmd\n" );
-                               wfProfileIn( 'convert' );
-                               $err = wfShellExec( $cmd, $retval );
-                               wfProfileOut( 'convert' );
+               } elseif ( $mime === "image/vnd.djvu" && $wgDjvuRenderer ) {
+                       // DJVU image
+                       // The file contains several images. First, extract the
+                       // page in hi-res, if it doesn't yet exist. Then, thumbnail
+                       // it.
+
+                       $cmd = wfEscapeShellArg( $wgDjvuRenderer ) . " -format=ppm -page={$page} -size=${width}x${height} " .
+                               wfEscapeShellArg( $source );
+                       if ( $wgDjvuPostProcessor ) {
+                               $cmd .= " | {$wgDjvuPostProcessor}";
+                       }
+                       $cmd .= ' > ' . wfEscapeShellArg($destination);
+                       wfProfileIn( 'ddjvu' );
+                       wfDebug( "reallyRenderThumb DJVU: $cmd\n" );
+                       $err = wfShellExec( $cmd, $retval );
+                       wfProfileOut( 'ddjvu' );
+
+               } elseif ( $wgUseImageMagick ) {
+                       # use ImageMagick
+
+                       if ( $mime == 'image/jpeg' ) {
+                               $quality = "-quality 80"; // 80%
+                       } elseif ( $mime == 'image/png' ) {
+                               $quality = "-quality 95"; // zlib 9, adaptive filtering
                        } else {
-                               # Use PHP's builtin GD library functions.
-                               #
-                               # First find out what kind of file this is, and select the correct
-                               # input routine for this.
-       
-                               $typemap = array(
-                                       'image/gif'          => array( 'imagecreatefromgif',  'palette',   'imagegif'  ),
-                                       'image/jpeg'         => array( 'imagecreatefromjpeg', 'truecolor', array( &$this, 'imageJpegWrapper' ) ),
-                                       'image/png'          => array( 'imagecreatefrompng',  'bits',      'imagepng'  ),
-                                       'image/vnd.wap.wmbp' => array( 'imagecreatefromwbmp', 'palette',   'imagewbmp'  ),
-                                       'image/xbm'          => array( 'imagecreatefromxbm',  'palette',   'imagexbm'  ),
-                               );
-                               if( !isset( $typemap[$this->mime] ) ) {
-                                       $err = 'Image type not supported';
-                                       wfDebug( "$err\n" );
-                                       return $err;
-                               }
-                               list( $loader, $colorStyle, $saveType ) = $typemap[$this->mime];
+                               $quality = ''; // default
+                       }
 
-                               if( !function_exists( $loader ) ) {
-                                       $err = "Incomplete GD library configuration: missing function $loader";
-                                       wfDebug( "$err\n" );
-                                       return $err;
-                               }
-                               if( $colorStyle == 'palette' ) {
-                                       $truecolor = false;
-                               } elseif( $colorStyle == 'truecolor' ) {
-                                       $truecolor = true;
-                               } elseif( $colorStyle == 'bits' ) {
-                                       $truecolor = ( $this->bits > 8 );
-                               }
+                       # Specify white background color, will be used for transparent images
+                       # in Internet Explorer/Windows instead of default black.
+
+                       # Note, we specify "-size {$width}" and NOT "-size {$width}x{$height}".
+                       # It seems that ImageMagick has a bug wherein it produces thumbnails of
+                       # the wrong size in the second case.
+
+                       $cmd  =  wfEscapeShellArg($wgImageMagickConvertCommand) .
+                               " {$quality} -background white -size {$width} ".
+                               wfEscapeShellArg($source) .
+                               // Coalesce is needed to scale animated GIFs properly (bug 1017).
+                               ' -coalesce ' .
+                               // For the -resize option a "!" is needed to force exact size,
+                               // or ImageMagick may decide your ratio is wrong and slice off
+                               // a pixel.
+                               " -thumbnail " . wfEscapeShellArg( "{$width}x{$height}!" ) .
+                               " -depth 8 " .
+                               wfEscapeShellArg($destination) . " 2>&1";
+                       wfDebug("reallyRenderThumb: running ImageMagick: $cmd\n");
+                       wfProfileIn( 'convert' );
+                       $err = wfShellExec( $cmd, $retval );
+                       wfProfileOut( 'convert' );
+               } elseif( $wgCustomConvertCommand ) {
+                       # Use a custom convert command
+                       # Variables: %s %d %w %h
+                       $src = wfEscapeShellArg( $source );
+                       $dst = wfEscapeShellArg( $destination );
+                       $cmd = $wgCustomConvertCommand;
+                       $cmd = str_replace( '%s', $src, str_replace( '%d', $dst, $cmd ) ); # Filenames
+                       $cmd = str_replace( '%h', $height, str_replace( '%w', $width, $cmd ) ); # Size
+                       wfDebug( "reallyRenderThumb: Running custom convert command $cmd\n" );
+                       wfProfileIn( 'convert' );
+                       $err = wfShellExec( $cmd, $retval );
+                       wfProfileOut( 'convert' );
+               } else {
+                       # Use PHP's builtin GD library functions.
+                       #
+                       # First find out what kind of file this is, and select the correct
+                       # input routine for this.
+
+                       $typemap = array(
+                               'image/gif'          => array( 'imagecreatefromgif',  'palette',   'imagegif'  ),
+                               'image/jpeg'         => array( 'imagecreatefromjpeg', 'truecolor', array( __CLASS__, 'imageJpegWrapper' ) ),
+                               'image/png'          => array( 'imagecreatefrompng',  'bits',      'imagepng'  ),
+                               'image/vnd.wap.wmbp' => array( 'imagecreatefromwbmp', 'palette',   'imagewbmp'  ),
+                               'image/xbm'          => array( 'imagecreatefromxbm',  'palette',   'imagexbm'  ),
+                       );
+                       if( !isset( $typemap[$mime] ) ) {
+                               $err = 'Image type not supported';
+                               wfDebug( "$err\n" );
+                               return $err;
+                       }
+                       list( $loader, $colorStyle, $saveType ) = $typemap[$mime];
 
-                               $src_image = call_user_func( $loader, $this->imagePath );
-                               if ( $truecolor ) {
-                                       $dst_image = imagecreatetruecolor( $width, $height );
-                               } else {
-                                       $dst_image = imagecreate( $width, $height );
-                               }
-                               imagecopyresampled( $dst_image, $src_image,
-                                                       0,0,0,0,
-                                                       $width, $height, $this->width, $this->height );
-                               call_user_func( $saveType, $dst_image, $thumbPath );
-                               imagedestroy( $dst_image );
-                               imagedestroy( $src_image );
+                       if( !function_exists( $loader ) ) {
+                               $err = "Incomplete GD library configuration: missing function $loader";
+                               wfDebug( "$err\n" );
+                               return $err;
                        }
+
+                       $src_image = call_user_func( $loader, $source );
+                       $dst_image = imagecreatetruecolor( $width, $height );
+                       imagecopyresampled( $dst_image, $src_image,
+                                               0,0,0,0,
+                                               $width, $height, imagesx( $src_image ), imagesy( $src_image ) );
+                       call_user_func( $saveType, $dst_image, $destination );
+                       imagedestroy( $dst_image );
+                       imagedestroy( $src_image );
                }
 
                #
                # Check for zero-sized thumbnails. Those can be generated when
                # no disk space is available or some other error occurs
                #
-               if( file_exists( $thumbPath ) ) {
-                       $thumbstat = stat( $thumbPath );
+               $removed = false;
+               if( file_exists( $destination ) ) {
+                       $thumbstat = stat( $destination );
                        if( $thumbstat['size'] == 0 || $retval != 0 ) {
                                wfDebugLog( 'thumbnail',
                                        sprintf( 'Removing bad %d-byte thumbnail "%s"',
-                                               $thumbstat['size'], $thumbPath ) );
-                               unlink( $thumbPath );
+                                               $thumbstat['size'], $destination ) );
+                               unlink( $destination );
+                               $removed = true;
                        }
                }
-               if ( $retval != 0 ) {
+               if ( $retval != 0 || $removed ) {
                        wfDebugLog( 'thumbnail',
                                sprintf( 'thumbnail failed on %s: error %d "%s" from "%s"',
                                        wfHostname(), $retval, trim($err), $cmd ) );
@@ -1305,7 +1290,7 @@ class Image
                return $this->lastError;
        }
 
-       function imageJpegWrapper( $dst_image, $thumbPath ) {
+       static function imageJpegWrapper( $dst_image, $thumbPath ) {
                imageinterlace( $dst_image );
                imagejpeg( $dst_image, $thumbPath, 95 );
        }
@@ -1319,16 +1304,17 @@ class Image
                        $files = array();
                        $dir = wfImageThumbDir( $this->name, $shared );
 
-                       // This generates an error on failure, hence the @
-                       $handle = @opendir( $dir );
+                       if ( is_dir( $dir ) ) {
+                               $handle = opendir( $dir );
 
-                       if ( $handle ) {
-                               while ( false !== ( $file = readdir($handle) ) ) {
-                                       if ( $file{0} != '.' ) {
-                                               $files[] = $file;
+                               if ( $handle ) {
+                                       while ( false !== ( $file = readdir($handle) ) ) {
+                                               if ( $file{0} != '.' ) {
+                                                       $files[] = $file;
+                                               }
                                        }
+                                       closedir( $handle );
                                }
-                               closedir( $handle );
                        }
                } else {
                        $files = array();
@@ -1360,22 +1346,24 @@ class Image
                $dir = wfImageThumbDir( $this->name, $shared );
                $urls = array();
                foreach ( $files as $file ) {
+                       $m = array();
                        if ( preg_match( '/^(\d+)px/', $file, $m ) ) {
-                               $urls[] = $this->thumbUrl( $m[1], $this->fromSharedDirectory );
+                               list( /* $isScriptUrl */, $url ) = $this->thumbUrl( $m[1] );
+                               $urls[] = $url;
                                @unlink( "$dir/$file" );
                        }
                }
 
                // Purge the squid
                if ( $wgUseSquid ) {
-                       $urls[] = $this->getViewURL();
+                       $urls[] = $this->getURL();
                        foreach ( $archiveFiles as $file ) {
                                $urls[] = wfImageArchiveUrl( $file );
                        }
                        wfPurgeSquidServers( $urls );
                }
        }
-       
+
        /**
         * Purge the image description page, but don't go after
         * pages using the image. Use when modifying file history
@@ -1386,7 +1374,7 @@ class Image
                $page->invalidateCache();
                $page->purgeSquid();
        }
-       
+
        /**
         * Purge metadata and all affected pages when the image is created,
         * deleted, or majorly updated. A set of additional URLs may be
@@ -1397,7 +1385,7 @@ class Image
                // Delete thumbnails and refresh image metadata cache
                $this->purgeCache();
                $this->purgeDescription();
-               
+
                // Purge cache of all pages using this image
                $update = new HTMLCacheUpdate( $this->getTitle(), 'imagelinks' );
                $update->doUpdate();
@@ -1443,7 +1431,7 @@ class Image
         * @public
         */
        function nextHistoryLine() {
-               $dbr =& wfGetDB( DB_SLAVE );
+               $dbr = wfGetDB( DB_SLAVE );
 
                $this->checkDBSchema($dbr);
 
@@ -1461,7 +1449,7 @@ class Image
                                array( 'img_name' => $this->title->getDBkey() ),
                                __METHOD__
                        );
-                       if ( 0 == wfNumRows( $this->historyRes ) ) {
+                       if ( 0 == $dbr->numRows( $this->historyRes ) ) {
                                return FALSE;
                        }
                } else if ( $this->historyLine == 1 ) {
@@ -1539,7 +1527,7 @@ class Image
        function recordUpload( $oldver, $desc, $license = '', $copyStatus = '', $source = '', $watch = false ) {
                global $wgUser, $wgUseCopyrightUpload;
 
-               $dbw =& wfGetDB( DB_MASTER );
+               $dbw = wfGetDB( DB_MASTER );
 
                $this->checkDBSchema($dbw);
 
@@ -1668,6 +1656,9 @@ class Image
                        $article->insertNewArticle( $textdesc, $desc, $minor, $watch, $suppressRC );
                }
 
+               # Hooks, hooks, the magic of hooks...
+               wfRunHooks( 'FileUpload', array( $this ) );
+
                # Add the log entry
                $log = new LogPage( 'upload' );
                $log->addEntry( 'upload', $descTitle, $desc );
@@ -1695,13 +1686,13 @@ class Image
                wfProfileIn( __METHOD__ );
 
                if ( $options ) {
-                       $db =& wfGetDB( DB_MASTER );
+                       $db = wfGetDB( DB_MASTER );
                } else {
-                       $db =& wfGetDB( DB_SLAVE );
+                       $db = wfGetDB( DB_SLAVE );
                }
                $linkCache =& LinkCache::singleton();
 
-               extract( $db->tableNames( 'page', 'imagelinks' ) );
+               list( $page, $imagelinks ) = $db->tableNamesN( 'page', 'imagelinks' );
                $encName = $db->addQuotes( $this->name );
                $sql = "SELECT page_namespace,page_title,page_id FROM $page,$imagelinks WHERE page_id=il_from AND il_to=$encName $options";
                $res = $db->query( $sql, __METHOD__ );
@@ -1719,7 +1710,7 @@ class Image
                wfProfileOut( __METHOD__ );
                return $retVal;
        }
-       
+
        /**
         * Retrive Exif data from the file and prune unrecognized tags
         * and/or tags with invalid contents
@@ -1729,7 +1720,7 @@ class Image
         */
        private function retrieveExifData( $filename ) {
                global $wgShowEXIF;
-               
+
                /*
                if ( $this->getMimeType() !== "image/jpeg" )
                        return array();
@@ -1739,7 +1730,7 @@ class Image
                        $exif = new Exif( $filename );
                        return $exif->getFilteredData();
                }
-               
+
                return array();
        }
 
@@ -1779,7 +1770,7 @@ class Image
                }
 
                # Update EXIF data in database
-               $dbw =& wfGetDB( DB_MASTER );
+               $dbw = wfGetDB( DB_MASTER );
 
                $this->checkDBSchema($dbw);
 
@@ -1799,7 +1790,7 @@ class Image
        function isLocal() {
                return !$this->fromSharedDirectory;
        }
-       
+
        /**
         * Was this image ever deleted from the wiki?
         *
@@ -1809,7 +1800,7 @@ class Image
                $title = Title::makeTitle( NS_IMAGE, $this->name );
                return ( $title->isDeleted() > 0 );
        }
-       
+
        /**
         * Delete all versions of the image.
         *
@@ -1821,37 +1812,37 @@ class Image
         * @param $reason
         * @return true on success, false on some kind of failure
         */
-       function delete( $reason ) {
+       function delete( $reason, $suppress=false ) {
                $transaction = new FSTransaction();
                $urlArr = array( $this->getURL() );
-               
+
                if( !FileStore::lock() ) {
                        wfDebug( __METHOD__.": failed to acquire file store lock, aborting\n" );
                        return false;
                }
-               
+
                try {
                        $dbw = wfGetDB( DB_MASTER );
                        $dbw->begin();
-                       
+
                        // Delete old versions
                        $result = $dbw->select( 'oldimage',
                                array( 'oi_archive_name' ),
                                array( 'oi_name' => $this->name ) );
-                       
+
                        while( $row = $dbw->fetchObject( $result ) ) {
                                $oldName = $row->oi_archive_name;
-                               
-                               $transaction->add( $this->prepareDeleteOld( $oldName, $reason ) );
-                               
+
+                               $transaction->add( $this->prepareDeleteOld( $oldName, $reason, $suppress ) );
+
                                // We'll need to purge this URL from caches...
                                $urlArr[] = wfImageArchiveUrl( $oldName );
                        }
                        $dbw->freeResult( $result );
-                       
+
                        // And the current version...
-                       $transaction->add( $this->prepareDeleteCurrent( $reason ) );
-                       
+                       $transaction->add( $this->prepareDeleteCurrent( $reason, $suppress ) );
+
                        $dbw->immediateCommit();
                } catch( MWException $e ) {
                        wfDebug( __METHOD__.": db error, rolling back file transactions\n" );
@@ -1859,22 +1850,22 @@ class Image
                        FileStore::unlock();
                        throw $e;
                }
-               
+
                wfDebug( __METHOD__.": deleted db items, applying file transactions\n" );
                $transaction->commit();
                FileStore::unlock();
 
-               
+
                // Update site_stats
                $site_stats = $dbw->tableName( 'site_stats' );
                $dbw->query( "UPDATE $site_stats SET ss_images=ss_images-1", __METHOD__ );
-               
+
                $this->purgeEverything( $urlArr );
-               
+
                return true;
        }
-       
-       
+
+
        /**
         * Delete an old version of the image.
         *
@@ -1887,20 +1878,20 @@ class Image
         * @throws MWException or FSException on database or filestore failure
         * @return true on success, false on some kind of failure
         */
-       function deleteOld( $archiveName, $reason ) {
+       function deleteOld( $archiveName, $reason, $suppress=false ) {
                $transaction = new FSTransaction();
                $urlArr = array();
-               
+
                if( !FileStore::lock() ) {
                        wfDebug( __METHOD__.": failed to acquire file store lock, aborting\n" );
                        return false;
                }
-               
+
                $transaction = new FSTransaction();
                try {
                        $dbw = wfGetDB( DB_MASTER );
                        $dbw->begin();
-                       $transaction->add( $this->prepareDeleteOld( $archiveName, $reason ) );
+                       $transaction->add( $this->prepareDeleteOld( $archiveName, $reason, $suppress ) );
                        $dbw->immediateCommit();
                } catch( MWException $e ) {
                        wfDebug( __METHOD__.": db error, rolling back file transaction\n" );
@@ -1908,11 +1899,11 @@ class Image
                        FileStore::unlock();
                        throw $e;
                }
-               
+
                wfDebug( __METHOD__.": deleted db items, applying file transaction\n" );
                $transaction->commit();
                FileStore::unlock();
-               
+
                $this->purgeDescription();
 
                // Squid purging
@@ -1925,13 +1916,13 @@ class Image
                }
                return true;
        }
-       
+
        /**
         * Delete the current version of a file.
         * May throw a database error.
         * @return true on success, false on failure
         */
-       private function prepareDeleteCurrent( $reason ) {
+       private function prepareDeleteCurrent( $reason, $suppress=false ) {
                return $this->prepareDeleteVersion(
                        $this->getFullPath(),
                        $reason,
@@ -1952,6 +1943,7 @@ class Image
                                'fa_user_text'    => 'img_user_text',
                                'fa_timestamp'    => 'img_timestamp' ),
                        array( 'img_name' => $this->name ),
+                       $suppress,
                        __METHOD__ );
        }
 
@@ -1960,7 +1952,7 @@ class Image
         * May throw a database error.
         * @return true on success, false on failure
         */
-       private function prepareDeleteOld( $archiveName, $reason ) {
+       private function prepareDeleteOld( $archiveName, $reason, $suppress=false ) {
                $oldpath = wfImageArchiveDir( $this->name ) .
                        DIRECTORY_SEPARATOR . $archiveName;
                return $this->prepareDeleteVersion(
@@ -1985,6 +1977,7 @@ class Image
                        array(
                                'oi_name' => $this->name,
                                'oi_archive_name' => $archiveName ),
+                       $suppress,
                        __METHOD__ );
        }
 
@@ -1997,14 +1990,14 @@ class Image
         *
         * @return FSTransaction
         */
-       private function prepareDeleteVersion( $path, $reason, $table, $fieldMap, $where, $fname ) {
+       private function prepareDeleteVersion( $path, $reason, $table, $fieldMap, $where, $suppress=false, $fname ) {
                global $wgUser, $wgSaveDeletedFiles;
-               
+
                // Dupe the file into the file store
                if( file_exists( $path ) ) {
                        if( $wgSaveDeletedFiles ) {
                                $group = 'deleted';
-                               
+
                                $store = FileStore::get( $group );
                                $key = FileStore::calculateKey( $path, $this->extension );
                                $transaction = $store->insert( $key, $path,
@@ -2020,7 +2013,7 @@ class Image
                        $key = null;
                        $transaction = new FSTransaction(); // empty
                }
-               
+
                if( $transaction === false ) {
                        // Fail to restore?
                        wfDebug( __METHOD__.": import to file store failed, aborting\n" );
@@ -2028,16 +2021,28 @@ class Image
                        return false;
                }
                
+               // Bitfields to further supress the image content
+               // Note that currently, live images are stored elsewhere
+               // and cannot be partially deleted
+               $bitfield = 0;
+               if ( $suppress ) {
+                       $bitfield |= self::DELETED_FILE;
+                       $bitfield |= self::DELETED_COMMENT;
+                       $bitfield |= self::DELETED_USER;
+                       $bitfield |= self::DELETED_RESTRICTED;
+               }
+
                $dbw = wfGetDB( DB_MASTER );
                $storageMap = array(
                        'fa_storage_group' => $dbw->addQuotes( $group ),
                        'fa_storage_key'   => $dbw->addQuotes( $key ),
-                       
+
                        'fa_deleted_user'      => $dbw->addQuotes( $wgUser->getId() ),
                        'fa_deleted_timestamp' => $dbw->timestamp(),
-                       'fa_deleted_reason'    => $dbw->addQuotes( $reason ) );
+                       'fa_deleted_reason'    => $dbw->addQuotes( $reason ),
+                       'fa_deleted'               => $bitfield);
                $allFields = array_merge( $storageMap, $fieldMap );
-               
+
                try {
                        if( $wgSaveDeletedFiles ) {
                                $dbw->insertSelect( 'filearchive', $table, $allFields, $where, $fname );
@@ -2050,10 +2055,10 @@ class Image
                        $transaction->rollback();
                        throw $e;
                }
-               
+
                return $transaction;
        }
-       
+
        /**
         * Restore all or specified deleted revisions to the given file.
         * Permissions and logging are left to the caller.
@@ -2065,36 +2070,38 @@ class Image
         * @return the number of file revisions restored if successful,
         *         or false on failure
         */
-       function restore( $versions=array() ) {
+       function restore( $versions=array(), $Unsuppress=false ) {
+               global $wgUser;
+       
                if( !FileStore::lock() ) {
                        wfDebug( __METHOD__." could not acquire filestore lock\n" );
                        return false;
                }
-               
+
                $transaction = new FSTransaction();
                try {
                        $dbw = wfGetDB( DB_MASTER );
                        $dbw->begin();
-                       
+
                        // Re-confirm whether this image presently exists;
                        // if no we'll need to create an image record for the
                        // first item we restore.
                        $exists = $dbw->selectField( 'image', '1',
                                array( 'img_name' => $this->name ),
                                __METHOD__ );
-                       
+
                        // Fetch all or selected archived revisions for the file,
                        // sorted from the most recent to the oldest.
                        $conditions = array( 'fa_name' => $this->name );
                        if( $versions ) {
                                $conditions['fa_id'] = $versions;
                        }
-                       
+
                        $result = $dbw->select( 'filearchive', '*',
                                $conditions,
                                __METHOD__,
                                array( 'ORDER BY' => 'fa_timestamp DESC' ) );
-                       
+
                        if( $dbw->numRows( $result ) < count( $versions ) ) {
                                // There's some kind of conflict or confusion;
                                // we can't restore everything we were asked to.
@@ -2111,29 +2118,35 @@ class Image
                                FileStore::unlock();
                                return true;
                        }
-                       
+
                        $revisions = 0;
                        while( $row = $dbw->fetchObject( $result ) ) {
+                               if ( $Unsuppress ) {
+                               // Currently, fa_deleted flags fall off upon restore, lets be careful about this
+                               } else if ( ($row->fa_deleted & Revision::DELETED_RESTRICTED) && !$wgUser->isAllowed('hiderevision') ) {
+                               // Skip restoring file revisions that the user cannot restore
+                                       continue;
+                               }
                                $revisions++;
                                $store = FileStore::get( $row->fa_storage_group );
                                if( !$store ) {
                                        wfDebug( __METHOD__.": skipping row with no file.\n" );
                                        continue;
                                }
-                               
+
                                if( $revisions == 1 && !$exists ) {
                                        $destDir = wfImageDir( $row->fa_name );
                                        if ( !is_dir( $destDir ) ) {
                                                wfMkdirParents( $destDir );
                                        }
                                        $destPath = $destDir . DIRECTORY_SEPARATOR . $row->fa_name;
-                                       
+
                                        // We may have to fill in data if this was originally
                                        // an archived file revision.
                                        if( is_null( $row->fa_metadata ) ) {
                                                $tempFile = $store->filePath( $row->fa_storage_key );
                                                $metadata = serialize( $this->retrieveExifData( $tempFile ) );
-                                               
+
                                                $magic = MimeMagic::singleton();
                                                $mime = $magic->guessMimeType( $tempFile, true );
                                                $media_type = $magic->getMediaType( $tempFile, $mime );
@@ -2144,7 +2157,7 @@ class Image
                                                $minor_mime = $row->fa_minor_mime;
                                                $media_type = $row->fa_media_type;
                                        }
-                                       
+
                                        $table = 'image';
                                        $fields = array(
                                                'img_name'        => $row->fa_name,
@@ -2175,7 +2188,7 @@ class Image
                                                wfMkdirParents( $destDir );
                                        }
                                        $destPath = $destDir . DIRECTORY_SEPARATOR . $archiveName;
-                                       
+
                                        $table = 'oldimage';
                                        $fields = array(
                                                'oi_name'         => $row->fa_name,
@@ -2189,13 +2202,13 @@ class Image
                                                'oi_user_text'    => $row->fa_user_text,
                                                'oi_timestamp'    => $row->fa_timestamp );
                                }
-                               
+
                                $dbw->insert( $table, $fields, __METHOD__ );
-                               /// @fixme this delete is not totally safe, potentially
+                               // @todo this delete is not totally safe, potentially
                                $dbw->delete( 'filearchive',
                                        array( 'fa_id' => $row->fa_id ),
                                        __METHOD__ );
-                               
+
                                // Check if any other stored revisions use this file;
                                // if so, we shouldn't remove the file from the deletion
                                // archives so they will still work.
@@ -2211,36 +2224,36 @@ class Image
                                } else {
                                        $flags = 0;
                                }
-                               
+
                                $transaction->add( $store->export( $row->fa_storage_key,
                                        $destPath, $flags ) );
                        }
-                       
+
                        $dbw->immediateCommit();
                } catch( MWException $e ) {
                        wfDebug( __METHOD__." caught error, aborting\n" );
                        $transaction->rollback();
                        throw $e;
                }
-               
+
                $transaction->commit();
                FileStore::unlock();
-               
+
                if( $revisions > 0 ) {
                        if( !$exists ) {
                                wfDebug( __METHOD__." restored $revisions items, creating a new current\n" );
-                               
+
                                // Update site_stats
                                $site_stats = $dbw->tableName( 'site_stats' );
                                $dbw->query( "UPDATE $site_stats SET ss_images=ss_images+1", __METHOD__ );
-                               
+
                                $this->purgeEverything();
                        } else {
                                wfDebug( __METHOD__." restored $revisions as archived versions\n" );
                                $this->purgeDescription();
                        }
                }
-               
+
                return $revisions;
        }
 
@@ -2251,31 +2264,40 @@ class Image
         * @param $page Integer: page number, starting with 1
         */
        function selectPage( $page ) {
-               wfDebug( __METHOD__." selecting page $page \n" );
-               $this->page = $page;
-               if ( ! $this->dataLoaded ) {
-                       $this->load();
-               }
-               if ( ! isset( $this->multiPageXML ) ) {
-                       $this->initializeMultiPageXML();
+               if( $this->initializeMultiPageXML() ) {
+                       wfDebug( __METHOD__." selecting page $page \n" );
+                       $this->page = $page;
+                       $o = $this->multiPageXML->BODY[0]->OBJECT[$page-1];
+                       $this->height = intval( $o['height'] );
+                       $this->width = intval( $o['width'] );
+               } else {
+                       wfDebug( __METHOD__." selectPage($page) for bogus multipage xml on '$this->name'\n" );
+                       return;
                }
-               $o = $this->multiPageXML->BODY[0]->OBJECT[$page-1];
-               $this->height = intval( $o['height'] );
-               $this->width = intval( $o['width'] );
        }
 
+       /**
+        * Lazy-initialize multipage XML metadata for DjVu files.
+        * @return bool true if $this->multiPageXML is set up and ready;
+        *              false if corrupt or otherwise failing
+        */
        function initializeMultiPageXML() {
+               $this->load();
+               if ( isset( $this->multiPageXML ) ) {
+                       return true;
+               }
+
                #
-               # Check for files uploaded prior to DJVU support activation
-               # They have a '0' in their metadata field.
+               # Check for files uploaded prior to DJVU support activation,
+               # or damaged.
                #
-               if ( $this->metadata == '0' ) {
+               if( empty( $this->metadata ) || $this->metadata == serialize( array() ) ) {
                        $deja = new DjVuImage( $this->imagePath );
                        $this->metadata = $deja->retrieveMetaData();
                        $this->purgeMetadataCache();
 
                        # Update metadata in the database
-                       $dbw =& wfGetDB( DB_MASTER );
+                       $dbw = wfGetDB( DB_MASTER );
                        $dbw->update( 'image',
                                array( 'img_metadata' => $this->metadata ),
                                array( 'img_name' => $this->name ),
@@ -2283,8 +2305,14 @@ class Image
                        );
                }
                wfSuppressWarnings();
-               $this->multiPageXML = new SimpleXMLElement( $this->metadata );
+               try {
+                       $this->multiPageXML = new SimpleXMLElement( $this->metadata );
+               } catch( Exception $e ) {
+                       wfDebug( "Bogus multipage XML metadata on '$this->name'\n" );
+                       $this->multiPageXML = null;
+               }
                wfRestoreWarnings();
+               return isset( $this->multiPageXML );
        }
 
        /**
@@ -2305,17 +2333,194 @@ class Image
                if ( ! $this->isMultipage() ) {
                        return null;
                }
-               if ( ! isset( $this->multiPageXML ) ) {
-                       $this->initializeMultiPageXML();
+               if( $this->initializeMultiPageXML() ) {
+                       return count( $this->multiPageXML->xpath( '//OBJECT' ) );
+               } else {
+                       wfDebug( "Requested pageCount() for bogus multi-page metadata for '$this->name'\n" );
+                       return null;
+               }
+       }
+
+       static function getCommonsDB() {
+               static $dbc;
+               global $wgLoadBalancer, $wgSharedUploadDBname;
+               if ( !isset( $dbc ) ) {
+                       $i = $wgLoadBalancer->getGroupIndex( 'commons' );
+                       $dbinfo = $wgLoadBalancer->mServers[$i];
+                       $dbc = new Database( $dbinfo['host'], $dbinfo['user'], 
+                               $dbinfo['password'], $wgSharedUploadDBname );
                }
-               return count( $this->multiPageXML->xpath( '//OBJECT' ) );
+               return $dbc;
        }
-       
+
+       /**
+        * Calculate the height of a thumbnail using the source and destination width
+        */
+       static function scaleHeight( $srcWidth, $srcHeight, $dstWidth ) {
+               // Exact integer multiply followed by division
+               return round( $srcHeight * $dstWidth / $srcWidth );
+       }
+
+       /**
+        * Get an image size array like that returned by getimagesize(), or false if it 
+        * can't be determined.
+        *
+        * @param string $fileName The filename
+        * @param string $mimeType The MIME type of the file
+        * @param object $deja Filled with a DjVu object if the mime type is image/vnd.djvu
+        * @return array
+        */
+       static function getImageSize( $fileName, $mimeType, &$deja ) {
+               $magic =& MimeMagic::singleton();
+               if( $mimeType == 'image/svg' || $mimeType == 'image/svg+xml' ) {
+                       $gis = wfGetSVGsize( $fileName );
+               } elseif( $mimeType == 'image/vnd.djvu' ) {
+                       wfSuppressWarnings();
+                       $deja = new DjVuImage( $fileName );
+                       $gis = $deja->getImageSize();
+                       wfRestoreWarnings();
+               } elseif ( !$magic->isPHPImageType( $mimeType ) ) {
+                       # Don't try to get the width and height of sound and video files, that's bad for performance
+                       $gis = false;
+               } else {
+                       wfSuppressWarnings();
+                       $gis = getimagesize( $fileName );
+                       wfRestoreWarnings();
+               }
+               return $gis;
+       }
+
+       /**
+        * Get the thumbnail extension and MIME type for a given source MIME type
+        * @return array thumbnail extension and MIME type
+        */
+       static function getThumbType( $ext, $mime ) {
+               switch ( $mime ) {
+                       case 'image/svg':
+                       case 'image/svg+xml':
+                               $ext = 'png';
+                               $mime = 'image/png';
+                               break;
+                       case 'image/vnd.djvu':
+                               $ext = $GLOBALS['wgDjvuOutputExtension'];
+                               $magic = MimeMagic::singleton();
+                               $mime = $magic->guessTypesForExtension( $ext );
+                               break;
+               }
+               return array( $ext, $mime );
+       }
+
+
 } //class
 
+class ArchivedFile
+{
+       /**
+        * Returns a file object from the filearchive table
+        * In the future, all current and old image storage
+        * may use FileStore. There will be a "old" storage 
+        * for current and previous file revisions as well as
+        * the "deleted" group for archived revisions
+        * @param $title, the corresponding image page title
+        * @param $id, the image id, a unique key
+        * @param $key, optional storage key
+        * @return ResultWrapper
+        */
+       function ArchivedFile( $title, $id=0, $key='' ) {
+               if( !is_object( $title ) ) {
+                       throw new MWException( 'Image constructor given bogus title.' );
+               }
+               $conds = ($id) ? "fa_id = $id" : "fa_storage_key = '$key'";
+               if( $title->getNamespace() == NS_IMAGE ) {
+                       $dbr = wfGetDB( DB_SLAVE );
+                       $res = $dbr->select( 'filearchive',
+                               array(
+                                       'fa_id',
+                                       'fa_name',
+                                       'fa_storage_key',
+                                       'fa_storage_group',
+                                       'fa_size',
+                                       'fa_bits',
+                                       'fa_width',
+                                       'fa_height',
+                                       'fa_metadata',
+                                       'fa_media_type',
+                                       'fa_major_mime',
+                                       'fa_minor_mime',
+                                       'fa_description',
+                                       'fa_user',
+                                       'fa_user_text',
+                                       'fa_timestamp',
+                                       'fa_deleted' ),
+                               array( 
+                                       'fa_name' => $title->getDbKey(),
+                                       $conds ),
+                               __METHOD__,
+                               array( 'ORDER BY' => 'fa_timestamp DESC' ) );
+                               
+                       if ( $dbr->numRows( $res ) == 0 ) {
+                       // this revision does not exist?
+                               return;
+                       }
+                       $ret = $dbr->resultObject( $res );
+                       $row = $ret->fetchObject();
+       
+                       // initialize fields for filestore image object
+                       $this->mId = intval($row->fa_id);
+                       $this->mName = $row->fa_name;
+                       $this->mGroup = $row->fa_storage_group;
+                       $this->mKey = $row->fa_storage_key;
+                       $this->mSize = $row->fa_size;
+                       $this->mBits = $row->fa_bits;
+                       $this->mWidth = $row->fa_width;
+                       $this->mHeight = $row->fa_height;
+                       $this->mMetaData = $row->fa_metadata;
+                       $this->mMime = "$row->fa_major_mime/$row->fa_minor_mime";
+                       $this->mType = $row->fa_media_type;
+                       $this->mDescription = $row->fa_description;
+                       $this->mUser = $row->fa_user;
+                       $this->mUserText = $row->fa_user_text;
+                       $this->mTimestamp = $row->fa_timestamp;
+                       $this->mDeleted = $row->fa_deleted;             
+               } else {
+                       throw new MWException( 'This title does not correspond to an image page.' );
+                       return;
+               }
+               return true;
+       }
+
+       /**
+        * int $field one of DELETED_* bitfield constants
+        * for file or revision rows
+        * @return bool
+        */
+       function isDeleted( $field ) {
+               return ($this->mDeleted & $field) == $field;
+       }
+       
+       /**
+        * Determine if the current user is allowed to view a particular
+        * field of this FileStore image file, if it's marked as deleted.
+        * @param int $field                                    
+        * @return bool
+        */
+       function userCan( $field ) {
+               if( isset($this->mDeleted) && ($this->mDeleted & $field) == $field ) {
+               // images
+                       global $wgUser;
+                       $permission = ( $this->mDeleted & Revision::DELETED_RESTRICTED ) == Revision::DELETED_RESTRICTED
+                               ? 'hiderevision'
+                               : 'deleterevision';
+                       wfDebug( "Checking for $permission due to $field match on $this->mDeleted\n" );
+                       return $wgUser->isAllowed( $permission );
+               } else {
+                       return true;
+               }
+       }
+}
+
 /**
  * Wrapper class for thumbnail images
- * @package MediaWiki
  */
 class ThumbnailImage {
        /**
@@ -2368,4 +2573,12 @@ class ThumbnailImage {
 
 }
 
+/**
+ * Aliases for backwards compatibility with 1.6
+ */
+define( 'MW_IMG_DELETED_FILE', Image::DELETED_FILE );
+define( 'MW_IMG_DELETED_COMMENT', Image::DELETED_COMMENT );
+define( 'MW_IMG_DELETED_USER', Image::DELETED_USER );
+define( 'MW_IMG_DELETED_RESTRICTED', Image::DELETED_RESTRICTED );
+
 ?>