Revert Special:Log to r20745 with non-ugly form
[lhc/web/wiklou.git] / includes / Image.php
index 309a1d7..6a5e730 100644 (file)
@@ -1,6 +1,5 @@
 <?php
 /**
- * @package MediaWiki
  */
 
 /**
@@ -12,9 +11,6 @@
  * extension=extensions/php_exif.dll
  */
 
-if ($wgShowEXIF)
-       require_once('Exif.php');
-
 /**
  * Bump this number when serialized cache records may be incompatible.
  */
@@ -25,12 +21,16 @@ define( 'MW_IMAGE_VERSION', 1 );
  *
  * Provides methods to retrieve paths (physical, logical, URL),
  * to generate thumbnails or for uploading.
- * @package MediaWiki
  */
 class Image
 {
+       const DELETED_FILE = 1;
+       const DELETED_COMMENT = 2;
+       const DELETED_USER = 4;
+    const DELETED_RESTRICTED = 8;
+    
        /**#@+
-        * @access private
+        * @private
         */
        var     $name,          # name of the image (constructor)
                $imagePath,     # Path of the image (loadFromXxx)
@@ -46,9 +46,11 @@ class Image
                $attr,          # /
                $type,          # MEDIATYPE_xxx (bitmap, drawing, audio...)
                $mime,          # MIME type, determined by MimeMagic::guessMimeType
+               $extension,     # The file extension (constructor)
                $size,          # Size in bytes (loadFromXxx)
                $metadata,      # Metadata
                $dataLoaded,    # Whether or not all this has been loaded from the database (loadFromXxx)
+               $page,          # Page to render when creating thumbnails
                $lastError;     # Error string associated with a thumbnail display error
 
 
@@ -58,9 +60,9 @@ class Image
         * Create an Image object from an image name
         *
         * @param string $name name of the image, used to create a title object using Title::makeTitleSafe
-        * @access public
+        * @public
         */
-       function newFromName( $name ) {
+       public static function newFromName( $name ) {
                $title = Title::makeTitleSafe( NS_IMAGE, $name );
                if ( is_object( $title ) ) {
                        return new Image( $title );
@@ -71,6 +73,7 @@ class Image
 
        /**
         * Obsolete factory function, use constructor
+        * @deprecated
         */
        function newFromTitle( $title ) {
                return new Image( $title );
@@ -78,31 +81,55 @@ class Image
 
        function Image( $title ) {
                if( !is_object( $title ) ) {
-                       wfDebugDieBacktrace( 'Image constructor given bogus title.' );
+                       throw new MWException( 'Image constructor given bogus title.' );
                }
                $this->title =& $title;
                $this->name = $title->getDBkey();
                $this->metadata = serialize ( array() ) ;
 
                $n = strrpos( $this->name, '.' );
-               $this->extension = strtolower( $n ? substr( $this->name, $n + 1 ) : '' );
+               $this->extension = Image::normalizeExtension( $n ?
+                       substr( $this->name, $n + 1 ) : '' );
                $this->historyLine = 0;
+               $this->page = 1;
 
                $this->dataLoaded = false;
        }
 
+       /**
+        * Normalize a file extension to the common form, and ensure it's clean.
+        * Extensions with non-alphanumeric characters will be discarded.
+        *
+        * @param $ext string (without the .)
+        * @return string
+        */
+       static function normalizeExtension( $ext ) {
+               $lower = strtolower( $ext );
+               $squish = array(
+                       'htm' => 'html',
+                       'jpeg' => 'jpg',
+                       'mpeg' => 'mpg',
+                       'tiff' => 'tif' );
+               if( isset( $squish[$lower] ) ) {
+                       return $squish[$lower];
+               } elseif( preg_match( '/^[0-9a-z]+$/', $lower ) ) {
+                       return $lower;
+               } else {
+                       return '';
+               }
+       }
+
        /**
         * Get the memcached keys
         * Returns an array, first element is the local cache key, second is the shared cache key, if there is one
         */
-       function getCacheKeys( $shared = false ) {
-               global $wgDBname, $wgUseSharedUploads, $wgSharedUploadDBname, $wgCacheSharedUploads;
+       function getCacheKeys( ) {
+               global $wgUseSharedUploads, $wgSharedUploadDBname, $wgCacheSharedUploads;
 
-               $foundCached = false;
                $hashedName = md5($this->name);
-               $keys = array( "$wgDBname:Image:$hashedName" );
+               $keys = array( wfMemcKey( 'Image', $hashedName ) );
                if ( $wgUseSharedUploads && $wgSharedUploadDBname && $wgCacheSharedUploads ) {
-                       $keys[] = "$wgSharedUploadDBname:Image:$hashedName";
+                       $keys[] = wfForeignMemcKey( $wgSharedUploadDBname, false, 'Image', $hashedName );
                }
                return $keys;
        }
@@ -112,8 +139,7 @@ class Image
         */
        function loadFromCache() {
                global $wgUseSharedUploads, $wgMemc;
-               $fname = 'Image::loadFromMemcached';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
                $this->dataLoaded = false;
                $keys = $this->getCacheKeys();
                $cachedValues = $wgMemc->get( $keys[0] );
@@ -121,7 +147,7 @@ class Image
                // Check if the key existed and belongs to this version of MediaWiki
                if (!empty($cachedValues) && is_array($cachedValues)
                  && isset($cachedValues['version']) && ( $cachedValues['version'] == MW_IMAGE_VERSION )
-                 && $cachedValues['fileExists'] && isset( $cachedValues['mime'] ) && isset( $cachedValues['metadata'] ) )
+                 && isset( $cachedValues['mime'] ) && isset( $cachedValues['metadata'] ) )
                {
                        if ( $wgUseSharedUploads && $cachedValues['fromShared']) {
                                # if this is shared file, we need to check if image
@@ -171,7 +197,7 @@ class Image
                        wfIncrStats( 'image_cache_miss' );
                }
 
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return $this->dataLoaded;
        }
 
@@ -179,13 +205,13 @@ class Image
         * Save the image metadata to memcached
         */
        function saveToCache() {
-               global $wgMemc;
+               global $wgMemc, $wgUseSharedUploads;
                $this->load();
                $keys = $this->getCacheKeys();
-               if ( $this->fileExists ) {
-                       // We can't cache negative metadata for non-existent files,
-                       // because if the file later appears in commons, the local
-                       // keys won't be purged.
+               // We can't cache negative metadata for non-existent files,
+               // because if the file later appears in commons, the local
+               // keys won't be purged.
+               if ( $this->fileExists || !$wgUseSharedUploads ) {
                        $cachedValues = array(
                                'version'    => MW_IMAGE_VERSION,
                                'name'       => $this->name,
@@ -212,16 +238,15 @@ class Image
         * Load metadata from the file itself
         */
        function loadFromFile() {
-               global $wgUseSharedUploads, $wgSharedUploadDirectory, $wgContLang,
-                      $wgShowEXIF;
-               $fname = 'Image::loadFromFile';
-               wfProfileIn( $fname );
+               global $wgUseSharedUploads, $wgSharedUploadDirectory, $wgContLang;
+               wfProfileIn( __METHOD__ );
                $this->imagePath = $this->getFullPath();
                $this->fileExists = file_exists( $this->imagePath );
                $this->fromSharedDirectory = false;
                $gis = array();
+               $deja = false;
 
-               if (!$this->fileExists) wfDebug("$fname: ".$this->imagePath." not found locally!\n");
+               if (!$this->fileExists) wfDebug(__METHOD__.': '.$this->imagePath." not found locally!\n");
 
                # If the file is not found, and a shared upload directory is used, look for it there.
                if (!$this->fileExists && $wgUseSharedUploads && $wgSharedUploadDirectory) {
@@ -239,7 +264,7 @@ class Image
 
 
                if ( $this->fileExists ) {
-                       $magic=& wfGetMimeMagic();
+                       $magic=& MimeMagic::singleton();
 
                        $this->mime = $magic->guessMimeType($this->imagePath,true);
                        $this->type = $magic->getMediaType($this->imagePath,$this->mime);
@@ -247,42 +272,24 @@ class Image
                        # Get size in bytes
                        $this->size = filesize( $this->imagePath );
 
-                       $magic=& wfGetMimeMagic();
-
                        # Height and width
-                       if( $this->mime == 'image/svg' ) {
-                               wfSuppressWarnings();
-                               $gis = wfGetSVGsize( $this->imagePath );
-                               wfRestoreWarnings();
-                       }
-                       elseif ( !$magic->isPHPImageType( $this->mime ) ) {
-                               # Don't try to get the width and height of sound and video files, that's bad for performance
-                               $gis[0]= 0; //width
-                               $gis[1]= 0; //height
-                               $gis[2]= 0; //unknown
-                               $gis[3]= ""; //width height string
-                       }
-                       else {
-                               wfSuppressWarnings();
-                               $gis = getimagesize( $this->imagePath );
-                               wfRestoreWarnings();
-                       }
+                       $gis = self::getImageSize( $this->imagePath, $this->mime, $deja );
 
-                       wfDebug("$fname: ".$this->imagePath." loaded, ".$this->size." bytes, ".$this->mime.".\n");
+                       wfDebug(__METHOD__.': '.$this->imagePath." loaded, ".$this->size." bytes, ".$this->mime.".\n");
                }
                else {
-                       $gis[0]= 0; //width
-                       $gis[1]= 0; //height
-                       $gis[2]= 0; //unknown
-                       $gis[3]= ""; //width height string
-
                        $this->mime = NULL;
                        $this->type = MEDIATYPE_UNKNOWN;
-                       wfDebug("$fname: ".$this->imagePath." NOT FOUND!\n");
+                       wfDebug(__METHOD__.': '.$this->imagePath." NOT FOUND!\n");
                }
 
-               $this->width = $gis[0];
-               $this->height = $gis[1];
+               if( $gis ) {
+                       $this->width = $gis[0];
+                       $this->height = $gis[1];
+               } else {
+                       $this->width = 0;
+                       $this->height = 0;
+               }
 
                #NOTE: $gis[2] contains a code for the image type. This is no longer used.
 
@@ -292,13 +299,16 @@ class Image
                $this->dataLoaded = true;
 
 
-               if ($this->fileExists && $wgShowEXIF) $this->metadata = serialize ( $this->retrieveExifData() ) ;
-               else $this->metadata = serialize ( array() ) ;
+               if ( $deja ) {
+                       $this->metadata = $deja->retrieveMetaData();
+               } else {
+                       $this->metadata = serialize( $this->retrieveExifData( $this->imagePath ) );
+               }
 
                if ( isset( $gis['bits'] ) )  $this->bits = $gis['bits'];
                else $this->bits = 0;
 
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
        }
 
        /**
@@ -306,17 +316,15 @@ class Image
         */
        function loadFromDB() {
                global $wgUseSharedUploads, $wgSharedUploadDBname, $wgSharedUploadDBprefix, $wgContLang;
-               $fname = 'Image::loadFromDB';
-               wfProfileIn( $fname );
-
-               $dbr =& wfGetDB( DB_SLAVE );
+               wfProfileIn( __METHOD__ );
 
+               $dbr = wfGetDB( DB_SLAVE );
                $this->checkDBSchema($dbr);
 
                $row = $dbr->selectRow( 'image',
                        array( 'img_size', 'img_width', 'img_height', 'img_bits',
                               'img_media_type', 'img_major_mime', 'img_minor_mime', 'img_metadata' ),
-                       array( 'img_name' => $this->name ), $fname );
+                       array( 'img_name' => $this->name ), __METHOD__ );
                if ( $row ) {
                        $this->fromSharedDirectory = false;
                        $this->fileExists = true;
@@ -331,12 +339,13 @@ class Image
                        # capitalize the first letter of the filename before
                        # looking it up in the shared repository.
                        $name = $wgContLang->ucfirst($this->name);
+                       $dbc = Image::getCommonsDB();
 
-                       $row = $dbr->selectRow( "`$wgSharedUploadDBname`.{$wgSharedUploadDBprefix}image",
+                       $row = $dbc->selectRow( "`$wgSharedUploadDBname`.{$wgSharedUploadDBprefix}image",
                                array(
                                        'img_size', 'img_width', 'img_height', 'img_bits',
                                        'img_media_type', 'img_major_mime', 'img_minor_mime', 'img_metadata' ),
-                               array( 'img_name' => $name ), $fname );
+                               array( 'img_name' => $name ), __METHOD__ );
                        if ( $row ) {
                                $this->fromSharedDirectory = true;
                                $this->fileExists = true;
@@ -360,11 +369,12 @@ class Image
                        $this->fileExists = false;
                        $this->fromSharedDirectory = false;
                        $this->metadata = serialize ( array() ) ;
+                       $this->mime = false;
                }
 
                # Unconditionally set loaded=true, we don't want the accessors constantly rechecking
                $this->dataLoaded = true;
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
        }
 
        /*
@@ -402,9 +412,12 @@ class Image
                                $this->loadFromDB();
                                if ( !$wgSharedUploadDBname && $wgUseSharedUploads ) {
                                        $this->loadFromFile();
-                               } elseif ( $this->fileExists ) {
+                               } elseif ( $this->fileExists || !$wgUseSharedUploads ) {
+                                       // We can do negative caching for local images, because the cache
+                                       // will be purged on upload. But we can't do it when shared images
+                                       // are enabled, since updates to that won't purge foreign caches.
                                        $this->saveToCache();
-                               }
+                               } 
                        }
                        $this->dataLoaded = true;
                }
@@ -416,34 +429,28 @@ class Image
         */
        function upgradeRow() {
                global $wgDBname, $wgSharedUploadDBname;
-               $fname = 'Image::upgradeRow';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
 
                $this->loadFromFile();
-               $dbw =& wfGetDB( DB_MASTER );
 
                if ( $this->fromSharedDirectory ) {
                        if ( !$wgSharedUploadDBname ) {
-                               wfProfileOut( $fname );
+                               wfProfileOut( __METHOD__ );
                                return;
                        }
 
                        // Write to the other DB using selectDB, not database selectors
                        // This avoids breaking replication in MySQL
-                       $dbw->selectDB( $wgSharedUploadDBname );
+                       $dbw = Image::getCommonsDB();
+               } else {
+                       $dbw = wfGetDB( DB_MASTER );
                }
 
                $this->checkDBSchema($dbw);
 
-               if (strpos($this->mime,'/')!==false) {
-                       list($major,$minor)= explode('/',$this->mime,2);
-               }
-               else {
-                       $major= $this->mime;
-                       $minor= "unknown";
-               }
+               list( $major, $minor ) = self::splitMime( $this->mime );
 
-               wfDebug("$fname: upgrading ".$this->name." to 1.5 schema\n");
+               wfDebug(__METHOD__.': upgrading '.$this->name." to 1.5 schema\n");
 
                $dbw->update( 'image',
                        array(
@@ -454,17 +461,32 @@ class Image
                                'img_major_mime' => $major,
                                'img_minor_mime' => $minor,
                                'img_metadata' => $this->metadata,
-                       ), array( 'img_name' => $this->name ), $fname
+                       ), array( 'img_name' => $this->name ), __METHOD__
                );
                if ( $this->fromSharedDirectory ) {
                        $dbw->selectDB( $wgDBname );
                }
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
+       }
+
+       /**
+        * Split an internet media type into its two components; if not
+        * a two-part name, set the minor type to 'unknown'.
+        *
+        * @param $mime "text/html" etc
+        * @return array ("text", "html") etc
+        */
+       static function splitMime( $mime ) {
+               if( strpos( $mime, '/' ) !== false ) {
+                       return explode( '/', $mime, 2 );
+               } else {
+                       return array( $mime, 'unknown' );
+               }
        }
 
        /**
         * Return the name of this image
-        * @access public
+        * @public
         */
        function getName() {
                return $this->name;
@@ -472,7 +494,7 @@ class Image
 
        /**
         * Return the associated title object
-        * @access public
+        * @public
         */
        function getTitle() {
                return $this->title;
@@ -480,7 +502,7 @@ class Image
 
        /**
         * Return the URL of the image file
-        * @access public
+        * @public
         */
        function getURL() {
                if ( !$this->url ) {
@@ -511,7 +533,7 @@ class Image
        /**
         * Return the image path of the image in the
         * local file system as an absolute path
-        * @access public
+        * @public
         */
        function getImagePath() {
                $this->load();
@@ -522,7 +544,7 @@ class Image
         * Return the width of the image
         *
         * Returns -1 if the file specified is not a known image type
-        * @access public
+        * @public
         */
        function getWidth() {
                $this->load();
@@ -533,7 +555,7 @@ class Image
         * Return the height of the image
         *
         * Returns -1 if the file specified is not a known image type
-        * @access public
+        * @public
         */
        function getHeight() {
                $this->load();
@@ -542,7 +564,7 @@ class Image
 
        /**
         * Return the size of the image file, in bytes
-        * @access public
+        * @public
         */
        function getSize() {
                $this->load();
@@ -577,7 +599,7 @@ class Image
         * @todo remember the result of this check.
         */
        function canRender() {
-               global $wgUseImageMagick;
+               global $wgUseImageMagick, $wgDjvuRenderer;
 
                if( $this->getWidth()<=0 || $this->getHeight()<=0 ) return false;
 
@@ -586,7 +608,7 @@ class Image
                if (!$mime || $mime==='unknown' || $mime==='unknown/unknown') return false;
 
                #if it's SVG, check if there's a converter enabled
-               if ($mime === 'image/svg') {
+               if ($mime === 'image/svg' || $mime == 'image/svg+xml' ) {
                        global $wgSVGConverters, $wgSVGConverter;
 
                        if ($wgSVGConverter && isset( $wgSVGConverters[$wgSVGConverter])) {
@@ -623,6 +645,7 @@ class Image
                        if ( $mime === 'image/vnd.wap.wbmp'
                          || $mime === 'image/x-xbitmap' ) return true;
                }
+               if ( $mime === 'image/vnd.djvu' && isset( $wgDjvuRenderer ) && $wgDjvuRenderer ) return true;
 
                return false;
        }
@@ -708,16 +731,23 @@ class Image
 
        /**
         * Return the escapeLocalURL of this image
-        * @access public
+        * @public
         */
-       function getEscapeLocalURL() {
+       function getEscapeLocalURL( $query=false) {
                $this->getTitle();
-               return $this->title->escapeLocalURL();
+               if ( $query === false ) {
+                       if ( $this->page != 1 ) {
+                               $query = 'page=' . $this->page;
+                       } else {
+                               $query = '';
+                       }
+               }
+               return $this->title->escapeLocalURL( $query );
        }
 
        /**
         * Return the escapeFullURL of this image
-        * @access public
+        * @public
         */
        function getEscapeFullURL() {
                $this->getTitle();
@@ -730,7 +760,7 @@ class Image
         * @param string $name  Name of the image, without the leading "Image:"
         * @param boolean $fromSharedDirectory  Should this be in $wgSharedUploadPath?
         * @return string URL of $name image
-        * @access public
+        * @public
         * @static
         */
        function imageUrl( $name, $fromSharedDirectory = false ) {
@@ -742,14 +772,14 @@ class Image
                        $base = $wgUploadBaseUrl;
                        $path = $wgUploadPath;
                }
-               $url = "{$base}{$path}" .  wfGetHashPath($name, $fromSharedDirectory) . "{$name}";
-               return wfUrlencode( $url );
+               $url = "{$base}{$path}" .  wfGetHashPath($name, $fromSharedDirectory) . "{$name}";
+               return wfUrlencode( $url );
        }
 
        /**
         * Returns true if the image file exists on disk.
         * @return boolean Whether image file exist on disk.
-        * @access public
+        * @public
         */
        function exists() {
                $this->load();
@@ -758,7 +788,7 @@ class Image
 
        /**
         * @todo document
-        * @access private
+        * @private
         */
        function thumbUrl( $width, $subdir='thumb') {
                global $wgUploadPath, $wgUploadBaseUrl, $wgSharedUploadPath;
@@ -808,15 +838,21 @@ class Image
         *
         * @param integer $width        Width of the thumbnail image
         * @param boolean $shared       Does the thumbnail come from the shared repository?
-        * @access private
+        * @private
         */
        function thumbName( $width ) {
+               global $wgDjvuOutputExtension;
                $thumb = $width."px-".$this->name;
+               if ( $this->page != 1 ) {
+                       $thumb = "page{$this->page}-$thumb";
+               }
 
                if( $this->mustRender() ) {
                        if( $this->canRender() ) {
-                               # Rasterize to PNG (for SVG vector images, etc)
-                               $thumb .= '.png';
+                               list( $ext, $mime ) = self::getThumbType( $this->extension, $this->mime );
+                               if ( $ext != $this->extension ) {
+                                       $thumb .= ".$ext";
+                               }
                        }
                        else {
                                #should we use iconThumb here to get a symbolic thumbnail?
@@ -841,7 +877,7 @@ class Image
         *
         * @param integer $width        maximum width of the generated thumbnail
         * @param integer $height       maximum height of the image (optional)
-        * @access public
+        * @public
         */
        function createThumb( $width, $height=-1 ) {
                $thumb = $this->getThumbnail( $width, $height );
@@ -854,30 +890,45 @@ class Image
         * provide access to the actual file, the real size of the thumb,
         * and can produce a convenient <img> tag for you.
         *
+        * For non-image formats, this may return a filetype-specific icon.
+        *
         * @param integer $width        maximum width of the generated thumbnail
         * @param integer $height       maximum height of the image (optional)
-        * @return ThumbnailImage
-        * @access public
+        * @param boolean $render       True to render the thumbnail if it doesn't exist,
+        *                              false to just return the URL
+        *
+        * @return ThumbnailImage or null on failure
+        * @public
         */
-       function getThumbnail( $width, $height=-1 ) {
-               if ( $height <= 0 ) {
-                       return $this->renderThumb( $width );
-               }
-               $this->load();
-
+       function getThumbnail( $width, $height=-1, $render = true ) {
+               wfProfileIn( __METHOD__ );
                if ($this->canRender()) {
-                       if ( $width > $this->width * $height / $this->height )
-                               $width = floor( $this->width * $height / $this->height );
-                               # Note this is the largest width such that the thumbnail's
-                               # height is at most $height.
-
-                       $thumb = $this->renderThumb( $width );
-               }
-               else $thumb= NULL; #not a bitmap or renderable image, don't try.
-
-               if( is_null( $thumb ) ) {
+                       if ( $height > 0 ) {
+                               $this->load();
+                               if ( $width > $this->width * $height / $this->height ) {
+                                       $width = wfFitBoxWidth( $this->width, $this->height, $height );
+                               }
+                       }
+                       if ( $render ) {
+                               $thumb = $this->renderThumb( $width );
+                       } else {
+                               // Don't render, just return the URL
+                               if ( $this->validateThumbParams( $width, $height ) ) {
+                                       if ( !$this->mustRender() && $width == $this->width && $height == $this->height ) {
+                                               $url = $this->getURL();
+                                       } else {
+                                               list( /* $isScriptUrl */, $url ) = $this->thumbUrl( $width );
+                                       }
+                                       $thumb = new ThumbnailImage( $url, $width, $height );
+                               } else {
+                                       $thumb = null;
+                               }
+                       }
+               } else {
+                       // not a bitmap or renderable image, don't try.
                        $thumb = $this->iconThumb();
                }
+               wfProfileOut( __METHOD__ );
                return $thumb;
        }
 
@@ -899,40 +950,29 @@ class Image
        }
 
        /**
-        * Create a thumbnail of the image having the specified width.
-        * The thumbnail will not be created if the width is larger than the
-        * image's width. Let the browser do the scaling in this case.
-        * The thumbnail is stored on disk and is only computed if the thumbnail
-        * file does not exist OR if it is older than the image.
-        * Returns an object which can return the pathname, URL, and physical
-        * pixel size of the thumbnail -- or null on failure.
+        * Validate thumbnail parameters and fill in the correct height
         *
-        * @return ThumbnailImage
-        * @access private
+        * @param integer &$width Specified width (input/output)
+        * @param integer &$height Height (output only)
+        * @return false to indicate that an error should be returned to the user. 
         */
-       function renderThumb( $width, $useScript = true ) {
-               global $wgUseSquid, $wgInternalServer;
-               global $wgThumbnailScriptPath, $wgSharedThumbnailScriptPath;
-               global $wgSVGMaxSize, $wgMaxImageArea, $wgThumbnailEpoch;
-
-               $fname = 'Image::renderThumb';
-               wfProfileIn( $fname );
-
-               $width = intval( $width );
+       function validateThumbParams( &$width, &$height ) {
+               global $wgSVGMaxSize, $wgMaxImageArea;
 
                $this->load();
+
                if ( ! $this->exists() )
                {
                        # If there is no image, there will be no thumbnail
-                       wfProfileOut( $fname );
-                       return null;
+                       return false;
                }
 
+               $width = intval( $width );
+
                # Sanity check $width
                if( $width <= 0 || $this->width <= 0) {
                        # BZZZT
-                       wfProfileOut( $fname );
-                       return null;
+                       return false;
                }
 
                # Don't thumbnail an image so big that it will fill hard drives and send servers into swap
@@ -942,31 +982,65 @@ class Image
                        $this->getMimeType() !== 'image/jpeg' &&
                        $this->width * $this->height > $wgMaxImageArea )
                {
-                       wfProfileOut( $fname );
-                       return null;
+                       return false;
                }
 
                # Don't make an image bigger than the source, or wgMaxSVGSize for SVGs
                if ( $this->mustRender() ) {
                        $width = min( $width, $wgSVGMaxSize );
                } elseif ( $width > $this->width - 1 ) {
-                       $thumb = new ThumbnailImage( $this->getURL(), $this->getWidth(), $this->getHeight() );
-                       wfProfileOut( $fname );
-                       return $thumb;
+                       $width = $this->width;
+                       $height = $this->height;
+                       return true;
                }
 
-               $height = round( $this->height * $width / $this->width );
+               $height = self::scaleHeight( $this->width, $this->height, $width );
+               return true;
+       }
+
+       /**
+        * Create a thumbnail of the image having the specified width.
+        * The thumbnail will not be created if the width is larger than the
+        * image's width. Let the browser do the scaling in this case.
+        * The thumbnail is stored on disk and is only computed if the thumbnail
+        * file does not exist OR if it is older than the image.
+        * Returns an object which can return the pathname, URL, and physical
+        * pixel size of the thumbnail -- or null on failure.
+        *
+        * @return ThumbnailImage or null on failure
+        * @private
+        */
+       function renderThumb( $width, $useScript = true ) {
+               global $wgUseSquid, $wgThumbnailEpoch;
+
+               wfProfileIn( __METHOD__ );
+
+               $this->load();
+               $height = -1;
+               if ( !$this->validateThumbParams( $width, $height ) ) {
+                       # Validation error
+                       wfProfileOut( __METHOD__ );
+                       return null;
+               }
+
+               if ( !$this->mustRender() && $width == $this->width && $height == $this->height ) {
+                       # validateThumbParams (or the user) wants us to return the unscaled image
+                       $thumb = new ThumbnailImage( $this->getURL(), $width, $height );
+                       wfProfileOut( __METHOD__ );
+                       return $thumb;
+               }
 
                list( $isScriptUrl, $url ) = $this->thumbUrl( $width );
                if ( $isScriptUrl && $useScript ) {
                        // Use thumb.php to render the image
                        $thumb = new ThumbnailImage( $url, $width, $height );
-                       wfProfileOut( $fname );
+                       wfProfileOut( __METHOD__ );
                        return $thumb;
                }
 
                $thumbName = $this->thumbName( $width, $this->fromSharedDirectory );
-               $thumbPath = wfImageThumbDir( $this->name, $this->fromSharedDirectory ).'/'.$thumbName;
+               $thumbDir = wfImageThumbDir( $this->name, $this->fromSharedDirectory );
+               $thumbPath = $thumbDir.'/'.$thumbName;
 
                if ( is_dir( $thumbPath ) ) {
                        // Directory where file should be
@@ -986,7 +1060,15 @@ class Image
 
                $done = true;
                if ( !file_exists( $thumbPath ) ||
-                       filemtime( $thumbPath ) < wfTimestamp( TS_UNIX, $wgThumbnailEpoch ) ) {
+                       filemtime( $thumbPath ) < wfTimestamp( TS_UNIX, $wgThumbnailEpoch ) ) 
+               {
+                       // Create the directory if it doesn't exist
+                       if ( is_file( $thumbDir ) ) {
+                               // File where thumb directory should be, destroy if possible
+                               @unlink( $thumbDir );
+                       }
+                       wfMkdirParents( $thumbDir );
+
                        $oldThumbPath = wfDeprecatedThumbDir( $thumbName, 'thumb', $this->fromSharedDirectory ).
                                '/'.$thumbName;
                        $done = false;
@@ -1000,7 +1082,7 @@ class Image
                                                        unlink( $thumbPath );
                                                } else {
                                                        // This should have been dealt with already
-                                                       wfDebugDieBacktrace( "Directory where image should be: $thumbPath" );
+                                                       throw new MWException( "Directory where image should be: $thumbPath" );
                                                }
                                        }
                                        // Rename the old image into the new location
@@ -1011,20 +1093,21 @@ class Image
                                }
                        }
                        if ( !$done ) {
-                               $this->lastError = $this->reallyRenderThumb( $thumbPath, $width, $height );
+                               $this->lastError = self::reallyRenderThumb( $this->imagePath, $thumbPath, $this->mime, 
+                                       $width, $height, $this->page );
                                if ( $this->lastError === true ) {
                                        $done = true;
+                               } elseif( $GLOBALS['wgIgnoreImageErrors'] ) {
+                                       // Log the error but output anyway.
+                                       // With luck it's a transitory error...
+                                       $done = true;
                                }
 
                                # Purge squid
                                # This has to be done after the image is updated and present for all machines on NFS,
                                # or else the old version might be stored into the squid again
                                if ( $wgUseSquid ) {
-                                       if ( substr( $url, 0, 4 ) == 'http' ) {
-                                               $urlArr = array( $url );
-                                       } else {
-                                               $urlArr = array( $wgInternalServer.$url );
-                                       }
+                                       $urlArr = array( $url );
                                        wfPurgeSquidServers($urlArr);
                                }
                        }
@@ -1035,28 +1118,33 @@ class Image
                } else {
                        $thumb = null;
                }
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return $thumb;
        } // END OF function renderThumb
 
        /**
         * Really render a thumbnail
         * Call this only for images for which canRender() returns true.
-        *
-        * @param string $thumbPath Path to thumbnail
-        * @param int $width Desired width in pixels
-        * @param int $height Desired height in pixels
-        * @return bool True on error, false or error string on failure.
-        * @access private
+        * 
+        * @param string $source Source filename
+        * @param string $destination Destination filename
+        * @param string $mime MIME type of source
+        * @param integer $width Destination width in pixels
+        * @param integer $height Destination height in pixels
+        * @param integer $page Which page of a multi-page document to display. Ignored 
+        *           for source MIME types which do not support multiple pages.
         */
-       function reallyRenderThumb( $thumbPath, $width, $height ) {
-               global $wgSVGConverters, $wgSVGConverter,
-                       $wgUseImageMagick, $wgImageMagickConvertCommand;
-
-               $this->load();
+       static function reallyRenderThumb( $source, $destination, $mime, $width, $height, $page = false ) {
+               global $wgSVGConverters, $wgSVGConverter;
+               global $wgUseImageMagick, $wgImageMagickConvertCommand;
+               global $wgCustomConvertCommand;
+               global $wgDjvuRenderer, $wgDjvuPostProcessor;
 
                $err = false;
-               if( $this->mime === "image/svg" ) {
+               $cmd = "";
+               $retval = 0;
+
+               if( $mime == "image/svg" || $mime == 'image/svg+xml' ) {
                        #Right now we have only SVG
 
                        global $wgSVGConverters, $wgSVGConverter;
@@ -1064,23 +1152,40 @@ class Image
                                global $wgSVGConverterPath;
                                $cmd = str_replace(
                                        array( '$path/', '$width', '$height', '$input', '$output' ),
-                                       array( $wgSVGConverterPath ? "$wgSVGConverterPath/" : "",
+                                       array( $wgSVGConverterPath ? wfEscapeShellArg( "$wgSVGConverterPath/" ) : "",
                                                   intval( $width ),
                                                   intval( $height ),
-                                                  wfEscapeShellArg( $this->imagePath ),
-                                                  wfEscapeShellArg( $thumbPath ) ),
-                                       $wgSVGConverters[$wgSVGConverter] );
+                                                  wfEscapeShellArg( $source ),
+                                                  wfEscapeShellArg( $destination ) ),
+                                       $wgSVGConverters[$wgSVGConverter] ) . " 2>&1";
                                wfProfileIn( 'rsvg' );
                                wfDebug( "reallyRenderThumb SVG: $cmd\n" );
-                               $err = wfShellExec( $cmd );
+                               $err = wfShellExec( $cmd, $retval );
                                wfProfileOut( 'rsvg' );
                        }
+               } elseif ( $mime === "image/vnd.djvu" && $wgDjvuRenderer ) {
+                       // DJVU image
+                       // The file contains several images. First, extract the
+                       // page in hi-res, if it doesn't yet exist. Then, thumbnail
+                       // it.
+
+                       $cmd = wfEscapeShellArg( $wgDjvuRenderer ) . " -format=ppm -page={$page} -size=${width}x${height} " .
+                               wfEscapeShellArg( $source );
+                       if ( $wgDjvuPostProcessor ) {
+                               $cmd .= " | {$wgDjvuPostProcessor}";
+                       }
+                       $cmd .= ' > ' . wfEscapeShellArg($destination);
+                       wfProfileIn( 'ddjvu' );
+                       wfDebug( "reallyRenderThumb DJVU: $cmd\n" );
+                       $err = wfShellExec( $cmd, $retval );
+                       wfProfileOut( 'ddjvu' );
+
                } elseif ( $wgUseImageMagick ) {
                        # use ImageMagick
-                       
-                       if ( $this->mime == 'image/jpeg' ) {
+
+                       if ( $mime == 'image/jpeg' ) {
                                $quality = "-quality 80"; // 80%
-                       } elseif ( $this->mime == 'image/png' ) {
+                       } elseif ( $mime == 'image/png' ) {
                                $quality = "-quality 95"; // zlib 9, adaptive filtering
                        } else {
                                $quality = ''; // default
@@ -1092,19 +1197,33 @@ class Image
                        # Note, we specify "-size {$width}" and NOT "-size {$width}x{$height}".
                        # It seems that ImageMagick has a bug wherein it produces thumbnails of
                        # the wrong size in the second case.
-                       
+
                        $cmd  =  wfEscapeShellArg($wgImageMagickConvertCommand) .
                                " {$quality} -background white -size {$width} ".
-                               wfEscapeShellArg($this->imagePath) .
+                               wfEscapeShellArg($source) .
+                               // Coalesce is needed to scale animated GIFs properly (bug 1017).
+                               ' -coalesce ' .
                                // For the -resize option a "!" is needed to force exact size,
                                // or ImageMagick may decide your ratio is wrong and slice off
                                // a pixel.
-                               " -resize " . wfEscapeShellArg( "{$width}x{$height}!" ) .
+                               " -thumbnail " . wfEscapeShellArg( "{$width}x{$height}!" ) .
                                " -depth 8 " .
-                               wfEscapeShellArg($thumbPath) . " 2>&1";
+                               wfEscapeShellArg($destination) . " 2>&1";
                        wfDebug("reallyRenderThumb: running ImageMagick: $cmd\n");
                        wfProfileIn( 'convert' );
-                       $err = wfShellExec( $cmd );
+                       $err = wfShellExec( $cmd, $retval );
+                       wfProfileOut( 'convert' );
+               } elseif( $wgCustomConvertCommand ) {
+                       # Use a custom convert command
+                       # Variables: %s %d %w %h
+                       $src = wfEscapeShellArg( $source );
+                       $dst = wfEscapeShellArg( $destination );
+                       $cmd = $wgCustomConvertCommand;
+                       $cmd = str_replace( '%s', $src, str_replace( '%d', $dst, $cmd ) ); # Filenames
+                       $cmd = str_replace( '%h', $height, str_replace( '%w', $width, $cmd ) ); # Size
+                       wfDebug( "reallyRenderThumb: Running custom convert command $cmd\n" );
+                       wfProfileIn( 'convert' );
+                       $err = wfShellExec( $cmd, $retval );
                        wfProfileOut( 'convert' );
                } else {
                        # Use PHP's builtin GD library functions.
@@ -1114,41 +1233,30 @@ class Image
 
                        $typemap = array(
                                'image/gif'          => array( 'imagecreatefromgif',  'palette',   'imagegif'  ),
-                               'image/jpeg'         => array( 'imagecreatefromjpeg', 'truecolor', array( &$this, 'imageJpegWrapper' ) ),
+                               'image/jpeg'         => array( 'imagecreatefromjpeg', 'truecolor', array( __CLASS__, 'imageJpegWrapper' ) ),
                                'image/png'          => array( 'imagecreatefrompng',  'bits',      'imagepng'  ),
                                'image/vnd.wap.wmbp' => array( 'imagecreatefromwbmp', 'palette',   'imagewbmp'  ),
                                'image/xbm'          => array( 'imagecreatefromxbm',  'palette',   'imagexbm'  ),
                        );
-                       if( !isset( $typemap[$this->mime] ) ) {
+                       if( !isset( $typemap[$mime] ) ) {
                                $err = 'Image type not supported';
                                wfDebug( "$err\n" );
                                return $err;
                        }
-                       list( $loader, $colorStyle, $saveType ) = $typemap[$this->mime];
+                       list( $loader, $colorStyle, $saveType ) = $typemap[$mime];
 
                        if( !function_exists( $loader ) ) {
                                $err = "Incomplete GD library configuration: missing function $loader";
                                wfDebug( "$err\n" );
                                return $err;
                        }
-                       if( $colorStyle == 'palette' ) {
-                               $truecolor = false;
-                       } elseif( $colorStyle == 'truecolor' ) {
-                               $truecolor = true;
-                       } elseif( $colorStyle == 'bits' ) {
-                               $truecolor = ( $this->bits > 8 );
-                       }
 
-                       $src_image = call_user_func( $loader, $this->imagePath );
-                       if ( $truecolor ) {
-                               $dst_image = imagecreatetruecolor( $width, $height );
-                       } else {
-                               $dst_image = imagecreate( $width, $height );
-                       }
+                       $src_image = call_user_func( $loader, $source );
+                       $dst_image = imagecreatetruecolor( $width, $height );
                        imagecopyresampled( $dst_image, $src_image,
                                                0,0,0,0,
-                                               $width, $height, $this->width, $this->height );
-                       call_user_func( $saveType, $dst_image, $thumbPath );
+                                               $width, $height, imagesx( $src_image ), imagesy( $src_image ) );
+                       call_user_func( $saveType, $dst_image, $destination );
                        imagedestroy( $dst_image );
                        imagedestroy( $src_image );
                }
@@ -1157,16 +1265,21 @@ class Image
                # Check for zero-sized thumbnails. Those can be generated when
                # no disk space is available or some other error occurs
                #
-               if( file_exists( $thumbPath ) ) {
-                       $thumbstat = stat( $thumbPath );
-                       if( $thumbstat['size'] == 0 ) {
-                               unlink( $thumbPath );
-                       } else {
-                               // All good
-                               $err = true;
+               $removed = false;
+               if( file_exists( $destination ) ) {
+                       $thumbstat = stat( $destination );
+                       if( $thumbstat['size'] == 0 || $retval != 0 ) {
+                               wfDebugLog( 'thumbnail',
+                                       sprintf( 'Removing bad %d-byte thumbnail "%s"',
+                                               $thumbstat['size'], $destination ) );
+                               unlink( $destination );
+                               $removed = true;
                        }
                }
-               if ( $err !== true ) {
+               if ( $retval != 0 || $removed ) {
+                       wfDebugLog( 'thumbnail',
+                               sprintf( 'thumbnail failed on %s: error %d "%s" from "%s"',
+                                       wfHostname(), $retval, trim($err), $cmd ) );
                        return wfMsg( 'thumbnail_error', $err );
                } else {
                        return true;
@@ -1177,7 +1290,7 @@ class Image
                return $this->lastError;
        }
 
-       function imageJpegWrapper( $dst_image, $thumbPath ) {
+       static function imageJpegWrapper( $dst_image, $thumbPath ) {
                imageinterlace( $dst_image );
                imagejpeg( $dst_image, $thumbPath, 95 );
        }
@@ -1191,16 +1304,17 @@ class Image
                        $files = array();
                        $dir = wfImageThumbDir( $this->name, $shared );
 
-                       // This generates an error on failure, hence the @
-                       $handle = @opendir( $dir );
+                       if ( is_dir( $dir ) ) {
+                               $handle = opendir( $dir );
 
-                       if ( $handle ) {
-                               while ( false !== ( $file = readdir($handle) ) ) {
-                                       if ( $file{0} != '.' ) {
-                                               $files[] = $file;
+                               if ( $handle ) {
+                                       while ( false !== ( $file = readdir($handle) ) ) {
+                                               if ( $file{0} != '.' ) {
+                                                       $files[] = $file;
+                                               }
                                        }
+                                       closedir( $handle );
                                }
-                               closedir( $handle );
                        }
                } else {
                        $files = array();
@@ -1222,7 +1336,7 @@ class Image
         * Delete all previously generated thumbnails, refresh metadata in memcached and purge the squid
         */
        function purgeCache( $archiveFiles = array(), $shared = false ) {
-               global $wgInternalServer, $wgUseSquid;
+               global $wgUseSquid;
 
                // Refresh metadata cache
                $this->purgeMetadataCache();
@@ -1232,39 +1346,78 @@ class Image
                $dir = wfImageThumbDir( $this->name, $shared );
                $urls = array();
                foreach ( $files as $file ) {
+                       $m = array();
                        if ( preg_match( '/^(\d+)px/', $file, $m ) ) {
-                               $urls[] = $wgInternalServer . $this->thumbUrl( $m[1], $this->fromSharedDirectory );
+                               list( /* $isScriptUrl */, $url ) = $this->thumbUrl( $m[1] );
+                               $urls[] = $url;
                                @unlink( "$dir/$file" );
                        }
                }
 
                // Purge the squid
                if ( $wgUseSquid ) {
-                       $urls[] = $wgInternalServer . $this->getViewURL();
+                       $urls[] = $this->getURL();
                        foreach ( $archiveFiles as $file ) {
-                               $urls[] = $wgInternalServer . wfImageArchiveUrl( $file );
+                               $urls[] = wfImageArchiveUrl( $file );
                        }
                        wfPurgeSquidServers( $urls );
                }
        }
 
+       /**
+        * Purge the image description page, but don't go after
+        * pages using the image. Use when modifying file history
+        * but not the current data.
+        */
+       function purgeDescription() {
+               $page = Title::makeTitle( NS_IMAGE, $this->name );
+               $page->invalidateCache();
+               $page->purgeSquid();
+       }
+
+       /**
+        * Purge metadata and all affected pages when the image is created,
+        * deleted, or majorly updated. A set of additional URLs may be
+        * passed to purge, such as specific image files which have changed.
+        * @param $urlArray array
+        */
+       function purgeEverything( $urlArr=array() ) {
+               // Delete thumbnails and refresh image metadata cache
+               $this->purgeCache();
+               $this->purgeDescription();
+
+               // Purge cache of all pages using this image
+               $update = new HTMLCacheUpdate( $this->getTitle(), 'imagelinks' );
+               $update->doUpdate();
+       }
+
        function checkDBSchema(&$db) {
-                global $wgCheckDBSchema;
-               if (!$wgCheckDBSchema) {
+               static $checkDone = false;
+               global $wgCheckDBSchema;
+               if (!$wgCheckDBSchema || $checkDone) {
                        return;
                }
                # img_name must be unique
                if ( !$db->indexUnique( 'image', 'img_name' ) && !$db->indexExists('image','PRIMARY') ) {
-                       wfDebugDieBacktrace( 'Database schema not up to date, please run maintenance/archives/patch-image_name_unique.sql' );
-               }
-
-               #new fields must exist
+                       throw new MWException( 'Database schema not up to date, please run maintenance/archives/patch-image_name_unique.sql' );
+               }
+               $checkDone = true;
+
+               # new fields must exist
+               # 
+               # Not really, there's hundreds of checks like this that we could do and they're all pointless, because 
+               # if the fields are missing, the database will loudly report a query error, the first time you try to do 
+               # something. The only reason I put the above schema check in was because the absence of that particular
+               # index would lead to an annoying subtle bug. No error message, just some very odd behaviour on duplicate
+               # uploads. -- TS
+               /*
                if ( !$db->fieldExists( 'image', 'img_media_type' )
                  || !$db->fieldExists( 'image', 'img_metadata' )
                  || !$db->fieldExists( 'image', 'img_width' ) ) {
 
-                       wfDebugDieBacktrace( 'Database schema not up to date, please run maintenance/update.php' );
-               }
+                       throw new MWException( 'Database schema not up to date, please run maintenance/update.php' );
+                }
+                */
        }
 
        /**
@@ -1275,11 +1428,10 @@ class Image
         *  1      query for old versions, return first one
         *  2, ... return next old version from above query
         *
-        * @access public
+        * @public
         */
        function nextHistoryLine() {
-               $fname = 'Image::nextHistoryLine()';
-               $dbr =& wfGetDB( DB_SLAVE );
+               $dbr = wfGetDB( DB_SLAVE );
 
                $this->checkDBSchema($dbr);
 
@@ -1295,9 +1447,9 @@ class Image
                                        "'' AS oi_archive_name"
                                ),
                                array( 'img_name' => $this->title->getDBkey() ),
-                               $fname
+                               __METHOD__
                        );
-                       if ( 0 == wfNumRows( $this->historyRes ) ) {
+                       if ( 0 == $dbr->numRows( $this->historyRes ) ) {
                                return FALSE;
                        }
                } else if ( $this->historyLine == 1 ) {
@@ -1313,7 +1465,7 @@ class Image
                                        'oi_archive_name'
                                ),
                                array( 'oi_name' => $this->title->getDBkey() ),
-                               $fname,
+                               __METHOD__,
                                array( 'ORDER BY' => 'oi_timestamp DESC' )
                        );
                }
@@ -1324,7 +1476,7 @@ class Image
 
        /**
         * Reset the history pointer to the first element of the history
-        * @access public
+        * @public
         */
        function resetHistory() {
                $this->historyLine = 0;
@@ -1338,7 +1490,7 @@ class Image
        * i.e. whether the images are all found in the same directory,
        * or in hashed paths like /images/3/3c.
        *
-       * @access public
+       * @public
        * @param boolean $fromSharedDirectory Return the path to the file
        *   in a shared repository (see $wgUseSharedRepository and related
        *   options in DefaultSettings.php) instead of a local one.
@@ -1364,7 +1516,7 @@ class Image
         * @return bool
         * @static
         */
-       function isHashed( $shared ) {
+       public static function isHashed( $shared ) {
                global $wgHashedUploadDirectory, $wgHashedSharedUploadDirectory;
                return $shared ? $wgHashedSharedUploadDirectory : $wgHashedUploadDirectory;
        }
@@ -1373,10 +1525,9 @@ class Image
         * Record an image upload in the upload log and the image table
         */
        function recordUpload( $oldver, $desc, $license = '', $copyStatus = '', $source = '', $watch = false ) {
-               global $wgUser, $wgUseCopyrightUpload, $wgUseSquid, $wgPostCommitUpdateList;
+               global $wgUser, $wgUseCopyrightUpload;
 
-               $fname = 'Image::recordUpload';
-               $dbw =& wfGetDB( DB_MASTER );
+               $dbw = wfGetDB( DB_MASTER );
 
                $this->checkDBSchema($dbw);
 
@@ -1437,11 +1588,9 @@ class Image
                                'img_user_text' => $wgUser->getName(),
                                'img_metadata' => $this->metadata,
                        ),
-                       $fname,
+                       __METHOD__,
                        'IGNORE'
                );
-               $descTitle = $this->getTitle();
-               $purgeURLs = array();
 
                if( $dbw->affectedRows() == 0 ) {
                        # Collision, this is an update of an image
@@ -1458,7 +1607,7 @@ class Image
                                        'oi_description' => 'img_description',
                                        'oi_user' => 'img_user',
                                        'oi_user_text' => 'img_user_text',
-                               ), array( 'img_name' => $this->name ), $fname
+                               ), array( 'img_name' => $this->name ), __METHOD__
                        );
 
                        # Update the current image row
@@ -1478,10 +1627,16 @@ class Image
                                        'img_metadata' => $this->metadata,
                                ), array( /* WHERE */
                                        'img_name' => $this->name
-                               ), $fname
+                               ), __METHOD__
                        );
+               } else {
+                       # This is a new image
+                       # Update the image count
+                       $site_stats = $dbw->tableName( 'site_stats' );
+                       $dbw->query( "UPDATE $site_stats SET ss_images=ss_images+1", __METHOD__ );
                }
 
+               $descTitle = $this->getTitle();
                $article = new Article( $descTitle );
                $minor = false;
                $watch = $watch || $wgUser->isWatched( $descTitle );
@@ -1495,24 +1650,27 @@ class Image
 
                        # Invalidate the cache for the description page
                        $descTitle->invalidateCache();
-                       $purgeURLs[] = $descTitle->getInternalURL();
+                       $descTitle->purgeSquid();
                } else {
                        // New image; create the description page.
                        $article->insertNewArticle( $textdesc, $desc, $minor, $watch, $suppressRC );
                }
 
-               # Invalidate cache for all pages using this image
-               $linksTo = $this->getLinksTo();
-
-               if ( $wgUseSquid ) {
-                       $u = SquidUpdate::newFromTitles( $linksTo, $purgeURLs );
-                       array_push( $wgPostCommitUpdateList, $u );
-               }
-               Title::touchArray( $linksTo );
+               # Hooks, hooks, the magic of hooks...
+               wfRunHooks( 'FileUpload', array( $this ) );
 
+               # Add the log entry
                $log = new LogPage( 'upload' );
                $log->addEntry( 'upload', $descTitle, $desc );
 
+               # Commit the transaction now, in case something goes wrong later
+               # The most important thing is that images don't get lost, especially archives
+               $dbw->immediateCommit();
+
+               # Invalidate cache for all pages using this image
+               $update = new HTMLCacheUpdate( $this->getTitle(), 'imagelinks' );
+               $update->doUpdate();
+
                return true;
        }
 
@@ -1521,22 +1679,23 @@ class Image
         * Also adds their IDs to the link cache
         *
         * This is mostly copied from Title::getLinksTo()
+        *
+        * @deprecated Use HTMLCacheUpdate, this function uses too much memory
         */
        function getLinksTo( $options = '' ) {
-               $fname = 'Image::getLinksTo';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
 
                if ( $options ) {
-                       $db =& wfGetDB( DB_MASTER );
+                       $db = wfGetDB( DB_MASTER );
                } else {
-                       $db =& wfGetDB( DB_SLAVE );
+                       $db = wfGetDB( DB_SLAVE );
                }
                $linkCache =& LinkCache::singleton();
 
-               extract( $db->tableNames( 'page', 'imagelinks' ) );
+               list( $page, $imagelinks ) = $db->tableNamesN( 'page', 'imagelinks' );
                $encName = $db->addQuotes( $this->name );
                $sql = "SELECT page_namespace,page_title,page_id FROM $page,$imagelinks WHERE page_id=il_from AND il_to=$encName $options";
-               $res = $db->query( $sql, $fname );
+               $res = $db->query( $sql, __METHOD__ );
 
                $retVal = array();
                if ( $db->numRows( $res ) ) {
@@ -1548,28 +1707,36 @@ class Image
                        }
                }
                $db->freeResult( $res );
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return $retVal;
        }
+
        /**
-        * Retrive Exif data from the database
-        *
-        * Retrive Exif data from the database and prune unrecognized tags
+        * Retrive Exif data from the file and prune unrecognized tags
         * and/or tags with invalid contents
         *
+        * @param $filename
         * @return array
         */
-       function retrieveExifData() {
+       private function retrieveExifData( $filename ) {
+               global $wgShowEXIF;
+
+               /*
                if ( $this->getMimeType() !== "image/jpeg" )
                        return array();
+               */
+
+               if( $wgShowEXIF && file_exists( $filename ) ) {
+                       $exif = new Exif( $filename );
+                       return $exif->getFilteredData();
+               }
 
-               $exif = new Exif( $this->imagePath );
-               return $exif->getFilteredData();
+               return array();
        }
 
        function getExifData() {
                global $wgRequest;
-               if ( $this->metadata === '0' )
+               if ( $this->metadata === '0' || $this->mime == 'image/vnd.djvu' )
                        return array();
 
                $purge = $wgRequest->getVal( 'action' ) == 'purge';
@@ -1590,13 +1757,11 @@ class Image
        }
 
        function updateExifData( $version ) {
-               $fname = 'Image:updateExifData';
-
                if ( $this->getImagePath() === false ) # Not a local image
                        return;
 
                # Get EXIF data from image
-               $exif = $this->retrieveExifData();
+               $exif = $this->retrieveExifData( $this->imagePath );
                if ( count( $exif ) ) {
                        $exif['MEDIAWIKI_EXIF_VERSION'] = $version;
                        $this->metadata = serialize( $exif );
@@ -1605,14 +1770,14 @@ class Image
                }
 
                # Update EXIF data in database
-               $dbw =& wfGetDB( DB_MASTER );
+               $dbw = wfGetDB( DB_MASTER );
 
                $this->checkDBSchema($dbw);
 
                $dbw->update( 'image',
                        array( 'img_metadata' => $this->metadata ),
                        array( 'img_name' => $this->name ),
-                       $fname
+                       __METHOD__
                );
        }
 
@@ -1626,254 +1791,742 @@ class Image
                return !$this->fromSharedDirectory;
        }
 
-} //class
+       /**
+        * Was this image ever deleted from the wiki?
+        *
+        * @return bool
+        */
+       function wasDeleted() {
+               $title = Title::makeTitle( NS_IMAGE, $this->name );
+               return ( $title->isDeleted() > 0 );
+       }
 
+       /**
+        * Delete all versions of the image.
+        *
+        * Moves the files into an archive directory (or deletes them)
+        * and removes the database rows.
+        *
+        * Cache purging is done; logging is caller's responsibility.
+        *
+        * @param $reason
+        * @return true on success, false on some kind of failure
+        */
+       function delete( $reason, $suppress=false ) {
+               $transaction = new FSTransaction();
+               $urlArr = array( $this->getURL() );
 
-/**
- * Returns the image directory of an image
- * If the directory does not exist, it is created.
- * The result is an absolute path.
- *
- * This function is called from thumb.php before Setup.php is included
- *
- * @param string $fname                file name of the image file
- * @access public
- */
-function wfImageDir( $fname ) {
-       global $wgUploadDirectory, $wgHashedUploadDirectory;
+               if( !FileStore::lock() ) {
+                       wfDebug( __METHOD__.": failed to acquire file store lock, aborting\n" );
+                       return false;
+               }
 
-       if (!$wgHashedUploadDirectory) { return $wgUploadDirectory; }
+               try {
+                       $dbw = wfGetDB( DB_MASTER );
+                       $dbw->begin();
 
-       $hash = md5( $fname );
-       $oldumask = umask(0);
-       $dest = $wgUploadDirectory . '/' . $hash{0};
-       if ( ! is_dir( $dest ) ) { mkdir( $dest, 0777 ); }
-       $dest .= '/' . substr( $hash, 0, 2 );
-       if ( ! is_dir( $dest ) ) { mkdir( $dest, 0777 ); }
+                       // Delete old versions
+                       $result = $dbw->select( 'oldimage',
+                               array( 'oi_archive_name' ),
+                               array( 'oi_name' => $this->name ) );
 
-       umask( $oldumask );
-       return $dest;
-}
+                       while( $row = $dbw->fetchObject( $result ) ) {
+                               $oldName = $row->oi_archive_name;
 
-/**
- * Returns the image directory of an image's thubnail
- * If the directory does not exist, it is created.
- * The result is an absolute path.
- *
- * This function is called from thumb.php before Setup.php is included
- *
- * @param string $fname                file name of the original image file
- * @param string $subdir       (optional) subdirectory of the image upload directory that should be used for storing the thumbnail. Default is 'thumb'
- * @param boolean $shared      (optional) use the shared upload directory
- * @access public
- */
-function wfImageThumbDir( $fname, $shared = false ) {
-       $base = wfImageArchiveDir( $fname, 'thumb', $shared );
-       if ( Image::isHashed( $shared ) ) {
-               $dir =  "$base/$fname";
+                               $transaction->add( $this->prepareDeleteOld( $oldName, $reason, $suppress ) );
+
+                               // We'll need to purge this URL from caches...
+                               $urlArr[] = wfImageArchiveUrl( $oldName );
+                       }
+                       $dbw->freeResult( $result );
+
+                       // And the current version...
+                       $transaction->add( $this->prepareDeleteCurrent( $reason, $suppress ) );
+
+                       $dbw->immediateCommit();
+               } catch( MWException $e ) {
+                       wfDebug( __METHOD__.": db error, rolling back file transactions\n" );
+                       $transaction->rollback();
+                       FileStore::unlock();
+                       throw $e;
+               }
+
+               wfDebug( __METHOD__.": deleted db items, applying file transactions\n" );
+               $transaction->commit();
+               FileStore::unlock();
+
+
+               // Update site_stats
+               $site_stats = $dbw->tableName( 'site_stats' );
+               $dbw->query( "UPDATE $site_stats SET ss_images=ss_images-1", __METHOD__ );
+
+               $this->purgeEverything( $urlArr );
 
-               if ( !is_dir( $base ) ) {
-                       $oldumask = umask(0);
-                       @mkdir( $base, 0777 );
-                       umask( $oldumask );
+               return true;
+       }
+
+
+       /**
+        * Delete an old version of the image.
+        *
+        * Moves the file into an archive directory (or deletes it)
+        * and removes the database row.
+        *
+        * Cache purging is done; logging is caller's responsibility.
+        *
+        * @param $reason
+        * @throws MWException or FSException on database or filestore failure
+        * @return true on success, false on some kind of failure
+        */
+       function deleteOld( $archiveName, $reason, $suppress=false ) {
+               $transaction = new FSTransaction();
+               $urlArr = array();
+
+               if( !FileStore::lock() ) {
+                       wfDebug( __METHOD__.": failed to acquire file store lock, aborting\n" );
+                       return false;
+               }
+
+               $transaction = new FSTransaction();
+               try {
+                       $dbw = wfGetDB( DB_MASTER );
+                       $dbw->begin();
+                       $transaction->add( $this->prepareDeleteOld( $archiveName, $reason, $suppress ) );
+                       $dbw->immediateCommit();
+               } catch( MWException $e ) {
+                       wfDebug( __METHOD__.": db error, rolling back file transaction\n" );
+                       $transaction->rollback();
+                       FileStore::unlock();
+                       throw $e;
+               }
+
+               wfDebug( __METHOD__.": deleted db items, applying file transaction\n" );
+               $transaction->commit();
+               FileStore::unlock();
+
+               $this->purgeDescription();
+
+               // Squid purging
+               global $wgUseSquid;
+               if ( $wgUseSquid ) {
+                       $urlArr = array(
+                               wfImageArchiveUrl( $archiveName ),
+                       );
+                       wfPurgeSquidServers( $urlArr );
+               }
+               return true;
+       }
+
+       /**
+        * Delete the current version of a file.
+        * May throw a database error.
+        * @return true on success, false on failure
+        */
+       private function prepareDeleteCurrent( $reason, $suppress=false ) {
+               return $this->prepareDeleteVersion(
+                       $this->getFullPath(),
+                       $reason,
+                       'image',
+                       array(
+                               'fa_name'         => 'img_name',
+                               'fa_archive_name' => 'NULL',
+                               'fa_size'         => 'img_size',
+                               'fa_width'        => 'img_width',
+                               'fa_height'       => 'img_height',
+                               'fa_metadata'     => 'img_metadata',
+                               'fa_bits'         => 'img_bits',
+                               'fa_media_type'   => 'img_media_type',
+                               'fa_major_mime'   => 'img_major_mime',
+                               'fa_minor_mime'   => 'img_minor_mime',
+                               'fa_description'  => 'img_description',
+                               'fa_user'         => 'img_user',
+                               'fa_user_text'    => 'img_user_text',
+                               'fa_timestamp'    => 'img_timestamp' ),
+                       array( 'img_name' => $this->name ),
+                       $suppress,
+                       __METHOD__ );
+       }
+
+       /**
+        * Delete a given older version of a file.
+        * May throw a database error.
+        * @return true on success, false on failure
+        */
+       private function prepareDeleteOld( $archiveName, $reason, $suppress=false ) {
+               $oldpath = wfImageArchiveDir( $this->name ) .
+                       DIRECTORY_SEPARATOR . $archiveName;
+               return $this->prepareDeleteVersion(
+                       $oldpath,
+                       $reason,
+                       'oldimage',
+                       array(
+                               'fa_name'         => 'oi_name',
+                               'fa_archive_name' => 'oi_archive_name',
+                               'fa_size'         => 'oi_size',
+                               'fa_width'        => 'oi_width',
+                               'fa_height'       => 'oi_height',
+                               'fa_metadata'     => 'NULL',
+                               'fa_bits'         => 'oi_bits',
+                               'fa_media_type'   => 'NULL',
+                               'fa_major_mime'   => 'NULL',
+                               'fa_minor_mime'   => 'NULL',
+                               'fa_description'  => 'oi_description',
+                               'fa_user'         => 'oi_user',
+                               'fa_user_text'    => 'oi_user_text',
+                               'fa_timestamp'    => 'oi_timestamp' ),
+                       array(
+                               'oi_name' => $this->name,
+                               'oi_archive_name' => $archiveName ),
+                       $suppress,
+                       __METHOD__ );
+       }
+
+       /**
+        * Do the dirty work of backing up an image row and its file
+        * (if $wgSaveDeletedFiles is on) and removing the originals.
+        *
+        * Must be run while the file store is locked and a database
+        * transaction is open to avoid race conditions.
+        *
+        * @return FSTransaction
+        */
+       private function prepareDeleteVersion( $path, $reason, $table, $fieldMap, $where, $suppress=false, $fname ) {
+               global $wgUser, $wgSaveDeletedFiles;
+
+               // Dupe the file into the file store
+               if( file_exists( $path ) ) {
+                       if( $wgSaveDeletedFiles ) {
+                               $group = 'deleted';
+
+                               $store = FileStore::get( $group );
+                               $key = FileStore::calculateKey( $path, $this->extension );
+                               $transaction = $store->insert( $key, $path,
+                                       FileStore::DELETE_ORIGINAL );
+                       } else {
+                               $group = null;
+                               $key = null;
+                               $transaction = FileStore::deleteFile( $path );
+                       }
+               } else {
+                       wfDebug( __METHOD__." deleting already-missing '$path'; moving on to database\n" );
+                       $group = null;
+                       $key = null;
+                       $transaction = new FSTransaction(); // empty
                }
 
-               if ( ! is_dir( $dir ) ) {
-                       if ( is_file( $dir ) ) {
-                               // Old thumbnail in the way of directory creation, kill it
-                               unlink( $dir );
+               if( $transaction === false ) {
+                       // Fail to restore?
+                       wfDebug( __METHOD__.": import to file store failed, aborting\n" );
+                       throw new MWException( "Could not archive and delete file $path" );
+                       return false;
+               }
+               
+               // Bitfields to further supress the image content
+               // Note that currently, live images are stored elsewhere
+               // and cannot be partially deleted
+               $bitfield = 0;
+               if ( $suppress ) {
+                       $bitfield |= self::DELETED_FILE;
+                       $bitfield |= self::DELETED_COMMENT;
+                       $bitfield |= self::DELETED_USER;
+                       $bitfield |= self::DELETED_RESTRICTED;
+               }
+
+               $dbw = wfGetDB( DB_MASTER );
+               $storageMap = array(
+                       'fa_storage_group' => $dbw->addQuotes( $group ),
+                       'fa_storage_key'   => $dbw->addQuotes( $key ),
+
+                       'fa_deleted_user'      => $dbw->addQuotes( $wgUser->getId() ),
+                       'fa_deleted_timestamp' => $dbw->timestamp(),
+                       'fa_deleted_reason'    => $dbw->addQuotes( $reason ),
+                       'fa_deleted'               => $bitfield);
+               $allFields = array_merge( $storageMap, $fieldMap );
+
+               try {
+                       if( $wgSaveDeletedFiles ) {
+                               $dbw->insertSelect( 'filearchive', $table, $allFields, $where, $fname );
                        }
-                       $oldumask = umask(0);
-                       @mkdir( $dir, 0777 );
-                       umask( $oldumask );
+                       $dbw->delete( $table, $where, $fname );
+               } catch( DBQueryError $e ) {
+                       // Something went horribly wrong!
+                       // Leave the file as it was...
+                       wfDebug( __METHOD__.": database error, rolling back file transaction\n" );
+                       $transaction->rollback();
+                       throw $e;
                }
-       } else {
-               $dir = $base;
+
+               return $transaction;
        }
 
-       return $dir;
-}
+       /**
+        * Restore all or specified deleted revisions to the given file.
+        * Permissions and logging are left to the caller.
+        *
+        * May throw database exceptions on error.
+        *
+        * @param $versions set of record ids of deleted items to restore,
+        *                    or empty to restore all revisions.
+        * @return the number of file revisions restored if successful,
+        *         or false on failure
+        */
+       function restore( $versions=array(), $Unsuppress=false ) {
+               global $wgUser;
+       
+               if( !FileStore::lock() ) {
+                       wfDebug( __METHOD__." could not acquire filestore lock\n" );
+                       return false;
+               }
 
-/**
- * Old thumbnail directory, kept for conversion
- */
-function wfDeprecatedThumbDir( $thumbName , $subdir='thumb', $shared=false) {
-       return wfImageArchiveDir( $thumbName, $subdir, $shared );
-}
+               $transaction = new FSTransaction();
+               try {
+                       $dbw = wfGetDB( DB_MASTER );
+                       $dbw->begin();
 
-/**
- * Returns the image directory of an image's old version
- * If the directory does not exist, it is created.
- * The result is an absolute path.
- *
- * This function is called from thumb.php before Setup.php is included
- *
- * @param string $fname                file name of the thumbnail file, including file size prefix
- * @param string $subdir       (optional) subdirectory of the image upload directory that should be used for storing the old version. Default is 'archive'
- * @param boolean $shared      (optional) use the shared upload directory (only relevant for other functions which call this one)
- * @access public
- */
-function wfImageArchiveDir( $fname , $subdir='archive', $shared=false ) {
-       global $wgUploadDirectory, $wgHashedUploadDirectory,
-              $wgSharedUploadDirectory, $wgHashedSharedUploadDirectory;
-       $dir = $shared ? $wgSharedUploadDirectory : $wgUploadDirectory;
-       $hashdir = $shared ? $wgHashedSharedUploadDirectory : $wgHashedUploadDirectory;
-       if (!$hashdir) { return $dir.'/'.$subdir; }
-       $hash = md5( $fname );
-       $oldumask = umask(0);
-
-       # Suppress warning messages here; if the file itself can't
-       # be written we'll worry about it then.
-       wfSuppressWarnings();
-
-       $archive = $dir.'/'.$subdir;
-       if ( ! is_dir( $archive ) ) { mkdir( $archive, 0777 ); }
-       $archive .= '/' . $hash{0};
-       if ( ! is_dir( $archive ) ) { mkdir( $archive, 0777 ); }
-       $archive .= '/' . substr( $hash, 0, 2 );
-       if ( ! is_dir( $archive ) ) { mkdir( $archive, 0777 ); }
-
-       wfRestoreWarnings();
-       umask( $oldumask );
-       return $archive;
-}
+                       // Re-confirm whether this image presently exists;
+                       // if no we'll need to create an image record for the
+                       // first item we restore.
+                       $exists = $dbw->selectField( 'image', '1',
+                               array( 'img_name' => $this->name ),
+                               __METHOD__ );
 
+                       // Fetch all or selected archived revisions for the file,
+                       // sorted from the most recent to the oldest.
+                       $conditions = array( 'fa_name' => $this->name );
+                       if( $versions ) {
+                               $conditions['fa_id'] = $versions;
+                       }
 
-/*
- * Return the hash path component of an image path (URL or filesystem),
- * e.g. "/3/3c/", or just "/" if hashing is not used.
- *
- * @param $dbkey The filesystem / database name of the file
- * @param $fromSharedDirectory Use the shared file repository? It may
- *   use different hash settings from the local one.
- */
-function wfGetHashPath ( $dbkey, $fromSharedDirectory = false ) {
-       if( Image::isHashed( $fromSharedDirectory ) ) {
-               $hash = md5($dbkey);
-               return '/' . $hash{0} . '/' . substr( $hash, 0, 2 ) . '/';
-       } else {
-               return '/';
+                       $result = $dbw->select( 'filearchive', '*',
+                               $conditions,
+                               __METHOD__,
+                               array( 'ORDER BY' => 'fa_timestamp DESC' ) );
+
+                       if( $dbw->numRows( $result ) < count( $versions ) ) {
+                               // There's some kind of conflict or confusion;
+                               // we can't restore everything we were asked to.
+                               wfDebug( __METHOD__.": couldn't find requested items\n" );
+                               $dbw->rollback();
+                               FileStore::unlock();
+                               return false;
+                       }
+
+                       if( $dbw->numRows( $result ) == 0 ) {
+                               // Nothing to do.
+                               wfDebug( __METHOD__.": nothing to do\n" );
+                               $dbw->rollback();
+                               FileStore::unlock();
+                               return true;
+                       }
+
+                       $revisions = 0;
+                       while( $row = $dbw->fetchObject( $result ) ) {
+                               if ( $Unsuppress ) {
+                               // Currently, fa_deleted flags fall off upon restore, lets be careful about this
+                               } else if ( ($row->fa_deleted & Revision::DELETED_RESTRICTED) && !$wgUser->isAllowed('hiderevision') ) {
+                               // Skip restoring file revisions that the user cannot restore
+                                       continue;
+                               }
+                               $revisions++;
+                               $store = FileStore::get( $row->fa_storage_group );
+                               if( !$store ) {
+                                       wfDebug( __METHOD__.": skipping row with no file.\n" );
+                                       continue;
+                               }
+
+                               if( $revisions == 1 && !$exists ) {
+                                       $destDir = wfImageDir( $row->fa_name );
+                                       if ( !is_dir( $destDir ) ) {
+                                               wfMkdirParents( $destDir );
+                                       }
+                                       $destPath = $destDir . DIRECTORY_SEPARATOR . $row->fa_name;
+
+                                       // We may have to fill in data if this was originally
+                                       // an archived file revision.
+                                       if( is_null( $row->fa_metadata ) ) {
+                                               $tempFile = $store->filePath( $row->fa_storage_key );
+                                               $metadata = serialize( $this->retrieveExifData( $tempFile ) );
+
+                                               $magic = MimeMagic::singleton();
+                                               $mime = $magic->guessMimeType( $tempFile, true );
+                                               $media_type = $magic->getMediaType( $tempFile, $mime );
+                                               list( $major_mime, $minor_mime ) = self::splitMime( $mime );
+                                       } else {
+                                               $metadata   = $row->fa_metadata;
+                                               $major_mime = $row->fa_major_mime;
+                                               $minor_mime = $row->fa_minor_mime;
+                                               $media_type = $row->fa_media_type;
+                                       }
+
+                                       $table = 'image';
+                                       $fields = array(
+                                               'img_name'        => $row->fa_name,
+                                               'img_size'        => $row->fa_size,
+                                               'img_width'       => $row->fa_width,
+                                               'img_height'      => $row->fa_height,
+                                               'img_metadata'    => $metadata,
+                                               'img_bits'        => $row->fa_bits,
+                                               'img_media_type'  => $media_type,
+                                               'img_major_mime'  => $major_mime,
+                                               'img_minor_mime'  => $minor_mime,
+                                               'img_description' => $row->fa_description,
+                                               'img_user'        => $row->fa_user,
+                                               'img_user_text'   => $row->fa_user_text,
+                                               'img_timestamp'   => $row->fa_timestamp );
+                               } else {
+                                       $archiveName = $row->fa_archive_name;
+                                       if( $archiveName == '' ) {
+                                               // This was originally a current version; we
+                                               // have to devise a new archive name for it.
+                                               // Format is <timestamp of archiving>!<name>
+                                               $archiveName =
+                                                       wfTimestamp( TS_MW, $row->fa_deleted_timestamp ) .
+                                                       '!' . $row->fa_name;
+                                       }
+                                       $destDir = wfImageArchiveDir( $row->fa_name );
+                                       if ( !is_dir( $destDir ) ) {
+                                               wfMkdirParents( $destDir );
+                                       }
+                                       $destPath = $destDir . DIRECTORY_SEPARATOR . $archiveName;
+
+                                       $table = 'oldimage';
+                                       $fields = array(
+                                               'oi_name'         => $row->fa_name,
+                                               'oi_archive_name' => $archiveName,
+                                               'oi_size'         => $row->fa_size,
+                                               'oi_width'        => $row->fa_width,
+                                               'oi_height'       => $row->fa_height,
+                                               'oi_bits'         => $row->fa_bits,
+                                               'oi_description'  => $row->fa_description,
+                                               'oi_user'         => $row->fa_user,
+                                               'oi_user_text'    => $row->fa_user_text,
+                                               'oi_timestamp'    => $row->fa_timestamp );
+                               }
+
+                               $dbw->insert( $table, $fields, __METHOD__ );
+                               // @todo this delete is not totally safe, potentially
+                               $dbw->delete( 'filearchive',
+                                       array( 'fa_id' => $row->fa_id ),
+                                       __METHOD__ );
+
+                               // Check if any other stored revisions use this file;
+                               // if so, we shouldn't remove the file from the deletion
+                               // archives so they will still work.
+                               $useCount = $dbw->selectField( 'filearchive',
+                                       'COUNT(*)',
+                                       array(
+                                               'fa_storage_group' => $row->fa_storage_group,
+                                               'fa_storage_key'   => $row->fa_storage_key ),
+                                       __METHOD__ );
+                               if( $useCount == 0 ) {
+                                       wfDebug( __METHOD__.": nothing else using {$row->fa_storage_key}, will deleting after\n" );
+                                       $flags = FileStore::DELETE_ORIGINAL;
+                               } else {
+                                       $flags = 0;
+                               }
+
+                               $transaction->add( $store->export( $row->fa_storage_key,
+                                       $destPath, $flags ) );
+                       }
+
+                       $dbw->immediateCommit();
+               } catch( MWException $e ) {
+                       wfDebug( __METHOD__." caught error, aborting\n" );
+                       $transaction->rollback();
+                       throw $e;
+               }
+
+               $transaction->commit();
+               FileStore::unlock();
+
+               if( $revisions > 0 ) {
+                       if( !$exists ) {
+                               wfDebug( __METHOD__." restored $revisions items, creating a new current\n" );
+
+                               // Update site_stats
+                               $site_stats = $dbw->tableName( 'site_stats' );
+                               $dbw->query( "UPDATE $site_stats SET ss_images=ss_images+1", __METHOD__ );
+
+                               $this->purgeEverything();
+                       } else {
+                               wfDebug( __METHOD__." restored $revisions as archived versions\n" );
+                               $this->purgeDescription();
+                       }
+               }
+
+               return $revisions;
        }
-}
 
-/**
- * Returns the image URL of an image's old version
- *
- * @param string $fname                file name of the image file
- * @param string $subdir       (optional) subdirectory of the image upload directory that is used by the old version. Default is 'archive'
- * @access public
- */
-function wfImageArchiveUrl( $name, $subdir='archive' ) {
-       global $wgUploadPath, $wgHashedUploadDirectory;
+       /**
+        * Select a page from a multipage document. Determines the page used for
+        * rendering thumbnails.
+        *
+        * @param $page Integer: page number, starting with 1
+        */
+       function selectPage( $page ) {
+               if( $this->initializeMultiPageXML() ) {
+                       wfDebug( __METHOD__." selecting page $page \n" );
+                       $this->page = $page;
+                       $o = $this->multiPageXML->BODY[0]->OBJECT[$page-1];
+                       $this->height = intval( $o['height'] );
+                       $this->width = intval( $o['width'] );
+               } else {
+                       wfDebug( __METHOD__." selectPage($page) for bogus multipage xml on '$this->name'\n" );
+                       return;
+               }
+       }
+
+       /**
+        * Lazy-initialize multipage XML metadata for DjVu files.
+        * @return bool true if $this->multiPageXML is set up and ready;
+        *              false if corrupt or otherwise failing
+        */
+       function initializeMultiPageXML() {
+               $this->load();
+               if ( isset( $this->multiPageXML ) ) {
+                       return true;
+               }
+
+               #
+               # Check for files uploaded prior to DJVU support activation,
+               # or damaged.
+               #
+               if( empty( $this->metadata ) || $this->metadata == serialize( array() ) ) {
+                       $deja = new DjVuImage( $this->imagePath );
+                       $this->metadata = $deja->retrieveMetaData();
+                       $this->purgeMetadataCache();
 
-       if ($wgHashedUploadDirectory) {
-               $hash = md5( substr( $name, 15) );
-               $url = $wgUploadPath.'/'.$subdir.'/' . $hash{0} . '/' .
-                 substr( $hash, 0, 2 ) . '/'.$name;
-       } else {
-               $url = $wgUploadPath.'/'.$subdir.'/'.$name;
+                       # Update metadata in the database
+                       $dbw = wfGetDB( DB_MASTER );
+                       $dbw->update( 'image',
+                               array( 'img_metadata' => $this->metadata ),
+                               array( 'img_name' => $this->name ),
+                               __METHOD__
+                       );
+               }
+               wfSuppressWarnings();
+               try {
+                       $this->multiPageXML = new SimpleXMLElement( $this->metadata );
+               } catch( Exception $e ) {
+                       wfDebug( "Bogus multipage XML metadata on '$this->name'\n" );
+                       $this->multiPageXML = null;
+               }
+               wfRestoreWarnings();
+               return isset( $this->multiPageXML );
        }
-       return wfUrlencode($url);
-}
 
-/**
- * Return a rounded pixel equivalent for a labeled CSS/SVG length.
- * http://www.w3.org/TR/SVG11/coords.html#UnitIdentifiers
- *
- * @param string $length
- * @return int Length in pixels
- */
-function wfScaleSVGUnit( $length ) {
-       static $unitLength = array(
-               'px' => 1.0,
-               'pt' => 1.25,
-               'pc' => 15.0,
-               'mm' => 3.543307,
-               'cm' => 35.43307,
-               'in' => 90.0,
-               ''   => 1.0, // "User units" pixels by default
-               '%'  => 2.0, // Fake it!
-               );
-       if( preg_match( '/^(\d+(?:\.\d+)?)(em|ex|px|pt|pc|cm|mm|in|%|)$/', $length, $matches ) ) {
-               $length = floatval( $matches[1] );
-               $unit = $matches[2];
-               return round( $length * $unitLength[$unit] );
-       } else {
-               // Assume pixels
-               return round( floatval( $length ) );
+       /**
+        * Returns 'true' if this image is a multipage document, e.g. a DJVU
+        * document.
+        *
+        * @return Bool
+        */
+       function isMultipage() {
+               return ( $this->mime == 'image/vnd.djvu' );
        }
-}
 
-/**
- * Compatible with PHP getimagesize()
- * @todo support gzipped SVGZ
- * @todo check XML more carefully
- * @todo sensible defaults
- *
- * @param string $filename
- * @return array
- */
-function wfGetSVGsize( $filename ) {
-       $width = 256;
-       $height = 256;
-
-       // Read a chunk of the file
-       $f = fopen( $filename, "rt" );
-       if( !$f ) return false;
-       $chunk = fread( $f, 4096 );
-       fclose( $f );
-
-       // Uber-crappy hack! Run through a real XML parser.
-       if( !preg_match( '/<svg\s*([^>]*)\s*>/s', $chunk, $matches ) ) {
-               return false;
+       /**
+        * Returns the number of pages of a multipage document, or NULL for
+        * documents which aren't multipage documents
+        */
+       function pageCount() {
+               if ( ! $this->isMultipage() ) {
+                       return null;
+               }
+               if( $this->initializeMultiPageXML() ) {
+                       return count( $this->multiPageXML->xpath( '//OBJECT' ) );
+               } else {
+                       wfDebug( "Requested pageCount() for bogus multi-page metadata for '$this->name'\n" );
+                       return null;
+               }
+       }
+
+       static function getCommonsDB() {
+               static $dbc;
+               global $wgLoadBalancer, $wgSharedUploadDBname;
+               if ( !isset( $dbc ) ) {
+                       $i = $wgLoadBalancer->getGroupIndex( 'commons' );
+                       $dbinfo = $wgLoadBalancer->mServers[$i];
+                       $dbc = new Database( $dbinfo['host'], $dbinfo['user'], 
+                               $dbinfo['password'], $wgSharedUploadDBname );
+               }
+               return $dbc;
        }
-       $tag = $matches[1];
-       if( preg_match( '/\bwidth\s*=\s*("[^"]+"|\'[^\']+\')/s', $tag, $matches ) ) {
-               $width = wfScaleSVGUnit( trim( substr( $matches[1], 1, -1 ) ) );
+
+       /**
+        * Calculate the height of a thumbnail using the source and destination width
+        */
+       static function scaleHeight( $srcWidth, $srcHeight, $dstWidth ) {
+               // Exact integer multiply followed by division
+               return round( $srcHeight * $dstWidth / $srcWidth );
        }
-       if( preg_match( '/\bheight\s*=\s*("[^"]+"|\'[^\']+\')/s', $tag, $matches ) ) {
-               $height = wfScaleSVGUnit( trim( substr( $matches[1], 1, -1 ) ) );
+
+       /**
+        * Get an image size array like that returned by getimagesize(), or false if it 
+        * can't be determined.
+        *
+        * @param string $fileName The filename
+        * @param string $mimeType The MIME type of the file
+        * @param object $deja Filled with a DjVu object if the mime type is image/vnd.djvu
+        * @return array
+        */
+       static function getImageSize( $fileName, $mimeType, &$deja ) {
+               $magic =& MimeMagic::singleton();
+               if( $mimeType == 'image/svg' || $mimeType == 'image/svg+xml' ) {
+                       $gis = wfGetSVGsize( $fileName );
+               } elseif( $mimeType == 'image/vnd.djvu' ) {
+                       wfSuppressWarnings();
+                       $deja = new DjVuImage( $fileName );
+                       $gis = $deja->getImageSize();
+                       wfRestoreWarnings();
+               } elseif ( !$magic->isPHPImageType( $mimeType ) ) {
+                       # Don't try to get the width and height of sound and video files, that's bad for performance
+                       $gis = false;
+               } else {
+                       wfSuppressWarnings();
+                       $gis = getimagesize( $fileName );
+                       wfRestoreWarnings();
+               }
+               return $gis;
        }
 
-       return array( $width, $height, 'SVG',
-               "width=\"$width\" height=\"$height\"" );
-}
+       /**
+        * Get the thumbnail extension and MIME type for a given source MIME type
+        * @return array thumbnail extension and MIME type
+        */
+       static function getThumbType( $ext, $mime ) {
+               switch ( $mime ) {
+                       case 'image/svg':
+                       case 'image/svg+xml':
+                               $ext = 'png';
+                               $mime = 'image/png';
+                               break;
+                       case 'image/vnd.djvu':
+                               $ext = $GLOBALS['wgDjvuOutputExtension'];
+                               $magic = MimeMagic::singleton();
+                               $mime = $magic->guessTypesForExtension( $ext );
+                               break;
+               }
+               return array( $ext, $mime );
+       }
 
-/**
- * Determine if an image exists on the 'bad image list'
- *
- * @param string $name The image to check
- * @return bool
- */
-function wfIsBadImage( $name ) {
-       global $wgContLang;
-       static $titleList = false;
-       if ( $titleList === false ) {
-               $titleList = array();
-
-               $lines = explode("\n", wfMsgForContent( 'bad_image_list' ));
-               foreach ( $lines as $line ) {
-                       if ( preg_match( '/^\*\s*\[{2}:(' . $wgContLang->getNsText( NS_IMAGE ) . ':.*?)\]{2}/', $line, $m ) ) {
-                               $t = Title::newFromText( $m[1] );
-                               $titleList[$t->getDBkey()] = 1;
+
+} //class
+
+class ArchivedFile
+{
+       /**
+        * Returns a file object from the filearchive table
+        * In the future, all current and old image storage
+        * may use FileStore. There will be a "old" storage 
+        * for current and previous file revisions as well as
+        * the "deleted" group for archived revisions
+        * @param $title, the corresponding image page title
+        * @param $id, the image id, a unique key
+        * @param $key, optional storage key
+        * @return ResultWrapper
+        */
+       function ArchivedFile( $title, $id=0, $key='' ) {
+               if( !is_object( $title ) ) {
+                       throw new MWException( 'Image constructor given bogus title.' );
+               }
+               $conds = ($id) ? "fa_id = $id" : "fa_storage_key = '$key'";
+               if( $title->getNamespace() == NS_IMAGE ) {
+                       $dbr = wfGetDB( DB_SLAVE );
+                       $res = $dbr->select( 'filearchive',
+                               array(
+                                       'fa_id',
+                                       'fa_name',
+                                       'fa_storage_key',
+                                       'fa_storage_group',
+                                       'fa_size',
+                                       'fa_bits',
+                                       'fa_width',
+                                       'fa_height',
+                                       'fa_metadata',
+                                       'fa_media_type',
+                                       'fa_major_mime',
+                                       'fa_minor_mime',
+                                       'fa_description',
+                                       'fa_user',
+                                       'fa_user_text',
+                                       'fa_timestamp',
+                                       'fa_deleted' ),
+                               array( 
+                                       'fa_name' => $title->getDbKey(),
+                                       $conds ),
+                               __METHOD__,
+                               array( 'ORDER BY' => 'fa_timestamp DESC' ) );
+                               
+                       if ( $dbr->numRows( $res ) == 0 ) {
+                       // this revision does not exist?
+                               return;
                        }
+                       $ret = $dbr->resultObject( $res );
+                       $row = $ret->fetchObject();
+       
+                       // initialize fields for filestore image object
+                       $this->mId = intval($row->fa_id);
+                       $this->mName = $row->fa_name;
+                       $this->mGroup = $row->fa_storage_group;
+                       $this->mKey = $row->fa_storage_key;
+                       $this->mSize = $row->fa_size;
+                       $this->mBits = $row->fa_bits;
+                       $this->mWidth = $row->fa_width;
+                       $this->mHeight = $row->fa_height;
+                       $this->mMetaData = $row->fa_metadata;
+                       $this->mMime = "$row->fa_major_mime/$row->fa_minor_mime";
+                       $this->mType = $row->fa_media_type;
+                       $this->mDescription = $row->fa_description;
+                       $this->mUser = $row->fa_user;
+                       $this->mUserText = $row->fa_user_text;
+                       $this->mTimestamp = $row->fa_timestamp;
+                       $this->mDeleted = $row->fa_deleted;             
+               } else {
+                       throw new MWException( 'This title does not correspond to an image page.' );
+                       return;
                }
+               return true;
        }
 
-       return array_key_exists( $name, $titleList );
+       /**
+        * int $field one of DELETED_* bitfield constants
+        * for file or revision rows
+        * @return bool
+        */
+       function isDeleted( $field ) {
+               return ($this->mDeleted & $field) == $field;
+       }
+       
+       /**
+        * Determine if the current user is allowed to view a particular
+        * field of this FileStore image file, if it's marked as deleted.
+        * @param int $field                                    
+        * @return bool
+        */
+       function userCan( $field ) {
+               if( isset($this->mDeleted) && ($this->mDeleted & $field) == $field ) {
+               // images
+                       global $wgUser;
+                       $permission = ( $this->mDeleted & Revision::DELETED_RESTRICTED ) == Revision::DELETED_RESTRICTED
+                               ? 'hiderevision'
+                               : 'deleterevision';
+                       wfDebug( "Checking for $permission due to $field match on $this->mDeleted\n" );
+                       return $wgUser->isAllowed( $permission );
+               } else {
+                       return true;
+               }
+       }
 }
 
-
-
 /**
  * Wrapper class for thumbnail images
- * @package MediaWiki
  */
 class ThumbnailImage {
        /**
         * @param string $path Filesystem path to the thumb
         * @param string $url URL path to the thumb
-        * @access private
+        * @private
         */
        function ThumbnailImage( $url, $width, $height, $path = false ) {
                $this->url = $url;
@@ -1902,7 +2555,7 @@ class ThumbnailImage {
         *
         * @param array $attribs
         * @return string
-        * @access public
+        * @public
         */
        function toHtml( $attribs = array() ) {
                $attribs['src'] = $this->url;
@@ -1919,4 +2572,13 @@ class ThumbnailImage {
        }
 
 }
+
+/**
+ * Aliases for backwards compatibility with 1.6
+ */
+define( 'MW_IMG_DELETED_FILE', Image::DELETED_FILE );
+define( 'MW_IMG_DELETED_COMMENT', Image::DELETED_COMMENT );
+define( 'MW_IMG_DELETED_USER', Image::DELETED_USER );
+define( 'MW_IMG_DELETED_RESTRICTED', Image::DELETED_RESTRICTED );
+
 ?>