Fix typo in comment
[lhc/web/wiklou.git] / includes / FileDeleteForm.php
index 2e80663..d86c8d8 100644 (file)
@@ -24,7 +24,6 @@ class FileDeleteForm {
        private $oldfile = null;
        private $oldimage = '';
 
-       private $DeleteReason, $DeleteReasonList;
        /**
         * Constructor
         *
@@ -40,7 +39,7 @@ class FileDeleteForm {
         * pending authentication, confirmation, etc.
         */
        public function execute() {
-               global $wgOut, $wgRequest, $wgUser;
+               global $wgOut, $wgRequest, $wgUser, $wgUploadMaintenance;
 
                $permissionErrors = $this->title->getUserPermissionsErrors( 'delete', $wgUser );
                if ( count( $permissionErrors ) ) {
@@ -51,6 +50,10 @@ class FileDeleteForm {
                        throw new ReadOnlyError;
                }
 
+               if ( $wgUploadMaintenance ) {
+                       throw new ErrorPageError( 'filedelete-maintenance-title', 'filedelete-maintenance' );
+               }
+
                $this->setHeaders();
 
                $this->oldimage = $wgRequest->getText( 'oldimage', false );
@@ -70,23 +73,23 @@ class FileDeleteForm {
 
                // Perform the deletion if appropriate
                if( $wgRequest->wasPosted() && $wgUser->matchEditToken( $token, $this->oldimage ) ) {
-                       $this->DeleteReasonList = $wgRequest->getText( 'wpDeleteReasonList' );
-                       $this->DeleteReason = $wgRequest->getText( 'wpReason' );
-                       $reason = $this->DeleteReasonList;
-                       if ( $reason != 'other' && $this->DeleteReason != '') {
+                       $deleteReasonList = $wgRequest->getText( 'wpDeleteReasonList' );
+                       $deleteReason = $wgRequest->getText( 'wpReason' );
+
+                       if ( $deleteReasonList == 'other' ) {
+                               $reason = $deleteReason;
+                       } elseif ( $deleteReason != '' ) {
                                // Entry from drop down menu + additional comment
-                               $reason .= wfMsgForContent( 'colon-separator' ) . $this->DeleteReason;
-                       } elseif ( $reason == 'other' ) {
-                               $reason = $this->DeleteReason;
+                               $reason = $deleteReasonList . wfMsgForContent( 'colon-separator' ) . $deleteReason;
+                       } else {
+                               $reason = $deleteReasonList;
                        }
 
-                       $status = self::doDelete( $this->title, $this->file, $this->oldimage, $reason, $suppress );
+                       $status = self::doDelete( $this->title, $this->file, $this->oldimage, $reason, $suppress, $wgUser );
 
                        if( !$status->isGood() ) {
                                $wgOut->addHTML( '<h2>' . $this->prepareMessage( 'filedeleteerror-short' ) . "</h2>\n" );
-                               $wgOut->addHTML( '<span class="error">' );
-                               $wgOut->addWikiText( $status->getWikiText( 'filedeleteerror-short', 'filedeleteerror-long' ) );
-                               $wgOut->addHTML( '</span>' );
+                               $wgOut->addWikiText( '<div class="error">' . $status->getWikiText( 'filedeleteerror-short', 'filedeleteerror-long' ) . '</div>' );
                        }
                        if( $status->ok ) {
                                $wgOut->setPageTitle( wfMessage( 'actioncomplete' ) );
@@ -94,6 +97,12 @@ class FileDeleteForm {
                                // Return to the main page if we just deleted all versions of the
                                // file, otherwise go back to the description page
                                $wgOut->addReturnTo( $this->oldimage ? $this->title : Title::newMainPage() );
+
+                               if ( $wgRequest->getCheck( 'wpWatch' ) && $wgUser->isLoggedIn() ) {
+                                       WatchAction::doWatch( $this->title, $wgUser );
+                               } elseif ( $this->title->userIsWatching() ) {
+                                       WatchAction::doUnwatch( $this->title, $wgUser );
+                               }
                        }
                        return;
                }
@@ -106,17 +115,21 @@ class FileDeleteForm {
         * Really delete the file
         *
         * @param $title Title object
-        * @param $file File object
+        * @param File $file: file object
         * @param $oldimage String: archive name
         * @param $reason String: reason of the deletion
         * @param $suppress Boolean: whether to mark all deleted versions as restricted
+        * @param $user User object performing the request
+        * @return bool|Status
         */
-       public static function doDelete( &$title, &$file, &$oldimage, $reason, $suppress ) {
-               global $wgUser;
-               $article = null;
-               $status = Status::newFatal( 'error' );
+       public static function doDelete( &$title, &$file, &$oldimage, $reason, $suppress, User $user = null ) {
+               if ( $user === null ) {
+                       global $wgUser;
+                       $user = $wgUser;
+               }
 
                if( $oldimage ) {
+                       $page = null;
                        $status = $file->deleteOld( $oldimage, $reason, $suppress );
                        if( $status->ok ) {
                                // Need to do a log item
@@ -128,33 +141,32 @@ class FileDeleteForm {
                                $log->addEntry( 'delete', $title, $logComment );
                        }
                } else {
-                       $id = $title->getArticleID( Title::GAID_FOR_UPDATE );
-                       $article = new Article( $title );
+                       $status = Status::newFatal( 'cannotdelete',
+                               wfEscapeWikiText( $title->getPrefixedText() )
+                       );
+                       $page = WikiPage::factory( $title );
                        $dbw = wfGetDB( DB_MASTER );
                        try {
                                // delete the associated article first
-                               if( $article->doDeleteArticle( $reason, $suppress, $id, false ) ) {
-                                       global $wgRequest;
-                                       if ( $wgRequest->getCheck( 'wpWatch' ) && $wgUser->isLoggedIn() ) {
-                                               WatchAction::doWatch( $title, $wgUser );
-                                       } elseif ( $title->userIsWatching() ) {
-                                               WatchAction::doUnwatch( $title, $wgUser );
-                                       }
+                               $error = '';
+                               if ( $page->doDeleteArticleReal( $reason, $suppress, 0, false, $error, $user ) >= WikiPage::DELETE_SUCCESS ) {
                                        $status = $file->delete( $reason, $suppress );
-                                       if( $status->ok ) {
-                                               $dbw->commit();
+                                       if( $status->isOK() ) {
+                                               $dbw->commit( __METHOD__ );
                                        } else {
-                                               $dbw->rollback();
+                                               $dbw->rollback( __METHOD__ );
                                        }
                                }
                        } catch ( MWException $e ) {
                                // rollback before returning to prevent UI from displaying incorrect "View or restore N deleted edits?"
-                               $dbw->rollback();
+                               $dbw->rollback( __METHOD__ );
                                throw $e;
                        }
                }
-               if( $status->isGood() )
-                       wfRunHooks('FileDeleteComplete', array( &$file, &$oldimage, &$article, &$wgUser, &$reason));
+
+               if ( $status->isOK() ) {
+                       wfRunHooks( 'FileDeleteComplete', array( &$file, &$oldimage, &$page, &$user, &$reason ) );
+               }
 
                return $status;
        }
@@ -182,7 +194,7 @@ class FileDeleteForm {
                        'id' => 'mw-img-deleteconfirm' ) ) .
                        Xml::openElement( 'fieldset' ) .
                        Xml::element( 'legend', null, wfMsg( 'filedelete-legend' ) ) .
-                       Html::hidden( 'wpEditToken', $wgUser->editToken( $this->oldimage ) ) .
+                       Html::hidden( 'wpEditToken', $wgUser->getEditToken( $this->oldimage ) ) .
                        $this->prepareMessage( 'filedelete-intro' ) .
                        Xml::openElement( 'table', array( 'id' => 'mw-img-deleteconfirm-table' ) ) .
                        "<tr>
@@ -284,10 +296,7 @@ class FileDeleteForm {
                global $wgOut;
                $wgOut->setPageTitle( wfMessage( 'filedelete', $this->title->getText() ) );
                $wgOut->setRobotPolicy( 'noindex,nofollow' );
-               $wgOut->setSubtitle( wfMsg(
-                       'filedelete-backlink',
-                       Linker::linkKnown( $this->title )
-               ) );
+               $wgOut->addBacklinkSubtitle( $this->title );
        }
 
        /**