Fix fixme on r107328, attempting to use $this in a static method
[lhc/web/wiklou.git] / includes / FeedUtils.php
index 9a2a724..8df4745 100644 (file)
@@ -1,8 +1,20 @@
 <?php
 
-// TODO: document
+/**
+ * Helper functions for feeds
+ *
+ * @ingroup Feed
+ */
 class FeedUtils {
 
+       /**
+        * Check whether feed's cache should be cleared; for changes feeds
+        * If the feed should be purged; $timekey and $key will be removed from
+        * $messageMemc
+        *
+        * @param $timekey String: cache key of the timestamp of the last item
+        * @param $key String: cache key of feed's content
+        */
        public static function checkPurge( $timekey, $key ) {
                global $wgRequest, $wgUser, $messageMemc;
                $purge = $wgRequest->getVal( 'action' ) === 'purge';
@@ -12,17 +24,22 @@ class FeedUtils {
                }
        }
 
+       /**
+        * Check whether feeds can be used and that $type is a valid feed type
+        *
+        * @param $type String: feed type, as requested by the user
+        * @return Boolean
+        */
        public static function checkFeedOutput( $type ) {
-               global $wgFeed, $wgFeedClasses;
+               global $wgOut, $wgFeed, $wgFeedClasses;
 
                if ( !$wgFeed ) {
-                       global $wgOut;
                        $wgOut->addWikiMsg( 'feed-unavailable' );
                        return false;
                }
 
                if( !isset( $wgFeedClasses[$type] ) ) {
-                       wfHttpError( 500, "Internal Server Error", "Unsupported feed type." );
+                       $wgOut->addWikiMsg( 'feed-invalid' );
                        return false;
                }
 
@@ -30,11 +47,12 @@ class FeedUtils {
        }
 
        /**
-       * Format a diff for the newsfeed
-       */
+        * Format a diff for the newsfeed
+        *
+        * @param $row Object: row from the recentchanges table
+        * @return String
+        */
        public static function formatDiff( $row ) {
-               global $wgUser;
-
                $titleObj = Title::makeTitle( $row->rc_namespace, $row->rc_title );
                $timestamp = wfTimestamp( TS_MW, $row->rc_timestamp );
                $actiontext = '';
@@ -43,7 +61,7 @@ class FeedUtils {
                                $actiontext = wfMsgHtml('rev-deleted-event');
                        } else {
                                $actiontext = LogPage::actionText( $row->rc_log_type, $row->rc_log_action,
-                                       $titleObj, $wgUser->getSkin(), LogPage::extractParams($row->rc_params,true,true) );
+                                       $titleObj, RequestContext::getMain()->getSkin(), LogPage::extractParams($row->rc_params,true,true) );
                        }
                }
                return self::formatDiffRow( $titleObj,
@@ -53,86 +71,122 @@ class FeedUtils {
                        $actiontext );
        }
 
+       /**
+        * Really format a diff for the newsfeed
+        *
+        * @param $title Title object
+        * @param $oldid Integer: old revision's id
+        * @param $newid Integer: new revision's id
+        * @param $timestamp Integer: new revision's timestamp
+        * @param $comment String: new revision's comment
+        * @param $actiontext String: text of the action; in case of log event
+        * @return String
+        */
        public static function formatDiffRow( $title, $oldid, $newid, $timestamp, $comment, $actiontext='' ) {
-               global $wgFeedDiffCutoff, $wgContLang, $wgUser;
-               wfProfileIn( __FUNCTION__ );
+               global $wgFeedDiffCutoff, $wgLang;
+               wfProfileIn( __METHOD__ );
 
-               $skin = $wgUser->getSkin();
                # log enties
                $completeText = '<p>' . implode( ' ',
                        array_filter(
                                array(
                                        $actiontext,
-                                       $skin->formatComment( $comment ) ) ) ) . "</p>\n";
+                                       Linker::formatComment( $comment ) ) ) ) . "</p>\n";
 
-               //NOTE: Check permissions for anonymous users, not current user.
-               //      No "privileged" version should end up in the cache.
-               //      Most feed readers will not log in anway.
+               // NOTE: Check permissions for anonymous users, not current user.
+               //       No "privileged" version should end up in the cache.
+               //       Most feed readers will not log in anway.
                $anon = new User();
                $accErrors = $title->getUserPermissionsErrors( 'read', $anon, true );
 
-               if( $title->getNamespace() >= 0 && !$accErrors ) {
-                       if( $oldid ) {
-                               wfProfileIn( __FUNCTION__."-dodiff" );
-
-                               #$diffText = $de->getDiff( wfMsg( 'revisionasof',
-                               #       $wgContLang->timeanddate( $timestamp ) ),
-                               #       wfMsg( 'currentrev' ) );
-                               
-                               // Don't bother generating the diff if we won't be able to show it
-                               if ( $wgFeedDiffCutoff > 0 ) {
-                                       $de = new DifferenceEngine( $title, $oldid, $newid );
-                                       $diffText = $de->getDiff(
-                                               wfMsg( 'previousrevision' ), // hack
-                                               wfMsg( 'revisionasof',
-                                                       $wgContLang->timeanddate( $timestamp ) ) );
-                               }
-
-                               if ( ( strlen( $diffText ) > $wgFeedDiffCutoff ) || ( $wgFeedDiffCutoff <= 0 ) ) {
-                                       // Omit large diffs
-                                       $diffLink = $title->escapeFullUrl(
-                                               'diff=' . $newid .
-                                               '&oldid=' . $oldid );
-                                       $diffText = '<a href="' .
-                                               $diffLink .
-                                               '">' .
-                                               htmlspecialchars( wfMsgForContent( 'showdiff' ) ) .
-                                               '</a>';
-                               } elseif ( $diffText === false ) {
-                                       // Error in diff engine, probably a missing revision
-                                       $diffText = "<p>Can't load revision $newid</p>";
-                               } else {
-                                       // Diff output fine, clean up any illegal UTF-8
-                                       $diffText = UtfNormal::cleanUp( $diffText );
-                                       $diffText = self::applyDiffStyle( $diffText );
-                               }
-                               wfProfileOut( __FUNCTION__."-dodiff" );
+               // Can't diff special pages, unreadable pages or pages with no new revision
+               // to compare against: just return the text.
+               if( $title->getNamespace() < 0 || $accErrors || !$newid ) {
+                       wfProfileOut( __METHOD__ );
+                       return $completeText;
+               }
+
+               if( $oldid ) {
+                       wfProfileIn( __METHOD__."-dodiff" );
+
+                       #$diffText = $de->getDiff( wfMsg( 'revisionasof',
+                       #       $wgLang->timeanddate( $timestamp ),
+                       #       $wgLang->date( $timestamp ),
+                       #       $wgLang->time( $timestamp ) ),
+                       #       wfMsg( 'currentrev' ) );
+
+                       // Don't bother generating the diff if we won't be able to show it
+                       if ( $wgFeedDiffCutoff > 0 ) {
+                               $de = new DifferenceEngine( $title, $oldid, $newid );
+                               $diffText = $de->getDiff(
+                                       wfMsg( 'previousrevision' ), // hack
+                                       wfMsg( 'revisionasof',
+                                       $wgLang->timeanddate( $timestamp ),
+                                       $wgLang->date( $timestamp ),
+                                       $wgLang->time( $timestamp ) ) );
+                       }
+
+                       if ( $wgFeedDiffCutoff <= 0 || ( strlen( $diffText ) > $wgFeedDiffCutoff ) ) {
+                               // Omit large diffs
+                               $diffText = self::getDiffLink( $title, $newid, $oldid );
+                       } elseif ( $diffText === false ) {
+                               // Error in diff engine, probably a missing revision
+                               $diffText = "<p>Can't load revision $newid</p>";
+                       } else {
+                               // Diff output fine, clean up any illegal UTF-8
+                               $diffText = UtfNormal::cleanUp( $diffText );
+                               $diffText = self::applyDiffStyle( $diffText );
+                       }
+                       wfProfileOut( __METHOD__."-dodiff" );
+               } else {
+                       $rev = Revision::newFromId( $newid );
+                       if( $wgFeedDiffCutoff <= 0 || is_null( $rev ) ) {
+                               $newtext = '';
+                       } else {
+                               $newtext = $rev->getText();
+                       }
+                       if ( $wgFeedDiffCutoff <= 0 || strlen( $newtext ) > $wgFeedDiffCutoff ) {
+                               // Omit large new page diffs, bug 29110
+                               $diffText = self::getDiffLink( $title, $newid );
                        } else {
-                               $rev = Revision::newFromId( $newid );
-                               if( is_null( $rev ) ) {
-                                       $newtext = '';
-                               } else {
-                                       $newtext = $rev->getText();
-                               }
                                $diffText = '<p><b>' . wfMsg( 'newpage' ) . '</b></p>' .
                                        '<div>' . nl2br( htmlspecialchars( $newtext ) ) . '</div>';
                        }
-                       $completeText .= $diffText;
                }
+               $completeText .= $diffText;
 
-               wfProfileOut( __FUNCTION__ );
+               wfProfileOut( __METHOD__ );
                return $completeText;
        }
 
        /**
-       * Hacky application of diff styles for the feeds.
-       * Might be 'cleaner' to use DOM or XSLT or something,
-       * but *gack* it's a pain in the ass.
-       *
-       * @param $text String:
-       * @return string
-       * @private
-       */
+        * Generates a diff link. Used when the full diff is not wanted for example
+        * when $wgFeedDiffCutoff is 0.
+        *
+        * @param $title Title object: used to generate the diff URL
+        * @param $newid Integer newid for this diff
+        * @param $oldid Integer|null oldid for the diff. Null means it is a new article
+        */
+       protected static function getDiffLink( Title $title, $newid, $oldid = null ) {
+               $queryParameters = ($oldid == null)
+                       ? "diff={$newid}"
+                       : "diff={$newid}&oldid={$oldid}" ;
+               $diffUrl = $title->getFullUrl( $queryParameters );
+
+               $diffLink = Html::element( 'a', array( 'href' => $diffUrl ),
+                       wfMsgForContent( 'showdiff' ) );
+
+               return $diffLink;
+       }
+
+       /**
+        * Hacky application of diff styles for the feeds.
+        * Might be 'cleaner' to use DOM or XSLT or something,
+        * but *gack* it's a pain in the ass.
+        *
+        * @param $text String: diff's HTML output
+        * @return String: modified HTML
+        */
        public static function applyDiffStyle( $text ) {
                $styles = array(
                        'diff'             => 'background-color: white; color:black;',
@@ -152,4 +206,4 @@ class FeedUtils {
                return $text;
        }
 
-}
\ No newline at end of file
+}