Update to r32375 / bug 11874 -- !important may have whitespace between ! and important
[lhc/web/wiklou.git] / includes / Export.php
index c57831f..5605b66 100644 (file)
@@ -1,58 +1,59 @@
 <?php
-# Copyright (C) 2003, 2005 Brion Vibber <brion@pobox.com>
+# Copyright (C) 2003, 2005, 2006 Brion Vibber <brion@pobox.com>
 # http://www.mediawiki.org/
-# 
+#
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or 
+# the Free Software Foundation; either version 2 of the License, or
 # (at your option) any later version.
-# 
+#
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 # GNU General Public License for more details.
-# 
+#
 # You should have received a copy of the GNU General Public License along
 # with this program; if not, write to the Free Software Foundation, Inc.,
-# 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 # http://www.gnu.org/copyleft/gpl.html
+
+
 /**
  *
- * @package MediaWiki
- * @subpackage SpecialPage
+ * @addtogroup SpecialPage
  */
+class WikiExporter {
+       var $list_authors = false ; # Return distinct author list (when not returning full history)
+       var $author_list = "" ;
+       
+       var $dumpUploads = false;
 
-/** */
-require_once( 'Revision.php' );
-
-define( 'MW_EXPORT_FULL',     0 );
-define( 'MW_EXPORT_CURRENT',  1 );
-
-define( 'MW_EXPORT_BUFFER',   0 );
-define( 'MW_EXPORT_STREAM',   1 );
+       const FULL = 0;
+       const CURRENT = 1;
 
-define( 'MW_EXPORT_TEXT',     0 );
-define( 'MW_EXPORT_STUB',     1 );
+       const BUFFER = 0;
+       const STREAM = 1;
 
+       const TEXT = 0;
+       const STUB = 1;
 
-/**
- * @package MediaWiki
- * @subpackage SpecialPage
- */
-class WikiExporter {
        /**
-        * If using MW_EXPORT_STREAM to stream a large amount of data,
+        * If using WikiExporter::STREAM to stream a large amount of data,
         * provide a database connection which is not managed by
         * LoadBalancer to read from: some history blob types will
         * make additional queries to pull source data while the
         * main query is still running.
         *
         * @param Database $db
-        * @param int $history one of MW_EXPORT_FULL or MW_EXPORT_CURRENT
-        * @param int $buffer one of MW_EXPORT_BUFFER or MW_EXPORT_STREAM
+        * @param mixed $history one of WikiExporter::FULL or WikiExporter::CURRENT, or an
+        *                       associative array:
+        *                         offset: non-inclusive offset at which to start the query
+        *                         limit: maximum number of rows to return
+        *                         dir: "asc" or "desc" timestamp order
+        * @param int $buffer one of WikiExporter::BUFFER or WikiExporter::STREAM
         */
-       function WikiExporter( &$db, $history = MW_EXPORT_CURRENT,
-                       $buffer = MW_EXPORT_BUFFER, $text = MW_EXPORT_TEXT ) {
+       function __construct( &$db, $history = WikiExporter::CURRENT,
+                       $buffer = WikiExporter::BUFFER, $text = WikiExporter::TEXT ) {
                $this->db =& $db;
                $this->history = $history;
                $this->buffer  = $buffer;
@@ -60,7 +61,7 @@ class WikiExporter {
                $this->sink    = new DumpOutput();
                $this->text    = $text;
        }
-       
+
        /**
         * Set the DumpOutput or DumpFilter object which will receive
         * various row objects and XML output for filtering. Filters
@@ -71,7 +72,7 @@ class WikiExporter {
        function setOutputSink( &$sink ) {
                $this->sink =& $sink;
        }
-       
+
        function openStream() {
                $output = $this->writer->openStream();
                $this->sink->writeOpenStream( $output );
@@ -90,7 +91,7 @@ class WikiExporter {
        function allPages() {
                return $this->dumpFrom( '' );
        }
-       
+
        /**
         * Dumps a series of page and revision records for those pages
         * in the database falling within the page_id range given.
@@ -105,16 +106,16 @@ class WikiExporter {
                }
                return $this->dumpFrom( $condition );
        }
-       
+
        /**
         * @param Title $title
         */
        function pageByTitle( $title ) {
                return $this->dumpFrom(
                        'page_namespace=' . $title->getNamespace() .
-                       ' AND page_title=' . $this->db->addQuotes( $title->getDbKey() ) );
+                       ' AND page_title=' . $this->db->addQuotes( $title->getDBkey() ) );
        }
-       
+
        function pageByName( $name ) {
                $title = Title::newFromText( $name );
                if( is_null( $title ) ) {
@@ -123,70 +124,127 @@ class WikiExporter {
                        return $this->pageByTitle( $title );
                }
        }
-       
+
        function pagesByName( $names ) {
                foreach( $names as $name ) {
                        $this->pageByName( $name );
                }
        }
 
-       
+
        // -------------------- private implementation below --------------------
-       
+
+       # Generates the distinct list of authors of an article
+       # Not called by default (depends on $this->list_authors)
+       # Can be set by Special:Export when not exporting whole history
+       function do_list_authors ( $page , $revision , $cond ) {
+               $fname = "do_list_authors" ;
+               wfProfileIn( $fname );
+               $this->author_list = "<contributors>";
+               //rev_deleted
+               $nothidden = '(rev_deleted & '.Revision::DELETED_USER.') = 0';
+               
+               $sql = "SELECT DISTINCT rev_user_text,rev_user FROM {$page},{$revision} WHERE page_id=rev_page AND $nothidden AND " . $cond ;
+               $result = $this->db->query( $sql, $fname );
+               $resultset = $this->db->resultObject( $result );
+               while( $row = $resultset->fetchObject() ) {
+                       $this->author_list .= "<contributor>" . 
+                               "<username>" . 
+                               htmlentities( $row->rev_user_text )  . 
+                               "</username>" . 
+                               "<id>" . 
+                               $row->rev_user .
+                               "</id>" . 
+                               "</contributor>";
+               }
+               wfProfileOut( $fname );
+               $this->author_list .= "</contributors>";
+       }
+
        function dumpFrom( $cond = '' ) {
                $fname = 'WikiExporter::dumpFrom';
                wfProfileIn( $fname );
-               
+
                $page     = $this->db->tableName( 'page' );
                $revision = $this->db->tableName( 'revision' );
                $text     = $this->db->tableName( 'text' );
-               
-               if( $this->history == MW_EXPORT_FULL ) {
+
+               $order = 'ORDER BY page_id';
+               $limit = '';
+
+               if( $this->history == WikiExporter::FULL ) {
                        $join = 'page_id=rev_page';
-               } elseif( $this->history == MW_EXPORT_CURRENT ) {
+               } elseif( $this->history == WikiExporter::CURRENT ) {
+                       if ( $this->list_authors && $cond != '' )  { // List authors, if so desired
+                               $this->do_list_authors ( $page , $revision , $cond );
+                       }
                        $join = 'page_id=rev_page AND page_latest=rev_id';
+               } elseif ( is_array( $this->history ) ) {
+                       $join = 'page_id=rev_page';
+                       if ( $this->history['dir'] == 'asc' ) {
+                               $op = '>';
+                               $order .= ', rev_timestamp';
+                       } else {
+                               $op = '<';
+                               $order .= ', rev_timestamp DESC';
+                       }
+                       if ( !empty( $this->history['offset'] ) ) {
+                               $join .= " AND rev_timestamp $op " . $this->db->addQuotes(
+                                       $this->db->timestamp( $this->history['offset'] ) );
+                       }
+                       if ( !empty( $this->history['limit'] ) ) {
+                               $limitNum = intval( $this->history['limit'] );
+                               if ( $limitNum > 0 ) {
+                                       $limit = "LIMIT $limitNum";
+                               }
+                       }
                } else {
                        wfProfileOut( $fname );
                        return new WikiError( "$fname given invalid history dump type." );
                }
                $where = ( $cond == '' ) ? '' : "$cond AND";
-               
-               if( $this->buffer == MW_EXPORT_STREAM ) {
+
+               if( $this->buffer == WikiExporter::STREAM ) {
                        $prev = $this->db->bufferResults( false );
                }
                if( $cond == '' ) {
                        // Optimization hack for full-database dump
-                       $pageindex = 'FORCE INDEX (PRIMARY)';
-                       $revindex = 'FORCE INDEX(page_timestamp)';
+                       $revindex = $pageindex = $this->db->useIndexClause("PRIMARY");
+                       $straight = ' /*! STRAIGHT_JOIN */ ';
                } else {
                        $pageindex = '';
                        $revindex = '';
+                       $straight = '';
                }
-               if( $this->text == MW_EXPORT_STUB ) {
-                       $sql = "SELECT * FROM
+               if( $this->text == WikiExporter::STUB ) {
+                       $sql = "SELECT $straight * FROM
                                        $page $pageindex,
                                        $revision $revindex
                                        WHERE $where $join
-                                       ORDER BY page_id";
+                                       $order $limit";
                } else {
-                       $sql = "SELECT * FROM
+                       $sql = "SELECT $straight * FROM
                                        $page $pageindex,
                                        $revision $revindex,
                                        $text
                                        WHERE $where $join AND rev_text_id=old_id
-                                       ORDER BY page_id";
+                                       $order $limit";
                }
                $result = $this->db->query( $sql, $fname );
                $wrapper = $this->db->resultObject( $result );
                $this->outputStream( $wrapper );
-               
-               if( $this->buffer == MW_EXPORT_STREAM ) {
+
+               if ( $this->list_authors ) {
+                       $this->outputStream( $wrapper );
+               }
+
+               if( $this->buffer == WikiExporter::STREAM ) {
                        $this->db->bufferResults( $prev );
                }
-               
+
                wfProfileOut( $fname );
        }
-       
+
        /**
         * Runs through a query result set dumping page and revision records.
         * The result set should be sorted/grouped by page to avoid duplicate
@@ -207,7 +265,11 @@ class WikiExporter {
                                $last->page_namespace != $row->page_namespace ||
                                $last->page_title     != $row->page_title ) {
                                if( isset( $last ) ) {
-                                       $output = $this->writer->closePage();
+                                       $output = '';
+                                       if( $this->dumpUploads ) {
+                                               $output .= $this->writer->writeUploads( $last );
+                                       }
+                                       $output .= $this->writer->closePage();
                                        $this->sink->writeClosePage( $output );
                                }
                                $output = $this->writer->openPage( $row );
@@ -218,23 +280,31 @@ class WikiExporter {
                        $this->sink->writeRevision( $row, $output );
                }
                if( isset( $last ) ) {
-                       $output = $this->writer->closePage();
+                       $output = '';
+                       if( $this->dumpUploads ) {
+                               $output .= $this->writer->writeUploads( $last );
+                       }
+                       $output .= $this->author_list;
+                       $output .= $this->writer->closePage();
                        $this->sink->writeClosePage( $output );
                }
                $resultset->free();
        }
 }
 
+/**
+ * @addtogroup Dump
+ */
 class XmlDumpWriter {
-       
+
        /**
         * Returns the export schema version.
         * @return string
         */
        function schemaVersion() {
-               return "0.3";
+               return "0.3"; // FIXME: upgrade to 0.4 when updated XSD is ready, for the revision deletion bits
        }
-       
+
        /**
         * Opens the XML output stream's root <mediawiki> element.
         * This does not include an xml directive, so is safe to include
@@ -259,7 +329,7 @@ class XmlDumpWriter {
                        "\n" .
                        $this->siteInfo();
        }
-       
+
        function siteInfo() {
                $info = array(
                        $this->sitename(),
@@ -271,29 +341,28 @@ class XmlDumpWriter {
                        implode( "\n    ", $info ) .
                        "\n  </siteinfo>\n";
        }
-       
+
        function sitename() {
                global $wgSitename;
                return wfElement( 'sitename', array(), $wgSitename );
        }
-       
+
        function generator() {
                global $wgVersion;
                return wfElement( 'generator', array(), "MediaWiki $wgVersion" );
        }
-       
+
        function homelink() {
-               $page = Title::newFromText( wfMsgForContent( 'mainpage' ) );
-               return wfElement( 'base', array(), $page->getFullUrl() );
+               return wfElement( 'base', array(), Title::newMainPage()->getFullUrl() );
        }
-       
+
        function caseSetting() {
                global $wgCapitalLinks;
                // "case-insensitive" option is reserved for future
                $sensitivity = $wgCapitalLinks ? 'first-letter' : 'case-sensitive';
                return wfElement( 'case', array(), $sensitivity );
        }
-       
+
        function namespaces() {
                global $wgContLang;
                $spaces = "  <namespaces>\n";
@@ -303,7 +372,7 @@ class XmlDumpWriter {
                $spaces .= "    </namespaces>";
                return $spaces;
        }
-       
+
        /**
         * Closes the output stream with the closing root element.
         * Call when finished dumping things.
@@ -312,7 +381,7 @@ class XmlDumpWriter {
                return "</mediawiki>\n";
        }
 
-       
+
        /**
         * Opens a <page> section on the output stream, with data
         * from the given database row.
@@ -332,7 +401,7 @@ class XmlDumpWriter {
                }
                return $out;
        }
-       
+
        /**
         * Closes a <page> section on the output stream.
         *
@@ -341,7 +410,7 @@ class XmlDumpWriter {
        function closePage() {
                return "  </page>\n";
        }
-       
+
        /**
         * Dumps a <revision> section on the output stream, with
         * data filled in from the given database row.
@@ -353,30 +422,30 @@ class XmlDumpWriter {
        function writeRevision( $row ) {
                $fname = 'WikiExporter::dumpRev';
                wfProfileIn( $fname );
-               
+
                $out  = "    <revision>\n";
                $out .= "      " . wfElement( 'id', null, strval( $row->rev_id ) ) . "\n";
-               
-               $ts = wfTimestamp2ISO8601( strval( $row->rev_timestamp ) );
-               $out .= "      " . wfElement( 'timestamp', null, $ts ) . "\n";
-               
-               $out .= "      <contributor>\n";
-               if( $row->rev_user ) {
-                       $out .= "        " . wfElementClean( 'username', null, strval( $row->rev_user_text ) ) . "\n";
-                       $out .= "        " . wfElement( 'id', null, strval( $row->rev_user ) ) . "\n";
+
+               $out .= $this->writeTimestamp( $row->rev_timestamp );
+
+               if( $row->rev_deleted & Revision::DELETED_USER ) {
+                       $out .= "      " . wfElement( 'contributor', array( 'deleted' => 'deleted' ) ) . "\n";
                } else {
-                       $out .= "        " . wfElementClean( 'ip', null, strval( $row->rev_user_text ) ) . "\n";
+                       $out .= $this->writeContributor( $row->rev_user, $row->rev_user_text );
                }
-               $out .= "      </contributor>\n";
-               
+
                if( $row->rev_minor_edit ) {
                        $out .=  "      <minor/>\n";
                }
-               if( $row->rev_comment != '' ) {
+               if( $row->rev_deleted & Revision::DELETED_COMMENT ) {
+                       $out .= "      " . wfElement( 'comment', array( 'deleted' => 'deleted' ) ) . "\n";
+               } elseif( $row->rev_comment != '' ) {
                        $out .= "      " . wfElementClean( 'comment', null, strval( $row->rev_comment ) ) . "\n";
                }
-               
-               if( isset( $row->old_text ) ) {
+
+               if( $row->rev_deleted & Revision::DELETED_TEXT ) {
+                       $out .= "      " . wfElement( 'text', array( 'deleted' => 'deleted' ) ) . "\n";
+               } elseif( isset( $row->old_text ) ) {
                        // Raw text from the database may have invalid chars
                        $text = strval( Revision::getRevisionText( $row ) );
                        $out .= "      " . wfElementClean( 'text',
@@ -388,40 +457,87 @@ class XmlDumpWriter {
                                array( 'id' => $row->rev_text_id ),
                                "" ) . "\n";
                }
-               
+
                $out .= "    </revision>\n";
-               
+
                wfProfileOut( $fname );
                return $out;
        }
+       
+       function writeTimestamp( $timestamp ) {
+               $ts = wfTimestamp( TS_ISO_8601, $timestamp );
+               return "      " . wfElement( 'timestamp', null, $ts ) . "\n";
+       }
+       
+       function writeContributor( $id, $text ) {
+               $out = "      <contributor>\n";
+               if( $id ) {
+                       $out .= "        " . wfElementClean( 'username', null, strval( $text ) ) . "\n";
+                       $out .= "        " . wfElement( 'id', null, strval( $id ) ) . "\n";
+               } else {
+                       $out .= "        " . wfElementClean( 'ip', null, strval( $text ) ) . "\n";
+               }
+               $out .= "      </contributor>\n";
+               return $out;
+       }
+       
+       /**
+        * Warning! This data is potentially inconsistent. :(
+        */
+       function writeUploads( $row ) {
+               if( $row->page_namespace == NS_IMAGE ) {
+                       $img = wfFindFile( $row->page_title );
+                       if( $img ) {
+                               $out = '';
+                               foreach( array_reverse( $img->getHistory() ) as $ver ) {
+                                       $out .= $this->writeUpload( $ver );
+                               }
+                               $out .= $this->writeUpload( $img );
+                               return $out;
+                       }
+               }
+               return '';
+       }
+       
+       function writeUpload( $file ) {
+               return "    <upload>\n" .
+                       $this->writeTimestamp( $file->getTimestamp() ) .
+                       $this->writeContributor( $file->getUser( 'id' ), $file->getUser( 'text' ) ) .
+                       "      " . wfElementClean( 'comment', null, $file->getDescription() ) . "\n" .
+                       "      " . wfElement( 'filename', null, $file->getName() ) . "\n" .
+                       "      " . wfElement( 'src', null, $file->getFullUrl() ) . "\n" .
+                       "      " . wfElement( 'size', null, $file->getSize() ) . "\n" .
+                       "    </upload>\n";
+       }
 
 }
 
 
 /**
  * Base class for output stream; prints to stdout or buffer or whereever.
+ * @addtogroup Dump
  */
 class DumpOutput {
        function writeOpenStream( $string ) {
                $this->write( $string );
        }
-       
+
        function writeCloseStream( $string ) {
                $this->write( $string );
        }
-       
+
        function writeOpenPage( $page, $string ) {
                $this->write( $string );
        }
-       
+
        function writeClosePage( $string ) {
                $this->write( $string );
        }
-       
+
        function writeRevision( $rev, $string ) {
                $this->write( $string );
        }
-       
+
        /**
         * Override to write to a different stream type.
         * @return bool
@@ -433,14 +549,15 @@ class DumpOutput {
 
 /**
  * Stream outputter to send data to a file.
+ * @addtogroup Dump
  */
 class DumpFileOutput extends DumpOutput {
        var $handle;
-       
+
        function DumpFileOutput( $file ) {
                $this->handle = fopen( $file, "wt" );
        }
-       
+
        function write( $string ) {
                fputs( $this->handle, $string );
        }
@@ -450,6 +567,7 @@ class DumpFileOutput extends DumpOutput {
  * Stream outputter to send data to a file via some filter program.
  * Even if compression is available in a library, using a separate
  * program can allow us to make use of a multi-processor system.
+ * @addtogroup Dump
  */
 class DumpPipeOutput extends DumpFileOutput {
        function DumpPipeOutput( $command, $file = null ) {
@@ -462,6 +580,7 @@ class DumpPipeOutput extends DumpFileOutput {
 
 /**
  * Sends dump output via the gzip compressor.
+ * @addtogroup Dump
  */
 class DumpGZipOutput extends DumpPipeOutput {
        function DumpGZipOutput( $file ) {
@@ -471,6 +590,7 @@ class DumpGZipOutput extends DumpPipeOutput {
 
 /**
  * Sends dump output via the bgzip2 compressor.
+ * @addtogroup Dump
  */
 class DumpBZip2Output extends DumpPipeOutput {
        function DumpBZip2Output( $file ) {
@@ -480,10 +600,14 @@ class DumpBZip2Output extends DumpPipeOutput {
 
 /**
  * Sends dump output via the p7zip compressor.
+ * @addtogroup Dump
  */
 class Dump7ZipOutput extends DumpPipeOutput {
        function Dump7ZipOutput( $file ) {
-               $command = "7za a -si " . wfEscapeShellArg( $file );
+               $command = "7za a -bd -si " . wfEscapeShellArg( $file );
+               // Suppress annoying useless crap from p7zip
+               // Unfortunately this could suppress real error messages too
+               $command .= ' >' . wfGetNull() . ' 2>&1';
                parent::DumpPipeOutput( $command );
        }
 }
@@ -494,68 +618,71 @@ class Dump7ZipOutput extends DumpPipeOutput {
  * Dump output filter class.
  * This just does output filtering and streaming; XML formatting is done
  * higher up, so be careful in what you do.
+ * @addtogroup Dump
  */
 class DumpFilter {
        function DumpFilter( &$sink ) {
                $this->sink =& $sink;
        }
-       
+
        function writeOpenStream( $string ) {
                $this->sink->writeOpenStream( $string );
        }
-       
+
        function writeCloseStream( $string ) {
                $this->sink->writeCloseStream( $string );
        }
-       
+
        function writeOpenPage( $page, $string ) {
                $this->sendingThisPage = $this->pass( $page, $string );
                if( $this->sendingThisPage ) {
                        $this->sink->writeOpenPage( $page, $string );
                }
        }
-       
+
        function writeClosePage( $string ) {
                if( $this->sendingThisPage ) {
                        $this->sink->writeClosePage( $string );
                        $this->sendingThisPage = false;
                }
        }
-       
+
        function writeRevision( $rev, $string ) {
                if( $this->sendingThisPage ) {
                        $this->sink->writeRevision( $rev, $string );
                }
        }
-       
+
        /**
         * Override for page-based filter types.
         * @return bool
         */
-       function pass( $page, $string ) {
+       function pass( $page ) {
                return true;
        }
 }
 
 /**
  * Simple dump output filter to exclude all talk pages.
+ * @addtogroup Dump
  */
 class DumpNotalkFilter extends DumpFilter {
        function pass( $page ) {
-               return !Namespace::isTalk( $page->page_namespace );
+               return !MWNamespace::isTalk( $page->page_namespace );
        }
 }
 
 /**
  * Dump output filter to include or exclude pages in a given set of namespaces.
+ * @addtogroup Dump
  */
 class DumpNamespaceFilter extends DumpFilter {
        var $invert = false;
        var $namespaces = array();
-       
+
        function DumpNamespaceFilter( &$sink, $param ) {
                parent::DumpFilter( $sink );
-               
+
                $constants = array(
                        "NS_MAIN"           => NS_MAIN,
                        "NS_TALK"           => NS_TALK,
@@ -573,12 +700,12 @@ class DumpNamespaceFilter extends DumpFilter {
                        "NS_HELP_TALK"      => NS_HELP_TALK,
                        "NS_CATEGORY"       => NS_CATEGORY,
                        "NS_CATEGORY_TALK"  => NS_CATEGORY_TALK );
-               
+
                if( $param{0} == '!' ) {
                        $this->invert = true;
                        $param = substr( $param, 1 );
                }
-               
+
                foreach( explode( ',', $param ) as $key ) {
                        $key = trim( $key );
                        if( isset( $constants[$key] ) ) {
@@ -588,11 +715,11 @@ class DumpNamespaceFilter extends DumpFilter {
                                $ns = intval( $key );
                                $this->namespaces[$ns] = true;
                        } else {
-                               die( "Unrecognized namespace key '$key'\n" );
+                               throw new MWException( "Unrecognized namespace key '$key'\n" );
                        }
                }
        }
-       
+
        function pass( $page ) {
                $match = isset( $this->namespaces[$page->page_namespace] );
                return $this->invert xor $match;
@@ -602,15 +729,16 @@ class DumpNamespaceFilter extends DumpFilter {
 
 /**
  * Dump output filter to include only the last revision in each page sequence.
+ * @addtogroup Dump
  */
 class DumpLatestFilter extends DumpFilter {
        var $page, $pageString, $rev, $revString;
-       
+
        function writeOpenPage( $page, $string ) {
                $this->page = $page;
                $this->pageString = $string;
        }
-       
+
        function writeClosePage( $string ) {
                if( $this->rev ) {
                        $this->sink->writeOpenPage( $this->page, $this->pageString );
@@ -622,7 +750,7 @@ class DumpLatestFilter extends DumpFilter {
                $this->page = null;
                $this->pageString = null;
        }
-       
+
        function writeRevision( $rev, $string ) {
                if( $rev->rev_id == $this->page->page_latest ) {
                        $this->rev = $rev;
@@ -633,37 +761,38 @@ class DumpLatestFilter extends DumpFilter {
 
 /**
  * Base class for output stream; prints to stdout or buffer or whereever.
+ * @addtogroup Dump
  */
 class DumpMultiWriter {
        function DumpMultiWriter( $sinks ) {
                $this->sinks = $sinks;
                $this->count = count( $sinks );
        }
-       
+
        function writeOpenStream( $string ) {
                for( $i = 0; $i < $this->count; $i++ ) {
                        $this->sinks[$i]->writeOpenStream( $string );
                }
        }
-       
+
        function writeCloseStream( $string ) {
                for( $i = 0; $i < $this->count; $i++ ) {
                        $this->sinks[$i]->writeCloseStream( $string );
                }
        }
-       
+
        function writeOpenPage( $page, $string ) {
                for( $i = 0; $i < $this->count; $i++ ) {
                        $this->sinks[$i]->writeOpenPage( $page, $string );
                }
        }
-       
+
        function writeClosePage( $string ) {
                for( $i = 0; $i < $this->count; $i++ ) {
                        $this->sinks[$i]->writeClosePage( $string );
                }
        }
-       
+
        function writeRevision( $rev, $string ) {
                for( $i = 0; $i < $this->count; $i++ ) {
                        $this->sinks[$i]->writeRevision( $rev, $string );
@@ -671,27 +800,20 @@ class DumpMultiWriter {
        }
 }
 
-
-
-function wfTimestamp2ISO8601( $ts ) {
-       #2003-08-05T18:30:02Z
-       return preg_replace( '/^(....)(..)(..)(..)(..)(..)$/', '$1-$2-$3T$4:$5:$6Z', wfTimestamp( TS_MW, $ts ) );
-}
-
 function xmlsafe( $string ) {
        $fname = 'xmlsafe';
        wfProfileIn( $fname );
-       
+
        /**
         * The page may contain old data which has not been properly normalized.
         * Invalid UTF-8 sequences or forbidden control characters will make our
         * XML output invalid, so be sure to strip them out.
         */
        $string = UtfNormal::cleanUp( $string );
-       
+
        $string = htmlspecialchars( $string );
        wfProfileOut( $fname );
        return $string;
 }
 
-?>
+