Follow-up r87176 use wfLocalFile instead of wfFindFile
[lhc/web/wiklou.git] / includes / Export.php
index c273bb0..2c8a748 100644 (file)
@@ -1,21 +1,27 @@
 <?php
-# Copyright (C) 2003, 2005, 2006 Brion Vibber <brion@pobox.com>
-# http://www.mediawiki.org/
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License along
-# with this program; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
-# http://www.gnu.org/copyleft/gpl.html
+/**
+ * Base classes for dumps and export
+ *
+ * Copyright © 2003, 2005, 2006 Brion Vibber <brion@pobox.com>
+ * http://www.mediawiki.org/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * http://www.gnu.org/copyleft/gpl.html
+ *
+ * @file
+ */
 
 /**
  * @defgroup Dump Dump
@@ -29,10 +35,12 @@ class WikiExporter {
        var $author_list = "" ;
 
        var $dumpUploads = false;
+       var $dumpUploadFileContents = false;
 
-       const FULL = 0;
-       const CURRENT = 1;
-       const LOGS = 2;
+       const FULL = 1;
+       const CURRENT = 2;
+       const STABLE = 4; // extension defined
+       const LOGS = 8;
 
        const BUFFER = 0;
        const STREAM = 1;
@@ -54,6 +62,7 @@ class WikiExporter {
         *                   limit: maximum number of rows to return
         *                   dir: "asc" or "desc" timestamp order
         * @param $buffer Int: one of WikiExporter::BUFFER or WikiExporter::STREAM
+        * @param $text Int: one of WikiExporter::TEXT or WikiExporter::STUB
         */
        function __construct( &$db, $history = WikiExporter::CURRENT,
                        $buffer = WikiExporter::BUFFER, $text = WikiExporter::TEXT ) {
@@ -104,7 +113,7 @@ class WikiExporter {
         */
        public function pagesByRange( $start, $end ) {
                $condition = 'page_id >= ' . intval( $start );
-               if( $end ) {
+               if ( $end ) {
                        $condition .= ' AND page_id < ' . intval( $end );
                }
                return $this->dumpFrom( $condition );
@@ -121,15 +130,15 @@ class WikiExporter {
 
        public function pageByName( $name ) {
                $title = Title::newFromText( $name );
-               if( is_null( $title ) ) {
-                       return new WikiError( "Can't export invalid title" );
+               if ( is_null( $title ) ) {
+                       throw new MWException( "Can't export invalid title" );
                } else {
                        return $this->pageByTitle( $title );
                }
        }
 
        public function pagesByName( $names ) {
-               foreach( $names as $name ) {
+               foreach ( $names as $name ) {
                        $this->pageByName( $name );
                }
        }
@@ -140,7 +149,7 @@ class WikiExporter {
 
        public function logsByRange( $start, $end ) {
                $condition = 'log_id >= ' . intval( $start );
-               if( $end ) {
+               if ( $end ) {
                        $condition .= ' AND log_id < ' . intval( $end );
                }
                return $this->dumpFrom( $condition );
@@ -149,18 +158,23 @@ class WikiExporter {
        # Generates the distinct list of authors of an article
        # Not called by default (depends on $this->list_authors)
        # Can be set by Special:Export when not exporting whole history
-       protected function do_list_authors( $page , $revision , $cond ) {
-               $fname = "do_list_authors" ;
-               wfProfileIn( $fname );
+       protected function do_list_authors( $cond ) {
+               wfProfileIn( __METHOD__ );
                $this->author_list = "<contributors>";
-               //rev_deleted
-               $nothidden = '(rev_deleted & '.Revision::DELETED_USER.') = 0';
-
-               $sql = "SELECT DISTINCT rev_user_text,rev_user FROM {$page},{$revision} 
-               WHERE page_id=rev_page AND $nothidden AND " . $cond ;
-               $result = $this->db->query( $sql, $fname );
-               $resultset = $this->db->resultObject( $result );
-               while( $row = $resultset->fetchObject() ) {
+               // rev_deleted
+
+               $res = $this->db->select(
+                       array( 'page', 'revision' ),
+                       array( 'DISTINCT rev_user_text', 'rev_user' ),
+                       array(
+                               $this->db->bitAnd( 'rev_deleted', Revision::DELETED_USER ) . ' = 0',
+                               $cond,
+                               'page_id = rev_id',
+                       ),
+                       __METHOD__
+               );
+
+               foreach ( $res as $row ) {
                        $this->author_list .= "<contributor>" .
                                "<username>" .
                                htmlentities( $row->rev_user_text )  .
@@ -170,106 +184,118 @@ class WikiExporter {
                                "</id>" .
                                "</contributor>";
                }
-               wfProfileOut( $fname );
                $this->author_list .= "</contributors>";
+               wfProfileOut( __METHOD__ );
        }
 
        protected function dumpFrom( $cond = '' ) {
-               $fname = 'WikiExporter::dumpFrom';
-               wfProfileIn( $fname );
-               
-               # For logs dumps...
-               if( $this->history & self::LOGS ) {
+               wfProfileIn( __METHOD__ );
+               # For logging dumps...
+               if ( $this->history & self::LOGS ) {
+                       if ( $this->buffer == WikiExporter::STREAM ) {
+                               $prev = $this->db->bufferResults( false );
+                       }
                        $where = array( 'user_id = log_user' );
                        # Hide private logs
-                       $where[] = LogEventsList::getExcludeClause( $this->db );
-                       if( $cond ) $where[] = $cond;
-                       $result = $this->db->select( array('logging','user'), 
-                               '*',
+                       $hideLogs = LogEventsList::getExcludeClause( $this->db );
+                       if ( $hideLogs ) $where[] = $hideLogs;
+                       # Add on any caller specified conditions
+                       if ( $cond ) $where[] = $cond;
+                       # Get logging table name for logging.* clause
+                       $logging = $this->db->tableName( 'logging' );
+                       $result = $this->db->select( array( 'logging', 'user' ),
+                               array( "{$logging}.*", 'user_name' ), // grab the user name
                                $where,
-                               $fname,
-                               array( 'ORDER BY' => 'log_id', 'USE INDEX' => array('logging' => 'PRIMARY') )
+                               __METHOD__,
+                               array( 'ORDER BY' => 'log_id', 'USE INDEX' => array( 'logging' => 'PRIMARY' ) )
                        );
                        $wrapper = $this->db->resultObject( $result );
                        $this->outputLogStream( $wrapper );
+                       if ( $this->buffer == WikiExporter::STREAM ) {
+                               $this->db->bufferResults( $prev );
+                       }
                # For page dumps...
                } else {
-                       list($page,$revision,$text) = $this->db->tableNamesN('page','revision','text');
-
-                       $order = 'ORDER BY page_id';
-                       $limit = '';
-
-                       if( $this->history == WikiExporter::FULL ) {
-                               $join = 'page_id=rev_page';
-                       } elseif( $this->history == WikiExporter::CURRENT ) {
-                               if ( $this->list_authors && $cond != '' )  { // List authors, if so desired
-                                       $this->do_list_authors ( $page , $revision , $cond );
-                               }
-                               $join = 'page_id=rev_page AND page_latest=rev_id';
-                       } elseif ( is_array( $this->history ) ) {
-                               $join = 'page_id=rev_page';
+                       $tables = array( 'page', 'revision' );
+                       $opts = array( 'ORDER BY' => 'page_id ASC' );
+                       $opts['USE INDEX'] = array();
+                       $join = array();
+                       if ( is_array( $this->history ) ) {
+                               # Time offset/limit for all pages/history...
+                               $revJoin = 'page_id=rev_page';
+                               # Set time order
                                if ( $this->history['dir'] == 'asc' ) {
                                        $op = '>';
-                                       $order .= ', rev_timestamp';
+                                       $opts['ORDER BY'] = 'rev_timestamp ASC';
                                } else {
                                        $op = '<';
-                                       $order .= ', rev_timestamp DESC';
+                                       $opts['ORDER BY'] = 'rev_timestamp DESC';
                                }
+                               # Set offset
                                if ( !empty( $this->history['offset'] ) ) {
-                                       $join .= " AND rev_timestamp $op " . $this->db->addQuotes(
-                                               $this->db->timestamp( $this->history['offset'] ) );
+                                       $revJoin .= " AND rev_timestamp $op " .
+                                               $this->db->addQuotes( $this->db->timestamp( $this->history['offset'] ) );
                                }
+                               $join['revision'] = array( 'INNER JOIN', $revJoin );
+                               # Set query limit
                                if ( !empty( $this->history['limit'] ) ) {
-                                       $limitNum = intval( $this->history['limit'] );
-                                       if ( $limitNum > 0 ) {
-                                               $limit = "LIMIT $limitNum";
-                                       }
+                                       $opts['LIMIT'] = intval( $this->history['limit'] );
+                               }
+                       } elseif ( $this->history & WikiExporter::FULL ) {
+                               # Full history dumps...
+                               $join['revision'] = array( 'INNER JOIN', 'page_id=rev_page' );
+                       } elseif ( $this->history & WikiExporter::CURRENT ) {
+                               # Latest revision dumps...
+                               if ( $this->list_authors && $cond != '' )  { // List authors, if so desired
+                                       $this->do_list_authors( $cond );
+                               }
+                               $join['revision'] = array( 'INNER JOIN', 'page_id=rev_page AND page_latest=rev_id' );
+                       } elseif ( $this->history & WikiExporter::STABLE ) {
+                               # "Stable" revision dumps...
+                               # Default JOIN, to be overridden...
+                               $join['revision'] = array( 'INNER JOIN', 'page_id=rev_page AND page_latest=rev_id' );
+                               # One, and only one hook should set this, and return false
+                               if ( wfRunHooks( 'WikiExporter::dumpStableQuery', array( &$tables, &$opts, &$join ) ) ) {
+                                       wfProfileOut( __METHOD__ );
+                                       throw new MWException( __METHOD__ . " given invalid history dump type." );
                                }
                        } else {
-                               wfProfileOut( $fname );
-                               return new WikiError( "$fname given invalid history dump type." );
+                               # Uknown history specification parameter?
+                               wfProfileOut( __METHOD__ );
+                               throw new MWException( __METHOD__ . " given invalid history dump type." );
                        }
-                       $where = ( $cond == '' ) ? '' : "$cond AND";
-
-                       if( $this->buffer == WikiExporter::STREAM ) {
-                               $prev = $this->db->bufferResults( false );
+                       # Query optimization hacks
+                       if ( $cond == '' ) {
+                               $opts[] = 'STRAIGHT_JOIN';
+                               $opts['USE INDEX']['page'] = 'PRIMARY';
                        }
-                       if( $cond == '' ) {
-                               // Optimization hack for full-database dump
-                               $revindex = $pageindex = $this->db->useIndexClause("PRIMARY");
-                               $straight = ' /*! STRAIGHT_JOIN */ ';
-                       } else {
-                               $pageindex = '';
-                               $revindex = '';
-                               $straight = '';
+                       # Build text join options
+                       if ( $this->text != WikiExporter::STUB ) { // 1-pass
+                               $tables[] = 'text';
+                               $join['text'] = array( 'INNER JOIN', 'rev_text_id=old_id' );
                        }
-                       if( $this->text == WikiExporter::STUB ) {
-                               $sql = "SELECT $straight * FROM
-                                       $page $pageindex,
-                                       $revision $revindex
-                                       WHERE $where $join
-                                       $order $limit";
-                       } else {
-                               $sql = "SELECT $straight * FROM
-                                       $page $pageindex,
-                                       $revision $revindex,
-                                       $text
-                                       WHERE $where $join AND rev_text_id=old_id
-                                       $order $limit";
+
+                       if ( $this->buffer == WikiExporter::STREAM ) {
+                               $prev = $this->db->bufferResults( false );
                        }
-                       $result = $this->db->query( $sql, $fname );
+
+                       wfRunHooks( 'ModifyExportQuery',
+                                               array( $this->db, &$tables, &$cond, &$opts, &$join ) );
+
+                       # Do the query!
+                       $result = $this->db->select( $tables, '*', $cond, __METHOD__, $opts, $join );
                        $wrapper = $this->db->resultObject( $result );
+                       # Output dump results
                        $this->outputPageStream( $wrapper );
-
                        if ( $this->list_authors ) {
                                $this->outputPageStream( $wrapper );
                        }
 
-                       if( $this->buffer == WikiExporter::STREAM ) {
+                       if ( $this->buffer == WikiExporter::STREAM ) {
                                $this->db->bufferResults( $prev );
                        }
                }
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
        }
 
        /**
@@ -286,14 +312,14 @@ class WikiExporter {
         */
        protected function outputPageStream( $resultset ) {
                $last = null;
-               while( $row = $resultset->fetchObject() ) {
-                       if( is_null( $last ) ||
+               foreach ( $resultset as $row ) {
+                       if ( is_null( $last ) ||
                                $last->page_namespace != $row->page_namespace ||
                                $last->page_title     != $row->page_title ) {
-                               if( isset( $last ) ) {
+                               if ( isset( $last ) ) {
                                        $output = '';
-                                       if( $this->dumpUploads ) {
-                                               $output .= $this->writer->writeUploads( $last );
+                                       if ( $this->dumpUploads ) {
+                                               $output .= $this->writer->writeUploads( $last, $this->dumpUploadFileContents );
                                        }
                                        $output .= $this->writer->closePage();
                                        $this->sink->writeClosePage( $output );
@@ -305,24 +331,22 @@ class WikiExporter {
                        $output = $this->writer->writeRevision( $row );
                        $this->sink->writeRevision( $row, $output );
                }
-               if( isset( $last ) ) {
+               if ( isset( $last ) ) {
                        $output = '';
-                       if( $this->dumpUploads ) {
-                               $output .= $this->writer->writeUploads( $last );
+                       if ( $this->dumpUploads ) {
+                               $output .= $this->writer->writeUploads( $last, $this->dumpUploadFileContents );
                        }
                        $output .= $this->author_list;
                        $output .= $this->writer->closePage();
                        $this->sink->writeClosePage( $output );
                }
-               $resultset->free();
        }
-       
+
        protected function outputLogStream( $resultset ) {
-               while( $row = $resultset->fetchObject() ) {
+               foreach ( $resultset as $row ) {
                        $output = $this->writer->writeLogItem( $row );
                        $this->sink->writeLogItem( $row, $output );
                }
-               $resultset->free();
        }
 }
 
@@ -336,7 +360,7 @@ class XmlDumpWriter {
         * @return string
         */
        function schemaVersion() {
-               return "0.3"; // FIXME: upgrade to 0.4 when updated XSD is ready, for the revision deletion bits
+               return "0.5";
        }
 
        /**
@@ -350,15 +374,15 @@ class XmlDumpWriter {
         * @return string
         */
        function openStream() {
-               global $wgContLanguageCode;
+               global $wgLanguageCode;
                $ver = $this->schemaVersion();
-               return wfElement( 'mediawiki', array(
+               return Xml::element( 'mediawiki', array(
                        'xmlns'              => "http://www.mediawiki.org/xml/export-$ver/",
                        'xmlns:xsi'          => "http://www.w3.org/2001/XMLSchema-instance",
                        'xsi:schemaLocation' => "http://www.mediawiki.org/xml/export-$ver/ " .
                                                "http://www.mediawiki.org/xml/export-$ver.xsd",
                        'version'            => $ver,
-                       'xml:lang'           => $wgContLanguageCode ),
+                       'xml:lang'           => $wgLanguageCode ),
                        null ) .
                        "\n" .
                        $this->siteInfo();
@@ -378,30 +402,33 @@ class XmlDumpWriter {
 
        function sitename() {
                global $wgSitename;
-               return wfElement( 'sitename', array(), $wgSitename );
+               return Xml::element( 'sitename', array(), $wgSitename );
        }
 
        function generator() {
-               global $wgVersion;
-               return wfElement( 'generator', array(), "MediaWiki $wgVersion" );
+               return Xml::element( 'generator', array(), "MediaWiki " . MW_VERSION );
        }
 
        function homelink() {
-               return wfElement( 'base', array(), Title::newMainPage()->getFullUrl() );
+               return Xml::element( 'base', array(), Title::newMainPage()->getFullUrl() );
        }
 
        function caseSetting() {
                global $wgCapitalLinks;
                // "case-insensitive" option is reserved for future
                $sensitivity = $wgCapitalLinks ? 'first-letter' : 'case-sensitive';
-               return wfElement( 'case', array(), $sensitivity );
+               return Xml::element( 'case', array(), $sensitivity );
        }
 
        function namespaces() {
                global $wgContLang;
-               $spaces = "  <namespaces>\n";
-               foreach( $wgContLang->getFormattedNamespaces() as $ns => $title ) {
-                       $spaces .= '      ' . wfElement( 'namespace', array( 'key' => $ns ), $title ) . "\n";
+               $spaces = "<namespaces>\n";
+               foreach ( $wgContLang->getFormattedNamespaces() as $ns => $title ) {
+                       $spaces .= '      ' .
+                               Xml::element( 'namespace',
+                                       array(  'key' => $ns,
+                                                       'case' => MWNamespace::isCapitalized( $ns ) ? 'first-letter' : 'case-sensitive',
+                                       ), $title ) . "\n";
                }
                $spaces .= "    </namespaces>";
                return $spaces;
@@ -427,12 +454,18 @@ class XmlDumpWriter {
        function openPage( $row ) {
                $out = "  <page>\n";
                $title = Title::makeTitle( $row->page_namespace, $row->page_title );
-               $out .= '    ' . wfElementClean( 'title', array(), $title->getPrefixedText() ) . "\n";
-               $out .= '    ' . wfElement( 'id', array(), strval( $row->page_id ) ) . "\n";
-               if( '' != $row->page_restrictions ) {
-                       $out .= '    ' . wfElement( 'restrictions', array(),
+               $out .= '    ' . Xml::elementClean( 'title', array(), $title->getPrefixedText() ) . "\n";
+               $out .= '    ' . Xml::element( 'id', array(), strval( $row->page_id ) ) . "\n";
+               if ( $row->page_is_redirect ) {
+                       $out .= '    ' . Xml::element( 'redirect', array() ) . "\n";
+               }
+               if ( $row->page_restrictions != '' ) {
+                       $out .= '    ' . Xml::element( 'restrictions', array(),
                                strval( $row->page_restrictions ) ) . "\n";
                }
+
+               wfRunHooks( 'XmlDumpWriterOpenPage', array( $this, &$out, $row, $title ) );
+
                return $out;
        }
 
@@ -454,50 +487,52 @@ class XmlDumpWriter {
         * @access private
         */
        function writeRevision( $row ) {
-               $fname = 'WikiExporter::dumpRev';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
 
                $out  = "    <revision>\n";
-               $out .= "      " . wfElement( 'id', null, strval( $row->rev_id ) ) . "\n";
+               $out .= "      " . Xml::element( 'id', null, strval( $row->rev_id ) ) . "\n";
 
                $out .= $this->writeTimestamp( $row->rev_timestamp );
 
-               if( $row->rev_deleted & Revision::DELETED_USER ) {
-                       $out .= "      " . wfElement( 'contributor', array( 'deleted' => 'deleted' ) ) . "\n";
+               if ( $row->rev_deleted & Revision::DELETED_USER ) {
+                       $out .= "      " . Xml::element( 'contributor', array( 'deleted' => 'deleted' ) ) . "\n";
                } else {
                        $out .= $this->writeContributor( $row->rev_user, $row->rev_user_text );
                }
 
-               if( $row->rev_minor_edit ) {
+               if ( $row->rev_minor_edit ) {
                        $out .=  "      <minor/>\n";
                }
-               if( $row->rev_deleted & Revision::DELETED_COMMENT ) {
-                       $out .= "      " . wfElement( 'comment', array( 'deleted' => 'deleted' ) ) . "\n";
-               } elseif( $row->rev_comment != '' ) {
-                       $out .= "      " . wfElementClean( 'comment', null, strval( $row->rev_comment ) ) . "\n";
+               if ( $row->rev_deleted & Revision::DELETED_COMMENT ) {
+                       $out .= "      " . Xml::element( 'comment', array( 'deleted' => 'deleted' ) ) . "\n";
+               } elseif ( $row->rev_comment != '' ) {
+                       $out .= "      " . Xml::elementClean( 'comment', null, strval( $row->rev_comment ) ) . "\n";
                }
 
-               if( $row->rev_deleted & Revision::DELETED_TEXT ) {
-                       $out .= "      " . wfElement( 'text', array( 'deleted' => 'deleted' ) ) . "\n";
-               } elseif( isset( $row->old_text ) ) {
+               $text = '';
+               if ( $row->rev_deleted & Revision::DELETED_TEXT ) {
+                       $out .= "      " . Xml::element( 'text', array( 'deleted' => 'deleted' ) ) . "\n";
+               } elseif ( isset( $row->old_text ) ) {
                        // Raw text from the database may have invalid chars
                        $text = strval( Revision::getRevisionText( $row ) );
-                       $out .= "      " . wfElementClean( 'text',
-                               array( 'xml:space' => 'preserve' ),
+                       $out .= "      " . Xml::elementClean( 'text',
+                               array( 'xml:space' => 'preserve', 'bytes' => $row->rev_len ),
                                strval( $text ) ) . "\n";
                } else {
                        // Stub output
-                       $out .= "      " . wfElement( 'text',
-                               array( 'id' => $row->rev_text_id ),
+                       $out .= "      " . Xml::element( 'text',
+                               array( 'id' => $row->rev_text_id, 'bytes' => $row->rev_len ),
                                "" ) . "\n";
                }
 
+               wfRunHooks( 'XmlDumpWriterWriteRevision', array( &$this, &$out, $row, $text ) );
+
                $out .= "    </revision>\n";
 
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return $out;
        }
-       
+
        /**
         * Dumps a <logitem> section on the output stream, with
         * data filled in from the given database row.
@@ -507,57 +542,56 @@ class XmlDumpWriter {
         * @access private
         */
        function writeLogItem( $row ) {
-               $fname = 'WikiExporter::writeLogItem';
-               wfProfileIn( $fname );
+               wfProfileIn( __METHOD__ );
 
                $out  = "    <logitem>\n";
-               $out .= "      " . wfElement( 'id', null, strval( $row->log_id ) ) . "\n";
+               $out .= "      " . Xml::element( 'id', null, strval( $row->log_id ) ) . "\n";
 
                $out .= $this->writeTimestamp( $row->log_timestamp );
 
-               if( $row->log_deleted & LogPage::DELETED_USER ) {
-                       $out .= "      " . wfElement( 'contributor', array( 'deleted' => 'deleted' ) ) . "\n";
+               if ( $row->log_deleted & LogPage::DELETED_USER ) {
+                       $out .= "      " . Xml::element( 'contributor', array( 'deleted' => 'deleted' ) ) . "\n";
                } else {
                        $out .= $this->writeContributor( $row->log_user, $row->user_name );
                }
 
-               if( $row->log_deleted & LogPage::DELETED_COMMENT ) {
-                       $out .= "      " . wfElement( 'comment', array( 'deleted' => 'deleted' ) ) . "\n";
-               } elseif( $row->log_comment != '' ) {
-                       $out .= "      " . wfElementClean( 'comment', null, strval( $row->log_comment ) ) . "\n";
+               if ( $row->log_deleted & LogPage::DELETED_COMMENT ) {
+                       $out .= "      " . Xml::element( 'comment', array( 'deleted' => 'deleted' ) ) . "\n";
+               } elseif ( $row->log_comment != '' ) {
+                       $out .= "      " . Xml::elementClean( 'comment', null, strval( $row->log_comment ) ) . "\n";
                }
-               
-               $out .= "      " . wfElement( 'type', null, strval( $row->log_type ) ) . "\n";
-               $out .= "      " . wfElement( 'action', null, strval( $row->log_action ) ) . "\n";
 
-               if( $row->log_deleted & LogPage::DELETED_ACTION ) {
-                       $out .= "      " . wfElement( 'text', array( 'deleted' => 'deleted' ) ) . "\n";
+               $out .= "      " . Xml::element( 'type', null, strval( $row->log_type ) ) . "\n";
+               $out .= "      " . Xml::element( 'action', null, strval( $row->log_action ) ) . "\n";
+
+               if ( $row->log_deleted & LogPage::DELETED_ACTION ) {
+                       $out .= "      " . Xml::element( 'text', array( 'deleted' => 'deleted' ) ) . "\n";
                } else {
                        $title = Title::makeTitle( $row->log_namespace, $row->log_title );
-                       $out .= "      " . wfElementClean( 'title', null, $title->getPrefixedText() ) . "\n";
-                       $out .= "      " . wfElementClean( 'params',
+                       $out .= "      " . Xml::elementClean( 'logtitle', null, $title->getPrefixedText() ) . "\n";
+                       $out .= "      " . Xml::elementClean( 'params',
                                array( 'xml:space' => 'preserve' ),
                                strval( $row->log_params ) ) . "\n";
                }
 
                $out .= "    </logitem>\n";
 
-               wfProfileOut( $fname );
+               wfProfileOut( __METHOD__ );
                return $out;
        }
 
        function writeTimestamp( $timestamp ) {
                $ts = wfTimestamp( TS_ISO_8601, $timestamp );
-               return "      " . wfElement( 'timestamp', null, $ts ) . "\n";
+               return "      " . Xml::element( 'timestamp', null, $ts ) . "\n";
        }
 
        function writeContributor( $id, $text ) {
                $out = "      <contributor>\n";
-               if( $id ) {
-                       $out .= "        " . wfElementClean( 'username', null, strval( $text ) ) . "\n";
-                       $out .= "        " . wfElement( 'id', null, strval( $id ) ) . "\n";
+               if ( $id ) {
+                       $out .= "        " . Xml::elementClean( 'username', null, strval( $text ) ) . "\n";
+                       $out .= "        " . Xml::element( 'id', null, strval( $id ) ) . "\n";
                } else {
-                       $out .= "        " . wfElementClean( 'ip', null, strval( $text ) ) . "\n";
+                       $out .= "        " . Xml::elementClean( 'ip', null, strval( $text ) ) . "\n";
                }
                $out .= "      </contributor>\n";
                return $out;
@@ -566,29 +600,48 @@ class XmlDumpWriter {
        /**
         * Warning! This data is potentially inconsistent. :(
         */
-       function writeUploads( $row ) {
-               if( $row->page_namespace == NS_IMAGE ) {
-                       $img = wfFindFile( $row->page_title );
-                       if( $img ) {
+       function writeUploads( $row, $dumpContents = false ) {
+               if ( $row->page_namespace == NS_IMAGE ) {
+                       $img = wfLocalFile( $row->page_title );
+                       if ( $img && $img->exists() ) {
                                $out = '';
-                               foreach( array_reverse( $img->getHistory() ) as $ver ) {
-                                       $out .= $this->writeUpload( $ver );
+                               foreach ( array_reverse( $img->getHistory() ) as $ver ) {
+                                       $out .= $this->writeUpload( $ver, $dumpContents );
                                }
-                               $out .= $this->writeUpload( $img );
+                               $out .= $this->writeUpload( $img, $dumpContents );
                                return $out;
                        }
                }
                return '';
        }
 
-       function writeUpload( $file ) {
+       function writeUpload( $file, $dumpContents = false ) {
+               if ( $file->isOld() ) {
+                       $archiveName = "      " . 
+                               Xml::element( 'archivename', null, $file->getArchiveName() ) . "\n";
+               } else {
+                       $archiveName = '';
+               }
+               if ( $dumpContents ) {
+                       # Dump file as base64
+                       # Uses only XML-safe characters, so does not need escaping
+                       $contents = '      <contents encoding="base64">' . 
+                               chunk_split( base64_encode( file_get_contents( $file->getPath() ) ) ) .
+                               "      </contents>\n";
+               } else {
+                       $contents = '';
+               }
                return "    <upload>\n" .
                        $this->writeTimestamp( $file->getTimestamp() ) .
                        $this->writeContributor( $file->getUser( 'id' ), $file->getUser( 'text' ) ) .
-                       "      " . wfElementClean( 'comment', null, $file->getDescription() ) . "\n" .
-                       "      " . wfElement( 'filename', null, $file->getName() ) . "\n" .
-                       "      " . wfElement( 'src', null, $file->getFullUrl() ) . "\n" .
-                       "      " . wfElement( 'size', null, $file->getSize() ) . "\n" .
+                       "      " . Xml::elementClean( 'comment', null, $file->getDescription() ) . "\n" .
+                       "      " . Xml::element( 'filename', null, $file->getName() ) . "\n" .
+                       $archiveName . 
+                       "      " . Xml::element( 'src', null, $file->getFullUrl() ) . "\n" .
+                       "      " . Xml::element( 'size', null, $file->getSize() ) . "\n" .
+                       "      " . Xml::element( 'sha1base36', null, $file->getSha1() ) . "\n" .
+                       "      " . Xml::element( 'rel', null, $file->getRel() ) . "\n" .
+                       $contents .
                        "    </upload>\n";
        }
 
@@ -619,7 +672,7 @@ class DumpOutput {
        function writeRevision( $rev, $string ) {
                $this->write( $string );
        }
-       
+
        function writeLogItem( $rev, $string ) {
                $this->write( $string );
        }
@@ -640,7 +693,7 @@ class DumpOutput {
 class DumpFileOutput extends DumpOutput {
        var $handle;
 
-       function DumpFileOutput( $file ) {
+       function __construct( $file ) {
                $this->handle = fopen( $file, "wt" );
        }
 
@@ -656,8 +709,8 @@ class DumpFileOutput extends DumpOutput {
  * @ingroup Dump
  */
 class DumpPipeOutput extends DumpFileOutput {
-       function DumpPipeOutput( $command, $file = null ) {
-               if( !is_null( $file ) ) {
+       function __construct( $command, $file = null ) {
+               if ( !is_null( $file ) ) {
                        $command .=  " > " . wfEscapeShellArg( $file );
                }
                $this->handle = popen( $command, "w" );
@@ -669,8 +722,8 @@ class DumpPipeOutput extends DumpFileOutput {
  * @ingroup Dump
  */
 class DumpGZipOutput extends DumpPipeOutput {
-       function DumpGZipOutput( $file ) {
-               parent::DumpPipeOutput( "gzip", $file );
+       function __construct( $file ) {
+               parent::__construct( "gzip", $file );
        }
 }
 
@@ -679,8 +732,8 @@ class DumpGZipOutput extends DumpPipeOutput {
  * @ingroup Dump
  */
 class DumpBZip2Output extends DumpPipeOutput {
-       function DumpBZip2Output( $file ) {
-               parent::DumpPipeOutput( "bzip2", $file );
+       function __construct( $file ) {
+               parent::__construct( "bzip2", $file );
        }
 }
 
@@ -689,12 +742,12 @@ class DumpBZip2Output extends DumpPipeOutput {
  * @ingroup Dump
  */
 class Dump7ZipOutput extends DumpPipeOutput {
-       function Dump7ZipOutput( $file ) {
+       function __construct( $file ) {
                $command = "7za a -bd -si " . wfEscapeShellArg( $file );
                // Suppress annoying useless crap from p7zip
                // Unfortunately this could suppress real error messages too
                $command .= ' >' . wfGetNull() . ' 2>&1';
-               parent::DumpPipeOutput( $command );
+               parent::__construct( $command );
        }
 }
 
@@ -707,7 +760,7 @@ class Dump7ZipOutput extends DumpPipeOutput {
  * @ingroup Dump
  */
 class DumpFilter {
-       function DumpFilter( &$sink ) {
+       function __construct( &$sink ) {
                $this->sink =& $sink;
        }
 
@@ -721,27 +774,27 @@ class DumpFilter {
 
        function writeOpenPage( $page, $string ) {
                $this->sendingThisPage = $this->pass( $page, $string );
-               if( $this->sendingThisPage ) {
+               if ( $this->sendingThisPage ) {
                        $this->sink->writeOpenPage( $page, $string );
                }
        }
 
        function writeClosePage( $string ) {
-               if( $this->sendingThisPage ) {
+               if ( $this->sendingThisPage ) {
                        $this->sink->writeClosePage( $string );
                        $this->sendingThisPage = false;
                }
        }
 
        function writeRevision( $rev, $string ) {
-               if( $this->sendingThisPage ) {
+               if ( $this->sendingThisPage ) {
                        $this->sink->writeRevision( $rev, $string );
                }
        }
-       
+
        function writeLogItem( $rev, $string ) {
                $this->sink->writeRevision( $rev, $string );
-       }       
+       }
 
        /**
         * Override for page-based filter types.
@@ -770,8 +823,8 @@ class DumpNamespaceFilter extends DumpFilter {
        var $invert = false;
        var $namespaces = array();
 
-       function DumpNamespaceFilter( &$sink, $param ) {
-               parent::DumpFilter( $sink );
+       function __construct( &$sink, $param ) {
+               parent::__construct( $sink );
 
                $constants = array(
                        "NS_MAIN"           => NS_MAIN,
@@ -780,7 +833,9 @@ class DumpNamespaceFilter extends DumpFilter {
                        "NS_USER_TALK"      => NS_USER_TALK,
                        "NS_PROJECT"        => NS_PROJECT,
                        "NS_PROJECT_TALK"   => NS_PROJECT_TALK,
-                       "NS_IMAGE"          => NS_IMAGE,
+                       "NS_FILE"           => NS_FILE,
+                       "NS_FILE_TALK"      => NS_FILE_TALK,
+                       "NS_IMAGE"          => NS_IMAGE,  // NS_IMAGE is an alias for NS_FILE
                        "NS_IMAGE_TALK"     => NS_IMAGE_TALK,
                        "NS_MEDIAWIKI"      => NS_MEDIAWIKI,
                        "NS_MEDIAWIKI_TALK" => NS_MEDIAWIKI_TALK,
@@ -791,17 +846,17 @@ class DumpNamespaceFilter extends DumpFilter {
                        "NS_CATEGORY"       => NS_CATEGORY,
                        "NS_CATEGORY_TALK"  => NS_CATEGORY_TALK );
 
-               if( $param{0} == '!' ) {
+               if ( $param { 0 } == '!' ) {
                        $this->invert = true;
                        $param = substr( $param, 1 );
                }
 
-               foreach( explode( ',', $param ) as $key ) {
+               foreach ( explode( ',', $param ) as $key ) {
                        $key = trim( $key );
-                       if( isset( $constants[$key] ) ) {
+                       if ( isset( $constants[$key] ) ) {
                                $ns = $constants[$key];
                                $this->namespaces[$ns] = true;
-                       } elseif( is_numeric( $key ) ) {
+                       } elseif ( is_numeric( $key ) ) {
                                $ns = intval( $key );
                                $this->namespaces[$ns] = true;
                        } else {
@@ -830,7 +885,7 @@ class DumpLatestFilter extends DumpFilter {
        }
 
        function writeClosePage( $string ) {
-               if( $this->rev ) {
+               if ( $this->rev ) {
                        $this->sink->writeOpenPage( $this->page, $this->pageString );
                        $this->sink->writeRevision( $this->rev, $this->revString );
                        $this->sink->writeClosePage( $string );
@@ -842,7 +897,7 @@ class DumpLatestFilter extends DumpFilter {
        }
 
        function writeRevision( $rev, $string ) {
-               if( $rev->rev_id == $this->page->page_latest ) {
+               if ( $rev->rev_id == $this->page->page_latest ) {
                        $this->rev = $rev;
                        $this->revString = $string;
                }
@@ -854,45 +909,44 @@ class DumpLatestFilter extends DumpFilter {
  * @ingroup Dump
  */
 class DumpMultiWriter {
-       function DumpMultiWriter( $sinks ) {
+       function __construct( $sinks ) {
                $this->sinks = $sinks;
                $this->count = count( $sinks );
        }
 
        function writeOpenStream( $string ) {
-               for( $i = 0; $i < $this->count; $i++ ) {
+               for ( $i = 0; $i < $this->count; $i++ ) {
                        $this->sinks[$i]->writeOpenStream( $string );
                }
        }
 
        function writeCloseStream( $string ) {
-               for( $i = 0; $i < $this->count; $i++ ) {
+               for ( $i = 0; $i < $this->count; $i++ ) {
                        $this->sinks[$i]->writeCloseStream( $string );
                }
        }
 
        function writeOpenPage( $page, $string ) {
-               for( $i = 0; $i < $this->count; $i++ ) {
+               for ( $i = 0; $i < $this->count; $i++ ) {
                        $this->sinks[$i]->writeOpenPage( $page, $string );
                }
        }
 
        function writeClosePage( $string ) {
-               for( $i = 0; $i < $this->count; $i++ ) {
+               for ( $i = 0; $i < $this->count; $i++ ) {
                        $this->sinks[$i]->writeClosePage( $string );
                }
        }
 
        function writeRevision( $rev, $string ) {
-               for( $i = 0; $i < $this->count; $i++ ) {
+               for ( $i = 0; $i < $this->count; $i++ ) {
                        $this->sinks[$i]->writeRevision( $rev, $string );
                }
        }
 }
 
 function xmlsafe( $string ) {
-       $fname = 'xmlsafe';
-       wfProfileIn( $fname );
+       wfProfileIn( __FUNCTION__ );
 
        /**
         * The page may contain old data which has not been properly normalized.
@@ -902,6 +956,6 @@ function xmlsafe( $string ) {
        $string = UtfNormal::cleanUp( $string );
 
        $string = htmlspecialchars( $string );
-       wfProfileOut( $fname );
+       wfProfileOut( __FUNCTION__ );
        return $string;
 }