Version the minifier cache in ResourceLoader
[lhc/web/wiklou.git] / includes / EditPage.php
index 10efc31..e8bfd95 100644 (file)
@@ -11,7 +11,7 @@
  * interfaces.
  *
  * EditPage cares about two distinct titles:
- * $wgTitle is the page that forms submit to, links point to,
+ * $this->mContextTitle is the page that forms submit to, links point to,
  * redirects go to, etc. $this->mTitle (as well as $mArticle) is the
  * page in the database that is actually being edited. These are
  * usually the same, but they are now allowed to be different.
@@ -44,18 +44,20 @@ class EditPage {
 
        var $mArticle;
        var $mTitle;
+       private $mContextTitle = null;
        var $action;
        var $isConflict = false;
        var $isCssJsSubpage = false;
        var $isCssSubpage = false;
        var $isJsSubpage = false;
-       var $deletedSinceEdit = false;
+       var $deletedSinceEdit;
        var $formtype;
        var $firsttime;
        var $lastDelete;
        var $mTokenOk = false;
        var $mTokenOkExceptSuffix = false;
        var $mTriedSave = false;
+       var $incompleteForm = false;
        var $tooBig = false;
        var $kblength = false;
        var $missingComment = false;
@@ -96,7 +98,7 @@ class EditPage {
         * @todo document
         * @param $article
         */
-       function EditPage( $article ) {
+       function __construct( $article ) {
                $this->mArticle =& $article;
                $this->mTitle = $article->getTitle();
                $this->action = 'submit';
@@ -117,6 +119,30 @@ class EditPage {
                return $this->mArticle;
        }
 
+       /**
+        * Set the context Title object
+        *
+        * @param $title Title object or null
+        */
+       public function setContextTitle( $title ) {
+               $this->mContextTitle = $title;
+       }
+
+       /**
+        * Get the context title object.
+        * If not set, $wgTitle will be returned. This behavior might changed in
+        * the future to return $this->mTitle instead.
+        *
+        * @return Title object
+        */
+       public function getContextTitle() {
+               if ( is_null( $this->mContextTitle ) ) {
+                       global $wgTitle;
+                       return $wgTitle;
+               } else {
+                       return $this->mContextTitle;
+               }
+       }
 
        /**
         * Fetch initial editing page content.
@@ -124,29 +150,27 @@ class EditPage {
         * @private
         */
        function getContent( $def_text = '' ) {
-               global $wgOut, $wgRequest, $wgParser, $wgContLang, $wgMessageCache;
+               global $wgOut, $wgRequest, $wgParser;
 
                wfProfileIn( __METHOD__ );
                # Get variables from query string :P
                $section = $wgRequest->getVal( 'section' );
-                       
-               $preload = $wgRequest->getVal( 'preload', 
+
+               $preload = $wgRequest->getVal( 'preload',
                        // Custom preload text for new sections
                        $section === 'new' ? 'MediaWiki:addsection-preload' : '' );
                $undoafter = $wgRequest->getVal( 'undoafter' );
                $undo = $wgRequest->getVal( 'undo' );
 
-               $text = '';
                // For message page not locally set, use the i18n message.
                // For other non-existent articles, use preload text if any.
                if ( !$this->mTitle->exists() ) {
                        if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
                                # If this is a system message, get the default text.
-                               list( $message, $lang ) = $wgMessageCache->figureMessage( $wgContLang->lcfirst( $this->mTitle->getText() ) );
-                               $wgMessageCache->loadAllMessages( $lang );
-                               $text = wfMsgGetKey( $message, false, $lang, false );
-                               if( wfEmptyMsg( $message, $text ) )
+                               $text = $this->mTitle->getDefaultMessageText();
+                               if( $text === false ) {
                                        $text = $this->getPreloadedText( $preload );
+                               }
                        } else {
                                # If requested, preload some text.
                                $text = $this->getPreloadedText( $preload );
@@ -262,8 +286,12 @@ class EditPage {
         * deletes.
         */
        protected function wasDeletedSinceLastEdit() {
-               if ( $this->deletedSinceEdit )
-                       return true;
+               if ( $this->deletedSinceEdit !== null ) {
+                       return $this->deletedSinceEdit;
+               }
+
+               $this->deletedSinceEdit = false;
+
                if ( $this->mTitle->isDeletedQuick() ) {
                        $this->lastDelete = $this->getLastDelete();
                        if ( $this->lastDelete ) {
@@ -273,9 +301,28 @@ class EditPage {
                                }
                        }
                }
+
                return $this->deletedSinceEdit;
        }
 
+       /**
+        * Checks whether the user entered a skin name in uppercase,
+        * e.g. "User:Example/Monobook.css" instead of "monobook.css"
+        */
+       protected function isWrongCaseCssJsPage() {
+               if( $this->mTitle->isCssJsSubpage() ) {
+                       $name = $this->mTitle->getSkinFromCssJsSubpage();
+                       $skins = array_merge(
+                               array_keys( Skin::getSkinNames() ),
+                               array( 'common' )
+                       );
+                       return !in_array( $name, $skins )
+                               && in_array( strtolower( $name ), $skins );
+               } else {
+                       return false;
+               }
+       }
+
        function submit() {
                $this->edit();
        }
@@ -319,19 +366,18 @@ class EditPage {
                        $this->preview = true;
                }
 
-               $wgOut->addScriptFile( 'edit.js' );
-               
+               $wgOut->addModules( array( 'mediawiki.legacy.edit', 'mediawiki.action.edit' ) );
+
                if ( $wgUser->getOption( 'uselivepreview', false ) ) {
-                       $wgOut->includeJQuery();
-                       $wgOut->addScriptFile( 'preview.js' );
+                       $wgOut->addModules( 'mediawiki.legacy.preview' );
                }
-               // Bug #19334: textarea jumps when editing articles in IE8
-               $wgOut->addStyle( 'common/IE80Fixes.css', 'screen', 'IE 8' );
 
                $permErrors = $this->getEditPermissionErrors();
                if ( $permErrors ) {
                        wfDebug( __METHOD__ . ": User can't edit\n" );
-                       $this->readOnlyPage( $this->getContent( false ), true, $permErrors, 'edit' );
+                       $content = $this->getContent( null );
+                       $content = $content === '' ? null : $content;
+                       $this->readOnlyPage( $content, true, $permErrors, 'edit' );
                        wfProfileOut( __METHOD__ );
                        return;
                } else {
@@ -363,7 +409,7 @@ class EditPage {
                $this->isCssJsSubpage      = $this->mTitle->isCssJsSubpage();
                $this->isCssSubpage        = $this->mTitle->isCssSubpage();
                $this->isJsSubpage         = $this->mTitle->isJsSubpage();
-               $this->isValidCssJsSubpage = $this->mTitle->isValidCssJsSubpage();
+               $this->isWrongCaseCssJsPage = $this->isWrongCaseCssJsPage();
 
                # Show applicable editing introductions
                if ( $this->formtype == 'initial' || $this->firsttime )
@@ -375,16 +421,18 @@ class EditPage {
 
                # Optional notices on a per-namespace and per-page basis
                $editnotice_ns   = 'editnotice-'.$this->mTitle->getNamespace();
-               if ( !wfEmptyMsg( $editnotice_ns, wfMsgForContent( $editnotice_ns ) ) ) {
-                       $wgOut->addWikiText( wfMsgForContent( $editnotice_ns )  );
+               $editnotice_ns_message = wfMessage( $editnotice_ns )->inContentLanguage();
+               if ( $editnotice_ns_message->exists() ) {
+                       $wgOut->addWikiText( $editnotice_ns_message->plain() );
                }
                if ( MWNamespace::hasSubpages( $this->mTitle->getNamespace() ) ) {
                        $parts = explode( '/', $this->mTitle->getDBkey() );
                        $editnotice_base = $editnotice_ns;
                        while ( count( $parts ) > 0 ) {
                                $editnotice_base .= '-'.array_shift( $parts );
-                               if ( !wfEmptyMsg( $editnotice_base, wfMsgForContent( $editnotice_base ) ) ) {
-                                       $wgOut->addWikiText( wfMsgForContent( $editnotice_base )  );
+                               $editnotice_base_msg = wfMessage( $editnotice_base )->inContentLanguage();
+                               if ( $editnotice_base_msg->exists() ) {
+                                       $wgOut->addWikiText( $editnotice_base_msg->plain()  );
                                }
                        }
                }
@@ -493,7 +541,7 @@ class EditPage {
        /**
         * Does this EditPage class support section editing?
         * This is used by EditPage subclasses to indicate their ui cannot handle section edits
-        * 
+        *
         * @return bool
         */
        protected function isSectionEditSupported() {
@@ -505,7 +553,7 @@ class EditPage {
         * This is used by EditPage subclasses when simply customizing the action
         * variable in the constructor is not enough. This can be used when the
         * EditPage lives inside of a Special page rather than a custom page action.
-        * 
+        *
         * @param $title Title object for which is being edited (where we go to for &action= links)
         * @return string
         */
@@ -542,7 +590,7 @@ class EditPage {
                        }
 
                        # Truncate for whole multibyte characters. +5 bytes for ellipsis
-                       $this->summary = $wgLang->truncate( $request->getText( 'wpSummary' ), 250, '' );
+                       $this->summary = $wgLang->truncate( $request->getText( 'wpSummary' ), 250 );
 
                        # Remove extra headings from summaries and new sections.
                        $this->summary = preg_replace('/^\s*=+\s*(.*?)\s*=+\s*$/', '$1', $this->summary);
@@ -552,7 +600,17 @@ class EditPage {
 
                        $this->scrolltop = $request->getIntOrNull( 'wpScrolltop' );
 
-                       if ( is_null( $this->edittime ) ) {
+                       if ($this->textbox1 === '' && $request->getVal( 'wpTextbox1' ) === null) {
+                               // wpTextbox1 field is missing, possibly due to being "too big"
+                               // according to some filter rules such as Suhosin's setting for
+                               // suhosin.request.max_value_length (d'oh)
+                               $this->incompleteForm = true;
+                       } else {
+                               // edittime should be one of our last fields; if it's missing,
+                               // the submission probably broke somewhere in the middle.
+                               $this->incompleteForm = is_null( $this->edittime );
+                       }
+                       if ( $this->incompleteForm ) {
                                # If the form is incomplete, force to preview.
                                wfDebug( __METHOD__ . ": Form data appears to be incomplete\n" );
                                wfDebug( "POST DATA: " . var_export( $_POST, true ) . "\n" );
@@ -644,10 +702,10 @@ class EditPage {
                        // Custom edit intro for new sections
                        $this->section === 'new' ? 'MediaWiki:addsection-editintro' : '' );
 
-               wfProfileOut( __METHOD__ );
-
                // Allow extensions to modify form data
                wfRunHooks( 'EditPage::importFormData', array( $this, $request ) );
+
+               wfProfileOut( __METHOD__ );
        }
 
        /**
@@ -655,7 +713,7 @@ class EditPage {
         * posted form to be placed in $this->textbox1, if using customized input
         * this method should be overrided and return the page text that will be used
         * for saving, preview parsing and so on...
-        * 
+        *
         * @param $request WebRequest
         */
        protected function importContentFormData( &$request ) {
@@ -690,7 +748,7 @@ class EditPage {
 
                if ( $namespace == NS_MEDIAWIKI ) {
                        # Show a warning if editing an interface message
-                       $wgOut->wrapWikiMsg( "<div class='mw-editinginterface'>\n$1</div>", 'editinginterface' );
+                       $wgOut->wrapWikiMsg( "<div class='mw-editinginterface'>\n$1\n</div>", 'editinginterface' );
                }
 
                # Show a warning message when someone creates/edits a user (talk) page but the user does not exist
@@ -701,7 +759,7 @@ class EditPage {
                        $user = User::newFromName( $username, false /* allow IP users*/ );
                        $ip = User::isIP( $username );
                        if ( !$user->isLoggedIn() && !$ip ) { # User does not exist
-                               $wgOut->wrapWikiMsg( "<div class=\"mw-userpage-userdoesnotexist error\">\n$1</div>",
+                               $wgOut->wrapWikiMsg( "<div class=\"mw-userpage-userdoesnotexist error\">\n$1\n</div>",
                                        array( 'userpage-userdoesnotexist', $username ) );
                        } else if ( $user->isBlocked() ) { # Show log extract if the user is currently blocked
                                LogEventsList::showLogExtract(
@@ -723,9 +781,9 @@ class EditPage {
                # Try to add a custom edit intro, or use the standard one if this is not possible.
                if ( !$this->showCustomIntro() && !$this->mTitle->exists() ) {
                        if ( $wgUser->isLoggedIn() ) {
-                               $wgOut->wrapWikiMsg( "<div class=\"mw-newarticletext\">\n$1</div>", 'newarticletext' );
+                               $wgOut->wrapWikiMsg( "<div class=\"mw-newarticletext\">\n$1\n</div>", 'newarticletext' );
                        } else {
-                               $wgOut->wrapWikiMsg( "<div class=\"mw-newarticletextanon\">\n$1</div>", 'newarticletextanon' );
+                               $wgOut->wrapWikiMsg( "<div class=\"mw-newarticletextanon\">\n$1\n</div>", 'newarticletextanon' );
                        }
                }
                # Give a notice if the user is editing a deleted/moved page...
@@ -749,8 +807,8 @@ class EditPage {
                        $title = Title::newFromText( $this->editintro );
                        if ( $title instanceof Title && $title->exists() && $title->userCanRead() ) {
                                global $wgOut;
-                               $revision = Revision::newFromTitle( $title );
-                               $wgOut->addWikiTextTitleTidy( $revision->getText(), $this->mTitle );
+                               // Added using template syntax, to take <noinclude>'s into account.
+                               $wgOut->addWikiTextTitleTidy( '{{:' . $title->getFullText() . '}}', $this->mTitle );
                                return true;
                        } else {
                                return false;
@@ -765,7 +823,7 @@ class EditPage {
         * @return one of the constants describing the result
         */
        function internalAttemptSave( &$result, $bot = false ) {
-               global $wgFilterCallback, $wgUser, $wgOut, $wgParser;
+               global $wgFilterCallback, $wgUser, $wgParser;
                global $wgMaxArticleSize;
 
                wfProfileIn( __METHOD__  );
@@ -773,6 +831,8 @@ class EditPage {
 
                if ( !wfRunHooks( 'EditPage::attemptSave', array( $this ) ) ) {
                        wfDebug( "Hook 'EditPage::attemptSave' aborted article saving\n" );
+                       wfProfileOut( __METHOD__ . '-checks' );
+                       wfProfileOut( __METHOD__  );
                        return self::AS_HOOK_ERROR;
                }
 
@@ -780,11 +840,12 @@ class EditPage {
                if ( $this->mTitle->getNamespace() == NS_FILE &&
                        Title::newFromRedirect( $this->textbox1 ) instanceof Title &&
                        !$wgUser->isAllowed( 'upload' ) ) {
-                               if ( $wgUser->isAnon() ) {
-                                       return self::AS_IMAGE_REDIRECT_ANON;
-                               } else {
-                                       return self::AS_IMAGE_REDIRECT_LOGGED;
-                               }
+                               $isAnon = $wgUser->isAnon();
+
+                               wfProfileOut( __METHOD__ . '-checks' );
+                               wfProfileOut( __METHOD__  );
+
+                               return $isAnon ? self::AS_IMAGE_REDIRECT_ANON : self::AS_IMAGE_REDIRECT_LOGGED;
                }
 
                # Check for spam
@@ -868,8 +929,10 @@ class EditPage {
                wfProfileOut( __METHOD__ . '-checks' );
 
                # If article is new, insert it.
-               $aid = $this->mTitle->getArticleID( GAID_FOR_UPDATE );
-               if ( 0 == $aid ) {
+               $aid = $this->mTitle->getArticleID( Title::GAID_FOR_UPDATE );
+               $new = ( $aid == 0 );
+
+               if ( $new ) {
                        // Late check for create permission, just in case *PARANOIA*
                        if ( !$this->mTitle->userCan( 'create' ) ) {
                                wfDebug( __METHOD__ . ": no create permission\n" );
@@ -903,145 +966,149 @@ class EditPage {
                                }
                        }
 
-                       $isComment = ( $this->section == 'new' );
+                       $text = $this->textbox1;
+                       if ( $this->section == 'new' && $this->summary != '' ) {
+                               $text = wfMsgForContent( 'newsectionheaderdefaultlevel', $this->summary ) . "\n\n" . $text;
+                       }
 
-                       $this->mArticle->insertNewArticle( $this->textbox1, $this->summary,
-                               $this->minoredit, $this->watchthis, false, $isComment, $bot );
+                       $retval = self::AS_SUCCESS_NEW_ARTICLE;
 
-                       wfProfileOut( __METHOD__ );
-                       return self::AS_SUCCESS_NEW_ARTICLE;
-               }
+               } else {
 
-               # Article exists. Check for edit conflict.
+                       # Article exists. Check for edit conflict.
 
-               $this->mArticle->clear(); # Force reload of dates, etc.
-               $this->mArticle->forUpdate( true ); # Lock the article
+                       $this->mArticle->clear(); # Force reload of dates, etc.
+                       $this->mArticle->forUpdate( true ); # Lock the article
 
-               wfDebug( "timestamp: {$this->mArticle->getTimestamp()}, edittime: {$this->edittime}\n" );
+                       wfDebug( "timestamp: {$this->mArticle->getTimestamp()}, edittime: {$this->edittime}\n" );
 
-               if ( $this->mArticle->getTimestamp() != $this->edittime ) {
-                       $this->isConflict = true;
-                       if ( $this->section == 'new' ) {
-                               if ( $this->mArticle->getUserText() == $wgUser->getName() &&
-                                       $this->mArticle->getComment() == $this->summary ) {
-                                       // Probably a duplicate submission of a new comment.
-                                       // This can happen when squid resends a request after
-                                       // a timeout but the first one actually went through.
-                                       wfDebug( __METHOD__ . ": duplicate new section submission; trigger edit conflict!\n" );
-                               } else {
-                                       // New comment; suppress conflict.
-                                       $this->isConflict = false;
-                                       wfDebug( __METHOD__ .": conflict suppressed; new section\n" );
+                       if ( $this->mArticle->getTimestamp() != $this->edittime ) {
+                               $this->isConflict = true;
+                               if ( $this->section == 'new' ) {
+                                       if ( $this->mArticle->getUserText() == $wgUser->getName() &&
+                                               $this->mArticle->getComment() == $this->summary ) {
+                                               // Probably a duplicate submission of a new comment.
+                                               // This can happen when squid resends a request after
+                                               // a timeout but the first one actually went through.
+                                               wfDebug( __METHOD__ . ": duplicate new section submission; trigger edit conflict!\n" );
+                                       } else {
+                                               // New comment; suppress conflict.
+                                               $this->isConflict = false;
+                                               wfDebug( __METHOD__ .": conflict suppressed; new section\n" );
+                                       }
                                }
                        }
-               }
-               $userid = $wgUser->getId();
+                       $userid = $wgUser->getId();
 
-               # Suppress edit conflict with self, except for section edits where merging is required.
-               if ( $this->isConflict && $this->section == '' && $this->userWasLastToEdit( $userid, $this->edittime ) ) {
-                       wfDebug( __METHOD__ . ": Suppressing edit conflict, same user.\n" );
-                       $this->isConflict = false;
-               }
-
-               if ( $this->isConflict ) {
-                       wfDebug( __METHOD__ . ": conflict! getting section '$this->section' for time '$this->edittime' (article time '" .
-                               $this->mArticle->getTimestamp() . "')\n" );
-                       $text = $this->mArticle->replaceSection( $this->section, $this->textbox1, $this->summary, $this->edittime );
-               } else {
-                       wfDebug( __METHOD__ . ": getting section '$this->section'\n" );
-                       $text = $this->mArticle->replaceSection( $this->section, $this->textbox1, $this->summary );
-               }
-               if ( is_null( $text ) ) {
-                       wfDebug( __METHOD__ . ": activating conflict; section replace failed.\n" );
-                       $this->isConflict = true;
-                       $text = $this->textbox1; // do not try to merge here!
-               } else if ( $this->isConflict ) {
-                       # Attempt merge
-                       if ( $this->mergeChangesInto( $text ) ) {
-                               // Successful merge! Maybe we should tell the user the good news?
+                       # Suppress edit conflict with self, except for section edits where merging is required.
+                       if ( $this->isConflict && $this->section == '' && $this->userWasLastToEdit( $userid, $this->edittime ) ) {
+                               wfDebug( __METHOD__ . ": Suppressing edit conflict, same user.\n" );
                                $this->isConflict = false;
-                               wfDebug( __METHOD__ . ": Suppressing edit conflict, successful merge.\n" );
-                       } else {
-                               $this->section = '';
-                               $this->textbox1 = $text;
-                               wfDebug( __METHOD__ . ": Keeping edit conflict, failed merge.\n" );
                        }
-               }
-
-               if ( $this->isConflict ) {
-                       wfProfileOut( __METHOD__ );
-                       return self::AS_CONFLICT_DETECTED;
-               }
 
-               $oldtext = $this->mArticle->getContent();
-
-               // Run post-section-merge edit filter
-               if ( !wfRunHooks( 'EditFilterMerged', array( $this, $text, &$this->hookError, $this->summary ) ) ) {
-                       # Error messages etc. could be handled within the hook...
-                       wfProfileOut( __METHOD__ );
-                       return self::AS_HOOK_ERROR;
-               } elseif ( $this->hookError != '' ) {
-                       # ...or the hook could be expecting us to produce an error
-                       wfProfileOut( __METHOD__ );
-                       return self::AS_HOOK_ERROR_EXPECTED;
-               }
+                       if ( $this->isConflict ) {
+                               wfDebug( __METHOD__ . ": conflict! getting section '$this->section' for time '$this->edittime' (article time '" .
+                                       $this->mArticle->getTimestamp() . "')\n" );
+                               $text = $this->mArticle->replaceSection( $this->section, $this->textbox1, $this->summary, $this->edittime );
+                       } else {
+                               wfDebug( __METHOD__ . ": getting section '$this->section'\n" );
+                               $text = $this->mArticle->replaceSection( $this->section, $this->textbox1, $this->summary );
+                       }
+                       if ( is_null( $text ) ) {
+                               wfDebug( __METHOD__ . ": activating conflict; section replace failed.\n" );
+                               $this->isConflict = true;
+                               $text = $this->textbox1; // do not try to merge here!
+                       } else if ( $this->isConflict ) {
+                               # Attempt merge
+                               if ( $this->mergeChangesInto( $text ) ) {
+                                       // Successful merge! Maybe we should tell the user the good news?
+                                       $this->isConflict = false;
+                                       wfDebug( __METHOD__ . ": Suppressing edit conflict, successful merge.\n" );
+                               } else {
+                                       $this->section = '';
+                                       $this->textbox1 = $text;
+                                       wfDebug( __METHOD__ . ": Keeping edit conflict, failed merge.\n" );
+                               }
+                       }
 
-               # Handle the user preference to force summaries here, but not for null edits
-               if ( $this->section != 'new' && !$this->allowBlankSummary && 0 != strcmp( $oldtext, $text )
-                       && !Title::newFromRedirect( $text ) ) # check if it's not a redirect
-               {
-                       if ( md5( $this->summary ) == $this->autoSumm ) {
-                               $this->missingSummary = true;
+                       if ( $this->isConflict ) {
                                wfProfileOut( __METHOD__ );
-                               return self::AS_SUMMARY_NEEDED;
+                               return self::AS_CONFLICT_DETECTED;
                        }
-               }
 
-               # And a similar thing for new sections
-               if ( $this->section == 'new' && !$this->allowBlankSummary ) {
-                       if ( trim( $this->summary ) == '' ) {
-                               $this->missingSummary = true;
+                       $oldtext = $this->mArticle->getContent();
+
+                       // Run post-section-merge edit filter
+                       if ( !wfRunHooks( 'EditFilterMerged', array( $this, $text, &$this->hookError, $this->summary ) ) ) {
+                               # Error messages etc. could be handled within the hook...
+                               wfProfileOut( __METHOD__ );
+                               return self::AS_HOOK_ERROR;
+                       } elseif ( $this->hookError != '' ) {
+                               # ...or the hook could be expecting us to produce an error
                                wfProfileOut( __METHOD__ );
-                               return self::AS_SUMMARY_NEEDED;
+                               return self::AS_HOOK_ERROR_EXPECTED;
                        }
-               }
 
-               # All's well
-               wfProfileIn( __METHOD__ . '-sectionanchor' );
-               $sectionanchor = '';
-               if ( $this->section == 'new' ) {
-                       if ( $this->textbox1 == '' ) {
-                               $this->missingComment = true;
-                               wfProfileOut( __METHOD__ . '-sectionanchor' );
-                               wfProfileOut( __METHOD__ );
-                               return self::AS_TEXTBOX_EMPTY;
+                       # Handle the user preference to force summaries here, but not for null edits
+                       if ( $this->section != 'new' && !$this->allowBlankSummary && 0 != strcmp( $oldtext, $text )
+                               && !Title::newFromRedirect( $text ) ) # check if it's not a redirect
+                       {
+                               if ( md5( $this->summary ) == $this->autoSumm ) {
+                                       $this->missingSummary = true;
+                                       wfProfileOut( __METHOD__ );
+                                       return self::AS_SUMMARY_NEEDED;
+                               }
                        }
-                       if ( $this->summary != '' ) {
-                               $sectionanchor = $wgParser->guessSectionNameFromWikiText( $this->summary );
-                               # This is a new section, so create a link to the new section
-                               # in the revision summary.
-                               $cleanSummary = $wgParser->stripSectionName( $this->summary );
-                               $this->summary = wfMsgForContent( 'newsectionsummary', $cleanSummary );
+
+                       # And a similar thing for new sections
+                       if ( $this->section == 'new' && !$this->allowBlankSummary ) {
+                               if ( trim( $this->summary ) == '' ) {
+                                       $this->missingSummary = true;
+                                       wfProfileOut( __METHOD__ );
+                                       return self::AS_SUMMARY_NEEDED;
+                               }
                        }
-               } elseif ( $this->section != '' ) {
-                       # Try to get a section anchor from the section source, redirect to edited section if header found
-                       # XXX: might be better to integrate this into Article::replaceSection
-                       # for duplicate heading checking and maybe parsing
-                       $hasmatch = preg_match( "/^ *([=]{1,6})(.*?)(\\1) *\\n/i", $this->textbox1, $matches );
-                       # we can't deal with anchors, includes, html etc in the header for now,
-                       # headline would need to be parsed to improve this
-                       if ( $hasmatch and strlen( $matches[2] ) > 0 ) {
-                               $sectionanchor = $wgParser->guessSectionNameFromWikiText( $matches[2] );
+
+                       # All's well
+                       wfProfileIn( __METHOD__ . '-sectionanchor' );
+                       $sectionanchor = '';
+                       if ( $this->section == 'new' ) {
+                               if ( $this->textbox1 == '' ) {
+                                       $this->missingComment = true;
+                                       wfProfileOut( __METHOD__ . '-sectionanchor' );
+                                       wfProfileOut( __METHOD__ );
+                                       return self::AS_TEXTBOX_EMPTY;
+                               }
+                               if ( $this->summary != '' ) {
+                                       $sectionanchor = $wgParser->guessLegacySectionNameFromWikiText( $this->summary );
+                                       # This is a new section, so create a link to the new section
+                                       # in the revision summary.
+                                       $cleanSummary = $wgParser->stripSectionName( $this->summary );
+                                       $this->summary = wfMsgForContent( 'newsectionsummary', $cleanSummary );
+                               }
+                       } elseif ( $this->section != '' ) {
+                               # Try to get a section anchor from the section source, redirect to edited section if header found
+                               # XXX: might be better to integrate this into Article::replaceSection
+                               # for duplicate heading checking and maybe parsing
+                               $hasmatch = preg_match( "/^ *([=]{1,6})(.*?)(\\1) *\\n/i", $this->textbox1, $matches );
+                               # we can't deal with anchors, includes, html etc in the header for now,
+                               # headline would need to be parsed to improve this
+                               if ( $hasmatch and strlen( $matches[2] ) > 0 ) {
+                                       $sectionanchor = $wgParser->guessLegacySectionNameFromWikiText( $matches[2] );
+                               }
                        }
-               }
-               wfProfileOut( __METHOD__ . '-sectionanchor' );
+                       $result['sectionanchor'] = $sectionanchor;
+                       wfProfileOut( __METHOD__ . '-sectionanchor' );
+
+                       // Save errors may fall down to the edit form, but we've now
+                       // merged the section into full text. Clear the section field
+                       // so that later submission of conflict forms won't try to
+                       // replace that into a duplicated mess.
+                       $this->textbox1 = $text;
+                       $this->section = '';
 
-               // Save errors may fall down to the edit form, but we've now
-               // merged the section into full text. Clear the section field
-               // so that later submission of conflict forms won't try to
-               // replace that into a duplicated mess.
-               $this->textbox1 = $text;
-               $this->section = '';
+                       $retval = self::AS_SUCCESS_UPDATE;
+               }
 
                // Check for length errors again now that the section is merged in
                $this->kblength = (int)( strlen( $text ) / 1024 );
@@ -1051,17 +1118,39 @@ class EditPage {
                        return self::AS_MAX_ARTICLE_SIZE_EXCEEDED;
                }
 
-               # update the article here
-               if ( $this->mArticle->updateArticle( $text, $this->summary, $this->minoredit,
-                       $this->watchthis, $bot, $sectionanchor ) )
-               {
+               $flags = EDIT_DEFER_UPDATES | EDIT_AUTOSUMMARY |
+                       ( $new ? EDIT_NEW : EDIT_UPDATE ) |
+                       ( $this->minoredit ? EDIT_MINOR : 0 ) |
+                       ( $bot ? EDIT_FORCE_BOT : 0 );
+
+               $status = $this->mArticle->doEdit( $text, $this->summary, $flags );
+
+               if ( $status->isOK() ) {
+                       $result['redirect'] = Title::newFromRedirect( $text ) !== null;
+                       $this->commitWatch();
                        wfProfileOut( __METHOD__ );
-                       return self::AS_SUCCESS_UPDATE;
+                       return $retval;
                } else {
                        $this->isConflict = true;
+                       wfProfileOut( __METHOD__ );
+                       return self::AS_END;
+               }
+       }
+
+       /**
+        * Commit the change of watch status
+        */
+       protected function commitWatch() {
+               if ( $this->watchthis xor $this->mTitle->userIsWatching() ) {
+                       $dbw = wfGetDB( DB_MASTER );
+                       $dbw->begin();
+                       if ( $this->watchthis ) {
+                               $this->mArticle->doWatch();
+                       } else {
+                               $this->mArticle->doUnwatch();
+                       }
+                       $dbw->commit();
                }
-               wfProfileOut( __METHOD__ );
-               return self::AS_END;
        }
 
        /**
@@ -1080,7 +1169,7 @@ class EditPage {
                        ),
                        __METHOD__,
                        array( 'ORDER BY' => 'rev_timestamp ASC', 'LIMIT' => 50 ) );
-               while( $row = $res->fetchObject() ) {
+               foreach ( $res as $row ) {
                        if( $row->rev_user != $id ) {
                                return false;
                        }
@@ -1147,23 +1236,23 @@ class EditPage {
        }
 
        function setHeaders() {
-               global $wgOut, $wgTitle;
+               global $wgOut;
                $wgOut->setRobotPolicy( 'noindex,nofollow' );
                if ( $this->formtype == 'preview' ) {
                        $wgOut->setPageTitleActionText( wfMsg( 'preview' ) );
                }
                if ( $this->isConflict ) {
-                       $wgOut->setPageTitle( wfMsg( 'editconflict', $wgTitle->getPrefixedText() ) );
+                       $wgOut->setPageTitle( wfMsg( 'editconflict', $this->getContextTitle()->getPrefixedText() ) );
                } elseif ( $this->section != '' ) {
                        $msg = $this->section == 'new' ? 'editingcomment' : 'editingsection';
-                       $wgOut->setPageTitle( wfMsg( $msg, $wgTitle->getPrefixedText() ) );
+                       $wgOut->setPageTitle( wfMsg( $msg, $this->getContextTitle()->getPrefixedText() ) );
                } else {
                        # Use the title defined by DISPLAYTITLE magic word when present
                        if ( isset( $this->mParserOutput )
                         && ( $dt = $this->mParserOutput->getDisplayTitle() ) !== false ) {
                                $title = $dt;
                        } else {
-                               $title = $wgTitle->getPrefixedText();
+                               $title = $this->getContextTitle()->getPrefixedText();
                        }
                        $wgOut->setPageTitle( wfMsg( 'editing', $title ) );
                }
@@ -1175,15 +1264,8 @@ class EditPage {
         *                      parameter; will be called during form output
         *                      near the top, for captchas and the like.
         */
-       function showEditForm( $formCallback=null ) {
-               global $wgOut, $wgUser, $wgTitle;
-
-               # If $wgTitle is null, that means we're in API mode.
-               # Some hook probably called this function  without checking
-               # for is_null($wgTitle) first. Bail out right here so we don't
-               # do lots of work just to discard it right after.
-               if ( is_null( $wgTitle ) )
-                       return;
+       function showEditForm( $formCallback = null ) {
+               global $wgOut, $wgUser;
 
                wfProfileIn( __METHOD__ );
 
@@ -1205,10 +1287,12 @@ class EditPage {
                # Enabled article-related sidebar, toplinks, etc.
                $wgOut->setArticleRelated( true );
 
-               if ( $this->showHeader() === false )
+               if ( $this->showHeader() === false ) {
+                       wfProfileOut( __METHOD__ );
                        return;
+               }
 
-               $action = htmlspecialchars($this->getActionURL($wgTitle));
+               $action = htmlspecialchars( $this->getActionURL( $this->getContextTitle() ) );
 
                if ( $wgUser->getOption( 'showtoolbar' ) and !$this->isCssJsSubpage ) {
                        # prepare toolbar for edit buttons
@@ -1234,7 +1318,7 @@ class EditPage {
 
                if ( $this->wasDeletedSinceLastEdit() && 'save' != $this->formtype ) {
                        $wgOut->wrapWikiMsg(
-                               "<div class='error mw-deleted-while-editing'>\n$1</div>",
+                               "<div class='error mw-deleted-while-editing'>\n$1\n</div>",
                                'deletedwhileediting' );
                } elseif ( $this->wasDeletedSinceLastEdit() ) {
                        // Hide the toolbar and edit area, user can click preview to get it back
@@ -1258,9 +1342,14 @@ HTML
                $this->showFormBeforeText();
 
                if ( $this->wasDeletedSinceLastEdit() && 'save' == $this->formtype ) {
+                       $username = $this->lastDelete->user_name;
+                       $comment = $this->lastDelete->log_comment;
+
+                       // It is better to not parse the comment at all than to have templates expanded in the middle
+                       // TODO: can the checkLabel be moved outside of the div so that wrapWikiMsg could be used?
                        $wgOut->addHTML(
                                '<div class="mw-confirm-recreate">' .
-                               $wgOut->parse( wfMsg( 'confirmrecreate',  $this->lastDelete->user_name , $this->lastDelete->log_comment ) ) .
+                               wfMsgExt( 'confirmrecreate', 'parseinline', $username, "<nowiki>$comment</nowiki>" ) .
                                Xml::checkLabel( wfMsg( 'recreate' ), 'wpRecreate', 'wpRecreate', false,
                                        array( 'title' => $sk->titleAttrib( 'recreate' ), 'tabindex' => 1, 'id' => 'wpRecreate' )
                                ) .
@@ -1277,11 +1366,11 @@ HTML
                # automatic one and pass that in the hidden field wpAutoSummary.
                if ( $this->missingSummary ||
                        ( $this->section == 'new' && $this->nosummary ) )
-                               $wgOut->addHTML( Xml::hidden( 'wpIgnoreBlankSummary', true ) );
+                               $wgOut->addHTML( Html::hidden( 'wpIgnoreBlankSummary', true ) );
                $autosumm = $this->autoSumm ? $this->autoSumm : md5( $this->summary );
-               $wgOut->addHTML( Xml::hidden( 'wpAutoSummary', $autosumm ) );
+               $wgOut->addHTML( Html::hidden( 'wpAutoSummary', $autosumm ) );
 
-               $wgOut->addHTML( Xml::hidden( 'oldid', $this->mArticle->getOldID() ) );
+               $wgOut->addHTML( Html::hidden( 'oldid', $this->mArticle->getOldID() ) );
 
                if ( $this->section == 'new' ) {
                        $this->showSummaryInput( true, $this->summary );
@@ -1289,13 +1378,13 @@ HTML
                }
 
                $wgOut->addHTML( $this->editFormTextBeforeContent );
-               
+
                if ( $this->isConflict ) {
                        // In an edit conflict bypass the overrideable content form method
                        // and fallback to the raw wpTextbox1 since editconflicts can't be
                        // resolved between page source edits and custom ui edits using the
                        // custom edit ui.
-                       $this->showTextbox1();
+                       $this->showTextbox1( null, $this->getContent() );
                } else {
                        $this->showContentForm();
                }
@@ -1326,7 +1415,7 @@ HTML
 
                if ( $this->isConflict )
                        $this->showConflict();
-               
+
                $wgOut->addHTML( $this->editFormTextBottom );
                $wgOut->addHTML( "</form>\n" );
                if ( !$wgUser->getOption( 'previewontop' ) ) {
@@ -1335,11 +1424,11 @@ HTML
 
                wfProfileOut( __METHOD__ );
        }
-       
+
        protected function showHeader() {
-               global $wgOut, $wgUser, $wgTitle, $wgMaxArticleSize, $wgLang;
+               global $wgOut, $wgUser, $wgMaxArticleSize, $wgLang;
                if ( $this->isConflict ) {
-                       $wgOut->wrapWikiMsg( "<div class='mw-explainconflict'>\n$1</div>", 'explainconflict' );
+                       $wgOut->wrapWikiMsg( "<div class='mw-explainconflict'>\n$1\n</div>", 'explainconflict' );
                        $this->edittime = $this->mArticle->getTimestamp();
                } else {
                        if ( $this->section != '' && !$this->isSectionEditSupported() ) {
@@ -1364,15 +1453,15 @@ HTML
                        }
 
                        if ( $this->missingComment ) {
-                               $wgOut->wrapWikiMsg( "<div id='mw-missingcommenttext'>\n$1</div>", 'missingcommenttext' );
+                               $wgOut->wrapWikiMsg( "<div id='mw-missingcommenttext'>\n$1\n</div>", 'missingcommenttext' );
                        }
 
                        if ( $this->missingSummary && $this->section != 'new' ) {
-                               $wgOut->wrapWikiMsg( "<div id='mw-missingsummary'>\n$1</div>", 'missingsummary' );
+                               $wgOut->wrapWikiMsg( "<div id='mw-missingsummary'>\n$1\n</div>", 'missingsummary' );
                        }
 
                        if ( $this->missingSummary && $this->section == 'new' ) {
-                               $wgOut->wrapWikiMsg( "<div id='mw-missingcommentheader'>\n$1</div>", 'missingcommentheader' );
+                               $wgOut->wrapWikiMsg( "<div id='mw-missingcommentheader'>\n$1\n</div>", 'missingcommentheader' );
                        }
 
                        if ( $this->hookError !== '' ) {
@@ -1387,9 +1476,9 @@ HTML
                        // Let sysop know that this will make private content public if saved
 
                                if ( !$this->mArticle->mRevision->userCan( Revision::DELETED_TEXT ) ) {
-                                       $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1</div>\n", 'rev-deleted-text-permission' );
+                                       $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1\n</div>\n", 'rev-deleted-text-permission' );
                                } else if ( $this->mArticle->mRevision->isDeleted( Revision::DELETED_TEXT ) ) {
-                                       $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1</div>\n", 'rev-deleted-text-view' );
+                                       $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1\n</div>\n", 'rev-deleted-text-view' );
                                }
 
                                if ( !$this->mArticle->mRevision->isCurrent() ) {
@@ -1401,19 +1490,23 @@ HTML
 
                if ( wfReadOnly() ) {
                        $wgOut->wrapWikiMsg( "<div id=\"mw-read-only-warning\">\n$1\n</div>", array( 'readonlywarning', wfReadOnlyReason() ) );
-               } elseif ( $wgUser->isAnon() && $this->formtype != 'preview' ) {
-                       $wgOut->wrapWikiMsg( "<div id=\"mw-anon-edit-warning\">\n$1</div>", 'anoneditwarning' );
+               } elseif ( $wgUser->isAnon() ) {
+                       if ( $this->formtype != 'preview' ) {
+                               $wgOut->wrapWikiMsg( "<div id=\"mw-anon-edit-warning\">\n$1</div>", 'anoneditwarning' );
+                       } else {
+                               $wgOut->wrapWikiMsg( "<div id=\"mw-anon-preview-warning\">\n$1</div>", 'anonpreviewwarning' );
+                       }
                } else {
                        if ( $this->isCssJsSubpage ) {
                                # Check the skin exists
-                               if ( !$this->isValidCssJsSubpage ) {
-                                       $wgOut->addWikiMsg( 'userinvalidcssjstitle', $wgTitle->getSkinFromCssJsSubpage() );
+                               if ( $this->isWrongCaseCssJsPage ) {
+                                       $wgOut->wrapWikiMsg( "<div class='error' id='mw-userinvalidcssjstitle'>\n$1\n</div>", array( 'userinvalidcssjstitle', $this->getContextTitle()->getSkinFromCssJsSubpage() ) );
                                }
                                if ( $this->formtype !== 'preview' ) {
                                        if ( $this->isCssSubpage )
-                                               $wgOut->addWikiMsg( 'usercssyoucanpreview' );
+                                               $wgOut->wrapWikiMsg( "<div id='mw-usercssyoucanpreview'>\n$1\n</div>", array( 'usercssyoucanpreview' ) );
                                        if ( $this->isJsSubpage )
-                                               $wgOut->addWikiMsg( 'userjsyoucanpreview' );
+                                               $wgOut->wrapWikiMsg( "<div id='mw-userjsyoucanpreview'>\n$1\n</div>", array( 'userjsyoucanpreview' ) );
                                }
                        }
                }
@@ -1456,13 +1549,14 @@ HTML
                }
 
                if ( $this->tooBig || $this->kblength > $wgMaxArticleSize ) {
-                       $wgOut->addHTML( "<div class='error' id='mw-edit-longpageerror'>\n" );
-                       $wgOut->addWikiMsg( 'longpageerror', $wgLang->formatNum( $this->kblength ), $wgLang->formatNum( $wgMaxArticleSize ) );
-                       $wgOut->addHTML( "</div>\n" );
-               } elseif ( $this->kblength > 29 ) {
-                       $wgOut->addHTML( "<div id='mw-edit-longpagewarning'>\n" );
-                       $wgOut->addWikiMsg( 'longpagewarning', $wgLang->formatNum( $this->kblength ) );
-                       $wgOut->addHTML( "</div>\n" );
+                       $wgOut->wrapWikiMsg( "<div class='error' id='mw-edit-longpageerror'>\n$1\n</div>",
+                               array( 'longpageerror', $wgLang->formatNum( $this->kblength ), $wgLang->formatNum( $wgMaxArticleSize ) ) );
+               } else {
+                       if( !wfMessage('longpage-hint')->isDisabled() ) {
+                               $wgOut->wrapWikiMsg( "<div id='mw-edit-longpage-hint'>\n$1\n</div>",
+                                       array( 'longpage-hint', $wgLang->formatSize( strlen( $this->textbox1 ) ), strlen( $this->textbox1 ) )
+                               );
+                       }
                }
        }
 
@@ -1472,23 +1566,25 @@ HTML
         * Note that you do not need to worry about the label's for=, it will be
         * inferred by the id given to the input. You can remove them both by
         * passing array( 'id' => false ) to $userInputAttrs.
-        * 
+        *
         * @param $summary The value of the summary input
         * @param $labelText The html to place inside the label
         * @param $inputAttrs An array of attrs to use on the input
         * @param $spanLabelAttrs An array of attrs to use on the span inside the label
-        * 
+        *
         * @return array An array in the format array( $label, $input )
         */
        function getSummaryInput($summary = "", $labelText = null, $inputAttrs = null, $spanLabelAttrs = null) {
+               global $wgUser;
+               //Note: the maxlength is overriden in JS to 250 and to make it use UTF-8 bytes, not characters.
                $inputAttrs = ( is_array($inputAttrs) ? $inputAttrs : array() ) + array(
                        'id' => 'wpSummary',
                        'maxlength' => '200',
                        'tabindex' => '1',
                        'size' => 60,
                        'spellcheck' => 'true',
-               );
-               
+               ) + $wgUser->getSkin()->tooltipAndAccessKeyAttribs( 'summary' );
+
                $spanLabelAttrs = ( is_array($spanLabelAttrs) ? $spanLabelAttrs : array() ) + array(
                        'class' => $this->missingSummary ? 'mw-summarymissed' : 'mw-summary',
                        'id' => "wpSummaryLabel"
@@ -1539,32 +1635,34 @@ HTML
        protected function getSummaryPreview( $isSubjectPreview, $summary = "" ) {
                if ( !$summary || ( !$this->preview && !$this->diff ) )
                        return "";
-               
+
                global $wgParser, $wgUser;
                $sk = $wgUser->getSkin();
-               
+
                if ( $isSubjectPreview )
                        $summary = wfMsgForContent( 'newsectionsummary', $wgParser->stripSectionName( $summary ) );
 
-               $summary = wfMsgExt( 'subject-preview', 'parseinline' ) . $sk->commentBlock( $summary, $this->mTitle, !!$isSubjectPreview );
+               $message = $isSubjectPreview ? 'subject-preview' : 'summary-preview';
+
+               $summary = wfMsgExt( $message, 'parseinline' ) . $sk->commentBlock( $summary, $this->mTitle, $isSubjectPreview );
                return Xml::tags( 'div', array( 'class' => 'mw-summary-preview' ), $summary );
        }
 
        protected function showFormBeforeText() {
                global $wgOut;
                $section = htmlspecialchars( $this->section );
-               $wgOut->addHTML( <<<INPUTS
+               $wgOut->addHTML( <<<HTML
 <input type='hidden' value="{$section}" name="wpSection" />
 <input type='hidden' value="{$this->starttime}" name="wpStarttime" />
 <input type='hidden' value="{$this->edittime}" name="wpEdittime" />
 <input type='hidden' value="{$this->scrolltop}" name="wpScrolltop" id="wpScrolltop" />
 
-INPUTS
+HTML
                );
                if ( !$this->checkUnicodeCompliantBrowser() )
-                       $wgOut->addHTML(Xml::hidden( 'safemode', '1' ));
+                       $wgOut->addHTML(Html::hidden( 'safemode', '1' ));
        }
-       
+
        protected function showFormAfterText() {
                global $wgOut, $wgUser;
                /**
@@ -1579,7 +1677,7 @@ INPUTS
                 * include the constant suffix to prevent editing from
                 * broken text-mangling proxies.
                 */
-               $wgOut->addHTML( "\n" . Xml::hidden( "wpEditToken", $wgUser->editToken() ) . "\n" );
+               $wgOut->addHTML( "\n" . Html::hidden( "wpEditToken", $wgUser->editToken() ) . "\n" );
        }
 
        /**
@@ -1589,8 +1687,6 @@ INPUTS
         * be it a form, or simply wpTextbox1 with a modified content that will be
         * reverse modified when extracted from the post data.
         * Note that this is basically the inverse for importContentFormData
-        * 
-        * @param $request WebRequest
         */
        protected function showContentForm() {
                $this->showTextbox1();
@@ -1600,7 +1696,7 @@ INPUTS
         * Method to output wpTextbox1
         * The $textoverride method can be used by subclasses overriding showContentForm
         * to pass back to this method.
-        * 
+        *
         * @param $customAttribs An array of html attributes to use in the textarea
         * @param $textoverride String: optional text to override $this->textarea1 with
         */
@@ -1626,7 +1722,7 @@ INPUTS
                                $classes[] = $attribs['class'];
                        $attribs['class'] = implode( ' ', $classes );
                }
-               
+
                $this->showTextbox( isset($textoverride) ? $textoverride : $this->textbox1, 'wpTextbox1', $attribs );
        }
 
@@ -1649,14 +1745,11 @@ INPUTS
                $attribs = $customAttribs + array(
                        'accesskey' => ',',
                        'id'   => $name,
-                       'cols' => $wgUser->getIntOption( 'cols' ), 
+                       'cols' => $wgUser->getIntOption( 'cols' ),
                        'rows' => $wgUser->getIntOption( 'rows' ),
-                       'style' => '' // avoid php notices when appending for editwidth preference (appending allows customAttribs['style'] to still work
+                       'style' => '' // avoid php notices when appending preferences (appending allows customAttribs['style'] to still work
                );
 
-               if ( $wgUser->getOption( 'editwidth' ) )
-                       $attribs['style'] .= 'width: 100%';
-
                $wgOut->addHTML( Html::textarea( $name, $wikitext, $attribs ) );
        }
 
@@ -1708,15 +1801,14 @@ INPUTS
         * Give a chance for site and per-namespace customizations of
         * terms of service summary link that might exist separately
         * from the copyright notice.
-        * 
+        *
         * This will display between the save button and the edit tools,
         * so should remain short!
         */
        protected function showTosSummary() {
                $msg = 'editpage-tos-summary';
                wfRunHooks( 'EditPageTosSummary', array( $this->mTitle, &$msg ) );
-               $text = wfMsg( $msg );
-               if( !wfEmptyMsg( $msg, $text ) && $text !== '-' ) {
+               if( !wfMessage( $msg )->isDisabled() ) {
                        global $wgOut;
                        $wgOut->addHTML( '<div class="mw-tos-summary">' );
                        $wgOut->addWikiMsgArray( $msg, array() );
@@ -1730,7 +1822,7 @@ INPUTS
                $wgOut->addWikiMsgArray( 'edittools', array(), array( 'content' ) );
                $wgOut->addHTML( '</div>' );
        }
-       
+
        protected function getCopywarn() {
                global $wgRightsText;
                if ( $wgRightsText ) {
@@ -1743,10 +1835,11 @@ INPUTS
                }
                // Allow for site and per-namespace customization of contribution/copyright notice.
                wfRunHooks( 'EditPageCopyrightWarning', array( $this->mTitle, &$copywarnMsg ) );
-               
-               return "<div id=\"editpage-copywarn\">\n" . call_user_func_array("wfMsgNoTrans", $copywarnMsg) . "\n</div>";
+
+               return "<div id=\"editpage-copywarn\">\n" .
+                       call_user_func_array("wfMsgNoTrans", $copywarnMsg) . "\n</div>";
        }
-       
+
        protected function showStandardInputs( &$tabindex = 2 ) {
                global $wgOut, $wgUser;
                $wgOut->addHTML( "<div class='editOptions'>\n" );
@@ -1771,7 +1864,11 @@ INPUTS
                $wgOut->addHTML( "      <span class='editHelp'>{$cancel}{$separator}{$edithelp}</span>\n" );
                $wgOut->addHTML( "</div><!-- editButtons -->\n</div><!-- editOptions -->\n" );
        }
-       
+
+       /*
+        * Show an edit conflict. textbox1 is already shown in showEditForm().
+        * If you want to use another entry point to this function, be careful.
+        */
        protected function showConflict() {
                global $wgOut;
                $this->textbox2 = $this->textbox1;
@@ -1793,20 +1890,20 @@ INPUTS
                $data = $dbr->selectRow(
                        array( 'logging', 'user' ),
                        array( 'log_type',
-                              'log_action',
-                              'log_timestamp',
-                              'log_user',
-                              'log_namespace',
-                              'log_title',
-                              'log_comment',
-                              'log_params',
-                              'log_deleted',
-                              'user_name' ),
+                                  'log_action',
+                                  'log_timestamp',
+                                  'log_user',
+                                  'log_namespace',
+                                  'log_title',
+                                  'log_comment',
+                                  'log_params',
+                                  'log_deleted',
+                                  'user_name' ),
                        array( 'log_namespace' => $this->mTitle->getNamespace(),
-                              'log_title' => $this->mTitle->getDBkey(),
-                              'log_type' => 'delete',
-                              'log_action' => 'delete',
-                              'user_id=log_user' ),
+                                  'log_title' => $this->mTitle->getDBkey(),
+                                  'log_type' => 'delete',
+                                  'log_action' => 'delete',
+                                  'user_id=log_user' ),
                        __METHOD__,
                        array( 'LIMIT' => 1, 'ORDER BY' => 'log_timestamp DESC' )
                );
@@ -1825,7 +1922,7 @@ INPUTS
         * @return string
         */
        function getPreviewText() {
-               global $wgOut, $wgUser, $wgTitle, $wgParser, $wgLang, $wgContLang, $wgMessageCache;
+               global $wgOut, $wgUser, $wgParser;
 
                wfProfileIn( __METHOD__ );
 
@@ -1835,6 +1932,8 @@ INPUTS
                        } else {
                                $note = wfMsg( 'session_fail_preview' );
                        }
+               } else if ( $this->incompleteForm ) {
+                       $note = wfMsg( 'edit_form_incomplete' );
                } else {
                        $note = wfMsg( 'previewnote' );
                }
@@ -1848,54 +1947,71 @@ INPUTS
                if ( $wgRawHtml && !$this->mTokenOk ) {
                        // Could be an offsite preview attempt. This is very unsafe if
                        // HTML is enabled, as it could be an attack.
-                       return $wgOut->parse( "<div class='previewnote'>" .
+                       $parsedNote = $wgOut->parse( "<div class='previewnote'>" .
                                wfMsg( 'session_fail_preview_html' ) . "</div>" );
+                       wfProfileOut( __METHOD__ );
+                       return $parsedNote;
                }
 
                # don't parse user css/js, show message about preview
-               # XXX: stupid php bug won't let us use $wgTitle->isCssJsSubpage() here
+               # XXX: stupid php bug won't let us use $this->getContextTitle()->isCssJsSubpage() here -- This note has been there since r3530. Sure the bug was fixed time ago?
+
+               if ( $this->isCssJsSubpage || $this->mTitle->isCssOrJsPage() ) {
+                       $level = 'user';
+                       if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
+                               $level = 'site';
+                       }
 
-               if ( $this->isCssJsSubpage ) {
+                       # Used messages to make sure grep find them:
+                       # Messages: usercsspreview, userjspreview, sitecsspreview, sitejspreview
                        if (preg_match( "/\\.css$/", $this->mTitle->getText() ) ) {
-                               $previewtext = wfMsg( 'usercsspreview' );
-                       } else if (preg_match( "/\\.js$/", $this->mTitle->getText() ) ) {
-                               $previewtext = wfMsg( 'userjspreview' );
+                               $previewtext = "<div id='mw-{$level}csspreview'>\n" . wfMsg( "{$level}csspreview" ) . "\n</div>";
+                               $class = "mw-code mw-css";
+                       } elseif (preg_match( "/\\.js$/", $this->mTitle->getText() ) ) {
+                               $previewtext = "<div id='mw-{$level}jspreview'>\n" . wfMsg( "{$level}jspreview" ) . "\n</div>";
+                               $class = "mw-code mw-js";
+                       } else {
+                               throw new MWException( 'A CSS/JS (sub)page but which is not css nor js!' );
                        }
+
                        $parserOptions->setTidy( true );
                        $parserOutput = $wgParser->parse( $previewtext, $this->mTitle, $parserOptions );
                        $previewHTML = $parserOutput->mText;
-               } elseif ( $rt = Title::newFromRedirectArray( $this->textbox1 ) ) {
-                       $previewHTML = $this->mArticle->viewRedirect( $rt, false );
+                       $previewHTML .= "<pre class=\"$class\" dir=\"ltr\">\n" . htmlspecialchars( $this->textbox1 ) . "\n</pre>\n";
                } else {
-                       $toparse = $this->textbox1;
-
-                       # If we're adding a comment, we need to show the
-                       # summary as the headline
-                       if ( $this->section == "new" && $this->summary != "" ) {
-                               $toparse = "== {$this->summary} ==\n\n" . $toparse;
-                       }
+                       $rt = Title::newFromRedirectArray( $this->textbox1 );
+                       if ( $rt ) {
+                               $previewHTML = $this->mArticle->viewRedirect( $rt, false );
+                       } else {
+                               $toparse = $this->textbox1;
 
-                       wfRunHooks( 'EditPageGetPreviewText', array( $this, &$toparse ) );
+                               # If we're adding a comment, we need to show the
+                               # summary as the headline
+                               if ( $this->section == "new" && $this->summary != "" ) {
+                                       $toparse = "== {$this->summary} ==\n\n" . $toparse;
+                               }
 
-                       // Parse mediawiki messages with correct target language
-                       if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
-                               list( /* $unused */, $lang ) = $wgMessageCache->figureMessage( $this->mTitle->getText() );
-                               $obj = wfGetLangObj( $lang );
-                               $parserOptions->setTargetLanguage( $obj );
-                       }
+                               wfRunHooks( 'EditPageGetPreviewText', array( $this, &$toparse ) );
 
+                               // Parse mediawiki messages with correct target language
+                               if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
+                                       list( /* $unused */, $lang ) = MessageCache::singleton()->figureMessage( $this->mTitle->getText() );
+                                       $obj = wfGetLangObj( $lang );
+                                       $parserOptions->setTargetLanguage( $obj );
+                               }
 
-                       $parserOptions->setTidy( true );
-                       $parserOptions->enableLimitReport();
-                       $parserOutput = $wgParser->parse( $this->mArticle->preSaveTransform( $toparse ),
+                               $parserOptions->setTidy( true );
+                               $parserOptions->enableLimitReport();
+                               $parserOutput = $wgParser->parse( $this->mArticle->preSaveTransform( $toparse ),
                                        $this->mTitle, $parserOptions );
 
-                       $previewHTML = $parserOutput->getText();
-                       $this->mParserOutput = $parserOutput;
-                       $wgOut->addParserOutputNoText( $parserOutput );
+                               $previewHTML = $parserOutput->getText();
+                               $this->mParserOutput = $parserOutput;
+                               $wgOut->addParserOutputNoText( $parserOutput );
 
-                       if ( count( $parserOutput->getWarnings() ) ) {
-                               $note .= "\n\n" . implode( "\n\n", $parserOutput->getWarnings() );
+                               if ( count( $parserOutput->getWarnings() ) ) {
+                                       $note .= "\n\n" . implode( "\n\n", $parserOutput->getWarnings() );
+                               }
                        }
                }
 
@@ -1956,7 +2072,7 @@ INPUTS
         * Produce the stock "please login to edit pages" page
         */
        function userNotLoggedInPage() {
-               global $wgUser, $wgOut, $wgTitle;
+               global $wgUser, $wgOut;
                $skin = $wgUser->getSkin();
 
                $loginTitle = SpecialPage::getTitleFor( 'Userlogin' );
@@ -1964,7 +2080,7 @@ INPUTS
                        $loginTitle,
                        wfMsgHtml( 'loginreqlink' ),
                        array(),
-                       array( 'returnto' => $wgTitle->getPrefixedText() ),
+                       array( 'returnto' => $this->getContextTitle()->getPrefixedText() ),
                        array( 'known', 'noclasses' )
                );
 
@@ -1972,8 +2088,8 @@ INPUTS
                $wgOut->setRobotPolicy( 'noindex,nofollow' );
                $wgOut->setArticleRelated( false );
 
-               $wgOut->addHTML( wfMsgWikiHtml( 'whitelistedittext', $loginLink ) );
-               $wgOut->returnToMain( false, $wgTitle );
+               $wgOut->addWikiMsgArray( 'whitelistedittext', array( $loginLink ), array( 'replaceafter' ) );
+               $wgOut->returnToMain( false, $this->getContextTitle() );
        }
 
        /**
@@ -1998,8 +2114,9 @@ INPUTS
         * Produce the stock "your edit contains spam" page
         *
         * @param $match Text which triggered one or more filters
+        * @deprecated Use method spamPageWithContent() instead
         */
-       function spamPage( $match = false ) {
+       static function spamPage( $match = false ) {
                global $wgOut, $wgTitle;
 
                $wgOut->setPageTitle( wfMsg( 'spamprotectiontitle' ) );
@@ -2008,13 +2125,46 @@ INPUTS
 
                $wgOut->addHTML( '<div id="spamprotected">' );
                $wgOut->addWikiMsg( 'spamprotectiontext' );
-               if ( $match )
+               if ( $match ) {
                        $wgOut->addWikiMsg( 'spamprotectionmatch', wfEscapeWikiText( $match ) );
+               }
                $wgOut->addHTML( '</div>' );
 
                $wgOut->returnToMain( false, $wgTitle );
        }
 
+       /**
+        * Show "your edit contains spam" page with your diff and text
+        *
+        * @param $match Text which triggered one or more filters
+        */
+       public function spamPageWithContent( $match = false ) {
+               global $wgOut;
+               $this->textbox2 = $this->textbox1;
+
+               $wgOut->setPageTitle( wfMsg( 'spamprotectiontitle' ) );
+               $wgOut->setRobotPolicy( 'noindex,nofollow' );
+               $wgOut->setArticleRelated( false );
+
+               $wgOut->addHTML( '<div id="spamprotected">' );
+               $wgOut->addWikiMsg( 'spamprotectiontext' );
+               if ( $match ) {
+                       $wgOut->addWikiMsg( 'spamprotectionmatch', wfEscapeWikiText( $match ) );
+               }
+               $wgOut->addHTML( '</div>' );
+
+               $wgOut->wrapWikiMsg( '<h2>$1</h2>', "yourdiff" );
+               $de = new DifferenceEngine( $this->mTitle );
+               $de->setText( $this->getContent(), $this->textbox2 );
+               $de->showDiff( wfMsg( "storedversion" ), wfMsg( "yourtext" ) );
+
+               $wgOut->wrapWikiMsg( '<h2>$1</h2>', "yourtext" );
+               $this->showTextbox2();
+
+               $wgOut->addReturnTo( $this->getContextTitle(), array( 'action' => 'edit' ) );
+       }
+
+
        /**
         * @private
         * @todo document
@@ -2100,19 +2250,25 @@ INPUTS
         * @return string
         */
        static function getEditToolbar() {
-               global $wgStylePath, $wgContLang, $wgLang;
+               global $wgStylePath, $wgContLang, $wgLang, $wgOut;
+               global $wgUseTeX, $wgEnableUploads, $wgForeignFileRepos;
 
-               /**
+               $imagesAvailable = $wgEnableUploads || count( $wgForeignFileRepos );
 
-                * toolarray an array of arrays which each include the filename of
-                * the button image (without path), the opening tag, the closing tag,
-                * and optionally a sample text that is inserted between the two when no
-                * selection is highlighted.
-                * The tip text is shown when the user moves the mouse over the button.
+               /**
+                * $toolarray is an array of arrays each of which includes the
+                * filename of the button image (without path), the opening
+                * tag, the closing tag, optionally a sample text that is
+                * inserted between the two when no selection is highlighted
+                * and an option to select which switches the automatic
+                * selection of inserted text (default is true, see
+                * mw-editbutton-image).  The tip text is shown when the user
+                * moves the mouse over the button.
                 *
-                * Already here are accesskeys (key), which are not used yet until someone
-                * can figure out a way to make them work in IE. However, we should make
-                * sure these keys are not defined on the edit page.
+                * Also here: accesskeys (key), which are not used yet until
+                * someone can figure out a way to make them work in
+                * IE. However, we should make sure these keys are not defined
+                * on the edit page.
                 */
                $toolarray = array(
                        array(
@@ -2160,16 +2316,17 @@ INPUTS
                                'tip'    => wfMsg( 'headline_tip' ),
                                'key'    => 'H'
                        ),
-                       array(
+                       $imagesAvailable ? array(
                                'image'  => $wgLang->getImageFile( 'button-image' ),
                                'id'     => 'mw-editbutton-image',
                                'open'   => '[[' . $wgContLang->getNsText( NS_FILE ) . ':',
                                'close'  => ']]',
                                'sample' => wfMsg( 'image_sample' ),
                                'tip'    => wfMsg( 'image_tip' ),
-                               'key'    => 'D'
-                       ),
-                       array(
+                               'key'    => 'D',
+                               'select' => true
+                       ) : false,
+                       $imagesAvailable ? array(
                                'image'  => $wgLang->getImageFile( 'button-media' ),
                                'id'     => 'mw-editbutton-media',
                                'open'   => '[[' . $wgContLang->getNsText( NS_MEDIA ) . ':',
@@ -2177,8 +2334,8 @@ INPUTS
                                'sample' => wfMsg( 'media_sample' ),
                                'tip'    => wfMsg( 'media_tip' ),
                                'key'    => 'M'
-                       ),
-                       array(
+                       ) : false,
+                       $wgUseTeX ?     array(
                                'image'  => $wgLang->getImageFile( 'button-math' ),
                                'id'     => 'mw-editbutton-math',
                                'open'   => "<math>",
@@ -2186,7 +2343,7 @@ INPUTS
                                'sample' => wfMsg( 'math_sample' ),
                                'tip'    => wfMsg( 'math_tip' ),
                                'key'    => 'C'
-                       ),
+                       ) : false,
                        array(
                                'image'  => $wgLang->getImageFile( 'button-nowiki' ),
                                'id'     => 'mw-editbutton-nowiki',
@@ -2219,6 +2376,14 @@ INPUTS
 
                $script = '';
                foreach ( $toolarray as $tool ) {
+                       if ( !$tool ) {
+                               continue;
+                       }
+
+                       if( !isset( $tool['select'] ) ) {
+                         $tool['select'] = true;
+                       }
+
                        $params = array(
                                $image = $wgStylePath . '/common/images/' . $tool['image'],
                                // Note that we use the tip both for the ALT tag and the TITLE tag of the image.
@@ -2236,7 +2401,10 @@ INPUTS
                                array_map( array( 'Xml', 'encodeJsVar' ), $params ) );
                        $script .= "addButton($paramList);\n";
                }
-               $toolbar .= Html::inlineScript( "\n$script\n" );
+
+               $wgOut->addScript( Html::inlineScript(
+                       "if ( window.mediaWiki ) { jQuery(function(){{$script}}); }"
+               ) );
 
                $toolbar .= "\n</div>";
 
@@ -2271,7 +2439,9 @@ INPUTS
                        );
                        $checkboxes['minor'] =
                                Xml::check( 'wpMinoredit', $checked['minor'], $attribs ) .
-                               "&nbsp;<label for='wpMinoredit'" . $skin->tooltip( 'minoredit', 'withaccess' ) . ">{$minorLabel}</label>";
+                               "&#160;<label for='wpMinoredit' id='mw-editpage-minoredit'" .
+                               Xml::expandAttributes( array( 'title' => $skin->titleAttrib( 'minoredit', 'withaccess' ) ) ) .
+                               ">{$minorLabel}</label>";
                }
 
                $watchLabel = wfMsgExt( 'watchthis', array( 'parseinline' ) );
@@ -2284,7 +2454,9 @@ INPUTS
                        );
                        $checkboxes['watch'] =
                                Xml::check( 'wpWatchthis', $checked['watch'], $attribs ) .
-                               "&nbsp;<label for='wpWatchthis'" . $skin->tooltip( 'watch', 'withaccess' ) . ">{$watchLabel}</label>";
+                               "&#160;<label for='wpWatchthis' id='mw-editpage-watch'" .
+                               Xml::expandAttributes( array( 'title' => $skin->titleAttrib( 'watch', 'withaccess' ) ) ) .
+                               ">{$watchLabel}</label>";
                }
                wfRunHooks( 'EditPageBeforeEditChecks', array( &$this, &$checkboxes, &$tabindex ) );
                return $checkboxes;
@@ -2298,7 +2470,7 @@ INPUTS
         *
         * @return array
         */
-       public function getEditButtons(&$tabindex) {
+       public function getEditButtons( &$tabindex ) {
                $buttons = array();
 
                $temp = array(
@@ -2372,7 +2544,7 @@ INPUTS
 
 
        public function getCancelLink() {
-               global $wgUser, $wgTitle;
+               global $wgUser;
 
                $cancelParams = array();
                if ( !$this->isConflict && $this->mArticle->getOldID() > 0 ) {
@@ -2380,7 +2552,7 @@ INPUTS
                }
 
                return $wgUser->getSkin()->link(
-                       $wgTitle,
+                       $this->getContextTitle(),
                        wfMsgExt( 'cancel', array( 'parseinline' ) ),
                        array( 'id' => 'mw-editform-cancel' ),
                        $cancelParams,
@@ -2551,7 +2723,7 @@ INPUTS
         * @return bool false if output is done, true if the rest of the form should be displayed
         */
        function attemptSave() {
-               global $wgUser, $wgOut, $wgTitle;
+               global $wgUser, $wgOut;
 
                $resultDetails = false;
                # Allow bots to exempt some edits from bot flagging
@@ -2565,7 +2737,7 @@ INPUTS
                switch ( $value ) {
                        case self::AS_HOOK_ERROR_EXPECTED:
                        case self::AS_CONTENT_TOO_BIG:
-                       case self::AS_ARTICLE_WAS_DELETED:
+                       case self::AS_ARTICLE_WAS_DELETED:
                        case self::AS_CONFLICT_DETECTED:
                        case self::AS_SUMMARY_NEEDED:
                        case self::AS_TEXTBOX_EMPTY:
@@ -2575,12 +2747,32 @@ INPUTS
 
                        case self::AS_HOOK_ERROR:
                        case self::AS_FILTERING:
+                               return false;
+
                        case self::AS_SUCCESS_NEW_ARTICLE:
+                               $query = $resultDetails['redirect'] ? 'redirect=no' : '';
+                               $wgOut->redirect( $this->mTitle->getFullURL( $query ) );
+                               return false;
+
                        case self::AS_SUCCESS_UPDATE:
+                               $extraQuery = '';
+                               $sectionanchor = $resultDetails['sectionanchor'];
+
+                               // Give extensions a chance to modify URL query on update
+                               wfRunHooks( 'ArticleUpdateBeforeRedirect', array( $this->mArticle, &$sectionanchor, &$extraQuery ) );
+
+                               if ( $resultDetails['redirect'] ) {
+                                       if ( $extraQuery == '' ) {
+                                               $extraQuery = 'redirect=no';
+                                       } else {
+                                               $extraQuery = 'redirect=no&' . $extraQuery;
+                                       }
+                               }
+                               $wgOut->redirect( $this->mTitle->getFullURL( $extraQuery ) . $sectionanchor );
                                return false;
 
                        case self::AS_SPAM_ERROR:
-                               $this->spamPage( $resultDetails['spam'] );
+                               $this->spamPageWithContent( $resultDetails['spam'] );
                                return false;
 
                        case self::AS_BLOCKED_PAGE_FOR_USER:
@@ -2595,22 +2787,22 @@ INPUTS
                                $this->userNotLoggedInPage();
                                return false;
 
-                       case self::AS_READ_ONLY_PAGE_LOGGED:
-                       case self::AS_READ_ONLY_PAGE:
-                               $wgOut->readOnlyPage();
-                               return false;
+                       case self::AS_READ_ONLY_PAGE_LOGGED:
+                       case self::AS_READ_ONLY_PAGE:
+                               $wgOut->readOnlyPage();
+                               return false;
 
-                       case self::AS_RATE_LIMITED:
-                               $wgOut->rateLimited();
-                               return false;
+                       case self::AS_RATE_LIMITED:
+                               $wgOut->rateLimited();
+                               return false;
 
-                       case self::AS_NO_CREATE_PERMISSION:
-                               $this->noCreatePermission();
-                               return;
+                       case self::AS_NO_CREATE_PERMISSION:
+                               $this->noCreatePermission();
+                               return;
 
                        case self::AS_BLANK_ARTICLE:
-                               $wgOut->redirect( $wgTitle->getFullURL() );
-                               return false;
+                               $wgOut->redirect( $this->getContextTitle()->getFullURL() );
+                               return false;
 
                        case self::AS_IMAGE_REDIRECT_LOGGED:
                                $wgOut->permissionRequired( 'upload' );
@@ -2619,7 +2811,7 @@ INPUTS
        }
 
        function getBaseRevision() {
-               if ( $this->mBaseRevision == false ) {
+               if ( !$this->mBaseRevision ) {
                        $db = wfGetDB( DB_MASTER );
                        $baseRevision = Revision::loadFromTimestamp(
                                $db, $this->mTitle, $this->edittime );
@@ -2627,5 +2819,5 @@ INPUTS
                } else {
                        return $this->mBaseRevision;
                }
-       }       
+       }
 }