It helps when you don't break things...
[lhc/web/wiklou.git] / includes / EditPage.php
index 4afee97..867431b 100644 (file)
@@ -1,18 +1,14 @@
 <?php
 /**
- * Contain the EditPage class
- * @package MediaWiki
+ * Contains the EditPage class
  */
 
 /**
- * Splitting edit page/HTML interface from Article...
+ * The edit page/HTML interface (split from Article)
  * The actual database and text munging is still in Article,
  * but it should get easier to call those from alternate
  * interfaces.
- *
- * @package MediaWiki
  */
-
 class EditPage {
        var $mArticle;
        var $mTitle;
@@ -24,6 +20,7 @@ class EditPage {
        var $firsttime;
        var $lastDelete;
        var $mTokenOk = false;
+       var $mTokenOkExceptSuffix = false;
        var $mTriedSave = false;
        var $tooBig = false;
        var $kblength = false;
@@ -32,6 +29,7 @@ class EditPage {
        var $allowBlankSummary = false;
        var $autoSumm = '';
        var $hookError = '';
+       var $mPreviewTemplates;
 
        # Form values
        var $save = false, $preview = false, $diff = false;
@@ -40,6 +38,14 @@ class EditPage {
        var $edittime = '', $section = '', $starttime = '';
        var $oldid = 0, $editintro = '', $scrolltop = null;
 
+       # Placeholders for text injection by hooks (must be HTML)
+       # extensions should take care to _append_ to the present value
+       public $editFormPageTop; // Before even the preview
+       public $editFormTextTop;
+       public $editFormTextAfterWarn;
+       public $editFormTextAfterTools;
+       public $editFormTextBottom;
+
        /**
         * @todo document
         * @param $article
@@ -48,26 +54,38 @@ class EditPage {
                $this->mArticle =& $article;
                global $wgTitle;
                $this->mTitle =& $wgTitle;
+
+               # Placeholders for text injection by hooks (empty per default)
+               $this->editFormPageTop =
+               $this->editFormTextTop =
+               $this->editFormTextAfterWarn =
+               $this->editFormTextAfterTools =
+               $this->editFormTextBottom = "";
        }
        
        /**
         * Fetch initial editing page content.
         */
-       private function getContent() {
-               global $wgRequest, $wgParser;
+       private function getContent( $def_text = '' ) {
+               global $wgOut, $wgRequest, $wgParser;
 
                # Get variables from query string :P
                $section = $wgRequest->getVal( 'section' );
                $preload = $wgRequest->getVal( 'preload' );
+               $undoafter = $wgRequest->getVal( 'undoafter' );
+               $undo = $wgRequest->getVal( 'undo' );
 
                wfProfileIn( __METHOD__ );
 
                $text = '';
                if( !$this->mTitle->exists() ) {
-
-                       # If requested, preload some text.
-                       $text = $this->getPreloadedText( $preload );
-
+                       if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
+                               # If this is a system message, get the default text. 
+                               $text = wfMsgWeirdKey ( $this->mTitle->getText() ) ;
+                       } else {
+                               # If requested, preload some text.
+                               $text = $this->getPreloadedText( $preload );
+                       }
                        # We used to put MediaWiki:Newarticletext here if
                        # $text was empty at this point.
                        # This is now shown above the edit box instead.
@@ -77,18 +95,68 @@ class EditPage {
                        // fetch the page record from the high-priority server,
                        // which is needed to guarantee we don't pick up lagged
                        // information.
-                       
+
                        $text = $this->mArticle->getContent();
-                       
-                       if( $section != '' ) {
+
+                       if ($undo > 0 && $undoafter > 0 && $undo < $undoafter) {
+                               # If they got undoafter and undo round the wrong way, switch them
+                               list( $undo, $undoafter ) = array( $undoafter, $undo );
+                       }
+
+                       if ( $undo > 0 && $undo > $undoafter ) {
+                               # Undoing a specific edit overrides section editing; section-editing
+                               # doesn't work with undoing.
+                               if ( $undoafter ) {
+                                       $undorev = Revision::newFromId($undo);
+                                       $oldrev = Revision::newFromId($undoafter);
+                               } else {
+                                       $undorev = Revision::newFromId($undo);
+                                       $oldrev = $undorev ? $undorev->getPrevious() : null;
+                               }
+
+                               #Sanity check, make sure it's the right page.
+                               # Otherwise, $text will be left as-is.
+                               if ( !is_null($undorev) && !is_null($oldrev) && $undorev->getPage()==$oldrev->getPage() && $undorev->getPage()==$this->mArticle->getID() ) {
+                                       $undorev_text = $undorev->getText();
+                                       $oldrev_text = $oldrev->getText();
+                                       $currev_text = $text;
+
+                                       #No use doing a merge if it's just a straight revert.
+                                       if ( $currev_text != $undorev_text ) {
+                                               $result = wfMerge($undorev_text, $oldrev_text, $currev_text, $text);
+                                       } else {
+                                               $text = $oldrev_text;
+                                               $result = true;
+                                       }
+                               } else {
+                                       // Failed basic sanity checks.
+                                       // Older revisions may have been removed since the link
+                                       // was created, or we may simply have got bogus input.
+                                       $result = false;
+                               }
+
+                               if( $result ) {
+                                       # Inform the user of our success and set an automatic edit summary
+                                       $this->editFormPageTop .= $wgOut->parse( wfMsgNoTrans( 'undo-success' ) );
+                                       $firstrev = $oldrev->getNext();
+                                       # If we just undid one rev, use an autosummary
+                                       if ( $firstrev->mId == $undo ) {
+                                               $this->summary = wfMsgForContent('undo-summary', $undo, $undorev->getUserText());
+                                       }
+                                       $this->formtype = 'diff';
+                               } else {
+                                       # Warn the user that something went wrong
+                                       $this->editFormPageTop .= $wgOut->parse( wfMsgNoTrans( 'undo-failure' ) );
+                               }
+                       } else if( $section != '' ) {
                                if( $section == 'new' ) {
                                        $text = $this->getPreloadedText( $preload );
                                } else {
-                                       $text = $wgParser->getSection( $text, $section );
+                                       $text = $wgParser->getSection( $text, $section, $def_text );
                                }
                        }
                }
-               
+
                wfProfileOut( __METHOD__ );
                return $text;
        }
@@ -232,7 +300,7 @@ class EditPage {
                global $wgOut, $wgUser, $wgRequest, $wgTitle;
                global $wgEmailConfirmToEdit;
 
-               if ( ! wfRunHooks( 'AlternateEdit', array( &$this  ) ) )
+               if ( ! wfRunHooks( 'AlternateEdit', array( &$this ) ) )
                        return;
 
                $fname = 'EditPage::edit';
@@ -251,7 +319,7 @@ class EditPage {
                        return;
                }
 
-               if ( ! $this->mTitle->userCanEdit() ) {
+               if ( ! $this->mTitle->userCan( 'edit' ) ) {
                        wfDebug( "$fname: user can't edit\n" );
                        $wgOut->readOnlyPage( $this->getContent(), true );
                        wfProfileOut( $fname );
@@ -285,7 +353,7 @@ class EditPage {
                        wfProfileOut($fname);
                        return;
                }
-               if ( !$this->mTitle->userCanCreate() && !$this->mTitle->exists() ) {
+               if ( !$this->mTitle->userCan( 'create' ) && !$this->mTitle->exists() ) {
                        wfDebug( "$fname: no create permission\n" );
                        $this->noCreatePermission();
                        wfProfileOut( $fname );
@@ -348,9 +416,10 @@ class EditPage {
                        }
                }
 
-               if(!$this->mTitle->getArticleID() && ('initial' == $this->formtype || $this->firsttime )) { # new article
+               # Show applicable editing introductions
+               if( $this->formtype == 'initial' || $this->firsttime )
                        $this->showIntro();
-               }
+       
                if( $this->mTitle->isTalkPage() ) {
                        $wgOut->addWikiText( wfMsg( 'talkpagetext' ) );
                }
@@ -371,7 +440,12 @@ class EditPage {
                # First time through: get contents, set time for conflict
                # checking, etc.
                if ( 'initial' == $this->formtype || $this->firsttime ) {
-                       $this->initialiseForm();
+                       if ($this->initialiseForm() === false) {
+                               $this->noSuchSectionPage();
+                               wfProfileOut( "$fname-business-end" );
+                               wfProfileOut( $fname );
+                               return;
+                       }
                        if( !$this->mTitle->getArticleId() ) 
                                wfRunHooks( 'EditFormPreloadText', array( &$this->textbox1, &$this->mTitle ) );
                }
@@ -382,17 +456,30 @@ class EditPage {
        }
 
        /**
-        * Return true if this page should be previewed when the edit form
-        * is initially opened.
+        * Should we show a preview when the edit form is first shown?
+        *
         * @return bool
-        * @private
         */
-       function previewOnOpen() {
-               global $wgUser;
-               return $this->section != 'new' &&
-                       ( ( $wgUser->getOption( 'previewonfirst' ) && $this->mTitle->exists() ) ||
-                               ( $this->mTitle->getNamespace() == NS_CATEGORY &&
-                                       !$this->mTitle->exists() ) );
+       private function previewOnOpen() {
+               global $wgRequest, $wgUser;
+               if( $wgRequest->getVal( 'preview' ) == 'yes' ) {
+                       // Explicit override from request
+                       return true;
+               } elseif( $wgRequest->getVal( 'preview' ) == 'no' ) {
+                       // Explicit override from request
+                       return false;
+               } elseif( $this->section == 'new' ) {
+                       // Nothing *to* preview for new sections
+                       return false;
+               } elseif( $this->mTitle->exists() && $wgUser->getOption( 'previewonfirst' ) ) {
+                       // Standard preference behaviour
+                       return true;
+               } elseif( !$this->mTitle->exists() && $this->mTitle->getNamespace() == NS_CATEGORY ) {
+                       // Categories are special
+                       return true;
+               } else {
+                       return false;
+               }
        }
 
        /**
@@ -432,7 +519,7 @@ class EditPage {
                                // Remember whether a save was requested, so we can indicate
                                // if we forced preview due to session failure.
                                $this->mTriedSave = !$this->preview;
-                               
+
                                if ( $this->tokenOk( $request ) ) {
                                        # Some browsers will not report any submit button
                                        # if the user hits enter in the comment box.
@@ -469,8 +556,8 @@ class EditPage {
                        } else {
                                $this->allowBlankSummary = $request->getBool( 'wpIgnoreBlankSummary' );
                        }
-       
-                       $this->autoSumm = $request->getText( 'wpAutoSummary' );                 
+
+                       $this->autoSumm = $request->getText( 'wpAutoSummary' ); 
                } else {
                        # Not a posted form? Start with nothing.
                        wfDebug( "$fname: Not a posted form.\n" );
@@ -508,35 +595,45 @@ class EditPage {
         */
        function tokenOk( &$request ) {
                global $wgUser;
-               if( $wgUser->isAnon() ) {
-                       # Anonymous users may not have a session
-                       # open. Don't tokenize.
-                       $this->mTokenOk = true;
-               } else {
-                       $this->mTokenOk = $wgUser->matchEditToken( $request->getVal( 'wpEditToken' ) );
-               }
+               $token = $request->getVal( 'wpEditToken' );
+               $this->mTokenOk = $wgUser->matchEditToken( $token );
+               $this->mTokenOkExceptSuffix = $wgUser->matchEditTokenNoSuffix( $token );
                return $this->mTokenOk;
        }
 
-       /** */
-       function showIntro() {
+       /**
+        * Show all applicable editing introductions
+        */
+       private function showIntro() {
                global $wgOut, $wgUser;
-               $addstandardintro=true;
-               if($this->editintro) {
-                       $introtitle=Title::newFromText($this->editintro);
-                       if(isset($introtitle) && $introtitle->userCanRead()) {
-                               $rev=Revision::newFromTitle($introtitle);
-                               if($rev) {
-                                       $wgOut->addSecondaryWikiText($rev->getText());
-                                       $addstandardintro=false;
-                               }
-                       }
-               }
-               if($addstandardintro) {
-                       if ( $wgUser->isLoggedIn() )
+               if( !$this->showCustomIntro() && !$this->mTitle->exists() ) {
+                       if( $wgUser->isLoggedIn() ) {
                                $wgOut->addWikiText( wfMsg( 'newarticletext' ) );
-                       else
+                       } else {
                                $wgOut->addWikiText( wfMsg( 'newarticletextanon' ) );
+                       }
+                       $this->showDeletionLog( $wgOut );
+               }
+       }
+       
+       /**
+        * Attempt to show a custom editing introduction, if supplied
+        *
+        * @return bool
+        */
+       private function showCustomIntro() {
+               if( $this->editintro ) {
+                       $title = Title::newFromText( $this->editintro );
+                       if( $title instanceof Title && $title->exists() && $title->userCanRead() ) {
+                               global $wgOut;
+                               $revision = Revision::newFromTitle( $title );
+                               $wgOut->addSecondaryWikiText( $revision->getText() );
+                               return true;
+                       } else {
+                               return false;
+                       }
+               } else {
+                       return false;
                }
        }
 
@@ -552,11 +649,18 @@ class EditPage {
                wfProfileIn( $fname );
                wfProfileIn( "$fname-checks" );
 
+               if( !wfRunHooks( 'EditPage::attemptSave', array( &$this ) ) )
+               {
+                       wfDebug( "Hook 'EditPage::attemptSave' aborted article saving" );
+                       return false;
+               }
+
                # Reintegrate metadata
                if ( $this->mMetaData != '' ) $this->textbox1 .= "\n" . $this->mMetaData ;
                $this->mMetaData = '' ;
 
                # Check for spam
+               $matches = array();
                if ( $wgSpamRegex && preg_match( $wgSpamRegex, $this->textbox1, $matches ) ) {
                        $this->spamPage ( $matches[0] );
                        wfProfileOut( "$fname-checks" );
@@ -595,7 +699,7 @@ class EditPage {
                        wfProfileOut( $fname );
                        return true;
                }
-               
+
                if ( !$wgUser->isAllowed('edit') ) {
                        if ( $wgUser->isAnon() ) {
                                $this->userNotLoggedInPage();
@@ -637,8 +741,9 @@ class EditPage {
                # If article is new, insert it.
                $aid = $this->mTitle->getArticleID( GAID_FOR_UPDATE );
                if ( 0 == $aid ) {
+
                        // Late check for create permission, just in case *PARANOIA*
-                       if ( !$this->mTitle->userCanCreate() ) {
+                       if ( !$this->mTitle->userCan( 'create' ) ) {
                                wfDebug( "$fname: no create permission\n" );
                                $this->noCreatePermission();
                                wfProfileOut( $fname );
@@ -652,14 +757,6 @@ class EditPage {
                                        return false;
                        }
 
-                       # If no edit comment was given when creating a new page, and what's being
-                       # created is a redirect, be smart and fill in a neat auto-comment
-                       if( $this->summary == '' ) {
-                               $rt = Title::newFromRedirect( $this->textbox1 );
-                               if( is_object( $rt ) )
-                                       $this->summary = wfMsgForContent( 'autoredircomment', $rt->getPrefixedText() );
-                       }
-
                        $isComment=($this->section=='new');
                        $this->mArticle->insertNewArticle( $this->textbox1, $this->summary,
                                $this->minoredit, $this->watchthis, false, $isComment);
@@ -673,6 +770,8 @@ class EditPage {
                $this->mArticle->clear(); # Force reload of dates, etc.
                $this->mArticle->forUpdate( true ); # Lock the article
 
+               wfDebug("timestamp: {$this->mArticle->getTimestamp()}, edittime: {$this->edittime}\n");
+
                if( $this->mArticle->getTimestamp() != $this->edittime ) {
                        $this->isConflict = true;
                        if( $this->section == 'new' ) {
@@ -731,16 +830,11 @@ class EditPage {
                        return true;
                }
 
-               # If no edit comment was given when turning a page into a redirect, be smart
-               # and fill in a neat auto-comment
-               if( $this->summary == '' ) {
-                       $rt = Title::newFromRedirect( $this->textbox1 );
-                       if( is_object( $rt ) )
-                               $this->summary = wfMsgForContent( 'autoredircomment', $rt->getPrefixedText() );
-               }
+               $oldtext = $this->mArticle->getContent();
 
-               # Handle the user preference to force summaries here
-               if( $this->section != 'new' && !$this->allowBlankSummary && $wgUser->getOption( 'forceeditsummary' ) ) {
+               # Handle the user preference to force summaries here, but not for null edits
+               if( $this->section != 'new' && !$this->allowBlankSummary && $wgUser->getOption( 'forceeditsummary')
+                       &&  0 != strcmp($oldtext, $text) && !Article::getRedirectAutosummary( $text )) {
                        if( md5( $this->summary ) == $this->autoSumm ) {
                                $this->missingSummary = true;
                                wfProfileOut( $fname );
@@ -748,6 +842,15 @@ class EditPage {
                        }
                }
 
+               #And a similar thing for new sections
+               if( $this->section == 'new' && !$this->allowBlankSummary && $wgUser->getOption( 'forceeditsummary' ) ) {
+                       if (trim($this->summary) == '') {
+                               $this->missingSummary = true;
+                               wfProfileOut( $fname );
+                               return( true );
+                       }
+               }
+
                # All's well
                wfProfileIn( "$fname-sectionanchor" );
                $sectionanchor = '';
@@ -805,11 +908,14 @@ class EditPage {
         */
        function initialiseForm() {
                $this->edittime = $this->mArticle->getTimestamp();
-               $this->textbox1 = $this->getContent();
                $this->summary = '';
+               $this->textbox1 = $this->getContent(false);
+               if ($this->textbox1 === false) return false;
+
                if ( !$this->mArticle->exists() && $this->mArticle->mTitle->getNamespace() == NS_MEDIAWIKI )
-                       $this->textbox1 = wfMsgWeirdKey( $this->mArticle->mTitle->getText() ) ;
+                       $this->textbox1 = wfMsgWeirdKey( $this->mArticle->mTitle->getText() );
                wfProxyCheck();
+               return true;
        }
 
        /**
@@ -824,7 +930,7 @@ class EditPage {
                $fname = 'EditPage::showEditForm';
                wfProfileIn( $fname );
 
-               $sk =& $wgUser->getSkin();
+               $sk = $wgUser->getSkin();
 
                wfRunHooks( 'EditPage::showEditForm:initial', array( &$this ) ) ;
 
@@ -848,6 +954,7 @@ class EditPage {
                                        $s = wfMsg('editingcomment', $this->mTitle->getPrefixedText() );
                                } else {
                                        $s = wfMsg('editingsection', $this->mTitle->getPrefixedText() );
+                                       $matches = array();
                                        if( !$this->summary && !$this->preview && !$this->diff ) {
                                                preg_match( "/^(=+)(.+)\\1/mi",
                                                        $this->textbox1,
@@ -865,11 +972,15 @@ class EditPage {
                        if ( $this->missingComment ) {
                                $wgOut->addWikiText( wfMsg( 'missingcommenttext' ) );
                        }
-                       
-                       if( $this->missingSummary ) {
+
+                       if( $this->missingSummary && $this->section != 'new' ) {
                                $wgOut->addWikiText( wfMsg( 'missingsummary' ) );
                        }
-                       
+
+                       if( $this->missingSummary && $this->section == 'new' ) {
+                               $wgOut->addWikiText( wfMsg( 'missingcommentheader' ) );
+                       }
+
                        if( !$this->hookError == '' ) {
                                $wgOut->addWikiText( $this->hookError );
                        }
@@ -877,11 +988,15 @@ class EditPage {
                        if ( !$this->checkUnicodeCompliantBrowser() ) {
                                $wgOut->addWikiText( wfMsg( 'nonunicodebrowser') );
                        }
-                       if ( isset( $this->mArticle )
-                            && isset( $this->mArticle->mRevision )
-                            && !$this->mArticle->mRevision->isCurrent() ) {
-                               $this->mArticle->setOldSubtitle( $this->mArticle->mRevision->getId() );
-                               $wgOut->addWikiText( wfMsg( 'editingold' ) );
+                       if ( isset( $this->mArticle ) && isset( $this->mArticle->mRevision ) ) {
+                       // Let sysop know that this will make private content public if saved
+                               if( $this->mArticle->mRevision->isDeleted( Revision::DELETED_TEXT ) ) {
+                                       $wgOut->addWikiText( wfMsg( 'rev-deleted-text-view' ) );
+                               }
+                               if( !$this->mArticle->mRevision->isCurrent() ) {
+                                       $this->mArticle->setOldSubtitle( $this->mArticle->mRevision->getId() );
+                                       $wgOut->addWikiText( wfMsg( 'editingold' ) );
+                               }
                        }
                }
 
@@ -899,24 +1014,33 @@ class EditPage {
                                }
                        }
                }
-                       
-               if( $this->mTitle->isProtected( 'edit' ) ) {
-                       # Is the protection due to the namespace, e.g. interface text?
-                       if( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
-                               # Yes; remind the user
-                               $notice = wfMsg( 'editinginterface' );
-                       } elseif( $this->mTitle->isSemiProtected() ) {
-                               # No; semi protected
+
+               if( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
+                       # Show a warning if editing an interface message
+                       $wgOut->addWikiText( wfMsg( 'editinginterface' ) );
+               } elseif( $this->mTitle->isProtected( 'edit' ) ) {
+                       # Is the title semi-protected?
+                       if( $this->mTitle->isSemiProtected() ) {
                                $notice = wfMsg( 'semiprotectedpagewarning' );
-                               if( wfEmptyMsg( 'semiprotectedpagewarning', $notice ) || $notice == '-' ) {
+                               if( wfEmptyMsg( 'semiprotectedpagewarning', $notice ) || $notice == '-' )
                                        $notice = '';
-                               }
                        } else {
-                               # No; regular protection
+                       # Then it must be protected based on static groups (regular)
                                $notice = wfMsg( 'protectedpagewarning' );
                        }
                        $wgOut->addWikiText( $notice );
                }
+               if ( $this->mTitle->isCascadeProtected() ) {
+                       # Is this page under cascading protection from some source pages?
+                       list($cascadeSources, /* $restrictions */) = $this->mTitle->getCascadeProtectionSources();
+                       if ( count($cascadeSources) > 0 ) {
+                               # Explain, and list the titles responsible
+                               $notice = wfMsgExt( 'cascadeprotectedwarning', array('parsemag'), count($cascadeSources) ) . "\n";
+                               foreach( $cascadeSources as $id => $page )
+                                       $notice .= '* [[:' . $page->getPrefixedText() . "]]\n";
+                               }
+                       $wgOut->addWikiText( $notice );
+               }
 
                if ( $this->kblength === false ) {
                        $this->kblength = (int)(strlen( $this->textbox1 ) / 1024);
@@ -927,6 +1051,12 @@ class EditPage {
                        $wgOut->addWikiText( wfMsg( 'longpagewarning', $wgLang->formatNum( $this->kblength ) ) );
                }
 
+               #need to parse the preview early so that we know which templates are used,
+               #otherwise users with "show preview after edit box" will get a blank list
+               if ( $this->formtype == 'preview' ) {
+                       $previewOutput = $this->getPreviewText();
+               }
+
                $rows = $wgUser->getIntOption( 'rows' );
                $cols = $wgUser->getIntOption( 'cols' );
 
@@ -940,8 +1070,6 @@ class EditPage {
 
                $summary = wfMsg('summary');
                $subject = wfMsg('subject');
-               $minor   = wfMsgExt('minoredit', array('parseinline'));
-               $watchthis = wfMsgExt('watchthis', array('parseinline'));
 
                $cancel = $sk->makeKnownLink( $this->mTitle->getPrefixedText(),
                                wfMsgExt('cancel', array('parseinline')) );
@@ -976,61 +1104,49 @@ class EditPage {
                                # Already watched
                                $this->watchthis = true;
                        }
-                       
-                       if( $wgUser->getOption( 'minordefault' ) ) $this->minoredit = true;
-               }
 
-               $minoredithtml = '';
-
-               if ( $wgUser->isAllowed('minoredit') ) {
-                       $minoredithtml =
-                               "<input tabindex='3' type='checkbox' value='1' name='wpMinoredit'".($this->minoredit?" checked='checked'":"").
-                               " accesskey='".wfMsg('accesskey-minoredit')."' id='wpMinoredit' />\n".
-                               "<label for='wpMinoredit' title='".wfMsg('tooltip-minoredit')."'>{$minor}</label>\n";
-               }
-
-               $watchhtml = '';
-
-               if ( $wgUser->isLoggedIn() ) {
-                       $watchhtml = "<input tabindex='4' type='checkbox' name='wpWatchthis'".
-                               ($this->watchthis?" checked='checked'":"").
-                               " accesskey=\"".htmlspecialchars(wfMsg('accesskey-watch'))."\" id='wpWatchthis'  />\n".
-                               "<label for='wpWatchthis' title=\"" .
-                                       htmlspecialchars(wfMsg('tooltip-watch'))."\">{$watchthis}</label>\n";
+                       if( $wgUser->getOption( 'minordefault' ) ) $this->minoredit = true;
                }
 
-               $checkboxhtml = $minoredithtml . $watchhtml;
+               $wgOut->addHTML( $this->editFormPageTop );
 
                if ( $wgUser->getOption( 'previewontop' ) ) {
 
                        if ( 'preview' == $this->formtype ) {
-                               $this->showPreview();
+                               $this->showPreview( $previewOutput );
                        } else {
                                $wgOut->addHTML( '<div id="wikiPreview"></div>' );
                        }
 
                        if ( 'diff' == $this->formtype ) {
-                               $wgOut->addHTML( $this->getDiff() );
+                               $this->showDiff();
                        }
                }
 
 
+               $wgOut->addHTML( $this->editFormTextTop );
+
                # if this is a comment, show a subject line at the top, which is also the edit summary.
                # Otherwise, show a summary field at the bottom
                $summarytext = htmlspecialchars( $wgContLang->recodeForEdit( $this->summary ) ); # FIXME
                if( $this->section == 'new' ) {
                        $commentsubject="<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}:</label></span>\n<div class='editOptions'>\n<input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
                        $editsummary = '';
+                       $subjectpreview = $summarytext && $this->preview ? "<div class=\"mw-summary-preview\">".wfMsg('subject-preview').':'.$sk->commentBlock( $this->summary, $this->mTitle )."</div>\n" : '';
+                       $summarypreview = '';
                } else {
                        $commentsubject = '';
                        $editsummary="<span id='wpSummaryLabel'><label for='wpSummary'>{$summary}:</label></span>\n<div class='editOptions'>\n<input tabindex='2' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' /><br />";
+                       $summarypreview = $summarytext && $this->preview ? "<div class=\"mw-summary-preview\">".wfMsg('summary-preview').':'.$sk->commentBlock( $this->summary, $this->mTitle )."</div>\n" : '';
+                       $subjectpreview = '';
                }
 
                # Set focus to the edit box on load, except on preview or diff, where it would interfere with the display
                if( !$this->preview && !$this->diff ) {
                        $wgOut->setOnloadHandler( 'document.editform.wpTextbox1.focus()' );
                }
-               $templates = $this->formatTemplates();
+               $templates = ($this->preview || $this->section != '') ? $this->mPreviewTemplates : $this->mArticle->getUsedTemplates();
+               $formattedtemplates = $sk->formatTemplates( $templates, $this->preview, $this->section != '');
 
                global $wgUseMetadataEdit ;
                if ( $wgUseMetadataEdit ) {
@@ -1058,68 +1174,18 @@ class EditPage {
                        }
                }
 
-               $temp = array(
-                       'id'        => 'wpSave',
-                       'name'      => 'wpSave',
-                       'type'      => 'submit',
-                       'tabindex'  => '5',
-                       'value'     => wfMsg('savearticle'),
-                       'accesskey' => wfMsg('accesskey-save'),
-                       'title'     => wfMsg('tooltip-save'),
-               );
-               $buttons['save'] = wfElement('input', $temp, '');
-               $temp = array(
-                       'id'        => 'wpDiff',
-                       'name'      => 'wpDiff',
-                       'type'      => 'submit',
-                       'tabindex'  => '7',
-                       'value'     => wfMsg('showdiff'),
-                       'accesskey' => wfMsg('accesskey-diff'),
-                       'title'     => wfMsg('tooltip-diff'),
-               );
-               $buttons['diff'] = wfElement('input', $temp, '');
+               $tabindex = 2;
 
-               global $wgLivePreview;
-               if ( $wgLivePreview && $wgUser->getOption( 'uselivepreview' ) ) {
-                       $temp = array(
-                               'id'        => 'wpPreview',
-                               'name'      => 'wpPreview',
-                               'type'      => 'submit',
-                               'tabindex'  => '6',
-                               'value'     => wfMsg('showpreview'),
-                               'accesskey' => '',
-                               'title'     => wfMsg('tooltip-preview'),
-                               'style'     => 'display: none;',
-                       );
-                       $buttons['preview'] = wfElement('input', $temp, '');
-                       $temp = array(
-                               'id'        => 'wpLivePreview',
-                               'name'      => 'wpLivePreview',
-                               'type'      => 'submit',
-                               'tabindex'  => '6',
-                               'value'     => wfMsg('showlivepreview'),
-                               'accesskey' => wfMsg('accesskey-preview'),
-                               'title'     => '',
-                               'onclick'   => $this->doLivePreviewScript(),
-                       );
-                       $buttons['live'] = wfElement('input', $temp, '');
-               } else {
-                       $temp = array(
-                               'id'        => 'wpPreview',
-                               'name'      => 'wpPreview',
-                               'type'      => 'submit',
-                               'tabindex'  => '6',
-                               'value'     => wfMsg('showpreview'),
-                               'accesskey' => wfMsg('accesskey-preview'),
-                               'title'     => wfMsg('tooltip-preview'),
-                       );
-                       $buttons['preview'] = wfElement('input', $temp, '');
-                       $buttons['live'] = '';
-               }
+               $checkboxes = self::getCheckboxes( $tabindex, $sk,
+                       array( 'minor' => $this->minoredit, 'watch' => $this->watchthis ) );
+
+               $checkboxhtml = implode( $checkboxes, "\n" );
+
+               $buttons = $this->getEditButtons( $tabindex );
+               $buttonshtml = implode( $buttons, "\n" );
 
                $safemodehtml = $this->checkUnicodeCompliantBrowser()
-                       ? ""
-                       : "<input type='hidden' name=\"safemode\" value='1' />\n";
+                       ? '' : Xml::hidden( 'safemode', '1' );
 
                $wgOut->addHTML( <<<END
 {$toolbar}
@@ -1131,6 +1197,8 @@ END
                        call_user_func_array( $formCallback, array( &$wgOut ) );
                }
 
+               wfRunHooks( 'EditPage::showEditForm:fields', array( &$this, &$wgOut ) );
+
                // Put these up at the top to ensure they aren't lost on early form submission
                $wgOut->addHTML( "
 <input type='hidden' value=\"" . htmlspecialchars( $this->section ) . "\" name=\"wpSection\" />
@@ -1141,6 +1209,7 @@ END
                $wgOut->addHTML( <<<END
 $recreate
 {$commentsubject}
+{$subjectpreview}
 <textarea tabindex='1' accesskey="," name="wpTextbox1" id="wpTextbox1" rows='{$rows}'
 cols='{$cols}'{$ew} $hidden>
 END
@@ -1150,43 +1219,49 @@ END
                " );
 
                $wgOut->addWikiText( $copywarn );
+               $wgOut->addHTML( $this->editFormTextAfterWarn );
                $wgOut->addHTML( "
 {$metadata}
 {$editsummary}
+{$summarypreview}
 {$checkboxhtml}
 {$safemodehtml}
 ");
 
                $wgOut->addHTML(
 "<div class='editButtons'>
-       {$buttons['save']}
-       {$buttons['preview']}
-       {$buttons['live']}
-       {$buttons['diff']}
+{$buttonshtml}
        <span class='editHelp'>{$cancel} | {$edithelp}</span>
 </div><!-- editButtons -->
 </div><!-- editOptions -->");
 
+               $wgOut->addHtml( '<div class="mw-editTools">' );
                $wgOut->addWikiText( wfMsgForContent( 'edittools' ) );
+               $wgOut->addHtml( '</div>' );
+
+               $wgOut->addHTML( $this->editFormTextAfterTools );
 
                $wgOut->addHTML( "
 <div class='templatesUsed'>
-{$templates}
+{$formattedtemplates}
 </div>
 " );
 
-               if ( $wgUser->isLoggedIn() ) {
-                       /**
-                        * To make it harder for someone to slip a user a page
-                        * which submits an edit form to the wiki without their
-                        * knowledge, a random token is associated with the login
-                        * session. If it's not passed back with the submission,
-                        * we won't save the page, or render user JavaScript and
-                        * CSS previews.
-                        */
-                       $token = htmlspecialchars( $wgUser->editToken() );
-                       $wgOut->addHTML( "\n<input type='hidden' value=\"$token\" name=\"wpEditToken\" />\n" );
-               }
+               /**
+                * To make it harder for someone to slip a user a page
+                * which submits an edit form to the wiki without their
+                * knowledge, a random token is associated with the login
+                * session. If it's not passed back with the submission,
+                * we won't save the page, or render user JavaScript and
+                * CSS previews.
+                *
+                * For anon editors, who may not have a session, we just
+                * include the constant suffix to prevent editing from
+                * broken text-mangling proxies.
+                */
+               $token = htmlspecialchars( $wgUser->editToken() );
+               $wgOut->addHTML( "\n<input type='hidden' value=\"$token\" name=\"wpEditToken\" />\n" );
+
 
                # If a blank edit summary was previously provided, and the appropriate
                # user preference is active, pass a hidden tag here. This will stop the
@@ -1195,7 +1270,7 @@ END
                if( $this->missingSummary ) {
                        $wgOut->addHTML( "<input type=\"hidden\" name=\"wpIgnoreBlankSummary\" value=\"1\" />\n" );
                }
-               
+
                # For a bit more sophisticated detection of blank summaries, hash the
                # automatic one and pass that in a hidden field.
                $autosumm = $this->autoSumm ? $this->autoSumm : md5( $this->summary );
@@ -1212,17 +1287,18 @@ END
                        $wgOut->addHTML( "<textarea tabindex=6 id='wpTextbox2' name=\"wpTextbox2\" rows='{$rows}' cols='{$cols}' wrap='virtual'>"
                                . htmlspecialchars( $this->safeUnicodeOutput( $this->textbox2 ) ) . "\n</textarea>" );
                }
+               $wgOut->addHTML( $this->editFormTextBottom );
                $wgOut->addHTML( "</form>\n" );
                if ( !$wgUser->getOption( 'previewontop' ) ) {
 
                        if ( $this->formtype == 'preview') {
-                               $this->showPreview();
+                               $this->showPreview( $previewOutput );
                        } else {
                                $wgOut->addHTML( '<div id="wikiPreview"></div>' );
                        }
-               
+
                        if ( $this->formtype == 'diff') {
-                               $wgOut->addHTML( $this->getDiff() );
+                               $this->showDiff();
                        }
 
                }
@@ -1233,55 +1309,23 @@ END
        /**
         * Append preview output to $wgOut.
         * Includes category rendering if this is a category page.
-        * @private
+        *
+        * @param string $text The HTML to be output for the preview.
         */
-       function showPreview() {
+       private function showPreview( $text ) {
                global $wgOut;
+
                $wgOut->addHTML( '<div id="wikiPreview">' );
                if($this->mTitle->getNamespace() == NS_CATEGORY) {
                        $this->mArticle->openShowCategory();
                }
-               $previewOutput = $this->getPreviewText();
-               $wgOut->addHTML( $previewOutput );
+               $wgOut->addHTML( $text );
                if($this->mTitle->getNamespace() == NS_CATEGORY) {
                        $this->mArticle->closeShowCategory();
                }
-               $wgOut->addHTML( "<br style=\"clear:both;\" />\n" );
                $wgOut->addHTML( '</div>' );
        }
 
-       /**
-        * Prepare a list of templates used by this page. Returns HTML.
-        */
-       function formatTemplates() {
-               global $wgUser;
-
-               $fname = 'EditPage::formatTemplates';
-               wfProfileIn( $fname );
-
-               $sk =& $wgUser->getSkin();
-
-               $outText = '';
-               $templates = $this->mArticle->getUsedTemplates();
-               if ( count( $templates ) > 0 ) {
-                       # Do a batch existence check
-                       $batch = new LinkBatch;
-                       foreach( $templates as $title ) {
-                               $batch->addObj( $title );
-                       }
-                       $batch->execute();
-
-                       # Construct the HTML
-                       $outText = '<br /><span class="mw-templatesUsedExplanation">'. wfMsgExt( 'templatesused', array( 'parseinline' ) ) . '</span><ul>';
-                       foreach ( $templates as $titleObj ) {
-                               $outText .= '<li>' . $sk->makeLinkObj( $titleObj ) . '</li>';
-                       }
-                       $outText .= '</ul>';
-               }
-               wfProfileOut( $fname );
-               return $outText;
-       }
-
        /**
         * Live Preview lets us fetch rendered preview page content and
         * add it to the page without refreshing the whole page.
@@ -1305,7 +1349,7 @@ END
        }
 
        function getLastDelete() {
-               $dbr =& wfGetDB( DB_SLAVE );
+               $dbr = wfGetDB( DB_SLAVE );
                $fname = 'EditPage::getLastDelete';
                $res = $dbr->select(
                        array( 'logging', 'user' ),
@@ -1346,7 +1390,11 @@ END
                wfProfileIn( $fname );
 
                if ( $this->mTriedSave && !$this->mTokenOk ) {
-                       $msg = 'session_fail_preview';
+                       if ( $this->mTokenOkExceptSuffix ) {
+                               $msg = 'token_suffix_mismatch';
+                       } else {
+                               $msg = 'session_fail_preview';
+                       }
                } else {
                        $msg = 'previewnote';
                }
@@ -1369,7 +1417,7 @@ END
 
                # don't parse user css/js, show message about preview
                # XXX: stupid php bug won't let us use $wgTitle->isCssJsSubpage() here
-               
+
                if ( $this->isCssJsSubpage ) {
                        if(preg_match("/\\.css$/", $wgTitle->getText() ) ) {
                                $previewtext = wfMsg('usercsspreview');
@@ -1397,6 +1445,13 @@ END
 
                        $previewHTML = $parserOutput->getText();
                        $wgOut->addParserOutputNoText( $parserOutput );
+                       
+                       # ParserOutput might have altered the page title, so reset it
+                       $wgOut->setPageTitle( wfMsg( 'editing', $this->mTitle->getPrefixedText() ) );                   
+
+                       foreach ( $parserOutput->getTemplates() as $ns => $template)
+                               foreach ( array_keys( $template ) as $dbk)
+                                       $this->mPreviewTemplates[] = Title::makeTitle($ns, $dbk);
 
                        wfProfileOut( $fname );
                        return $previewhead . $previewHTML;
@@ -1409,16 +1464,16 @@ END
        function blockedPage() {
                global $wgOut, $wgUser;
                $wgOut->blockedPage( false ); # Standard block notice on the top, don't 'return'
-               
+
                # If the user made changes, preserve them when showing the markup
-               # (This happens when a user is blocked during edit, for instance)               
+               # (This happens when a user is blocked during edit, for instance)
                $first = $this->firsttime || ( !$this->save && $this->textbox1 == '' );
                if( $first ) {
                        $source = $this->mTitle->exists() ? $this->getContent() : false;
                } else {
                        $source = $this->textbox1;
                }
-       
+
                # Spit out the source or the user's modified version
                if( $source !== false ) {
                        $rows = $wgUser->getOption( 'rows' );
@@ -1436,14 +1491,14 @@ END
        function userNotLoggedInPage() {
                global $wgUser, $wgOut;
                $skin = $wgUser->getSkin();
-               
+
                $loginTitle = SpecialPage::getTitleFor( 'Userlogin' );
                $loginLink = $skin->makeKnownLinkObj( $loginTitle, wfMsgHtml( 'loginreqlink' ), 'returnto=' . $this->mTitle->getPrefixedUrl() );
-       
+
                $wgOut->setPageTitle( wfMsg( 'whitelistedittitle' ) );
                $wgOut->setRobotPolicy( 'noindex,nofollow' );
                $wgOut->setArticleRelated( false );
-               
+
                $wgOut->addHtml( wfMsgWikiHtml( 'whitelistedittext', $loginLink ) );
                $wgOut->returnToMain( false, $this->mTitle->getPrefixedUrl() );
        }
@@ -1459,11 +1514,26 @@ END
                $wgOut->setPageTitle( wfMsg( 'confirmedittitle' ) );
                $wgOut->setRobotPolicy( 'noindex,nofollow' );
                $wgOut->setArticleRelated( false );
-               
+
                $wgOut->addWikiText( wfMsg( 'confirmedittext' ) );
                $wgOut->returnToMain( false );
        }
 
+       /**
+        * Creates a basic error page which informs the user that
+        * they have attempted to edit a nonexistant section.
+        */
+       function noSuchSectionPage() {
+               global $wgOut;
+
+               $wgOut->setPageTitle( wfMsg( 'nosuchsectiontitle' ) );
+               $wgOut->setRobotPolicy( 'noindex,nofollow' );
+               $wgOut->setArticleRelated( false );
+
+               $wgOut->addWikiText( wfMsg( 'nosuchsectiontext', $this->section ) );
+               $wgOut->returnToMain( false, $this->mTitle->getPrefixedUrl() );
+       }
+
        /**
         * Produce the stock "your edit contains spam" page
         *
@@ -1479,7 +1549,7 @@ END
                $wgOut->addWikiText( wfMsg( 'spamprotectiontext' ) );
                if ( $match )
                        $wgOut->addWikiText( wfMsg( 'spamprotectionmatch', "<nowiki>{$match}</nowiki>" ) );
-                       
+
                $wgOut->returnToMain( false );
        }
 
@@ -1491,7 +1561,7 @@ END
                $fname = 'EditPage::mergeChangesInto';
                wfProfileIn( $fname );
 
-               $db =& wfGetDB( DB_MASTER );
+               $db = wfGetDB( DB_MASTER );
 
                // This is the revision the editor started from
                $baseRevision = Revision::loadFromTimestamp(
@@ -1511,6 +1581,7 @@ END
                }
                $currentText = $currentRevision->getText();
 
+               $result = '';
                if( wfMerge( $baseText, $editText, $currentText, $result ) ){
                        $editText = $result;
                        wfProfileOut( $fname );
@@ -1584,90 +1655,102 @@ END
                 * can figure out a way to make them work in IE. However, we should make
                 * sure these keys are not defined on the edit page.
                 */
-               $toolarray=array(
-                       array(  'image'=>'button_bold.png',
-                                       'open'  =>      "\'\'\'",
-                                       'close' =>      "\'\'\'",
-                                       'sample'=>      wfMsg('bold_sample'),
-                                       'tip'   =>      wfMsg('bold_tip'),
-                                       'key'   =>      'B'
-                               ),
-                       array(  'image'=>'button_italic.png',
-                                       'open'  =>      "\'\'",
-                                       'close' =>      "\'\'",
-                                       'sample'=>      wfMsg('italic_sample'),
-                                       'tip'   =>      wfMsg('italic_tip'),
-                                       'key'   =>      'I'
-                               ),
-                       array(  'image'=>'button_link.png',
-                                       'open'  =>      '[[',
-                                       'close' =>      ']]',
-                                       'sample'=>      wfMsg('link_sample'),
-                                       'tip'   =>      wfMsg('link_tip'),
-                                       'key'   =>      'L'
-                               ),
-                       array(  'image'=>'button_extlink.png',
-                                       'open'  =>      '[',
-                                       'close' =>      ']',
-                                       'sample'=>      wfMsg('extlink_sample'),
-                                       'tip'   =>      wfMsg('extlink_tip'),
-                                       'key'   =>      'X'
-                               ),
-                       array(  'image'=>'button_headline.png',
-                                       'open'  =>      "\\n== ",
-                                       'close' =>      " ==\\n",
-                                       'sample'=>      wfMsg('headline_sample'),
-                                       'tip'   =>      wfMsg('headline_tip'),
-                                       'key'   =>      'H'
-                               ),
-                       array(  'image'=>'button_image.png',
-                                       'open'  =>      '[['.$wgContLang->getNsText(NS_IMAGE).":",
-                                       'close' =>      ']]',
-                                       'sample'=>      wfMsg('image_sample'),
-                                       'tip'   =>      wfMsg('image_tip'),
-                                       'key'   =>      'D'
-                               ),
-                       array(  'image' =>'button_media.png',
-                                       'open'  =>      '[['.$wgContLang->getNsText(NS_MEDIA).':',
-                                       'close' =>      ']]',
-                                       'sample'=>      wfMsg('media_sample'),
-                                       'tip'   =>      wfMsg('media_tip'),
-                                       'key'   =>      'M'
-                               ),
-                       array(  'image' =>'button_math.png',
-                                       'open'  =>      "<math>",
-                                       'close' =>      "<\\/math>",
-                                       'sample'=>      wfMsg('math_sample'),
-                                       'tip'   =>      wfMsg('math_tip'),
-                                       'key'   =>      'C'
-                               ),
-                       array(  'image' =>'button_nowiki.png',
-                                       'open'  =>      "<nowiki>",
-                                       'close' =>      "<\\/nowiki>",
-                                       'sample'=>      wfMsg('nowiki_sample'),
-                                       'tip'   =>      wfMsg('nowiki_tip'),
-                                       'key'   =>      'N'
-                               ),
-                       array(  'image' =>'button_sig.png',
-                                       'open'  =>      '--~~~~',
-                                       'close' =>      '',
-                                       'sample'=>      '',
-                                       'tip'   =>      wfMsg('sig_tip'),
-                                       'key'   =>      'Y'
-                               ),
-                       array(  'image' =>'button_hr.png',
-                                       'open'  =>      "\\n----\\n",
-                                       'close' =>      '',
-                                       'sample'=>      '',
-                                       'tip'   =>      wfMsg('hr_tip'),
-                                       'key'   =>      'R'
-                               )
+               $toolarray = array(
+                       array(  'image' => 'button_bold.png',
+                               'id'    => 'mw-editbutton-bold',
+                               'open'  => '\\\'\\\'\\\'',
+                               'close' => '\\\'\\\'\\\'',
+                               'sample'=> wfMsg('bold_sample'),
+                               'tip'   => wfMsg('bold_tip'),
+                               'key'   => 'B'
+                       ),
+                       array(  'image' => 'button_italic.png',
+                               'id'    => 'mw-editbutton-italic',
+                               'open'  => '\\\'\\\'',
+                               'close' => '\\\'\\\'',
+                               'sample'=> wfMsg('italic_sample'),
+                               'tip'   => wfMsg('italic_tip'),
+                               'key'   => 'I'
+                       ),
+                       array(  'image' => 'button_link.png',
+                               'id'    => 'mw-editbutton-link',
+                               'open'  => '[[',
+                               'close' => ']]',
+                               'sample'=> wfMsg('link_sample'),
+                               'tip'   => wfMsg('link_tip'),
+                               'key'   => 'L'
+                       ),
+                       array(  'image' => 'button_extlink.png',
+                               'id'    => 'mw-editbutton-extlink',
+                               'open'  => '[',
+                               'close' => ']',
+                               'sample'=> wfMsg('extlink_sample'),
+                               'tip'   => wfMsg('extlink_tip'),
+                               'key'   => 'X'
+                       ),
+                       array(  'image' => 'button_headline.png',
+                               'id'    => 'mw-editbutton-headline',
+                               'open'  => "\\n== ",
+                               'close' => " ==\\n",
+                               'sample'=> wfMsg('headline_sample'),
+                               'tip'   => wfMsg('headline_tip'),
+                               'key'   => 'H'
+                       ),
+                       array(  'image' => 'button_image.png',
+                               'id'    => 'mw-editbutton-image',
+                               'open'  => '[['.$wgContLang->getNsText(NS_IMAGE).":",
+                               'close' => ']]',
+                               'sample'=> wfMsg('image_sample'),
+                               'tip'   => wfMsg('image_tip'),
+                               'key'   => 'D'
+                       ),
+                       array(  'image' => 'button_media.png',
+                               'id'    => 'mw-editbutton-media',
+                               'open'  => '[['.$wgContLang->getNsText(NS_MEDIA).':',
+                               'close' => ']]',
+                               'sample'=> wfMsg('media_sample'),
+                               'tip'   => wfMsg('media_tip'),
+                               'key'   => 'M'
+                       ),
+                       array(  'image' => 'button_math.png',
+                               'id'    => 'mw-editbutton-math',
+                               'open'  => "<math>",
+                               'close' => "<\\/math>",
+                               'sample'=> wfMsg('math_sample'),
+                               'tip'   => wfMsg('math_tip'),
+                               'key'   => 'C'
+                       ),
+                       array(  'image' => 'button_nowiki.png',
+                               'id'    => 'mw-editbutton-nowiki',
+                               'open'  => "<nowiki>",
+                               'close' => "<\\/nowiki>",
+                               'sample'=> wfMsg('nowiki_sample'),
+                               'tip'   => wfMsg('nowiki_tip'),
+                               'key'   => 'N'
+                       ),
+                       array(  'image' => 'button_sig.png',
+                               'id'    => 'mw-editbutton-signature',
+                               'open'  => '--~~~~',
+                               'close' => '',
+                               'sample'=> '',
+                               'tip'   => wfMsg('sig_tip'),
+                               'key'   => 'Y'
+                       ),
+                       array(  'image' => 'button_hr.png',
+                               'id'    => 'mw-editbutton-hr',
+                               'open'  => "\\n----\\n",
+                               'close' => '',
+                               'sample'=> '',
+                               'tip'   => wfMsg('hr_tip'),
+                               'key'   => 'R'
+                       )
                );
                $toolbar = "<div id='toolbar'>\n";
                $toolbar.="<script type='$wgJsMimeType'>\n/*<![CDATA[*/\n";
 
                foreach($toolarray as $tool) {
 
+                       $cssId = $tool['id'];
                        $image=$wgStylePath.'/common/images/'.$tool['image'];
                        $open=$tool['open'];
                        $close=$tool['close'];
@@ -1681,7 +1764,7 @@ END
 
                        #$key = $tool["key"];
 
-                       $toolbar.="addButton('$image','$tip','$open','$close','$sample');\n";
+                       $toolbar.="addButton('$image','$tip','$open','$close','$sample','$cssId');\n";
                }
 
                $toolbar.="/*]]>*/\n</script>";
@@ -1689,6 +1772,127 @@ END
                return $toolbar;
        }
 
+       /**
+        * Returns an array of html code of the following checkboxes:
+        * minor and watch
+        *
+        * @param $tabindex Current tabindex
+        * @param $skin Skin object
+        * @param $checked Array of checkbox => bool, where bool indicates the checked
+        *                 status of the checkbox
+        *
+        * @return array
+        */
+       public static function getCheckboxes( &$tabindex, $skin, $checked ) {
+               global $wgUser;
+
+               $checkboxes = array();
+
+               $checkboxes['minor'] = '';
+               $minorLabel = wfMsgExt('minoredit', array('parseinline'));
+               if ( $wgUser->isAllowed('minoredit') ) {
+                       $attribs = array(
+                               'tabindex'  => ++$tabindex,
+                               'accesskey' => wfMsg( 'accesskey-minoredit' ),
+                               'id'        => 'wpMinoredit',
+                       );
+                       $checkboxes['minor'] =
+                               Xml::check( 'wpMinoredit', $checked['minor'], $attribs ) .
+                               "&nbsp;<label for='wpMinoredit'".$skin->tooltipAndAccesskey('minoredit').">{$minorLabel}</label>";
+               }
+
+               $watchLabel = wfMsgExt('watchthis', array('parseinline'));
+               $checkboxes['watch'] = '';
+               if ( $wgUser->isLoggedIn() ) {
+                       $attribs = array(
+                               'tabindex'  => ++$tabindex,
+                               'accesskey' => wfMsg( 'accesskey-watch' ),
+                               'id'        => 'wpWatchthis',
+                       );
+                       $checkboxes['watch'] =
+                               Xml::check( 'wpWatchthis', $checked['watch'], $attribs ) .
+                               "&nbsp;<label for='wpWatchthis'".$skin->tooltipAndAccesskey('watch').">{$watchLabel}</label>";
+               }
+               return $checkboxes;
+       }
+
+       /**
+        * Returns an array of html code of the following buttons:
+        * save, diff, preview and live
+        *
+        * @param $tabindex Current tabindex
+        *
+        * @return array
+        */
+       public function getEditButtons(&$tabindex) {
+               global $wgLivePreview, $wgUser;
+
+               $buttons = array();
+
+               $temp = array(
+                       'id'        => 'wpSave',
+                       'name'      => 'wpSave',
+                       'type'      => 'submit',
+                       'tabindex'  => ++$tabindex,
+                       'value'     => wfMsg('savearticle'),
+                       'accesskey' => wfMsg('accesskey-save'),
+                       'title'     => wfMsg( 'tooltip-save' ).' ['.wfMsg( 'accesskey-save' ).']',
+               );
+               $buttons['save'] = wfElement('input', $temp, '');
+
+               ++$tabindex; // use the same for preview and live preview
+               if ( $wgLivePreview && $wgUser->getOption( 'uselivepreview' ) ) {
+                       $temp = array(
+                               'id'        => 'wpPreview',
+                               'name'      => 'wpPreview',
+                               'type'      => 'submit',
+                               'tabindex'  => $tabindex,
+                               'value'     => wfMsg('showpreview'),
+                               'accesskey' => '',
+                               'title'     => wfMsg( 'tooltip-preview' ).' ['.wfMsg( 'accesskey-preview' ).']',
+                               'style'     => 'display: none;',
+                       );
+                       $buttons['preview'] = wfElement('input', $temp, '');
+
+                       $temp = array(
+                               'id'        => 'wpLivePreview',
+                               'name'      => 'wpLivePreview',
+                               'type'      => 'submit',
+                               'tabindex'  => $tabindex,
+                               'value'     => wfMsg('showlivepreview'),
+                               'accesskey' => wfMsg('accesskey-preview'),
+                               'title'     => '',
+                               'onclick'   => $this->doLivePreviewScript(),
+                       );
+                       $buttons['live'] = wfElement('input', $temp, '');
+               } else {
+                       $temp = array(
+                               'id'        => 'wpPreview',
+                               'name'      => 'wpPreview',
+                               'type'      => 'submit',
+                               'tabindex'  => $tabindex,
+                               'value'     => wfMsg('showpreview'),
+                               'accesskey' => wfMsg('accesskey-preview'),
+                               'title'     => wfMsg( 'tooltip-preview' ).' ['.wfMsg( 'accesskey-preview' ).']',
+                       );
+                       $buttons['preview'] = wfElement('input', $temp, '');
+                       $buttons['live'] = '';
+               }
+
+               $temp = array(
+                       'id'        => 'wpDiff',
+                       'name'      => 'wpDiff',
+                       'type'      => 'submit',
+                       'tabindex'  => ++$tabindex,
+                       'value'     => wfMsg('showdiff'),
+                       'accesskey' => wfMsg('accesskey-diff'),
+                       'title'     => wfMsg( 'tooltip-diff' ).' ['.wfMsg( 'accesskey-diff' ).']',
+               );
+               $buttons['diff'] = wfElement('input', $temp, '');
+
+               return $buttons;
+       }
+
        /**
         * Output preview text only. This can be sucked into the edit page
         * via JavaScript, and saves the server time rendering the skin as
@@ -1697,19 +1901,23 @@ END
         * failure, etc).
         *
         * @todo This doesn't include category or interlanguage links.
-        *       Would need to enhance it a bit, maybe wrap them in XML
-        *       or something... that might also require more skin
+        *       Would need to enhance it a bit, <s>maybe wrap them in XML
+        *       or something...</s> that might also require more skin
         *       initialization, so check whether that's a problem.
         */
        function livePreview() {
                global $wgOut;
                $wgOut->disable();
-               header( 'Content-type: text/xml' );
+               header( 'Content-type: text/xml; charset=utf-8' );
                header( 'Cache-control: no-cache' );
-               # FIXME
-               echo $this->getPreviewText( );
-               /* To not shake screen up and down between preview and live-preview */
-               echo "<br style=\"clear:both;\" />\n";
+
+               $s =
+               '<?xml version="1.0" encoding="UTF-8" ?>' . "\n" .
+               Xml::openElement( 'livepreview' ) .
+               Xml::element( 'preview', null, $this->getPreviewText() ) .
+               Xml::element( 'br', array( 'style' => 'clear: both;' ) ) .
+               Xml::closeElement( 'livepreview' );
+               echo $s;
        }
 
 
@@ -1719,10 +1927,8 @@ END
         *
         * If this is a section edit, we'll replace the section as for final
         * save and then make a comparison.
-        *
-        * @return string HTML
         */
-       function getDiff() {
+       function showDiff() {
                $oldtext = $this->mArticle->fetchContent();
                $newtext = $this->mArticle->replaceSection(
                        $this->section, $this->textbox1, $this->summary, $this->edittime );
@@ -1733,11 +1939,13 @@ END
                        $de = new DifferenceEngine( $this->mTitle );
                        $de->setText( $oldtext, $newtext );
                        $difftext = $de->getDiff( $oldtitle, $newtitle );
+                       $de->showDiffStyle();
                } else {
                        $difftext = '';
                }
 
-               return '<div id="wikiDiff">' . $difftext . '</div>';
+               global $wgOut;
+               $wgOut->addHtml( '<div id="wikiDiff">' . $difftext . '</div>' );
        }
 
        /**
@@ -1860,7 +2068,32 @@ END
                $wgOut->setPageTitle( wfMsg( 'nocreatetitle' ) );
                $wgOut->addWikiText( wfMsg( 'nocreatetext' ) );
        }
-
+       
+       /**
+        * If there are rows in the deletion log for this page, show them,
+        * along with a nice little note for the user
+        *
+        * @param OutputPage $out
+        */
+       private function showDeletionLog( $out ) {
+               $title = $this->mArticle->getTitle();
+               $reader = new LogReader(
+                       new FauxRequest(
+                               array(
+                                       'page' => $title->getPrefixedText(),
+                                       'type' => 'delete',
+                                       )
+                       )
+               );
+               if( $reader->hasRows() ) {
+                       $out->addHtml( '<div id="mw-recreate-deleted-warn">' );
+                       $out->addWikiText( wfMsg( 'recreate-deleted-warn' ) );
+                       $viewer = new LogViewer( $reader );
+                       $viewer->showList( $out );
+                       $out->addHtml( '</div>' );                      
+               }                               
+       }
+       
 }
 
-?>
+