Remove $wgColorErrors. Apparently unused at least since r17991 at 2006-11-29
[lhc/web/wiklou.git] / includes / EditPage.php
index d25e0f2..77627cb 100644 (file)
@@ -129,8 +129,8 @@ class EditPage {
                wfProfileIn( __METHOD__ );
                # Get variables from query string :P
                $section = $wgRequest->getVal( 'section' );
-                       
-               $preload = $wgRequest->getVal( 'preload', 
+
+               $preload = $wgRequest->getVal( 'preload',
                        // Custom preload text for new sections
                        $section === 'new' ? 'MediaWiki:addsection-preload' : '' );
                $undoafter = $wgRequest->getVal( 'undoafter' );
@@ -143,7 +143,6 @@ class EditPage {
                        if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
                                # If this is a system message, get the default text.
                                list( $message, $lang ) = $wgMessageCache->figureMessage( $wgContLang->lcfirst( $this->mTitle->getText() ) );
-                               $wgMessageCache->loadAllMessages( $lang );
                                $text = wfMsgGetKey( $message, false, $lang, false );
                                if( wfEmptyMsg( $message, $text ) )
                                        $text = $this->getPreloadedText( $preload );
@@ -320,7 +319,7 @@ class EditPage {
                }
 
                $wgOut->addScriptFile( 'edit.js' );
-               
+
                if ( $wgUser->getOption( 'uselivepreview', false ) ) {
                        $wgOut->includeJQuery();
                        $wgOut->addScriptFile( 'preview.js' );
@@ -493,7 +492,7 @@ class EditPage {
        /**
         * Does this EditPage class support section editing?
         * This is used by EditPage subclasses to indicate their ui cannot handle section edits
-        * 
+        *
         * @return bool
         */
        protected function isSectionEditSupported() {
@@ -505,8 +504,8 @@ class EditPage {
         * This is used by EditPage subclasses when simply customizing the action
         * variable in the constructor is not enough. This can be used when the
         * EditPage lives inside of a Special page rather than a custom page action.
-        * 
-        * @param Title $title The title for which is being edited (where we go to for &action= links)
+        *
+        * @param $title Title object for which is being edited (where we go to for &action= links)
         * @return string
         */
        protected function getActionURL( Title $title ) {
@@ -655,8 +654,8 @@ class EditPage {
         * posted form to be placed in $this->textbox1, if using customized input
         * this method should be overrided and return the page text that will be used
         * for saving, preview parsing and so on...
-        * 
-        * @praram WebRequest $request
+        *
+        * @param $request WebRequest
         */
        protected function importContentFormData( &$request ) {
                return; // Don't do anything, EditPage already extracted wpTextbox1
@@ -690,7 +689,7 @@ class EditPage {
 
                if ( $namespace == NS_MEDIAWIKI ) {
                        # Show a warning if editing an interface message
-                       $wgOut->wrapWikiMsg( "<div class='mw-editinginterface'>\n$1</div>", 'editinginterface' );
+                       $wgOut->wrapWikiMsg( "<div class='mw-editinginterface'>\n$1\n</div>", 'editinginterface' );
                }
 
                # Show a warning message when someone creates/edits a user (talk) page but the user does not exist
@@ -701,7 +700,7 @@ class EditPage {
                        $user = User::newFromName( $username, false /* allow IP users*/ );
                        $ip = User::isIP( $username );
                        if ( !$user->isLoggedIn() && !$ip ) { # User does not exist
-                               $wgOut->wrapWikiMsg( "<div class=\"mw-userpage-userdoesnotexist error\">\n$1</div>",
+                               $wgOut->wrapWikiMsg( "<div class=\"mw-userpage-userdoesnotexist error\">\n$1\n</div>",
                                        array( 'userpage-userdoesnotexist', $username ) );
                        } else if ( $user->isBlocked() ) { # Show log extract if the user is currently blocked
                                LogEventsList::showLogExtract(
@@ -723,9 +722,9 @@ class EditPage {
                # Try to add a custom edit intro, or use the standard one if this is not possible.
                if ( !$this->showCustomIntro() && !$this->mTitle->exists() ) {
                        if ( $wgUser->isLoggedIn() ) {
-                               $wgOut->wrapWikiMsg( "<div class=\"mw-newarticletext\">\n$1</div>", 'newarticletext' );
+                               $wgOut->wrapWikiMsg( "<div class=\"mw-newarticletext\">\n$1\n</div>", 'newarticletext' );
                        } else {
-                               $wgOut->wrapWikiMsg( "<div class=\"mw-newarticletextanon\">\n$1</div>", 'newarticletextanon' );
+                               $wgOut->wrapWikiMsg( "<div class=\"mw-newarticletextanon\">\n$1\n</div>", 'newarticletextanon' );
                        }
                }
                # Give a notice if the user is editing a deleted/moved page...
@@ -765,7 +764,7 @@ class EditPage {
         * @return one of the constants describing the result
         */
        function internalAttemptSave( &$result, $bot = false ) {
-               global $wgFilterCallback, $wgUser, $wgOut, $wgParser;
+               global $wgFilterCallback, $wgUser, $wgParser;
                global $wgMaxArticleSize;
 
                wfProfileIn( __METHOD__  );
@@ -905,11 +904,20 @@ class EditPage {
 
                        $isComment = ( $this->section == 'new' );
 
-                       $this->mArticle->insertNewArticle( $this->textbox1, $this->summary,
-                               $this->minoredit, $this->watchthis, false, $isComment, $bot );
+                       $flags = EDIT_NEW | EDIT_DEFER_UPDATES | EDIT_AUTOSUMMARY |
+                               ( $this->minoredit ? EDIT_MINOR : 0 ) |
+                               ( $bot ? EDIT_FORCE_BOT : 0 );
+                       $status = $this->mArticle->doEdit( $this->textbox1, $this->summary, $flags,
+                               false, null, $this->watchthis, $isComment, '', true );
 
+                       if ( $status->isOK() ) {
+                               wfProfileOut( __METHOD__ );
+                               return self::AS_SUCCESS_NEW_ARTICLE;
+                       } else {
+                               $result = $status->getErrorsArray();
+                       }
                        wfProfileOut( __METHOD__ );
-                       return self::AS_SUCCESS_NEW_ARTICLE;
+                       return self::AS_END;
                }
 
                # Article exists. Check for edit conflict.
@@ -1017,7 +1025,7 @@ class EditPage {
                                return self::AS_TEXTBOX_EMPTY;
                        }
                        if ( $this->summary != '' ) {
-                               $sectionanchor = $wgParser->guessSectionNameFromWikiText( $this->summary );
+                               $sectionanchor = $wgParser->guessLegacySectionNameFromWikiText( $this->summary );
                                # This is a new section, so create a link to the new section
                                # in the revision summary.
                                $cleanSummary = $wgParser->stripSectionName( $this->summary );
@@ -1031,7 +1039,7 @@ class EditPage {
                        # we can't deal with anchors, includes, html etc in the header for now,
                        # headline would need to be parsed to improve this
                        if ( $hasmatch and strlen( $matches[2] ) > 0 ) {
-                               $sectionanchor = $wgParser->guessSectionNameFromWikiText( $matches[2] );
+                               $sectionanchor = $wgParser->guessLegacySectionNameFromWikiText( $matches[2] );
                        }
                }
                wfProfileOut( __METHOD__ . '-sectionanchor' );
@@ -1051,14 +1059,20 @@ class EditPage {
                        return self::AS_MAX_ARTICLE_SIZE_EXCEEDED;
                }
 
-               # update the article here
-               if ( $this->mArticle->updateArticle( $text, $this->summary, $this->minoredit,
-                       $this->watchthis, $bot, $sectionanchor ) )
+               // Update the article here
+               $flags = EDIT_UPDATE | EDIT_DEFER_UPDATES | EDIT_AUTOSUMMARY |
+                       ( $this->minoredit ? EDIT_MINOR : 0 ) |
+                       ( $bot ? EDIT_FORCE_BOT : 0 );
+               $status = $this->mArticle->doEdit( $text, $this->summary, $flags,
+                       false, null, $this->watchthis, false, $sectionanchor, true );
+
+               if ( $status->isOK() )
                {
                        wfProfileOut( __METHOD__ );
                        return self::AS_SUCCESS_UPDATE;
                } else {
                        $this->isConflict = true;
+                       $result = $status->getErrorsArray();
                }
                wfProfileOut( __METHOD__ );
                return self::AS_END;
@@ -1140,7 +1154,6 @@ class EditPage {
                        # Already watched
                        $this->watchthis = true;
                }
-               if ( $wgUser->getOption( 'minordefault' ) ) $this->minoredit = true;
                if ( $this->textbox1 === false ) return false;
                wfProxyCheck();
                return true;
@@ -1234,7 +1247,7 @@ class EditPage {
 
                if ( $this->wasDeletedSinceLastEdit() && 'save' != $this->formtype ) {
                        $wgOut->wrapWikiMsg(
-                               "<div class='error mw-deleted-while-editing'>\n$1</div>",
+                               "<div class='error mw-deleted-while-editing'>\n$1\n</div>",
                                'deletedwhileediting' );
                } elseif ( $this->wasDeletedSinceLastEdit() ) {
                        // Hide the toolbar and edit area, user can click preview to get it back
@@ -1289,13 +1302,13 @@ HTML
                }
 
                $wgOut->addHTML( $this->editFormTextBeforeContent );
-               
+
                if ( $this->isConflict ) {
                        // In an edit conflict bypass the overrideable content form method
                        // and fallback to the raw wpTextbox1 since editconflicts can't be
                        // resolved between page source edits and custom ui edits using the
                        // custom edit ui.
-                       $this->showTextbox1();
+                       $this->showTextbox1( null, $this->getContent() );
                } else {
                        $this->showContentForm();
                }
@@ -1326,7 +1339,7 @@ HTML
 
                if ( $this->isConflict )
                        $this->showConflict();
-               
+
                $wgOut->addHTML( $this->editFormTextBottom );
                $wgOut->addHTML( "</form>\n" );
                if ( !$wgUser->getOption( 'previewontop' ) ) {
@@ -1335,11 +1348,11 @@ HTML
 
                wfProfileOut( __METHOD__ );
        }
-       
+
        protected function showHeader() {
                global $wgOut, $wgUser, $wgTitle, $wgMaxArticleSize, $wgLang;
                if ( $this->isConflict ) {
-                       $wgOut->wrapWikiMsg( "<div class='mw-explainconflict'>\n$1</div>", 'explainconflict' );
+                       $wgOut->wrapWikiMsg( "<div class='mw-explainconflict'>\n$1\n</div>", 'explainconflict' );
                        $this->edittime = $this->mArticle->getTimestamp();
                } else {
                        if ( $this->section != '' && !$this->isSectionEditSupported() ) {
@@ -1364,15 +1377,15 @@ HTML
                        }
 
                        if ( $this->missingComment ) {
-                               $wgOut->wrapWikiMsg( "<div id='mw-missingcommenttext'>\n$1</div>", 'missingcommenttext' );
+                               $wgOut->wrapWikiMsg( "<div id='mw-missingcommenttext'>\n$1\n</div>", 'missingcommenttext' );
                        }
 
                        if ( $this->missingSummary && $this->section != 'new' ) {
-                               $wgOut->wrapWikiMsg( "<div id='mw-missingsummary'>\n$1</div>", 'missingsummary' );
+                               $wgOut->wrapWikiMsg( "<div id='mw-missingsummary'>\n$1\n</div>", 'missingsummary' );
                        }
 
                        if ( $this->missingSummary && $this->section == 'new' ) {
-                               $wgOut->wrapWikiMsg( "<div id='mw-missingcommentheader'>\n$1</div>", 'missingcommentheader' );
+                               $wgOut->wrapWikiMsg( "<div id='mw-missingcommentheader'>\n$1\n</div>", 'missingcommentheader' );
                        }
 
                        if ( $this->hookError !== '' ) {
@@ -1387,9 +1400,9 @@ HTML
                        // Let sysop know that this will make private content public if saved
 
                                if ( !$this->mArticle->mRevision->userCan( Revision::DELETED_TEXT ) ) {
-                                       $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1</div>\n", 'rev-deleted-text-permission' );
+                                       $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1\n</div>\n", 'rev-deleted-text-permission' );
                                } else if ( $this->mArticle->mRevision->isDeleted( Revision::DELETED_TEXT ) ) {
-                                       $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1</div>\n", 'rev-deleted-text-view' );
+                                       $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1\n</div>\n", 'rev-deleted-text-view' );
                                }
 
                                if ( !$this->mArticle->mRevision->isCurrent() ) {
@@ -1401,19 +1414,23 @@ HTML
 
                if ( wfReadOnly() ) {
                        $wgOut->wrapWikiMsg( "<div id=\"mw-read-only-warning\">\n$1\n</div>", array( 'readonlywarning', wfReadOnlyReason() ) );
-               } elseif ( $wgUser->isAnon() && $this->formtype != 'preview' ) {
-                       $wgOut->wrapWikiMsg( "<div id=\"mw-anon-edit-warning\">\n$1</div>", 'anoneditwarning' );
+               } elseif ( $wgUser->isAnon() ) {
+                       if ( $this->formtype != 'preview' ) {
+                               $wgOut->wrapWikiMsg( "<div id=\"mw-anon-edit-warning\">\n$1</div>", 'anoneditwarning' );
+                       } else {
+                               $wgOut->wrapWikiMsg( "<div id=\"mw-anon-preview-warning\">\n$1</div>", 'anonpreviewwarning' );
+                       }
                } else {
                        if ( $this->isCssJsSubpage ) {
                                # Check the skin exists
                                if ( !$this->isValidCssJsSubpage ) {
-                                       $wgOut->addWikiMsg( 'userinvalidcssjstitle', $wgTitle->getSkinFromCssJsSubpage() );
+                                       $wgOut->wrapWikiMsg( "<div class='error' id='mw-userinvalidcssjstitle'>\n$1\n</div>", array( 'userinvalidcssjstitle', $wgTitle->getSkinFromCssJsSubpage() ) );
                                }
                                if ( $this->formtype !== 'preview' ) {
                                        if ( $this->isCssSubpage )
-                                               $wgOut->addWikiMsg( 'usercssyoucanpreview' );
+                                               $wgOut->wrapWikiMsg( "<div id='mw-usercssyoucanpreview'>\n$1\n</div>", array( 'usercssyoucanpreview' ) );
                                        if ( $this->isJsSubpage )
-                                               $wgOut->addWikiMsg( 'userjsyoucanpreview' );
+                                               $wgOut->wrapWikiMsg( "<div id='mw-userjsyoucanpreview'>\n$1\n</div>", array( 'userjsyoucanpreview' ) );
                                }
                        }
                }
@@ -1472,23 +1489,25 @@ HTML
         * Note that you do not need to worry about the label's for=, it will be
         * inferred by the id given to the input. You can remove them both by
         * passing array( 'id' => false ) to $userInputAttrs.
-        * 
+        *
         * @param $summary The value of the summary input
         * @param $labelText The html to place inside the label
-        * @param $userInputAttrs An array of attrs to use on the input
-        * @param $userSpanAttrs An array of attrs to use on the span inside the label
-        * 
+        * @param $inputAttrs An array of attrs to use on the input
+        * @param $spanLabelAttrs An array of attrs to use on the span inside the label
+        *
         * @return array An array in the format array( $label, $input )
         */
        function getSummaryInput($summary = "", $labelText = null, $inputAttrs = null, $spanLabelAttrs = null) {
+               global $wgUser;
+               //Note: the maxlength is overriden in JS to 250 and to make it use UTF-8 bytes, not characters.
                $inputAttrs = ( is_array($inputAttrs) ? $inputAttrs : array() ) + array(
                        'id' => 'wpSummary',
                        'maxlength' => '200',
                        'tabindex' => '1',
                        'size' => 60,
                        'spellcheck' => 'true',
-               );
-               
+               ) + $wgUser->getSkin()->tooltipAndAccessKeyAttribs( 'summary' );
+
                $spanLabelAttrs = ( is_array($spanLabelAttrs) ? $spanLabelAttrs : array() ) + array(
                        'class' => $this->missingSummary ? 'mw-summarymissed' : 'mw-summary',
                        'id' => "wpSummaryLabel"
@@ -1506,11 +1525,11 @@ HTML
        }
 
        /**
-        * @param bool $isSubjectPreview true if this is the section subject/title
-        *                               up top, or false if this is the comment
-        *                               summary down below the textarea
-        * @param string $summary The text of the summary to display
-        * @return string
+        * @param $isSubjectPreview Boolean: true if this is the section subject/title
+        *                          up top, or false if this is the comment summary
+        *                          down below the textarea
+        * @param $summary String: The text of the summary to display
+        * @return String
         */
        protected function showSummaryInput( $isSubjectPreview, $summary = "" ) {
                global $wgOut, $wgContLang;
@@ -1530,23 +1549,25 @@ HTML
        }
 
        /**
-        * @param bool $isSubjectPreview true if this is the section subject/title
-        *                               up top, or false if this is the comment
-        *                               summary down below the textarea
-        * @param string $summary The text of the summary to display
-        * @return string
+        * @param $isSubjectPreview Boolean: true if this is the section subject/title
+        *                          up top, or false if this is the comment summary
+        *                          down below the textarea
+        * @param $summary String: the text of the summary to display
+        * @return String
         */
        protected function getSummaryPreview( $isSubjectPreview, $summary = "" ) {
                if ( !$summary || ( !$this->preview && !$this->diff ) )
                        return "";
-               
+
                global $wgParser, $wgUser;
                $sk = $wgUser->getSkin();
-               
+
                if ( $isSubjectPreview )
                        $summary = wfMsgForContent( 'newsectionsummary', $wgParser->stripSectionName( $summary ) );
 
-               $summary = wfMsgExt( 'subject-preview', 'parseinline' ) . $sk->commentBlock( $summary, $this->mTitle, !!$isSubjectPreview );
+               $message = $isSubjectPreview ? 'subject-preview' : 'summary-preview';
+
+               $summary = wfMsgExt( $message, 'parseinline' ) . $sk->commentBlock( $summary, $this->mTitle, $isSubjectPreview );
                return Xml::tags( 'div', array( 'class' => 'mw-summary-preview' ), $summary );
        }
 
@@ -1564,7 +1585,7 @@ INPUTS
                if ( !$this->checkUnicodeCompliantBrowser() )
                        $wgOut->addHTML(Xml::hidden( 'safemode', '1' ));
        }
-       
+
        protected function showFormAfterText() {
                global $wgOut, $wgUser;
                /**
@@ -1589,8 +1610,8 @@ INPUTS
         * be it a form, or simply wpTextbox1 with a modified content that will be
         * reverse modified when extracted from the post data.
         * Note that this is basically the inverse for importContentFormData
-        * 
-        * @praram WebRequest $request
+        *
+        * @param $request WebRequest
         */
        protected function showContentForm() {
                $this->showTextbox1();
@@ -1600,9 +1621,9 @@ INPUTS
         * Method to output wpTextbox1
         * The $textoverride method can be used by subclasses overriding showContentForm
         * to pass back to this method.
-        * 
-        * @param array $customAttribs An array of html attributes to use in the textarea
-        * @param string $textoverride Optional text to override $this->textarea1 with
+        *
+        * @param $customAttribs An array of html attributes to use in the textarea
+        * @param $textoverride String: optional text to override $this->textarea1 with
         */
        protected function showTextbox1($customAttribs = null, $textoverride = null) {
                $classes = array(); // Textarea CSS
@@ -1626,7 +1647,7 @@ INPUTS
                                $classes[] = $attribs['class'];
                        $attribs['class'] = implode( ' ', $classes );
                }
-               
+
                $this->showTextbox( isset($textoverride) ? $textoverride : $this->textbox1, 'wpTextbox1', $attribs );
        }
 
@@ -1649,14 +1670,11 @@ INPUTS
                $attribs = $customAttribs + array(
                        'accesskey' => ',',
                        'id'   => $name,
-                       'cols' => $wgUser->getIntOption( 'cols' ), 
+                       'cols' => $wgUser->getIntOption( 'cols' ),
                        'rows' => $wgUser->getIntOption( 'rows' ),
-                       'style' => '' // avoid php notices when appending for editwidth preference (appending allows customAttribs['style'] to still work
+                       'style' => '' // avoid php notices when appending preferences (appending allows customAttribs['style'] to still work
                );
 
-               if ( $wgUser->getOption( 'editwidth' ) )
-                       $attribs['style'] .= 'width: 100%';
-
                $wgOut->addHTML( Html::textarea( $name, $wikitext, $attribs ) );
        }
 
@@ -1688,7 +1706,7 @@ INPUTS
         * Append preview output to $wgOut.
         * Includes category rendering if this is a category page.
         *
-        * @param string $text The HTML to be output for the preview.
+        * @param $text String: the HTML to be output for the preview.
         */
        protected function showPreview( $text ) {
                global $wgOut;
@@ -1704,14 +1722,16 @@ INPUTS
                }
        }
 
+       /**
+        * Give a chance for site and per-namespace customizations of
+        * terms of service summary link that might exist separately
+        * from the copyright notice.
+        *
+        * This will display between the save button and the edit tools,
+        * so should remain short!
+        */
        protected function showTosSummary() {
                $msg = 'editpage-tos-summary';
-               // Give a chance for site and per-namespace customizations of
-               // terms of service summary link that might exist separately
-               // from the copyright notice.
-               //
-               // This will display between the save button and the edit tools,
-               // so should remain short!
                wfRunHooks( 'EditPageTosSummary', array( $this->mTitle, &$msg ) );
                $text = wfMsg( $msg );
                if( !wfEmptyMsg( $msg, $text ) && $text !== '-' ) {
@@ -1728,7 +1748,7 @@ INPUTS
                $wgOut->addWikiMsgArray( 'edittools', array(), array( 'content' ) );
                $wgOut->addHTML( '</div>' );
        }
-       
+
        protected function getCopywarn() {
                global $wgRightsText;
                if ( $wgRightsText ) {
@@ -1741,10 +1761,10 @@ INPUTS
                }
                // Allow for site and per-namespace customization of contribution/copyright notice.
                wfRunHooks( 'EditPageCopyrightWarning', array( $this->mTitle, &$copywarnMsg ) );
-               
+
                return "<div id=\"editpage-copywarn\">\n" . call_user_func_array("wfMsgNoTrans", $copywarnMsg) . "\n</div>";
        }
-       
+
        protected function showStandardInputs( &$tabindex = 2 ) {
                global $wgOut, $wgUser;
                $wgOut->addHTML( "<div class='editOptions'>\n" );
@@ -1769,7 +1789,11 @@ INPUTS
                $wgOut->addHTML( "      <span class='editHelp'>{$cancel}{$separator}{$edithelp}</span>\n" );
                $wgOut->addHTML( "</div><!-- editButtons -->\n</div><!-- editOptions -->\n" );
        }
-       
+
+       /*
+        * Show an edit conflict. textbox1 is already shown in showEditForm().
+        * If you want to use another entry point to this function, be careful.
+        */
        protected function showConflict() {
                global $wgOut;
                $this->textbox2 = $this->textbox1;
@@ -1823,7 +1847,7 @@ INPUTS
         * @return string
         */
        function getPreviewText() {
-               global $wgOut, $wgUser, $wgTitle, $wgParser, $wgLang, $wgContLang, $wgMessageCache;
+               global $wgOut, $wgUser, $wgParser, $wgMessageCache;
 
                wfProfileIn( __METHOD__ );
 
@@ -1855,9 +1879,9 @@ INPUTS
 
                if ( $this->isCssJsSubpage ) {
                        if (preg_match( "/\\.css$/", $this->mTitle->getText() ) ) {
-                               $previewtext = wfMsg( 'usercsspreview' );
+                               $previewtext = "<div id='mw-usercsspreview'>\n" . wfMsg( 'usercsspreview' ) . "\n</div>";
                        } else if (preg_match( "/\\.js$/", $this->mTitle->getText() ) ) {
-                               $previewtext = wfMsg( 'userjspreview' );
+                               $previewtext = "<div id='mw-userjspreview'>\n" . wfMsg( 'userjspreview' ) . "\n</div>";
                        }
                        $parserOptions->setTidy( true );
                        $parserOutput = $wgParser->parse( $previewtext, $this->mTitle, $parserOptions );
@@ -1997,7 +2021,7 @@ INPUTS
         *
         * @param $match Text which triggered one or more filters
         */
-       function spamPage( $match = false ) {
+       static function spamPage( $match = false ) {
                global $wgOut, $wgTitle;
 
                $wgOut->setPageTitle( wfMsg( 'spamprotectiontitle' ) );
@@ -2006,8 +2030,9 @@ INPUTS
 
                $wgOut->addHTML( '<div id="spamprotected">' );
                $wgOut->addWikiMsg( 'spamprotectiontext' );
-               if ( $match )
+               if ( $match ) {
                        $wgOut->addWikiMsg( 'spamprotectionmatch', wfEscapeWikiText( $match ) );
+               }
                $wgOut->addHTML( '</div>' );
 
                $wgOut->returnToMain( false, $wgTitle );
@@ -2081,8 +2106,8 @@ INPUTS
 
        /**
         * Format an anchor fragment as it would appear for a given section name
-        * @param string $text
-        * @return string
+        * @param $text String
+        * @return String
         * @private
         */
        function sectionAnchor( $text ) {
@@ -2269,7 +2294,7 @@ INPUTS
                        );
                        $checkboxes['minor'] =
                                Xml::check( 'wpMinoredit', $checked['minor'], $attribs ) .
-                               "&nbsp;<label for='wpMinoredit'" . $skin->tooltip( 'minoredit', 'withaccess' ) . ">{$minorLabel}</label>";
+                               "&#160;<label for='wpMinoredit'" . $skin->tooltip( 'minoredit', 'withaccess' ) . ">{$minorLabel}</label>";
                }
 
                $watchLabel = wfMsgExt( 'watchthis', array( 'parseinline' ) );
@@ -2282,7 +2307,7 @@ INPUTS
                        );
                        $checkboxes['watch'] =
                                Xml::check( 'wpWatchthis', $checked['watch'], $attribs ) .
-                               "&nbsp;<label for='wpWatchthis'" . $skin->tooltip( 'watch', 'withaccess' ) . ">{$watchLabel}</label>";
+                               "&#160;<label for='wpWatchthis'" . $skin->tooltip( 'watch', 'withaccess' ) . ">{$watchLabel}</label>";
                }
                wfRunHooks( 'EditPageBeforeEditChecks', array( &$this, &$checkboxes, &$tabindex ) );
                return $checkboxes;
@@ -2420,9 +2445,9 @@ INPUTS
         * Filter an input field through a Unicode de-armoring process if it
         * came from an old browser with known broken Unicode editing issues.
         *
-        * @param WebRequest $request
-        * @param string $field
-        * @return string
+        * @param $request WebRequest
+        * @param $field String
+        * @return String
         * @private
         */
        function safeUnicodeInput( $request, $field ) {
@@ -2443,8 +2468,8 @@ INPUTS
         * Filter an output field through a Unicode armoring process if it is
         * going to an old browser with known broken Unicode editing issues.
         *
-        * @param string $text
-        * @return string
+        * @param $text String
+        * @return String
         * @private
         */
        function safeUnicodeOutput( $text ) {
@@ -2464,8 +2489,8 @@ INPUTS
         * Preexisting such character references will have a 0 added to them
         * to ensure that round-trips do not alter the original data.
         *
-        * @param string $invalue
-        * @return string
+        * @param $invalue String
+        * @return String
         * @private
         */
        function makesafe( $invalue ) {
@@ -2506,8 +2531,8 @@ INPUTS
         * back to UTF-8. Used to protect data from corruption by broken web browsers
         * as listed in $wgBrowserBlackList.
         *
-        * @param string $invalue
-        * @return string
+        * @param $invalue String
+        * @return String
         * @private
         */
        function unmakesafe( $invalue ) {
@@ -2578,7 +2603,7 @@ INPUTS
                                return false;
 
                        case self::AS_SPAM_ERROR:
-                               $this->spamPage( $resultDetails['spam'] );
+                               self::spamPage( $resultDetails['spam'] );
                                return false;
 
                        case self::AS_BLOCKED_PAGE_FOR_USER:
@@ -2617,7 +2642,7 @@ INPUTS
        }
 
        function getBaseRevision() {
-               if ( $this->mBaseRevision == false ) {
+               if ( !$this->mBaseRevision ) {
                        $db = wfGetDB( DB_MASTER );
                        $baseRevision = Revision::loadFromTimestamp(
                                $db, $this->mTitle, $this->edittime );
@@ -2625,5 +2650,5 @@ INPUTS
                } else {
                        return $this->mBaseRevision;
                }
-       }       
+       }
 }