(bug 8556) When using $wgRawHtml, don't show scary session_failure/possible attack
[lhc/web/wiklou.git] / includes / EditPage.php
index cb4f761..44cba7f 100644 (file)
@@ -11,7 +11,7 @@
  * interfaces.
  *
  * EditPage cares about two distinct titles:
- * $wgTitle is the page that forms submit to, links point to,
+ * $this->mContextTitle is the page that forms submit to, links point to,
  * redirects go to, etc. $this->mTitle (as well as $mArticle) is the
  * page in the database that is actually being edited. These are
  * usually the same, but they are now allowed to be different.
@@ -42,20 +42,31 @@ class EditPage {
        const AS_IMAGE_REDIRECT_ANON       = 233;
        const AS_IMAGE_REDIRECT_LOGGED     = 234;
 
+       /**
+        * @var Article
+        */
        var $mArticle;
+
+       /**
+        * @var Title
+        */
        var $mTitle;
+       private $mContextTitle = null;
        var $action;
        var $isConflict = false;
        var $isCssJsSubpage = false;
        var $isCssSubpage = false;
        var $isJsSubpage = false;
-       var $deletedSinceEdit = false;
+       var $isWrongCaseCssJsPage = false;
+       var $isNew = false; // new page or new section
+       var $deletedSinceEdit;
        var $formtype;
        var $firsttime;
        var $lastDelete;
        var $mTokenOk = false;
        var $mTokenOkExceptSuffix = false;
        var $mTriedSave = false;
+       var $incompleteForm = false;
        var $tooBig = false;
        var $kblength = false;
        var $missingComment = false;
@@ -64,7 +75,12 @@ class EditPage {
        var $autoSumm = '';
        var $hookError = '';
        #var $mPreviewTemplates;
+
+       /**
+        * @var ParserOutput
+        */
        var $mParserOutput;
+
        var $mBaseRevision = false;
        var $mShowSummaryField = true;
 
@@ -85,6 +101,7 @@ class EditPage {
        public $editFormTextBottom;
        public $editFormTextAfterContent;
        public $previewTextAfterContent;
+       public $mPreloadText;
 
        /* $didSave should be set to true whenever an article was succesfully altered. */
        public $didSave = false;
@@ -94,7 +111,7 @@ class EditPage {
 
        /**
         * @todo document
-        * @param $article
+        * @param $article Article
         */
        function __construct( $article ) {
                $this->mArticle =& $article;
@@ -113,18 +130,47 @@ class EditPage {
                $this->mPreloadText = "";
        }
 
+       /**
+        * @return Article
+        */
        function getArticle() {
                return $this->mArticle;
        }
 
+       /**
+        * Set the context Title object
+        *
+        * @param $title Title object or null
+        */
+       public function setContextTitle( $title ) {
+               $this->mContextTitle = $title;
+       }
+
+       /**
+        * Get the context title object.
+        * If not set, $wgTitle will be returned. This behavior might changed in
+        * the future to return $this->mTitle instead.
+        *
+        * @return Title object
+        */
+       public function getContextTitle() {
+               if ( is_null( $this->mContextTitle ) ) {
+                       global $wgTitle;
+                       return $wgTitle;
+               } else {
+                       return $this->mContextTitle;
+               }
+       }
 
        /**
         * Fetch initial editing page content.
+        *
+        * @param $def_text string
         * @returns mixed string on success, $def_text for invalid sections
         * @private
         */
        function getContent( $def_text = '' ) {
-               global $wgOut, $wgRequest, $wgParser, $wgContLang, $wgMessageCache;
+               global $wgOut, $wgRequest, $wgParser;
 
                wfProfileIn( __METHOD__ );
                # Get variables from query string :P
@@ -141,10 +187,10 @@ class EditPage {
                if ( !$this->mTitle->exists() ) {
                        if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
                                # If this is a system message, get the default text.
-                               list( $message, $lang ) = $wgMessageCache->figureMessage( $wgContLang->lcfirst( $this->mTitle->getText() ) );
-                               $text = wfMsgGetKey( $message, false, $lang, false );
-                               if( wfEmptyMsg( $message, $text ) )
+                               $text = $this->mTitle->getDefaultMessageText();
+                               if( $text === false ) {
                                        $text = $this->getPreloadedText( $preload );
+                               }
                        } else {
                                # If requested, preload some text.
                                $text = $this->getPreloadedText( $preload );
@@ -198,7 +244,7 @@ class EditPage {
                                        // was created, or we may simply have got bogus input.
                                        $this->editFormPageTop .= $wgOut->parse( '<div class="error mw-undo-norev">' . wfMsgNoTrans( 'undo-norev' ) . '</div>' );
                                }
-                       } else if ( $section != '' ) {
+                       } elseif ( $section != '' ) {
                                if ( $section == 'new' ) {
                                        $text = $this->getPreloadedText( $preload );
                                } else {
@@ -212,7 +258,11 @@ class EditPage {
                return $text;
        }
 
-       /** Use this method before edit() to preload some text into the edit box */
+       /**
+        * Use this method before edit() to preload some text into the edit box
+        *
+        * @param $text string
+        */
        public function setPreloadedText( $text ) {
                $this->mPreloadText = $text;
        }
@@ -253,15 +303,19 @@ class EditPage {
                return '';
        }
 
-       /*
+       /**
         * Check if a page was deleted while the user was editing it, before submit.
         * Note that we rely on the logging table, which hasn't been always there,
         * but that doesn't matter, because this only applies to brand new
         * deletes.
         */
        protected function wasDeletedSinceLastEdit() {
-               if ( $this->deletedSinceEdit )
-                       return true;
+               if ( $this->deletedSinceEdit !== null ) {
+                       return $this->deletedSinceEdit;
+               }
+
+               $this->deletedSinceEdit = false;
+
                if ( $this->mTitle->isDeletedQuick() ) {
                        $this->lastDelete = $this->getLastDelete();
                        if ( $this->lastDelete ) {
@@ -271,12 +325,15 @@ class EditPage {
                                }
                        }
                }
+
                return $this->deletedSinceEdit;
        }
 
        /**
         * Checks whether the user entered a skin name in uppercase,
         * e.g. "User:Example/Monobook.css" instead of "monobook.css"
+        *
+        * @return bool
         */
        protected function isWrongCaseCssJsPage() {
                if( $this->mTitle->isCssJsSubpage() ) {
@@ -335,11 +392,13 @@ class EditPage {
                        $this->preview = true;
                }
 
-               $wgOut->addModules( 'mediawiki.legacy.edit' );
+               $wgOut->addModules( array( 'mediawiki.action.edit' ) );
 
                if ( $wgUser->getOption( 'uselivepreview', false ) ) {
                        $wgOut->addModules( 'mediawiki.legacy.preview' );
                }
+               // Bug #19334: textarea jumps when editing articles in IE8
+               $wgOut->addStyle( 'common/IE80Fixes.css', 'screen', 'IE 8' );
 
                $permErrors = $this->getEditPermissionErrors();
                if ( $permErrors ) {
@@ -352,9 +411,9 @@ class EditPage {
                } else {
                        if ( $this->save ) {
                                $this->formtype = 'save';
-                       } else if ( $this->preview ) {
+                       } elseif ( $this->preview ) {
                                $this->formtype = 'preview';
-                       } else if ( $this->diff ) {
+                       } elseif ( $this->diff ) {
                                $this->formtype = 'diff';
                        } else { # First time through
                                $this->firsttime = true;
@@ -375,10 +434,11 @@ class EditPage {
 
                $this->isConflict = false;
                // css / js subpages of user pages get a special treatment
-               $this->isCssJsSubpage      = $this->mTitle->isCssJsSubpage();
-               $this->isCssSubpage        = $this->mTitle->isCssSubpage();
-               $this->isJsSubpage         = $this->mTitle->isJsSubpage();
+               $this->isCssJsSubpage       = $this->mTitle->isCssJsSubpage();
+               $this->isCssSubpage         = $this->mTitle->isCssSubpage();
+               $this->isJsSubpage          = $this->mTitle->isJsSubpage();
                $this->isWrongCaseCssJsPage = $this->isWrongCaseCssJsPage();
+               $this->isNew                = !$this->mTitle->exists() || $this->section == 'new';
 
                # Show applicable editing introductions
                if ( $this->formtype == 'initial' || $this->firsttime )
@@ -439,6 +499,9 @@ class EditPage {
                wfProfileOut( __METHOD__ );
        }
 
+       /**
+        * @return array
+        */
        protected function getEditPermissionErrors() {
                global $wgUser;
                $permErrors = $this->mTitle->getUserPermissionsErrors( 'edit', $wgUser );
@@ -532,7 +595,7 @@ class EditPage {
 
        /**
         * @todo document
-        * @param $request
+        * @param $request WebRequest
         */
        function importFormData( &$request ) {
                global $wgLang, $wgUser;
@@ -569,7 +632,17 @@ class EditPage {
 
                        $this->scrolltop = $request->getIntOrNull( 'wpScrolltop' );
 
-                       if ( is_null( $this->edittime ) ) {
+                       if ($this->textbox1 === '' && $request->getVal( 'wpTextbox1' ) === null) {
+                               // wpTextbox1 field is missing, possibly due to being "too big"
+                               // according to some filter rules such as Suhosin's setting for
+                               // suhosin.request.max_value_length (d'oh)
+                               $this->incompleteForm = true;
+                       } else {
+                               // edittime should be one of our last fields; if it's missing,
+                               // the submission probably broke somewhere in the middle.
+                               $this->incompleteForm = is_null( $this->edittime );
+                       }
+                       if ( $this->incompleteForm ) {
                                # If the form is incomplete, force to preview.
                                wfDebug( __METHOD__ . ": Form data appears to be incomplete\n" );
                                wfDebug( "POST DATA: " . var_export( $_POST, true ) . "\n" );
@@ -589,7 +662,7 @@ class EditPage {
                                        # The unmarked state will be assumed to be a save,
                                        # if the form seems otherwise complete.
                                        wfDebug( __METHOD__ . ": Passed token check.\n" );
-                               } else if ( $this->diff ) {
+                               } elseif ( $this->diff ) {
                                        # Failed token check, but only requested "Show Changes".
                                        wfDebug( __METHOD__ . ": Failed token check; Show Changes requested.\n" );
                                } else {
@@ -653,7 +726,7 @@ class EditPage {
                $this->bot = $request->getBool( 'bot', true );
                $this->nosummary = $request->getBool( 'nosummary' );
 
-               // FIXME: unused variable?
+               // @todo FIXME: Unused variable?
                $this->oldid = $request->getInt( 'oldid' );
 
                $this->live = $request->getCheck( 'live' );
@@ -661,10 +734,10 @@ class EditPage {
                        // Custom edit intro for new sections
                        $this->section === 'new' ? 'MediaWiki:addsection-editintro' : '' );
 
-               wfProfileOut( __METHOD__ );
-
                // Allow extensions to modify form data
                wfRunHooks( 'EditPage::importFormData', array( $this, $request ) );
+
+               wfProfileOut( __METHOD__ );
        }
 
        /**
@@ -719,8 +792,8 @@ class EditPage {
                        $ip = User::isIP( $username );
                        if ( !$user->isLoggedIn() && !$ip ) { # User does not exist
                                $wgOut->wrapWikiMsg( "<div class=\"mw-userpage-userdoesnotexist error\">\n$1\n</div>",
-                                       array( 'userpage-userdoesnotexist', $username ) );
-                       } else if ( $user->isBlocked() ) { # Show log extract if the user is currently blocked
+                                       array( 'userpage-userdoesnotexist', wfEscapeWikiText( $username ) ) );
+                       } elseif ( $user->isBlocked() ) { # Show log extract if the user is currently blocked
                                LogEventsList::showLogExtract(
                                        $wgOut,
                                        'block',
@@ -766,8 +839,8 @@ class EditPage {
                        $title = Title::newFromText( $this->editintro );
                        if ( $title instanceof Title && $title->exists() && $title->userCanRead() ) {
                                global $wgOut;
-                               $revision = Revision::newFromTitle( $title );
-                               $wgOut->addWikiTextTitleTidy( $revision->getText(), $this->mTitle );
+                               // Added using template syntax, to take <noinclude>'s into account.
+                               $wgOut->addWikiTextTitleTidy( '{{:' . $title->getFullText() . '}}', $this->mTitle );
                                return true;
                        } else {
                                return false;
@@ -779,7 +852,11 @@ class EditPage {
 
        /**
         * Attempt submission (no UI)
-        * @return one of the constants describing the result
+        *
+        * @param $result
+        * @param $bot bool
+        *
+        * @return int one of the constants describing the result
         */
        function internalAttemptSave( &$result, $bot = false ) {
                global $wgFilterCallback, $wgUser, $wgParser;
@@ -790,6 +867,8 @@ class EditPage {
 
                if ( !wfRunHooks( 'EditPage::attemptSave', array( $this ) ) ) {
                        wfDebug( "Hook 'EditPage::attemptSave' aborted article saving\n" );
+                       wfProfileOut( __METHOD__ . '-checks' );
+                       wfProfileOut( __METHOD__  );
                        return self::AS_HOOK_ERROR;
                }
 
@@ -797,11 +876,12 @@ class EditPage {
                if ( $this->mTitle->getNamespace() == NS_FILE &&
                        Title::newFromRedirect( $this->textbox1 ) instanceof Title &&
                        !$wgUser->isAllowed( 'upload' ) ) {
-                               if ( $wgUser->isAnon() ) {
-                                       return self::AS_IMAGE_REDIRECT_ANON;
-                               } else {
-                                       return self::AS_IMAGE_REDIRECT_LOGGED;
-                               }
+                               $isAnon = $wgUser->isAnon();
+
+                               wfProfileOut( __METHOD__ . '-checks' );
+                               wfProfileOut( __METHOD__  );
+
+                               return $isAnon ? self::AS_IMAGE_REDIRECT_ANON : self::AS_IMAGE_REDIRECT_LOGGED;
                }
 
                # Check for spam
@@ -934,7 +1014,6 @@ class EditPage {
                        # Article exists. Check for edit conflict.
 
                        $this->mArticle->clear(); # Force reload of dates, etc.
-                       $this->mArticle->forUpdate( true ); # Lock the article
 
                        wfDebug( "timestamp: {$this->mArticle->getTimestamp()}, edittime: {$this->edittime}\n" );
 
@@ -974,7 +1053,7 @@ class EditPage {
                                wfDebug( __METHOD__ . ": activating conflict; section replace failed.\n" );
                                $this->isConflict = true;
                                $text = $this->textbox1; // do not try to merge here!
-                       } else if ( $this->isConflict ) {
+                       } elseif ( $this->isConflict ) {
                                # Attempt merge
                                if ( $this->mergeChangesInto( $text ) ) {
                                        // Successful merge! Maybe we should tell the user the good news?
@@ -1049,7 +1128,7 @@ class EditPage {
                                $hasmatch = preg_match( "/^ *([=]{1,6})(.*?)(\\1) *\\n/i", $this->textbox1, $matches );
                                # we can't deal with anchors, includes, html etc in the header for now,
                                # headline would need to be parsed to improve this
-                               if ( $hasmatch and strlen( $matches[2] ) > 0 ) {
+                               if ( $hasmatch && strlen( $matches[2] ) > 0 ) {
                                        $sectionanchor = $wgParser->guessLegacySectionNameFromWikiText( $matches[2] );
                                }
                        }
@@ -1076,7 +1155,7 @@ class EditPage {
 
                $flags = EDIT_DEFER_UPDATES | EDIT_AUTOSUMMARY |
                        ( $new ? EDIT_NEW : EDIT_UPDATE ) |
-                       ( $this->minoredit ? EDIT_MINOR : 0 ) |
+                       ( ( $this->minoredit && !$this->isNew ) ? EDIT_MINOR : 0 ) |
                        ( $bot ? EDIT_FORCE_BOT : 0 );
 
                $status = $this->mArticle->doEdit( $text, $this->summary, $flags );
@@ -1097,13 +1176,14 @@ class EditPage {
         * Commit the change of watch status
         */
        protected function commitWatch() {
+               global $wgUser;
                if ( $this->watchthis xor $this->mTitle->userIsWatching() ) {
                        $dbw = wfGetDB( DB_MASTER );
                        $dbw->begin();
                        if ( $this->watchthis ) {
-                               $this->mArticle->doWatch();
+                               WatchAction::doWatch( $this->mTitle, $wgUser );
                        } else {
-                               $this->mArticle->doUnwatch();
+                               WatchAction::doUnwatch( $this->mTitle, $wgUser );
                        }
                        $dbw->commit();
                }
@@ -1113,6 +1193,11 @@ class EditPage {
         * Check if no edits were made by other users since
         * the time a user started editing the page. Limit to
         * 50 revisions for the sake of performance.
+        *
+        * @param $id int
+        * @param $edittime string
+        *
+        * @return bool
         */
        protected function userWasLastToEdit( $id, $edittime ) {
                if( !$id ) return false;
@@ -1135,7 +1220,10 @@ class EditPage {
 
        /**
         * Check given input text against $wgSpamRegex, and return the text of the first match.
-        * @return mixed -- matching string or false
+        *
+        * @param $text string
+        *
+        * @return string|false matching string or false
         */
        public static function matchSpamRegex( $text ) {
                global $wgSpamRegex;
@@ -1146,7 +1234,10 @@ class EditPage {
 
        /**
         * Check given input text against $wgSpamRegex, and return the text of the first match.
-        * @return mixed -- matching string or false
+        *
+        * @parma $text string
+        *
+        * @return string|false  matching string or false
         */
        public static function matchSummarySpamRegex( $text ) {
                global $wgSummarySpamRegex;
@@ -1154,6 +1245,11 @@ class EditPage {
                return self::matchSpamRegexInternal( $text, $regexes );
        }
 
+       /**
+        * @param $text string
+        * @param $regexes array
+        * @return bool|string
+        */
        protected static function matchSpamRegexInternal( $text, $regexes ) {
                foreach( $regexes as $regex ) {
                        $matches = array();
@@ -1167,7 +1263,7 @@ class EditPage {
        /**
         * Initialise form fields in the object
         * Called on the first invocation, e.g. when a user clicks an edit link
-        * @returns bool -- if the requested section is valid
+        * @return bool -- if the requested section is valid
         */
        function initialiseForm() {
                global $wgUser;
@@ -1185,30 +1281,34 @@ class EditPage {
                        # Already watched
                        $this->watchthis = true;
                }
-               if ( $wgUser->getOption( 'minordefault' ) ) $this->minoredit = true;
-               if ( $this->textbox1 === false ) return false;
+               if ( $wgUser->getOption( 'minordefault' ) && !$this->isNew ) {
+                       $this->minoredit = true;
+               }
+               if ( $this->textbox1 === false ) {
+                       return false;
+               }
                wfProxyCheck();
                return true;
        }
 
        function setHeaders() {
-               global $wgOut, $wgTitle;
+               global $wgOut;
                $wgOut->setRobotPolicy( 'noindex,nofollow' );
                if ( $this->formtype == 'preview' ) {
                        $wgOut->setPageTitleActionText( wfMsg( 'preview' ) );
                }
                if ( $this->isConflict ) {
-                       $wgOut->setPageTitle( wfMsg( 'editconflict', $wgTitle->getPrefixedText() ) );
+                       $wgOut->setPageTitle( wfMsg( 'editconflict', $this->getContextTitle()->getPrefixedText() ) );
                } elseif ( $this->section != '' ) {
                        $msg = $this->section == 'new' ? 'editingcomment' : 'editingsection';
-                       $wgOut->setPageTitle( wfMsg( $msg, $wgTitle->getPrefixedText() ) );
+                       $wgOut->setPageTitle( wfMsg( $msg, $this->getContextTitle()->getPrefixedText() ) );
                } else {
                        # Use the title defined by DISPLAYTITLE magic word when present
                        if ( isset( $this->mParserOutput )
                         && ( $dt = $this->mParserOutput->getDisplayTitle() ) !== false ) {
                                $title = $dt;
                        } else {
-                               $title = $wgTitle->getPrefixedText();
+                               $title = $this->getContextTitle()->getPrefixedText();
                        }
                        $wgOut->setPageTitle( wfMsg( 'editing', $title ) );
                }
@@ -1216,19 +1316,11 @@ class EditPage {
 
        /**
         * Send the edit form and related headers to $wgOut
-        * @param $formCallback Optional callable that takes an OutputPage
-        *                      parameter; will be called during form output
-        *                      near the top, for captchas and the like.
+        * @param $formCallback Callback that takes an OutputPage parameter; will be called
+        *     during form output near the top, for captchas and the like.
         */
        function showEditForm( $formCallback = null ) {
-               global $wgOut, $wgUser, $wgTitle;
-
-               # If $wgTitle is null, that means we're in API mode.
-               # Some hook probably called this function  without checking
-               # for is_null($wgTitle) first. Bail out right here so we don't
-               # do lots of work just to discard it right after.
-               if ( is_null( $wgTitle ) )
-                       return;
+               global $wgOut, $wgUser;
 
                wfProfileIn( __METHOD__ );
 
@@ -1250,10 +1342,12 @@ class EditPage {
                # Enabled article-related sidebar, toplinks, etc.
                $wgOut->setArticleRelated( true );
 
-               if ( $this->showHeader() === false )
+               if ( $this->showHeader() === false ) {
+                       wfProfileOut( __METHOD__ );
                        return;
+               }
 
-               $action = htmlspecialchars( $this->getActionURL( $wgTitle ) );
+               $action = htmlspecialchars( $this->getActionURL( $this->getContextTitle() ) );
 
                if ( $wgUser->getOption( 'showtoolbar' ) and !$this->isCssJsSubpage ) {
                        # prepare toolbar for edit buttons
@@ -1288,7 +1382,6 @@ class EditPage {
                        // @todo move this to a cleaner conditional instead of blanking a variable
                }
                $wgOut->addHTML( <<<HTML
-{$toolbar}
 <form id="editform" name="editform" method="post" action="$action" enctype="multipart/form-data">
 HTML
 );
@@ -1305,12 +1398,15 @@ HTML
                if ( $this->wasDeletedSinceLastEdit() && 'save' == $this->formtype ) {
                        $username = $this->lastDelete->user_name;
                        $comment = $this->lastDelete->log_comment;
-       
+
                        // It is better to not parse the comment at all than to have templates expanded in the middle
                        // TODO: can the checkLabel be moved outside of the div so that wrapWikiMsg could be used?
+                       $key = $comment === ''
+                               ? 'confirmrecreate-noreason'
+                               : 'confirmrecreate';
                        $wgOut->addHTML(
                                '<div class="mw-confirm-recreate">' .
-                               wfMsgExt( 'confirmrecreate', 'parseinline', $username, "<nowiki>$comment</nowiki>" ) .
+                               wfMsgExt( $key, 'parseinline', $username, "<nowiki>$comment</nowiki>" ) .
                                Xml::checkLabel( wfMsg( 'recreate' ), 'wpRecreate', 'wpRecreate', false,
                                        array( 'title' => $sk->titleAttrib( 'recreate' ), 'tabindex' => 1, 'id' => 'wpRecreate' )
                                ) .
@@ -1340,6 +1436,8 @@ HTML
 
                $wgOut->addHTML( $this->editFormTextBeforeContent );
 
+               $wgOut->addHTML( $toolbar );
+
                if ( $this->isConflict ) {
                        // In an edit conflict bypass the overrideable content form method
                        // and fallback to the raw wpTextbox1 since editconflicts can't be
@@ -1387,7 +1485,7 @@ HTML
        }
 
        protected function showHeader() {
-               global $wgOut, $wgUser, $wgTitle, $wgMaxArticleSize, $wgLang;
+               global $wgOut, $wgUser, $wgMaxArticleSize, $wgLang;
                if ( $this->isConflict ) {
                        $wgOut->wrapWikiMsg( "<div class='mw-explainconflict'>\n$1\n</div>", 'explainconflict' );
                        $this->edittime = $this->mArticle->getTimestamp();
@@ -1438,7 +1536,7 @@ HTML
 
                                if ( !$this->mArticle->mRevision->userCan( Revision::DELETED_TEXT ) ) {
                                        $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1\n</div>\n", 'rev-deleted-text-permission' );
-                               } else if ( $this->mArticle->mRevision->isDeleted( Revision::DELETED_TEXT ) ) {
+                               } elseif ( $this->mArticle->mRevision->isDeleted( Revision::DELETED_TEXT ) ) {
                                        $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1\n</div>\n", 'rev-deleted-text-view' );
                                }
 
@@ -1461,7 +1559,7 @@ HTML
                        if ( $this->isCssJsSubpage ) {
                                # Check the skin exists
                                if ( $this->isWrongCaseCssJsPage ) {
-                                       $wgOut->wrapWikiMsg( "<div class='error' id='mw-userinvalidcssjstitle'>\n$1\n</div>", array( 'userinvalidcssjstitle', $wgTitle->getSkinFromCssJsSubpage() ) );
+                                       $wgOut->wrapWikiMsg( "<div class='error' id='mw-userinvalidcssjstitle'>\n$1\n</div>", array( 'userinvalidcssjstitle', $this->getContextTitle()->getSkinFromCssJsSubpage() ) );
                                }
                                if ( $this->formtype !== 'preview' ) {
                                        if ( $this->isCssSubpage )
@@ -1528,10 +1626,10 @@ HTML
         * inferred by the id given to the input. You can remove them both by
         * passing array( 'id' => false ) to $userInputAttrs.
         *
-        * @param $summary The value of the summary input
-        * @param $labelText The html to place inside the label
-        * @param $inputAttrs An array of attrs to use on the input
-        * @param $spanLabelAttrs An array of attrs to use on the span inside the label
+        * @param $summary string The value of the summary input
+        * @param $labelText string The html to place inside the label
+        * @param $inputAttrs array of attrs to use on the input
+        * @param $spanLabelAttrs array of attrs to use on the span inside the label
         *
         * @return array An array in the format array( $label, $input )
         */
@@ -1574,11 +1672,13 @@ HTML
                # Add a class if 'missingsummary' is triggered to allow styling of the summary line
                $summaryClass = $this->missingSummary ? 'mw-summarymissed' : 'mw-summary';
                if ( $isSubjectPreview ) {
-                       if ( $this->nosummary )
+                       if ( $this->nosummary ) {
                                return;
+                       }
                } else {
-                       if ( !$this->mShowSummaryField )
+                       if ( !$this->mShowSummaryField ) {
                                return;
+                       }
                }
                $summary = $wgContLang->recodeForEdit( $summary );
                $labelText = wfMsgExt( $isSubjectPreview ? 'subject' : 'summary', 'parseinline' );
@@ -1671,6 +1771,10 @@ HTML
                                # Then it must be protected based on static groups (regular)
                                $classes[] = 'mw-textarea-protected';
                        }
+                       # Is the title cascade-protected?
+                       if ( $this->mTitle->isCascadeProtected() ) {
+                               $classes[] = 'mw-textarea-cprotected';
+                       }
                }
                $attribs = array( 'tabindex' => 1 );
                if ( is_array($customAttribs) )
@@ -1688,7 +1792,7 @@ HTML
        }
 
        protected function showTextbox2() {
-               $this->showTextbox( $this->textbox2, 'wpTextbox2', array( 'tabindex' => 6 ) );
+               $this->showTextbox( $this->textbox2, 'wpTextbox2', array( 'tabindex' => 6, 'readonly' ) );
        }
 
        protected function showTextbox( $content, $name, $customAttribs = array() ) {
@@ -1711,6 +1815,13 @@ HTML
                        'style' => '' // avoid php notices when appending preferences (appending allows customAttribs['style'] to still work
                );
 
+               global $wgBetterDirectionality;
+               if( $wgBetterDirectionality ) {
+                       $pageLang = $this->mTitle->getPageLanguage();
+                       $attribs['lang'] = $pageLang->getCode();
+                       $attribs['dir'] = $pageLang->getDir();
+               }
+
                $wgOut->addHTML( Html::textarea( $name, $wikitext, $attribs ) );
        }
 
@@ -1797,7 +1908,8 @@ HTML
                // Allow for site and per-namespace customization of contribution/copyright notice.
                wfRunHooks( 'EditPageCopyrightWarning', array( $this->mTitle, &$copywarnMsg ) );
 
-               return "<div id=\"editpage-copywarn\">\n" . call_user_func_array("wfMsgNoTrans", $copywarnMsg) . "\n</div>";
+               return "<div id=\"editpage-copywarn\">\n" .
+                       call_user_func_array("wfMsgNoTrans", $copywarnMsg) . "\n</div>";
        }
 
        protected function showStandardInputs( &$tabindex = 2 ) {
@@ -1825,7 +1937,7 @@ HTML
                $wgOut->addHTML( "</div><!-- editButtons -->\n</div><!-- editOptions -->\n" );
        }
 
-       /*
+       /**
         * Show an edit conflict. textbox1 is already shown in showEditForm().
         * If you want to use another entry point to this function, be careful.
         */
@@ -1850,20 +1962,20 @@ HTML
                $data = $dbr->selectRow(
                        array( 'logging', 'user' ),
                        array( 'log_type',
-                              'log_action',
-                              'log_timestamp',
-                              'log_user',
-                              'log_namespace',
-                              'log_title',
-                              'log_comment',
-                              'log_params',
-                              'log_deleted',
-                              'user_name' ),
+                                  'log_action',
+                                  'log_timestamp',
+                                  'log_user',
+                                  'log_namespace',
+                                  'log_title',
+                                  'log_comment',
+                                  'log_params',
+                                  'log_deleted',
+                                  'user_name' ),
                        array( 'log_namespace' => $this->mTitle->getNamespace(),
-                              'log_title' => $this->mTitle->getDBkey(),
-                              'log_type' => 'delete',
-                              'log_action' => 'delete',
-                              'user_id=log_user' ),
+                                  'log_title' => $this->mTitle->getDBkey(),
+                                  'log_type' => 'delete',
+                                  'log_action' => 'delete',
+                                  'user_id=log_user' ),
                        __METHOD__,
                        array( 'LIMIT' => 1, 'ORDER BY' => 'log_timestamp DESC' )
                );
@@ -1882,7 +1994,7 @@ HTML
         * @return string
         */
        function getPreviewText() {
-               global $wgOut, $wgUser, $wgParser, $wgMessageCache;
+               global $wgOut, $wgUser, $wgParser;
 
                wfProfileIn( __METHOD__ );
 
@@ -1892,6 +2004,8 @@ HTML
                        } else {
                                $note = wfMsg( 'session_fail_preview' );
                        }
+               } elseif ( $this->incompleteForm ) {
+                       $note = wfMsg( 'edit_form_incomplete' );
                } else {
                        $note = wfMsg( 'previewnote' );
                }
@@ -1905,12 +2019,20 @@ HTML
                if ( $wgRawHtml && !$this->mTokenOk ) {
                        // Could be an offsite preview attempt. This is very unsafe if
                        // HTML is enabled, as it could be an attack.
-                       return $wgOut->parse( "<div class='previewnote'>" .
-                               wfMsg( 'session_fail_preview_html' ) . "</div>" );
+                       $parsedNote = '';
+                       if ( $this->textbox1 !== '' ) {
+                               // Do not put big scary notice, if previewing the empty
+                               // string, which happens when you initially edit
+                               // a category page, due to automatic preview-on-open.
+                               $parsedNote = $wgOut->parse( "<div class='previewnote'>" .
+                                       wfMsg( 'session_fail_preview_html' ) . "</div>" );
+                       }
+                       wfProfileOut( __METHOD__ );
+                       return $parsedNote;
                }
 
                # don't parse user css/js, show message about preview
-               # XXX: stupid php bug won't let us use $wgTitle->isCssJsSubpage() here -- This note has been there since r3530. Sure the bug was fixed time ago?
+               # XXX: stupid php bug won't let us use $this->getContextTitle()->isCssJsSubpage() here -- This note has been there since r3530. Sure the bug was fixed time ago?
 
                if ( $this->isCssJsSubpage || $this->mTitle->isCssOrJsPage() ) {
                        $level = 'user';
@@ -1949,13 +2071,11 @@ HTML
 
                                wfRunHooks( 'EditPageGetPreviewText', array( $this, &$toparse ) );
 
-                               // Parse mediawiki messages with correct target language
+                               // In which language to parse the page
+                               // (Should this still be only for MediaWiki pages, or for all pages?)
                                if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
-                                       list( /* $unused */, $lang ) = $wgMessageCache->figureMessage( $this->mTitle->getText() );
-                                       $obj = wfGetLangObj( $lang );
-                                       $parserOptions->setTargetLanguage( $obj );
+                                       $parserOptions->setTargetLanguage( $this->mTitle->getPageLanguage() );
                                }
-
                                $parserOptions->setTidy( true );
                                $parserOptions->enableLimitReport();
                                $parserOutput = $wgParser->parse( $this->mArticle->preSaveTransform( $toparse ),
@@ -1981,14 +2101,26 @@ HTML
                        '<h2 id="mw-previewheader">' . htmlspecialchars( wfMsg( 'preview' ) ) . "</h2>" .
                        $wgOut->parse( $note ) . $conflict . "</div>\n";
 
+               global $wgBetterDirectionality;
+               if( $wgBetterDirectionality ) {
+                       $pageLang = $this->mTitle->getPageLanguage();
+                       $attribs = array( 'lang' => $pageLang->getCode(), 'dir' => $pageLang->getDir(),
+                               'class' => 'mw-content-'.$pageLang->getDir() );
+                       $previewHTML = Html::rawElement( 'div', $attribs, $previewHTML );
+               }
                wfProfileOut( __METHOD__ );
                return $previewhead . $previewHTML . $this->previewTextAfterContent;
        }
 
+       /**
+        * @return Array
+        */
        function getTemplates() {
                if ( $this->preview || $this->section != '' ) {
                        $templates = array();
-                       if ( !isset( $this->mParserOutput ) ) return $templates;
+                       if ( !isset( $this->mParserOutput ) ) {
+                               return $templates;
+                       }
                        foreach( $this->mParserOutput->getTemplates() as $ns => $template) {
                                foreach( array_keys( $template ) as $dbk ) {
                                        $templates[] = Title::makeTitle($ns, $dbk);
@@ -2028,7 +2160,7 @@ HTML
         * Produce the stock "please login to edit pages" page
         */
        function userNotLoggedInPage() {
-               global $wgUser, $wgOut, $wgTitle;
+               global $wgUser, $wgOut;
                $skin = $wgUser->getSkin();
 
                $loginTitle = SpecialPage::getTitleFor( 'Userlogin' );
@@ -2036,7 +2168,7 @@ HTML
                        $loginTitle,
                        wfMsgHtml( 'loginreqlink' ),
                        array(),
-                       array( 'returnto' => $wgTitle->getPrefixedText() ),
+                       array( 'returnto' => $this->getContextTitle()->getPrefixedText() ),
                        array( 'known', 'noclasses' )
                );
 
@@ -2044,8 +2176,8 @@ HTML
                $wgOut->setRobotPolicy( 'noindex,nofollow' );
                $wgOut->setArticleRelated( false );
 
-               $wgOut->addHTML( wfMsgWikiHtml( 'whitelistedittext', $loginLink ) );
-               $wgOut->returnToMain( false, $wgTitle );
+               $wgOut->addWikiMsgArray( 'whitelistedittext', array( $loginLink ), array( 'replaceafter' ) );
+               $wgOut->returnToMain( false, $this->getContextTitle() );
        }
 
        /**
@@ -2070,7 +2202,7 @@ HTML
         * Produce the stock "your edit contains spam" page
         *
         * @param $match Text which triggered one or more filters
-        * @deprecated Use method spamPageWithContent() instead
+        * @deprecated since 1.17 Use method spamPageWithContent() instead
         */
        static function spamPage( $match = false ) {
                global $wgOut, $wgTitle;
@@ -2095,7 +2227,7 @@ HTML
         * @param $match Text which triggered one or more filters
         */
        public function spamPageWithContent( $match = false ) {
-               global $wgOut, $wgTitle;
+               global $wgOut;
                $this->textbox2 = $this->textbox1;
 
                $wgOut->setPageTitle( wfMsg( 'spamprotectiontitle' ) );
@@ -2117,13 +2249,17 @@ HTML
                $wgOut->wrapWikiMsg( '<h2>$1</h2>', "yourtext" );
                $this->showTextbox2();
 
-               $wgOut->addReturnTo( $wgTitle, array( 'action' => 'edit' ) );
+               $wgOut->addReturnTo( $this->getContextTitle(), array( 'action' => 'edit' ) );
        }
 
 
        /**
         * @private
         * @todo document
+        *
+        * @parma $editText string
+        *
+        * @return bool
         */
        function mergeChangesInto( &$editText ){
                wfProfileIn( __METHOD__ );
@@ -2179,14 +2315,6 @@ HTML
                return true;
        }
 
-       /**
-        * @deprecated use $wgParser->stripSectionName()
-        */
-       function pseudoParseSectionAnchor( $text ) {
-               global $wgParser;
-               return $wgParser->stripSectionName( $text );
-       }
-
        /**
         * Format an anchor fragment as it would appear for a given section name
         * @param $text String
@@ -2212,16 +2340,19 @@ HTML
                $imagesAvailable = $wgEnableUploads || count( $wgForeignFileRepos );
 
                /**
-
-                * toolarray an array of arrays which each include the filename of
-                * the button image (without path), the opening tag, the closing tag,
-                * and optionally a sample text that is inserted between the two when no
-                * selection is highlighted.
-                * The tip text is shown when the user moves the mouse over the button.
+                * $toolarray is an array of arrays each of which includes the
+                * filename of the button image (without path), the opening
+                * tag, the closing tag, optionally a sample text that is
+                * inserted between the two when no selection is highlighted
+                * and an option to select which switches the automatic
+                * selection of inserted text (default is true, see
+                * mw-editbutton-image).  The tip text is shown when the user
+                * moves the mouse over the button.
                 *
-                * Already here are accesskeys (key), which are not used yet until someone
-                * can figure out a way to make them work in IE. However, we should make
-                * sure these keys are not defined on the edit page.
+                * Also here: accesskeys (key), which are not used yet until
+                * someone can figure out a way to make them work in
+                * IE. However, we should make sure these keys are not defined
+                * on the edit page.
                 */
                $toolarray = array(
                        array(
@@ -2276,7 +2407,8 @@ HTML
                                'close'  => ']]',
                                'sample' => wfMsg( 'image_sample' ),
                                'tip'    => wfMsg( 'image_tip' ),
-                               'key'    => 'D'
+                               'key'    => 'D',
+                               'select' => true
                        ) : false,
                        $imagesAvailable ? array(
                                'image'  => $wgLang->getImageFile( 'button-media' ),
@@ -2332,6 +2464,10 @@ HTML
                                continue;
                        }
 
+                       if( !isset( $tool['select'] ) ) {
+                         $tool['select'] = true;
+                       }
+
                        $params = array(
                                $image = $wgStylePath . '/common/images/' . $tool['image'],
                                // Note that we use the tip both for the ALT tag and the TITLE tag of the image.
@@ -2347,13 +2483,12 @@ HTML
 
                        $paramList = implode( ',',
                                array_map( array( 'Xml', 'encodeJsVar' ), $params ) );
-                       $script .= "addButton($paramList);\n";
+                       $script .= "mw.toolbar.addButton($paramList);\n";
                }
-               
                $wgOut->addScript( Html::inlineScript(
-                       "if ( window.mediaWiki ) { $script }"
+                       "if ( window.mediaWiki ) {{$script}}"
                ) );
-               
+
                $toolbar .= "\n</div>";
 
                wfRunHooks( 'EditPageBeforeEditToolbar', array( &$toolbar ) );
@@ -2377,19 +2512,22 @@ HTML
 
                $checkboxes = array();
 
-               $checkboxes['minor'] = '';
-               $minorLabel = wfMsgExt( 'minoredit', array( 'parseinline' ) );
-               if ( $wgUser->isAllowed( 'minoredit' ) ) {
-                       $attribs = array(
-                               'tabindex'  => ++$tabindex,
-                               'accesskey' => wfMsg( 'accesskey-minoredit' ),
-                               'id'        => 'wpMinoredit',
-                       );
-                       $checkboxes['minor'] =
-                               Xml::check( 'wpMinoredit', $checked['minor'], $attribs ) .
-                               "&#160;<label for='wpMinoredit' id='mw-editpage-minoredit'" .
-                               Xml::expandAttributes( array( 'title' => $skin->titleAttrib( 'minoredit', 'withaccess' ) ) ) .
-                               ">{$minorLabel}</label>";
+               // don't show the minor edit checkbox if it's a new page or section
+               if ( !$this->isNew ) {
+                       $checkboxes['minor'] = '';
+                       $minorLabel = wfMsgExt( 'minoredit', array( 'parseinline' ) );
+                       if ( $wgUser->isAllowed( 'minoredit' ) ) {
+                               $attribs = array(
+                                       'tabindex'  => ++$tabindex,
+                                       'accesskey' => wfMsg( 'accesskey-minoredit' ),
+                                       'id'        => 'wpMinoredit',
+                               );
+                               $checkboxes['minor'] =
+                                       Xml::check( 'wpMinoredit', $checked['minor'], $attribs ) .
+                                       "&#160;<label for='wpMinoredit' id='mw-editpage-minoredit'" .
+                                       Xml::expandAttributes( array( 'title' => $skin->titleAttrib( 'minoredit', 'withaccess' ) ) ) .
+                                       ">{$minorLabel}</label>";
+                       }
                }
 
                $watchLabel = wfMsgExt( 'watchthis', array( 'parseinline' ) );
@@ -2490,9 +2628,11 @@ HTML
                echo $s;
        }
 
-
+       /**
+        * @return string
+        */
        public function getCancelLink() {
-               global $wgUser, $wgTitle;
+               global $wgUser;
 
                $cancelParams = array();
                if ( !$this->isConflict && $this->mArticle->getOldID() > 0 ) {
@@ -2500,7 +2640,7 @@ HTML
                }
 
                return $wgUser->getSkin()->link(
-                       $wgTitle,
+                       $this->getContextTitle(),
                        wfMsgExt( 'cancel', array( 'parseinline' ) ),
                        array( 'id' => 'mw-editform-cancel' ),
                        $cancelParams,
@@ -2554,6 +2694,11 @@ HTML
                        : $text;
        }
 
+       /**
+        * @param $request WebRequest
+        * @param $text string
+        * @return string
+        */
        function safeUnicodeText( $request, $text ) {
                $text = rtrim( $text );
                return $request->getBool( 'safemode' )
@@ -2598,7 +2743,7 @@ HTML
                $result = "";
                $working = 0;
                for( $i = 0; $i < strlen( $invalue ); $i++ ) {
-                       $bytevalue = ord( $invalue{$i} );
+                       $bytevalue = ord( $invalue[$i] );
                        if ( $bytevalue <= 0x7F ) { //0xxx xxxx
                                $result .= chr( $bytevalue );
                                $bytesleft = 0;
@@ -2635,13 +2780,13 @@ HTML
        function unmakesafe( $invalue ) {
                $result = "";
                for( $i = 0; $i < strlen( $invalue ); $i++ ) {
-                       if ( ( substr( $invalue, $i, 3 ) == "&#x" ) && ( $invalue{$i+3} != '0' ) ) {
+                       if ( ( substr( $invalue, $i, 3 ) == "&#x" ) && ( $invalue[$i+3] != '0' ) ) {
                                $i += 3;
                                $hexstring = "";
                                do {
-                                       $hexstring .= $invalue{$i};
+                                       $hexstring .= $invalue[$i];
                                        $i++;
-                               } while( ctype_xdigit( $invalue{$i} ) && ( $i < strlen( $invalue ) ) );
+                               } while( ctype_xdigit( $invalue[$i] ) && ( $i < strlen( $invalue ) ) );
 
                                // Do some sanity checks. These aren't needed for reversability,
                                // but should help keep the breakage down if the editor
@@ -2671,7 +2816,7 @@ HTML
         * @return bool false if output is done, true if the rest of the form should be displayed
         */
        function attemptSave() {
-               global $wgUser, $wgOut, $wgTitle;
+               global $wgUser, $wgOut;
 
                $resultDetails = false;
                # Allow bots to exempt some edits from bot flagging
@@ -2685,7 +2830,7 @@ HTML
                switch ( $value ) {
                        case self::AS_HOOK_ERROR_EXPECTED:
                        case self::AS_CONTENT_TOO_BIG:
-                       case self::AS_ARTICLE_WAS_DELETED:
+                       case self::AS_ARTICLE_WAS_DELETED:
                        case self::AS_CONFLICT_DETECTED:
                        case self::AS_SUMMARY_NEEDED:
                        case self::AS_TEXTBOX_EMPTY:
@@ -2735,22 +2880,22 @@ HTML
                                $this->userNotLoggedInPage();
                                return false;
 
-                       case self::AS_READ_ONLY_PAGE_LOGGED:
-                       case self::AS_READ_ONLY_PAGE:
-                               $wgOut->readOnlyPage();
-                               return false;
+                       case self::AS_READ_ONLY_PAGE_LOGGED:
+                       case self::AS_READ_ONLY_PAGE:
+                               $wgOut->readOnlyPage();
+                               return false;
 
-                       case self::AS_RATE_LIMITED:
-                               $wgOut->rateLimited();
-                               return false;
+                       case self::AS_RATE_LIMITED:
+                               $wgOut->rateLimited();
+                               return false;
 
-                       case self::AS_NO_CREATE_PERMISSION:
-                               $this->noCreatePermission();
-                               return;
+                       case self::AS_NO_CREATE_PERMISSION:
+                               $this->noCreatePermission();
+                               return false;
 
                        case self::AS_BLANK_ARTICLE:
-                               $wgOut->redirect( $wgTitle->getFullURL() );
-                               return false;
+                               $wgOut->redirect( $this->getContextTitle()->getFullURL() );
+                               return false;
 
                        case self::AS_IMAGE_REDIRECT_LOGGED:
                                $wgOut->permissionRequired( 'upload' );
@@ -2758,6 +2903,9 @@ HTML
                }
        }
 
+       /**
+        * @return Revision
+        */
        function getBaseRevision() {
                if ( !$this->mBaseRevision ) {
                        $db = wfGetDB( DB_MASTER );