/** @var string */
public $action = 'submit';
- /** @var bool */
+ /** @var bool Whether an edit conflict needs to be resolved. Detected based on whether
+ * $editRevId is different from the current revision. When a conflict has successfully
+ * been resolved by a 3-way-merge, this field is set to false.
+ */
public $isConflict = false;
/** @var bool New page or new section */
/** @var bool Has a summary been preset using GET parameter &summary= ? */
public $hasPresetSummary = false;
- /** @var Revision|bool|null */
+ /** @var Revision|bool|null A revision object corresponding to $this->editRevId. */
public $mBaseRevision = false;
/** @var bool */
/** @var string */
public $edittime = '';
- /** @var int */
+ /** @var int ID of the current revision at the time editing was initiated on the client.
+ * This is used to detect and resolve edit conflicts.
+ *
+ * @note 0 if the page did not exist at that time.
+ * @note When starting an edit from an old revision, this still records the current
+ * revision at the time , not the one the edit is based on.
+ *
+ * @see $oldid
+ * @see getBaseRevision()
+ */
private $editRevId = null;
/** @var string */
/** @var string */
public $starttime = '';
- /** @var int */
+ /** @var int Revision ID the edit is based on, or 0 if it's the current revision.
+ * @see $editRevId
+ */
public $oldid = 0;
- /** @var int */
+ /** @var int Revision ID the edit is based on, adjusted when an edit conflict is resolved.
+ * @see $editRevId
+ * @see $oldid
+ * @see getparentRevId()
+ */
public $parentRevId = 0;
/** @var string */
$this->isConflict = false;
# Show applicable editing introductions
- if ( $this->formtype == 'initial' || $this->firsttime ) {
+ if ( $this->formtype === 'initial' || $this->firsttime ) {
$this->showIntro();
}
# that edit() already checked just in case someone tries to sneak
# in the back door with a hand-edited submission URL.
- if ( 'save' == $this->formtype ) {
+ if ( 'save' === $this->formtype ) {
$resultDetails = null;
$status = $this->attemptSave( $resultDetails );
if ( !$this->handleStatus( $status, $resultDetails ) ) {
# First time through: get contents, set time for conflict
# checking, etc.
- if ( 'initial' == $this->formtype || $this->firsttime ) {
+ if ( 'initial' === $this->formtype || $this->firsttime ) {
if ( $this->initialiseForm() === false ) {
$this->noSuchSectionPage();
return;
foreach ( $permErrors as $error ) {
if ( ( $this->preview || $this->diff )
&& (
- $error[0] == 'blockedtext' ||
- $error[0] == 'autoblockedtext' ||
- $error[0] == 'systemblockedtext'
+ $error[0] === 'blockedtext' ||
+ $error[0] === 'autoblockedtext' ||
+ $error[0] === 'systemblockedtext'
)
) {
$remove[] = $error;
// security reasons
return false;
}
- if ( $request->getVal( 'preview' ) == 'yes' ) {
+ if ( $request->getVal( 'preview' ) === 'yes' ) {
// Explicit override from request
return true;
- } elseif ( $request->getVal( 'preview' ) == 'no' ) {
+ } elseif ( $request->getVal( 'preview' ) === 'no' ) {
// Explicit override from request
return false;
- } elseif ( $this->section == 'new' ) {
+ } elseif ( $this->section === 'new' ) {
// Nothing *to* preview for new sections
return false;
} elseif ( ( $request->getVal( 'preload' ) !== null || $this->mTitle->exists() )
throw new ErrorPageError( 'sectioneditnotsupported-title', 'sectioneditnotsupported-text' );
}
- $this->isNew = !$this->mTitle->exists() || $this->section == 'new';
+ $this->isNew = !$this->mTitle->exists() || $this->section === 'new';
if ( $request->wasPosted() ) {
# These fields need to be checked for encoding.
} else {
// If we receive the last parameter of the request, we can fairly
// claim the POST request has not been truncated.
-
- // TODO: softened the check for cutover. Once we determine
- // that it is safe, we should complete the transition by
- // removing the "edittime" clause.
- $this->incompleteForm = ( !$request->getVal( 'wpUltimateParam' )
- && is_null( $this->edittime ) );
+ $this->incompleteForm = !$request->getVal( 'wpUltimateParam' );
}
if ( $this->incompleteForm ) {
# If the form is incomplete, force to preview.
$user = $this->context->getUser();
# Don't force edit summaries when a user is editing their own user or talk page
- if ( ( $this->mTitle->mNamespace == NS_USER || $this->mTitle->mNamespace == NS_USER_TALK )
- && $this->mTitle->getText() == $user->getName()
+ if ( ( $this->mTitle->mNamespace === NS_USER || $this->mTitle->mNamespace === NS_USER_TALK )
+ && $this->mTitle->getText() === $user->getName()
) {
$this->allowBlankSummary = true;
} else {
// When creating a new section, we can preload a section title by passing it as the
// preloadtitle parameter in the URL (T15100)
- if ( $this->section == 'new' && $request->getVal( 'preloadtitle' ) ) {
+ if ( $this->section === 'new' && $request->getVal( 'preloadtitle' ) ) {
$this->sectiontitle = $request->getVal( 'preloadtitle' );
// Once wpSummary isn't being use for setting section titles, we should delete this.
$this->summary = $request->getVal( 'preloadtitle' );
- } elseif ( $this->section != 'new' && $request->getVal( 'summary' ) ) {
+ } elseif ( $this->section !== 'new' && $request->getVal( 'summary' ) ) {
$this->summary = $request->getText( 'summary' );
if ( $this->summary !== '' ) {
$this->hasPresetSummary = true;
$request = $this->context->getRequest();
// For message page not locally set, use the i18n message.
// For other non-existent articles, use preload text if any.
- if ( !$this->mTitle->exists() || $this->section == 'new' ) {
- if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI && $this->section != 'new' ) {
+ if ( !$this->mTitle->exists() || $this->section === 'new' ) {
+ if ( $this->mTitle->getNamespace() === NS_MEDIAWIKI && $this->section !== 'new' ) {
# If this is a system message, get the default text.
$msg = $this->mTitle->getDefaultMessageText();
if ( $undo > 0 && $undoafter > 0 ) {
$undorev = Revision::newFromId( $undo );
$oldrev = Revision::newFromId( $undoafter );
+ $undoMsg = null;
# Sanity check, make sure it's the right page,
# the revisions exist and they were not deleted.
!$undorev->isDeleted( Revision::DELETED_TEXT ) &&
!$oldrev->isDeleted( Revision::DELETED_TEXT )
) {
- $content = $this->page->getUndoContent( $undorev, $oldrev );
-
- if ( $content === false ) {
- # Warn the user that something went wrong
- $undoMsg = 'failure';
+ if ( WikiPage::hasDifferencesOutsideMainSlot( $undorev, $oldrev ) ) {
+ // Cannot yet undo edits that involve anything other the main slot.
+ $undoMsg = 'main-slot-only';
} else {
+ $content = $this->page->getUndoContent( $undorev, $oldrev );
+
+ if ( $content === false ) {
+ # Warn the user that something went wrong
+ $undoMsg = 'failure';
+ }
+ }
+
+ if ( $undoMsg === null ) {
$oldContent = $this->page->getContent( Revision::RAW );
$popts = ParserOptions::newFromUserAndLang( $user, $wgContLang );
$newContent = $content->preSaveTransform( $this->mTitle, $user, $popts );
# If we just undid one rev, use an autosummary
$firstrev = $oldrev->getNext();
- if ( $firstrev && $firstrev->getId() == $undo ) {
+ if ( $firstrev && $firstrev->getId() === $undo ) {
$userText = $undorev->getUserText();
if ( $userText === '' ) {
$undoSummary = $this->context->msg(
}
$out = $this->context->getOutput();
- // Messages: undo-success, undo-failure, undo-norev, undo-nochange
- $class = ( $undoMsg == 'success' ? '' : 'error ' ) . "mw-undo-{$undoMsg}";
+ // Messages: undo-success, undo-failure, undo-main-slot-only, undo-norev,
+ // undo-nochange.
+ $class = ( $undoMsg === 'success' ? '' : 'error ' ) . "mw-undo-{$undoMsg}";
$this->editFormPageTop .= $out->parse( "<div class=\"{$class}\">" .
$this->context->msg( 'undo-' . $undoMsg )->plain() . '</div>', true, /* interface */true );
}
* @return Content|null
*/
private function getOriginalContent( User $user ) {
- if ( $this->section == 'new' ) {
+ if ( $this->section === 'new' ) {
return $this->getCurrentContent();
}
$revision = $this->mArticle->getRevisionFetched();
$postEditKey = self::POST_EDIT_COOKIE_KEY_PREFIX . $revisionId;
$val = 'saved';
- if ( $statusValue == self::AS_SUCCESS_NEW_ARTICLE ) {
+ if ( $statusValue === self::AS_SUCCESS_NEW_ARTICLE ) {
$val = 'created';
} elseif ( $this->oldid ) {
$val = 'restored';
* @todo FIXME: once the interface for internalAttemptSave() is made
* nicer, this should use the message in $status
*/
- if ( $status->value == self::AS_SUCCESS_UPDATE
- || $status->value == self::AS_SUCCESS_NEW_ARTICLE
+ if ( $status->value === self::AS_SUCCESS_UPDATE
+ || $status->value === self::AS_SUCCESS_NEW_ARTICLE
) {
$this->incrementResolvedConflicts();
);
if ( $resultDetails['redirect'] ) {
- if ( $extraQuery == '' ) {
+ if ( $extraQuery === '' ) {
$extraQuery = 'redirect=no';
} else {
$extraQuery = 'redirect=no&' . $extraQuery;
*/
protected function runPostMergeFilters( Content $content, Status $status, User $user ) {
// Run old style post-section-merge edit filter
- if ( $this->hookError != '' ) {
+ if ( $this->hookError !== '' ) {
# ...or the hook could be expecting us to produce an error
$status->fatal( 'hookaborted' );
$status->value = self::AS_HOOK_ERROR_EXPECTED;
}
# Check image redirect
- if ( $this->mTitle->getNamespace() == NS_FILE &&
+ if ( $this->mTitle->getNamespace() === NS_FILE &&
$textbox_content->isRedirect() &&
!$user->isAllowed( 'upload' )
) {
# Check for spam
$match = self::matchSummarySpamRegex( $this->summary );
- if ( $match === false && $this->section == 'new' ) {
+ if ( $match === false && $this->section === 'new' ) {
# $wgSpamRegex is enforced on this new heading/summary because, unlike
# regular summaries, it is added to the actual wikitext.
if ( $this->sectiontitle !== '' ) {
$status->fatal( 'hookaborted' );
$status->value = self::AS_HOOK_ERROR;
return $status;
- } elseif ( $this->hookError != '' ) {
+ } elseif ( $this->hookError !== '' ) {
# ...or the hook could be expecting us to produce an error
$status->fatal( 'hookaborted' );
$status->value = self::AS_HOOK_ERROR_EXPECTED;
$content = $textbox_content;
$result['sectionanchor'] = '';
- if ( $this->section == 'new' ) {
+ if ( $this->section === 'new' ) {
if ( $this->sectiontitle !== '' ) {
// Insert the section title above the content.
$content = $content->addSectionHeader( $this->sectiontitle );
wfDebug( "timestamp: {$timestamp}, edittime: {$this->edittime}\n" );
- // Check editRevId if set, which handles same-second timestamp collisions
- if ( $timestamp != $this->edittime
- || ( $this->editRevId !== null && $this->editRevId != $latest )
+ // An edit conflict is detected if the current revision is different from the
+ // revision that was current when editing was initiated on the client.
+ // This is checked based on the timestamp and revision ID.
+ // TODO: the timestamp based check can probably go away now.
+ if ( $timestamp !== $this->edittime
+ || ( $this->editRevId !== null && $this->editRevId !== $latest )
) {
$this->isConflict = true;
- if ( $this->section == 'new' ) {
- if ( $this->page->getUserText() == $user->getName() &&
- $this->page->getComment() == $this->newSectionSummary()
+ if ( $this->section === 'new' ) {
+ if ( $this->page->getUserText() === $user->getName() &&
+ $this->page->getComment() === $this->newSectionSummary()
) {
// Probably a duplicate submission of a new comment.
// This can happen when CDN resends a request after
return $status;
}
- if ( $this->section == 'new' ) {
+ if ( $this->section === 'new' ) {
// Handle the user preference to force summaries here
- if ( !$this->allowBlankSummary && trim( $this->summary ) == '' ) {
+ if ( !$this->allowBlankSummary && trim( $this->summary ) === '' ) {
$this->missingSummary = true;
$status->fatal( 'missingsummary' ); // or 'missingcommentheader' if $section == 'new'. Blegh
$status->value = self::AS_SUMMARY_NEEDED;
}
// Do not allow the user to post an empty comment
- if ( $this->textbox1 == '' ) {
+ if ( $this->textbox1 === '' ) {
$this->missingComment = true;
$status->fatal( 'missingcommenttext' );
$status->value = self::AS_TEXTBOX_EMPTY;
} elseif ( !$this->allowBlankSummary
&& !$content->equals( $this->getOriginalContent( $user ) )
&& !$content->isRedirect()
- && md5( $this->summary ) == $this->autoSumm
+ && md5( $this->summary ) === $this->autoSumm
) {
$this->missingSummary = true;
$status->fatal( 'missingsummary' );
# All's well
$sectionanchor = '';
- if ( $this->section == 'new' ) {
+ if ( $this->section === 'new' ) {
$this->summary = $this->newSectionSummary( $sectionanchor );
- } elseif ( $this->section != '' ) {
+ } elseif ( $this->section !== '' ) {
# Try to get a section anchor from the section source, redirect
# to edited section if header found.
# XXX: Might be better to integrate this into Article::replaceSectionAtRev
$watch = $this->watchthis;
// Do this in its own transaction to reduce contention...
DeferredUpdates::addCallableUpdate( function () use ( $user, $title, $watch ) {
- if ( $watch == $user->isWatched( $title, User::IGNORE_USER_RIGHTS ) ) {
+ if ( $watch === $user->isWatched( $title, User::IGNORE_USER_RIGHTS ) ) {
return; // nothing to change
}
WatchAction::doWatchOrUnwatch( $watch, $title, $user );
private function mergeChangesIntoContent( &$editContent ) {
$db = wfGetDB( DB_MASTER );
- // This is the revision the editor started from
+ // This is the revision that was current at the time editing was initiated on the client,
+ // even if the edit was based on an old revision.
$baseRevision = $this->getBaseRevision();
$baseContent = $baseRevision ? $baseRevision->getContent() : null;
}
/**
- * @note: this method is very poorly named. If the user opened the form with ?oldid=X,
- * one might think of X as the "base revision", which is NOT what this returns.
- * @return Revision|null Current version when the edit was started
+ * Returns the revision that was current at the time editing was initiated on the client,
+ * even if the edit was based on an old revision.
+ *
+ * @warning: this method is very poorly named. If the user opened the form with ?oldid=X,
+ * one might think of X as the "base revision", which is NOT what this returns,
+ * see oldid for that. One might further assume that this corresponds to the $baseRevId
+ * parameter of WikiPage::doEditContent, which is not the case either.
+ * getExpectedParentRevision() would perhaps be a better name.
+ *
+ * @return Revision|null Current version when editing was initiated on the client
*/
public function getBaseRevision() {
if ( !$this->mBaseRevision ) {
$contextTitle = $this->getContextTitle();
if ( $this->isConflict ) {
$msg = 'editconflict';
- } elseif ( $contextTitle->exists() && $this->section != '' ) {
- $msg = $this->section == 'new' ? 'editingcomment' : 'editingsection';
+ } elseif ( $contextTitle->exists() && $this->section !== '' ) {
+ $msg = $this->section === 'new' ? 'editingcomment' : 'editingsection';
} else {
$msg = $contextTitle->exists()
- || ( $contextTitle->getNamespace() == NS_MEDIAWIKI
+ || ( $contextTitle->getNamespace() === NS_MEDIAWIKI
&& $contextTitle->getDefaultMessageText() !== false
)
? 'editing'
$out = $this->context->getOutput();
$namespace = $this->mTitle->getNamespace();
- if ( $namespace == NS_MEDIAWIKI ) {
+ if ( $namespace === NS_MEDIAWIKI ) {
# Show a warning if editing an interface message
$out->wrapWikiMsg( "<div class='mw-editinginterface'>\n$1\n</div>", 'editinginterface' );
# If this is a default message (but not css, json, or js),
'translateinterface' );
}
}
- } elseif ( $namespace == NS_FILE ) {
+ } elseif ( $namespace === NS_FILE ) {
# Show a hint to shared repo
$file = wfFindFile( $this->mTitle );
if ( $file && !$file->isLocal() ) {
# Show a warning message when someone creates/edits a user (talk) page but the user does not exist
# Show log extract when the user is currently blocked
- if ( $namespace == NS_USER || $namespace == NS_USER_TALK ) {
+ if ( $namespace === NS_USER || $namespace === NS_USER_TALK ) {
$username = explode( '/', $this->mTitle->getText(), 2 )[0];
$user = User::newFromName( $username, false /* allow IP users */ );
$ip = User::isIP( $username );
if ( !( $user && $user->isLoggedIn() ) && !$ip ) { # User does not exist
$out->wrapWikiMsg( "<div class=\"mw-userpage-userdoesnotexist error\">\n$1\n</div>",
[ 'userpage-userdoesnotexist', wfEscapeWikiText( $username ) ] );
- } elseif ( !is_null( $block ) && $block->getType() != Block::TYPE_AUTO ) {
+ } elseif ( !is_null( $block ) && $block->getType() !== Block::TYPE_AUTO ) {
# Show log extract if the user is currently blocked
LogEventsList::showLogExtract(
$out,
# we parse this near the beginning so that setHeaders can do the title
# setting work instead of leaving it in getPreviewText
$previewOutput = '';
- if ( $this->formtype == 'preview' ) {
+ if ( $this->formtype === 'preview' ) {
$previewOutput = $this->getPreviewText();
}
$this->addEditNotices();
if ( !$this->isConflict &&
- $this->section != '' &&
+ $this->section !== '' &&
!$this->isSectionEditSupported() ) {
// We use $this->section to much before this and getVal('wgSection') directly in other places
// at this point we can't reset $this->section to '' to fallback to non-section editing.
$showToolbar = true;
if ( $this->wasDeletedSinceLastEdit() ) {
- if ( $this->formtype == 'save' ) {
+ if ( $this->formtype === 'save' ) {
// Hide the toolbar and edit area, user can click preview to get it back
// Add an confirmation checkbox and explanation.
$showToolbar = false;
// Put these up at the top to ensure they aren't lost on early form submission
$this->showFormBeforeText();
- if ( $this->wasDeletedSinceLastEdit() && 'save' == $this->formtype ) {
+ if ( $this->wasDeletedSinceLastEdit() && 'save' === $this->formtype ) {
$username = $this->lastDelete->user_name;
$comment = CommentStore::getStore()
->getComment( 'log_comment', $this->lastDelete )->text;
# ####
# For a bit more sophisticated detection of blank summaries, hash the
# automatic one and pass that in the hidden field wpAutoSummary.
- if ( $this->missingSummary || ( $this->section == 'new' && $this->nosummary ) ) {
+ if ( $this->missingSummary || ( $this->section === 'new' && $this->nosummary ) ) {
$out->addHTML( Html::hidden( 'wpIgnoreBlankSummary', true ) );
}
$out->enableOOUI();
- if ( $this->section == 'new' ) {
+ if ( $this->section === 'new' ) {
$this->showSummaryInput( true, $this->summary );
$out->addHTML( $this->getSummaryPreview( true, $this->summary ) );
}
$type = false;
if ( $this->preview ) {
$type = 'preview';
- } elseif ( $this->section != '' ) {
+ } elseif ( $this->section !== '' ) {
$type = 'section';
}
$this->addExplainConflictHeader( $out );
$this->editRevId = $this->page->getLatest();
} else {
- if ( $this->section != '' && $this->section != 'new' ) {
+ if ( $this->section !== '' && $this->section !== 'new' ) {
if ( !$this->summary && !$this->preview && !$this->diff ) {
$sectionTitle = self::extractSectionTitle( $this->textbox1 ); // FIXME: use Content object
if ( $sectionTitle !== false ) {
$out->wrapWikiMsg( "<div id='mw-missingcommenttext'>\n$1\n</div>", 'missingcommenttext' );
}
- if ( $this->missingSummary && $this->section != 'new' ) {
+ if ( $this->missingSummary && $this->section !== 'new' ) {
$out->wrapWikiMsg(
"<div id='mw-missingsummary'>\n$1\n</div>",
[ 'missingsummary', $buttonLabel ]
);
}
- if ( $this->missingSummary && $this->section == 'new' ) {
+ if ( $this->missingSummary && $this->section === 'new' ) {
$out->wrapWikiMsg(
"<div id='mw-missingcommentheader'>\n$1\n</div>",
[ 'missingcommentheader', $buttonLabel ]
$out->addWikiText( $this->hookError );
}
- if ( $this->section != 'new' ) {
+ if ( $this->section !== 'new' ) {
$revision = $this->mArticle->getRevisionFetched();
if ( $revision ) {
// Let sysop know that this will make private content public if saved
[ 'readonlywarning', wfReadOnlyReason() ]
);
} elseif ( $user->isAnon() ) {
- if ( $this->formtype != 'preview' ) {
+ if ( $this->formtype !== 'preview' ) {
$out->wrapWikiMsg(
"<div id='mw-anon-edit-warning' class='warningbox'>\n$1\n</div>",
[ 'anoneditwarning',
* Builds a standard summary input with a label.
*
* @param string $summary The value of the summary input
- * @param string $labelText The html to place inside the label
- * @param array $inputAttrs Array of attrs to use on the input
+ * @param string|null $labelText The html to place inside the label
+ * @param array|null $inputAttrs Array of attrs to use on the input
*
* @return OOUI\FieldLayout OOUI FieldLayout with Label and Input
*/
* The $textoverride method can be used by subclasses overriding showContentForm
* to pass back to this method.
*
- * @param array $customAttribs Array of html attributes to use in the textarea
- * @param string $textoverride Optional text to override $this->textarea1 with
+ * @param array|null $customAttribs Array of html attributes to use in the textarea
+ * @param string|null $textoverride Optional text to override $this->textarea1 with
*/
protected function showTextbox1( $customAttribs = null, $textoverride = null ) {
- if ( $this->wasDeletedSinceLastEdit() && $this->formtype == 'save' ) {
+ if ( $this->wasDeletedSinceLastEdit() && $this->formtype === 'save' ) {
$attribs = [ 'style' => 'display:none;' ];
} else {
$builder = new TextboxBuilder();
}
$this->showTextbox(
- $textoverride !== null ? $textoverride : $this->textbox1,
+ $textoverride ?? $this->textbox1,
'wpTextbox1',
$attribs
);
$attribs = [ 'id' => 'wikiPreview', 'class' => implode( ' ', $classes ) ];
- if ( $this->formtype != 'preview' ) {
+ if ( $this->formtype !== 'preview' ) {
$attribs['style'] = 'display: none;';
}
$out = $this->context->getOutput();
$out->addHTML( Xml::openElement( 'div', $attribs ) );
- if ( $this->formtype == 'preview' ) {
+ if ( $this->formtype === 'preview' ) {
$this->showPreview( $previewOutput );
} else {
// Empty content container for LivePreview
$out->addHTML( '</div>' );
- if ( $this->formtype == 'diff' ) {
+ if ( $this->formtype === 'diff' ) {
try {
$this->showDiff();
} catch ( MWContentSerializationException $ex ) {
$oldtitlemsg = 'currentrev';
# if message does not exist, show diff against the preloaded default
- if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI && !$this->mTitle->exists() ) {
+ if ( $this->mTitle->getNamespace() === NS_MEDIAWIKI && !$this->mTitle->exists() ) {
$oldtext = $this->mTitle->getDefaultMessageText();
if ( $oldtext !== false ) {
$oldtitlemsg = 'defaultmessagetext';
$out = $this->context->getOutput();
$out->addHTML( "<div class='editOptions'>\n" );
- if ( $this->section != 'new' ) {
+ if ( $this->section !== 'new' ) {
$this->showSummaryInput( false, $this->summary );
$out->addHTML( $this->getSummaryPreview( false, $this->summary ) );
}
$level = false;
}
- if ( $content->getModel() == CONTENT_MODEL_CSS ) {
+ if ( $content->getModel() === CONTENT_MODEL_CSS ) {
$format = 'css';
if ( $level === 'user' && !$config->get( 'AllowUserCss' ) ) {
$format = false;
}
- } elseif ( $content->getModel() == CONTENT_MODEL_JSON ) {
+ } elseif ( $content->getModel() === CONTENT_MODEL_JSON ) {
$format = 'json';
if ( $level === 'user' /* No comparable 'AllowUserJson' */ ) {
$format = false;
}
- } elseif ( $content->getModel() == CONTENT_MODEL_JAVASCRIPT ) {
+ } elseif ( $content->getModel() === CONTENT_MODEL_JAVASCRIPT ) {
$format = 'js';
if ( $level === 'user' && !$config->get( 'AllowUserJs' ) ) {
$format = false;
* @return array
*/
public function getTemplates() {
- if ( $this->preview || $this->section != '' ) {
+ if ( $this->preview || $this->section !== '' ) {
$templates = [];
if ( !isset( $this->mParserOutput ) ) {
return $templates;
* Shows a bulletin board style toolbar for common editing functions.
* It can be disabled in the user preferences.
*
- * @param Title $title Title object for the page being edited (optional)
+ * @param Title|null $title Title object for the page being edited (optional)
* @return string
*/
public static function getEditToolbar( $title = null ) {
dépôts / lhc / web / wiklou.git / blobdiff