Remove call to deprecated $wgOut->includeJQuery();
[lhc/web/wiklou.git] / includes / EditPage.php
index e9db1e4..0c9be60 100644 (file)
@@ -96,7 +96,7 @@ class EditPage {
         * @todo document
         * @param $article
         */
-       function EditPage( $article ) {
+       function __construct( $article ) {
                $this->mArticle =& $article;
                $this->mTitle = $article->getTitle();
                $this->action = 'submit';
@@ -129,21 +129,19 @@ class EditPage {
                wfProfileIn( __METHOD__ );
                # Get variables from query string :P
                $section = $wgRequest->getVal( 'section' );
-                       
-               $preload = $wgRequest->getVal( 'preload', 
+
+               $preload = $wgRequest->getVal( 'preload',
                        // Custom preload text for new sections
                        $section === 'new' ? 'MediaWiki:addsection-preload' : '' );
                $undoafter = $wgRequest->getVal( 'undoafter' );
                $undo = $wgRequest->getVal( 'undo' );
 
-               $text = '';
                // For message page not locally set, use the i18n message.
                // For other non-existent articles, use preload text if any.
                if ( !$this->mTitle->exists() ) {
                        if ( $this->mTitle->getNamespace() == NS_MEDIAWIKI ) {
                                # If this is a system message, get the default text.
                                list( $message, $lang ) = $wgMessageCache->figureMessage( $wgContLang->lcfirst( $this->mTitle->getText() ) );
-                               $wgMessageCache->loadAllMessages( $lang );
                                $text = wfMsgGetKey( $message, false, $lang, false );
                                if( wfEmptyMsg( $message, $text ) )
                                        $text = $this->getPreloadedText( $preload );
@@ -319,19 +317,18 @@ class EditPage {
                        $this->preview = true;
                }
 
-               $wgOut->addScriptFile( 'edit.js' );
-               
+               $wgOut->addModules( 'mediawiki.legacy.edit' );
+
                if ( $wgUser->getOption( 'uselivepreview', false ) ) {
-                       $wgOut->includeJQuery();
-                       $wgOut->addScriptFile( 'preview.js' );
+                       $wgOut->addModules( 'mediawiki.legacy.preview' );
                }
-               // Bug #19334: textarea jumps when editing articles in IE8
-               $wgOut->addStyle( 'common/IE80Fixes.css', 'screen', 'IE 8' );
 
                $permErrors = $this->getEditPermissionErrors();
                if ( $permErrors ) {
                        wfDebug( __METHOD__ . ": User can't edit\n" );
-                       $this->readOnlyPage( $this->getContent( false ), true, $permErrors, 'edit' );
+                       $content = $this->getContent( null );
+                       $content = $content === '' ? null : $content;
+                       $this->readOnlyPage( $content, true, $permErrors, 'edit' );
                        wfProfileOut( __METHOD__ );
                        return;
                } else {
@@ -493,7 +490,7 @@ class EditPage {
        /**
         * Does this EditPage class support section editing?
         * This is used by EditPage subclasses to indicate their ui cannot handle section edits
-        * 
+        *
         * @return bool
         */
        protected function isSectionEditSupported() {
@@ -505,7 +502,7 @@ class EditPage {
         * This is used by EditPage subclasses when simply customizing the action
         * variable in the constructor is not enough. This can be used when the
         * EditPage lives inside of a Special page rather than a custom page action.
-        * 
+        *
         * @param $title Title object for which is being edited (where we go to for &action= links)
         * @return string
         */
@@ -655,7 +652,7 @@ class EditPage {
         * posted form to be placed in $this->textbox1, if using customized input
         * this method should be overrided and return the page text that will be used
         * for saving, preview parsing and so on...
-        * 
+        *
         * @param $request WebRequest
         */
        protected function importContentFormData( &$request ) {
@@ -690,7 +687,7 @@ class EditPage {
 
                if ( $namespace == NS_MEDIAWIKI ) {
                        # Show a warning if editing an interface message
-                       $wgOut->wrapWikiMsg( "<div class='mw-editinginterface'>\n$1</div>", 'editinginterface' );
+                       $wgOut->wrapWikiMsg( "<div class='mw-editinginterface'>\n$1\n</div>", 'editinginterface' );
                }
 
                # Show a warning message when someone creates/edits a user (talk) page but the user does not exist
@@ -701,7 +698,7 @@ class EditPage {
                        $user = User::newFromName( $username, false /* allow IP users*/ );
                        $ip = User::isIP( $username );
                        if ( !$user->isLoggedIn() && !$ip ) { # User does not exist
-                               $wgOut->wrapWikiMsg( "<div class=\"mw-userpage-userdoesnotexist error\">\n$1</div>",
+                               $wgOut->wrapWikiMsg( "<div class=\"mw-userpage-userdoesnotexist error\">\n$1\n</div>",
                                        array( 'userpage-userdoesnotexist', $username ) );
                        } else if ( $user->isBlocked() ) { # Show log extract if the user is currently blocked
                                LogEventsList::showLogExtract(
@@ -723,9 +720,9 @@ class EditPage {
                # Try to add a custom edit intro, or use the standard one if this is not possible.
                if ( !$this->showCustomIntro() && !$this->mTitle->exists() ) {
                        if ( $wgUser->isLoggedIn() ) {
-                               $wgOut->wrapWikiMsg( "<div class=\"mw-newarticletext\">\n$1</div>", 'newarticletext' );
+                               $wgOut->wrapWikiMsg( "<div class=\"mw-newarticletext\">\n$1\n</div>", 'newarticletext' );
                        } else {
-                               $wgOut->wrapWikiMsg( "<div class=\"mw-newarticletextanon\">\n$1</div>", 'newarticletextanon' );
+                               $wgOut->wrapWikiMsg( "<div class=\"mw-newarticletextanon\">\n$1\n</div>", 'newarticletextanon' );
                        }
                }
                # Give a notice if the user is editing a deleted/moved page...
@@ -765,7 +762,7 @@ class EditPage {
         * @return one of the constants describing the result
         */
        function internalAttemptSave( &$result, $bot = false ) {
-               global $wgFilterCallback, $wgUser, $wgOut, $wgParser;
+               global $wgFilterCallback, $wgUser, $wgParser;
                global $wgMaxArticleSize;
 
                wfProfileIn( __METHOD__  );
@@ -868,7 +865,7 @@ class EditPage {
                wfProfileOut( __METHOD__ . '-checks' );
 
                # If article is new, insert it.
-               $aid = $this->mTitle->getArticleID( GAID_FOR_UPDATE );
+               $aid = $this->mTitle->getArticleID( Title::GAID_FOR_UPDATE );
                if ( 0 == $aid ) {
                        // Late check for create permission, just in case *PARANOIA*
                        if ( !$this->mTitle->userCan( 'create' ) ) {
@@ -1017,7 +1014,7 @@ class EditPage {
                                return self::AS_TEXTBOX_EMPTY;
                        }
                        if ( $this->summary != '' ) {
-                               $sectionanchor = $wgParser->guessSectionNameFromWikiText( $this->summary );
+                               $sectionanchor = $wgParser->guessLegacySectionNameFromWikiText( $this->summary );
                                # This is a new section, so create a link to the new section
                                # in the revision summary.
                                $cleanSummary = $wgParser->stripSectionName( $this->summary );
@@ -1031,7 +1028,7 @@ class EditPage {
                        # we can't deal with anchors, includes, html etc in the header for now,
                        # headline would need to be parsed to improve this
                        if ( $hasmatch and strlen( $matches[2] ) > 0 ) {
-                               $sectionanchor = $wgParser->guessSectionNameFromWikiText( $matches[2] );
+                               $sectionanchor = $wgParser->guessLegacySectionNameFromWikiText( $matches[2] );
                        }
                }
                wfProfileOut( __METHOD__ . '-sectionanchor' );
@@ -1080,7 +1077,7 @@ class EditPage {
                        ),
                        __METHOD__,
                        array( 'ORDER BY' => 'rev_timestamp ASC', 'LIMIT' => 50 ) );
-               while( $row = $res->fetchObject() ) {
+               foreach ( $res as $row ) {
                        if( $row->rev_user != $id ) {
                                return false;
                        }
@@ -1140,7 +1137,6 @@ class EditPage {
                        # Already watched
                        $this->watchthis = true;
                }
-               if ( $wgUser->getOption( 'minordefault' ) ) $this->minoredit = true;
                if ( $this->textbox1 === false ) return false;
                wfProxyCheck();
                return true;
@@ -1175,7 +1171,7 @@ class EditPage {
         *                      parameter; will be called during form output
         *                      near the top, for captchas and the like.
         */
-       function showEditForm( $formCallback=null ) {
+       function showEditForm( $formCallback = null ) {
                global $wgOut, $wgUser, $wgTitle;
 
                # If $wgTitle is null, that means we're in API mode.
@@ -1234,7 +1230,7 @@ class EditPage {
 
                if ( $this->wasDeletedSinceLastEdit() && 'save' != $this->formtype ) {
                        $wgOut->wrapWikiMsg(
-                               "<div class='error mw-deleted-while-editing'>\n$1</div>",
+                               "<div class='error mw-deleted-while-editing'>\n$1\n</div>",
                                'deletedwhileediting' );
                } elseif ( $this->wasDeletedSinceLastEdit() ) {
                        // Hide the toolbar and edit area, user can click preview to get it back
@@ -1277,11 +1273,11 @@ HTML
                # automatic one and pass that in the hidden field wpAutoSummary.
                if ( $this->missingSummary ||
                        ( $this->section == 'new' && $this->nosummary ) )
-                               $wgOut->addHTML( Xml::hidden( 'wpIgnoreBlankSummary', true ) );
+                               $wgOut->addHTML( Html::hidden( 'wpIgnoreBlankSummary', true ) );
                $autosumm = $this->autoSumm ? $this->autoSumm : md5( $this->summary );
-               $wgOut->addHTML( Xml::hidden( 'wpAutoSummary', $autosumm ) );
+               $wgOut->addHTML( Html::hidden( 'wpAutoSummary', $autosumm ) );
 
-               $wgOut->addHTML( Xml::hidden( 'oldid', $this->mArticle->getOldID() ) );
+               $wgOut->addHTML( Html::hidden( 'oldid', $this->mArticle->getOldID() ) );
 
                if ( $this->section == 'new' ) {
                        $this->showSummaryInput( true, $this->summary );
@@ -1289,7 +1285,7 @@ HTML
                }
 
                $wgOut->addHTML( $this->editFormTextBeforeContent );
-               
+
                if ( $this->isConflict ) {
                        // In an edit conflict bypass the overrideable content form method
                        // and fallback to the raw wpTextbox1 since editconflicts can't be
@@ -1326,7 +1322,7 @@ HTML
 
                if ( $this->isConflict )
                        $this->showConflict();
-               
+
                $wgOut->addHTML( $this->editFormTextBottom );
                $wgOut->addHTML( "</form>\n" );
                if ( !$wgUser->getOption( 'previewontop' ) ) {
@@ -1335,11 +1331,11 @@ HTML
 
                wfProfileOut( __METHOD__ );
        }
-       
+
        protected function showHeader() {
                global $wgOut, $wgUser, $wgTitle, $wgMaxArticleSize, $wgLang;
                if ( $this->isConflict ) {
-                       $wgOut->wrapWikiMsg( "<div class='mw-explainconflict'>\n$1</div>", 'explainconflict' );
+                       $wgOut->wrapWikiMsg( "<div class='mw-explainconflict'>\n$1\n</div>", 'explainconflict' );
                        $this->edittime = $this->mArticle->getTimestamp();
                } else {
                        if ( $this->section != '' && !$this->isSectionEditSupported() ) {
@@ -1364,15 +1360,15 @@ HTML
                        }
 
                        if ( $this->missingComment ) {
-                               $wgOut->wrapWikiMsg( "<div id='mw-missingcommenttext'>\n$1</div>", 'missingcommenttext' );
+                               $wgOut->wrapWikiMsg( "<div id='mw-missingcommenttext'>\n$1\n</div>", 'missingcommenttext' );
                        }
 
                        if ( $this->missingSummary && $this->section != 'new' ) {
-                               $wgOut->wrapWikiMsg( "<div id='mw-missingsummary'>\n$1</div>", 'missingsummary' );
+                               $wgOut->wrapWikiMsg( "<div id='mw-missingsummary'>\n$1\n</div>", 'missingsummary' );
                        }
 
                        if ( $this->missingSummary && $this->section == 'new' ) {
-                               $wgOut->wrapWikiMsg( "<div id='mw-missingcommentheader'>\n$1</div>", 'missingcommentheader' );
+                               $wgOut->wrapWikiMsg( "<div id='mw-missingcommentheader'>\n$1\n</div>", 'missingcommentheader' );
                        }
 
                        if ( $this->hookError !== '' ) {
@@ -1387,9 +1383,9 @@ HTML
                        // Let sysop know that this will make private content public if saved
 
                                if ( !$this->mArticle->mRevision->userCan( Revision::DELETED_TEXT ) ) {
-                                       $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1</div>\n", 'rev-deleted-text-permission' );
+                                       $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1\n</div>\n", 'rev-deleted-text-permission' );
                                } else if ( $this->mArticle->mRevision->isDeleted( Revision::DELETED_TEXT ) ) {
-                                       $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1</div>\n", 'rev-deleted-text-view' );
+                                       $wgOut->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1\n</div>\n", 'rev-deleted-text-view' );
                                }
 
                                if ( !$this->mArticle->mRevision->isCurrent() ) {
@@ -1411,13 +1407,13 @@ HTML
                        if ( $this->isCssJsSubpage ) {
                                # Check the skin exists
                                if ( !$this->isValidCssJsSubpage ) {
-                                       $wgOut->addWikiMsg( 'userinvalidcssjstitle', $wgTitle->getSkinFromCssJsSubpage() );
+                                       $wgOut->wrapWikiMsg( "<div class='error' id='mw-userinvalidcssjstitle'>\n$1\n</div>", array( 'userinvalidcssjstitle', $wgTitle->getSkinFromCssJsSubpage() ) );
                                }
                                if ( $this->formtype !== 'preview' ) {
                                        if ( $this->isCssSubpage )
-                                               $wgOut->addWikiMsg( 'usercssyoucanpreview' );
+                                               $wgOut->wrapWikiMsg( "<div id='mw-usercssyoucanpreview'>\n$1\n</div>", array( 'usercssyoucanpreview' ) );
                                        if ( $this->isJsSubpage )
-                                               $wgOut->addWikiMsg( 'userjsyoucanpreview' );
+                                               $wgOut->wrapWikiMsg( "<div id='mw-userjsyoucanpreview'>\n$1\n</div>", array( 'userjsyoucanpreview' ) );
                                }
                        }
                }
@@ -1476,16 +1472,17 @@ HTML
         * Note that you do not need to worry about the label's for=, it will be
         * inferred by the id given to the input. You can remove them both by
         * passing array( 'id' => false ) to $userInputAttrs.
-        * 
+        *
         * @param $summary The value of the summary input
         * @param $labelText The html to place inside the label
         * @param $inputAttrs An array of attrs to use on the input
         * @param $spanLabelAttrs An array of attrs to use on the span inside the label
-        * 
+        *
         * @return array An array in the format array( $label, $input )
         */
        function getSummaryInput($summary = "", $labelText = null, $inputAttrs = null, $spanLabelAttrs = null) {
                global $wgUser;
+               //Note: the maxlength is overriden in JS to 250 and to make it use UTF-8 bytes, not characters.
                $inputAttrs = ( is_array($inputAttrs) ? $inputAttrs : array() ) + array(
                        'id' => 'wpSummary',
                        'maxlength' => '200',
@@ -1544,32 +1541,34 @@ HTML
        protected function getSummaryPreview( $isSubjectPreview, $summary = "" ) {
                if ( !$summary || ( !$this->preview && !$this->diff ) )
                        return "";
-               
+
                global $wgParser, $wgUser;
                $sk = $wgUser->getSkin();
-               
+
                if ( $isSubjectPreview )
                        $summary = wfMsgForContent( 'newsectionsummary', $wgParser->stripSectionName( $summary ) );
 
-               $summary = wfMsgExt( 'subject-preview', 'parseinline' ) . $sk->commentBlock( $summary, $this->mTitle, !!$isSubjectPreview );
+               $message = $isSubjectPreview ? 'subject-preview' : 'summary-preview';
+
+               $summary = wfMsgExt( $message, 'parseinline' ) . $sk->commentBlock( $summary, $this->mTitle, $isSubjectPreview );
                return Xml::tags( 'div', array( 'class' => 'mw-summary-preview' ), $summary );
        }
 
        protected function showFormBeforeText() {
                global $wgOut;
                $section = htmlspecialchars( $this->section );
-               $wgOut->addHTML( <<<INPUTS
+               $wgOut->addHTML( <<<HTML
 <input type='hidden' value="{$section}" name="wpSection" />
 <input type='hidden' value="{$this->starttime}" name="wpStarttime" />
 <input type='hidden' value="{$this->edittime}" name="wpEdittime" />
 <input type='hidden' value="{$this->scrolltop}" name="wpScrolltop" id="wpScrolltop" />
 
-INPUTS
+HTML
                );
                if ( !$this->checkUnicodeCompliantBrowser() )
-                       $wgOut->addHTML(Xml::hidden( 'safemode', '1' ));
+                       $wgOut->addHTML(Html::hidden( 'safemode', '1' ));
        }
-       
+
        protected function showFormAfterText() {
                global $wgOut, $wgUser;
                /**
@@ -1584,7 +1583,7 @@ INPUTS
                 * include the constant suffix to prevent editing from
                 * broken text-mangling proxies.
                 */
-               $wgOut->addHTML( "\n" . Xml::hidden( "wpEditToken", $wgUser->editToken() ) . "\n" );
+               $wgOut->addHTML( "\n" . Html::hidden( "wpEditToken", $wgUser->editToken() ) . "\n" );
        }
 
        /**
@@ -1594,8 +1593,6 @@ INPUTS
         * be it a form, or simply wpTextbox1 with a modified content that will be
         * reverse modified when extracted from the post data.
         * Note that this is basically the inverse for importContentFormData
-        * 
-        * @param $request WebRequest
         */
        protected function showContentForm() {
                $this->showTextbox1();
@@ -1605,7 +1602,7 @@ INPUTS
         * Method to output wpTextbox1
         * The $textoverride method can be used by subclasses overriding showContentForm
         * to pass back to this method.
-        * 
+        *
         * @param $customAttribs An array of html attributes to use in the textarea
         * @param $textoverride String: optional text to override $this->textarea1 with
         */
@@ -1631,7 +1628,7 @@ INPUTS
                                $classes[] = $attribs['class'];
                        $attribs['class'] = implode( ' ', $classes );
                }
-               
+
                $this->showTextbox( isset($textoverride) ? $textoverride : $this->textbox1, 'wpTextbox1', $attribs );
        }
 
@@ -1654,7 +1651,7 @@ INPUTS
                $attribs = $customAttribs + array(
                        'accesskey' => ',',
                        'id'   => $name,
-                       'cols' => $wgUser->getIntOption( 'cols' ), 
+                       'cols' => $wgUser->getIntOption( 'cols' ),
                        'rows' => $wgUser->getIntOption( 'rows' ),
                        'style' => '' // avoid php notices when appending preferences (appending allows customAttribs['style'] to still work
                );
@@ -1710,7 +1707,7 @@ INPUTS
         * Give a chance for site and per-namespace customizations of
         * terms of service summary link that might exist separately
         * from the copyright notice.
-        * 
+        *
         * This will display between the save button and the edit tools,
         * so should remain short!
         */
@@ -1732,7 +1729,7 @@ INPUTS
                $wgOut->addWikiMsgArray( 'edittools', array(), array( 'content' ) );
                $wgOut->addHTML( '</div>' );
        }
-       
+
        protected function getCopywarn() {
                global $wgRightsText;
                if ( $wgRightsText ) {
@@ -1745,10 +1742,10 @@ INPUTS
                }
                // Allow for site and per-namespace customization of contribution/copyright notice.
                wfRunHooks( 'EditPageCopyrightWarning', array( $this->mTitle, &$copywarnMsg ) );
-               
+
                return "<div id=\"editpage-copywarn\">\n" . call_user_func_array("wfMsgNoTrans", $copywarnMsg) . "\n</div>";
        }
-       
+
        protected function showStandardInputs( &$tabindex = 2 ) {
                global $wgOut, $wgUser;
                $wgOut->addHTML( "<div class='editOptions'>\n" );
@@ -1831,7 +1828,7 @@ INPUTS
         * @return string
         */
        function getPreviewText() {
-               global $wgOut, $wgUser, $wgTitle, $wgParser, $wgLang, $wgContLang, $wgMessageCache;
+               global $wgOut, $wgUser, $wgParser, $wgMessageCache;
 
                wfProfileIn( __METHOD__ );
 
@@ -1863,9 +1860,9 @@ INPUTS
 
                if ( $this->isCssJsSubpage ) {
                        if (preg_match( "/\\.css$/", $this->mTitle->getText() ) ) {
-                               $previewtext = wfMsg( 'usercsspreview' );
+                               $previewtext = "<div id='mw-usercsspreview'>\n" . wfMsg( 'usercsspreview' ) . "\n</div>";
                        } else if (preg_match( "/\\.js$/", $this->mTitle->getText() ) ) {
-                               $previewtext = wfMsg( 'userjspreview' );
+                               $previewtext = "<div id='mw-userjspreview'>\n" . wfMsg( 'userjspreview' ) . "\n</div>";
                        }
                        $parserOptions->setTidy( true );
                        $parserOutput = $wgParser->parse( $previewtext, $this->mTitle, $parserOptions );
@@ -2005,7 +2002,7 @@ INPUTS
         *
         * @param $match Text which triggered one or more filters
         */
-       function spamPage( $match = false ) {
+       static function spamPage( $match = false ) {
                global $wgOut, $wgTitle;
 
                $wgOut->setPageTitle( wfMsg( 'spamprotectiontitle' ) );
@@ -2014,8 +2011,9 @@ INPUTS
 
                $wgOut->addHTML( '<div id="spamprotected">' );
                $wgOut->addWikiMsg( 'spamprotectiontext' );
-               if ( $match )
+               if ( $match ) {
                        $wgOut->addWikiMsg( 'spamprotectionmatch', wfEscapeWikiText( $match ) );
+               }
                $wgOut->addHTML( '</div>' );
 
                $wgOut->returnToMain( false, $wgTitle );
@@ -2106,7 +2104,10 @@ INPUTS
         * @return string
         */
        static function getEditToolbar() {
-               global $wgStylePath, $wgContLang, $wgLang;
+               global $wgStylePath, $wgContLang, $wgLang, $wgOut;
+               global $wgUseTeX, $wgEnableUploads, $wgForeignFileRepos;
+
+               $imagesAvailable = $wgEnableUploads || count( $wgForeignFileRepos );
 
                /**
 
@@ -2166,7 +2167,7 @@ INPUTS
                                'tip'    => wfMsg( 'headline_tip' ),
                                'key'    => 'H'
                        ),
-                       array(
+                       $imagesAvailable ? array(
                                'image'  => $wgLang->getImageFile( 'button-image' ),
                                'id'     => 'mw-editbutton-image',
                                'open'   => '[[' . $wgContLang->getNsText( NS_FILE ) . ':',
@@ -2174,8 +2175,8 @@ INPUTS
                                'sample' => wfMsg( 'image_sample' ),
                                'tip'    => wfMsg( 'image_tip' ),
                                'key'    => 'D'
-                       ),
-                       array(
+                       ) : false,
+                       $imagesAvailable ? array(
                                'image'  => $wgLang->getImageFile( 'button-media' ),
                                'id'     => 'mw-editbutton-media',
                                'open'   => '[[' . $wgContLang->getNsText( NS_MEDIA ) . ':',
@@ -2183,8 +2184,8 @@ INPUTS
                                'sample' => wfMsg( 'media_sample' ),
                                'tip'    => wfMsg( 'media_tip' ),
                                'key'    => 'M'
-                       ),
-                       array(
+                       ) : false,
+                       $wgUseTeX ?     array(
                                'image'  => $wgLang->getImageFile( 'button-math' ),
                                'id'     => 'mw-editbutton-math',
                                'open'   => "<math>",
@@ -2192,7 +2193,7 @@ INPUTS
                                'sample' => wfMsg( 'math_sample' ),
                                'tip'    => wfMsg( 'math_tip' ),
                                'key'    => 'C'
-                       ),
+                       ) : false,
                        array(
                                'image'  => $wgLang->getImageFile( 'button-nowiki' ),
                                'id'     => 'mw-editbutton-nowiki',
@@ -2225,6 +2226,8 @@ INPUTS
 
                $script = '';
                foreach ( $toolarray as $tool ) {
+                       if ( !$tool ) continue;
+
                        $params = array(
                                $image = $wgStylePath . '/common/images/' . $tool['image'],
                                // Note that we use the tip both for the ALT tag and the TITLE tag of the image.
@@ -2242,8 +2245,11 @@ INPUTS
                                array_map( array( 'Xml', 'encodeJsVar' ), $params ) );
                        $script .= "addButton($paramList);\n";
                }
-               $toolbar .= Html::inlineScript( "\n$script\n" );
-
+               
+               $wgOut->addScript( Html::inlineScript(
+                       "if ( window.mediaWiki ) { $script }"
+               ) );
+               
                $toolbar .= "\n</div>";
 
                wfRunHooks( 'EditPageBeforeEditToolbar', array( &$toolbar ) );
@@ -2277,7 +2283,7 @@ INPUTS
                        );
                        $checkboxes['minor'] =
                                Xml::check( 'wpMinoredit', $checked['minor'], $attribs ) .
-                               "&nbsp;<label for='wpMinoredit'" . $skin->tooltip( 'minoredit', 'withaccess' ) . ">{$minorLabel}</label>";
+                               "&#160;<label for='wpMinoredit' id='mw-editpage-minoredit'" . $skin->tooltip( 'minoredit', 'withaccess' ) . ">{$minorLabel}</label>";
                }
 
                $watchLabel = wfMsgExt( 'watchthis', array( 'parseinline' ) );
@@ -2290,7 +2296,7 @@ INPUTS
                        );
                        $checkboxes['watch'] =
                                Xml::check( 'wpWatchthis', $checked['watch'], $attribs ) .
-                               "&nbsp;<label for='wpWatchthis'" . $skin->tooltip( 'watch', 'withaccess' ) . ">{$watchLabel}</label>";
+                               "&#160;<label for='wpWatchthis' id='mw-editpage-watch'" . $skin->tooltip( 'watch', 'withaccess' ) . ">{$watchLabel}</label>";
                }
                wfRunHooks( 'EditPageBeforeEditChecks', array( &$this, &$checkboxes, &$tabindex ) );
                return $checkboxes;
@@ -2586,7 +2592,7 @@ INPUTS
                                return false;
 
                        case self::AS_SPAM_ERROR:
-                               $this->spamPage( $resultDetails['spam'] );
+                               self::spamPage( $resultDetails['spam'] );
                                return false;
 
                        case self::AS_BLOCKED_PAGE_FOR_USER:
@@ -2625,7 +2631,7 @@ INPUTS
        }
 
        function getBaseRevision() {
-               if ( $this->mBaseRevision == false ) {
+               if ( !$this->mBaseRevision ) {
                        $db = wfGetDB( DB_MASTER );
                        $baseRevision = Revision::loadFromTimestamp(
                                $db, $this->mTitle, $this->edittime );
@@ -2633,5 +2639,5 @@ INPUTS
                } else {
                        return $this->mBaseRevision;
                }
-       }       
+       }
 }