Revert r19877; no reason is given for it but it breaks things such as parameter subst...
[lhc/web/wiklou.git] / includes / DifferenceEngine.php
index ba80e21..e6218b6 100644 (file)
@@ -1,31 +1,21 @@
 <?php
 /**
  * See diff.doc
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @addtogroup DifferenceEngine
  */
 
-/** */
-require_once( 'Revision.php' );
-
-define( 'MAX_DIFF_LINE', 10000 );
-define( 'MAX_DIFF_XREF_LENGTH', 10000 );
-
 /**
  * @todo document
- * @access public
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @public
+ * @addtogroup DifferenceEngine
  */
 class DifferenceEngine {
        /**#@+
-        * @access private
+        * @private
         */
        var $mOldid, $mNewid, $mTitle;
        var $mOldtitle, $mNewtitle, $mPagetitle;
        var $mOldtext, $mNewtext;
-       var $mOldUser, $mNewUser;
-       var $mOldComment, $mNewComment;
        var $mOldPage, $mNewPage;
        var $mRcidMarkPatrolled;
        var $mOldRev, $mNewRev;
@@ -35,10 +25,10 @@ class DifferenceEngine {
 
        /**
         * Constructor
-        * @param Title $titleObj Title object that the diff is associated with
-        * @param integer $old Old ID we want to show and diff with.
-        * @param string $new Either 'prev' or 'next'.
-        * @param integer $rcid ??? (default 0)
+        * @param $titleObj Title object that the diff is associated with
+        * @param $old Integer: old ID we want to show and diff with.
+        * @param $new String: either 'prev' or 'next'.
+        * @param $rcid Integer: ??? FIXME (default 0)
         */
        function DifferenceEngine( $titleObj = null, $old = 0, $new = 0, $rcid = 0 ) {
                $this->mTitle = $titleObj;
@@ -71,9 +61,8 @@ class DifferenceEngine {
                $this->mRcidMarkPatrolled = intval($rcid);  # force it to be an integer
        }
 
-       function showDiffPage() {
-               global $wgUser, $wgOut, $wgContLang, $wgOnlySysopsCanPatrol,
-                      $wgUseExternalEditor, $wgUseRCPatrol;
+       function showDiffPage( $diffOnly = false ) {
+               global $wgUser, $wgOut, $wgUseExternalEditor, $wgUseRCPatrol;
                $fname = 'DifferenceEngine::showDiffPage';
                wfProfileIn( $fname );
 
@@ -106,17 +95,18 @@ CONTROL;
                        return;
                }
 
-               $t = $this->mTitle->getPrefixedText() . " (Diff: {$this->mOldid}, " .
-                 "{$this->mNewid})";
-               $mtext = wfMsg( 'missingarticle', "<nowiki>$t</nowiki>" );
-
                $wgOut->setArticleFlag( false );
                if ( ! $this->loadRevisionData() ) {
+                       $t = $this->mTitle->getPrefixedText() . " (Diff: {$this->mOldid}, {$this->mNewid})";
+                       $mtext = wfMsg( 'missingarticle', "<nowiki>$t</nowiki>" );
                        $wgOut->setPagetitle( wfMsg( 'errorpagetitle' ) );
                        $wgOut->addWikitext( $mtext );
                        wfProfileOut( $fname );
                        return;
                }
+               
+               wfRunHooks( 'DiffViewHeader', array( $this, $this->mOldRev, $this->mNewRev ) );
+
                if ( $this->mNewRev->isCurrent() ) {
                        $wgOut->setArticleFlag( true );
                }
@@ -126,6 +116,7 @@ CONTROL;
                # is the first version of that article. In that case, V' does not exist.
                if ( $this->mOldid === false ) {
                        $this->showFirstRevision();
+                       $this->renderNewRevision();  // should we respect $diffOnly here or not?
                        wfProfileOut( $fname );
                        return;
                }
@@ -140,7 +131,7 @@ CONTROL;
                        $wgOut->setPageTitle( $oldTitle . ', ' . $newTitle );
                }
                $wgOut->setSubtitle( wfMsg( 'difference' ) );
-               $wgOut->setRobotpolicy( 'noindex,follow' );
+               $wgOut->setRobotpolicy( 'noindex,nofollow' );
 
                if ( !( $this->mOldPage->userCanRead() && $this->mNewPage->userCanRead() ) ) {
                        $wgOut->loginToUse();
@@ -150,33 +141,14 @@ CONTROL;
                }
 
                $sk = $wgUser->getSkin();
-               $talk = $wgContLang->getNsText( NS_TALK );
-               $contribs = wfMsg( 'contribslink' );
-
-               $this->mOldComment = $sk->formatComment($this->mOldComment);
-               $this->mNewComment = $sk->formatComment($this->mNewComment);
-
-               $oldUserLink = $sk->makeLinkObj( Title::makeTitleSafe( NS_USER, $this->mOldUser ), $this->mOldUser );
-               $newUserLink = $sk->makeLinkObj( Title::makeTitleSafe( NS_USER, $this->mNewUser ), $this->mNewUser );
-               $oldUTLink = $sk->makeLinkObj( Title::makeTitleSafe( NS_USER_TALK, $this->mOldUser ), $talk );
-               $newUTLink = $sk->makeLinkObj( Title::makeTitleSafe( NS_USER_TALK, $this->mNewUser ), $talk );
-               $oldContribs = $sk->makeKnownLinkObj( Title::makeTitle( NS_SPECIAL, 'Contributions' ), $contribs,
-                       'target=' . urlencode($this->mOldUser) );
-               $newContribs = $sk->makeKnownLinkObj( Title::makeTitle( NS_SPECIAL, 'Contributions' ), $contribs,
-                       'target=' . urlencode($this->mNewUser) );
+
                if ( $this->mNewRev->isCurrent() && $wgUser->isAllowed('rollback') ) {
-                       $rollback = '&nbsp;&nbsp;&nbsp;<strong>[' . $sk->makeKnownLinkObj( $this->mTitle, wfMsg( 'rollbacklink' ),
-                               'action=rollback&from=' . urlencode($this->mNewUser) .
-                               '&token=' . urlencode( $wgUser->editToken( array( $this->mTitle->getPrefixedText(), $this->mNewUser ) ) ) ) .
-                               ']</strong>';
+                       $rollback = '&nbsp;&nbsp;&nbsp;' . $sk->generateRollback( $this->mNewRev );
                } else {
                        $rollback = '';
                }
-               if ( $wgUseRCPatrol && $this->mRcidMarkPatrolled != 0 && $wgUser->isLoggedIn() &&
-                    ( $wgUser->isAllowed('rollback') || !$wgOnlySysopsCanPatrol ) )
-               {
-                       $patrol = ' [' . $sk->makeKnownLinkObj( $this->mTitle, wfMsg( 'markaspatrolleddiff' ),
-                               "action=markpatrolled&rcid={$this->mRcidMarkPatrolled}" ) . ']';
+               if( $wgUseRCPatrol && $this->mRcidMarkPatrolled != 0 && $wgUser->isAllowed( 'patrol' ) ) {
+                       $patrol = ' [' . $sk->makeKnownLinkObj( $this->mTitle, wfMsg( 'markaspatrolleddiff' ), "action=markpatrolled&rcid={$this->mRcidMarkPatrolled}" ) . ']';
                } else {
                        $patrol = '';
                }
@@ -184,34 +156,69 @@ CONTROL;
                $prevlink = $sk->makeKnownLinkObj( $this->mTitle, wfMsgHtml( 'previousdiff' ),
                        'diff=prev&oldid='.$this->mOldid, '', '', 'id="differences-prevlink"' );
                if ( $this->mNewRev->isCurrent() ) {
-                       $nextlink = '';
+                       $nextlink = '&nbsp;';
                } else {
                        $nextlink = $sk->makeKnownLinkObj( $this->mTitle, wfMsgHtml( 'nextdiff' ),
                                'diff=next&oldid='.$this->mNewid, '', '', 'id="differences-nextlink"' );
                }
 
-               $oldHeader = "<strong>{$this->mOldtitle}</strong><br />$oldUserLink " .
-                       "($oldUTLink | $oldContribs)<br />" . $this->mOldComment .
-                       '<br />' . $prevlink;
-               $newHeader = "<strong>{$this->mNewtitle}</strong><br />$newUserLink " .
-                       "($newUTLink | $newContribs) $rollback<br />" . $this->mNewComment .
-                       '<br />' . $nextlink . $patrol;
+               $oldminor = '';
+               $newminor = '';
+
+               if ($this->mOldRev->mMinorEdit == 1) {
+                       $oldminor = wfElement( 'span', array( 'class' => 'minor' ),
+                               wfMsg( 'minoreditletter') ) . ' ';
+               }
+
+               if ($this->mNewRev->mMinorEdit == 1) {
+                       $newminor = wfElement( 'span', array( 'class' => 'minor' ),
+                       wfMsg( 'minoreditletter') ) . ' ';
+               }
+
+               $oldHeader = "<strong>{$this->mOldtitle}</strong><br />" .
+                       $sk->revUserTools( $this->mOldRev ) . "<br />" .
+                       $oldminor . $sk->revComment( $this->mOldRev, !$diffOnly ) . "<br />" .
+                       $prevlink;
+               $newHeader = "<strong>{$this->mNewtitle}</strong><br />" .
+                       $sk->revUserTools( $this->mNewRev ) . " $rollback<br />" .
+                       $newminor . $sk->revComment( $this->mNewRev, !$diffOnly ) . "<br />" .
+                       $nextlink . $patrol;
 
                $this->showDiff( $oldHeader, $newHeader );
+
+               if ( !$diffOnly )
+                       $this->renderNewRevision();
+
+               wfProfileOut( $fname );
+       }
+
+       /**
+        * Show the new revision of the page.
+        */
+       function renderNewRevision() {
+               global $wgOut;
+               $fname = 'DifferenceEngine::renderNewRevision';
+               wfProfileIn( $fname );
+
                $wgOut->addHTML( "<hr /><h2>{$this->mPagetitle}</h2>\n" );
+               #add deleted rev tag if needed
+               if ( !$this->mNewRev->userCan(Revision::DELETED_TEXT) ) {
+                       $wgOut->addWikiText( wfMsg( 'rev-deleted-text-permission' ) );
+               }
 
                if( !$this->mNewRev->isCurrent() ) {
-                       $oldEditSectionSetting = $wgOut->mParserOptions->setEditSection( false );
+                       $oldEditSectionSetting = $wgOut->parserOptions()->setEditSection( false );
                }
 
                $this->loadNewText();
                if( is_object( $this->mNewRev ) ) {
                        $wgOut->setRevisionId( $this->mNewRev->getId() );
                }
-               $wgOut->addSecondaryWikiText( $this->mNewtext );
+
+               $wgOut->addWikiTextTidy( $this->mNewtext );
 
                if( !$this->mNewRev->isCurrent() ) {
-                       $wgOut->mParserOptions->setEditSection( $oldEditSectionSetting );
+                       $wgOut->parserOptions()->setEditSection( $oldEditSectionSetting );
                }
 
                wfProfileOut( $fname );
@@ -222,7 +229,7 @@ CONTROL;
         * contrast to normal "old revision" display style.
         */
        function showFirstRevision() {
-               global $wgOut, $wgUser, $wgLang;
+               global $wgOut, $wgUser;
 
                $fname = 'DifferenceEngine::showFirstRevision';
                wfProfileIn( $fname );
@@ -255,28 +262,16 @@ CONTROL;
                #
                $sk = $wgUser->getSkin();
 
-               $uTLink = $sk->makeLinkObj( Title::makeTitleSafe( NS_USER_TALK, $this->mOldUser ),  $wgLang->getNsText( NS_TALK ) );
-               $userLink = $sk->makeLinkObj( Title::makeTitleSafe( NS_USER, $this->mOldUser ), $this->mOldUser );
-               $contribs = $sk->makeKnownLinkObj( Title::makeTitle( NS_SPECIAL, 'Contributions' ), wfMsg( 'contribslink' ),
-                       'target=' . urlencode($this->mOldUser) );
                $nextlink = $sk->makeKnownLinkObj( $this->mTitle, wfMsgHtml( 'nextdiff' ), 'diff=next&oldid='.$this->mNewid, '', '', 'id="differences-nextlink"' );
-               $header = "<div class=\"firstrevisionheader\" style=\"text-align: center\"><strong>{$this->mOldtitle}</strong><br />$userLink " .
-                       "($uTLink | $contribs)<br />" . $this->mOldComment .
-                       '<br />' . $nextlink. "</div>\n";
+               $header = "<div class=\"firstrevisionheader\" style=\"text-align: center\"><strong>{$this->mOldtitle}</strong><br />" .
+                       $sk->revUserTools( $this->mNewRev ) . "<br />" .
+                       $sk->revComment( $this->mNewRev ) . "<br />" .
+                       $nextlink . "</div>\n";
 
                $wgOut->addHTML( $header );
 
                $wgOut->setSubtitle( wfMsg( 'difference' ) );
-               $wgOut->setRobotpolicy( 'noindex,follow' );
-
-
-               # Show current revision
-               #
-               $wgOut->addHTML( "<hr /><h2>{$this->mPagetitle}</h2>\n" );
-               if( is_object( $this->mNewRev ) ) {
-                       $wgOut->setRevisionId( $this->mNewRev->getId() );
-               }
-               $wgOut->addSecondaryWikiText( $this->mNewtext );
+               $wgOut->setRobotpolicy( 'noindex,nofollow' );
 
                wfProfileOut( $fname );
        }
@@ -289,7 +284,7 @@ CONTROL;
                global $wgOut;
                $diff = $this->getDiff( $otitle, $ntitle );
                if ( $diff === false ) {
-                       $wgOut->addWikitext( wfMsg( 'missingarticle', "<nowiki>$t</nowiki>" ) );
+                       $wgOut->addWikitext( wfMsg( 'missingarticle', "<nowiki>(fixme, bug)</nowiki>" ) );
                        return false;
                } else {
                        $wgOut->addHTML( $diff );
@@ -307,7 +302,8 @@ CONTROL;
                if ( $body === false ) {
                        return false;
                } else {
-                       return $this->addHeader( $body, $otitle, $ntitle );
+                       $multi = $this->getMultiNotice();
+                       return $this->addHeader( $body, $otitle, $ntitle, $multi );
                }
        }
 
@@ -317,7 +313,7 @@ CONTROL;
         * Returns false on error
         */
        function getDiffBody() {
-               global $wgContLang, $wgMemc, $wgDBname;
+               global $wgMemc;
                $fname = 'DifferenceEngine::getDiffBody';
                wfProfileIn( $fname );
                
@@ -325,36 +321,40 @@ CONTROL;
                $key = false;
                if ( $this->mOldid && $this->mNewid ) {
                        // Try cache
-                       $key = "$wgDBname:diff:oldid:{$this->mOldid}:newid:{$this->mNewid}";
+                       $key = wfMemcKey( 'diff', 'oldid', $this->mOldid, 'newid', $this->mNewid );
                        $difftext = $wgMemc->get( $key );
                        if ( $difftext ) {
                                wfIncrStats( 'diff_cache_hit' );
                                $difftext = $this->localiseLineNumbers( $difftext );
-                               $difftext .= "\n<!-- diff cache key $key -->\n"; 
+                               $difftext .= "\n<!-- diff cache key $key -->\n";
                                wfProfileOut( $fname );
                                return $difftext;
                        }
                }
 
+               #loadtext is permission safe, this just clears out the diff
                if ( !$this->loadText() ) {
                        wfProfileOut( $fname );
                        return false;
+               } else if ( $this->mOldRev && !$this->mOldRev->userCan(Revision::DELETED_TEXT) ) {
+                 return '';
+               } else if ( $this->mNewRev && !$this->mNewRev->userCan(Revision::DELETED_TEXT) ) {
+                 return '';
                }
 
-               $otext = $wgContLang->segmentForDiff($this->mOldtext);
-               $ntext = $wgContLang->segmentForDiff($this->mNewtext);
-               $difftext = $this->generateDiffBody( $otext, $ntext );
-               $difftext = $wgContLang->unsegmentForDiff($difftext);
-
+               $difftext = $this->generateDiffBody( $this->mOldtext, $this->mNewtext );
+               
                // Save to cache for 7 days
-               if ( $key !== false ) {
+               if ( $key !== false && $difftext !== false ) {
                        wfIncrStats( 'diff_cache_miss' );
                        $wgMemc->set( $key, $difftext, 7*86400 );
                } else {
                        wfIncrStats( 'diff_uncacheable' );
                }
                // Replace line numbers with the text in the user's language
-               $difftext = $this->localiseLineNumbers( $difftext );
+               if ( $difftext !== false ) {
+                       $difftext = $this->localiseLineNumbers( $difftext );
+               }
                wfProfileOut( $fname );
                return $difftext;
        }
@@ -364,36 +364,41 @@ CONTROL;
         * $otext and $ntext must be already segmented
         */
        function generateDiffBody( $otext, $ntext ) {
-               global $wgExternalDiffEngine;
+               global $wgExternalDiffEngine, $wgContLang;
                $fname = 'DifferenceEngine::generateDiffBody';
+
+               $otext = str_replace( "\r\n", "\n", $otext );
+               $ntext = str_replace( "\r\n", "\n", $ntext );
+               
                if ( $wgExternalDiffEngine == 'wikidiff' ) {
                        # For historical reasons, external diff engine expects
                        # input text to be HTML-escaped already
-                       $otext = str_replace( "\r\n", "\n", htmlspecialchars ( $otext ) );
-                       $ntext = str_replace( "\r\n", "\n", htmlspecialchars ( $ntext ) );
+                       $otext = htmlspecialchars ( $wgContLang->segmentForDiff( $otext ) );
+                       $ntext = htmlspecialchars ( $wgContLang->segmentForDiff( $ntext ) );
                        if( !function_exists( 'wikidiff_do_diff' ) ) {
                                dl('php_wikidiff.so');
                        }
-                       return wikidiff_do_diff( $otext, $ntext, 2 );
-               } 
+                       return $wgContLang->unsegementForDiff( wikidiff_do_diff( $otext, $ntext, 2 ) );
+               }
                
                if ( $wgExternalDiffEngine == 'wikidiff2' ) {
                        # Better external diff engine, the 2 may some day be dropped
-                       # This one does the escaping itself
-                       $otext = str_replace( "\r\n", "\n", $otext );
-                       $ntext = str_replace( "\r\n", "\n", $ntext );                   
+                       # This one does the escaping and segmenting itself
                        if ( !function_exists( 'wikidiff2_do_diff' ) ) {
+                               wfProfileIn( "$fname-dl" );
                                @dl('php_wikidiff2.so');
+                               wfProfileOut( "$fname-dl" );
                        }
                        if ( function_exists( 'wikidiff2_do_diff' ) ) {
-                               return wikidiff2_do_diff( $otext, $ntext, 2 );
+                               wfProfileIn( 'wikidiff2_do_diff' );
+                               $text = wikidiff2_do_diff( $otext, $ntext, 2 );
+                               wfProfileOut( 'wikidiff2_do_diff' );
+                               return $text;
                        }
                }
                if ( $wgExternalDiffEngine !== false ) {
                        # Diff via the shell
                        global $wgTmpDirectory;
-                       $otext = str_replace( "\r\n", "\n", $otext );
-                       $ntext = str_replace( "\r\n", "\n", $ntext );
                        $tempName1 = tempnam( $wgTmpDirectory, 'diff_' );
                        $tempName2 = tempnam( $wgTmpDirectory, 'diff_' );
 
@@ -421,11 +426,11 @@ CONTROL;
                }
                
                # Native PHP diff
-               $ota = explode( "\n", str_replace( "\r\n", "\n", $otext ) );
-               $nta = explode( "\n", str_replace( "\r\n", "\n", $ntext ) );
-               $diffs =& new Diff( $ota, $nta );
-               $formatter =& new TableDiffFormatter();
-               return $formatter->format( $diffs );
+               $ota = explode( "\n", $wgContLang->segmentForDiff( $otext ) );
+               $nta = explode( "\n", $wgContLang->segmentForDiff( $ntext ) );
+               $diffs = new Diff( $ota, $nta );
+               $formatter = new TableDiffFormatter();
+               return $wgContLang->unsegmentForDiff( $formatter->format( $diffs ) );
        }
                
 
@@ -433,29 +438,66 @@ CONTROL;
         * Replace line numbers with the text in the user's language
         */
        function localiseLineNumbers( $text ) {
-               return preg_replace_callback( '/<!--LINE (\d+)-->/', 
+               return preg_replace_callback( '/<!--LINE (\d+)-->/',
                        array( &$this, 'localiseLineNumbersCb' ), $text );
        }
 
        function localiseLineNumbersCb( $matches ) {
                global $wgLang;
-               return wfMsg( 'lineno', $wgLang->formatNum( $matches[1] ) );
+               return wfMsgExt( 'lineno', array('parseinline'), $wgLang->formatNum( $matches[1] ) );
+       }
+
+       
+       /**
+        * If there are revisions between the ones being compared, return a note saying so.
+        */
+       function getMultiNotice() {
+               if ( !is_object($this->mOldRev) || !is_object($this->mNewRev) )
+                       return '';
+               
+               if( !$this->mOldPage->equals( $this->mNewPage ) ) {
+                       // Comparing two different pages? Count would be meaningless.
+                       return '';
+               }
+               
+               $oldid = $this->mOldRev->getId();
+               $newid = $this->mNewRev->getId();
+               if ( $oldid > $newid ) {
+                       $tmp = $oldid; $oldid = $newid; $newid = $tmp;
+               }
+
+               $n = $this->mTitle->countRevisionsBetween( $oldid, $newid );
+               if ( !$n )
+                       return '';
+
+               return wfMsgExt( 'diff-multi', array( 'parseinline' ), $n );
        }
 
+
        /**
         * Add the header to a diff body
         */
-       function addHeader( $diff, $otitle, $ntitle ) {
-               $out = "
+       function addHeader( $diff, $otitle, $ntitle, $multi = '' ) {
+               global $wgOut;
+       
+               if ( $this->mOldRev && $this->mOldRev->isDeleted(Revision::DELETED_TEXT) ) {
+                  $otitle = '<span class="history-deleted">'.$otitle.'</span>';
+               }
+               if ( $this->mNewRev && $this->mNewRev->isDeleted(Revision::DELETED_TEXT) ) {
+                  $ntitle = '<span class="history-deleted">'.$ntitle.'</span>';
+               }
+               $header = "
                        <table border='0' width='98%' cellpadding='0' cellspacing='4' class='diff'>
                        <tr>
                                <td colspan='2' width='50%' align='center' class='diff-otitle'>{$otitle}</td>
                                <td colspan='2' width='50%' align='center' class='diff-ntitle'>{$ntitle}</td>
                        </tr>
-                       $diff
-                       </table>
                ";
-               return $out;
+
+               if ( $multi != '' )
+                       $header .= "<tr><td colspan='4' align='center' class='diff-multi'>{$multi}</td></tr>";
+
+               return $header . $diff . "</table>";
        }
 
        /**
@@ -498,21 +540,28 @@ CONTROL;
                }
 
                // Set assorted variables
+               $timestamp = $wgLang->timeanddate( $this->mNewRev->getTimestamp(), true );
+               $this->mNewPage = $this->mNewRev->getTitle();
                if( $this->mNewRev->isCurrent() ) {
-                       $this->mPagetitle = htmlspecialchars( wfMsg( 'currentrev' ) );
-                       $this->mNewPage = $this->mTitle;
                        $newLink = $this->mNewPage->escapeLocalUrl();
-                       $this->mNewtitle = "<a href='$newLink'>{$this->mPagetitle}</a>";
+                       $this->mPagetitle = htmlspecialchars( wfMsg( 'currentrev' ) );
+                       $newEdit = $this->mNewPage->escapeLocalUrl( 'action=edit' );
+                       $newUndo = $this->mNewPage->escapeLocalUrl( 'action=edit&undo=' . $this->mNewid );
+
+                       $this->mNewtitle = "<a href='$newLink'>{$this->mPagetitle}</a> ($timestamp)"
+                               . " (<a href='$newEdit'>" . htmlspecialchars( wfMsg( 'editold' ) ) . "</a>)"
+                               . " (<a href='$newUndo'>" . htmlspecialchars( wfMsg( 'editundo' ) ) . "</a>)";
+
                } else {
-                       $this->mNewPage = $this->mNewRev->getTitle();
-                       $newLink = $this->mNewPage->escapeLocalUrl ('oldid=' . $this->mNewid );
-                       $t = $wgLang->timeanddate( $this->mNewRev->getTimestamp(), true );
-                       $this->mPagetitle = htmlspecialchars( wfMsg( 'revisionasof', $t ) );
-                       $this->mNewtitle = "<a href='$newLink'>{$this->mPagetitle}</a>";
-               }
+                       $newLink = $this->mNewPage->escapeLocalUrl( 'oldid=' . $this->mNewid );
+                       $newEdit = $this->mNewPage->escapeLocalUrl( 'action=edit&oldid=' . $this->mNewid );
+                       $newUndo = $this->mNewPage->escapeLocalUrl( 'action=edit&undo=' . $this->mNewid );
+                       $this->mPagetitle = htmlspecialchars( wfMsg( 'revisionasof', $timestamp ) );
 
-               $this->mNewUser = $this->mNewRev->getUserText();
-               $this->mNewComment = $this->mNewRev->getComment();
+                       $this->mNewtitle = "<a href='$newLink'>{$this->mPagetitle}</a>"
+                               . " (<a href='$newEdit'>" . htmlspecialchars( wfMsg( 'editold' ) ) . "</a>)"
+                               . " (<a href='$newUndo'>" . htmlspecialchars( wfMsg( 'editundo' ) ) . "</a>)";
+               }
 
                // Load the old revision object
                $this->mOldRev = false;
@@ -539,11 +588,9 @@ CONTROL;
 
                        $t = $wgLang->timeanddate( $this->mOldRev->getTimestamp(), true );
                        $oldLink = $this->mOldPage->escapeLocalUrl( 'oldid=' . $this->mOldid );
-                       $this->mOldtitle = "<a href='$oldLink'>" . htmlspecialchars( wfMsg( 'revisionasof', $t ) ) . '</a>';
-
-
-                       $this->mOldUser = $this->mOldRev->getUserText();
-                       $this->mOldComment = $this->mOldRev->getComment();
+                       $oldEdit = $this->mOldPage->escapeLocalUrl( 'action=edit&oldid=' . $this->mOldid );
+                       $this->mOldtitle = "<a href='$oldLink'>" . htmlspecialchars( wfMsg( 'revisionasof', $t ) )
+                               . "</a> (<a href='$oldEdit'>" . htmlspecialchars( wfMsg( 'editold' ) ) . "</a>)";
                }
 
                return true;
@@ -564,13 +611,14 @@ CONTROL;
                        return false;
                }
                if ( $this->mOldRev ) {
-                       $this->mOldtext = $this->mOldRev->getText();
+                       // FIXME: permission tests
+                       $this->mOldtext = $this->mOldRev->revText();
                        if ( $this->mOldtext === false ) {
                                return false;
                        }
                }
                if ( $this->mNewRev ) {
-                       $this->mNewtext = $this->mNewRev->getText();
+                       $this->mNewtext = $this->mNewRev->revText();
                        if ( $this->mNewtext === false ) {
                                return false;
                        }
@@ -607,9 +655,8 @@ define('USE_ASSERTS', function_exists('assert'));
 
 /**
  * @todo document
- * @access private
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @private
+ * @addtogroup DifferenceEngine
  */
 class _DiffOp {
        var $type;
@@ -631,9 +678,8 @@ class _DiffOp {
 
 /**
  * @todo document
- * @access private
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @private
+ * @addtogroup DifferenceEngine
  */
 class _DiffOp_Copy extends _DiffOp {
        var $type = 'copy';
@@ -652,9 +698,8 @@ class _DiffOp_Copy extends _DiffOp {
 
 /**
  * @todo document
- * @access private
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @private
+ * @addtogroup DifferenceEngine
  */
 class _DiffOp_Delete extends _DiffOp {
        var $type = 'delete';
@@ -671,9 +716,8 @@ class _DiffOp_Delete extends _DiffOp {
 
 /**
  * @todo document
- * @access private
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @private
+ * @addtogroup DifferenceEngine
  */
 class _DiffOp_Add extends _DiffOp {
        var $type = 'add';
@@ -690,9 +734,8 @@ class _DiffOp_Add extends _DiffOp {
 
 /**
  * @todo document
- * @access private
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @private
+ * @addtogroup DifferenceEngine
  */
 class _DiffOp_Change extends _DiffOp {
        var $type = 'change';
@@ -728,12 +771,13 @@ class _DiffOp_Change extends _DiffOp {
  * Line length limits for robustness added by Tim Starling, 2005-08-31
  *
  * @author Geoffrey T. Dairiki, Tim Starling
- * @access private
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @private
+ * @addtogroup DifferenceEngine
  */
 class _DiffEngine
 {
+       const MAX_XREF_LENGTH =  10000;
+
        function diff ($from_lines, $to_lines) {
                $fname = '_DiffEngine::diff';
                wfProfileIn( $fname );
@@ -831,7 +875,7 @@ class _DiffEngine
         * Returns the whole line if it's small enough, or the MD5 hash otherwise
         */
        function _line_hash( $line ) {
-               if ( strlen( $line ) > MAX_DIFF_XREF_LENGTH ) {
+               if ( strlen( $line ) > self::MAX_XREF_LENGTH ) {
                        return md5( $line );
                } else {
                        return $line;
@@ -902,7 +946,7 @@ class _DiffEngine
                                                $ymids[$k] = $ymids[$k-1];
                                                break;
                                        }
-                               while (list ($junk, $y) = each($matches)) {
+                               while (list ( /* $junk */, $y) = each($matches)) {
                                        if ($y > $this->seq[$k-1]) {
                                                USE_ASSERTS && assert($y < $this->seq[$k]);
                                                // Optimization: this is a common case:
@@ -1148,9 +1192,8 @@ class _DiffEngine
 /**
  * Class representing a 'diff' between two sequences of strings.
  * @todo document
- * @access private
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @private
+ * @addtogroup DifferenceEngine
  */
 class Diff
 {
@@ -1290,9 +1333,8 @@ class Diff
 /**
  * FIXME: bad name.
  * @todo document
- * @access private
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @private
+ * @addtogroup DifferenceEngine
  */
 class MappedDiff extends Diff
 {
@@ -1354,9 +1396,8 @@ class MappedDiff extends Diff
  * It is intended that this class be customized via inheritance,
  * to obtain fancier outputs.
  * @todo document
- * @access private
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @private
+ * @addtogroup DifferenceEngine
  */
 class DiffFormatter
 {
@@ -1521,9 +1562,8 @@ define('NBSP', '&#160;');                 // iso-8859-x non-breaking space.
 
 /**
  * @todo document
- * @access private
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @private
+ * @addtogroup DifferenceEngine
  */
 class _HWLDF_WordAccumulator {
        function _HWLDF_WordAccumulator () {
@@ -1535,9 +1575,12 @@ class _HWLDF_WordAccumulator {
 
        function _flushGroup ($new_tag) {
                if ($this->_group !== '') {
-                       if ($this->_tag == 'mark')
-                               $this->_line .= '<span class="diffchange">' .
-                                       htmlspecialchars ( $this->_group ) . '</span>';
+                       if ($this->_tag == 'ins')
+                               $this->_line .= '<ins class="diffchange">' .
+                                       htmlspecialchars ( $this->_group ) . '</ins>';
+                       elseif ($this->_tag == 'del')
+                               $this->_line .= '<del class="diffchange">' .
+                                       htmlspecialchars ( $this->_group ) . '</del>';
                        else
                                $this->_line .= htmlspecialchars ( $this->_group );
                }
@@ -1580,12 +1623,13 @@ class _HWLDF_WordAccumulator {
 
 /**
  * @todo document
- * @access private
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @private
+ * @addtogroup DifferenceEngine
  */
 class WordLevelDiff extends MappedDiff
 {
+       const MAX_LINE_LENGTH = 10000;
+
        function WordLevelDiff ($orig_lines, $closing_lines) {
                $fname = 'WordLevelDiff::WordLevelDiff';
                wfProfileIn( $fname );
@@ -1614,10 +1658,11 @@ class WordLevelDiff extends MappedDiff
                                $words[] = "\n";
                                $stripped[] = "\n";
                        }
-                       if ( strlen( $line ) > MAX_DIFF_LINE ) {
+                       if ( strlen( $line ) > self::MAX_LINE_LENGTH ) {
                                $words[] = $line;
                                $stripped[] = $line;
                        } else {
+                               $m = array();
                                if (preg_match_all('/ ( [^\S\n]+ | [0-9_A-Za-z\x80-\xff]+ | . ) (?: (?!< \n) [^\S\n])? /xs',
                                        $line, $m))
                                {
@@ -1639,7 +1684,7 @@ class WordLevelDiff extends MappedDiff
                        if ($edit->type == 'copy')
                                $orig->addWords($edit->orig);
                        elseif ($edit->orig)
-                               $orig->addWords($edit->orig, 'mark');
+                               $orig->addWords($edit->orig, 'del');
                }
                $lines = $orig->getLines();
                wfProfileOut( $fname );
@@ -1655,7 +1700,7 @@ class WordLevelDiff extends MappedDiff
                        if ($edit->type == 'copy')
                                $closing->addWords($edit->closing);
                        elseif ($edit->closing)
-                               $closing->addWords($edit->closing, 'mark');
+                               $closing->addWords($edit->closing, 'ins');
                }
                $lines = $closing->getLines();
                wfProfileOut( $fname );
@@ -1666,9 +1711,8 @@ class WordLevelDiff extends MappedDiff
 /**
  *     Wikipedia Table style diff formatter.
  * @todo document
- * @access private
- * @package MediaWiki
- * @subpackage DifferenceEngine
+ * @private
+ * @addtogroup DifferenceEngine
  */
 class TableDiffFormatter extends DiffFormatter
 {
@@ -1684,7 +1728,6 @@ class TableDiffFormatter extends DiffFormatter
        }
 
        function _start_block( $header ) {
-               global $wgOut;
                echo $header;
        }