Alrighty, now we properly remove old blocks before inserting the new one. (Bug 10080...
[lhc/web/wiklou.git] / includes / Block.php
index 6257b71..2a1ad69 100644 (file)
@@ -1,5 +1,6 @@
 <?php
 /**
+ * @file
  * Blocks and bans object
  */
 
 class Block
 {
        /* public*/ var $mAddress, $mUser, $mBy, $mReason, $mTimestamp, $mAuto, $mId, $mExpiry,
-                               $mRangeStart, $mRangeEnd, $mAnonOnly, $mEnableAutoblock, $mHideName;
-       /* private */ var $mNetworkBits, $mIntegerAddr, $mForUpdate, $mFromMaster, $mByName;
-       
+                               $mRangeStart, $mRangeEnd, $mAnonOnly, $mEnableAutoblock, $mHideName,
+                               $mBlockEmail, $mByName;
+       /* private */ var $mNetworkBits, $mIntegerAddr, $mForUpdate, $mFromMaster;
+
        const EB_KEEP_EXPIRED = 1;
        const EB_FOR_UPDATE = 2;
        const EB_RANGE_ONLY = 4;
 
        function __construct( $address = '', $user = 0, $by = 0, $reason = '',
-               $timestamp = '' , $auto = 0, $expiry = '', $anonOnly = 0, $createAccount = 0, $enableAutoblock = 0, 
-               $hideName = 0 )
+               $timestamp = '' , $auto = 0, $expiry = '', $anonOnly = 0, $createAccount = 0, $enableAutoblock = 0,
+               $hideName = 0, $blockEmail = 0 )
        {
                $this->mId = 0;
                # Expand valid IPv6 addresses
@@ -40,7 +42,7 @@ class Block
                $this->mExpiry = self::decodeExpiry( $expiry );
                $this->mEnableAutoblock = $enableAutoblock;
                $this->mHideName = $hideName;
-
+               $this->mBlockEmail = $blockEmail;
                $this->mForUpdate = false;
                $this->mFromMaster = false;
                $this->mByName = false;
@@ -58,10 +60,10 @@ class Block
                }
        }
 
-       static function newFromID( $id ) 
+       static function newFromID( $id )
        {
                $dbr = wfGetDB( DB_SLAVE );
-               $res = $dbr->resultObject( $dbr->select( 'ipblocks', '*', 
+               $res = $dbr->resultObject( $dbr->select( 'ipblocks', '*',
                        array( 'ipb_id' => $id ), __METHOD__ ) );
                $block = new Block;
                if ( $block->loadFromResult( $res ) ) {
@@ -74,9 +76,9 @@ class Block
        function clear()
        {
                $this->mAddress = $this->mReason = $this->mTimestamp = '';
-               $this->mId = $this->mAnonOnly = $this->mCreateAccount = 
-                       $this->mEnableAutoblock = $this->mAuto = $this->mUser = 
-                       $this->mBy = $this->mHideName = 0;
+               $this->mId = $this->mAnonOnly = $this->mCreateAccount =
+                       $this->mEnableAutoblock = $this->mAuto = $this->mUser =
+                       $this->mBy = $this->mHideName = $this->mBlockEmail = 0;
                $this->mByName = false;
        }
 
@@ -123,7 +125,7 @@ class Block
 
                # Try user block
                if ( $user ) {
-                       $res = $db->resultObject( $db->select( 'ipblocks', '*', array( 'ipb_user' => $user ), 
+                       $res = $db->resultObject( $db->select( 'ipblocks', '*', array( 'ipb_user' => $user ),
                                __METHOD__, $options ) );
                        if ( $this->loadFromResult( $res, $killExpired ) ) {
                                return true;
@@ -149,7 +151,7 @@ class Block
                }
 
                # Try range block
-               if ( $this->loadRange( $address, $killExpired, $user == 0 ) ) {
+               if ( $this->loadRange( $address, $killExpired, $user ) ) {
                        if ( $user && $this->mAnonOnly ) {
                                $this->clear();
                                return false;
@@ -169,7 +171,7 @@ class Block
                                return true;
                        }
                }
-               
+
                # Give up
                $this->clear();
                return false;
@@ -178,7 +180,7 @@ class Block
        /**
         * Fill in member variables from a result wrapper
         */
-       function loadFromResult( ResultWrapper $res, $killExpired = true ) 
+       function loadFromResult( ResultWrapper $res, $killExpired = true )
        {
                $ret = false;
                if ( 0 != $res->numRows() ) {
@@ -233,7 +235,7 @@ class Block
                        "ipb_range_start <= '$iaddr'",
                        "ipb_range_end >= '$iaddr'"
                );
-               
+
                if ( $user ) {
                        $conds['ipb_anon_only'] = 0;
                }
@@ -262,13 +264,14 @@ class Block
                $this->mAnonOnly = $row->ipb_anon_only;
                $this->mCreateAccount = $row->ipb_create_account;
                $this->mEnableAutoblock = $row->ipb_enable_autoblock;
+               $this->mBlockEmail = $row->ipb_block_email;
                $this->mHideName = $row->ipb_deleted;
                $this->mId = $row->ipb_id;
                $this->mExpiry = self::decodeExpiry( $row->ipb_expiry );
                if ( isset( $row->user_name ) ) {
                        $this->mByName = $row->user_name;
                } else {
-                       $this->mByName = false;
+                       $this->mByName = $row->ipb_by_text;
                }
                $this->mRangeStart = $row->ipb_range_start;
                $this->mRangeEnd = $row->ipb_range_end;
@@ -356,7 +359,7 @@ class Block
 
        /**
        * Insert a block into the block table.
-       *@return Whether or not the insertion was successful.
+       * @return Whether or not the insertion was successful.
        */
        function insert()
        {
@@ -371,6 +374,16 @@ class Block
                # Unset ipb_enable_autoblock for IP blocks, makes no sense
                if ( !$this->mUser ) {
                        $this->mEnableAutoblock = 0;
+                       $this->mBlockEmail = 0; //Same goes for email...
+               }
+
+               if( !$this->mByName ) {
+                       if( $this->mBy ) {
+                               $this->mByName = User::whoIs( $this->mBy );
+                       } else {
+                               global $wgUser;
+                               $this->mByName = $wgUser->getName();
+                       }
                }
 
                # Don't collide with expired blocks
@@ -383,6 +396,7 @@ class Block
                                'ipb_address' => $this->mAddress,
                                'ipb_user' => $this->mUser,
                                'ipb_by' => $this->mBy,
+                               'ipb_by_text' => $this->mByName,
                                'ipb_reason' => $this->mReason,
                                'ipb_timestamp' => $dbw->timestamp($this->mTimestamp),
                                'ipb_auto' => $this->mAuto,
@@ -392,11 +406,11 @@ class Block
                                'ipb_expiry' => self::encodeExpiry( $this->mExpiry, $dbw ),
                                'ipb_range_start' => $this->mRangeStart,
                                'ipb_range_end' => $this->mRangeEnd,
-                               'ipb_deleted'   => $this->mHideName
+                               'ipb_deleted'   => $this->mHideName,
+                               'ipb_block_email' => $this->mBlockEmail
                        ), 'Block::insert', array( 'IGNORE' )
                );
                $affected = $dbw->affectedRows();
-               $dbw->commit();
 
                if ($affected)
                        $this->doRetroactiveAutoblock();
@@ -438,9 +452,6 @@ class Block
        * @return bool Whether or not an autoblock was inserted.
        */
        function doAutoblock( $autoblockip, $justInserted = false ) {
-               # Check if this IP address is already blocked
-               $dbw = wfGetDB( DB_MASTER );
-
                # If autoblocks are disabled, go away.
                if ( !$this->mEnableAutoblock ) {
                        return;
@@ -475,6 +486,12 @@ class Block
                                wfDebug( " No match\n" );
                        }
                }
+               
+               ## Allow hooks to cancel the autoblock.
+               if (!wfRunHooks( 'AbortAutoblock', array( $autoblockip, &$this ) )) {
+                       wfDebug( "Autoblock aborted by hook." );
+                       return false;
+               }
 
                # It's okay to autoblock. Go ahead and create/insert the block.
 
@@ -591,9 +608,6 @@ class Block
         */
        function getByName()
        {
-               if ( $this->mByName === false ) {
-                       $this->mByName = User::whoIs( $this->mBy );
-               }
                return $this->mByName;
        }
 
@@ -612,7 +626,7 @@ class Block
                        return $this->mAddress;
                }
        }
-       
+
        /**
         * Encode expiry for DB
         */
@@ -624,24 +638,24 @@ class Block
                }
        }
 
-       /** 
+       /**
         * Decode expiry which has come from the DB
         */
-       static function decodeExpiry( $expiry ) {
+       static function decodeExpiry( $expiry, $timestampType = TS_MW ) {
                if ( $expiry == '' || $expiry == Block::infinity() ) {
                        return Block::infinity();
                } else {
-                       return wfTimestamp( TS_MW, $expiry );
+                       return wfTimestamp( $timestampType, $expiry );
                }
        }
-       
+
        static function getAutoblockExpiry( $timestamp )
        {
                global $wgAutoblockExpiry;
                return wfTimestamp( TS_MW, wfTimestamp( TS_UNIX, $timestamp ) + $wgAutoblockExpiry );
        }
-       
-       /** 
+
+       /**
         * Gets rid of uneeded numbers in quad-dotted/octet IP strings
         * For example, 127.111.113.151/24 -> 127.111.113.0/24
         */
@@ -674,7 +688,7 @@ class Block
                return $range;
        }
 
-       /** 
+       /**
         * Purge expired blocks from the ipblocks table
         */
        static function purgeExpired() {
@@ -683,8 +697,8 @@ class Block
        }
 
        static function infinity() {
-               # This is a special keyword for timestamps in PostgreSQL, and 
-               # works with CHAR(14) as well because "i" sorts after all numbers.              
+               # This is a special keyword for timestamps in PostgreSQL, and
+               # works with CHAR(14) as well because "i" sorts after all numbers.
                return 'infinity';
 
                /*
@@ -696,6 +710,48 @@ class Block
                return $infinity;
                 */
        }
+       
+       /**
+        * Convert a DB-encoded expiry into a real string that humans can read.
+        */
+       static function formatExpiry( $encoded_expiry ) {
+       
+               static $msg = null;
+               
+               if( is_null( $msg ) ) {
+                       $msg = array();
+                       $keys = array( 'infiniteblock', 'expiringblock' );
+                       foreach( $keys as $key ) {
+                               $msg[$key] = wfMsgHtml( $key );
+                       }
+               }
+               
+               $expiry = Block::decodeExpiry( $encoded_expiry );
+               if ($expiry == 'infinity') {
+                       $expirystr = $msg['infiniteblock'];
+               } else {
+                       global $wgLang;
+                       $expiretimestr = $wgLang->timeanddate( $expiry, true );
+                       $expirystr = wfMsgReplaceArgs( $msg['expiringblock'], array($expiretimestr) );
+               }
+
+               return $expirystr;
+       }
+       
+       /**
+        * Convert a typed-in expiry time into something we can put into the database.
+        */
+       static function parseExpiryInput( $expiry_input ) {
+               if ( $expiry_input == 'infinite' || $expiry_input == 'indefinite' ) {
+                       $expiry = 'infinity';
+               } else {
+                       $expiry = strtotime( $expiry_input );
+                       if ($expiry < 0 || $expiry === false) {
+                               return false;
+                       }
+               }
+               
+               return $expiry;
+       }
 
 }
-?>