Merge "Do not use OutputPage to output exceptions in Installer"

[lhc/web/wiklou.git] / includes / Article.php

diff --git a/includes/Article.php b/includes/Article.php
index ce6407a..a5d4d5b 100644 (file)
--- a/includes/Article.php
+++ b/includes/Article.php
@@ -158,7 +158,7 @@ class Article implements Page {
                }
 
                $page = null;
-               wfRunHooks( 'ArticleFromTitle', array( &$title, &$page ) );
+               wfRunHooks( 'ArticleFromTitle', array( &$title, &$page, $context ) );
                if ( !$page ) {
                        switch ( $title->getNamespace() ) {
                                case NS_FILE:
@@ -460,14 +460,6 @@ class Article implements Page {
                return $this->mContentObject;
        }
 
-       /**
-        * No-op
-        * @deprecated since 1.18
-        */
-       public function forUpdate() {
-               wfDeprecated( __METHOD__, '1.18' );
-       }
-
        /**
         * Returns true if the currently-referenced revision is the current edit
         * to this page (and it exists).
@@ -980,7 +972,7 @@ class Article implements Page {
                                $outputPage->addSubtitle( wfMessage( 'redirectedfrom' )->rawParams( $redir ) );
 
                                // Set the fragment if one was specified in the redirect
-                               if ( strval( $this->getTitle()->getFragment() ) != '' ) {
+                               if ( $this->getTitle()->hasFragment() ) {
                                        $outputPage->addJsConfigVars( 'wgRedirectToFragment', $this->getTitle()->getFragmentForURL() );
                                        $outputPage->addModules( 'mediawiki.action.view.redirectToFragment' );
                                }
@@ -1620,7 +1612,8 @@ class Article implements Page {
                $outputPage->setPageTitle( wfMessage( 'delete-confirm', $this->getTitle()->getPrefixedText() ) );
                $outputPage->addBacklinkSubtitle( $this->getTitle() );
                $outputPage->setRobotPolicy( 'noindex,nofollow' );
-               if ( $this->getTitle()->getBacklinkCache()->hasLinks( 'pagelinks' ) ) {
+               $backlinkCache = $this->getTitle()->getBacklinkCache();
+               if ( $backlinkCache->hasLinks( 'pagelinks' ) || $backlinkCache->hasLinks( 'templatelinks' ) ) {
                        $outputPage->wrapWikiMsg( "<div class='mw-warning plainlinks'>\n$1\n</div>\n",
                                'deleting-backlinks-warning' );
                }
@@ -1898,15 +1891,6 @@ class Article implements Page {
                Action::factory( 'info', $this )->show();
        }
 
-       /**
-        * Mark this particular edit/page as patrolled
-        * @deprecated since 1.18
-        */
-       public function markpatrolled() {
-               wfDeprecated( __METHOD__, '1.18' );
-               Action::factory( 'markpatrolled', $this )->show();
-       }
-
        /**
         * Handle action=purge
         * @deprecated since 1.19
@@ -1934,72 +1918,6 @@ class Article implements Page {
                Action::factory( 'rollback', $this )->show();
        }
 
-       /**
-        * User-interface handler for the "watch" action.
-        * Requires Request to pass a token as of 1.18.
-        * @deprecated since 1.18
-        */
-       public function watch() {
-               wfDeprecated( __METHOD__, '1.18' );
-               Action::factory( 'watch', $this )->show();
-       }
-
-       /**
-        * Add this page to the current user's watchlist
-        *
-        * This is safe to be called multiple times
-        *
-        * @return bool true on successful watch operation
-        * @deprecated since 1.18
-        */
-       public function doWatch() {
-               wfDeprecated( __METHOD__, '1.18' );
-               return WatchAction::doWatch( $this->getTitle(), $this->getContext()->getUser() );
-       }
-
-       /**
-        * User interface handler for the "unwatch" action.
-        * Requires Request to pass a token as of 1.18.
-        * @deprecated since 1.18
-        */
-       public function unwatch() {
-               wfDeprecated( __METHOD__, '1.18' );
-               Action::factory( 'unwatch', $this )->show();
-       }
-
-       /**
-        * Stop watching a page
-        * @return bool true on successful unwatch
-        * @deprecated since 1.18
-        */
-       public function doUnwatch() {
-               wfDeprecated( __METHOD__, '1.18' );
-               return WatchAction::doUnwatch( $this->getTitle(), $this->getContext()->getUser() );
-       }
-
-       /**
-        * Output a redirect back to the article.
-        * This is typically used after an edit.
-        *
-        * @deprecated in 1.18; call OutputPage::redirect() directly
-        * @param $noRedir Boolean: add redirect=no
-        * @param string $sectionAnchor section to redirect to, including "#"
-        * @param string $extraQuery extra query params
-        */
-       public function doRedirect( $noRedir = false, $sectionAnchor = '', $extraQuery = '' ) {
-               wfDeprecated( __METHOD__, '1.18' );
-               if ( $noRedir ) {
-                       $query = 'redirect=no';
-                       if ( $extraQuery ) {
-                               $query .= "&$extraQuery";
-                       }
-               } else {
-                       $query = $extraQuery;
-               }
-
-               $this->getContext()->getOutput()->redirect( $this->getTitle()->getFullURL( $query ) . $sectionAnchor );
-       }
-
        /**
         * Use PHP's magic __get handler to handle accessing of
         * raw WikiPage fields for backwards compatibility.