From 899f475d0dad8ea0a24f706fc8ac07e3097d6191 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Mon, 10 Dec 2018 15:29:43 -0500 Subject: [PATCH] rdbms: reduce LoadBalancer replication log spam LoadMonitor already has similar and less-frequent logging since it only happens on cache rebuilds. Bug: T204531 Change-Id: I270a65ab1d3f471bd49c8f54d85151c91827a518 (cherry picked from commit 38b54d71ece279f978246fefa21142f34cb6e07f) --- RELEASE-NOTES-1.31 | 1 + includes/libs/rdbms/loadbalancer/LoadBalancer.php | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31 index 5569367745..fa89df3b01 100644 --- a/RELEASE-NOTES-1.31 +++ b/RELEASE-NOTES-1.31 @@ -49,6 +49,7 @@ THIS IS NOT A RELEASE YET * Fix addition of ug_expiry column to user_groups table on MSSQL. * (T204767) Add join conditions to ActiveUsersPager * (T210621) User: Bypass repeatable-read when creating an actor_id. +* (T204531) rdbms: reduce LoadBalancer replication log spam. == MediaWiki 1.31.1 == diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php b/includes/libs/rdbms/loadbalancer/LoadBalancer.php index 29793ee853..d5e65cdddf 100644 --- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php +++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php @@ -311,7 +311,7 @@ class LoadBalancer implements ILoadBalancer { ": server {host} is not replicating?", [ 'host' => $host ] ); unset( $loads[$i] ); } elseif ( $lag > $maxServerLag ) { - $this->replLogger->info( + $this->replLogger->debug( __METHOD__ . ": server {host} has {lag} seconds of lag (>= {maxlag})", [ 'host' => $host, 'lag' => $lag, 'maxlag' => $maxServerLag ] -- 2.20.1