From 5739d1454b5bc5ae7fe178ac7b92dd2134d7f194 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Wed, 28 Mar 2018 19:42:31 -0700 Subject: [PATCH] rdbms: make LoadBalancer::doWait() cast $timeout to an integer Make sure that fractional values are not sent to masterPosWait() Change-Id: I0a66471d4bf7005774b5741702c7f9c65bbfd5d0 --- includes/libs/rdbms/loadbalancer/LoadBalancer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/libs/rdbms/loadbalancer/LoadBalancer.php b/includes/libs/rdbms/loadbalancer/LoadBalancer.php index 94acc1ef05..96b6180409 100644 --- a/includes/libs/rdbms/loadbalancer/LoadBalancer.php +++ b/includes/libs/rdbms/loadbalancer/LoadBalancer.php @@ -591,7 +591,7 @@ class LoadBalancer implements ILoadBalancer { * @return bool */ protected function doWait( $index, $open = false, $timeout = null ) { - $timeout = max( 1, $timeout ?: $this->waitTimeout ); + $timeout = max( 1, intval( $timeout ?: $this->waitTimeout ) ); // Check if we already know that the DB has reached this point $server = $this->getServerName( $index ); -- 2.20.1