lhc/web/wiklou.git
12 years agofix bug #29102: Upgrade fails "Unknown character set: 'mysql4'"
Mark A. Hershberger [Wed, 9 Nov 2011 03:25:15 +0000 (03:25 +0000)]
fix bug #29102: Upgrade fails "Unknown character set: 'mysql4'"

by replacing "mysql4" with "binary"

Trivial enough to be backported, I think.

12 years agoDelete LanguageSr_el.deps.php. LanguageSr_ec.php doesn't
Platonides [Tue, 8 Nov 2011 23:23:23 +0000 (23:23 +0000)]
Delete LanguageSr_el.deps.php. LanguageSr_ec.php doesn't
contain any base class used in LanguageSr_el. Not even in r13157.

12 years agoAdd name for code tly: Talysh ( http://en.wikipedia.org/wiki/Talysh_language ).
Platonides [Tue, 8 Nov 2011 23:01:30 +0000 (23:01 +0000)]
Add name for code tly: Talysh ( en.wikipedia.org/wiki/Talysh_language ).
There are translations in that language for the toolserver and
some extensions (AdminLinks, Babel, CategoryTree, Contest, GlobalUsage,
LanguageSelector, Todo, Translate and WikiData).

12 years agoMark as FIXME. This three calls leak a png filename in sys_get_temp_dir() each,
Platonides [Tue, 8 Nov 2011 22:27:25 +0000 (22:27 +0000)]
Mark as FIXME. This three calls leak a png filename in sys_get_temp_dir() each,
tempnam() like, not the two-words filenames of RandomImageGenerator::getRandomFilenames()
They aren't produced by ApiTestCaseUpload::fakeUploadFile() either.

12 years agoTest for bug 32057.
Platonides [Tue, 8 Nov 2011 21:55:05 +0000 (21:55 +0000)]
Test for bug 32057.
Latent bug in quite unused preprocessing path (expansion of heading nodes),
which was exposed by r101291 and fixed in r102440.
This test is used to exercise that code path.

12 years agoRevert r99307 and its friend r99309, improper use of !important per CR
Roan Kattouw [Tue, 8 Nov 2011 21:38:06 +0000 (21:38 +0000)]
Revert r99307 and its friend r99309, improper use of !important per CR

12 years agoAttempt to fix translatewiki bug 32057
Platonides [Tue, 8 Nov 2011 20:58:57 +0000 (20:58 +0000)]
Attempt to fix translatewiki bug 32057
The different Preprocessor::newChild expect false (with strict comparison) if there's no title passed to them.

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Tue, 8 Nov 2011 20:32:28 +0000 (20:32 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoFix for r102417: commiting OutputPage.php is actually a good idea
Alexandre Emsenhuber [Tue, 8 Nov 2011 18:02:26 +0000 (18:02 +0000)]
Fix for r102417: commiting OutputPage.php is actually a good idea

12 years ago* Changed OutputPage's handling of subtitles to use an array and implode it with...
Alexandre Emsenhuber [Tue, 8 Nov 2011 18:01:22 +0000 (18:01 +0000)]
* Changed OutputPage's handling of subtitles to use an array and implode it with "<br />" so that callers don't have to bother whether there's already a subtitle when adding new ones
* Make OutputPage::setSubtitle(), OutputPage::addSubtitle() and OutputPage::appendSubtitle() accept a Message object in addition to a string
* Added new method OutputPage::addSubtitle() to replace appendSubtitle() and marked it as deprecated
* Clear the subtitles when showing an error page
* Always show the subtitle from Article::viewRedirect() when showing a page; left the parameter for use in EditPage
* Make Article::setOldSubtitle() add two subtitles and has to set "display:inline;" for the three possible divs to avoid too many spacing
* Removed the six different backlink subtitles and added one new message 'backlinksubtitle' to replace them and added OutputPage::addBacklinkSubtitle() to factorise common code
* Changed EditPage's view source to show "View source for <Page>" with the same backlink in subtitle for consistency with other back links and page titles

12 years agoBug 20148 - Change title of Special:Disambiguations
Antoine Musso [Tue, 8 Nov 2011 17:48:54 +0000 (17:48 +0000)]
Bug 20148 - Change title of Special:Disambiguations

Changing the english title to something more accurate.

12 years agoCast the return value of getExtraUserToggles() to an array in case it's not in the...
Roan Kattouw [Tue, 8 Nov 2011 17:20:54 +0000 (17:20 +0000)]
Cast the return value of getExtraUserToggles() to an array in case it's not in the dataCache

12 years agoFix fatal introduced in r97296. Seems to happen only after restarting memcached.
Roan Kattouw [Tue, 8 Nov 2011 17:16:07 +0000 (17:16 +0000)]
Fix fatal introduced in r97296. Seems to happen only after restarting memcached.

( ! ) Fatal error: Unsupported operand types in /srv/org/wikimedia/prototype/wikis/rl2/languages/Language.php on line 479
Call Stack
# Time Memory Function Location
1 0.0002 121976 {main}( ) ../index.php:0
2 0.0082 2959136 MediaWiki->run( ) ../index.php:58
3 0.0082 2959136 MediaWiki->main( ) ../Wiki.php:531
4 0.0082 2959136 MediaWiki->performRequest( ) ../Wiki.php:612
5 0.0165 5012424 MediaWiki->performAction( ) ../Wiki.php:252
6 0.0585 6947008 EditPage->submit( ) ../Wiki.php:506
7 0.0585 6947008 EditPage->edit( ) ../EditPage.php:360
8 0.1441 19979552 EditPage->showEditForm( ) ../EditPage.php:512
9 0.1704 22610032 EditPage->showStandardInputs( ) ../EditPage.php:1574
10 0.1778 22627752 Skin::makeInternalOrExternalUrl( ) ../EditPage.php:2046
11 0.1778 22627752 Skin::makeUrl( ) ../Skin.php:1006
12 0.1779 22627752 Skin::checkTitle( ) ../Skin.php:991
13 0.1780 22627752 Title::newFromText( ) ../Skin.php:1050
14 0.1780 22627752 Title->secureAndSplit( ) ../Title.php:148
15 0.1780 22627752 Language->getNsIndex( ) ../Title.php:2718
16 0.1781 22627752 Language->getNamespaceIds( ) ../Language.php:530
17 0.1782 22627752 Language->getNamespaceAliases( ) ../Language.php:505

12 years agotest SQL for our QueryPages objects
Antoine Musso [Tue, 8 Nov 2011 16:22:42 +0000 (16:22 +0000)]
test SQL for our QueryPages objects

Part of bug 32118: test special pages SQL queries against all supported DB

Still need to add all the other non QueryPage special pages and then setup
jenkins to support other databases.

12 years agoUse the local context instead of $wgOut, now that we have one
Alexandre Emsenhuber [Tue, 8 Nov 2011 16:06:59 +0000 (16:06 +0000)]
Use the local context instead of $wgOut, now that we have one

12 years ago* Use local context to get messages
Alexandre Emsenhuber [Tue, 8 Nov 2011 16:04:25 +0000 (16:04 +0000)]
* Use local context to get messages
* Changed three isset() to [!=]== null

12 years agocorrect typo in r102393
Antoine Musso [Tue, 8 Nov 2011 13:24:45 +0000 (13:24 +0000)]
correct typo in r102393

12 years agoadd quick comment from r102334 cr
Antoine Musso [Tue, 8 Nov 2011 12:07:45 +0000 (12:07 +0000)]
add quick comment from r102334 cr

12 years agoclean RN 1.19 of bugs merged in 1.18
Antoine Musso [Tue, 8 Nov 2011 10:54:14 +0000 (10:54 +0000)]
clean RN 1.19 of bugs merged in 1.18

bug 16428, bug 30684, bug 30907

12 years agoPrefix debug message in wfClientAcceptsGzip()
Antoine Musso [Tue, 8 Nov 2011 09:10:33 +0000 (09:10 +0000)]
Prefix debug message in wfClientAcceptsGzip()

12 years agoupdate ParserCache debug message
Antoine Musso [Tue, 8 Nov 2011 09:08:15 +0000 (09:08 +0000)]
update ParserCache debug message

"Found." was not very helpfull when indicating we found a cached
ParserOutput object.

12 years agoRemoved old, unused, MW_IMG_* constants
Aaron Schulz [Mon, 7 Nov 2011 23:24:56 +0000 (23:24 +0000)]
Removed old, unused, MW_IMG_* constants

12 years agoFollow-up r102334: odd that this minus sign (yes, copied from a diff) was actually...
Happy-melon [Mon, 7 Nov 2011 22:15:05 +0000 (22:15 +0000)]
Follow-up r102334: odd that this minus sign (yes, copied from a diff) was actually harmless.  Also explicitly define a variable that would otherwise be lazily initialised to zero but about which my IDE complains.

12 years ago(bug 31502) (follow-up r84718) Restore ToC to Special:EditWatchlist if there is more...
Happy-melon [Mon, 7 Nov 2011 22:11:04 +0000 (22:11 +0000)]
(bug 31502) (follow-up r84718) Restore ToC to Special:EditWatchlist if there is more than one namespace and more than 30 titles total (also resolves the commented TODO in the pre-r84718 code).

12 years agoFU r102073:
Aaron Schulz [Mon, 7 Nov 2011 21:54:19 +0000 (21:54 +0000)]
FU r102073:
* Added assertRepoDefined()/assertRepoTitle() functions to throw exceptions if a valid FileRepo or Title member is not set
* Fixed comment about UnregisteredLocalFile (it always sets a Title object)
* Note that $title in File constructor can be a string and that getTitle() can return false in docs

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Mon, 7 Nov 2011 20:46:13 +0000 (20:46 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years ago* Use 'new self' instead of hard-coded class name
Aaron Schulz [Mon, 7 Nov 2011 20:22:57 +0000 (20:22 +0000)]
* Use 'new self' instead of hard-coded class name
* Added constructor comment

12 years ago* Added specific page header when showing "search deleted pages" form
Alexandre Emsenhuber [Mon, 7 Nov 2011 18:30:22 +0000 (18:30 +0000)]
* Added specific page header when showing "search deleted pages" form
* Throw an exception directly instead of calling OutputPage::permissionRequired()
* Removed unreachable code paths
* Show nicer error messages when undeletion could not be executed
* Pass the subpage parameter to loadRequest() and define $mTarget and $mTargetObj there

12 years agore Bug #29283, r101507: Apply Vitaliy Filippov's followup fix:
Mark A. Hershberger [Mon, 7 Nov 2011 17:50:54 +0000 (17:50 +0000)]
re Bug #29283, r101507: Apply Vitaliy Filippov's followup fix:

    .... I've found another bug with the implementation - it also
    relies on the presence of key '...:preload' and doesn't check it
    when checking for the expired cache, which can lead to "Invalid or
    missing localisation cache" exceptions.

12 years agotests for bug 32047 / r102301
Antoine Musso [Mon, 7 Nov 2011 17:48:42 +0000 (17:48 +0000)]
tests for bug 32047 / r102301

In table with class="sortable", thead is before caption

12 years agoFix Bug #32047: in table with class="sortable", thead is before
Mark A. Hershberger [Mon, 7 Nov 2011 17:33:13 +0000 (17:33 +0000)]
Fix Bug #32047: in table with class="sortable", thead is before
caption

Apply fomafix's patch for jquery.tablesorter.js (also reported upstream:
https://forum.jquery.com/topic/in-table-with-class-sortable-thead-is-before-caption
(currently in moderation)

12 years agoAllow raw conditions on insertSelect, given that array syntax isn't always expressive...
Platonides [Mon, 7 Nov 2011 17:19:08 +0000 (17:19 +0000)]
Allow raw conditions on insertSelect, given that array syntax isn't always expressive enough (r96930)

12 years agoFix Bug #31547 - Category links need less spacing and better wrapping
Mark A. Hershberger [Mon, 7 Nov 2011 17:03:24 +0000 (17:03 +0000)]
Fix Bug #31547 - Category links need less spacing and better wrapping

Updated patch from Erwin Dokter

12 years agobug 31990 justify paragraphs pref adds extra space to category listing
Antoine Musso [Mon, 7 Nov 2011 16:46:22 +0000 (16:46 +0000)]
bug 31990 justify paragraphs pref adds extra space to category listing

When text justification is enabled in user preference, the category list
could show a large space before the first category. Overriding the element
to use left justification is enough to fix the spacing issue albeit the
categories will no more justified.

Thanks to lupo with bug 31990 comments number 8 hinting at the catlinks
element not being properly justified.

This is a regression in REL1_18 and need a backport.

12 years agobug 29110 - $wgFeedDiffCutoff doesn't affect new pages
Antoine Musso [Mon, 7 Nov 2011 16:12:37 +0000 (16:12 +0000)]
bug 29110 - $wgFeedDiffCutoff doesn't affect new pages

Patch by John Du Hart. Rewritten to avoid code duplication, duplicate
code is now in a helper function.

12 years agofix badly named variable
Antoine Musso [Mon, 7 Nov 2011 15:36:06 +0000 (15:36 +0000)]
fix badly named variable

Resource takes two S in french :D
follow up r102286

12 years agoearly returns to avoid long code in if / else
Antoine Musso [Mon, 7 Nov 2011 14:57:55 +0000 (14:57 +0000)]
early returns to avoid long code in if / else

Instead of enclosing a lot of code in a if() {} block. I reverted the logic
to exit early. That makes code a bit easier to read.

Logic was:
 if( $title->getNamespace() >= 0 && !$accErrors && $newid ) {
   // LOT OF CODE
 }
 return;

Now:
 if( $title->getNamespace() < 0 || $accErrors || !$newid ) {
   return;
 }
 // LOT OF CODE

12 years agodieout when file is a boolean
Antoine Musso [Mon, 7 Nov 2011 14:46:49 +0000 (14:46 +0000)]
dieout when file is a boolean

On file operation errors, the file variable can be assigned boolean false
which is not a valid handle. Those backtrace can help users debug an issue
when generating a filemap.

12 years agoBug 30232 - add current time to message wlnote on Special:Watchlist
Antoine Musso [Mon, 7 Nov 2011 14:20:17 +0000 (14:20 +0000)]
Bug 30232 - add current time to message wlnote on Special:Watchlist

Patch by Umherirrender. I did remove the rcnote message being used most
probably before we had support for {{PLURAL}}. So now we just rely
on the wlnote message.

As requested by Niklas, the timeanddate parameter was dropped from
original patch.

Umherirrender is already in the CREDITS file.

12 years agoRemoved useless second parameter to Title::quickUserCan()
Alexandre Emsenhuber [Mon, 7 Nov 2011 13:54:03 +0000 (13:54 +0000)]
Removed useless second parameter to Title::quickUserCan()

12 years ago* Removed existence of Title object check since not having it would make other things...
Alexandre Emsenhuber [Mon, 7 Nov 2011 13:51:40 +0000 (13:51 +0000)]
* Removed existence of Title object check since not having it would make other things crash in the same function
* Moved isArticleRelated() check one level up
* And pass the User object to Title::quickUserCan()

12 years ago* Fix checks to show whether "edit" and "addsection" tabs should be marked as active...
Alexandre Emsenhuber [Mon, 7 Nov 2011 13:42:35 +0000 (13:42 +0000)]
* Fix checks to show whether "edit" and "addsection" tabs should be marked as active so there's one, and only one active tab
* Follow-up r102192: simply call isProtect() to see if the page is protected, it also handles creation protection

12 years agoUpdate date format for dsb and hsb: month names need the genitive, make them consistent
Raimond Spekking [Mon, 7 Nov 2011 12:49:12 +0000 (12:49 +0000)]
Update date format for dsb and hsb: month names need the genitive, make them consistent
Per discussion on https://translatewiki.net/wiki/Thread:User_talk:Raymond/Formatierung_einer_Datumsvariable

12 years agoAllow for installation of php in ~/.mwphp and don't die if maintenance/dev/data alrea...
Daniel Friesen [Sun, 6 Nov 2011 23:49:16 +0000 (23:49 +0000)]
Allow for installation of php in ~/.mwphp and don't die if maintenance/dev/data already existsy

12 years agoFollowup r102201, quote all variables to guard against paths with spaces in them.
Daniel Friesen [Sun, 6 Nov 2011 23:13:36 +0000 (23:13 +0000)]
Followup r102201, quote all variables to guard against paths with spaces in them.

12 years agoCommit maintenance/dev/ a set of bash scripts that can quickly download php 5.4,...
Daniel Friesen [Sun, 6 Nov 2011 22:50:32 +0000 (22:50 +0000)]
Commit maintenance/dev/ a set of bash scripts that can quickly download php 5.4, install it in an isolated area, install a quick development copy of MediaWiki, and then start up a local webserver.

12 years agore r102027: split up long lines
Mark A. Hershberger [Sun, 6 Nov 2011 21:31:52 +0000 (21:31 +0000)]
re r102027: split up long lines

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Sun, 6 Nov 2011 20:51:20 +0000 (20:51 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoUse WikiPage instead of Article to call updateCategoryCounts()
Alexandre Emsenhuber [Sun, 6 Nov 2011 20:39:20 +0000 (20:39 +0000)]
Use WikiPage instead of Article to call updateCategoryCounts()

12 years ago* Only show "view" tabs when the user hasn't the permission to read the page and...
Alexandre Emsenhuber [Sun, 6 Nov 2011 20:30:08 +0000 (20:30 +0000)]
* Only show "view" tabs when the user hasn't the permission to read the page and put the whole stuff in a $userCanRead check instead of doing that for each check
* Factorise duplicate code (for the "protect" tab generation)
* Use Title::quickUserCan() check for delete and protect actions instead of User::isAllowed()
* Pass the User object to Title::quickUserCan()

12 years ago* Merged Title::userCanRead() check in Title::getUserPermissionsErrors()
Alexandre Emsenhuber [Sun, 6 Nov 2011 19:59:46 +0000 (19:59 +0000)]
* Merged Title::userCanRead() check in Title::getUserPermissionsErrors()
* (bug 26020) Setting $wgEmailConfirmToEdit to true no longer removes diffs from recent changes feeds
* Added second parameter to Title::userCan() and Title::quickUserCan() to allow callers to pass the User object to use for checks; this changes Title::userCan()'s second parameter from "do expensive queries" flag to User, but all callers should have been updated in r102183
* Updated callers that might throw a PermissionsError to use getUserPermissionsErrors() instead and pass the error array to the exception
* Refactored duplicate code in missingPermissionError()
* Moved Title::isNamespaceProtected() a bit upper and Title::userCanRead() near Title::userCan() to have related functions in the same location
* Some minor refactoring in permission-related functions in Title

12 years agoBug 26375 - Italics should be passed to TOC
Platonides [Sun, 6 Nov 2011 15:07:34 +0000 (15:07 +0000)]
Bug 26375 - Italics should be passed to TOC
http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=403630551#Italics_in_ToC

12 years agoDidn't we agree to use @since?
Niklas Laxström [Sun, 6 Nov 2011 12:15:28 +0000 (12:15 +0000)]
Didn't we agree to use @since?

12 years ago* Moved the language variant check inside the "not a special page" check instead...
Alexandre Emsenhuber [Sun, 6 Nov 2011 05:51:38 +0000 (05:51 +0000)]
* Moved the language variant check inside the "not a special page" check instead of doing it again after
* Moved the definition of the $session variable near where it's used

12 years agoFixed doc typo
Aaron Schulz [Sun, 6 Nov 2011 05:43:03 +0000 (05:43 +0000)]
Fixed doc typo

12 years agoMake the CliInstaller use --server to set wgServer instead of always setting it to...
Daniel Friesen [Sun, 6 Nov 2011 01:15:25 +0000 (01:15 +0000)]
Make the CliInstaller use --server to set wgServer instead of always setting it to "localhost"

12 years ago* Use local context to get messages
Alexandre Emsenhuber [Sat, 5 Nov 2011 21:06:33 +0000 (21:06 +0000)]
* Use local context to get messages
* Escape messages that were passed raw to the output

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Sat, 5 Nov 2011 21:03:17 +0000 (21:03 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years ago* Only call Title::getPageLanguage() when necessary, i.e. after "!$wgDisableLangConve...
Alexandre Emsenhuber [Sat, 5 Nov 2011 20:25:00 +0000 (20:25 +0000)]
* Only call Title::getPageLanguage() when necessary, i.e. after "!$wgDisableLangConversion && $wgCanonicalLanguageLinks" check passed
* Removed creation of Special:Recentchanges' Title object and use Title::isSpecial() instead

12 years ago* Made OuputPage::showPermissionsErrorPage() show a different messages for 'read...
Alexandre Emsenhuber [Sat, 5 Nov 2011 19:51:05 +0000 (19:51 +0000)]
* Made OuputPage::showPermissionsErrorPage() show a different messages for 'read', 'edit', 'create' and 'upload' actions to saying "You need to log in to do this action" when 1) The user is not logged in 2) The only error is a permissions error (no block or something else) and 3) The error can simply be avoided by logging in
* This replaces OuputPage::loginToUse() functionnality, made it simply throw a PermissionsEror exception and updated all calls in core
* Same for the check in SpecialUpload::execute(), EditPage::userNotLoggedInPage() and EditPage::noCreatePermission()
* Throw the same exception in EditPage::attemptSave() whether the user is logged in or not and let OuputPage::showPermissionsErrorPage() decide which message to display
* Replaced call to deprecated OutputPage::blockedPage() in SpecialUpload
* Displayed messages are the same as now, except the title is always "loginreqtitle"
* 'nocreatetitle' and 'uploadnologin' messages are still used by extensions, so I kept them, but the message 'whitelistedittitle' is not used anymore and has been removed

12 years ago* Use WikiPage instead of Article for doPurge(), getting raw wikitext and ParserCache...
Alexandre Emsenhuber [Sat, 5 Nov 2011 19:17:15 +0000 (19:17 +0000)]
* Use WikiPage instead of Article for doPurge(), getting raw wikitext and ParserCache access
* Use ParserOptions::newFromContext()

12 years ago* fixing Special:ListBots which behaved like Special:ListAdmins
Danny B [Sat, 5 Nov 2011 16:35:24 +0000 (16:35 +0000)]
* fixing Special:ListBots which behaved like Special:ListAdmins

12 years agoFollowup r100126, per brion remove htmlspecialchars() call
Sam Reed [Sat, 5 Nov 2011 14:22:58 +0000 (14:22 +0000)]
Followup r100126, per brion remove htmlspecialchars() call

Swap back a code line to use $text

Swap some space indents to tabs

12 years agoFollowup r101241, after removing @private set private modifier as they are indeed...
Sam Reed [Sat, 5 Nov 2011 14:20:00 +0000 (14:20 +0000)]
Followup r101241, after removing @private set private modifier as they are indeed private...

12 years agoPartial revert to r101244 due to next() weirdness
Sam Reed [Sat, 5 Nov 2011 14:10:50 +0000 (14:10 +0000)]
Partial revert to r101244 due to next() weirdness

12 years agoAdded title type hint to invalidateImageRedirect here too
Aaron Schulz [Sat, 5 Nov 2011 09:19:35 +0000 (09:19 +0000)]
Added title type hint to invalidateImageRedirect here too

12 years ago* Added File::normalizeTitle() function and used it to consolidate file title validit...
Aaron Schulz [Fri, 4 Nov 2011 23:49:03 +0000 (23:49 +0000)]
* Added File::normalizeTitle() function and used it to consolidate file title validity checks and sanitation. (bug 32195)
* Broke a few long lines.

12 years ago* Added some Title type hinting
Aaron Schulz [Fri, 4 Nov 2011 23:33:53 +0000 (23:33 +0000)]
* Added some Title type hinting
* Used 'self' in some class construction instances

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Fri, 4 Nov 2011 22:41:52 +0000 (22:41 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years agoWindows compat for a couple of tests :(
Max Semenik [Fri, 4 Nov 2011 20:46:04 +0000 (20:46 +0000)]
Windows compat for a couple of tests :(

12 years agoApply for Bug #31694 -- "During installation, tabbing order (cursor focus) goes to...
Mark A. Hershberger [Fri, 4 Nov 2011 18:47:14 +0000 (18:47 +0000)]
Apply for Bug #31694 -- "During installation, tabbing order (cursor focus) goes to logo instead of 'continue'"
Patch From: Grunny

12 years agoApply patch from Bug #12262 -- "Indents and lists don't align"
Mark A. Hershberger [Fri, 4 Nov 2011 18:39:30 +0000 (18:39 +0000)]
Apply patch from Bug #12262 -- "Indents and lists don't align"

12 years agoSome cleanup to EditPage:
Alexandre Emsenhuber [Fri, 4 Nov 2011 18:35:25 +0000 (18:35 +0000)]
Some cleanup to EditPage:
* Added displayPermissionsError() to show the permissions error page with the content if there's content to show or it will throw an normal exception if there's nothing to display; this restores a functionnality lost at some point and added new message 'viewyourtext' that is displayed when the user made changes to the content (e.g. when the block happens while the user is editing the page)
* Marked EditPage::readOnlyPage() as deprecated since displayPermissionsError() is now used. This also means that OutputPage::readOnlyPage() is no longer used to display such error pages (but still have to keep that functionnality since it's used by extensions, same for EditPage::readOnlyPage(), *sigh*)
* Removed blockedPage()'s display of content since it's nearly never called (a blocked user would trigger the path mentionned above, not the check in internalAttemptSave()) and also removed 'blockedoriginalsource' and 'blockededitsource' messages that are no longer used
* Use OutputPage::prepareErrorPage() to prepare error pages instead of doing all that stuff directly
* Moved noCreatePermission() near other error-related functions
* Throw an exception directly in attemptSave() instead of calling deprecated methods and marked noCreatePermission() and blockedPage() as deprecated

12 years agoAnd while I'm at it, move token check to onView() so that if action=markpatrolled...
Alexandre Emsenhuber [Fri, 4 Nov 2011 16:40:00 +0000 (16:40 +0000)]
And while I'm at it, move token check to onView() so that if action=markpatrolled is called without parameters, the user will see 'markedaspatrollederror' error and not 'sessionfailure'

12 years agoUpdated docs for r101896
Aaron Schulz [Fri, 4 Nov 2011 15:05:00 +0000 (15:05 +0000)]
Updated docs for r101896

12 years agoFixes Bug #31722 — “ugly old toolbar icons - height inconsistent” —
Mark A. Hershberger [Fri, 4 Nov 2011 13:21:32 +0000 (13:21 +0000)]
Fixes Bug #31722 — “ugly old toolbar icons - height inconsistent” —
patch from diebuche.

12 years agoeol w/s
Mark A. Hershberger [Fri, 4 Nov 2011 13:08:44 +0000 (13:08 +0000)]
eol w/s

12 years agoFix history versions
Sam Reed [Fri, 4 Nov 2011 11:53:22 +0000 (11:53 +0000)]
Fix history versions

12 years ago1.17 -> 1.18
Sam Reed [Fri, 4 Nov 2011 11:51:06 +0000 (11:51 +0000)]
1.17 -> 1.18

12 years ago* fixed ipblocks.ipb_by_text field, removed default blank not null (fixed install...
Jure Kajzer [Fri, 4 Nov 2011 11:35:10 +0000 (11:35 +0000)]
* fixed ipblocks.ipb_by_text field, removed default blank not null (fixed install&update)
* fixed Block->insert; ipblocks.ipb_id is autoincrement field (should use sequences for compatibility)

12 years agoUse WikiPage instead of Article to call the hasViewableContent() method
Alexandre Emsenhuber [Fri, 4 Nov 2011 08:58:10 +0000 (08:58 +0000)]
Use WikiPage instead of Article to call the hasViewableContent() method

12 years ago* fixed a typo in oracle/tables.sql
Jure Kajzer [Fri, 4 Nov 2011 07:17:13 +0000 (07:17 +0000)]
* fixed a typo in oracle/tables.sql
* readded the sha1 fields (installer & upgrader)

12 years agoPer Platonides, fix for r101630: correct class name
Alexandre Emsenhuber [Fri, 4 Nov 2011 06:59:36 +0000 (06:59 +0000)]
Per Platonides, fix for r101630: correct class name

12 years agoRemoved debug code from r101944
Aaron Schulz [Fri, 4 Nov 2011 01:56:51 +0000 (01:56 +0000)]
Removed debug code from r101944

12 years agoPartial revert of r101912 -- restores r99315 'includexmlnamespace' parameter for...
Brion Vibber [Fri, 4 Nov 2011 01:31:15 +0000 (01:31 +0000)]
Partial revert of r101912 -- restores r99315 'includexmlnamespace' parameter for API, but keeps the logic to keep that from clobbering alternate XML output formats with their own namespaces.

12 years agoalpha -> beta
Sam Reed [Fri, 4 Nov 2011 01:28:52 +0000 (01:28 +0000)]
alpha -> beta

Merge RELEASE-NOTES changes

12 years agoDocumentation
Sam Reed [Fri, 4 Nov 2011 01:00:06 +0000 (01:00 +0000)]
Documentation

Fix mime-type on image

12 years agoResync 1.18 RELEASE-NOTES files
Sam Reed [Fri, 4 Nov 2011 00:59:11 +0000 (00:59 +0000)]
Resync 1.18 RELEASE-NOTES files

12 years agoAdd Central Dusun language code to RELEASE-NOTES-1.18
Sam Reed [Fri, 4 Nov 2011 00:32:45 +0000 (00:32 +0000)]
Add Central Dusun language code to RELEASE-NOTES-1.18

12 years ago* (bug 31878, bug 31542) Fix XML namespace output in API; removed now-unneeded includ...
Brion Vibber [Thu, 3 Nov 2011 23:14:58 +0000 (23:14 +0000)]
* (bug 31878, bug 31542) Fix XML namespace output in API; removed now-unneeded includexmlnamespace parameter.

Any existing uses of includexmlnamespace should be ignored and harmless.

If output data already includes a specific default namespace as an xmlns attribute, it is now retained -- so for example the RSD API discovery module outputs the appropriate namespace instead of the generic API one.

Partial revert of r99135 which added the includexmlnamespace parameter as a temporary requirement to get the xmlns attribute included.

Followup to r88007 which added the xmlns originally, but in the wrong order so it overrode existing output data.

12 years agoFollow-up r101808. Use canonical class name.
Platonides [Thu, 3 Nov 2011 22:58:16 +0000 (22:58 +0000)]
Follow-up r101808. Use canonical class name.

12 years agoFU r96015: removed & in MakeGlobalVariablesScript hook
Aaron Schulz [Thu, 3 Nov 2011 22:21:19 +0000 (22:21 +0000)]
FU r96015: removed & in MakeGlobalVariablesScript hook

12 years agoeol w/s
Mark A. Hershberger [Thu, 3 Nov 2011 21:22:34 +0000 (21:22 +0000)]
eol w/s

12 years agoBug 28172 - wfGetDB called when it shouldn't be
OverlordQ [Thu, 3 Nov 2011 21:00:14 +0000 (21:00 +0000)]
Bug 28172 - wfGetDB called when it shouldn't be

12 years agoFix fixme on r101177
Sam Reed [Thu, 3 Nov 2011 20:55:57 +0000 (20:55 +0000)]
Fix fixme on r101177

12 years agoWhoops, need a !
Chad Horohoe [Thu, 3 Nov 2011 20:17:49 +0000 (20:17 +0000)]
Whoops, need a !

12 years agoLocalisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Thu, 3 Nov 2011 20:16:37 +0000 (20:16 +0000)]
Localisation updates for core and extension messages from translatewiki.net

12 years ago*grumble grumble* know it alls think I'm abusing $wgMiserMode. So fine, have a SHINY...
Chad Horohoe [Thu, 3 Nov 2011 20:15:27 +0000 (20:15 +0000)]
*grumble grumble* know it alls think I'm abusing $wgMiserMode. So fine, have a SHINY NEW GLOBAL INSTEAD. bug 32072, r92109, yada-yada.

This is not a "useless" error message, regardless of what the bug claims.

12 years agoFix for r101858: forgot the override those methods
Alexandre Emsenhuber [Thu, 3 Nov 2011 19:25:30 +0000 (19:25 +0000)]
Fix for r101858: forgot the override those methods

12 years agobug 32183: remove the client-* classes added from user-agent-sniffing onto the <html...
Brion Vibber [Thu, 3 Nov 2011 19:18:49 +0000 (19:18 +0000)]
bug 32183: remove the client-* classes added from user-agent-sniffing onto the <html> element.

Browser sniffing is bad, and having these here encourages unpleasantness.
Keeping the js/nojs ones as those are useful and non-evil (they're an example of feature detection, exposed via CSS here rather than through JS.)