From: Bartosz DziewoƄski Date: Mon, 2 Mar 2020 16:08:15 +0000 (+0100) Subject: SECURITY: jquery.makeCollapsible: Escape user-generated CSS selectors X-Git-Tag: 1.31.7~1 X-Git-Url: http://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=91e63a1332fb589f8f3cc47b4466f24943aa8bd4 SECURITY: jquery.makeCollapsible: Escape user-generated CSS selectors Bug: T246602 Change-Id: Iea64a258499ab597b9a8900418a42162fdb5f391 --- diff --git a/resources/src/jquery/jquery.makeCollapsible.js b/resources/src/jquery/jquery.makeCollapsible.js index 1f40e0a2b7..a433497506 100644 --- a/resources/src/jquery/jquery.makeCollapsible.js +++ b/resources/src/jquery/jquery.makeCollapsible.js @@ -279,6 +279,7 @@ } else { collapsibleId = $collapsible.attr( 'id' ) || ''; if ( collapsibleId.indexOf( 'mw-customcollapsible-' ) === 0 ) { + collapsibleId = $.escapeSelector( collapsibleId ); $customTogglers = $( '.' + collapsibleId.replace( 'mw-customcollapsible', 'mw-customtoggle' ) ) .addClass( 'mw-customtoggle' ); }