From: Jack Phoenix <ashley@uncyclomedia.co>
Date: Tue, 5 Mar 2019 23:13:59 +0000 (+0200)
Subject: Fix a rather fatal typo in rebuildrecentchanges.php
X-Git-Tag: 1.31.2~26
X-Git-Url: http://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=0e052c816b21e38096d4c6d747a9beadb9d0d575

Fix a rather fatal typo in rebuildrecentchanges.php

The JOIN condition was being ignored because there is no table called "user_group" in MediaWiki core.
Thus if and when using $wgSharedDB, the query would end up listing *all* registered users from the shared user table.
And even without $wgSharedDB, running rebuildrecentchanges.php would result in everyone's edits being marked as bot edits (recentchanges.rc_bot = 1) and thus hidden from the Special:RecentChanges page.

Thanks to Lcawte for reporting this bug.

Follow-up to 27c61fb1e94da9114314468fd00bcf129ec064b6

Change-Id: I18d658b67c50f2200341f732783c2e7524dd27f1
---

diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index 1a66001cb8..d3b37621c4 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -59,6 +59,7 @@ THIS IS NOT A RELEASE YET
 * (T216968) Return pageid as int in both list=iwbacklinks and list=langbacklinks.
 * (T215169) Fix for Database::update() with IGNORE option fails on PostgreSQL.
 * (T204423) Backport support for hyphenated DB names in JobQueueGroup.
+* Fix typo in rebuildrecentchanges.php resulting in rogue bot flags.
 
 == MediaWiki 1.31.1 ==
 
diff --git a/maintenance/rebuildrecentchanges.php b/maintenance/rebuildrecentchanges.php
index a259484f7f..cbbe714975 100644
--- a/maintenance/rebuildrecentchanges.php
+++ b/maintenance/rebuildrecentchanges.php
@@ -373,7 +373,7 @@ class RebuildRecentchanges extends Maintenance {
 				[ 'ug_group' => $botgroups ],
 				__METHOD__,
 				[ 'DISTINCT' ],
-				[ 'user_group' => [ 'JOIN', 'user_id = ug_user' ] ] + $userQuery['joins']
+				[ 'user_groups' => [ 'JOIN', 'user_id = ug_user' ] ] + $userQuery['joins']
 			);
 
 			$botusers = [];