From: Ammar Abdulhamid <ammarpad@yahoo.com>
Date: Sun, 13 Oct 2019 10:25:20 +0000 (+0100)
Subject: Deprecate 'jquery.tabIndex' module
X-Git-Tag: 1.34.0-rc.1~20
X-Git-Url: http://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=commitdiff_plain;h=04cea76cbbd1c66ddfa2a674cf383ffb497234ae

Deprecate 'jquery.tabIndex' module

Bug: T234581
Change-Id: I8e1b43ae17b2bdd90f5ce7f0a4907cf94f759b8d
---

diff --git a/RELEASE-NOTES-1.34 b/RELEASE-NOTES-1.34
index 4cf982d59f..e9101b3e30 100644
--- a/RELEASE-NOTES-1.34
+++ b/RELEASE-NOTES-1.34
@@ -595,6 +595,7 @@ because of Phabricator reports.
 * Specifying a SpecialPage object for the list of special pages (either through
   the SpecialPage_initList hook or by adding to $wgSpecialPages) is now
   deprecated.
+* The 'jquery.tabIndex' module is deprecated.
 * WebInstaller::getInfoBox(), getWarningBox() and getErrorBox() are deprecated.
   Use Html::errorBox() or Html::warningBox() instead.
 * Use of ActorMigration with 'ar_user', 'img_user', 'oi_user', 'fa_user',
diff --git a/resources/Resources.php b/resources/Resources.php
index 9354435d58..92a98051ac 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -268,6 +268,7 @@ return [
 		'dependencies' => 'jquery.highlightText',
 	],
 	'jquery.tabIndex' => [
+		'deprecated' => true,
 		'scripts' => 'resources/src/jquery/jquery.tabIndex.js',
 	],
 	'jquery.tablesorter' => [
diff --git a/tests/qunit/QUnitTestResources.php b/tests/qunit/QUnitTestResources.php
index a3a165f0a2..e4e899af52 100644
--- a/tests/qunit/QUnitTestResources.php
+++ b/tests/qunit/QUnitTestResources.php
@@ -50,7 +50,6 @@ return [
 			'tests/qunit/suites/resources/jquery/jquery.highlightText.test.js',
 			'tests/qunit/suites/resources/jquery/jquery.lengthLimit.test.js',
 			'tests/qunit/suites/resources/jquery/jquery.makeCollapsible.test.js',
-			'tests/qunit/suites/resources/jquery/jquery.tabIndex.test.js',
 			'tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js',
 			'tests/qunit/suites/resources/jquery/jquery.tablesorter.parsers.test.js',
 			'tests/qunit/suites/resources/jquery/jquery.textSelection.test.js',
@@ -106,7 +105,6 @@ return [
 			'jquery.highlightText',
 			'jquery.lengthLimit',
 			'jquery.makeCollapsible',
-			'jquery.tabIndex',
 			'jquery.tablesorter',
 			'jquery.textSelection',
 			'mediawiki.api',
diff --git a/tests/qunit/suites/resources/jquery/jquery.tabIndex.test.js b/tests/qunit/suites/resources/jquery/jquery.tabIndex.test.js
deleted file mode 100644
index 220771b14d..0000000000
--- a/tests/qunit/suites/resources/jquery/jquery.tabIndex.test.js
+++ /dev/null
@@ -1,35 +0,0 @@
-( function () {
-	QUnit.module( 'jquery.tabIndex', QUnit.newMwEnvironment() );
-
-	QUnit.test( 'firstTabIndex', function ( assert ) {
-		var html, $testA, $testB;
-		html = '<form>' +
-			'<input tabindex="7" />' +
-			'<input tabindex="9" />' +
-			'<textarea tabindex="2">Foobar</textarea>' +
-			'<textarea tabindex="5">Foobar</textarea>' +
-			'</form>';
-
-		$testA = $( '<div>' ).html( html ).appendTo( '#qunit-fixture' );
-		assert.strictEqual( $testA.firstTabIndex(), 2, 'First tabindex should be 2 within this context.' );
-
-		$testB = $( '<div>' );
-		assert.strictEqual( $testB.firstTabIndex(), null, 'Return null if none available.' );
-	} );
-
-	QUnit.test( 'lastTabIndex', function ( assert ) {
-		var html, $testA, $testB;
-		html = '<form>' +
-			'<input tabindex="7" />' +
-			'<input tabindex="9" />' +
-			'<textarea tabindex="2">Foobar</textarea>' +
-			'<textarea tabindex="5">Foobar</textarea>' +
-			'</form>';
-
-		$testA = $( '<div>' ).html( html ).appendTo( '#qunit-fixture' );
-		assert.strictEqual( $testA.lastTabIndex(), 9, 'Last tabindex should be 9 within this context.' );
-
-		$testB = $( '<div>' );
-		assert.strictEqual( $testB.lastTabIndex(), null, 'Return null if none available.' );
-	} );
-}() );