Only link local titles on Special:Search

Anything else is confusing, especially given the message text
we have there.

Example:
https://www.mediawiki.org/wiki/Special:Search?search=en%3Afoo&fulltext=1

Also fix the documentation of Title::isLocal as that was misleading
and fooled me (in PS1).

Change-Id: Iccb69de4c7243bf144a12deb8b86505e56a111dd

diff --git a/includes/Title.php b/includes/Title.php
index e8cda85..c570633 100644 (file)
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -795,7 +795,8 @@ class Title {
 
        /**
         * Determine whether the object refers to a page within
-        * this project.
+        * this project (either this wiki or a wiki with a local
+        * interwiki, see https://www.mediawiki.org/wiki/Manual:Interwiki_table#iw_local )
         *
         * @return bool True if this is an in-project interwiki link or a wikilink, false otherwise
         */

diff --git a/includes/specials/SpecialSearch.php b/includes/specials/SpecialSearch.php
index c922fbd..a139740 100644 (file)
--- a/includes/specials/SpecialSearch.php
+++ b/includes/specials/SpecialSearch.php
@@ -426,15 +426,18 @@ class SpecialSearch extends SpecialPage {
                        return;
                }
 
+               $messageName = 'searchmenu-new-nocreate';
                $linkClass = 'mw-search-createlink';
-               if ( $title->isKnown() ) {
-                       $messageName = 'searchmenu-exists';
-                       $linkClass = 'mw-search-exists';
-               } elseif ( $title->quickUserCan( 'create', $this->getUser() ) ) {
-                       $messageName = 'searchmenu-new';
-               } else {
-                       $messageName = 'searchmenu-new-nocreate';
+
+               if ( !$title->isExternal() ) {
+                       if ( $title->isKnown() ) {
+                               $messageName = 'searchmenu-exists';
+                               $linkClass = 'mw-search-exists';
+                       } elseif ( $title->quickUserCan( 'create', $this->getUser() ) ) {
+                               $messageName = 'searchmenu-new';
+                       }
                }
+
                $params = array(
                        $messageName,
                        wfEscapeWikiText( $title->getPrefixedText() ),