Remove completely useless implementation of getInfo()
authorChad Horohoe <chadh@wikimedia.org>
Wed, 19 Mar 2014 16:35:23 +0000 (09:35 -0700)
committerChad <chadh@wikimedia.org>
Wed, 19 Mar 2014 20:20:31 +0000 (20:20 +0000)
Embedding random strings in Special:Search's comments doesn't
help debugging and just increases page size.

Bug: 62768
Change-Id: I51270aa3f2cba921841e2d8ebbd4fa665542f8a9

includes/search/SearchResultSet.php
includes/specials/SpecialSearch.php

index 3c6c8d0..e689389 100644 (file)
@@ -88,16 +88,6 @@ class SearchResultSet {
                return '';
        }
 
-       /**
-        * Return information about how and from where the results were fetched,
-        * should be useful for diagnostics and debugging
-        *
-        * @return String
-        */
-       function getInfo() {
-               return null;
-       }
-
        /**
         * Return a result set of hits on other (multiple) wikis associated with this one
         *
index 3659c48..ffe88f7 100644 (file)
@@ -538,12 +538,7 @@ class SpecialSearch extends SpecialPage {
 
                $terms = $wgContLang->convertForSearchResult( $matches->termMatches() );
 
-               $out = "";
-               $infoLine = $matches->getInfo();
-               if ( !is_null( $infoLine ) ) {
-                       $out .= "\n<!-- {$infoLine} -->\n";
-               }
-               $out .= "<ul class='mw-search-results'>\n";
+               $out = "<ul class='mw-search-results'>\n";
                $result = $matches->next();
                while ( $result ) {
                        $out .= $this->showHit( $result, $terms );