Merge "Add 'autocomplete' option to HTMLTextField"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 18 Nov 2016 18:41:16 +0000 (18:41 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 18 Nov 2016 18:41:16 +0000 (18:41 +0000)
1  2 
includes/htmlform/fields/HTMLAutoCompleteSelectField.php
includes/htmlform/fields/HTMLTextField.php

   *   other-message - Message to use instead of htmlform-selectorother-other for
   *      the 'other' message.
   *   other - Raw text to use for the 'other' message
+  *
+  * The old name of autocomplete-data[-messages] was autocomplete[-messages] which is still
+  * recognized but deprecated since MediaWiki 1.29 since it conflicts with how autocomplete is
+  * used in HTMLTextField.
   */
  class HTMLAutoCompleteSelectField extends HTMLTextField {
-       protected $autocomplete = [];
+       protected $autocompleteData = [];
  
 -      function __construct( $params ) {
 +      public function __construct( $params ) {
                $params += [
                        'require-match' => false,
                ];