Rearrange code in User::getBlockedStatus to avoid isAllowed calls
authorGergő Tisza <tgr.huwiki@gmail.com>
Thu, 21 Mar 2019 16:00:49 +0000 (09:00 -0700)
committerReedy <reedy@wikimedia.org>
Thu, 21 Mar 2019 18:54:41 +0000 (18:54 +0000)
commitfe7ffa24f5228ac2a58689bef8c9e1c5bf6838ee
tree1f27956acc5a7d7a1facc1d8427a56563b0b35d5
parent61a7a5463de9c4d1073f3c0fd17b35b797923c2d
Rearrange code in User::getBlockedStatus to avoid isAllowed calls

User::isAllowed() triggers session loading, which results in a loop
if it is called during session loading. Session providers need to
check block status when $wgBlockDisablesLogin is enabled, so try to
avoid isAllowed calls in that situation.

Bug: T218608
Change-Id: Iab24923c613d6aeed4b574f587fc4cee8f33077c
RELEASE-NOTES-1.31
includes/user/User.php