The war on redundant ampersand usage!
authorNick Jenkins <nickj@users.mediawiki.org>
Mon, 22 Jan 2007 23:50:42 +0000 (23:50 +0000)
committerNick Jenkins <nickj@users.mediawiki.org>
Mon, 22 Jan 2007 23:50:42 +0000 (23:50 +0000)
commitf88c771756c580442fe7ca2f84bcbb8067b77f57
treedb64f75bd493add62d5fa9f4b47de778dc452aca
parent50d9a5ec18cd1e952433b9ee1f22bf04916d1537
The war on redundant ampersand usage!
* Convert "$dbw =& wfGetDB( DB_MASTER );" --> "$dbw = wfGetDB( DB_MASTER );"
* convert "$skin =& $wgUser->getSkin();" --> "$skin = $wgUser->getSkin();"

For the time being have not changed the function definitions of wfGetDB() or User::getSkin() [i.e. they are still both return-by-ref], so as to ensure the interface does not change for extensions [some of which may still be trying to run on PHP4 environments]. However presumably at some point this can be changed too.

Also includes tiny tweak to newlines in parserTests - will show 1 rather than 2 newlines between the "Reading tests from" strings when in quiet mode.
156 files changed:
includes/AjaxFunctions.php
includes/Article.php
includes/BagOStuff.php
includes/Block.php
includes/CacheDependency.php
includes/CategoryPage.php
includes/Categoryfinder.php
includes/ChangesList.php
includes/DatabaseFunctions.php
includes/EditPage.php
includes/HTMLCacheUpdate.php
includes/HistoryBlob.php
includes/Image.php
includes/ImageGallery.php
includes/ImagePage.php
includes/JobQueue.php
includes/LinkBatch.php
includes/LinkCache.php
includes/Linker.php
includes/LinksUpdate.php
includes/LogPage.php
includes/Math.php
includes/MessageCache.php
includes/OutputPage.php
includes/PageHistory.php
includes/Parser.php
includes/ParserOptions.php
includes/Profiler.php
includes/QueryPage.php
includes/RecentChange.php
includes/Revision.php
includes/SearchMySQL.php
includes/SearchMySQL4.php
includes/SearchPostgres.php
includes/SearchTsearch2.php
includes/SiteStats.php
includes/Skin.php
includes/SkinTemplate.php
includes/SpecialAllmessages.php
includes/SpecialAllpages.php
includes/SpecialAncientpages.php
includes/SpecialBrokenRedirects.php
includes/SpecialCategories.php
includes/SpecialContributions.php
includes/SpecialDeadendpages.php
includes/SpecialDisambiguations.php
includes/SpecialDoubleRedirects.php
includes/SpecialExport.php
includes/SpecialImagelist.php
includes/SpecialImport.php
includes/SpecialListredirects.php
includes/SpecialListusers.php
includes/SpecialLog.php
includes/SpecialLonelypages.php
includes/SpecialMIMEsearch.php
includes/SpecialMostcategories.php
includes/SpecialMostimages.php
includes/SpecialMostlinked.php
includes/SpecialMostlinkedcategories.php
includes/SpecialMostrevisions.php
includes/SpecialNewimages.php
includes/SpecialNewpages.php
includes/SpecialPopularpages.php
includes/SpecialPrefixindex.php
includes/SpecialRandompage.php
includes/SpecialRandomredirect.php
includes/SpecialRecentchanges.php
includes/SpecialRecentchangeslinked.php
includes/SpecialSearch.php
includes/SpecialShortpages.php
includes/SpecialStatistics.php
includes/SpecialUncategorizedimages.php
includes/SpecialUncategorizedpages.php
includes/SpecialUnusedcategories.php
includes/SpecialUnusedimages.php
includes/SpecialUnusedtemplates.php
includes/SpecialUnwatchedpages.php
includes/SpecialUpload.php
includes/SpecialUserlogin.php
includes/SpecialVersion.php
includes/SpecialWantedcategories.php
includes/SpecialWantedpages.php
includes/SpecialWatchlist.php
includes/SpecialWhatlinkshere.php
includes/SquidUpdate.php
includes/Title.php
includes/User.php
includes/UserMailer.php
includes/WatchedItem.php
includes/Wiki.php
includes/api/ApiPageSet.php
includes/api/ApiQuery.php
includes/api/ApiQueryAllpages.php
includes/api/ApiQueryBacklinks.php
includes/api/ApiQueryLogEvents.php
includes/api/ApiQueryRecentChanges.php
includes/api/ApiQueryRevisions.php
includes/api/ApiQueryUserContributions.php
install-utils.inc
maintenance/addwiki.php
maintenance/attachLatest.php
maintenance/attribute.php
maintenance/backup.inc
maintenance/changePassword.php
maintenance/checkUsernames.php
maintenance/cleanupDupes.inc
maintenance/cleanupSpam.php
maintenance/cleanupTitles.php
maintenance/cleanupWatchlist.php
maintenance/clear_interwiki_cache.php
maintenance/convertLinks.inc
maintenance/deleteBatch.php
maintenance/deleteDefaultMessages.php
maintenance/deleteImageMemcached.php
maintenance/deleteOldRevisions.inc
maintenance/deleteOrphanedRevisions.php
maintenance/deleteRevision.php
maintenance/dumpHTML.inc
maintenance/dumpHTML.php
maintenance/dumpLinks.php
maintenance/dumpReplayLog.php
maintenance/fixSlaveDesync.php
maintenance/fixTimestamps.php
maintenance/fixUserRegistration.php
maintenance/generateSitemap.php
maintenance/importLogs.inc
maintenance/moveBatch.php
maintenance/namespaceDupes.php
maintenance/nukeNS.php
maintenance/nukePage.inc
maintenance/orphans.php
maintenance/parserTests.inc
maintenance/purgeOldText.inc
maintenance/reassignEdits.inc.php
maintenance/rebuildInterwiki.inc
maintenance/rebuildrecentchanges.inc
maintenance/refreshImageCount.php
maintenance/refreshLinks.inc
maintenance/removeUnusedAccounts.inc
maintenance/removeUnusedAccounts.php
maintenance/runJobs.php
maintenance/showJobs.php
maintenance/showStats.php
maintenance/storage/checkStorage.php
maintenance/storage/compressOld.inc
maintenance/storage/dumpRev.php
maintenance/storage/moveToExternal.php
maintenance/storage/resolveStubs.php
maintenance/updateArticleCount.inc.php
maintenance/updateArticleCount.php
maintenance/updateSearchIndex.inc
maintenance/updateSpecialPages.php
maintenance/userDupes.php
skins/disabled/HTMLDump.php
skins/disabled/MonoBookCBT.php
trackback.php